[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-487284735 Update the PR to remove the `visitWindow` method in `RexCopier`. Thanks for your review, @zabetak This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-487137129 @zabetak any other comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-485817334 @zabetak, I updated the PR using `super.visitWindow(window)`. Could you please review again? Thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-485650820 @zabetak I modified the tests to verify that the `RexCopier` works correctly. Please review it again. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-485344172 @zabetak Any comments? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-483975946 > Overall, it looks good but I will do another more careful pass in the following days ;) Sure. Appreciate it : ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
