[GitHub] [calcite] wenhuitang edited a comment on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLib

2020-03-25 Thread GitBox 
wenhuitang edited a comment on issue #1862: [CALCITE-3864] Add Implementation 
for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return 
type inference of SqlLibraryOperators.CONCAT_FUNCTION
URL: https://github.com/apache/calcite/pull/1862#issuecomment-603669239
 
 
   > (1)In Oracle, `concat` function accepts only two operands. In 
`SqlLibraryOperators`, We'd better seperate the `CONCAT_FUNCTION` into 
`CONCAT_FUNCTION` and `ORACLE_CONCAT_FUNCTION`. For `ORACLE_CONCAT_FUNCTION`, 
we can use `SqlOperandCountRanges.of(2)` to enable the constraint.
   
   How about seperate the `CONCAT_FUNCTION` into `CONCAT_FUNCTION`  which uses  
SqlOperandCountRanges.from(3) and `CONCAT2` which uses 
`SqlOperandCountRanges.of(2)`? And the libraries for  `CONCAT_FUNCTION` are PG 
and MySql. The libraries for `CONCAT2` are Oracle, PG and MySQL .Since 
currently `CONCAT_FUNCTION`  which use SqlOperandCountRanges.from(2) contains 
the case of concat2 that may lead to confusion.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] wenhuitang edited a comment on issue #1862: [CALCITE-3864] Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLib

2020-03-24 Thread GitBox 
wenhuitang edited a comment on issue #1862: [CALCITE-3864] Add Implementation 
for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return 
type inference of SqlLibraryOperators.CONCAT_FUNCTION
URL: https://github.com/apache/calcite/pull/1862#issuecomment-603174424
 
 
   > hi @wenhuitang In addition, you need to add function docs.
   
   The description of CONCAT(string [, string ]*)  has already existed in Line 
2325 of the document reference.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services