wnob opened a new pull request, #2973:
URL: https://github.com/apache/calcite/pull/2973

   There is an existing implementation for a BQ `DATE` function but it wrongly 
thinks this is simply a typecast. See documentation [here][1].
   
   This PR implements 2 of the 4 possible overloads for `DATE` (considering the 
optional time zone in the second form) as well as 1 of the possible overloads 
for `TIMESTAMP`, and was able to get a quidem test to pass utilizing both 
functions. I intend to implement the rest of the overloads in a follow-up 
commit but was hoping for some feedback now and thought this was a decent-sized 
commit to review at once.
   
   [1]: 
https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#date


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to