zabetak commented on code in PR #2988: URL: https://github.com/apache/calcite/pull/2988#discussion_r1034587984
########## site/_docs/howto.md: ########## @@ -841,6 +841,8 @@ your key to the keyservers used by Nexus, see above. that the `META-INF` directory contains `LICENSE`, `NOTICE` * Check PGP, per [this](https://httpd.apache.org/dev/verification.html) +* Check that Proj4J is not among the api and implementation dependencies, Review Comment: We could enforce this with a new CI job as well. Not necessary to do it now but maybe worth considering as a follow-up. ########## core/build.gradle.kts: ########## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") + api("org.locationtech.jts:jts-core") + api("org.locationtech.jts.io:jts-io-common") + compileOnly("org.locationtech.proj4j:proj4j") + testImplementation("org.locationtech.proj4j:proj4j") Review Comment: `testImplementation` means that we need it in the compile and runtime classpath for tests; is this true? If we can use `testRuntimeOnly` I think it would be better. ########## core/build.gradle.kts: ########## @@ -57,6 +54,11 @@ dependencies { api("org.checkerframework:checker-qual") api("org.slf4j:slf4j-api") + api("org.locationtech.jts:jts-core") + api("org.locationtech.jts.io:jts-io-common") + compileOnly("org.locationtech.proj4j:proj4j") + testImplementation("org.locationtech.proj4j:proj4j") Review Comment: Moreover, consider moving it closer to other dependencies in the same group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
