[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3310: Graceful shutdown strategy used as default one
JiriOndrusek commented on pull request #3310: URL: https://github.com/apache/camel-quarkus/pull/3310#issuecomment-975227826 @aldettinger documentation is added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch regen_bot updated (2ec8a1b -> 7f6b0dc)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. omit 2ec8a1b Regen for commit 18ee7705c8f6b9c8071bab6f6384571dab3b7ce7 add 7f6b0dc Regen for commit 18ee7705c8f6b9c8071bab6f6384571dab3b7ce7 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (2ec8a1b) \ N -- N -- N refs/heads/regen_bot (7f6b0dc) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
[GitHub] [camel-quarkus] aldettinger commented on pull request #3310: Graceful shutdown strategy used as default one
aldettinger commented on pull request #3310: URL: https://github.com/apache/camel-quarkus/pull/3310#issuecomment-975258237 The migration guide is definitely the right place. We could merge this PR from my point of view :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] Croway opened a new pull request #6459: [CAMEL-17216] Allow to include properties file
Croway opened a new pull request #6459: URL: https://github.com/apache/camel/pull/6459 Hi, properties file can be added via --properties option, for example ``` jbang -Dcamel.jbang.version=3.14.0 CamelJBang@apache/camel run github:apache:camel-k:examples/languages/routes.yaml --properties /path/to/application.properties ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] squakez closed issue #2762: How can I find the log file location in the integration pod?
squakez closed issue #2762: URL: https://github.com/apache/camel-k/issues/2762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #2762: How can I find the log file location in the integration pod?
squakez commented on issue #2762: URL: https://github.com/apache/camel-k/issues/2762#issuecomment-975301641 I've just answered to the the post in SO, I see also @nicolaferraro provided the same information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli opened a new pull request #755: cq 2.5.0
lburgazzoli opened a new pull request #755: URL: https://github.com/apache/camel-k-runtime/pull/755 - deps: update to camel-quarkus 2.4.0 - fix: move tests classes to a dedicate package to avoid split package warning - deps: update camel-quarkus to v2.5.0 **Release Note** ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #2762: How can I find the log file location in the integration pod?
astefanutti commented on issue #2762: URL: https://github.com/apache/camel-k/issues/2762#issuecomment-975306288 > Where is the log file location in the integration pod? Generally, containers write to `stdout` or `stderr`. That is the case for integration Pods, that rely on the [Quarkus console log handler](https://quarkus.io/guides/logging#console-log-handler) by default. Then it depends on the container runtime that's setup for your cluster. With CRI-O, the log files are written in the `/var/log/pods` directory of the host node by default. It's `/var/lib/docker/containers` for the Docker container runtime. You can access this directory by accessing the node where the Pod is schedule, but it's also possible to mount the directory into a Pod. > How can I specify log file location If I want to log certain lines into a separated log file? You can configure the [Quarkus file log handler](https://quarkus.io/guides/logging#quarkus-log-logging-log-config_quarkus.log.file-file-logging), e.g.: ``` $ kamel run -p quarkus.log.file.enable=true -p quarkus.log.file.path=/tmp/trace.log ``` Some examples of Quarkus logging configuration are available at https://quarkus.io/guides/logging#examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli opened a new pull request #756: chore: remove staging maven repo
lburgazzoli opened a new pull request #756: URL: https://github.com/apache/camel-k-runtime/pull/756 **Release Note** ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3315: Apache Drill Unable to start
jamesnetherton commented on issue #3315: URL: https://github.com/apache/camel-quarkus/issues/3315#issuecomment-975307152 I'm no expert with Drill, but I don't think creating a `DataSource` is the way to work with the camel-drill component. Take a look at the documentation: https://camel.apache.org/components/3.13.x/drill-component.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli opened a new issue #2763: Implement gosec to inspect source code for security problems
lburgazzoli opened a new issue #2763: URL: https://github.com/apache/camel-k/issues/2763 We should add [gosec](https://github.com/securego/gosec) to inspect source code for security problems -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #2763: Implement gosec to inspect source code for security problems
lburgazzoli commented on issue #2763: URL: https://github.com/apache/camel-k/issues/2763#issuecomment-975322731 /cc @astefanutti @squakez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #755: cq 2.5.0
lburgazzoli commented on pull request #755: URL: https://github.com/apache/camel-k-runtime/pull/755#issuecomment-975329141 /cc @squakez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #2763: Implement gosec to inspect source code for security problems
lburgazzoli commented on issue #2763: URL: https://github.com/apache/camel-k/issues/2763#issuecomment-975330136 We should probably also pay a little bit more attention to golangci-lint results -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #2534: Once quarkiverse extension (google-cloud-storage) allows optional and multiple client registration, change google-storage extension accordin
jamesnetherton closed issue #2534: URL: https://github.com/apache/camel-quarkus/issues/2534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #2534: Once quarkiverse extension (google-cloud-storage) allows optional and multiple client registration, change google-storage extension ac
jamesnetherton commented on issue #2534: URL: https://github.com/apache/camel-quarkus/issues/2534#issuecomment-975342283 Out of date since we no longer use the `quarkus-google-cloud-services` extensions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #2526: Once quarkiverse extension upgrades google-cloud-storage to 1.113.8, remove exclusion in google-storage extension
jamesnetherton commented on issue #2526: URL: https://github.com/apache/camel-quarkus/issues/2526#issuecomment-975343596 Out of date since we no longer use the `quarkus-google-cloud-services` extensions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #2526: Once quarkiverse extension upgrades google-cloud-storage to 1.113.8, remove exclusion in google-storage extension
jamesnetherton closed issue #2526: URL: https://github.com/apache/camel-quarkus/issues/2526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] squakez opened a new issue #2764: Jitpack still configured with `master` branch
squakez opened a new issue #2764: URL: https://github.com/apache/camel-k/issues/2764 https://github.com/apache/camel-k/blob/main/pkg/util/jitpack/jitpack.go#L28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] zhiminglim commented on issue #2737: How to package integration to deploy it into a private k8s cluster without internet connection
zhiminglim commented on issue #2737: URL: https://github.com/apache/camel-k/issues/2737#issuecomment-975347263 @elainhelen if I may join in this thread, I have a question with regards to how you manage to perform `kamel local build xxx.java` as I'm too looking for a solution to a use case similar to yours. I'm using Camel K Client 1.6.0, and when I did a `kamel local build --integration-directory test Basic.java`, it is returning an error without stack trace. ``` > kamel local build --integration-directory test Basic.java failure while building project: exit status 1 ``` Is there anything in particular you have to set up in advance before running the above command? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch main updated (7f6b0dc -> 671f842)
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/camel.git. from 7f6b0dc Regen for commit 18ee7705c8f6b9c8071bab6f6384571dab3b7ce7 new 40943be CAMEL-17215: camel-main - MainShutdownStrategy polished new 671f842 CAMEL-17215: camel-jbang - Reload should restart max-messages duration The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../main/java/org/apache/camel/spi/CamelEvent.java | 8 + .../java/org/apache/camel/spi/EventFactory.java| 8 + .../camel/impl/event/DefaultEventFactory.java | 5 +++ ...teRemovedEvent.java => RouteReloadedEvent.java} | 8 ++--- .../camel/main/DefaultMainShutdownStrategy.java| 4 +-- .../camel/main/MainDurationEventNotifier.java | 32 +++--- .../apache/camel/main/MainShutdownStrategy.java| 25 +++--- .../java/org/apache/camel/main/MainSupport.java| 13 +--- .../camel/main/SimpleMainShutdownStrategy.java | 36 +--- .../java/org/apache/camel/support/EventHelper.java | 39 ++ .../camel/support/RouteWatcherReloadStrategy.java | 5 +++ .../ROOT/pages/camel-3x-upgrade-guide-3_14.adoc| 4 +++ .../apache/camel/dsl/jbang/core/commands/Run.java | 21 +--- .../camel/dsl/jbang/core/common/RuntimeUtil.java | 8 ++--- 14 files changed, 183 insertions(+), 33 deletions(-) copy core/camel-base/src/main/java/org/apache/camel/impl/event/{RouteRemovedEvent.java => RouteReloadedEvent.java} (83%)
[camel] 01/02: CAMEL-17215: camel-main - MainShutdownStrategy polished
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git commit 40943be07fc20ea80d9383e39d416fd4131bf526 Author: Claus Ibsen AuthorDate: Mon Nov 22 07:33:41 2021 +0100 CAMEL-17215: camel-main - MainShutdownStrategy polished --- .../camel/main/DefaultMainShutdownStrategy.java | 4 ++-- .../org/apache/camel/main/MainShutdownStrategy.java | 20 +++- .../camel/main/SimpleMainShutdownStrategy.java | 4 ++-- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/core/camel-main/src/main/java/org/apache/camel/main/DefaultMainShutdownStrategy.java b/core/camel-main/src/main/java/org/apache/camel/main/DefaultMainShutdownStrategy.java index 9958622..5c73c05 100644 --- a/core/camel-main/src/main/java/org/apache/camel/main/DefaultMainShutdownStrategy.java +++ b/core/camel-main/src/main/java/org/apache/camel/main/DefaultMainShutdownStrategy.java @@ -66,9 +66,9 @@ public class DefaultMainShutdownStrategy extends SimpleMainShutdownStrategy { } @Override -public void await(long timeout, TimeUnit unit) throws InterruptedException { +public boolean await(long timeout, TimeUnit unit) throws InterruptedException { installHangupInterceptor(); -super.await(timeout, unit); +return super.await(timeout, unit); } private void handleHangup() { diff --git a/core/camel-main/src/main/java/org/apache/camel/main/MainShutdownStrategy.java b/core/camel-main/src/main/java/org/apache/camel/main/MainShutdownStrategy.java index 023ad48..46ab437 100644 --- a/core/camel-main/src/main/java/org/apache/camel/main/MainShutdownStrategy.java +++ b/core/camel-main/src/main/java/org/apache/camel/main/MainShutdownStrategy.java @@ -35,28 +35,38 @@ public interface MainShutdownStrategy { } +/** + * Adds a shutdown listener + * + * @param listener the listener + */ void addShutdownListener(ShutdownEventListener listener); /** + * Returns true if the application is allowed to run. + * * @return true if the application is allowed to run. */ boolean isRunAllowed(); /** + * Return true if the shutdown has been initiated by the caller. + * * @return true if the shutdown has been initiated by the caller. */ boolean shutdown(); /** - * Wait for main to complete. + * Waiting for Camel Main to complete. */ void await() throws InterruptedException; /** - * Wait for main to complete. + * Waiting for Camel Main to complete. * - * @param timeout the maximum time to wait - * @param unitthe time unit of the {@code timeout} argument + * @param timeout the maximum time to wait + * @param unitthe time unit of the {@code timeout} argument + * @return true if Camel Main was completed before the timeout, false if timeout was triggered. */ -void await(long timeout, TimeUnit unit) throws InterruptedException; +boolean await(long timeout, TimeUnit unit) throws InterruptedException; } diff --git a/core/camel-main/src/main/java/org/apache/camel/main/SimpleMainShutdownStrategy.java b/core/camel-main/src/main/java/org/apache/camel/main/SimpleMainShutdownStrategy.java index 7675edb..18b7ae4 100644 --- a/core/camel-main/src/main/java/org/apache/camel/main/SimpleMainShutdownStrategy.java +++ b/core/camel-main/src/main/java/org/apache/camel/main/SimpleMainShutdownStrategy.java @@ -74,8 +74,8 @@ public class SimpleMainShutdownStrategy implements MainShutdownStrategy { } @Override -public void await(long timeout, TimeUnit unit) throws InterruptedException { +public boolean await(long timeout, TimeUnit unit) throws InterruptedException { LOG.debug("Await shutdown to complete with timeout: {} {}", timeout, unit); -latch.await(timeout, unit); +return latch.await(timeout, unit); } }
[camel] 02/02: CAMEL-17215: camel-jbang - Reload should restart max-messages duration
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git commit 671f842ff7017a659dd13baceef94990fe8e95f3 Author: Claus Ibsen AuthorDate: Mon Nov 22 10:57:28 2021 +0100 CAMEL-17215: camel-jbang - Reload should restart max-messages duration --- .../main/java/org/apache/camel/spi/CamelEvent.java | 8 + .../java/org/apache/camel/spi/EventFactory.java| 8 + .../camel/impl/event/DefaultEventFactory.java | 5 +++ .../camel/impl/event/RouteReloadedEvent.java | 34 +++ .../camel/main/MainDurationEventNotifier.java | 32 +++--- .../apache/camel/main/MainShutdownStrategy.java| 7 +++- .../java/org/apache/camel/main/MainSupport.java| 13 +--- .../camel/main/SimpleMainShutdownStrategy.java | 34 --- .../java/org/apache/camel/support/EventHelper.java | 39 ++ .../camel/support/RouteWatcherReloadStrategy.java | 5 +++ .../ROOT/pages/camel-3x-upgrade-guide-3_14.adoc| 4 +++ .../apache/camel/dsl/jbang/core/commands/Run.java | 21 +--- .../camel/dsl/jbang/core/common/RuntimeUtil.java | 8 ++--- 13 files changed, 196 insertions(+), 22 deletions(-) diff --git a/core/camel-api/src/main/java/org/apache/camel/spi/CamelEvent.java b/core/camel-api/src/main/java/org/apache/camel/spi/CamelEvent.java index 1de38c0..6a34fa8 100644 --- a/core/camel-api/src/main/java/org/apache/camel/spi/CamelEvent.java +++ b/core/camel-api/src/main/java/org/apache/camel/spi/CamelEvent.java @@ -55,6 +55,7 @@ public interface CamelEvent { RoutesStopped, RouteAdded, RouteRemoved, +RouteReloaded, RouteStarting, RouteStarted, RouteStopping, @@ -347,6 +348,13 @@ public interface CamelEvent { } } +interface RouteReloadedEvent extends RouteEvent { +@Override +default Type getType() { +return Type.RouteReloaded; +} +} + interface RouteStartingEvent extends RouteEvent { @Override default Type getType() { diff --git a/core/camel-api/src/main/java/org/apache/camel/spi/EventFactory.java b/core/camel-api/src/main/java/org/apache/camel/spi/EventFactory.java index 6cc7994..fa402e9 100644 --- a/core/camel-api/src/main/java/org/apache/camel/spi/EventFactory.java +++ b/core/camel-api/src/main/java/org/apache/camel/spi/EventFactory.java @@ -196,6 +196,14 @@ public interface EventFactory { CamelEvent createRouteRemovedEvent(Route route); /** + * Creates an {@link CamelEvent} for {@link Route} has been reloaded successfully. + * + * @param route the route + * @return the reloaded event + */ +CamelEvent createRouteReloaded(Route route); + +/** * Creates an {@link CamelEvent} when an {@link org.apache.camel.Exchange} has been created * * @param exchange the exchange diff --git a/core/camel-base/src/main/java/org/apache/camel/impl/event/DefaultEventFactory.java b/core/camel-base/src/main/java/org/apache/camel/impl/event/DefaultEventFactory.java index 8472242..f04c267 100644 --- a/core/camel-base/src/main/java/org/apache/camel/impl/event/DefaultEventFactory.java +++ b/core/camel-base/src/main/java/org/apache/camel/impl/event/DefaultEventFactory.java @@ -131,6 +131,11 @@ public class DefaultEventFactory implements EventFactory { } @Override +public CamelEvent createRouteReloaded(Route route) { +return new RouteReloadedEvent(route); +} + +@Override public CamelEvent createExchangeCreatedEvent(Exchange exchange) { return new ExchangeCreatedEvent(exchange); } diff --git a/core/camel-base/src/main/java/org/apache/camel/impl/event/RouteReloadedEvent.java b/core/camel-base/src/main/java/org/apache/camel/impl/event/RouteReloadedEvent.java new file mode 100644 index 000..651bc22 --- /dev/null +++ b/core/camel-base/src/main/java/org/apache/camel/impl/event/RouteReloadedEvent.java @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.impl.event; + +import org.apache.camel.R
[GitHub] [camel-k] lburgazzoli commented on issue #2763: Implement gosec to inspect source code for security problems
lburgazzoli commented on issue #2763: URL: https://github.com/apache/camel-k/issues/2763#issuecomment-975351146 Or maybe enable gosec linter in golangci-lint -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] hokutor opened a new pull request #6460: CAMEL-17221: Fix isIgnoreSslVerification parameter in HuaweiCloud Ima…
hokutor opened a new pull request #6460: URL: https://github.com/apache/camel/pull/6460 …geRecognition component and SimpleNotification component -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-spring-boot] branch main updated: CAMEL-17215: camel-jbang - Reload should restart max-messages duration
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-spring-boot.git The following commit(s) were added to refs/heads/main by this push: new cdae280 CAMEL-17215: camel-jbang - Reload should restart max-messages duration cdae280 is described below commit cdae2804b047e0d8320e5f492578ba689093729d Author: Claus Ibsen AuthorDate: Mon Nov 22 11:15:25 2021 +0100 CAMEL-17215: camel-jbang - Reload should restart max-messages duration --- core/camel-spring-boot/src/main/docs/spring-boot.json | 7 +++ .../org/apache/camel/spring/boot/CamelConfigurationProperties.java | 6 ++ .../camel/spring/boot/CamelSpringBootApplicationListener.java | 4 ++-- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/core/camel-spring-boot/src/main/docs/spring-boot.json b/core/camel-spring-boot/src/main/docs/spring-boot.json index 6453476..1ad8709 100644 --- a/core/camel-spring-boot/src/main/docs/spring-boot.json +++ b/core/camel-spring-boot/src/main/docs/spring-boot.json @@ -882,6 +882,13 @@ "defaultValue": true }, { + "name": "camel.springboot.routes-reload-restart-duration", + "type": "java.lang.Boolean", + "description": "Whether to restart max duration when routes are reloaded. For example if max duration is 60 seconds, and a route is reloaded after 25 seconds, then this will restart the count and wait 60 seconds again.", + "sourceType": "org.apache.camel.spring.boot.CamelConfigurationProperties", + "defaultValue": true +}, +{ "name": "camel.springboot.shutdown-log-inflight-exchanges-on-timeout", "type": "java.lang.Boolean", "description": "Sets whether to log information about the inflight Exchanges which are still running during a shutdown which didn't complete without the given timeout. This requires to enable the option inflightRepositoryExchangeEnabled.", diff --git a/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java b/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java index 0c9fdac..f7bca8c 100644 --- a/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java +++ b/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelConfigurationProperties.java @@ -221,6 +221,12 @@ public class CamelConfigurationProperties extends DefaultConfigurationProperties private boolean routesReloadRemoveAllRoutes = true; /** + * Whether to restart max duration when routes are reloaded. For example if max duration is 60 seconds, and a route + * is reloaded after 25 seconds, then this will restart the count and wait 60 seconds again. + */ + private boolean routesReloadRestartDuration = true; + +/** * To specify for how long time in seconds to keep running the JVM before automatic terminating the JVM. * You can use this to run Spring Boot for a short while. */ diff --git a/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelSpringBootApplicationListener.java b/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelSpringBootApplicationListener.java index 6d3773d..cf5ea84 100644 --- a/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelSpringBootApplicationListener.java +++ b/core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelSpringBootApplicationListener.java @@ -123,7 +123,7 @@ public class CamelSpringBootApplicationListener implements ApplicationListener
[camel] branch main updated (671f842 -> b4ce306)
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/camel.git. from 671f842 CAMEL-17215: camel-jbang - Reload should restart max-messages duration add b4ce306 CAMEL-17215: camel-jbang - Reload should restart max-messages duration No new revisions were added by this update. Summary of changes: .../MainConfigurationPropertiesConfigurer.java | 6 ++ .../camel-main-configuration-metadata.json | 1 + core/camel-main/src/main/docs/main.adoc| 3 ++- .../camel/main/DefaultConfigurationProperties.java | 23 ++ .../camel/main/MainDurationEventNotifier.java | 17 ++-- .../java/org/apache/camel/main/MainSupport.java| 3 ++- 6 files changed, 45 insertions(+), 8 deletions(-)
[GitHub] [camel] davsclaus commented on pull request #6459: [CAMEL-17216] Allow to include properties file
davsclaus commented on pull request #6459: URL: https://github.com/apache/camel/pull/6459#issuecomment-975371328 What if you have a properties file in the current folder, or a sub folder, where you do not have a leading slash, eg ``` jbang -Dcamel.jbang.version=3.14.0 CamelJBang@apache/camel run github:apache:camel-k:examples/languages/routes.yaml --properties my-prop.properties ``` or ``` jbang -Dcamel.jbang.version=3.14.0 CamelJBang@apache/camel run github:apache:camel-k:examples/languages/routes.yaml --properties ../config/application.properties ``` The default resolver is classpath, but this wont work with jbang (well it would be odd to have a JAR that embeds .properties that should be loaded). So we could maybe always just use file: as scheme prefix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-kamelets] branch main updated: fix: use the right json schema type for integers (#575)
This is an automated email from the ASF dual-hosted git repository. valdar pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-kamelets.git The following commit(s) were added to refs/heads/main by this push: new 8187e83 fix: use the right json schema type for integers (#575) 8187e83 is described below commit 8187e8333a342afb25cf9d98282b9b8d0326555f Author: Luca Burgazzoli AuthorDate: Mon Nov 22 11:28:09 2021 +0100 fix: use the right json schema type for integers (#575) --- aws-s3-streaming-upload-sink.kamelet.yaml | 4 ++-- azure-storage-queue-source.kamelet.yaml | 2 +- couchbase-sink.kamelet.yaml | 2 +- .../main/resources/kamelets/aws-s3-streaming-upload-sink.kamelet.yaml | 4 ++-- .../main/resources/kamelets/azure-storage-queue-source.kamelet.yaml | 2 +- .../src/main/resources/kamelets/couchbase-sink.kamelet.yaml | 2 +- .../src/main/resources/kamelets/throttle-action.kamelet.yaml | 4 ++-- throttle-action.kamelet.yaml | 4 ++-- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/aws-s3-streaming-upload-sink.kamelet.yaml b/aws-s3-streaming-upload-sink.kamelet.yaml index ded18ef..831cab6 100644 --- a/aws-s3-streaming-upload-sink.kamelet.yaml +++ b/aws-s3-streaming-upload-sink.kamelet.yaml @@ -70,12 +70,12 @@ spec: batchMessageNumber: title: Batch Message Number description: The number of messages composing a batch in streaming upload mode -type: int +type: integer default: 10 batchSize: title: Batch Size description: The batch size (in bytes) in streaming upload mode -type: int +type: integer default: '100' streamingUploadTimeout: title: Streaming Upload Timeout diff --git a/azure-storage-queue-source.kamelet.yaml b/azure-storage-queue-source.kamelet.yaml index 626d5f4..b5c8dab 100644 --- a/azure-storage-queue-source.kamelet.yaml +++ b/azure-storage-queue-source.kamelet.yaml @@ -42,7 +42,7 @@ spec: maxMessages: title: Maximum Messages description: Maximum number of messages to get, if there are less messages exist in the queue than requested all the messages will be returned. By default it will consider 1 message to be retrieved, the allowed range is 1 to 32 messages. -type: int +type: integer default: 1 dependencies: - "camel:azure-storage-queue" diff --git a/couchbase-sink.kamelet.yaml b/couchbase-sink.kamelet.yaml index e0b97f1..a227fbd 100644 --- a/couchbase-sink.kamelet.yaml +++ b/couchbase-sink.kamelet.yaml @@ -32,7 +32,7 @@ spec: couchbasePort: title: Port description: The port to use -type: int +type: integer default: 8091 bucket: title: Bucket diff --git a/library/camel-kamelets/src/main/resources/kamelets/aws-s3-streaming-upload-sink.kamelet.yaml b/library/camel-kamelets/src/main/resources/kamelets/aws-s3-streaming-upload-sink.kamelet.yaml index ded18ef..831cab6 100644 --- a/library/camel-kamelets/src/main/resources/kamelets/aws-s3-streaming-upload-sink.kamelet.yaml +++ b/library/camel-kamelets/src/main/resources/kamelets/aws-s3-streaming-upload-sink.kamelet.yaml @@ -70,12 +70,12 @@ spec: batchMessageNumber: title: Batch Message Number description: The number of messages composing a batch in streaming upload mode -type: int +type: integer default: 10 batchSize: title: Batch Size description: The batch size (in bytes) in streaming upload mode -type: int +type: integer default: '100' streamingUploadTimeout: title: Streaming Upload Timeout diff --git a/library/camel-kamelets/src/main/resources/kamelets/azure-storage-queue-source.kamelet.yaml b/library/camel-kamelets/src/main/resources/kamelets/azure-storage-queue-source.kamelet.yaml index 626d5f4..b5c8dab 100644 --- a/library/camel-kamelets/src/main/resources/kamelets/azure-storage-queue-source.kamelet.yaml +++ b/library/camel-kamelets/src/main/resources/kamelets/azure-storage-queue-source.kamelet.yaml @@ -42,7 +42,7 @@ spec: maxMessages: title: Maximum Messages description: Maximum number of messages to get, if there are less messages exist in the queue than requested all the messages will be returned. By default it will consider 1 message to be retrieved, the allowed range is 1 to 32 messages. -type: int +type: integer default: 1 dependencies: - "camel:azure-storage-queue" diff --git a/library/camel-kamelets/src/main/resources/kamelets/couchbase-sink.kamelet.yaml b/library/camel-kamelets/src/main/resources/kamelets/couchbase-sink.kamelet.yaml index e0b97f1..a227fbd 100644 --- a/libra
[GitHub] [camel-kamelets] valdar merged pull request #575: fix: use the right json schema type for integers
valdar merged pull request #575: URL: https://github.com/apache/camel-kamelets/pull/575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-kamelets] branch regen_bot updated (fc18dd5 -> 8187e83)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel-kamelets.git. from fc18dd5 Bump Kubernetes Client Camel-K extension to version 5.10.1 add 8187e83 fix: use the right json schema type for integers (#575) No new revisions were added by this update. Summary of changes: aws-s3-streaming-upload-sink.kamelet.yaml | 4 ++-- azure-storage-queue-source.kamelet.yaml | 2 +- couchbase-sink.kamelet.yaml | 2 +- .../main/resources/kamelets/aws-s3-streaming-upload-sink.kamelet.yaml | 4 ++-- .../main/resources/kamelets/azure-storage-queue-source.kamelet.yaml | 2 +- .../src/main/resources/kamelets/couchbase-sink.kamelet.yaml | 2 +- .../src/main/resources/kamelets/throttle-action.kamelet.yaml | 4 ++-- throttle-action.kamelet.yaml | 4 ++-- 8 files changed, 12 insertions(+), 12 deletions(-)
[GitHub] [camel-k] squakez commented on issue #2737: How to package integration to deploy it into a private k8s cluster without internet connection
squakez commented on issue #2737: URL: https://github.com/apache/camel-k/issues/2737#issuecomment-975399413 > @elainhelen if I may join in this thread, I have a question with regards to how you manage to perform `kamel local build xxx.java` as I'm too looking for a solution to a use case similar to yours. > > I'm using Camel K Client 1.6.0, and when I did a `kamel local build --integration-directory test Basic.java`, it is returning an error without stack trace. > > ``` > > kamel local build --integration-directory test Basic.java > failure while building project: exit status 1 > ``` > > Is there anything in particular you have to set up in advance before running the above command? The `local` is performed on your machine, so you must make sure that you have all the expected tools required by the build process, ie, maven, jdk, quarkus, ... it seems that your error happens when you try to [package the application](https://github.com/apache/camel-k/blob/main/pkg/builder/quarkus.go#L191), so, likely, you don't have all the required configuration needed to run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch regen_bot updated (7f6b0dc -> 671f842)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. from 7f6b0dc Regen for commit 18ee7705c8f6b9c8071bab6f6384571dab3b7ce7 add 40943be CAMEL-17215: camel-main - MainShutdownStrategy polished add 671f842 CAMEL-17215: camel-jbang - Reload should restart max-messages duration No new revisions were added by this update. Summary of changes: .../main/java/org/apache/camel/spi/CamelEvent.java | 8 + .../java/org/apache/camel/spi/EventFactory.java| 8 + .../camel/impl/event/DefaultEventFactory.java | 5 +++ ...teRemovedEvent.java => RouteReloadedEvent.java} | 8 ++--- .../camel/main/DefaultMainShutdownStrategy.java| 4 +-- .../camel/main/MainDurationEventNotifier.java | 32 +++--- .../apache/camel/main/MainShutdownStrategy.java| 25 +++--- .../java/org/apache/camel/main/MainSupport.java| 13 +--- .../camel/main/SimpleMainShutdownStrategy.java | 36 +--- .../java/org/apache/camel/support/EventHelper.java | 39 ++ .../camel/support/RouteWatcherReloadStrategy.java | 5 +++ .../ROOT/pages/camel-3x-upgrade-guide-3_14.adoc| 4 +++ .../apache/camel/dsl/jbang/core/commands/Run.java | 21 +--- .../camel/dsl/jbang/core/common/RuntimeUtil.java | 8 ++--- 14 files changed, 183 insertions(+), 33 deletions(-) copy core/camel-base/src/main/java/org/apache/camel/impl/event/{RouteRemovedEvent.java => RouteReloadedEvent.java} (83%)
[GitHub] [camel-k-runtime] squakez commented on a change in pull request #755: cq 2.5.0
squakez commented on a change in pull request #755: URL: https://github.com/apache/camel-k-runtime/pull/755#discussion_r754163905 ## File path: pom.xml ## @@ -397,7 +397,7 @@ --> camel.quarkus.staging - https://repository.apache.org/content/repositories/orgapachecamel-1370 + https://repository.apache.org/content/repositories/orgapachecamel-1379 Review comment: Will conflict with #756 ## File path: pom.xml ## @@ -435,7 +435,7 @@ --> camel.quarkus.staging - https://repository.apache.org/content/repositories/orgapachecamel-1370 + https://repository.apache.org/content/repositories/orgapachecamel-1379 Review comment: Same here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #756: chore: remove staging maven repo
lburgazzoli merged pull request #756: URL: https://github.com/apache/camel-k-runtime/pull/756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-k-runtime] branch main updated: chore: remove staging maven repo
This is an automated email from the ASF dual-hosted git repository. lburgazzoli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-k-runtime.git The following commit(s) were added to refs/heads/main by this push: new 709f7b5 chore: remove staging maven repo 709f7b5 is described below commit 709f7b5f6b5bb44cde4e0270fbed1f74d5e34e86 Author: Luca Burgazzoli AuthorDate: Mon Nov 22 10:09:56 2021 +0100 chore: remove staging maven repo --- pom.xml | 22 -- 1 file changed, 22 deletions(-) diff --git a/pom.xml b/pom.xml index c8e63e6..a37b500 100644 --- a/pom.xml +++ b/pom.xml @@ -396,17 +396,6 @@ --> -camel.quarkus.staging - https://repository.apache.org/content/repositories/orgapachecamel-1370 -Apache Snapshot Repo - -false - - -true - - - apache.snapshots https://repository.apache.org/snapshots/ Apache Snapshot Repo @@ -434,17 +423,6 @@ --> -camel.quarkus.staging - https://repository.apache.org/content/repositories/orgapachecamel-1370 -Apache Snapshot Repo - -false - - -true - - - apache.snapshots https://repository.apache.org/snapshots/
[GitHub] [camel] github-actions[bot] opened a new pull request #6461: Generated sources regen
github-actions[bot] opened a new pull request #6461: URL: https://github.com/apache/camel/pull/6461 Regen bot :robot: found some uncommited changes after running build on :camel: main. Please do not delete `regen_bot` branch after merge/rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch regen_bot updated (671f842 -> 2169122)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. from 671f842 CAMEL-17215: camel-jbang - Reload should restart max-messages duration add b4ce306 CAMEL-17215: camel-jbang - Reload should restart max-messages duration add 2169122 Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb No new revisions were added by this update. Summary of changes: .../main/camel-main-configuration-metadata.json| 1 + .../MainConfigurationPropertiesConfigurer.java | 6 ++ .../camel-main-configuration-metadata.json | 1 + core/camel-main/src/main/docs/main.adoc| 3 ++- .../camel/main/DefaultConfigurationProperties.java | 23 ++ .../camel/main/MainDurationEventNotifier.java | 17 ++-- .../java/org/apache/camel/main/MainSupport.java| 3 ++- 7 files changed, 46 insertions(+), 8 deletions(-)
[GitHub] [camel] Croway commented on pull request #6459: [CAMEL-17216] Allow to include properties file
Croway commented on pull request #6459: URL: https://github.com/apache/camel/pull/6459#issuecomment-975416447 Good point, the latest commit pre append the absolute path in case of missing /. I tested it with ``` jbang -Dcamel.jbang.version=3.14.0-SNAPSHOT CamelJBang@apache/camel run github:Croway:camel-k:examples/languages/routes.yaml --properties /home/federico/test.properties jbang -Dcamel.jbang.version=3.14.0-SNAPSHOT CamelJBang@apache/camel run github:Croway:camel-k:examples/languages/routes.yaml --properties file:///home/federico/test.properties jbang -Dcamel.jbang.version=3.14.0-SNAPSHOT CamelJBang@apache/camel run github:Croway:camel-k:examples/languages/routes.yaml --properties ../test.properties jbang -Dcamel.jbang.version=3.14.0-SNAPSHOT CamelJBang@apache/camel run github:Croway:camel-k:examples/languages/routes.yaml --properties test.properties ``` and they are working -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch main updated: Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/main by this push: new 3e66423 Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb 3e66423 is described below commit 3e664234cd8eea253c32785a296fbe2ffaba3e55 Author: davsclaus AuthorDate: Mon Nov 22 11:13:58 2021 + Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb Signed-off-by: GitHub --- .../org/apache/camel/catalog/main/camel-main-configuration-metadata.json | 1 + 1 file changed, 1 insertion(+) diff --git a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/main/camel-main-configuration-metadata.json b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/main/camel-main-configuration-metadata.json index 80ac8a9..bbb41bd 100644 --- a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/main/camel-main-configuration-metadata.json +++ b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/main/camel-main-configuration-metadata.json @@ -80,6 +80,7 @@ { "name": "camel.main.routesReloadEnabled", "description": "Used for enabling automatic routes reloading. If enabled then Camel will watch for file changes in the given reload directory, and trigger reloading routes if files are changed.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "boolean", "javaType": "boolean", "defaultValue": "false" }, { "name": "camel.main.routesReloadPattern", "description": "Used for inclusive filtering of routes from directories. Typical used for specifying to accept routes in XML or YAML files, such as .yaml,.xml. Multiple patterns can be specified separated by comma.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "string", "javaType": "java.lang.String" }, { "name": "camel.main.routesReloadRemoveAllRoutes", "description": "When reloading routes should all existing routes be stopped and removed. By default, Camel will stop and remove all existing routes before reloading routes. This ensures that only the reloaded routes will be active. If disabled then only routes with the same route id is updated, and any existing routes are continued to run.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "boolean", "ja [...] +{ "name": "camel.main.routesReloadRestartDuration", "description": "Whether to restart max duration when routes are reloaded. For example if max duration is 60 seconds, and a route is reloaded after 25 seconds, then this will restart the count and wait 60 seconds again.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "boolean", "javaType": "boolean", "defaultValue": true }, { "name": "camel.main.shutdownLogInflightExchangesOnTimeout", "description": "Sets whether to log information about the inflight Exchanges which are still running during a shutdown which didn't complete without the given timeout. This requires to enable the option inflightRepositoryBrowseEnabled.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "boolean", "javaType": "boolean", "defaultValue": true }, { "name": "camel.main.shutdownNowOnTimeout", "description": "Sets whether to force shutdown of all consumers when a timeout occurred and thus not all consumers was shutdown within that period. You should have good reasons to set this option to false as it means that the routes keep running and is halted abruptly when CamelContext has been shutdown.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "boolean", "javaType": "boolean", "defaultValue": true }, { "name": "camel.main.shutdownRoutesInReverseOrder", "description": "Sets whether routes should be shutdown in reverse or the same order as they were started.", "sourceType": "org.apache.camel.main.DefaultConfigurationProperties", "type": "boolean", "javaType": "boolean", "defaultValue": true },
[GitHub] [camel] oscerd merged pull request #6461: Generated sources regen
oscerd merged pull request #6461: URL: https://github.com/apache/camel/pull/6461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] FernandoDorado closed issue #1291: Problem with line breaks kafka-hdfs sink connector
FernandoDorado closed issue #1291: URL: https://github.com/apache/camel-kafka-connector/issues/1291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #1291: Problem with line breaks kafka-hdfs sink connector
oscerd commented on issue #1291: URL: https://github.com/apache/camel-kafka-connector/issues/1291#issuecomment-975436387 Leave it open if you want so we can work on that or wait for the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] FernandoDorado commented on issue #1291: Problem with line breaks kafka-hdfs sink connector
FernandoDorado commented on issue #1291: URL: https://github.com/apache/camel-kafka-connector/issues/1291#issuecomment-975437276 Perfect, we will let you know when we have progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6459: [CAMEL-17216] Allow to include properties file
davsclaus merged pull request #6459: URL: https://github.com/apache/camel/pull/6459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch main updated: [CAMEL-17216] Allow to include properties file (#6459)
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/main by this push: new 1c79dc4 [CAMEL-17216] Allow to include properties file (#6459) 1c79dc4 is described below commit 1c79dc40c8ba51f15734bd52ad50b821cdc2b6c9 Author: Federico Mariani <34543311+cro...@users.noreply.github.com> AuthorDate: Mon Nov 22 13:01:05 2021 +0100 [CAMEL-17216] Allow to include properties file (#6459) --- .../apache/camel/dsl/jbang/core/commands/Run.java | 23 ++ 1 file changed, 23 insertions(+) diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java index 528e05e..fc36ec2 100644 --- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java +++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java @@ -19,6 +19,7 @@ package org.apache.camel.dsl.jbang.core.commands; import java.io.File; import java.io.IOException; +import java.nio.file.FileSystems; import java.util.concurrent.Callable; import java.util.concurrent.Executors; import java.util.concurrent.ScheduledExecutorService; @@ -65,6 +66,10 @@ class Run implements Callable { @Option(names = { "--reload" }, description = "Enables live reload when source file is changed (saved)") private boolean reload; +@Option(names = { "--properties" }, +description = "Load properties file for route placeholders (ex. /path/to/file.properties") +private String propertiesFiles; + @Option(names = { "--file-lock" }, defaultValue = "true", description = "Whether to create a temporary file lock, which upon deleting triggers this process to terminate") private boolean fileLock = true; @@ -155,6 +160,24 @@ class Run implements Callable { } } +if (propertiesFiles != null) { +String[] filesLocation = propertiesFiles.split(","); +StringBuilder locations = new StringBuilder(); +for (String file : filesLocation) { +if (!file.startsWith("file:")) { +if (!file.startsWith("/")) { +file = FileSystems.getDefault().getPath("").toAbsolutePath() + File.separator + file; +} + +file = "file://" + file; +} + +locations.append(file).append(","); +} + +main.addInitialProperty("camel.component.properties.location", locations.toString()); +} + System.out.println("Starting Camel JBang!"); main.start();
[camel] branch main updated (1c79dc4 -> 1511045)
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/camel.git. from 1c79dc4 [CAMEL-17216] Allow to include properties file (#6459) add 1511045 camel-jbang - Polished No new revisions were added by this update. Summary of changes: .../apache/camel/dsl/jbang/core/api/Converter.java | 1 - .../apache/camel/dsl/jbang/core/api/Extractor.java | 1 - .../apache/camel/dsl/jbang/core/api/Printer.java | 1 - .../camel/dsl/jbang/core/api/TemplateParser.java | 1 - .../jbang/core/commands/AbstractInitKamelet.java | 1 - .../dsl/jbang/core/commands/AbstractSearch.java| 1 - .../dsl/jbang/core/commands/CamelJBangMain.java| 1 - .../apache/camel/dsl/jbang/core/commands/Init.java | 1 - .../camel/dsl/jbang/core/commands/InitBinding.java | 1 - .../camel/dsl/jbang/core/commands/InitKamelet.java | 1 - .../apache/camel/dsl/jbang/core/commands/Run.java | 36 +++--- .../camel/dsl/jbang/core/commands/Search.java | 1 - .../dsl/jbang/core/commands/SearchComponents.java | 1 - .../dsl/jbang/core/commands/SearchKamelets.java| 1 - .../dsl/jbang/core/commands/SearchLanguages.java | 1 - .../dsl/jbang/core/commands/SearchOthers.java | 1 - .../dsl/jbang/core/common/MatchExtractor.java | 1 - .../common/exceptions/ResourceAlreadyExists.java | 2 +- .../common/exceptions/ResourceDoesNotExist.java| 2 +- .../jbang/core/components/ComponentConverter.java | 2 +- .../components/ComponentDescriptionMatching.java | 1 - .../jbang/core/components/ComponentPrinter.java| 2 +- .../dsl/jbang/core/kamelets/KameletConverter.java | 2 +- .../core/kamelets/KameletDescriptionMatching.java | 1 - .../dsl/jbang/core/kamelets/KameletPrinter.java| 2 +- .../jbang/core/languages/LanguageConverter.java| 2 +- .../languages/LanguageDescriptionMatching.java | 1 - .../dsl/jbang/core/languages/LanguagePrinter.java | 2 +- .../dsl/jbang/core/others/OtherConverter.java | 2 +- .../core/others/OtherDescriptionMatching.java | 1 - .../camel/dsl/jbang/core/others/OtherPrinter.java | 2 +- .../core/templates/VelocityTemplateParser.java | 1 - .../camel/dsl/jbang/core/types/Component.java | 1 - .../apache/camel/dsl/jbang/core/types/Kamelet.java | 1 - .../camel/dsl/jbang/core/types/Language.java | 1 - .../apache/camel/dsl/jbang/core/types/Other.java | 1 - 36 files changed, 28 insertions(+), 53 deletions(-)
[camel] branch regen_bot updated (2169122 -> 3e66423)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. omit 2169122 Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb add 3e66423 Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (2169122) \ N -- N -- N refs/heads/regen_bot (3e66423) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
[GitHub] [camel-k] k0pper commented on issue #2765: How to use a custom Kamelet Repository?
k0pper commented on issue #2765: URL: https://github.com/apache/camel-k/issues/2765#issuecomment-975484604 ``Update: The command `helm install --namespace camel-k --create-namespace --generate-name --set platform.build.registry.address=${REGISTRY_ADDRESS} --set platform.build.registry.insecure=true --set "platform.kamelet.repositories[0].uri=github.com/k0pper/custom-kamelets" camel-k/camel-k` worked and the repository is set inside the IntegrationPlatform.yaml inside the cluster, but when I view the Kamelets inside the cluster I still have the default Kamelets from the default repository **without** the custom one ``` ~ ➤ k get kamelet -n camel-k NAME PHASE avro-deserialize-actionReady avro-serialize-action Ready aws-cloudwatch-sinkReady aws-ddb-streams-source Ready aws-ec2-sink Ready (...) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] k0pper edited a comment on issue #2765: How to use a custom Kamelet Repository?
k0pper edited a comment on issue #2765: URL: https://github.com/apache/camel-k/issues/2765#issuecomment-975484604 Update: The command `helm install --namespace camel-k --create-namespace --generate-name --set platform.build.registry.address=${REGISTRY_ADDRESS} --set platform.build.registry.insecure=true --set "platform.kamelet.repositories[0].uri=github.com/k0pper/custom-kamelets" camel-k/camel-k` worked and the repository is set inside the IntegrationPlatform.yaml inside the cluster, but when I view the Kamelets inside the cluster I still have the default Kamelets from the default repository **without** the custom one ``` ~ ➤ k get kamelet -n camel-k NAME PHASE avro-deserialize-actionReady avro-serialize-action Ready aws-cloudwatch-sinkReady aws-ddb-streams-source Ready aws-ec2-sink Ready (...) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli opened a new pull request #2766: gosec
lburgazzoli opened a new pull request #2766: URL: https://github.com/apache/camel-k/pull/2766 - fix(gosec): Implicit memory aliasing in for loop (G601) - fix(gosec): Expect WriteFile permissions to be 0600 or less (G306) - fix(gosec): Use of weak random number generator (G404) - fix(gosec): disable rule G101 - chore(ci): update golangci-lint to v1.43 **Release Note** ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] astefanutti opened a new pull request #2767: chore(build): Upgrade Maven to version 3.8.4
astefanutti opened a new pull request #2767: URL: https://github.com/apache/camel-k/pull/2767 **Release Note** ```release-note chore(build): Upgrade Maven to version 3.8.4 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #2766: gosec
lburgazzoli commented on pull request #2766: URL: https://github.com/apache/camel-k/pull/2766#issuecomment-975491973 @astefanutti @squakez I've done a quick scanning with `gosec` by enabling the related lint in `golangci-lint` (see https://github.com/apache/camel-k/issues/2763). I'm not sure if the change I made are the proper one but the intention is more to make them a little bit visible so we can agree on the path we want to follow in general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #2766: gosec
lburgazzoli commented on pull request #2766: URL: https://github.com/apache/camel-k/pull/2766#issuecomment-975494300 @astefanutti @squakez I've done a quick scanning with `gosec` by enabling the related lint in `golangci-lint` (see https://github.com/apache/camel-k/issues/2763). I'm not sure if the change I made are the proper one but the intention is more to make them a little bit visible so we can agree on the path we want to follow in general. As example one of the reported issue is about `Implicit memory aliasing in for loop` which may lead to very bad results but looking at the code, it should not happen because the methods that re invoked are `stateless` but still the caller should not make assumption thus is better to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli edited a comment on pull request #2766: gosec
lburgazzoli edited a comment on pull request #2766: URL: https://github.com/apache/camel-k/pull/2766#issuecomment-975494300 @astefanutti @squakez I've done a quick scanning with `gosec` by enabling the related lint in `golangci-lint` (see https://github.com/apache/camel-k/issues/2763). I'm not sure if the change I made are the proper one but the intention is more to make them a little bit visible so we can agree on the path we want to follow in general. As example one of the reported issue is about `Implicit memory aliasing in for loop` which may lead to very bad results but looking at the code, it should not happen because the methods that re invoked are `stateless` but still the caller should not make assumption thus is better to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-karavan] branch main updated: Reload for JBang (#115)
This is an automated email from the ASF dual-hosted git repository. marat pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-karavan.git The following commit(s) were added to refs/heads/main by this push: new f92e6b7 Reload for JBang (#115) f92e6b7 is described below commit f92e6b7dd025cdee46011ba4253f04874666b154 Author: Marat Gubaidullin AuthorDate: Mon Nov 22 07:58:33 2021 -0500 Reload for JBang (#115) --- karavan-vscode/package.json | 11 --- karavan-vscode/src/extension.ts | 10 +++--- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/karavan-vscode/package.json b/karavan-vscode/package.json index a4d39f0..24e9b38 100644 --- a/karavan-vscode/package.json +++ b/karavan-vscode/package.json @@ -53,7 +53,7 @@ "properties": { "CamelJBang.version": { "type": "string", - "default": "3.13.0", + "default": "3.14.0-SNAPSHOT", "description": "Camel version" }, "CamelJBang.maxMessages": { @@ -61,11 +61,16 @@ "default": 10, "description": "Max number of messages to process before stopping" }, -"CamelJBang.debugLevel": { +"CamelJBang.loggingLevel": { "type": "string", "default": "info", "enum": ["info", "error", "debug", "trace"], - "description": "Default debug level" + "description": "Logging level" +}, +"CamelJBang.reload": { + "type": "boolean", + "default": "true", + "description": "Reload routes on change" } } }, diff --git a/karavan-vscode/src/extension.ts b/karavan-vscode/src/extension.ts index a951501..38c00dd 100644 --- a/karavan-vscode/src/extension.ts +++ b/karavan-vscode/src/extension.ts @@ -200,14 +200,18 @@ function parceYaml(filename: string, yaml: string): [boolean, string?] { function runCamelJbang(filename: string) { const version = vscode.workspace.getConfiguration().get("CamelJBang.version"); const maxMessages = vscode.workspace.getConfiguration().get("CamelJBang.maxMessages"); -const debugLevel = vscode.workspace.getConfiguration().get("CamelJBang.debugLevel"); +const loggingLevel = vscode.workspace.getConfiguration().get("CamelJBang.loggingLevel"); +const reload = vscode.workspace.getConfiguration().get("CamelJBang.reload"); +const command = "jbang -Dcamel.jbang.version=" + version + " CamelJBang@apache/camel run " + filename ++ " --max-messages=" + maxMessages ++ " --logging-level=" + loggingLevel ++ (reload ? " --reload" : ""); const existTerminal = TERMINALS.get(filename); if (existTerminal) existTerminal.dispose(); const terminal = vscode.window.createTerminal('CamelJBang: ' + filename); TERMINALS.set(filename, terminal); terminal.show(); -terminal.sendText("jbang -Dcamel.jbang.version=" + version + " CamelJBang@apache/camel run " + filename -+ " --max-messages=" + maxMessages + " --debug-level=" + debugLevel); +terminal.sendText(command); } export function deactivate() {
[GitHub] [camel-karavan] mgubaidullin merged pull request #115: Reload for JBang
mgubaidullin merged pull request #115: URL: https://github.com/apache/camel-karavan/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #112: JBang live reload
mgubaidullin commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975496821 `reload` option has been added https://user-images.githubusercontent.com/1379213/142865976-7df1002b-6e05-462d-891c-876adf3f537a.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch regen_bot updated (3e66423 -> 1511045)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. from 3e66423 Regen for commit b4ce30679f52de0a2b23e4e3ce54ec6b1606ebdb add 1c79dc4 [CAMEL-17216] Allow to include properties file (#6459) add 1511045 camel-jbang - Polished No new revisions were added by this update. Summary of changes: .../apache/camel/dsl/jbang/core/api/Converter.java | 1 - .../apache/camel/dsl/jbang/core/api/Extractor.java | 1 - .../apache/camel/dsl/jbang/core/api/Printer.java | 1 - .../camel/dsl/jbang/core/api/TemplateParser.java | 1 - .../jbang/core/commands/AbstractInitKamelet.java | 1 - .../dsl/jbang/core/commands/AbstractSearch.java| 1 - .../dsl/jbang/core/commands/CamelJBangMain.java| 1 - .../apache/camel/dsl/jbang/core/commands/Init.java | 1 - .../camel/dsl/jbang/core/commands/InitBinding.java | 1 - .../camel/dsl/jbang/core/commands/InitKamelet.java | 1 - .../apache/camel/dsl/jbang/core/commands/Run.java | 53 -- .../camel/dsl/jbang/core/commands/Search.java | 1 - .../dsl/jbang/core/commands/SearchComponents.java | 1 - .../dsl/jbang/core/commands/SearchKamelets.java| 1 - .../dsl/jbang/core/commands/SearchLanguages.java | 1 - .../dsl/jbang/core/commands/SearchOthers.java | 1 - .../dsl/jbang/core/common/MatchExtractor.java | 1 - .../common/exceptions/ResourceAlreadyExists.java | 2 +- .../common/exceptions/ResourceDoesNotExist.java| 2 +- .../jbang/core/components/ComponentConverter.java | 2 +- .../components/ComponentDescriptionMatching.java | 1 - .../jbang/core/components/ComponentPrinter.java| 2 +- .../dsl/jbang/core/kamelets/KameletConverter.java | 2 +- .../core/kamelets/KameletDescriptionMatching.java | 1 - .../dsl/jbang/core/kamelets/KameletPrinter.java| 2 +- .../jbang/core/languages/LanguageConverter.java| 2 +- .../languages/LanguageDescriptionMatching.java | 1 - .../dsl/jbang/core/languages/LanguagePrinter.java | 2 +- .../dsl/jbang/core/others/OtherConverter.java | 2 +- .../core/others/OtherDescriptionMatching.java | 1 - .../camel/dsl/jbang/core/others/OtherPrinter.java | 2 +- .../core/templates/VelocityTemplateParser.java | 1 - .../camel/dsl/jbang/core/types/Component.java | 1 - .../apache/camel/dsl/jbang/core/types/Kamelet.java | 1 - .../camel/dsl/jbang/core/types/Language.java | 1 - .../apache/camel/dsl/jbang/core/types/Other.java | 1 - 36 files changed, 48 insertions(+), 50 deletions(-)
[GitHub] [camel-karavan] mgubaidullin commented on issue #112: JBang live reload
mgubaidullin commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975498471 If I use the following command ``` jbang -Dcamel.jbang.version=3.14.0-SNAPSHOT CamelJBang@apache/camel run timer-demo.yaml --max-messages=10 --logging-level=info --reload ``` After 10 messages route stops and program exit. I thought if we could just stop route after `-max-messages` without exit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin edited a comment on issue #112: JBang live reload
mgubaidullin edited a comment on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975498471 If I use the following command ``` jbang -Dcamel.jbang.version=3.14.0-SNAPSHOT CamelJBang@apache/camel run timer-demo.yaml --max-messages=10 --logging-level=info --reload ``` After 10 messages route stops and program exit. I thought if we could just stop route after `-max-messages` without exit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] davsclaus commented on issue #112: JBang live reload
davsclaus commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975517788 Ah but max duration(s) has always been to terminate the JVM application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] davsclaus commented on issue #112: JBang live reload
davsclaus commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975519643 Created a ticket https://issues.apache.org/jira/browse/CAMEL-17223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #112: JBang live reload
mgubaidullin commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975520464 We could terminate if no `reload` option or just stop route if there is a `reload` option -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #112: JBang live reload
mgubaidullin commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975522636 Are max-messages and max duration the same option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] 02/02: CAMEL-17224 - Bump Maven Wrapper to 3.8.4
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git commit fa5e4cce847bbe3bfc73c442149aecb1a2ed040e Author: Andrea Cosentino AuthorDate: Mon Nov 22 14:31:35 2021 +0100 CAMEL-17224 - Bump Maven Wrapper to 3.8.4 --- .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index 4643c8f..598fb34 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -1,2 +1,2 @@ -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.3/apache-maven-3.8.4-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar
[camel] 01/02: CAMEL-17224 - Bump Maven Wrapper to 3.8.4
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git commit 6c80e022e6514b902ed339e5c0214ff56e04ed98 Author: Andrea Cosentino AuthorDate: Mon Nov 22 14:30:06 2021 +0100 CAMEL-17224 - Bump Maven Wrapper to 3.8.4 --- .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index a9f1ef8..4643c8f 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -1,2 +1,2 @@ -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.3/apache-maven-3.8.3-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.3/apache-maven-3.8.4-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar
[camel] branch main updated (1511045 -> fa5e4cc)
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/camel.git. from 1511045 camel-jbang - Polished new 6c80e02 CAMEL-17224 - Bump Maven Wrapper to 3.8.4 new fa5e4cc CAMEL-17224 - Bump Maven Wrapper to 3.8.4 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [camel-karavan] davsclaus commented on issue #112: JBang live reload
davsclaus commented on issue #112: URL: https://github.com/apache/camel-karavan/issues/112#issuecomment-975526061 No, one is X number of messages in total processed, and the other is after X seconds (time). And there is also a 3rd about being idle (eg no messages after X time) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-karavan] davsclaus opened a new issue #116: JBang - run in JVM debug mode so you can do JVM remote debugging
davsclaus opened a new issue #116: URL: https://github.com/apache/camel-karavan/issues/116 We should find out if we can launch jbang in JVM debug mode (there are some JVM flags you need to turn on, to make it debug mode on port 5005, and suspend=y etc. And if so we should find out if we can make VSCode detect this and be able to debug the Camel code. Not sure how easy it is for it to know which JARs to have on its project and so on. But its also a more general problem with jbang, so we can talk to Max about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch main updated: CAMEL-17202: camel-rest-openapi - If two openapi spec uses the same path only one rest endpoint is created. Thanks to Henrik Karlsson for the example that reproduces this
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/main by this push: new a3d00dc CAMEL-17202: camel-rest-openapi - If two openapi spec uses the same path only one rest endpoint is created. Thanks to Henrik Karlsson for the example that reproduces this bug. a3d00dc is described below commit a3d00dcc3557bc73314e26f43fe6ebc31a8fcafb Author: Claus Ibsen AuthorDate: Mon Nov 22 14:45:41 2021 +0100 CAMEL-17202: camel-rest-openapi - If two openapi spec uses the same path only one rest endpoint is created. Thanks to Henrik Karlsson for the example that reproduces this bug. --- .../camel/component/rest/openapi/RestOpenApiEndpoint.java | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/components/camel-rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiEndpoint.java b/components/camel-rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiEndpoint.java index 330adb9..17b6d1e 100644 --- a/components/camel-rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiEndpoint.java +++ b/components/camel-rest-openapi/src/main/java/org/apache/camel/component/rest/openapi/RestOpenApiEndpoint.java @@ -340,15 +340,19 @@ public final class RestOpenApiEndpoint extends DefaultEndpoint { final Document openapi, final OasOperation operation, final String method, final String uriTemplate) throws Exception { -final String basePath = determineBasePath(openapi); -final String componentEndpointUri = "rest:" + method + ":" + basePath + ":" + uriTemplate; -final CamelContext camelContext = getCamelContext(); - -final Endpoint endpoint = camelContext.getEndpoint(componentEndpointUri); +CamelContext camelContext = getCamelContext(); Map params = determineEndpointParameters(openapi, operation); boolean hasHost = params.containsKey("host"); + +String basePath = determineBasePath(openapi); +String componentEndpointUri = "rest:" + method + ":" + basePath + ":" + uriTemplate; +if (hasHost) { +componentEndpointUri += "?host=" + params.get("host"); +} + +Endpoint endpoint = camelContext.getEndpoint(componentEndpointUri); // let the rest endpoint configure itself endpoint.configureProperties(params);
[camel] branch main updated: Indentation of Parent POM
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/main by this push: new 5ab93c8 Indentation of Parent POM 5ab93c8 is described below commit 5ab93c890acd3abf356aae50c0fa59b064291037 Author: Andrea Cosentino AuthorDate: Mon Nov 22 14:51:19 2021 +0100 Indentation of Parent POM --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 78abad6..8e36525 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -246,7 +246,7 @@ 4.4.14 4.5.13 4.1.4 - 3.21.4.1 + 3.21.4.1 3.0.59 1.5.18 1.0.7
[GitHub] [camel-k] k0pper commented on issue #2765: How to use a custom Kamelet Repository?
k0pper commented on issue #2765: URL: https://github.com/apache/camel-k/issues/2765#issuecomment-975553494 ... When trying to deploy a KameletBinding: ``` apiVersion: camel.apache.org/v1alpha1 kind: KameletBinding metadata: name: my-earthquake-log spec: source: ref: kind: Kamelet apiVersion: camel.apache.org/v1alpha1 name: earthquake-source sink: ref: kind: Kamelet apiVersion: camel.apache.org/v1alpha1 name: log-sink ``` I get the error that the URI for the kamelet repository was invalid: ``` {"level":"info","ts":1637588929.720187,"logger":"camel-k.trait","msg":"Apply trait: init"} {"level":"info","ts":1637588929.7207434,"logger":"camel-k.trait","msg":"Apply trait: camel"} {"level":"info","ts":1637588929.7224216,"logger":"camel-k.trait","msg":"Apply trait: kamelets"} {"level":"error","ts":1637588929.7234652,"logger":"controller-runtime.manager.controller.integration-controller","msg":"Reconciler error","name":"my-earthquake-log","namespace":"camel-k","error":"error during trait customization: invalid uri: github.com/k0pper/custom-kamelets","errorVerbose":"invalid uri: github.com/k0pper/custom-kamelets\nerror during trait customization ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on pull request #3314: Disable FOP integration test failed in native mode on Mac OS #3280
ffang commented on pull request #3314: URL: https://github.com/apache/camel-quarkus/pull/3314#issuecomment-97522 Thanks @jamesnetherton @aldettinger @oscerd ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #3310: Graceful shutdown strategy used as default one
jamesnetherton merged pull request #3310: URL: https://github.com/apache/camel-quarkus/pull/3310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #3179: `quarkus.camel.main.shutdown.timeout` doesn't work as intended
jamesnetherton closed issue #3179: URL: https://github.com/apache/camel-quarkus/issues/3179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-quarkus] branch main updated: Graceful shutdown strategy used as default one
This is an automated email from the ASF dual-hosted git repository. jamesnetherton pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git The following commit(s) were added to refs/heads/main by this push: new 79b7a7a Graceful shutdown strategy used as default one 79b7a7a is described below commit 79b7a7a37577d8eff9e00654b2eadc640402a39c Author: JiriOndrusek AuthorDate: Fri Nov 19 10:00:34 2021 +0100 Graceful shutdown strategy used as default one --- docs/modules/ROOT/pages/migration-guide/2.6.0.adoc | 19 +++ docs/modules/ROOT/pages/migration-guide/index.adoc | 1 + .../core/deployment/CamelContextProcessor.java | 20 +++ .../CamelContextDefaultStrategyTest.java | 38 + .../camel/quarkus/core/CamelContextRecorder.java | 4 ++ .../camel/quarkus/core/FastCamelContext.java | 3 +- ...lContextDefaultShutdownStrategyDevModeTest.java | 64 ++ .../CamelContextNoShutdownStrategyDevModeTest.java | 43 +++ .../camel/quarkus/main/CamelSupportResource.java | 7 +++ 9 files changed, 175 insertions(+), 24 deletions(-) diff --git a/docs/modules/ROOT/pages/migration-guide/2.6.0.adoc b/docs/modules/ROOT/pages/migration-guide/2.6.0.adoc new file mode 100644 index 000..81dd32c --- /dev/null +++ b/docs/modules/ROOT/pages/migration-guide/2.6.0.adoc @@ -0,0 +1,19 @@ += Camel Quarkus 2.6.0 Migration Guide + +The following guide outlines how to adapt your code to changes that were made in Camel Quarkus 2.6.0 & Quarkus 2.6.0.Final. + +== Graceful shutdown strategy is used by default + +In previous releases, graceful shutdown strategy (default strategy in Camel, see https://camel.apache.org/manual/graceful-shutdown.html[documentation] ) wasn't used by default. +Shutdown wasn't controlled by any strategy. + +This is no longer the case. +Graceful shutdown strategy is enabled by default (see https://camel.apache.org/manual/graceful-shutdown.html[documentation]) with one exception only. +If timeout for graceful shutdown is not set and application runs in a development mode, no shutdown strategy is used (behavior for the development mode without timeout for graceful timeout wasn't changed). + +`DefaultShutdownStrategy` could be configured via `application.properties`. +For example: +``` +#set graceful timeout to 15 seconds +camel.main.shutdownTimeout = 15 +``` diff --git a/docs/modules/ROOT/pages/migration-guide/index.adoc b/docs/modules/ROOT/pages/migration-guide/index.adoc index cca6a59..a53106e 100644 --- a/docs/modules/ROOT/pages/migration-guide/index.adoc +++ b/docs/modules/ROOT/pages/migration-guide/index.adoc @@ -4,6 +4,7 @@ We do frequent releases, a release almost every month, and even though we strive Listed here are guides on how to migrate between major versions and anything of significance to watch for when upgrading from minor versions. +* xref:migration-guide/2.6.0.adoc[Camel Quarkus 2.5.0 to Camel Quarkus 2.6.0 migration guide] * xref:migration-guide/2.2.0.adoc[Camel Quarkus 2.1.0 to Camel Quarkus 2.2.0 migration guide] * xref:migration-guide/2.1.0.adoc[Camel Quarkus 2.0.0 to Camel Quarkus 2.1.0 migration guide] * xref:migration-guide/2.0.0.adoc[Camel Quarkus 1.x to Camel Quarkus 2.0.0 migration guide] diff --git a/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelContextProcessor.java b/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelContextProcessor.java index 73aa229..814ac56 100644 --- a/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelContextProcessor.java +++ b/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelContextProcessor.java @@ -25,6 +25,8 @@ import java.util.stream.Collectors; import io.quarkus.arc.deployment.BeanContainerBuildItem; import io.quarkus.arc.deployment.BeanDiscoveryFinishedBuildItem; import io.quarkus.arc.deployment.SyntheticBeansRuntimeInitBuildItem; +import io.quarkus.deployment.IsDevelopment; +import io.quarkus.deployment.annotations.BuildProducer; import io.quarkus.deployment.annotations.BuildStep; import io.quarkus.deployment.annotations.Consume; import io.quarkus.deployment.annotations.ExecutionTime; @@ -103,6 +105,24 @@ public class CamelContextProcessor { } /** + * This step customizes camel context for development mode. + * + * @param recorder the recorder + * @param producer producer of context customizer build item + */ +@Record(ExecutionTime.STATIC_INIT) +@BuildStep(onlyIf = IsDevelopment.class) +public void devModeCamelContextCustomizations( +CamelContextRecorder recorder, +BuildProducer producer) { +String val = CamelSupport.getOptionalConfigValue("camel.main.shutdownTimeout", String.class, null); +if (val == null) { +//if no graceful time
[GitHub] [camel-k] hguerrero commented on issue #2585: Add the option to inject the integration container as a side car to another deployment
hguerrero commented on issue #2585: URL: https://github.com/apache/camel-k/issues/2585#issuecomment-975574331 Hi @astefanutti any update on the possible _sidecar_ deployment strategy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch regen_bot updated (1511045 -> fa5e4cc)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. from 1511045 camel-jbang - Polished add 6c80e02 CAMEL-17224 - Bump Maven Wrapper to 3.8.4 add fa5e4cc CAMEL-17224 - Bump Maven Wrapper to 3.8.4 No new revisions were added by this update. Summary of changes: .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [camel-k] astefanutti commented on pull request #2767: chore(build): Upgrade Maven to version 3.8.4
astefanutti commented on pull request #2767: URL: https://github.com/apache/camel-k/pull/2767#issuecomment-975580019 Let's merge this, the CI failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel-k] branch main updated: chore(build): Upgrade Maven to version 3.8.4
This is an automated email from the ASF dual-hosted git repository. astefanutti pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-k.git The following commit(s) were added to refs/heads/main by this push: new fa624e1 chore(build): Upgrade Maven to version 3.8.4 fa624e1 is described below commit fa624e11cb181b12e44923c9db3cd5a24e330cbb Author: Antonin Stefanutti AuthorDate: Mon Nov 22 13:52:38 2021 +0100 chore(build): Upgrade Maven to version 3.8.4 --- build/Dockerfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build/Dockerfile b/build/Dockerfile index a9383f7..f00f140 100644 --- a/build/Dockerfile +++ b/build/Dockerfile @@ -15,10 +15,10 @@ FROM quay.io/quarkus/ubi-quarkus-mandrel:21.2.0.0-Final-java11 -ARG MAVEN_VERSION="3.8.3" +ARG MAVEN_VERSION="3.8.4" ARG MAVEN_HOME="/usr/share/maven" -ARG SHA="1c12a5df43421795054874fd54bb8b37d242949133b5bf6052a063a13a93f13a20e6e9dae2b3d85b9c7034ec977bbc2b6e7f66832182b9c863711d78bfe60faa" -ARG BASE_URL="https://downloads.apache.org/maven/maven-3/${MAVEN_VERSION}/binaries"; +ARG SHA="a9b2d825eacf2e771ed5d6b0e01398589ac1bfa4171f36154d1b5787879605507802f699da6f7cfc80732a5282fd31b28e4cd6052338cbef0fa1358b48a5e3c8" +ARG BASE_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries"; USER 0
[GitHub] [camel-k] astefanutti merged pull request #2767: chore(build): Upgrade Maven to version 3.8.4
astefanutti merged pull request #2767: URL: https://github.com/apache/camel-k/pull/2767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #2585: Add the option to inject the integration container as a side car to another deployment
astefanutti commented on issue #2585: URL: https://github.com/apache/camel-k/issues/2585#issuecomment-975586564 Hi @hguerrero no update yet. While the general idea seems clear, I realise that this could help if you have a pointer to a use case that you would want use to reuse / focus on, so as to make sure we are in line with what you have in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[camel] branch regen_bot updated (fa5e4cc -> a3d00dc)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. from fa5e4cc CAMEL-17224 - Bump Maven Wrapper to 3.8.4 add a3d00dc CAMEL-17202: camel-rest-openapi - If two openapi spec uses the same path only one rest endpoint is created. Thanks to Henrik Karlsson for the example that reproduces this bug. No new revisions were added by this update. Summary of changes: .../camel/component/rest/openapi/RestOpenApiEndpoint.java | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)
[camel] branch regen_bot updated (a3d00dc -> 5ab93c8)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch regen_bot in repository https://gitbox.apache.org/repos/asf/camel.git. from a3d00dc CAMEL-17202: camel-rest-openapi - If two openapi spec uses the same path only one rest endpoint is created. Thanks to Henrik Karlsson for the example that reproduces this bug. add 5ab93c8 Indentation of Parent POM No new revisions were added by this update. Summary of changes: parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [camel-k] astefanutti closed pull request #1624: Traits configuration API and schema
astefanutti closed pull request #1624: URL: https://github.com/apache/camel-k/pull/1624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] aldettinger opened a new pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
aldettinger opened a new pull request #3316: URL: https://github.com/apache/camel-quarkus/pull/3316 …n camel main is disabled #2978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3316: core: Add RouteConfigurationsBuilder before regular RoutesBuilder whe…
aldettinger commented on a change in pull request #3316: URL: https://github.com/apache/camel-quarkus/pull/3316#discussion_r754390810 ## File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelContextRecorder.java ## @@ -90,6 +93,8 @@ public void customize(RuntimeValue context, RuntimeValue context.setShutdownStrategy(new NoShutdownStrategy())); } Review comment: I've marked those recorded methods as deprecated. Maybe it's even ok to remove them ? I don't know what we have done in the past for that kind of situations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] cunningt opened a new pull request #6462: CAMEL-17062 Move camel-dependencies inside of camel-catalog to avoid deployment issues
cunningt opened a new pull request #6462: URL: https://github.com/apache/camel/pull/6462 https://issues.apache.org/jira/browse/CAMEL-17062 camel-dependencies has no dependencies and maven forces it early in the build order.camel-catalog syncs the properties to camel-dependencies, but that doesn't happen till after camel-dependencies builds and install, which creates a build order issue - the camel-dependencies that is installed and deployed is not the synced copy. An advantage to this approach is that if there are sync properties changes to camel-dependencies, the build is not overwriting source git files - camel-dependencies is synced within the target build directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba opened a new pull request #3317: Next is 2.6.0
zbendhiba opened a new pull request #3317: URL: https://github.com/apache/camel-quarkus/pull/3317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton opened a new issue #3318: Document that `vertx-websocket` consumers run on the Quarkus Vert.x web server
jamesnetherton opened a new issue #3318: URL: https://github.com/apache/camel-quarkus/issues/3318 The docs are missing this piece of information, so we should add it. We could maybe consider lifting this restriction. When I originally wrote the extension I figured it was more optimal to leverage the existing Quarkus Vert.x router like we do with `platform-http`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r51038 - in /release/camel/camel-quarkus: 2.4.0/ 2.5.0/ 2.5.0/apache-camel-quarkus-2.5.0-src.zip 2.5.0/apache-camel-quarkus-2.5.0-src.zip.asc 2.5.0/apache-camel-quarkus-2.5.0-src.zip.sha51
Author: zbendhiba Date: Mon Nov 22 16:20:49 2021 New Revision: 51038 Log: Apache Camel Quarkus 2.5.0 released artifacts Added: release/camel/camel-quarkus/2.5.0/ release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip (with props) release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.asc (with props) release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.sha512 Removed: release/camel/camel-quarkus/2.4.0/ Added: release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip == Binary file - no diff available. Propchange: release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip -- svn:mime-type = application/zip Added: release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.asc == Binary file - no diff available. Propchange: release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.asc -- svn:mime-type = application/pgp-signature Added: release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.sha512 == --- release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.sha512 (added) +++ release/camel/camel-quarkus/2.5.0/apache-camel-quarkus-2.5.0-src.zip.sha512 Mon Nov 22 16:20:49 2021 @@ -0,0 +1 @@ +ed5024d66ba8159154eb75c0e06e33ce76c08d00a27d12633bf89dac03fce76e27fbe13f47e9bd0443507a988ab8b68312e02d95d69e9f832526e350566fa6c1 apache-camel-quarkus-2.5.0-src.zip
[GitHub] [camel] colin-mullikin opened a new pull request #6463: Add namespace to path used for leadership election when using Zookeeper with Master component
colin-mullikin opened a new pull request #6463: URL: https://github.com/apache/camel/pull/6463 This allows different routes to have separate leaders based on the namespace defined (i.e. "master:namespace1" and "master:namespace2" could run on separate cluster members, as long as they are each running on only one). The camel-consul component already works this way in conjunction with the camel-master component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] shuhua-wang opened a new issue #2768: Is there any resources requirements for camel-k operator Deployment?
shuhua-wang opened a new issue #2768: URL: https://github.com/apache/camel-k/issues/2768 I am deploying the camel-k operator using helm charts provided in this repo. However I didn't find any resources requirements for the Pod of camel-k operator in the values.yaml file. Such as: resources: limits: cpu: memory: requests: cpu: memory: Is there any recommendation for those requirements when using camel-k operator? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #3317: Next is 2.6.0
ppalaga merged pull request #3317: URL: https://github.com/apache/camel-quarkus/pull/3317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #2766: gosec
lburgazzoli commented on pull request #2766: URL: https://github.com/apache/camel-k/pull/2766#issuecomment-976009518 @astefanutti @squakez I've somehow fixed some of the issues reported by `golanci-lint` and `gosec`, however I need some feedback for the fixes in particular for [this](https://github.com/apache/camel-k/pull/2766/commits/0a5b577a1a423db5c58019f98acd88afdb685998) commit where I've tried to address deferring invocation of "Close" on type "*os.File", like: ```go f, err := os.Open("/foo/bar.txt") if err != nil { return err } defer f.Close() ``` The reason of this finding is that, when deferring the method call, we don't check if the file is really closed or not and in most of the case it is probably ok (it looks like the standard library is doing so) but it may cause very subtle bugs like we may leak file descriptor that may or may not impact the behavior of the application at some point (i.e. you may run out of file descriptors). So I think that when possible this problem should be addressed. However it is not very clear how to implement it. Some hint may be found in this blog post: https://www.joeshaw.org/dont-defer-close-on-writable-files. I've tried to implement what is written in that post but it does not seem to be applicable as a general rule so I ended up with some slightly different way (that also leverage some of the hints from the blog) that make use of closures. I'm not sure if that is the right approach or not so any feedback would be more that welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli edited a comment on pull request #2766: gosec
lburgazzoli edited a comment on pull request #2766: URL: https://github.com/apache/camel-k/pull/2766#issuecomment-976009518 @astefanutti @squakez I've somehow fixed some of the issues reported by `golanci-lint` and `gosec`, however I need some feedback for the fixes in particular for [this](https://github.com/apache/camel-k/pull/2766/commits/0a5b577a1a423db5c58019f98acd88afdb685998) commit where I've tried to address deferring invocation of "Close" on type "*os.File", like: ```go f, err := os.Open("/foo/bar.txt") if err != nil { return err } defer f.Close() ``` The reason of this finding is that, when deferring the method call, we don't check if the file is really closed or not and in most of the case it is probably ok but it may cause very subtle bugs like we may leak file descriptor that may or may not impact the behavior of the application at some point (i.e. you may run out of file descriptors). So I think that when possible this problem should be addressed. However it is not very clear how to implement it. Some hint may be found in this blog post: https://www.joeshaw.org/dont-defer-close-on-writable-files. I've tried to implement what is written in that post but it does not seem to be applicable as a general rule so I ended up with some slightly different way (that also leverage some of the hints from the blog) that make use of closures. I'm not sure if that is the right approach or not so any feedback would be more that welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #2766: gosec
lburgazzoli commented on pull request #2766: URL: https://github.com/apache/camel-k/pull/2766#issuecomment-976014782 gosec action is not allowed, I've raised an issue: https://issues.apache.org/jira/browse/INFRA-22558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on pull request #2246: Allow configuring target docker repository name via IntegrationPlatformBuildSpec
github-actions[bot] commented on pull request #2246: URL: https://github.com/apache/camel-k/pull/2246#issuecomment-976026502 This PR has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] github-actions[bot] closed issue #2558: Kamelet: default KameletBindings configuration settings
github-actions[bot] closed issue #2558: URL: https://github.com/apache/camel-k/issues/2558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org