[GitHub] [camel-kamelets] mthirion opened a new pull request, #1245: KafkaKameletsWithScram512

[GitBox]

mthirion opened a new pull request, #1245:
URL: https://github.com/apache/camel-kamelets/pull/1245

   Added a Kafka sink and Kafka source Kamelet definition that support 
SCRAM-SHA-512 authentication.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on issue #4434: js-dsl: JavaScriptDslTest is failing on quarkus-platform

[GitBox]

aldettinger commented on issue #4434:
URL: https://github.com/apache/camel-quarkus/issues/4434#issuecomment-1398629526

   In this case, the JDK version and OS might not be the issue.
   The test is working on camel-quarkus but failing on quarkus-platform.
   They key information might be that the camel-quarkus tests are repackaged 
into quarkus-platform tests.
   Once repackaged in the platform, the mjs file might be accessible as a 
resource but not a file.
   This is a common tips when dealing with camel-quarkus and quarkus-platform.
   
   From there, maybe there is a way to influence the import resolution to match 
resources or tmp file. Maybe even just in the the context of tests. Or work 
with a kind of tmp file.
   
   Indeed, worst case it could be disabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] essobedo commented on issue #4434: js-dsl: JavaScriptDslTest is failing on quarkus-platform

[GitBox]

essobedo commented on issue #4434:
URL: https://github.com/apache/camel-quarkus/issues/4434#issuecomment-1398593485

   I cannot reproduce it on a MacOS with Temurin 11.0.18+10 and on the docker 
image `maven:3-eclipse-temurin-11`. The best, I can do is to remove this 
particular use case (ability to import modules), is-it acceptable for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] klease merged pull request #9182: Simplify creation of SSL context for WireMock Jetty server.

[GitBox]

klease merged PR #9182:
URL: https://github.com/apache/camel/pull/9182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin commented on pull request #629: Make Quinoa work

[GitBox]

mgubaidullin commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398566478

   I will ping you when we need `npm ci` work ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin commented on pull request #629: Make Quinoa work

[GitBox]

mgubaidullin commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398565702

   Thank you @ia3andy. Welcome to Karavan contributors!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin merged pull request #629: Make Quinoa work

[GitBox]

mgubaidullin merged PR #629:
URL: https://github.com/apache/camel-karavan/pull/629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

squakez commented on code in PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#discussion_r1082701027


##
pkg/client/camel/applyconfiguration/core/v1/affinity.go:
##
@@ -0,0 +1,58 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// Code generated by applyconfiguration-gen. DO NOT EDIT.
+
+package v1
+
+// AffinityApplyConfiguration represents an declarative configuration of the 
Affinity type for use
+// with apply.
+type AffinityApplyConfiguration struct {

Review Comment:
   I think this is some issue with the autogen. We should not have kubernetes 
resources here I guess. @astefanutti fyi



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #9183: Prevent high channel churn in a queue full scenario

[GitBox]

essobedo commented on PR #9183:
URL: https://github.com/apache/camel/pull/9183#issuecomment-1398560691

   But there is also a formatting issue in your code:
   
   ```
   [ERROR] Failed to execute goal 
net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (validate) on 
project camel-rabbitmq: File 
'/home/runner/work/camel/camel/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQMessagePublisher.java'
 has not been previously formatted.  Please format file and commit before 
running validation! -> [Help 1]
   ```
   
   Launch the command `mvn formatter:format`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #9183: Prevent high channel churn in a queue full scenario

[GitBox]

essobedo commented on PR #9183:
URL: https://github.com/apache/camel/pull/9183#issuecomment-1398556825

   The checkstyle issue is not related to your changes but is more in 
`camel-jbang-core`:
   
   ```
   [ERROR] 
/home/runner/work/camel/camel/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/CodeRestGenerator.java:108:22:
 Name 'CODE' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]
   [ERROR] 
/home/runner/work/camel/camel/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/CodeRestGenerator.java:109:22:
 Name 'GENERATOR_NAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[LocalFinalVariableName]
   [ERROR] 
/home/runner/work/camel/camel/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/CodeRestGenerator.java:110:22:
 Name 'LIBRARY' must match pattern '^[a-z][a-zA-Z0-9]*$'. 
[LocalFinalVariableName]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] groundhog2k commented on pull request #9183: Prevent high channel churn in a queue full scenario

[GitBox]

groundhog2k commented on PR #9183:
URL: https://github.com/apache/camel/pull/9183#issuecomment-1398547394

   What is the reason that the pipeline failed? I can't see any root cause in 
the logs - only "error 1" !? Anything I can do/fix here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9181: Prevent high channel churn in a queue full scenario

[GitBox]

github-actions[bot] commented on PR #9181:
URL: https://github.com/apache/camel/pull/9181#issuecomment-1398538402

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] oscerd merged pull request #9184: Generated sources regen for SBOM

[GitBox]

oscerd merged PR #9184:
URL: https://github.com/apache/camel/pull/9184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] opened a new pull request, #9184: Generated sources regen for SBOM

[GitBox]

github-actions[bot] opened a new pull request, #9184:
URL: https://github.com/apache/camel/pull/9184

   Regen bot :robot: found some uncommitted changes after running build on 
:camel: `main` branch for generating SBOMs.
   Please do not delete `regen_bot_sbom` branch after merge/rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9183: Prevent high channel churn in a queue full scenario

[GitBox]

github-actions[bot] commented on PR #9183:
URL: https://github.com/apache/camel/pull/9183#issuecomment-1398499252

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 1 | 0 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy commented on pull request #629: Make Quinoa work

[GitBox]

ia3andy commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398497649

   I've tried to use `npm ci` (frozen-lockfile) in the quinoa build but for 
some reason it's not happy with the local dependency so I disabled it (which 
was already the case anyway since CI was set to false).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy commented on pull request #629: Make Quinoa work

[GitBox]

ia3andy commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398496077

   @mgubaidullin the Quinoa build part is passing on my fork, there is an error 
when pushing the image afteward but I guess it won't happen on this repo. So 
it's good to be merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9182: Simplify creation of SSL context for WireMock Jetty server.

[GitBox]

github-actions[bot] commented on PR #9182:
URL: https://github.com/apache/camel/pull/9182#issuecomment-1398490514

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] andreaTP commented on pull request #3994: [proposal] Publish a generated extension using jbang and jitpack

[GitBox]

andreaTP commented on PR #3994:
URL: https://github.com/apache/camel-k/pull/3994#issuecomment-1398477467

   > who is going to consume such new configurations
   
   Here we are publishing standard Java Artifacts (i.e. a `jar` file and 
additional metadata) not configuration.
   Users that want to programmatically access camel-k Custom Resources with a 
typed interface using Java can add the dependency to their project and use it 
as shown in the snippet above.
   
   > how the jar will end up into `com.github.andreaTP:camel-k:0.0.2-SNAPSHOT`
   
   `com.github.andreaTP` comes from the fact that I published using my fork of 
this project, if you decide to merge this PR the published artifacts will be 
named: `com.github.apache:camel-k:`, this is an intrinsic of 
https://jitpack.io/
   
   > I suppose you have some process that will use this configuration for 
publishing the artifact, is it so?
   
   that's jitpack.io , you can publish the library to Maven Central but this 
will require more setup/credentials etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

squakez commented on code in PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#discussion_r1082608404


##
script/Makefile:
##
@@ -212,7 +212,8 @@ codegen-tools-install: controller-gen
@# We must force the installation to make sure we are using the correct 
version
@# Note: as there is no --version in the tools, we cannot rely on 
cached local versions
@echo "Installing k8s.io/code-generator tools with version 
$(CODEGEN_VERSION)"
-   go install 
k8s.io/code-generator/cmd/applyconfiguration-gen@$(CODEGEN_VERSION)
+   #go install 
k8s.io/code-generator/cmd/applyconfiguration-gen@$(CODEGEN_VERSION)
+   go install 
github.com/astefanutti/code-generator/cmd/applyconfiguration-gen@pr-144-install

Review Comment:
   Okey, please, let's track and make sure to follow up it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #3995: chore(deps): bump github.com/spf13/viper from 1.14.0 to 1.15.0

[GitBox]

squakez merged PR #3995:
URL: https://github.com/apache/camel-k/pull/3995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] essobedo commented on pull request #4428: Ref #4426: Support CSimple expressions with all DSLs

[GitBox]

essobedo commented on PR #4428:
URL: https://github.com/apache/camel-quarkus/pull/4428#issuecomment-1398462736

   That's weird, the build complained about uncommitted files that are not even 
related to these changes (cxf and controlbus-statistics).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on issue #3996: Camel-k checks other namespaces and error given

[GitBox]

squakez commented on issue #3996:
URL: https://github.com/apache/camel-k/issues/3996#issuecomment-1398456703

   Yes, that is a kind of INFO, but as it is misleading I suggest we even 
remove it. You can just ignore for the time being.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #3994: [proposal] Publish a generated extension using jbang and jitpack

[GitBox]

squakez commented on PR #3994:
URL: https://github.com/apache/camel-k/pull/3994#issuecomment-1398454905

   What I still miss to understand who is going to consume such new 
configurations and how the jar will end up into 
`com.github.andreaTP:camel-k:0.0.2-SNAPSHOT`. I suppose you have some process 
that will use this configuration for publishing the artifact, is it so?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] lburgazzoli commented on pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

lburgazzoli commented on PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#issuecomment-1398452397

   > > @astefanutti @squakez @tadayosi @claudio4j it lacks a test for 
integration that are scaled > 1, let me know if the test should be part of this 
pr or can wait for a second iteration.
   > 
   > Feel free to track it in a follow up issue and work it later.
   
   https://github.com/apache/camel-k/issues/3997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] lburgazzoli opened a new issue, #3997: Create a test for structured health check conditions

[GitBox]

lburgazzoli opened a new issue, #3997:
URL: https://github.com/apache/camel-k/issues/3997

   Original discussion: 
https://github.com/apache/camel-k/pull/3977#issuecomment-1398432246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

lburgazzoli commented on code in PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#discussion_r1082589295


##
script/Makefile:
##
@@ -212,7 +212,8 @@ codegen-tools-install: controller-gen
@# We must force the installation to make sure we are using the correct 
version
@# Note: as there is no --version in the tools, we cannot rely on 
cached local versions
@echo "Installing k8s.io/code-generator tools with version 
$(CODEGEN_VERSION)"
-   go install 
k8s.io/code-generator/cmd/applyconfiguration-gen@$(CODEGEN_VERSION)
+   #go install 
k8s.io/code-generator/cmd/applyconfiguration-gen@$(CODEGEN_VERSION)
+   go install 
github.com/astefanutti/code-generator/cmd/applyconfiguration-gen@pr-144-install

Review Comment:
   I think @astefanutti has prepared a pr to fix this upstream



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

lburgazzoli commented on code in PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#discussion_r1082588838


##
script/gen_client.sh:
##
@@ -17,7 +17,7 @@
 
 location=$(dirname $0)
 
-unset GOPATH
+#unset GOPATH

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

lburgazzoli commented on code in PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#discussion_r1082588522


##
e2e/global/common/traits/health_test.go:
##
@@ -104,20 +106,190 @@ func TestHealthTrait(t *testing.T) {
//
Eventually(IntegrationCondition(ns, name, 
v1.IntegrationConditionReady), TestTimeoutLong).Should(And(
WithTransform(IntegrationConditionReason, 
Equal(v1.IntegrationConditionRuntimeNotReadyReason)),
-   WithTransform(IntegrationConditionMessage, 
HavePrefix(
-   fmt.Sprintf(
-   "[Pod %s runtime is not ready: 
map[check.kind:READINESS route.id:route1 route.status:Stopped]",
-   pod.Name))),
-   ))
+   WithTransform(IntegrationConditionMessage, 
Equal("1/1 pods are not ready"
+
+   Eventually(IntegrationCondition(ns, name, 
v1.IntegrationConditionReady), TestTimeoutLong).Should(
+   Satisfy(func(c *v1.IntegrationCondition) bool {
+   if c.Status != corev1.ConditionFalse {
+   return false
+   }
+   if len(c.Pods) != 1 {
+   return false
+   }
+
+   var r *v1.HealthCheckResponse
+
+   for h := range c.Pods[0].Health {
+   if c.Pods[0].Health[h].Name == 
"camel-routes" {
+   r = [0].Health[h]
+   }
+   }
+
+   if r == nil {
+   return false
+   }
+
+   if r.Data == nil {
+   return false
+   }
+
+   var data map[string]interface{}
+   if err := json.Unmarshal(r.Data, 
); err != nil {
+   return false
+   }
+
+   return data["check.kind"].(string) == 
"READINESS" && data["route.status"].(string) == "Stopped"
+   }))
+
// Check the Integration is still in running phase

Review Comment:
   done



##
pkg/apis/camel/v1/integration_types.go:
##
@@ -262,6 +262,8 @@ type IntegrationCondition struct {
Reason string `json:"reason,omitempty"`
// A human-readable message indicating details about the transition.
Message string `json:"message,omitempty"`
+   // TODO: add documentation

Review Comment:
   done



##
pkg/apis/camel/v1alpha1/kamelet_binding_types.go:
##
@@ -120,6 +120,8 @@ type KameletBindingCondition struct {
Reason string `json:"reason,omitempty"`
// A human readable message indicating details about the transition.
Message string `json:"message,omitempty"`
+   // TODO: add documentation

Review Comment:
   done



##
script/gen_client.sh:
##
@@ -26,7 +26,7 @@ cd $location/../pkg/client/camel
 echo "Generating Go client code..."
 
 $(go env GOPATH)/bin/applyconfiguration-gen \
-   
--input-dirs=github.com/apache/camel-k/pkg/apis/camel/v1,github.com/apache/camel-k/pkg/apis/camel/v1alpha1
 \
+   
--input-dirs=github.com/apache/camel-k/pkg/apis/camel/v1,github.com/apache/camel-k/pkg/apis/camel/v1alpha1i,k8s.io/apimachinery/pkg/apis/meta/v1,k8s.io/api/core/v1
 \

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on issue #3991: camel k bypassing maven settings.xml when using proxy

[GitBox]

squakez commented on issue #3991:
URL: https://github.com/apache/camel-k/issues/3991#issuecomment-1398443789

   I wonder if it is really using a custom maven repository at all. If you 
notice in my mock example:
   ```
   from/to repository-000 (http://my-repo): transfer failed for 
http://my-repo/org/apache/camel/k/camel-k-runtime-bom/1.16.0/camel-k-runtime-bom-1.16.0.pom,
 proxy: ProxyInfo{host='my-proxy', userName='null', port=80, type='http', 
nonProxyHosts='null'} @ line 15
   ```
   it shows it goes against a custom repo and it really use some proxy. For the 
sake of testing, I've run the following installation:
   ```
   kamel install --operator-env-vars=HTTP_PROXY=http://my-proxy 
--maven-repository http://my-repo
   ```
   Something it would be good to check is the IntegrationPlatform, in order to 
confirm that the repo is correctly configured (kubectl get ip -o yaml). And 
also, double check the configmap that holds the maven setting configuration. 
Feel free to post here all those info for further review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on issue #3982: Release 1.10.4

[GitBox]

squakez commented on issue #3982:
URL: https://github.com/apache/camel-k/issues/3982#issuecomment-1398435966

   Unfortunately https://github.com/apache/camel-k/pull/3897 is not an easy 
backport as it seems it requires to align almost completely to 1.11. For next 
release we won't include, which means we may delay as there is no other urgent 
things that will be included.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez closed pull request #3993: [1.10.x] fix: reconciliation loops behaviors

[GitBox]

squakez closed pull request #3993: [1.10.x] fix: reconciliation loops behaviors
URL: https://github.com/apache/camel-k/pull/3993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

squakez commented on PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#issuecomment-1398432246

   > @astefanutti @squakez @tadayosi @claudio4j it lacks a test for integration 
that are scaled > 1, let me know if the test should be part of this pr or can 
wait for a second iteration.
   
   Feel free to track it in a follow up issue and work it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on a diff in pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

squakez commented on code in PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#discussion_r1082551286


##
e2e/global/common/traits/health_test.go:
##
@@ -104,20 +106,190 @@ func TestHealthTrait(t *testing.T) {
//
Eventually(IntegrationCondition(ns, name, 
v1.IntegrationConditionReady), TestTimeoutLong).Should(And(
WithTransform(IntegrationConditionReason, 
Equal(v1.IntegrationConditionRuntimeNotReadyReason)),
-   WithTransform(IntegrationConditionMessage, 
HavePrefix(
-   fmt.Sprintf(
-   "[Pod %s runtime is not ready: 
map[check.kind:READINESS route.id:route1 route.status:Stopped]",
-   pod.Name))),
-   ))
+   WithTransform(IntegrationConditionMessage, 
Equal("1/1 pods are not ready"
+
+   Eventually(IntegrationCondition(ns, name, 
v1.IntegrationConditionReady), TestTimeoutLong).Should(
+   Satisfy(func(c *v1.IntegrationCondition) bool {
+   if c.Status != corev1.ConditionFalse {
+   return false
+   }
+   if len(c.Pods) != 1 {
+   return false
+   }
+
+   var r *v1.HealthCheckResponse
+
+   for h := range c.Pods[0].Health {
+   if c.Pods[0].Health[h].Name == 
"camel-routes" {
+   r = [0].Health[h]
+   }
+   }
+
+   if r == nil {
+   return false
+   }
+
+   if r.Data == nil {
+   return false
+   }
+
+   var data map[string]interface{}
+   if err := json.Unmarshal(r.Data, 
); err != nil {
+   return false
+   }
+
+   return data["check.kind"].(string) == 
"READINESS" && data["route.status"].(string) == "Stopped"
+   }))
+
// Check the Integration is still in running phase

Review Comment:
   Misleading comment. According to the statement below, it should be in error 
phase.



##
pkg/apis/camel/v1/integration_types.go:
##
@@ -262,6 +262,8 @@ type IntegrationCondition struct {
Reason string `json:"reason,omitempty"`
// A human-readable message indicating details about the transition.
Message string `json:"message,omitempty"`
+   // TODO: add documentation

Review Comment:
   Nitpick... you know otherwise nobody will ever bother to fix it :)



##
pkg/apis/camel/v1alpha1/kamelet_binding_types.go:
##
@@ -120,6 +120,8 @@ type KameletBindingCondition struct {
Reason string `json:"reason,omitempty"`
// A human readable message indicating details about the transition.
Message string `json:"message,omitempty"`
+   // TODO: add documentation

Review Comment:
   Ditto



##
script/gen_client.sh:
##
@@ -17,7 +17,7 @@
 
 location=$(dirname $0)
 
-unset GOPATH
+#unset GOPATH

Review Comment:
   If it not required, we better remove even the comment IMO



##
script/gen_client.sh:
##
@@ -26,7 +26,7 @@ cd $location/../pkg/client/camel
 echo "Generating Go client code..."
 
 $(go env GOPATH)/bin/applyconfiguration-gen \
-   
--input-dirs=github.com/apache/camel-k/pkg/apis/camel/v1,github.com/apache/camel-k/pkg/apis/camel/v1alpha1
 \
+   
--input-dirs=github.com/apache/camel-k/pkg/apis/camel/v1,github.com/apache/camel-k/pkg/apis/camel/v1alpha1i,k8s.io/apimachinery/pkg/apis/meta/v1,k8s.io/api/core/v1
 \

Review Comment:
   is `v1alpha1i` what we really need?



##
script/Makefile:
##
@@ -212,7 +212,8 @@ codegen-tools-install: controller-gen
@# We must force the installation to make sure we are using the correct 
version
@# Note: as there is no --version in the tools, we cannot rely on 
cached local versions
@echo "Installing k8s.io/code-generator tools with version 
$(CODEGEN_VERSION)"
-   go install 
k8s.io/code-generator/cmd/applyconfiguration-gen@$(CODEGEN_VERSION)
+   #go install 
k8s.io/code-generator/cmd/applyconfiguration-gen@$(CODEGEN_VERSION)
+   go 

[GitHub] [camel-k] lburgazzoli commented on pull request #3977: feat: Render error message condition as json/structured message

[GitBox]

lburgazzoli commented on PR #3977:
URL: https://github.com/apache/camel-k/pull/3977#issuecomment-1398430359

   @astefanutti @squakez @tadayosi @claudio4j it lacks a test for integration 
that are scaled > 1, let me know if the test should be part of this pr or can 
wait for a second iteration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #9181: Prevent high channel churn in a queue full scenario

[GitBox]

oscerd commented on PR #9181:
URL: https://github.com/apache/camel/pull/9181#issuecomment-1398427052

   Please don't close this one, this is a bug, so it should go on 3.20.x too, 
thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9183: Prevent high channel churn in a queue full scenario

[GitBox]

github-actions[bot] commented on PR #9183:
URL: https://github.com/apache/camel/pull/9183#issuecomment-1398425103

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] groundhog2k opened a new pull request, #9183: Prevent high channel churn in a queue full scenario

[GitBox]

groundhog2k opened a new pull request, #9183:
URL: https://github.com/apache/camel/pull/9183

   In a scenario with a high message publishing rate and a full queue the 
publisher will get "nack" (not acknowledged) as feedback from RabbitMQ.
   
   The method Channel#waitForConfirmsOrDie(long) in 
https://github.com/rabbitmq/rabbitmq-java-client/blob/main/src/main/java/com/rabbitmq/client/impl/ChannelN.java#L241
 will close the channel. This closed channel is then given back to the channel 
pool. Next time the channel is taken out of the pool it is detected as closed 
and will be removed. So a new channel needs to be opened and this too will be 
closed directly after usage when the same queue is still full. There will be a 
high rate of opened and closed communication channels and the channel pool gets 
unusable.
   
   This is described as high channel churn 
(https://www.rabbitmq.com/channels.html#high-channel-churn) and can have side 
effects on RabbitMQ (memory and cpu resource usage) and performance too.
   
   It was also discussed with folks from rabbitmq-java-client 
(rabbitmq/rabbitmq-java-client#942) and the usage of 
Channel#waitForConfirmsOrDie(long) is "highly NOT recommended" by them.
   
   This behavior affects ALL versions of the camel-rabbitmq component!
   
   # Description
   
   
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   
   
   - [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn 
-Psourcecheck`
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] groundhog2k closed pull request #9181: Prevent high channel churn in a queue full scenario

[GitBox]

groundhog2k closed pull request #9181: Prevent high channel churn in a queue 
full scenario
URL: https://github.com/apache/camel/pull/9181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] MazArslan opened a new issue, #3996: Camel-k checks other namespaces and error given

[GitBox]

MazArslan opened a new issue, #3996:
URL: https://github.com/apache/camel-k/issues/3996

   ```
   $ kamel run Integration.java --namespace user1-dev
   Unable to verify existence of operator id [camel-k] due to lack of user 
privileges
   Integration "integration" updated
   ```
   
   We get this error when running a integration against a set namespace. 
   The operator is installed in the namespace `user1-dev`rather than `camel-k` 
and there is no global operator. The command succeeds, but we get this `Unable 
to verify existence of operator id [camel-k] due to lack of user privileges`. 
We are logged in as a standard user, with limited rights. 
   
   It seems as if getting this error because it is trying to get operator info 
in other namespaces,  but the operator is installed in the `user1-dev` 
namespace. Why would it need to look for other resources in other namespaces. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions

[GitBox]

aldettinger commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398419074

   Indeed, well spotted, not all updates are to be consumed.
   
   Also, I'm thinking the dependabot approach would encourage to increase each 
quarkiverse.* version independently. I see this as a benefit at this stage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] klease commented on pull request #9182: Simplify creation of SSL context for WireMock Jetty server.

[GitBox]

klease commented on PR #9182:
URL: https://github.com/apache/camel/pull/9182#issuecomment-1398419394

   Now that wiremock has been upgraded to 3.x, it's possible to simplify the 
overriding class which sets the cipher suites.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] klease opened a new pull request, #9182: Simplify creation of SSL context for WireMock Jetty server.

[GitBox]

klease opened a new pull request, #9182:
URL: https://github.com/apache/camel/pull/9182

   Use the method JettyHttpServer.buildSslContextFactory in the new WireMock 
version to avoid having to override createHttpConnector.
   
   # Description
   
   
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   
   
   - [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn 
-Psourcecheck`
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9182: Simplify creation of SSL context for WireMock Jetty server.

[GitBox]

github-actions[bot] commented on PR #9182:
URL: https://github.com/apache/camel/pull/9182#issuecomment-1398418437

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] lburgazzoli commented on pull request #3993: [1.10.x] fix: reconciliation loops behaviors

[GitBox]

lburgazzoli commented on PR #3993:
URL: https://github.com/apache/camel-k/pull/3993#issuecomment-1398417838

   > No luck. I am not sure we can make a backport of the fix, unless we 
basically do all the rest of backports to align to version 1.11.x. cc 
@lburgazzoli
   
   ok, if not possible leave it as it is, we'll try to move to 1.11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #3993: [1.10.x] fix: reconciliation loops behaviors

[GitBox]

squakez commented on PR #3993:
URL: https://github.com/apache/camel-k/pull/3993#issuecomment-1398413260

   No luck. I am not sure we can make a backport of the fix, unless we 
basically do all the rest of backports to align to version 1.11.x. cc 
@lburgazzoli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy commented on pull request #629: Make Quinoa work

[GitBox]

ia3andy commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398412433

   I am testing on my local branch, for now it fails, but I am close to have it 
working..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] brunomendola commented on issue #620: Route not rendering under WLS 2

[GitBox]

brunomendola commented on issue #620:
URL: https://github.com/apache/camel-karavan/issues/620#issuecomment-1398408910

   I closed the remote folder in VS Code and opened it again. No changes.
   I even tried to lose the folder, delete the .vscode subdirectory and open 
the folder again...
   
   Still empty screen when I open the yaml with the Karavan extension.
   
   
![image](https://user-images.githubusercontent.com/1853562/213707888-3bf4c308-4a67-41a1-be18-6d5d556f7e37.png)
   
   
![image](https://user-images.githubusercontent.com/1853562/213707943-57021613-6356-4733-bd10-2b750e5af487.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9181: Prevent high channel churn in a queue full scenario

[GitBox]

github-actions[bot] commented on PR #9181:
URL: https://github.com/apache/camel/pull/9181#issuecomment-1398407562

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] groundhog2k opened a new pull request, #9181: Prevent high channel churn in a queue full scenario

[GitBox]

groundhog2k opened a new pull request, #9181:
URL: https://github.com/apache/camel/pull/9181

   In a scenario with a high message publishing rate and a full queue the 
publisher will get "nack" (not acknowledged) as feedback from RabbitMQ. 
   
   The method Channel#waitForConfirmsOrDie(long) in 
https://github.com/rabbitmq/rabbitmq-java-client/blob/main/src/main/java/com/rabbitmq/client/impl/ChannelN.java#L241
 will close the channel. This closed channel is then given back to the channel 
pool.  Next time the channel is taken out of the pool it is detected as closed 
and will be removed. So a new channel needs to be opened and this too will be 
closed directly after usage when the same queue is still full. There will be a 
high rate of opened and closed communication channels and the channel pool gets 
unusable. 
   
   This is described as high channel churn 
(https://www.rabbitmq.com/channels.html#high-channel-churn) and can have side 
effects on RabbitMQ (memory and cpu resource usage) and performance too.
   
   It was also discussed with folks from rabbitmq-java-client 
(rabbitmq/rabbitmq-java-client#942) and the usage of 
Channel#waitForConfirmsOrDie(long) is "highly NOT recommended" by them.
   
   This behavior affects ALL versions of the camel-rabbitmq component!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] mgubaidullin commented on pull request #629: Make Quinoa work

[GitBox]

mgubaidullin commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398400288

   > Something else I wasn't able to run locally because you need to have some 
envs `GIT_REPOSITORY `, ... could you add the way to configure it for local dev 
in the dev doc https://github.com/apache/camel-karavan/blob/main/DEV.md
   
   1. Check. Local run works fine 
   2. https://github.com/apache/camel-karavan/issues/630


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy commented on pull request #629: Make Quinoa work

[GitBox]

ia3andy commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398366516

   @oscerd @mgubaidullin we can't make sure currently it works as the CI is 
disabled if it's not main. I will test on my fork, please do not merge yet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy commented on pull request #629: Make Quinoa work

[GitBox]

ia3andy commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398355247

   Something else I wasn't able to run locally because you need to have some 
envs `GIT_REPOSITORY `, ... could you add the way to configure it for local dev 
in the dev doc https://github.com/apache/camel-karavan/blob/main/DEV.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] oscerd commented on pull request #629: Make Quinoa work

[GitBox]

oscerd commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398354977

   @mgubaidullin this is for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy commented on pull request #629: Make Quinoa work

[GitBox]

ia3andy commented on PR #629:
URL: https://github.com/apache/camel-karavan/pull/629#issuecomment-1398353011

   Also @valdar you should consider actually fixing what eslint is complaining 
about (or editing the rules)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-karavan] ia3andy opened a new pull request, #629: Make Quinoa work

[GitBox]

ia3andy opened a new pull request, #629:
URL: https://github.com/apache/camel-karavan/pull/629

   The problem is with ESLINT, in the CI, `CI=true` makes react-scripts do the 
eslint check in error mode. 
   In the maven-frontend-plugin config you had `CI=false` but this is wrong 
since it's not really the fix.
   
   I fixed the problem, let's see if the CI passes now..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions

[GitBox]

jamesnetherton commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398272370

   > I would vote to experiment with this.
   > 
   > I wonder what other think ?
   
   Yeah let's see how it works for us.
   
   For `quarkus-amazon-services` we maybe need to be a bit careful. I don't 
think we always want to merge version upgrades, given that project is a Quarkus 
Platform member and we should not use a version higher than what is specified 
there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton closed issue #3327: Sql derby - test exernal db if possible, remove workaround because of quarkus issue #21639

[GitBox]

jamesnetherton closed issue #3327: Sql derby - test exernal db if possible, 
remove workaround because of quarkus issue #21639
URL: https://github.com/apache/camel-quarkus/issues/3327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton merged pull request #3370: Sql test using derby doesn't start dev service and shows class loadin…

[GitBox]

jamesnetherton merged PR #3370:
URL: https://github.com/apache/camel-quarkus/pull/3370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kafka-connector] mundrusatish commented on issue #1504: camel-https-kafka-connector support for multiple HTTPS endpoints

[GitBox]

mundrusatish commented on issue #1504:
URL: 
https://github.com/apache/camel-kafka-connector/issues/1504#issuecomment-1398264613

   thanks @oscerd for the pointers.
   the base use case is to sink to two API's at a time based on codition (des 
above) still not possible from ckc. Pls confirm.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] aldettinger opened a new issue, #4434: js-dsl: JavaScriptDslTest is failing on quarkus-platform

[GitBox]

aldettinger opened a new issue, #4434:
URL: https://github.com/apache/camel-quarkus/issues/4434

   java.lang.RuntimeException: java.lang.RuntimeException: Failed to start 
quarkus
at 
io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:625)
at 
io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:696)
at 
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at 
org.junit.jupiter.api.extension.InvocationInterceptor.interceptTestClassConstructor(InvocationInterceptor.java:73)
at 
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at 
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
at 
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:62)
at 
org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeTestClassConstructor(ClassBasedTestDescriptor.java:363)
at 
org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateTestClass(ClassBasedTestDescriptor.java:310)
at 
org.junit.jupiter.engine.descriptor.ClassTestDescriptor.instantiateTestClass(ClassTestDescriptor.java:79)
at 
org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateAndPostProcessTestInstance(ClassBasedTestDescriptor.java:286)
at 
org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$4(ClassBasedTestDescriptor.java:278)
at java.base/java.util.Optional.orElseGet(Optional.java:369)
at 
org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$5(ClassBasedTestDescriptor.java:277)
at 
org.junit.jupiter.engine.execution.TestInstancesProvider.getTestInstances(TestInstancesProvider.java:31)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$prepare$0(TestMethodTestDescriptor.java:105)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:104)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:68)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$prepare$2(NodeTestTask.java:123)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.prepare(NodeTestTask.java:123)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:90)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at 

[GitHub] [camel] orpiske merged pull request #9178: (chores) camel-pulsar: fixes some errors shown in logs

[GitBox]

orpiske merged PR #9178:
URL: https://github.com/apache/camel/pull/9178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] orpiske merged pull request #9177: (chores) camel-kafka: disable connection check test on Apache CI

[GitBox]

orpiske merged PR #9177:
URL: https://github.com/apache/camel/pull/9177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] orpiske merged pull request #9179: (chores) build: removed outdated scripts

[GitBox]

orpiske merged PR #9179:
URL: https://github.com/apache/camel/pull/9179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9178: (chores) camel-pulsar: fixes some errors shown in logs

[GitBox]

github-actions[bot] commented on PR #9178:
URL: https://github.com/apache/camel/pull/9178#issuecomment-1398230122

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 1 | 0 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9178: (chores) camel-pulsar: fixes some errors shown in logs

[GitBox]

github-actions[bot] commented on PR #9178:
URL: https://github.com/apache/camel/pull/9178#issuecomment-1398222928

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 1 | 0 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9179: (chores) build: removed outdated scripts

[GitBox]

github-actions[bot] commented on PR #9179:
URL: https://github.com/apache/camel/pull/9179#issuecomment-1398220891

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9177: (chores) camel-kafka: disable connection check test on Apache CI

[GitBox]

github-actions[bot] commented on PR #9177:
URL: https://github.com/apache/camel/pull/9177#issuecomment-1398220603

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] andreaTP commented on pull request #3994: [proposal] Publish a generated extension using jbang and jitpack

[GitBox]

andreaTP commented on PR #3994:
URL: https://github.com/apache/camel-k/pull/3994#issuecomment-1398211837

   @squakez Sure, sorry for the missing context, here the ultimate goal is to 
provide the users a Java library to easily interact with typed Camel-K Custom 
Resources using the `fabric8` `kubernetes-client`.
   You can test the result of this PR using e.g. `jbang` and you will list the 
CamelCatalogs in a cluster with a script like:
   ```java
   //REPOS mavencentral,jitpack
   //DEPS io.fabric8:kubernetes-client:6.4.0
   //DEPS io.fabric8:generator-annotations:6.4.0
   //DEPS com.github.andreaTP:camel-k:0.0.2-SNAPSHOT
   
   import io.fabric8.kubernetes.client.*;
   import org.apache.camel.v1.*;
   public class testCamelKExtension {
   public static void main(String... args) {
   var client = new KubernetesClientBuilder().build();
   var camelCatalogClient = client.resources(CamelCatalog.class);
   camelCatalogClient.list().getItems().forEach(c -> {
   System.out.println(c.getMetadata().getName());
   });
   }
   }
   ```
   This is a user experience very close to the one offered by the current 
extension, let me know if you have any additional doubt or question, happy to 
clarify  .
   
   > So this would go in substitution of the crd extension for camel-k coming 
from the Kubernetes client project?
   
   @oscerd this is completely up for discussion, I'm proposing this alternative 
approach and we can think about keeping the 2 available for some time to see 
how this works out, wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] Tibor17 commented on pull request #1383: Upgrade to surefire/failsafe plugins 3.0.0-M8

[GitBox]

Tibor17 commented on PR #1383:
URL: https://github.com/apache/camel-quarkus/pull/1383#issuecomment-1398192346

   Hi Jiri,
   
   I am aware of such issue SUREFIRE-2143
   . It was never
   working. We are reworking the code in many places which would fix several
   issues at once. It will be a big change.
   
   On Thu, Jan 19, 2023 at 2:18 PM JiriOndrusek ***@***.***>
   wrote:
   
   > There is another problem with 3.0.0-M8, where skipped counts are not
   > correct when @ParametrizedTest is used (worked correctly in 2.22.2 or
   > 3.0.0-*M7). Reported as
   > https://issues.apache.org/jira/browse/SUREFIRE-2143
   >
   > —
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you commented.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] essobedo commented on pull request #4428: Ref #4426: Support CSimple expressions with all DSLs

[GitBox]

essobedo commented on PR #4428:
URL: https://github.com/apache/camel-quarkus/pull/4428#issuecomment-1398187311

   Note added and fallback solution proposed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] oscerd merged pull request #9180: Update publish-subscribe-channel.adoc

[GitBox]

oscerd merged PR #9180:
URL: https://github.com/apache/camel/pull/9180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] zhfeng commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions

[GitBox]

zhfeng commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398178560

   yeah. I think we can use `ignore` in yaml file to skip some artifacts or 
some version we don't want to update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9177: (chores) camel-kafka: disable connection check test on Apache CI

[GitBox]

github-actions[bot] commented on PR #9177:
URL: https://github.com/apache/camel/pull/9177#issuecomment-1398178390

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9180: Update publish-subscribe-channel.adoc

[GitBox]

github-actions[bot] commented on PR #9180:
URL: https://github.com/apache/camel/pull/9180#issuecomment-1398175889

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] OscarGalindo opened a new pull request, #9180: Update publish-subscribe-channel.adoc

[GitBox]

OscarGalindo opened a new pull request, #9180:
URL: https://github.com/apache/camel/pull/9180

   Simple typo
   
   # Description
   
   
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   
   
   - [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn 
-Psourcecheck`
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions

[GitBox]

aldettinger commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398171473

   So, when we want to skip a version. Then we just modify the yaml file ?
   That would be a nice way to document what quarkiverse updates are dangling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #9179: (chores) build: removed outdated scripts

[GitBox]

orpiske commented on PR #9179:
URL: https://github.com/apache/camel/pull/9179#issuecomment-1398170743

   It looks like we don't need these. Do we?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #9177: (chores) camel-kafka: disable connection check test on Apache CI

[GitBox]

orpiske commented on PR #9177:
URL: https://github.com/apache/camel/pull/9177#issuecomment-1398165436

   Actually, I think this test is wrong as it seems to depend on a complex 
chain of events to be correct (service needs to be *fully* up, Camel - and the 
Kafka client - needs to be connect, partition/client metadata has to be 
properly synced/up-to-date). It seems to work well just on machines fast enough 
for this to happen in a timely manner. 
   
   I'll remove it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] essobedo commented on pull request #4428: Ref #4426: Support CSimple expressions with all DSLs

[GitBox]

essobedo commented on PR #4428:
URL: https://github.com/apache/camel-quarkus/pull/4428#issuecomment-1398164066

   > Something I just remembered about doing 'dry run' stuff at build time, is 
that you potentially run into issues once you start moving away from the 'happy 
path'. E.g if a `RouteBuilder` does some CDI injection, I think the build time 
Expression Extractor phase will fail.
   > 
   > Maybe we should add a note about that to the docs.
   
   I see, I'm adding a fallback solution and a note about this limitation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #9178: (chores) camel-pulsar: fixes some errors shown in logs

[GitBox]

orpiske commented on PR #9178:
URL: https://github.com/apache/camel/pull/9178#issuecomment-1398160094

   Obs.: `PulsarSuspendRouteIT` is still broken, so the tests are likely to 
fail. It may take a bit more effort (from me, at least) to figure out what's 
going on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9178: (chores) camel-pulsar: fixes some errors shown in logs

[GitBox]

github-actions[bot] commented on PR #9178:
URL: https://github.com/apache/camel/pull/9178#issuecomment-1398159334

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kafka-connector] oscerd commented on issue #1504: camel-https-kafka-connector support for multiple HTTPS endpoints

[GitBox]

oscerd commented on issue #1504:
URL: 
https://github.com/apache/camel-kafka-connector/issues/1504#issuecomment-1398147224

   If you want to use EIPs, use directly Apache Camel instead of passing 
through kafka connector project.
   
   You can do that easily by consuming from a kafka endpoint.
   
   For versions of ckc not based on Camel-Kamelets, we were providing some OOTB 
transformations. Since the switch to Kamelets we are not providing them anymore.
   
   My suggestion is to move to plain Apache Camel for your use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kafka-connector] oscerd closed issue #1504: camel-https-kafka-connector support for multiple HTTPS endpoints

[GitBox]

oscerd closed issue #1504: camel-https-kafka-connector support for multiple 
HTTPS endpoints
URL: https://github.com/apache/camel-kafka-connector/issues/1504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kafka-connector-examples] oscerd closed issue #342: Camel AWS S3 source connector - Error org.reflections.ReflectionsException: Scanner SubTypesScanner was not configured

[GitBox]

oscerd closed issue #342: Camel AWS S3 source connector - Error 
org.reflections.ReflectionsException: Scanner SubTypesScanner was not configured
URL: https://github.com/apache/camel-kafka-connector-examples/issues/342


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] zhfeng commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions

[GitBox]

zhfeng commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398129700

   It could open a PR for any new release of  quarkiverse artifacts we are 
using. More details on 
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
   
   Of casue we can skip a version if it is not feasible for merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9177: (chores) camel-kafka: disable connection check test on Apache CI

[GitBox]

github-actions[bot] commented on PR #9177:
URL: https://github.com/apache/camel/pull/9177#issuecomment-1398114286

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested 
automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the 
job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] orpiske opened a new pull request, #9177: (chores) camel-kafka: disable connection check test on Apache CI

[GitBox]

orpiske opened a new pull request, #9177:
URL: https://github.com/apache/camel/pull/9177

   # Description
   
   This test runs OK locally, but fails on Apache CI.
   
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   
   
   - [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn 
-Psourcecheck`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] aadish2020 commented on issue #3991: camel k bypassing maven settings.xml when using proxy

[GitBox]

aadish2020 commented on issue #3991:
URL: https://github.com/apache/camel-k/issues/3991#issuecomment-139857

   > I think the issue may be related by the way you're calling the 
installation variables. Each environment variable should be called with 
`--operator-env-vars` separately, such as: `-operator-env-vars 
HTTP_PROXY=http://xx.xx.xx.xx:xx -operator-env-vars 
NO_PROXY=.cluster.local,.svc,127.0.0.1,localhost,10.96.0.0/16,10.244.0.0/16 
-operator-env-vars HTTPS_PROXY=http://xx.xx.xx.xx:xx`
   > 
   > What is happening right now is that you only create an env var, with a 
wrong format `HTTP_PROXY=http://xx.xx.xx.xx:xx,` (mind the comma), reason why 
the proxy is not taken in account. Please, try again with the proper 
installation format and let us know how it goes.
   
   Thanks for your response @squakez, but this is still not working. 
   I am concerned that why is it going to https://repo.maven.apache.org to get 
the artifacts instead of my private repo, even when I have applied the 
settings.xml 
   
   ```
   
{"level":"info","ts":1674205550.5891948,"logger":"camel-k.maven","msg":"executing:
 mvn -V --no-transfer-progress -Dstyle.color=never package 
-Dmaven.repo.local=/tmp/artifacts/m2 --global-settings 
/tmp/kit-cf55irnq24t5vefn9l90-1435150009/maven/settings.xml --settings 
/tmp/kit-cf55irnq24t5vefn9l90-1435150009/maven/user-settings.xml 
-Dmaven.artifact.threads=8 -T 8","MAVEN_OPTS":""}
   
{"level":"info","ts":1674205550.5892284,"logger":"camel-k.maven.build","msg":"Executed
 command: /usr/bin/mvn -V --no-transfer-progress -Dstyle.color=never package 
-Dmaven.repo.local=/tmp/artifacts/m2 --global-settings 
/tmp/kit-cf55irnq24t5vefn9l90-1435150009/maven/settings.xml --settings 
/tmp/kit-cf55irnq24t5vefn9l90-1435150009/maven/user-settings.xml 
-Dmaven.artifact.threads=8 -T 8"}
   
{"level":"info","ts":1674205551.348,"logger":"camel-k.maven.build","msg":"Apache
 Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)"}
   
{"level":"info","ts":1674205551.3456213,"logger":"camel-k.maven.build","msg":"Maven
 home: /usr/share/maven"}
   
{"level":"info","ts":1674205551.345626,"logger":"camel-k.maven.build","msg":"Java
 version: 11.0.16, vendor: Eclipse Adoptium, runtime: /opt/mandrel"}
   
{"level":"info","ts":1674205551.34563,"logger":"camel-k.maven.build","msg":"Default
 locale: en_US, platform encoding: UTF-8"}
   
{"level":"info","ts":1674205551.3456335,"logger":"camel-k.maven.build","msg":"OS
 name: \"linux\", version: \"3.10.0-1160.71.1.el7.x86_64\", arch: \"amd64\", 
family: \"unix\""}
   
{"level":"info","ts":1674205552.254,"logger":"camel-k.maven.build","msg":"Scanning
 for projects..."}
   
{"level":"error","ts":1674205552.6695,"logger":"camel-k.maven.build","msg":"[ERROR]
 Some problems were encountered while processing the POMs:\n[ERROR] 
Non-resolvable import POM: Could not find artifact 
org.apache.camel.k:camel-k-runtime-bom:pom:1.16.0 in central 
(https://repo.maven.apache.org/maven2) @ line 15, column 19\n[ERROR] 
'dependencies.dependency.version' for 
org.apache.camel.quarkus:camel-quarkus-core:jar is missing. @ line 25, column 
17\n[ERROR] 'dependencies.dependency.version' for 
org.apache.camel.quarkus:camel-quarkus-kafka:jar is missing. @ line 29, column 
17\n[ERROR] 'dependencies.dependency.version' for 
org.apache.camel.quarkus:camel-quarkus-kamelet:jar is missing. @ line 33, 
column 17\n[ERROR] 'dependencies.dependency.version' for 
org.apache.camel.quarkus:camel-quarkus-knative:jar is missing. @ line 37, 
column 17\n[ERROR] 'dependencies.dependency.version' for 
org.apache.camel.k:camel-k-knative-impl:jar is missing. @ line 41, column 
17\n[ERROR] 'dependencies.depend
 ency.version' for org.apache.camel.k:camel-k-runtime:jar is missing. @ line 
45, column 17\n[ERROR] 'dependencies.dependency.version' for 
org.apache.camel.quarkus:camel-quarkus-platform-http:jar is missing. @ line 54, 
column 17\n[ERROR] 'dependencies.dependency.version' for 
org.apache.camel.quarkus:camel-quarkus-yaml-dsl:jar is missing. @ line 58, 
column 17\n @ 
","stacktrace":"github.com/apache/camel-k/pkg/util/log.Logger.Error\n\tgithub.com/apache/camel-k/pkg/util/log/log.go:75\ngithub.com/apache/camel-k/pkg/util/maven.normalizeLog\n\tgithub.com/apache/camel-k/pkg/util/maven/maven_log.go:83\ngithub.com/apache/camel-k/pkg/util/maven.mavenLogHandler\n\tgithub.com/apache/camel-k/pkg/util/maven/maven_log.go:54\ngithub.com/apache/camel-k/pkg/util.scan\n\tgithub.com/apache/camel-k/pkg/util/command.go:77\ngithub.com/apache/camel-k/pkg/util.RunAndLog.func1\n\tgithub.com/apache/camel-k/pkg/util/command.go:56\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\tgolang.org/x/sync@v0.1.0/errgroup/e
 rrgroup.go:75"}
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact 

[GitHub] [camel] davsclaus merged pull request #9175: Spring Boot 2.7.8 parent dependencies

[GitBox]

davsclaus merged PR #9175:
URL: https://github.com/apache/camel/pull/9175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #3994: [proposal] Publish a generated extension using jbang and jitpack

[GitBox]

squakez commented on PR #3994:
URL: https://github.com/apache/camel-k/pull/3994#issuecomment-1398091804

   Thanks for submitting the PR. However I am not able to entirely understand 
how this is going to work. Is it some user that need to run some command with 
the proposed configuration? Can you please provide a step by step description 
of the process? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on pull request #4433: Fix #4128 add a dependabot to upgrade quarkiverse versions

[GitBox]

aldettinger commented on PR #4433:
URL: https://github.com/apache/camel-quarkus/pull/4433#issuecomment-1398082960

   Good time to experiment with new tools right after a release. Thus few 
questions.
   
   Will dependabot upgrade versions only linked to CVEs ?
   Or upgrade to any new release quarkiverse.* version available ?
   
   Also, in case a new quarkiverse.* version is available but we would skip it 
in camel-quarkus, because of a bug for instance. Then, how could we skip that 
version ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-k] squakez commented on issue #3991: camel k bypassing maven settings.xml when using proxy

[GitBox]

squakez commented on issue #3991:
URL: https://github.com/apache/camel-k/issues/3991#issuecomment-1398082182

   I think the issue may be related by the way you're calling the installation 
variables. Each environment variable should be called with 
`--operator-env-vars` separately, such as: `-operator-env-vars 
HTTP_PROXY=http://xx.xx.xx.xx:xx -operator-env-vars 
NO_PROXY=.cluster.local,.svc,127.0.0.1,localhost,10.96.0.0/16,10.244.0.0/16 
-operator-env-vars HTTPS_PROXY=http://xx.xx.xx.xx:xx`
   
   What is happening right now is that you only create an env var, with a wrong 
format `HTTP_PROXY=http://xx.xx.xx.xx:xx,` (mind the comma), reason why the 
proxy is not taken in account. Please, try again with the proper installation 
format and let us know how it goes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4428: Ref #4426: Support CSimple expressions with all DSLs

[GitBox]

jamesnetherton commented on PR #4428:
URL: https://github.com/apache/camel-quarkus/pull/4428#issuecomment-1398081286

   Something I just remembered about doing 'dry run' stuff at build time, is 
that you potentially run into issues once you start moving away from the 'happy 
path'. E.g if a `RouteBuilder` does some CDI injection, I think the build time 
Expression Extractor phase will fail.
   
   Maybe we should add a note about that to the docs. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #3370: Sql test using derby doesn't start dev service and shows class loadin…

[GitBox]

JiriOndrusek commented on PR #3370:
URL: https://github.com/apache/camel-quarkus/pull/3370#issuecomment-1398059425

   Done, can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kamelets] oscerd commented on issue #1244: Provide a way to pass Kamelets arbitrary parameters so that users don't need to extend predefined Kamelets so often

[GitBox]

oscerd commented on issue #1244:
URL: 
https://github.com/apache/camel-kamelets/issues/1244#issuecomment-1398049007

   To me, it's almost impossible to accomplish this, for multiple reasons:
   
   - We give the opportunity to write a Kamelet in multiple ways (like having 
toD, to and some steps in between)
   - We provide a basic catalog that could be extended as users wish
   
   In my opinion we don't really need a way to extend a single kamelets, but we 
might need to create a way of having some kind of Kamelets marketplace (like 
for example ansible galay or Terraform modules). 
   
   In that way anyone could take kamelets, extend them and eventually publish 
their own catalog in the marketplace.
   
   Even our catalog could be improved, for example through the addition of 
other labels like "Advanced", "Beginner", "Ready for Prod" etc.
   
   I think we should focus more on supporting different catalogs in all the 
runtimes, than on extending the single Kamelet.  
   
   It's a tradeoff, but I do think the advantages will be more if we think 
about Kamelets like a catalogs marketplace.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kamelets] davsclaus commented on issue #1244: Provide a way to pass Kamelets arbitrary parameters so that users don't need to extend predefined Kamelets so often

[GitBox]

davsclaus commented on issue #1244:
URL: 
https://github.com/apache/camel-kamelets/issues/1244#issuecomment-1398045063

   Please do NOT do this - the promise of Kamelets is that that are easier and 
not complex. The point is exactly that if you need a derived of a given kamelet 
you copy it and adjust it as a new kamelet. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kamelets] oscerd merged pull request #1243: isolate the verifyHeader method in testSupportedHeaders to allow customizations

[GitBox]

oscerd merged PR #1243:
URL: https://github.com/apache/camel-kamelets/pull/1243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-kamelets] oscerd merged pull request #1242: isolate the verifyHeader method in testSupportedHeaders to allow customizations (0.10.x branch)

[GitBox]

oscerd merged PR #1242:
URL: https://github.com/apache/camel-kamelets/pull/1242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] oscerd merged pull request #9176: Generated sources regen

[GitBox]

oscerd merged PR #9176:
URL: https://github.com/apache/camel/pull/9176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org