CAMEL-7724: Fixed CS
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/c2025456 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/c2025456 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/c2025456 Branch: refs/heads/master Commit: c20254566b65485ddb0e9d11d4bc2b67e4bd9e95 Parents: a02bd17 Author: Claus Ibsen <davscl...@apache.org> Authored: Fri Aug 22 08:07:38 2014 +0200 Committer: Claus Ibsen <davscl...@apache.org> Committed: Fri Aug 22 08:07:38 2014 +0200 ---------------------------------------------------------------------- .../dataformat/bindy/format/BooleanFormat.java | 2 +- .../BindySimpleCsvBooleanUnmarshallTest.java | 10 +++--- .../bindy/model/simple/bool/BooleanExample.java | 33 ++++++++++---------- 3 files changed, 23 insertions(+), 22 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/c2025456/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/format/BooleanFormat.java ---------------------------------------------------------------------- diff --git a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/format/BooleanFormat.java b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/format/BooleanFormat.java index d94596e..ac0955f 100755 --- a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/format/BooleanFormat.java +++ b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/format/BooleanFormat.java @@ -25,7 +25,7 @@ public class BooleanFormat implements Format<Boolean> { } public Boolean parse(String string) throws Exception { - return new Boolean(string); + return Boolean.valueOf(string); } } http://git-wip-us.apache.org/repos/asf/camel/blob/c2025456/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvBooleanUnmarshallTest.java ---------------------------------------------------------------------- diff --git a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvBooleanUnmarshallTest.java b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvBooleanUnmarshallTest.java index 44ad4a1..57eea3b 100755 --- a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvBooleanUnmarshallTest.java +++ b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvBooleanUnmarshallTest.java @@ -16,11 +16,6 @@ */ package org.apache.camel.dataformat.bindy.csv; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; - import java.util.List; import java.util.Map; @@ -37,6 +32,11 @@ import org.springframework.test.annotation.DirtiesContext; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.AbstractJUnit4SpringContextTests; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + @ContextConfiguration public class BindySimpleCsvBooleanUnmarshallTest extends AbstractJUnit4SpringContextTests { http://git-wip-us.apache.org/repos/asf/camel/blob/c2025456/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/model/simple/bool/BooleanExample.java ---------------------------------------------------------------------- diff --git a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/model/simple/bool/BooleanExample.java b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/model/simple/bool/BooleanExample.java index 7378a01..07801ea 100644 --- a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/model/simple/bool/BooleanExample.java +++ b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/model/simple/bool/BooleanExample.java @@ -21,31 +21,32 @@ import org.apache.camel.dataformat.bindy.annotation.DataField; @CsvRecord(separator = ",") public class BooleanExample { + @DataField(pos = 1) public String name; @DataField(pos = 2, defaultValue = "true") public Boolean exist; - public String getName() { - return name; - } + public String getName() { + return name; + } - public void setName(String name) { - this.name = name; - } + public void setName(String name) { + this.name = name; + } - public Boolean getExist() { - return exist; - } + public Boolean getExist() { + return exist; + } - public void setExist(Boolean exist) { - this.exist = exist; - } + public void setExist(Boolean exist) { + this.exist = exist; + } - @Override - public String toString() { - return "BoolExample [name=" + name + ", exist=" + exist + "]"; - } + @Override + public String toString() { + return "BoolExample [name=" + name + ", exist=" + exist + "]"; + } }