davsclaus commented on a change in pull request #6634:
URL: https://github.com/apache/camel/pull/6634#discussion_r778564862
##########
File path: core/camel-core-engine/pom.xml
##########
@@ -349,43 +357,6 @@
</dependency>
</dependencies>
</profile>
-
- <profile>
- <id>jdk9s-build</id>
- <activation>
- <jdk>[9,)</jdk>
- </activation>
- <dependencies>
- <!-- xmltokenizer using woodstox -->
- <dependency>
- <groupId>org.codehaus.woodstox</groupId>
- <artifactId>woodstox-core-asl</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-surefire-plugin</artifactId>
- <configuration>
- <!-- skip file stress tests as they are intended
to run manually -->
- <excludes>
-
<exclude>org/apache/camel/component/file/stress/**.java</exclude>
-
<exclude>**/DistributedCompletionIntervalTest.java</exclude>
-
<exclude>**/DistributedConcurrentPerCorrelationKeyTest.java</exclude>
- <exclude>${platform.skip.tests}</exclude>
- </excludes>
-
<forkedProcessTimeoutInSeconds>3000</forkedProcessTimeoutInSeconds>
- <!-- needed for testing the properties component
-->
- <environmentVariables>
- <FOO_SERVICE_HOST>myserver</FOO_SERVICE_HOST>
Review comment:
I think these ENV are used during test of camel-core. Not sure if we set
them in another way.
##########
File path: core/camel-management-api/pom.xml
##########
@@ -242,42 +249,5 @@
</dependency>
</dependencies>
</profile>
-
- <profile>
- <id>jdk9s-build</id>
- <activation>
- <jdk>[9,)</jdk>
- </activation>
- <dependencies>
- <!-- xmltokenizer using woodstox -->
- <dependency>
- <groupId>org.codehaus.woodstox</groupId>
- <artifactId>woodstox-core-asl</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-surefire-plugin</artifactId>
- <configuration>
- <!-- skip file stress tests as they are intended
to run manually -->
- <excludes>
-
<exclude>org/apache/camel/component/file/stress/**.java</exclude>
-
<exclude>**/DistributedCompletionIntervalTest.java</exclude>
-
<exclude>**/DistributedConcurrentPerCorrelationKeyTest.java</exclude>
- <exclude>${platform.skip.tests}</exclude>
- </excludes>
-
<forkedProcessTimeoutInSeconds>3000</forkedProcessTimeoutInSeconds>
- <!-- needed for testing the properties component
-->
- <environmentVariables>
- <FOO_SERVICE_HOST>myserver</FOO_SERVICE_HOST>
Review comment:
Same as prev comment
##########
File path: parent/pom.xml
##########
@@ -4048,6 +4110,13 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-package-maven-plugin</artifactId>
<version>${project.version}</version>
+ <dependencies>
Review comment:
Oh maybe this jaxb dependency should be added directly to
camel-package-maven-plugin so its not needed to be added in this special way
##########
File path: parent/pom.xml
##########
@@ -4040,6 +4040,68 @@
</dependencies>
</dependencyManagement>
+ <dependencies>
Review comment:
We should in another PR see what of this crap we can get rid of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
