[GitHub] [camel] davsclaus commented on pull request #6531: CAMEL-17307: camel-support - Added ThrowingPredicate interface to cre…
davsclaus commented on pull request #6531: URL: https://github.com/apache/camel/pull/6531#issuecomment-1019456845 Take a look at https://github.com/apache/camel/commit/ed4d79bef73fdb650d8c4b8531f3441b7224f620 The unit tests show what you can do. If you have feedback, suggestions then you are welcome to post them, or send a PR from the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6531: CAMEL-17307: camel-support - Added ThrowingPredicate interface to cre…
davsclaus commented on pull request #6531: URL: https://github.com/apache/camel/pull/6531#issuecomment-1019455144 Oh sorry in the mean time I have been working on this. Have the implemented ready, just doing a rebuild of code before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6531: CAMEL-17307: camel-support - Added ThrowingPredicate interface to cre…
davsclaus commented on pull request #6531: URL: https://github.com/apache/camel/pull/6531#issuecomment-1008629497 @TCke83 I added a suggestion to this branch (one commit) https://github.com/apache/camel/tree/throw-predicate Then what is needed is to make it possible from camel-validator to setup a custom exception factory. And add docs to the component. And add an unit test as well. Would you be able to help with that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6531: CAMEL-17307: camel-support - Added ThrowingPredicate interface to cre…
davsclaus commented on pull request #6531: URL: https://github.com/apache/camel/pull/6531#issuecomment-993366534 I think a factory is a good idea, but then you can implement a custom factory where you can build your custom exceptions based on the predicate. I do not think we should/need to add some `HasCustomException` interface but just rely on the predicate instance where you can check yourself what you want to do, in your custom factory. Then this is non invasive on the camel-core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
