[GitHub] [camel] davsclaus commented on pull request #8795: CAMEL-18739 fix by handing over the completion to the original exchange

2022-12-14 Thread GitBox 


davsclaus commented on PR #8795:
URL: https://github.com/apache/camel/pull/8795#issuecomment-1351821364

   Okay I am working on a fix in camel-zipfile and core so this will work 
together - just need some more polish to ensure it works without causing other 
problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #8795: CAMEL-18739 fix by handing over the completion to the original exchange

2022-12-08 Thread GitBox 


davsclaus commented on PR #8795:
URL: https://github.com/apache/camel/pull/8795#issuecomment-1343022169

   No on completion happens after mock assertion. 
   
   There is an method on mock that can be used to test for file exists in a 
safer way without having to sleep (expectedFileExists) but there is no API for 
testing that a file is to be delted.
   
   Instead of using sleep you can use the availability library which has a 
nicer API.
   
   Something along the way
   
   Awaitility.waitAtMost(5, TimeUnit.SECONDS).until(() -> counter.get() > 1);
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #8795: CAMEL-18739 fix by handing over the completion to the original exchange

2022-11-30 Thread GitBox 


davsclaus commented on PR #8795:
URL: https://github.com/apache/camel/pull/8795#issuecomment-1332078305

   Can you send a PR for camel-zipfile we can use as unit test for this. This 
PR is changing in a central class used for other EIPs so we should be careful.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org