[GitHub] [camel] orpiske commented on pull request #8046: CAMEL-18152: implement auto-configuration for the adapters
orpiske commented on PR #8046: URL: https://github.com/apache/camel/pull/8046#issuecomment-1270080344 @ColdFireIce I hope you don't mind, but I went ahead and created the ticket, so I can fix and backport this: https://issues.apache.org/jira/browse/CAMEL-18594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8046: CAMEL-18152: implement auto-configuration for the adapters
orpiske commented on PR #8046:
URL: https://github.com/apache/camel/pull/8046#issuecomment-1269870831
> HI @orpiske , after I switched to version 3.19.0 (with this change) My
route to process some files is no longer working:
>
> `Error starting consumer while taking leadership. Caused by:
[java.lang.NullPointerException - Cannot invoke
"org.apache.camel.resume.ResumeStrategy.setAdapter(org.apache.camel.resume.ResumeAdapter)"
because "this.resumeStrategy" is null]`
>
> ```
> @Component
> public class LocalDirectoryWatcher extends RouteBuilder {
>
> @Override
> public void configure() {
> from("{{route.in}}")
> .process(this::exchange);
> }
>
> void exchange(Exchange exchange) {
> ...
> }
> ```
>
> `route.in` is `route.in: master:localimport:file:/some-directory-patch`
>
> Other routes that just do a
`from("{{foo.route.in}}").to("{{foo.route.out}}");` work fine.
>
> Is there something I'm missing?
Thanks for the report. Please, can you please share the whole stack trace?
Aso feel free to [open a ticket on our Jira](https://issues.apache.org/jira/)
with all the details, so I can take a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8046: CAMEL-18152: implement auto-configuration for the adapters
orpiske commented on PR #8046: URL: https://github.com/apache/camel/pull/8046#issuecomment-1196567551 Couchdb is known to be broken on GH actions, so we are good to merge despite the test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8046: CAMEL-18152: implement auto-configuration for the adapters
orpiske commented on PR #8046: URL: https://github.com/apache/camel/pull/8046#issuecomment-1196402775 @davsclaus I removed the duplicated files, so now it should be the real thing. I am thinking about creating the "ResumeAdapter" annotation you mentioned. Not necessarily on this PR, but as a follow up, since there's a chance it will need greater flexibility in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8046: CAMEL-18152: implement auto-configuration for the adapters
orpiske commented on PR #8046:
URL: https://github.com/apache/camel/pull/8046#issuecomment-1195643175
> Its a bit wrong when there are 2 generated files for the same thing. You
need for @JdkService to have a sub path I think, eg @JdkService("resume/file")
>
> Or you can create a special annotation that extends @JdkService that setup
this correct, we have done this for some others, then you can use
@ResumeAdapter("file") etc as annotation.
Oh, thanks for catching it.
One of the files in the camel-file shouldn't be there as it is a leftover
from a previous attempt. 🤦🏽♂️
What I am trying to achieve here is that it needs to be able to
differentiate between different configs based on the consumer so that it loads
the adapter that is appropriate for that component. However, there are some
components (like the DB-based ones) that have a shared adapter because they do
+/- the same thing.
Tomorrow I'll clean it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
