[GitHub] [camel-k] astefanutti commented on a change in pull request #2771: feat(cmd/run): autogenerated configmap for resource/config local files
astefanutti commented on a change in pull request #2771:
URL: https://github.com/apache/camel-k/pull/2771#discussion_r778378721
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,199 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/resource"
+)
+
+// The Mount trait can be used to configure volumes mounted on the Integration
Pods.
+//
+// +camel-k:trait=mount
+// nolint: tagliatelle
+type mountTrait struct {
+ BaseTrait `property:",squash"`
+ // A list of configuration pointing to configmap/secret.
+ // The configuration are expected to be UTF-8 resources as they are
processed by runtime Camel Context and tried to be parsed as property files.
+ // They are also made available on the classpath in order to ease their
usage directly from the Route.
+ // Syntax: [configmap|secret]:name[key], where name represents the
resource name and key optionally represents the resource key to be filtered
+ Configs []string `property:"configs" json:"configs,omitempty"`
+ // A list of resources (text or binary content) pointing to
configmap/secret.
+ // The resources are expected to be any resource type (text or binary
content).
+ // The destination path can be either a default location or any path
specified by the user.
+ // Syntax: [configmap|secret]:name[/key][@path], where name represents
the resource name, key optionally represents the resource key to be filtered
and path represents the destination path
+ Resources []string `property:"resources" json:"resources,omitempty"`
+ // A list of Persistent Volume Claims to be mounted. Syntax:
[pvcname:/container/path]
+ Volumes []string `property:"volumes" json:"volumes,omitempty"`
+}
+
+func newMountTrait() Trait {
+ return &mountTrait{
+ // Must follow immediately the container trait
+ BaseTrait: NewBaseTrait("mount", 1610),
+ }
+}
+
+func (t *mountTrait) Configure(e *Environment) (bool, error) {
+ if IsFalse(t.Enabled) {
+ return false, nil
+ }
+
+ if e.IntegrationInPhase(v1.IntegrationPhaseInitialization) ||
+ (!e.IntegrationInPhase(v1.IntegrationPhaseInitialization) &&
!e.IntegrationInRunningPhases()) {
+ return false, nil
+ }
+
+ // Validate resources and pvcs
+ for _, c := range t.Configs {
+ if !strings.HasPrefix(c, "configmap:") && !strings.HasPrefix(c,
"secret:") {
+ return false, fmt.Errorf("unsupported config %s, must
be a configmap or secret resource", c)
+ }
+ }
+ for _, r := range t.Resources {
+ if !strings.HasPrefix(r, "configmap:") && !strings.HasPrefix(r,
"secret:") {
+ return false, fmt.Errorf("unsupported resource %s, must
be a configmap or secret resource", r)
+ }
+ }
+
+ return true, nil
+}
+
+func (t *mountTrait) Apply(e *Environment) error {
+ if e.IntegrationInPhase(v1.IntegrationPhaseInitialization) {
+ return nil
+ }
+
+ container := e.GetIntegrationContainer()
+ if container == nil {
+ return fmt.Errorf("unable to find integration container: %s",
e.Integration.Name)
+ }
+
+ var volumes *[]corev1.Volume
+ visited := false
+
+ // Deployment
+ if err := e.Resources.VisitDeploymentE(func(deployment
*appsv1.Deployment) error {
+ volumes = &deployment.Spec.Template.Spec.Volumes
+ visited = true
+ return nil
+ }); err != nil {
+ return err
+ }
+
+ // Knative Service
+ if err := e.Resources.VisitKnativeServiceE(func(service
*serving.Service) error {
+ volumes = &service.Spec.ConfigurationSpec.Template.Spec.Volumes
+
[GitHub] [camel-k] astefanutti commented on a change in pull request #2771: feat(cmd/run): autogenerated configmap for resource/config local files
astefanutti commented on a change in pull request #2771:
URL: https://github.com/apache/camel-k/pull/2771#discussion_r778037581
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,199 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/resource"
+)
+
+// The Mount trait can be used to configure volumes mounted on the Integration
Pods.
+//
+// +camel-k:trait=mount
+// nolint: tagliatelle
+type mountTrait struct {
+ BaseTrait `property:",squash"`
+ // A list of configuration pointing to configmap/secret.
+ // The configuration are expected to be ÙTF-8 resources as they are
processed by runtime Camel Context and tried to be parsed as property files.
Review comment:
nit: `ÙTF-8` -> `UTF-8`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #2771: feat(cmd/run): autogenerated configmap for resource/config local files
astefanutti commented on a change in pull request #2771:
URL: https://github.com/apache/camel-k/pull/2771#discussion_r777990928
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,177 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/resource"
+)
+
+// The Mount trait can be used to configure volumes mounted on the Integration
Pod.
+//
+// +camel-k:trait=mount
+// nolint: tagliatelle
+type mountTrait struct {
+ BaseTrait `property:",squash"`
+ // A list of configuration pointing to configmap/secret. Syntax:
[configmap|secret]:name[key], where name represents the resource name and key
optionally represents the resource key to be filtered
+ Configs []string `property:"configs" json:"configs,omitempty"`
Review comment:
The comment now documents what kind of content can be provided. I could
still imagine an external user asking what's the difference between configs and
resources functionally. May I suggest to add that configs are added to the
classpath, and that they are typically used to configure Camel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a change in pull request #2771: feat(cmd/run): autogenerated configmap for resource/config local files
astefanutti commented on a change in pull request #2771:
URL: https://github.com/apache/camel-k/pull/2771#discussion_r777994177
##
File path: pkg/util/kubernetes/factory.go
##
@@ -32,6 +33,12 @@ var (
validResourceRequirementsRegexp =
regexp.MustCompile(`^(requests|limits)\.(memory|cpu)=([\w\.]+)$`)
)
+// ConfigMapAutogenLabel --
+const ConfigMapAutogenLabel = "camel.apache.org/autogenerated"
Review comment:
May I suggest `camel.apache.org/generated` instead?
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,193 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/resource"
+)
+
+// The Mount trait can be used to configure volumes mounted on the Integration
Pods.
+//
+// +camel-k:trait=mount
+// nolint: tagliatelle
+type mountTrait struct {
+ BaseTrait `property:",squash"`
+ // A list of configuration (only text content) pointing to
configmap/secret. Syntax: [configmap|secret]:name[key], where name represents
the resource name and key optionally represents the resource key to be filtered
+ Configs []string `property:"configs" json:"configs,omitempty"`
+ // A list of resources (text or binary content) pointing to
configmap/secret. Syntax: [configmap|secret]:name[/key][@path], where name
represents the resource name, key optionally represents the resource key to be
filtered and path represents the destination path
+ Resources []string `property:"resources" json:"resources,omitempty"`
+ // A list of Persistent Volume Claims to be mounted. Syntax:
[pvcname:/container/path]
+ Volumes []string `property:"volumes" json:"volumes,omitempty"`
+}
+
+func newMountTrait() Trait {
+ return &mountTrait{
+ // Must follow immediately the container trait
+ BaseTrait: NewBaseTrait("mount", 1610),
+ }
+}
+
+func (t *mountTrait) Configure(e *Environment) (bool, error) {
+ if IsFalse(t.Enabled) {
+ return false, nil
+ }
+
+ if e.IntegrationInPhase(v1.IntegrationPhaseInitialization) {
+ return false, nil
+ }
+
+ // Validate resources and pvcs
+ for _, c := range t.Configs {
+ if !strings.HasPrefix(c, "configmap:") && !strings.HasPrefix(c,
"secret:") {
+ return false, fmt.Errorf("unsupported config %s, must
be a configmap or secret resource", c)
+ }
+ }
+ for _, r := range t.Resources {
+ if !strings.HasPrefix(r, "configmap:") && !strings.HasPrefix(r,
"secret:") {
+ return false, fmt.Errorf("unsupported resource %s, must
be a configmap or secret resource", r)
+ }
+ }
+
+ return true, nil
+}
+
+func (t *mountTrait) Apply(e *Environment) error {
+ if e.IntegrationInPhase(v1.IntegrationPhaseInitialization) {
+ return nil
+ }
+
+ container := e.GetIntegrationContainer()
+ if container == nil {
+ return fmt.Errorf("unable to find integration container: %s",
e.Integration.Name)
+ }
+
+ var volumes *[]corev1.Volume
+ visited := false
+
+ // Deployment
+ if err := e.Resources.VisitDeploymentE(func(deployment
*appsv1.Deployment) error {
+ volumes = &deployment.Spec.Template.Spec.Volumes
+ visited = true
+ return nil
+ }); err != nil {
+ return err
+ }
+
+ // Knative Service
+ if err := e.Resources.VisitKnativeServiceE(func(service
*serving.Service) error {
+ volumes = &service.Spec.ConfigurationSpec.Template.Spec.Volumes
+ visited = true
+ return nil
+ }); err != nil {
+ return err
+ }
+
+ // CronJob
+ if err := e.Resources.VisitCronJobE(func(cron *v1beta1.CronJo
[GitHub] [camel-k] astefanutti commented on a change in pull request #2771: feat(cmd/run): autogenerated configmap for resource/config local files
astefanutti commented on a change in pull request #2771:
URL: https://github.com/apache/camel-k/pull/2771#discussion_r777379979
##
File path: pkg/util/kubernetes/factory.go
##
@@ -114,3 +115,34 @@ func NewResourceRequirements(reqs []string)
(corev1.ResourceRequirements, error)
return resReq, nil
}
+
+// NewConfigmap will create a Configmap.
+func NewConfigmap(namespace, cmName, originalFilename string, generatedKey
string,
Review comment:
nit: NewConfigmap -> NewConfigMap
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,177 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/resource"
+)
+
+// The Mount trait can be used to configure volumes mounted on the Integration
Pod.
Review comment:
nit: Pod -> Pod(s)
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,177 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/resource"
+)
+
+// The Mount trait can be used to configure volumes mounted on the Integration
Pod.
+//
+// +camel-k:trait=mount
+// nolint: tagliatelle
+type mountTrait struct {
+ BaseTrait `property:",squash"`
+ // A list of configuration pointing to configmap/secret. Syntax:
[configmap|secret]:name[key], where name represents the resource name and key
optionally represents the resource key to be filtered
+ Configs []string `property:"configs" json:"configs,omitempty"`
Review comment:
It may be useful to state in what `Configs` and `Resources` differ.
##
File path: pkg/trait/mount.go
##
@@ -0,0 +1,177 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package trait
+
+import (
+ "fmt"
+ "strings"
+
+ appsv1 "k8s.io/api/apps/v1"
+ "k8s.io/api/batch/v1beta1"
+ corev1 "k8s.io/api/core/v1"
+
+ serving "knative.dev/serving/pkg/apis/serving/v1"
+
+ v1 "github.com/apache/camel-k/pkg/apis/camel/v1"
+ "github.com/apache/camel-k/pkg/util/kubernetes"
+ utilResource "github.com/apache/camel-k/pkg/util/
