[GitHub] [camel-kafka-connector] orpiske commented on pull request #1408: Upgrade to Camel 3.18.0
orpiske commented on PR #1408: URL: https://github.com/apache/camel-kafka-connector/pull/1408#issuecomment-1198022619 @ffang I'll merge it for now, but please feel free to review the CXF and let me know if you notice anything broken. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on pull request #1408: Upgrade to Camel 3.18.0
orpiske commented on PR #1408: URL: https://github.com/apache/camel-kafka-connector/pull/1408#issuecomment-1198022171 > LGTM. We should merge and prepare a release. +1 Let's get this in, so it can run for a few cycles in the CI. I'll merge it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on pull request #1408: Upgrade to Camel 3.18.0
orpiske commented on PR #1408: URL: https://github.com/apache/camel-kafka-connector/pull/1408#issuecomment-1197955785 This one is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on pull request #1408: Upgrade to Camel 3.18.0
orpiske commented on PR #1408: URL: https://github.com/apache/camel-kafka-connector/pull/1408#issuecomment-1197783883 ErrorHandler reference issue is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on pull request #1408: Upgrade to Camel 3.18.0
orpiske commented on PR #1408:
URL:
https://github.com/apache/camel-kafka-connector/pull/1408#issuecomment-1196980207
@oscerd this is still pretty broken. The tests are failing because of this:
```
Caused by: java.lang.IllegalStateException: Unsupported definition:
ErrorHandlerBuilderRef[{{errorHandler}}]
at
org.apache.camel.reifier.errorhandler.ErrorHandlerReifier.reifier(ErrorHandlerReifier.java:88)
~[camel-core-reifier-3.18.0.jar:3.18.0]
at
org.apache.camel.impl.DefaultModelReifierFactory.createErrorHandler(DefaultModelReifierFactory.java:65)
~[camel-core-engine-3.18.0.jar:3.18.0]
at
org.apache.camel.reifier.ProcessorReifier.wrapInErrorHandler(ProcessorReifier.java:754)
~[camel-core-reifier-3.18.0.jar:3.18.0]
```
Hey @ffang would you mind a review on the CXF changes, please? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
