[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1215: Debezium PostgresSQL Connector native support #1191
JiriOndrusek commented on a change in pull request #1215:
URL: https://github.com/apache/camel-quarkus/pull/1215#discussion_r428044591
##
File path:
integration-tests/debezium-postgres/src/test/java/org/apache/camel/quarkus/component/debezium/postgres/it/DebeziumPostgresTestResource.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.camel.quarkus.component.debezium.postgres.it;
+
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.util.Collections;
+import java.util.Map;
+
+import
org.apache.camel.quarkus.testcontainers.ContainerResourceLifecycleManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.PostgreSQLContainer;
+import org.testcontainers.utility.TestcontainersConfiguration;
+
+public class DebeziumPostgresTestResource implements
ContainerResourceLifecycleManager {
+private static final Logger LOGGER =
LoggerFactory.getLogger(DebeziumPostgresTestResource.class);
+
+private static final int POSTGRES_PORT = 5432;
+private static final String POSTGRES_IMAGE = "debezium/postgres:11";
+
+private PostgreSQLContainer postgresContainer;
+private Connection connection;
+private Path storeFile;
+private String hostname;
+private int port;
+
+@Override
+public Map start() {
+LOGGER.info(TestcontainersConfiguration.getInstance().toString());
+
+try {
+storeFile = Files.createTempFile("debezium-postgress-store-", "");
+
+postgresContainer = new PostgreSQLContainer<>(POSTGRES_IMAGE)
+.withUsername(DebeziumPostgresResource.DB_USERNAME)
+.withPassword(DebeziumPostgresResource.DB_PASSWORD)
+.withDatabaseName(DebeziumPostgresResource.DB_NAME)
+.withInitScript("init.sql");
+
+postgresContainer.start();
+
+final String jdbcUrl = "jdbc:postgresql://" +
postgresContainer.getContainerIpAddress() + ":"
++ postgresContainer.getMappedPort(POSTGRES_PORT) + "/" +
DebeziumPostgresResource.DB_NAME + "?user="
++ DebeziumPostgresResource.DB_USERNAME + "=" +
DebeziumPostgresResource.DB_PASSWORD;
+connection = DriverManager.getConnection(jdbcUrl);
+hostname = postgresContainer.getContainerIpAddress();
+port = postgresContainer.getMappedPort(POSTGRES_PORT);
+
+return Collections.emptyMap();
+} catch (Exception e) {
+throw new RuntimeException(e);
+}
+}
+
+@Override
+public void stop() {
+try {
+if (connection != null) {
+connection.close();
+}
+if (postgresContainer != null) {
+postgresContainer.stop();
+}
+if (storeFile != null) {
+Files.deleteIfExists(storeFile);
+}
+} catch (Exception e) {
+// ignored
+}
+}
+
+@Override
+public void inject(Object testInstance) {
+((DebeziumPostgresTest) testInstance).connection = this.connection;
Review comment:
@jamesnetherton I've started to work on debebezium-mysql. Because this
extension will be very similar to debezium-postgres (and probably other
debezium-* extensions). I'd like to refactor each of them to use some
debezium-common extension. As a part of that refactor I'll cover also this
issue with properties. -> From my POV I'd fixed it after merging this one PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1215: Debezium PostgresSQL Connector native support #1191
JiriOndrusek commented on a change in pull request #1215:
URL: https://github.com/apache/camel-quarkus/pull/1215#discussion_r427337045
##
File path:
integration-tests/debezium-postgres/src/test/java/org/apache/camel/quarkus/component/debezium/postgres/it/DebeziumPostgresTestResource.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.camel.quarkus.component.debezium.postgres.it;
+
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.util.Collections;
+import java.util.Map;
+
+import
org.apache.camel.quarkus.testcontainers.ContainerResourceLifecycleManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.PostgreSQLContainer;
+import org.testcontainers.utility.TestcontainersConfiguration;
+
+public class DebeziumPostgresTestResource implements
ContainerResourceLifecycleManager {
+private static final Logger LOGGER =
LoggerFactory.getLogger(DebeziumPostgresTestResource.class);
+
+private static final int POSTGRES_PORT = 5432;
+private static final String POSTGRES_IMAGE = "debezium/postgres:11";
+
+private PostgreSQLContainer postgresContainer;
+private Connection connection;
+private Path storeFile;
+private String hostname;
+private int port;
+
+@Override
+public Map start() {
+LOGGER.info(TestcontainersConfiguration.getInstance().toString());
+
+try {
+storeFile = Files.createTempFile("debezium-postgress-store-", "");
+
+postgresContainer = new PostgreSQLContainer<>(POSTGRES_IMAGE)
+.withUsername(DebeziumPostgresResource.DB_USERNAME)
+.withPassword(DebeziumPostgresResource.DB_PASSWORD)
+.withDatabaseName(DebeziumPostgresResource.DB_NAME)
+.withInitScript("init.sql");
+
+postgresContainer.start();
+
+final String jdbcUrl = "jdbc:postgresql://" +
postgresContainer.getContainerIpAddress() + ":"
++ postgresContainer.getMappedPort(POSTGRES_PORT) + "/" +
DebeziumPostgresResource.DB_NAME + "?user="
++ DebeziumPostgresResource.DB_USERNAME + "=" +
DebeziumPostgresResource.DB_PASSWORD;
+connection = DriverManager.getConnection(jdbcUrl);
+hostname = postgresContainer.getContainerIpAddress();
+port = postgresContainer.getMappedPort(POSTGRES_PORT);
+
+return Collections.emptyMap();
+} catch (Exception e) {
+throw new RuntimeException(e);
+}
+}
+
+@Override
+public void stop() {
+try {
+if (connection != null) {
+connection.close();
+}
+if (postgresContainer != null) {
+postgresContainer.stop();
+}
+if (storeFile != null) {
+Files.deleteIfExists(storeFile);
+}
+} catch (Exception e) {
+// ignored
+}
+}
+
+@Override
+public void inject(Object testInstance) {
+((DebeziumPostgresTest) testInstance).connection = this.connection;
Review comment:
and for example connection is not a simple object
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1215: Debezium PostgresSQL Connector native support #1191
JiriOndrusek commented on a change in pull request #1215:
URL: https://github.com/apache/camel-quarkus/pull/1215#discussion_r427336399
##
File path:
integration-tests/debezium-postgres/src/test/java/org/apache/camel/quarkus/component/debezium/postgres/it/DebeziumPostgresTestResource.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.camel.quarkus.component.debezium.postgres.it;
+
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.util.Collections;
+import java.util.Map;
+
+import
org.apache.camel.quarkus.testcontainers.ContainerResourceLifecycleManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.PostgreSQLContainer;
+import org.testcontainers.utility.TestcontainersConfiguration;
+
+public class DebeziumPostgresTestResource implements
ContainerResourceLifecycleManager {
+private static final Logger LOGGER =
LoggerFactory.getLogger(DebeziumPostgresTestResource.class);
+
+private static final int POSTGRES_PORT = 5432;
+private static final String POSTGRES_IMAGE = "debezium/postgres:11";
+
+private PostgreSQLContainer postgresContainer;
+private Connection connection;
+private Path storeFile;
+private String hostname;
+private int port;
+
+@Override
+public Map start() {
+LOGGER.info(TestcontainersConfiguration.getInstance().toString());
+
+try {
+storeFile = Files.createTempFile("debezium-postgress-store-", "");
+
+postgresContainer = new PostgreSQLContainer<>(POSTGRES_IMAGE)
+.withUsername(DebeziumPostgresResource.DB_USERNAME)
+.withPassword(DebeziumPostgresResource.DB_PASSWORD)
+.withDatabaseName(DebeziumPostgresResource.DB_NAME)
+.withInitScript("init.sql");
+
+postgresContainer.start();
+
+final String jdbcUrl = "jdbc:postgresql://" +
postgresContainer.getContainerIpAddress() + ":"
++ postgresContainer.getMappedPort(POSTGRES_PORT) + "/" +
DebeziumPostgresResource.DB_NAME + "?user="
++ DebeziumPostgresResource.DB_USERNAME + "=" +
DebeziumPostgresResource.DB_PASSWORD;
+connection = DriverManager.getConnection(jdbcUrl);
+hostname = postgresContainer.getContainerIpAddress();
+port = postgresContainer.getMappedPort(POSTGRES_PORT);
+
+return Collections.emptyMap();
+} catch (Exception e) {
+throw new RuntimeException(e);
+}
+}
+
+@Override
+public void stop() {
+try {
+if (connection != null) {
+connection.close();
+}
+if (postgresContainer != null) {
+postgresContainer.stop();
+}
+if (storeFile != null) {
+Files.deleteIfExists(storeFile);
+}
+} catch (Exception e) {
+// ignored
+}
+}
+
+@Override
+public void inject(Object testInstance) {
+((DebeziumPostgresTest) testInstance).connection = this.connection;
Review comment:
@jamesnetherton I know about Map approach. It is working well if
property placeholder is "not" in test, where I could inject propertiesComponent
to translate it for me. But I haven't found any way how to do it in test/*
classes. Did I miss something?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
