[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1258: Debezium MySQL Connector native support #1192
JiriOndrusek commented on pull request #1258: URL: https://github.com/apache/camel-quarkus/pull/1258#issuecomment-632583549 @jamesnetherton My intention is to create debezium-common module, because a lot of code seems to be common for alle debezium modules. I wanted to create 2 modules and then refactor them. (to be sure what is common and what not). So I now would like to refactor debezium-mysql and debezium-postgres and afterwards create the rest of modules. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1258: Debezium MySQL Connector native support #1192
JiriOndrusek commented on pull request #1258: URL: https://github.com/apache/camel-quarkus/pull/1258#issuecomment-632584418 @jamesnetherton should I modify this PR to contain also refactor of debezium-postgres? (doesn't seems to be the correct approach for me). I like the idea to get this one merged and then create debezium common issue and PR. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1258: Debezium MySQL Connector native support #1192
JiriOndrusek commented on pull request #1258: URL: https://github.com/apache/camel-quarkus/pull/1258#issuecomment-632592677 no problem, I'll do the refactor as the part of this PR. (it was just a technicality, if I can refactor debezium-postgtres when I'm creating debezium-mysql) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1258: Debezium MySQL Connector native support #1192
JiriOndrusek commented on pull request #1258: URL: https://github.com/apache/camel-quarkus/pull/1258#issuecomment-633553700 @jamesnetherton I've joined test modules for all debezium components into one - integration-test/debezium-common and then I've used (and modified) debezium-support, so there should be no comon code in each module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1258: Debezium MySQL Connector native support #1192
JiriOndrusek commented on pull request #1258: URL: https://github.com/apache/camel-quarkus/pull/1258#issuecomment-634066299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1258: Debezium MySQL Connector native support #1192
JiriOndrusek commented on pull request #1258: URL: https://github.com/apache/camel-quarkus/pull/1258#issuecomment-634548464 @ppalaga All requests are added into PR. About > need to exclude mysql-connector from every quarkus-mysql it is used in `extensions/debezium/mysql/pom.xml` line 71` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
