[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5117: Onboard Camel K Runtime
jamesnetherton commented on code in PR #5117:
URL: https://github.com/apache/camel-quarkus/pull/5117#discussion_r1277280841
##
extensions-jvm/k/bom/pom.xml:
##
@@ -0,0 +1,135 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+org.apache.camel.quarkus
+camel-quarkus
+3.0.0-SNAPSHOT
+../../../pom.xml
+
+4.0.0
+
+camel-quarkus-k-runtime-bom
+Camel Quarkus :: Camel K Runtime BOM
+pom
+
+
+io.quarkus.platform
+
+
+
+
+
+${quarkus-platform-group}
Review Comment:
```suggestion
org.apache.camel.quarkus
```
##
extensions-jvm/k/bom/pom.xml:
##
@@ -0,0 +1,135 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+org.apache.camel.quarkus
+camel-quarkus
+3.0.0-SNAPSHOT
+../../../pom.xml
+
+4.0.0
+
+camel-quarkus-k-runtime-bom
+Camel Quarkus :: Camel K Runtime BOM
+pom
+
+
+io.quarkus.platform
+
+
+
+
+
+${quarkus-platform-group}
+quarkus-camel-bom
Review Comment:
```suggestion
camel-quarkus-bom
```
##
extensions-jvm/k/bom/pom.xml:
##
@@ -0,0 +1,135 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+org.apache.camel.quarkus
+camel-quarkus
+3.0.0-SNAPSHOT
+../../../pom.xml
+
+4.0.0
+
+camel-quarkus-k-runtime-bom
+Camel Quarkus :: Camel K Runtime BOM
+pom
+
+
+io.quarkus.platform
+
+
+
+
+
+${quarkus-platform-group}
+quarkus-camel-bom
+${quarkus.version}
Review Comment:
```suggestion
${project.version}
```
##
extensions-jvm/k/bom/pom.xml:
##
@@ -0,0 +1,135 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+org.apache.camel.quarkus
+camel-quarkus
+3.0.0-SNAPSHOT
+../../../pom.xml
+
+4.0.0
+
+camel-quarkus-k-runtime-bom
+Camel Quarkus :: Camel K Runtime BOM
+pom
+
+
+io.quarkus.platform
+
+
+
+
+
+${quarkus-platform-group}
+quarkus-camel-bom
+${quarkus.version}
+pom
+import
+
+
+${quarkus-platform-group}
Review Comment:
```suggestion
io.quarkus
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5117: Onboard Camel K Runtime
jamesnetherton commented on code in PR #5117: URL: https://github.com/apache/camel-quarkus/pull/5117#discussion_r1273527574 ## docs/modules/ROOT/nav.adoc: ## @@ -81,6 +81,8 @@ *** xref:reference/extensions/csimple.adoc[CSimple] *** xref:reference/extensions/cxf-soap.adoc[CXF] *** xref:reference/extensions/caffeine.adoc[Caffeine Cache] +*** xref:reference/extensions/k-runtime.adoc[Camel K] Review Comment: I'm guessing the CQ Maven tooling added these. We probably need to suppress that. ## integration-tests-jvm/k/k-loader/pom.xml: ## @@ -0,0 +1,175 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +org.apache.camel.quarkus +camel-quarkus-build-parent-it +3.0.0-SNAPSHOT +../../../poms/build-parent-it/pom.xml + +4.0.0 + +camel-quarkus-integration-test-k-loader +Camel Quarkus :: Integration Tests :: Camel K Loader +Integration tests for Camel Quarkus K Loader extension + + + +org.apache.camel.quarkus + camel-quarkus-integration-test-support-k-loader-inspector + + +org.apache.camel.quarkus +camel-quarkus-k-core + + + + +org.apache.camel.quarkus +camel-quarkus-groovy-dsl + + +org.apache.camel.quarkus +camel-quarkus-java-joor-dsl + + +org.apache.camel.quarkus +camel-quarkus-js-dsl + + +org.apache.camel +camel-jsh-dsl + + +org.apache.camel.quarkus +camel-quarkus-kotlin-dsl + + +org.apache.camel +camel-yaml-dsl + + +org.snakeyaml +snakeyaml-engine + + + + +org.apache.camel.quarkus +camel-quarkus-xml-io-dsl + + +org.apache.camel.quarkus +camel-quarkus-jackson + + +org.apache.camel.quarkus +camel-quarkus-direct + + +org.apache.camel.quarkus +camel-quarkus-log + + +org.apache.camel.quarkus +camel-quarkus-bean + + +io.quarkus +quarkus-jsonb + + +io.quarkus +quarkus-resteasy + + +io.quarkus +quarkus-resteasy-jsonb + + + + +io.quarkus +quarkus-junit5 +test + + +io.rest-assured +rest-assured +test + + +org.assertj +assertj-core +test + + + Review Comment: For all integration tests, these should be wrapped in a `VirtualDependencies` profile. Example here: https://github.com/apache/camel-quarkus/blob/main/integration-tests-jvm/asn1/pom.xml#L56-L81 All of the `org.apache.camel.quarkus` test dependency deployment artifacts need adding in there to ensure the build order is correct. ## extensions-jvm/k/k-core/api/pom.xml: ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +org.apache.camel.quarkus +camel-quarkus-extensions-jvm +3.0.0-SNAPSHOT +../../../pom.xml + +4.0.0 + +camel-quarkus-k-core-api +Camel Quarkus :: Camel K Core :: API + + + + + + + + + + +org.apache.camel +camel-core-engine + + +org.apache.camel +camel-core-languages + + +org.apache.camel +camel-endpointdsl + + + + + + + +org.apache.maven.plugins +maven-surefire-plugin Review Comment: Will tests be added eventually to this module? I don't see any. If not, I guess we can remove this plugin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
