[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-597040206 I was able to reproduce using `mvn -Papache-release release:prepare -DpushChanges=false`. I'd say the extension-less `NOTICE` and `LICENSE` files are unwanted. They come via `org.apache.apache.resources:apache-source-release-assembly-descriptor` artifact that is added as a dependency of the assembly plugin in the apache parent: https://github.com/apache/maven-apache-parent/blob/apache-21/pom.xml#L352-L378 It does not happen with Camel because Camel seems to provide its own assembly descriptor in https://github.com/apache/camel/blob/master/apache-camel/pom.xml#L227 . We should perhaps do the same. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594546304 OK, let me try `mvn -Prelease release:prepare -DpushChanges=false` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594495544 I mean, how do I build the source distro? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution
ppalaga commented on issue #844: Duplicate LICENSE(.txt) and NOTICE(.txt) files in the source distribution URL: https://github.com/apache/camel-quarkus/issues/844#issuecomment-594494670 @gnodet could you please sketch how did you find this issue? I have an idea where the problem is but I'd like to make sure that my fix will meet your acceptance criteria. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
