[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #3705: Add cloudEvents and knative extensions
zbendhiba commented on code in PR #3705:
URL: https://github.com/apache/camel-quarkus/pull/3705#discussion_r980960482
##
extensions/knative/deployment/src/main/java/org/apache/camel/quarkus/component/knative/deployment/KnativeProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.knative.deployment;
+
+import java.util.List;
+
+import io.quarkus.arc.deployment.UnremovableBeanBuildItem;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.vertx.core.deployment.CoreVertxBuildItem;
+import io.quarkus.vertx.http.deployment.VertxWebRouterBuildItem;
+import org.apache.camel.component.knative.KnativeComponent;
+import org.apache.camel.component.knative.KnativeConstants;
+import org.apache.camel.component.knative.spi.KnativeEnvironment;
+import org.apache.camel.component.knative.spi.KnativeResource;
+import org.apache.camel.quarkus.component.knative.KnativeConsumerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeProducerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeRecorder;
+import org.apache.camel.quarkus.core.deployment.spi.CamelRuntimeBeanBuildItem;
+import org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilter;
+import
org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilterBuildItem;
+import org.apache.camel.spi.ComponentCustomizer;
+
+class KnativeProcessor {
+
+private static final String FEATURE = "camel-knative";
+
+@BuildStep
+FeatureBuildItem feature() {
+return new FeatureBuildItem(FEATURE);
+}
+
+@BuildStep
+List unremovableBeans() {
+return List.of(
+UnremovableBeanBuildItem.beanTypes(KnativeEnvironment.class));
+}
+
+@BuildStep
+List reflectiveClasses() {
Review Comment:
https://issues.apache.org/jira/browse/CAMEL-18561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #3705: Add cloudEvents and knative extensions
zbendhiba commented on code in PR #3705:
URL: https://github.com/apache/camel-quarkus/pull/3705#discussion_r980951313
##
extensions/knative/deployment/src/main/java/org/apache/camel/quarkus/component/knative/deployment/KnativeProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.knative.deployment;
+
+import java.util.List;
+
+import io.quarkus.arc.deployment.UnremovableBeanBuildItem;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.vertx.core.deployment.CoreVertxBuildItem;
+import io.quarkus.vertx.http.deployment.VertxWebRouterBuildItem;
+import org.apache.camel.component.knative.KnativeComponent;
+import org.apache.camel.component.knative.KnativeConstants;
+import org.apache.camel.component.knative.spi.KnativeEnvironment;
+import org.apache.camel.component.knative.spi.KnativeResource;
+import org.apache.camel.quarkus.component.knative.KnativeConsumerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeProducerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeRecorder;
+import org.apache.camel.quarkus.core.deployment.spi.CamelRuntimeBeanBuildItem;
+import org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilter;
+import
org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilterBuildItem;
+import org.apache.camel.spi.ComponentCustomizer;
+
+class KnativeProcessor {
+
+private static final String FEATURE = "camel-knative";
+
+@BuildStep
+FeatureBuildItem feature() {
+return new FeatureBuildItem(FEATURE);
+}
+
+@BuildStep
+List unremovableBeans() {
+return List.of(
+UnremovableBeanBuildItem.beanTypes(KnativeEnvironment.class));
+}
+
+@BuildStep
+List reflectiveClasses() {
Review Comment:
they are both marked with `@Configurer` but it seems to need this BuildStep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #3705: Add cloudEvents and knative extensions
zbendhiba commented on code in PR #3705:
URL: https://github.com/apache/camel-quarkus/pull/3705#discussion_r980948995
##
extensions/knative/deployment/src/main/java/org/apache/camel/quarkus/component/knative/deployment/KnativeProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.knative.deployment;
+
+import java.util.List;
+
+import io.quarkus.arc.deployment.UnremovableBeanBuildItem;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.vertx.core.deployment.CoreVertxBuildItem;
+import io.quarkus.vertx.http.deployment.VertxWebRouterBuildItem;
+import org.apache.camel.component.knative.KnativeComponent;
+import org.apache.camel.component.knative.KnativeConstants;
+import org.apache.camel.component.knative.spi.KnativeEnvironment;
+import org.apache.camel.component.knative.spi.KnativeResource;
+import org.apache.camel.quarkus.component.knative.KnativeConsumerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeProducerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeRecorder;
+import org.apache.camel.quarkus.core.deployment.spi.CamelRuntimeBeanBuildItem;
+import org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilter;
+import
org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilterBuildItem;
+import org.apache.camel.spi.ComponentCustomizer;
+
+class KnativeProcessor {
+
+private static final String FEATURE = "camel-knative";
+
+@BuildStep
+FeatureBuildItem feature() {
+return new FeatureBuildItem(FEATURE);
+}
+
+@BuildStep
+List unremovableBeans() {
+return List.of(
+UnremovableBeanBuildItem.beanTypes(KnativeEnvironment.class));
+}
+
+@BuildStep
+List reflectiveClasses() {
Review Comment:
that is not fixed yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #3705: Add cloudEvents and knative extensions
zbendhiba commented on code in PR #3705: URL: https://github.com/apache/camel-quarkus/pull/3705#discussion_r980085648 ## integration-tests/knative-producer/pom.xml: ## @@ -0,0 +1,195 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.camel.quarkus +camel-quarkus-build-parent-it +2.13.0-SNAPSHOT +../../poms/build-parent-it/pom.xml + + +camel-quarkus-integration-test-knative-producer +Camel Quarkus :: Integration Tests :: Knative Producer +Integration tests for Camel Quarkus Knative Producer extension + + Review Comment: thanks I'll do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #3705: Add cloudEvents and knative extensions
zbendhiba commented on code in PR #3705:
URL: https://github.com/apache/camel-quarkus/pull/3705#discussion_r980085159
##
extensions/knative/deployment/src/main/java/org/apache/camel/quarkus/component/knative/deployment/KnativeProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.knative.deployment;
+
+import java.util.List;
+
+import io.quarkus.arc.deployment.UnremovableBeanBuildItem;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.vertx.core.deployment.CoreVertxBuildItem;
+import io.quarkus.vertx.http.deployment.VertxWebRouterBuildItem;
+import org.apache.camel.component.knative.KnativeComponent;
+import org.apache.camel.component.knative.KnativeConstants;
+import org.apache.camel.component.knative.spi.KnativeEnvironment;
+import org.apache.camel.component.knative.spi.KnativeResource;
+import org.apache.camel.quarkus.component.knative.KnativeConsumerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeProducerRecorder;
+import org.apache.camel.quarkus.component.knative.KnativeRecorder;
+import org.apache.camel.quarkus.core.deployment.spi.CamelRuntimeBeanBuildItem;
+import org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilter;
+import
org.apache.camel.quarkus.core.deployment.spi.CamelServiceFilterBuildItem;
+import org.apache.camel.spi.ComponentCustomizer;
+
+class KnativeProcessor {
+
+private static final String FEATURE = "camel-knative";
+
+@BuildStep
+FeatureBuildItem feature() {
+return new FeatureBuildItem(FEATURE);
+}
+
+@BuildStep
+List unremovableBeans() {
+return List.of(
+UnremovableBeanBuildItem.beanTypes(KnativeEnvironment.class));
+}
+
+@BuildStep
+List reflectiveClasses() {
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
