[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4088: JCache native mode
zhfeng commented on code in PR #4088: URL: https://github.com/apache/camel-quarkus/pull/4088#discussion_r970278736 ## integration-tests/jcache/src/main/resources/application.properties: ## @@ -0,0 +1,17 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- +quarkus.native.resources.includes=reference.conf Review Comment: Thanks for explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4088: JCache native mode
zhfeng commented on code in PR #4088:
URL: https://github.com/apache/camel-quarkus/pull/4088#discussion_r970277955
##
extensions/jcache/deployment/src/main/java/org/apache/camel/quarkus/component/jcache/deployment/JcacheProcessor.java:
##
@@ -34,13 +38,20 @@ FeatureBuildItem feature() {
return new FeatureBuildItem(FEATURE);
}
-/**
- * Remove this once this extension starts supporting the native mode.
- */
-@BuildStep(onlyIf = NativeBuild.class)
-@Record(value = ExecutionTime.RUNTIME_INIT)
-void warnJvmInNative(JvmOnlyRecorder recorder) {
-JvmOnlyRecorder.warnJvmInNative(LOG, FEATURE); // warn at build time
-recorder.warnJvmInNative(FEATURE); // warn at runtime
+@BuildStep
+void nativeResources(BuildProducer services,
+BuildProducer nativeResources) {
Review Comment:
OK, I get it. So it looks like only need
`BuildProducer services` here. Is it right? @ppalaga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4088: JCache native mode
zhfeng commented on code in PR #4088:
URL: https://github.com/apache/camel-quarkus/pull/4088#discussion_r970265256
##
extensions/jcache/deployment/src/main/java/org/apache/camel/quarkus/component/jcache/deployment/JcacheProcessor.java:
##
@@ -34,13 +38,20 @@ FeatureBuildItem feature() {
return new FeatureBuildItem(FEATURE);
}
-/**
- * Remove this once this extension starts supporting the native mode.
- */
-@BuildStep(onlyIf = NativeBuild.class)
-@Record(value = ExecutionTime.RUNTIME_INIT)
-void warnJvmInNative(JvmOnlyRecorder recorder) {
-JvmOnlyRecorder.warnJvmInNative(LOG, FEATURE); // warn at build time
-recorder.warnJvmInNative(FEATURE); // warn at runtime
+@BuildStep
+void nativeResources(BuildProducer services,
+BuildProducer nativeResources) {
Review Comment:
It seems that `nativeResources` does not be used in the method. Did you want
to regiter some resouces in native image?
##
integration-tests/jcache/src/main/resources/application.properties:
##
@@ -0,0 +1,17 @@
+## ---
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---
+quarkus.native.resources.includes=reference.conf
Review Comment:
I can not find `reference.conf` in the test resource. Why we need this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
