[GitHub] [camel-website] zregvart commented on pull request #369: Add customized scrollbar for table and code snippets

2020-05-26 Thread GitBox 


zregvart commented on pull request #369:
URL: https://github.com/apache/camel-website/pull/369#issuecomment-634287391


   I would prefer if we don't target specific browser, this makes it hard for 
us to maintain in the future (we need to test those rules in many 
browsers/versions).
   
   I think this doesn't help much with the way we display tables (they're too 
wide), there has been some work in #271, I think it would be better to finish 
that work so by default we don't have horizontal scrollbars.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-website] zregvart commented on pull request #369: Add customized scrollbar for table and code snippets

2020-06-07 Thread GitBox 


zregvart commented on pull request #369:
URL: https://github.com/apache/camel-website/pull/369#issuecomment-640223552


   @AemieJ let's discuss this on the call on Monday.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-website] zregvart commented on pull request #369: Add customized scrollbar for table and code snippets

2020-06-08 Thread GitBox 


zregvart commented on pull request #369:
URL: https://github.com/apache/camel-website/pull/369#issuecomment-640517220


   On today's call we agreed to research the accessibility implications of this 
change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-website] zregvart commented on pull request #369: Add customized scrollbar for table and code snippets

2020-06-10 Thread GitBox 


zregvart commented on pull request #369:
URL: https://github.com/apache/camel-website/pull/369#issuecomment-642207796


   My understanding is that folk with impaired vision can customize the 
scrollbars appearance through browser/OS customizations, I wasn't sure if they 
can still do that if we customize the scrollbars, @AemieJ have you found that 
they can override and set their own preference?
   
   @AemieJ I'm not sure if you're advocating to customize the scrollbars or 
not, how would you proceed based on the research? From my side if the research 
shows that we won't jeopardize folk with impaired vision so they can still use 
the website and we don't degrade the website aesthetics I'm okay with the 
custom scrollbars. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel-website] zregvart commented on pull request #369: Add customized scrollbar for table and code snippets

2020-06-16 Thread GitBox 


zregvart commented on pull request #369:
URL: https://github.com/apache/camel-website/pull/369#issuecomment-644968319


   This needs to be rebased.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org