Re: [I] Add TLS configuration in the ingress trait [camel-k]
squakez closed issue #5635: Add TLS configuration in the ingress trait URL: https://github.com/apache/camel-k/issues/5635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add TLS configuration in the ingress trait [camel-k]
squakez commented on issue #5635: URL: https://github.com/apache/camel-k/issues/5635#issuecomment-2173258281 Ah, yes, you need to `make generate` before making the image in order to regen the CRDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add TLS configuration in the ingress trait [camel-k]
romain-pfund commented on issue #5635: URL: https://github.com/apache/camel-k/issues/5635#issuecomment-2173172792 hi, got trouble to test it on minikube. I've updated the 3 files, add a test in pkg/trait/ingress_test.go witch is passing From https://camel.apache.org/camel-k/2.3.x/contributing/developers.html#_for_minikube, ran ``` make make images kamel install -olm=false ``` but I keep having `Integration in version "v1" cannot be handled as a Integration: strict decoding error: unknown field "spec.traits.ingress.tlsHosts"` sure I'm missing a simple thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add TLS configuration in the ingress trait [camel-k]
squakez commented on issue #5635: URL: https://github.com/apache/camel-k/issues/5635#issuecomment-2167957877 > I've never done Go development, I may look at it this weekend or monday From what I saw, I mainly on > > * pkg/apis/camel/v1/trait/ingress.go > > * pkg/trait/ingress.go > > * pkg/trait/ingress_test.go Yeah, that's correct. This particular development should not require the knowledge of the entire operator. If the unit tests are passing, then, we should be fine. Have a look at https://camel.apache.org/camel-k/next/contributing/developers.html and feel free to ping either here on in Zulip chat to get any support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add TLS configuration in the ingress trait [camel-k]
romain-pfund commented on issue #5635: URL: https://github.com/apache/camel-k/issues/5635#issuecomment-2167953597 I've never done Go development, I may look at it this weekend or monday From what I saw, I mainly on - pkg/apis/camel/v1/trait/ingress.go - pkg/trait/ingress.go - pkg/trait/ingress_test.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add TLS configuration in the ingress trait [camel-k]
squakez commented on issue #5635: URL: https://github.com/apache/camel-k/issues/5635#issuecomment-2167733161 Thanks. Contributions are welcomed as usual! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Add TLS configuration in the ingress trait [camel-k]
romain-pfund opened a new issue, #5635:
URL: https://github.com/apache/camel-k/issues/5635
### Requirement
As an integration developper using camel-k, I want to user TLS on my
ingresses so I can securely contact my camel-k integrations
### Problem
To fully configure TLS on an ingress, we need to set the spec.tls part
(hosts and secretName).
https://kubernetes.io/docs/concepts/services-networking/ingress/#tls
But this is actually not covered by the actual ingress trait
### Proposal
Implement this configuration properties:
```
ingress.tls.hosts | list[string]
ingress.tls.secretName | string
```
to set
```
apiVersion: networking.k8s.io/v1
kind: Ingress
...
spec:
tls:
- hosts:
- {{ingress.tls.hosts[]}}
secretName: {{ingress.tls.secretName}}
...
```
### Open questions
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
