Re: [I] Consider using metav1.Condition instead of own condition structs [camel-k]

2024-05-27 Thread via GitHub 


github-actions[bot] commented on issue #5191:
URL: https://github.com/apache/camel-k/issues/5191#issuecomment-2134164284

   This issue has been automatically marked as stale due to 90 days of 
inactivity.
   It will be closed if no further activity occurs within 15 days.
   If you think that’s incorrect or the issue should never stale, please simply 
write any comment.
   Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Consider using metav1.Condition instead of own condition structs [camel-k]

2024-02-27 Thread via GitHub 


christophd opened a new issue, #5191:
URL: https://github.com/apache/camel-k/issues/5191

   ### Requirement
   
   Use the default `metav1.Condition` as conditions on Camel K custom resources.
   
   ### Problem
   
   The conditions used in the Camel K custom resources usually are structs that 
alias to strings.
   
   Instead of this we could try to just reuse `metav1.Condition`, which would 
allow to manipulate conditions using some [k8s 
utilities](https://github.com/kubernetes/apimachinery/blob/master/pkg/api/meta/conditions.go).
   
   The downside is that we won't have the specific condition type, but given 
99% of the time is just an alias to strings and there are no real enums in go, 
I don't see anymore a very strong benefit.
   
   ### Proposal
   
   _No response_
   
   ### Open questions
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org