Re: [I] Fix flaky health trait test [camel-k]

2024-04-24 Thread via GitHub


christophd closed issue #4922: Fix flaky health trait test
URL: https://github.com/apache/camel-k/issues/4922


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Fix flaky health trait test [camel-k]

2024-04-10 Thread via GitHub


christophd commented on issue #4922:
URL: https://github.com/apache/camel-k/issues/4922#issuecomment-2046914252

   Some more analysis on this flaky test can be found in #5345 which is a 
duplicate of this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Fix flaky health trait test [camel-k]

2023-12-15 Thread via GitHub


rinaldodev commented on issue #4922:
URL: https://github.com/apache/camel-k/issues/4922#issuecomment-1858276507

   To bring more clarity to this issue: this appears to be caused by the 
camel-routes health check reporting as Ready before the routes had some time to 
load. See https://issues.apache.org/jira/browse/CAMEL-20242.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Fix flaky health trait test [camel-k]

2023-11-21 Thread via GitHub


rinaldodev commented on issue #4922:
URL: https://github.com/apache/camel-k/issues/4922#issuecomment-1821401158

   @squakez I believe that one is fine. Yes, you can assign it to me, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Fix flaky health trait test [camel-k]

2023-11-21 Thread via GitHub


squakez commented on issue #4922:
URL: https://github.com/apache/camel-k/issues/4922#issuecomment-1820435500

   @rinaldodev thanks for reporting. What labels do you think it is required? 
Please also let me know if you are going to work on this so I can assign to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Fix flaky health trait test [camel-k]

2023-11-20 Thread via GitHub


rinaldodev commented on issue #4922:
URL: https://github.com/apache/camel-k/issues/4922#issuecomment-1819455863

   Would someone please update the labels on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Fix flaky health trait test [camel-k]

2023-11-20 Thread via GitHub


rinaldodev opened a new issue, #4922:
URL: https://github.com/apache/camel-k/issues/4922

   ### What happened?
   
   While running [this 
test](https://github.com/apache/camel-k/blob/2089fc29e996784e9af9c695c8bbb40f6a59ece1/e2e/common/traits/health_test.go#L359C14-L359C14),
   I noticed the Integration's Ready condition is true for a while before 
becoming false, which in turns makes 
[this](https://github.com/apache/camel-k/blob/2089fc29e996784e9af9c695c8bbb40f6a59ece1/e2e/common/traits/health_test.go#L369)
 assertion fail sometimes.
   Making the test flaky.
   
   ```
   - firstTruthyTime: "2023-11-20T13:02:00Z"
 lastTransitionTime: "2023-11-20T13:02:00Z"
 lastUpdateTime: "2023-11-20T13:02:00Z"
 message: 1/1 ready replicas
 reason: DeploymentReady
 status: "True"
 type: Ready
   ```
   
   ### Steps to reproduce
   
   Run [this e2e 
test](https://github.com/apache/camel-k/blob/main/e2e/common/traits/health_test.go)
 a few times until it fails.
   
   ### Relevant log output
   
   ```shell
   apiVersion: camel.apache.org/v1
   kind: Integration
   metadata:
 annotations:
   camel.apache.org/operator.id: test-305d00bf-726e-4415-9567-2573502fa0bf
 creationTimestamp: "2023-11-20T12:49:24Z"
 generation: 1
 name: never-readypnryt
 namespace: test-305d00bf-726e-4415-9567-2573502fa0bf
 resourceVersion: "19430"
 uid: aa15f5f4-1343-4d20-b61c-48cc8f187298
   spec:
 sources:
 - content: |
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed 
with
  * this work for additional information regarding copyright ownership.
  * The ASF licenses this file to You under the Apache License, Version 
2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
  *
  *  http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
   
 import org.apache.camel.builder.RouteBuilder;
   
 public class NeverReady extends RouteBuilder {
 @Override
 public void configure() throws Exception {
 from("timer:tick").id("never-ready")
 
.to("controlbus:route?routeId=never-ready=stop=true")
 .setHeader("m").constant("string!")
 .setBody().simple("Magic${header.m}")
 .log("${body}");
 }
 }
   name: NeverReady.java
 traits:
   health:
 enabled: true
 livenessProbeEnabled: false
 livenessScheme: HTTP
 readinessProbeEnabled: true
 readinessScheme: HTTP
 startupProbeEnabled: false
 startupScheme: HTTP
   status:
 conditions:
 - firstTruthyTime: "2023-11-20T12:49:24Z"
   lastTransitionTime: "2023-11-20T12:49:24Z"
   lastUpdateTime: "2023-11-20T12:49:24Z"
   message: 
test-305d00bf-726e-4415-9567-2573502fa0bf/test-305d00bf-726e-4415-9567-2573502fa0bf
   reason: IntegrationPlatformAvailable
   status: "True"
   type: IntegrationPlatformAvailable
 - firstTruthyTime: "2023-11-20T12:49:24Z"
   lastTransitionTime: "2023-11-20T12:49:24Z"
   lastUpdateTime: "2023-11-20T12:49:24Z"
   message: explicitly disabled by the user
   reason: masterTraitConfiguration
   status: "True"
   type: TraitInfo
 - firstTruthyTime: "2023-11-20T13:01:56Z"
   lastTransitionTime: "2023-11-20T13:01:56Z"
   lastUpdateTime: "2023-11-20T13:01:56Z"
   message: kit-cldlbl2hqaes73e5b8j0
   reason: IntegrationKitAvailable
   status: "True"
   type: IntegrationKitAvailable
 - firstTruthyTime: "2023-11-20T13:01:56Z"
   lastTransitionTime: "2023-11-20T13:01:56Z"
   lastUpdateTime: "2023-11-20T13:01:56Z"
   message: deployment name is never-readypnryt
   reason: DeploymentAvailable
   status: "True"
   type: DeploymentAvailable
 - firstTruthyTime: "2023-11-20T13:02:00Z"
   lastTransitionTime: "2023-11-20T13:02:00Z"
   lastUpdateTime: "2023-11-20T13:02:00Z"
   message: 1/1 ready replicas
   reason: DeploymentReady
   status: "True"
   type: Ready
 dependencies:
 - camel:controlbus
 - camel:timer
 - mvn:org.apache.camel.k:camel-k-runtime
 - mvn:org.apache.camel.quarkus:camel-quarkus-java-joor-dsl
 - mvn:org.apache.camel.quarkus:camel-quarkus-microprofile-health
 digest: vZi_hPRbPLDXMUuj2SPoFJLW2OPdK7PcY7M79Rh_eGB8
 image: