Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
squakez merged PR #5425: URL: https://github.com/apache/camel-k/pull/5425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
claudio4j commented on PR #5425: URL: https://github.com/apache/camel-k/pull/5425#issuecomment-2083465816 It would be good to also add some sort of visual aid to the deprecated field, as we see from [quarkus trait](https://camel.apache.org/camel-k/next/traits/quarkus.html), there are two deprecated fields, but there is no visual aid to help users to quickly notice it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1583202850 ## addons/tracing/tracing.go: ## @@ -38,6 +38,7 @@ import ( // WARNING: The Tracing trait can't be enabled at the same time as the Telemetry trait. // // +camel-k:trait=tracing. +// +camel-k:deprecated=2.3.0. Review Comment: ```suggestion // +camel-k:deprecated=1.12.0. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580680838 ## pkg/apis/camel/v1/trait/dependencies.go: ## @@ -20,7 +20,10 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal +// +//lint:ignore SA1000 Ignore the requirement for comments to end in a period. Review Comment: However I'm not 100% sure that this is really happening. Try running a `make lint` to validate it without the dot, I may be just wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580679628 ## pkg/apis/camel/v1/trait/dependencies.go: ## @@ -20,7 +20,10 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal +// +//lint:ignore SA1000 Ignore the requirement for comments to end in a period. Review Comment: I prefer the lint to be quiet :) (so yes, better let the dot) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
tdiesler commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580674609 ## pkg/apis/camel/v1/trait/dependencies.go: ## @@ -20,7 +20,10 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal +// +//lint:ignore SA1000 Ignore the requirement for comments to end in a period. Review Comment: We would get an odd dot after a version ``` // +camel-k:trait=registry. // +camel-k:deprecated=2.2.0. ``` I don't mind, do you prefer that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580667845 ## pkg/apis/camel/v1/trait/dependencies.go: ## @@ -20,7 +20,10 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal +// +//lint:ignore SA1000 Ignore the requirement for comments to end in a period. Review Comment: Why ignoring the lint warning? IMO we should follow its guidelines and just add the dot at the end, as we were using to do before. Mind that by adding the `nolint` at that level we'd swallow any other lint warning related to this category. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580620317 ## pkg/apis/camel/v1/trait/dependencies.go: ## @@ -20,7 +20,8 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal Review Comment: I think `lint` will complain as expects comments to end with a dot. Just `make lint` to verify. ## docs/modules/ROOT/partials/apis/camel-k-crds.adoc: ## @@ -8240,8 +8240,6 @@ Deprecated: for backward compatibility. * <<#_camel_apache_org_v1_IntegrationKitTraits, IntegrationKitTraits>> * <<#_camel_apache_org_v1_Traits, Traits>> -WARNING: The Registry trait is **deprecated** and will removed in future release versions. Review Comment: We can probably keep both image and description message, I don't think they are incompatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5424) Generate badges & ignore internal traits [camel-k]
tdiesler commented on PR #5425: URL: https://github.com/apache/camel-k/pull/5425#issuecomment-2077302806 The second commit ignores the internal `dependencies` trait -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
