Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2122665234 Like so ... https://github.com/apache/camel-k/pull/5518/commits/787a1d6f826be2a94523ed06588586387be574fe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
squakez commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2122272606 See: https://github.com/apache/camel-k/blob/4317da83d0f15137b12da6a2204d2543bd9e4603/docs/modules/traits/pages/3scale.adoc?plain=1#L21 We need to make the change on the go file and then, `make generate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2122255426 I rebased those changes on main and see no differences. I believe I already changed stuff at the source i.e. the trait Go files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
squakez commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2115476670 @tdiesler we did changes in autogenerated code in traits. It is likely that tonight it will be reverted back. You need to change the content of the trait golang files and later `make generate` to refresh the autogen content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
oscerd commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2114427521 The build seems to be fine. The website should be online in a few minutes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
oscerd commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2114303578 Sorry for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2114302026 Thanks @oscerd - the msg for the squashed commit is a little awkward As you might recall, I squash stuff already before I do a PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
oscerd commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2114240725 https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/1612/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
oscerd merged PR #5497: URL: https://github.com/apache/camel-k/pull/5497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2114231085 Ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2112961152 Could we run this again pls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
oscerd commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2112551397 > ``` > $ ./docs/local-build.sh quick > [15:31:01.130] INFO (@djencks/antora-timer): stage playbookBuilt took 0.167s > [15:31:01.132] INFO (@djencks/antora-timer): Extensions after stage playbookBuilt took 0.002s > [15:31:01.135] INFO (@djencks/antora-timer): stage beforeProcess took 0.003s > [15:31:01.136] INFO (@djencks/antora-timer): Extensions after stage beforeProcess took 0.001s > [15:31:01.229] INFO (@djencks/antora-timer): stage uiLoaded took 0.093s > [15:31:01.229] INFO (@djencks/antora-timer): Extensions after stage uiLoaded took 0s > [15:31:01.258] INFO (@djencks/antora-timer): stage contentAggregated took 0.029s > [15:31:01.259] INFO (@djencks/antora-timer): Extensions after stage contentAggregated took 0.001s > [15:31:01.262] INFO (@djencks/antora-timer): stage contentClassified took 0.003s > [15:31:01.289] INFO (@djencks/antora-timer): Extensions after stage contentClassified took 0.027s > [15:31:02.842] INFO (@djencks/antora-timer): stage documentsConverted took 1.553s > [15:31:02.842] INFO (@djencks/antora-timer): Extensions after stage documentsConverted took 0s > [15:31:02.849] INFO (@djencks/antora-timer): stage navigationBuilt took 0.007s > [15:31:02.849] INFO (@djencks/antora-timer): Extensions after stage navigationBuilt took 0s > [15:31:03.049] INFO (@djencks/antora-timer): stage pagesComposed took 0.2s > [15:31:03.049] INFO (@djencks/antora-timer): Extensions after stage pagesComposed took 0s > [15:31:03.050] INFO (@djencks/antora-timer): stage redirectsProduced took 0.001s > [15:31:03.050] INFO (@djencks/antora-timer): Extensions after stage redirectsProduced took 0s > [15:31:03.052] INFO (@djencks/antora-timer): stage siteMapped took 0.002s > [15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage siteMapped took 0s > [15:31:03.052] INFO (@djencks/antora-timer): stage beforePublish took 0s > [15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage beforePublish took 0s > Site generation complete! > Open file:///Users/tdiesler/git/camel-website/documentation in a browser to view your site. > [15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0.081s > [15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0s > [15:31:03.133] INFO (@djencks/antora-timer): total build time 2.17s > ``` This is good, but the full build from the website on the CI might fail anyway. It happened before. But this is great! Thanks @tdiesler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2112542048 ``` $ ./docs/local-build.sh quick [15:31:01.130] INFO (@djencks/antora-timer): stage playbookBuilt took 0.167s [15:31:01.132] INFO (@djencks/antora-timer): Extensions after stage playbookBuilt took 0.002s [15:31:01.135] INFO (@djencks/antora-timer): stage beforeProcess took 0.003s [15:31:01.136] INFO (@djencks/antora-timer): Extensions after stage beforeProcess took 0.001s [15:31:01.229] INFO (@djencks/antora-timer): stage uiLoaded took 0.093s [15:31:01.229] INFO (@djencks/antora-timer): Extensions after stage uiLoaded took 0s [15:31:01.258] INFO (@djencks/antora-timer): stage contentAggregated took 0.029s [15:31:01.259] INFO (@djencks/antora-timer): Extensions after stage contentAggregated took 0.001s [15:31:01.262] INFO (@djencks/antora-timer): stage contentClassified took 0.003s [15:31:01.289] INFO (@djencks/antora-timer): Extensions after stage contentClassified took 0.027s [15:31:02.842] INFO (@djencks/antora-timer): stage documentsConverted took 1.553s [15:31:02.842] INFO (@djencks/antora-timer): Extensions after stage documentsConverted took 0s [15:31:02.849] INFO (@djencks/antora-timer): stage navigationBuilt took 0.007s [15:31:02.849] INFO (@djencks/antora-timer): Extensions after stage navigationBuilt took 0s [15:31:03.049] INFO (@djencks/antora-timer): stage pagesComposed took 0.2s [15:31:03.049] INFO (@djencks/antora-timer): Extensions after stage pagesComposed took 0s [15:31:03.050] INFO (@djencks/antora-timer): stage redirectsProduced took 0.001s [15:31:03.050] INFO (@djencks/antora-timer): Extensions after stage redirectsProduced took 0s [15:31:03.052] INFO (@djencks/antora-timer): stage siteMapped took 0.002s [15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage siteMapped took 0s [15:31:03.052] INFO (@djencks/antora-timer): stage beforePublish took 0s [15:31:03.052] INFO (@djencks/antora-timer): Extensions after stage beforePublish took 0s Site generation complete! Open file:///Users/tdiesler/git/camel-website/documentation in a browser to view your site. [15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0.081s [15:31:03.133] INFO (@djencks/antora-timer): stage sitePublished took 0s [15:31:03.133] INFO (@djencks/antora-timer): total build time 2.17s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
oscerd commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2112436236 If we merge, let's run the ci-build for website here: https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/ in case something is broken we need to fix it soon or revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2112297718 All docs should be done - ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
tdiesler commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2110450553 Ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (#5489) Groovy > Yaml [camel-k]
github-actions[bot] commented on PR #5497: URL: https://github.com/apache/camel-k/pull/5497#issuecomment-2110150678 :warning: Unit test coverage report - coverage decreased from 38.2% to 38.1% (**-0.1%**) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
