Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
oscerd merged PR #12670: URL: https://github.com/apache/camel/pull/12670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
otavioprado commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882968852 > You could do something like mvnd clean install -Dquickly @oscerd done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
oscerd commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882956111 You could do something like mvnd clean install -Dquickly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
otavioprado commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882935462 @oscerd, to address the build issue, should I have run `mvn clean install -DskipTests` locally and committed all the auto-generated changes? Please note that there are numerous changes if I need to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
oscerd commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882909592 Let's wait for green build and then I'll merge. Thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
otavioprado commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882907436 > I guess you'll need to rebase @otavioprado and fix the conflict. All good after that. @oscerd conflict fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
oscerd commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882901451 I guess you'll need to rebase @otavioprado and fix the conflict. All good after that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
otavioprado commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882873134 > I think we could merge this one. But we should add a note in the migration guide between 4.3 and 4.4 I've just added a note about this to the following location: docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_4.adoc. Please let me know if any further adjustments are necessary. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
aeberhart commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882844229 I am one of the maintainers of the new jsonata lib. I wanted to provide some context on this lib and hopefully ease some of the concerns that @orpiske rightfully voiced about changing dependencies. You can find a list of JSONata implementations here: https://docs.jsonata.org/next/overview. At the moment there are two Java implementations: [JSONata4Java](https://github.com/IBM/JSONata4Java) and [jsonata-java](https://github.com/dashjoin/jsonata-java). We use JSONata heavily for our low code platform (https://github.com/dashjoin/platform) and started out with JSONata4Java. Works great but there are some [limitations](https://github.com/IBM/JSONata4Java?tab=readme-ov-file#current-limitations) with more complex expressions which can be frustrating because something that works in the JSONata playground does not in the Java environment. Then we decided to leverage the JS language reference via graal, which worked but had some performance issues. Finally, we started our Java version which is a 1:1 port of the original JS reference implementation to Java. This ensures * 100% compatibility with the language specification * an easy path to port future changes in the language and bugfixes into the Java world by keeping the code structure, comments, formatting of the original as much as possible As far as I know, there are no expressions that evaluate differently when changing the library. This means that Camel code does not have to be changed when upgrading. We're also committed to maintaining the library. Of course more contributors are always welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
oscerd commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1882813756 I think we could merge this one. But we should add a note in the migration guide between 4.3 and 4.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20298] Enhancing JSONata Compatibility for Full Reference Port [camel]
orpiske commented on PR #12670: URL: https://github.com/apache/camel/pull/12670#issuecomment-1880033142 Thank you @otavioprado. Many members of the community are currently on / returning from PTO. So, let's just wait a bit more until they are fully back in the game. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
