Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1935662658 We can close this. I merged the typo fix on #13069 (which was what we needed). Unfortunately I couldn't cherry-pick the specific change, but credits were given in the commit message. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske closed pull request #12966: [Camel 20377] *IT tests should be run with failsafe instead of surefire URL: https://github.com/apache/camel/pull/12966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1932492310 > Due to the default activation rules, the full profile seems to interfere with the ability to run integration tests as a standalone task. The only way I could run them was via the profile that I created. If there is a combination of properties and profiles that enables integration tests to run, please let me know what that is, as it is not documented as far as I can tell. If you are running [as you described above](https://github.com/apache/camel/pull/12966#discussion_r1476489604) (where you said you were running the command `mvn failsafe:verify`), then you are **doing it wrong**. That's why the tests are not running for you. You should use `mvn verify` [as explained in the failsafe documentation](https://maven.apache.org/surefire/maven-failsafe-plugin/). > > I can try to move the profile to `parent/pom.xml` but it may not work, if my memory is correct. The only item to fix is the typo on the project's `pom.xml` file. > In any case, how would a contributor know what belongs in `pom.xml` vs `parent/pom.xml`? Typically, learning the details about a project happen organically: via reviews, discussions (on Zulip, here or on the mailing list, etc), etc. This is specially true a in project as large and as complex as Camel, with a rather small number of core contributors. We try our best to document how users can get started with [contributions in our Contributing Guide](https://camel.apache.org/camel-core/contributing/). In there, we link to a number of issues that are [good for first timers](https://issues.apache.org/jira/browse/CAMEL-20384?filter=12348073): issues and improvements that don't involve the project build, CI, core code, architecture and other items that may require a greater understanding of the project needs and requirements. [That's how many of us started](https://github.com/apache/camel/pull/2887). In many cases, we rely on convention over configuration (such as the case of running the unit tests using `mvn test` and the integration tests using `mvn verify`), so that contributors jumping from another project can reuse what they've learned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
cziesman commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1932333613 Due to the default activation rules, the full profile seems to interfere with the ability to run integration tests as a standalone task. The only way I could run them was via the profile that I created. If there is a combination of properties and profiles that enables integration tests to run, please let me know what that is, as it is not documented as far as I can tell. I can try to move the profile to `parent/pom.xml` but it may not work, if my memory is correct. In any case, how would a contributor know what belongs in `pom.xml` vs `parent/pom.xml`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1932170509 > What is the status/consensus on this PR? > > > > We will cut 4.4 LTS start of next week so we should get this done before, or move to 4.5 There's only a typo to be fixed here. The tests were not running for the contributor because he was using the incorrect command to do so. It would still be good to fix the typo, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
davsclaus commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1931955907 What is the status/consensus on this PR? We will cut 4.4 LTS start of next week so we should get this done before, or move to 4.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475782422
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
I am truly sorry for having missed this, but I would like us to avoid piling
up the build with profiles that are very rarely used (by ourselves or by our CI
or by the automation that we have).
We (myself included) spent a lot of time cleaning up a several profiles that
existed on Camel 3 but we never used and complicated the build.
For profiles, the less and simpler, the better. And this is specially true
now that we have to tweak the build so it works flawlessly in different
architectures (x86, aarch64, s390x, ppc6le).
Lastly, the configuration part is not necessary because [failsafe already
does (most of) this by
default](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html).
There ~are~were, indeed, some test cases that are (incorrectly) named
`*IntegrationTest.java` (in `camel-google` and in `camel-salesforce`), but the
proper fix here is to rename them to `*IT.java` as we did in the past.
@davsclaus @oscerd wdyt?
*Update*: there were 5 tests named incorrectly in Camel google. There were
fixed by #12983.
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
I am truly sorry for having missed this, but I would like us to avoid piling
up the build with profiles that are very rarely used (by ourselves or by our CI
or by the automation that we have).
We (myself included) spent a lot of time cleaning up a several profiles that
existed on Camel 3 but we never used and complicated the build.
For profiles, the less and simpler, the better. And this is specially true
now that we have to tweak the build so it works flawlessly in different
architectures (x86, aarch64, s390x, ppc6le).
Lastly, the configuration part is not necessary because [failsafe already
does (most of) this by
default](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html).
There ~are~were, indeed, some test cases that are (incorrectly) named
`*IntegrationTest.java` (in `camel-google` and in `camel-salesforce`), but the
proper fix here is to rename them to `*IT.java` as we did in the past.
@davsclaus @oscerd wdyt?
**Update**: there were 5 tests named incorrectly in Camel google. There were
fixed by #12983.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1477006645
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
Review Comment:
This change, if necessary, should be done on the parent pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476513291
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
You should use: `mvn verify` [to run the
tests](https://maven.apache.org/surefire/maven-failsafe-plugin/) (unit +
integration).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476517267
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
My workflow (and I guess, the same for other committers) is just:
```
cd path/to/project
# Build with Maven Daemon, for quicker build (just once, unless I am working
on core changes also)
mvnd -Dquickly clean install
# Go to whatever you are working on (i.e.; camel-kafka)
cd components/camel-kafka
# Run the tests
mvn verify
```
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476517267
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
My workflow (and I guess, the same for other committers) is just:
```
cd path/to/project
# Build with Maven Daemon, for quicker build
mvnd -Dquickly clean install
# Go to whatever you are working on (i.e.; camel-kafka)
cd components/camel-kafka
# Run the tests
mvn verify
```
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476517267
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
My (and I guess, the same for other committers) is just:
```
cd path/to/project
# Build with Maven Daemon, for quicker build
mvnd -Dquickly clean install
# Go to whatever you are working on (i.e.; camel-kafka)
cd components/camel-kafka
# Run the tests
mvn verify
```
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476513291
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
You should use: `mvn verify` to run the tests (unit + integration).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
cziesman commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476489604
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
Has anybody else tried to run integration tests lately? When I run `mvn
failsafe:verify` against `main`, I get dozens of these errors:
```
[WARNING] The POM for
org.apache.maven.plugins:maves-surefire-plugin:jar:3.2.5 is missing, no
dependency information available
[WARNING] Failed to retrieve plugin descriptor for
org.apache.maven.plugins:maves-surefire-plugin:3.2.5: Plugin
org.apache.maven.plugins:maves-surefire-plugin:3.2.5 or one of its dependencies
could not be resolved: The following artifacts could not be resolved:
org.apache.maven.plugins:maves-surefire-plugin:jar:3.2.5 (absent):
org.apache.maven.plugins:maves-surefire-plugin:jar:3.2.5 was not found in
https://repo.maven.apache.org/maven2 during a previous attempt. This failure
was cached in the local repository and resolution is not reattempted until the
update interval of central has elapsed or updates are forced
```
It turns out that this line in `pom.xml`
`maves-surefire-plugin`
should be this:
`maven-surefire-plugin`
When I fix that, no integration tests are executed. Maybe there is a magic
combination of properties and profiles that enables integration tests to run,
but I couldn't figure it out.
You make a very good point about reducing complexity, but I think maybe
there needs to be a separate effort to refactor the POM structure. Things seem
to have gotten so complicated that tests can't even run reliably. In the
meantime, after days of trying, the profile that I created is the only way I
could find to run integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476463946
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
org.apache.maven.plugins
maven-failsafe-plugin
-${maven-surefire-plugin-version}
+${maven-failsafe-plugin-version}
Review Comment:
Yeah, I think this is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
cziesman commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476443510
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
org.apache.maven.plugins
maven-failsafe-plugin
-${maven-surefire-plugin-version}
+${maven-failsafe-plugin-version}
Review Comment:
The versions are the same today, but that may not always be the case. Or,
there may be a bug in one of the plugins that requires reverting to a previous
version. Finally, just for clarity, the version property name should match the
artifact ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
cziesman commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1476428491
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
Review Comment:
Surefire doesn't automatically exclude the pattern `*IntegrationTest.java`.
I added all of the combinations just for completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475809322
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
Review Comment:
On more note is that any configuration to the surefire configuration needs
to be done on the parent's [pom.xml
file](https://github.com/apache/camel/blob/main/parent/pom.xml). If needed,
it's better to keep it in a single place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475782422
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
I am truly sorry for having missed this, but I would like us to avoid piling
up the build with profiles that are very rarely used (by ourselves or by our CI
or by the automation that we have).
We (myself included) spent a lot of time cleaning up a several profiles that
existed on Camel 3 but we never used and complicated the build.
For profiles, the less and simpler, the better. And this is specially true
now that we have to tweak the build so it works flawlessly in different
architectures (x86, aarch64, s390x, ppc6le).
Lastly, the configuration part is not necessary because [failsafe already
does (most of) this by
default](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html).
There are, indeed, some test cases that are (incorrectly) named
`*IntegrationTest.java` (in `camel-google` and in `camel-salesforce`), but the
proper fix here is to rename them to `*IT.java` as we did in the past.
@davsclaus @oscerd wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475794696
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
Review Comment:
We don't really need this. Surefire [already does it by
default](https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html).
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
${maven-surefire-plugin-version}
+
+
+**/*Test.java
+
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
org.apache.maven.plugins
maven-failsafe-plugin
-${maven-surefire-plugin-version}
+${maven-failsafe-plugin-version}
Review Comment:
This is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475782422
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
I am truly sorry for having missed this, but I would us to avoid piling up
the build with profiles that are very rarely used (by ourselves or by our CI or
by the automation that we have).
We (myself included) spent a lot of time cleaning up a several profiles that
existed on Camel 3 but we never used and complicated the build.
For profiles, the less and simpler, the better. And this is specially true
now that we have to tweak the build so it works flawlessly in different
architectures (x86, aarch64, s390x, ppc6le).
Lastly, the configuration part is not necessary because [failsafe already
does (most of) this by
default](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html).
There are, indeed, some test cases that are (incorrectly) named
`*IntegrationTest.java` (in `camel-google` and in `camel-salesforce`), but the
proper fix here is to rename them to `*IT.java` as we did in the past.
@davsclaus @oscerd wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
oscerd commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475799453
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
I think it's better to avoid more profiles, we have already enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1475782422
##
pom.xml:
##
@@ -915,5 +925,37 @@
+
+integration-test
+
+
+
+
+
+org.apache.maven.plugins
+maven-failsafe-plugin
+${maven-failsafe-plugin-version}
+
+
+
+integration-test
+verify
+
+
+
+
+false
+
+**/*IT.java
+**/*IntegrationTest.java
+
+
+**/*Test.java
+
+
+
+
+
+
Review Comment:
I am truly sorry for having missed this, but I would us to avoid piling up
the build with profiles that are very rarely used (by ourselves or by our CI or
by the automation that we have).
We (myself included) spent a lot of time cleaning up a several profiles that
existed on Camel 3 but we never used and complicated the build.
For profiles, the less and simpler, the better.
@davsclaus @oscerd wdyt?
##
pom.xml:
##
@@ -409,13 +410,22 @@
org.apache.maven.plugins
-maves-surefire-plugin
+maven-surefire-plugin
Review Comment:
This is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1923129459 /component-test camel-kafka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
github-actions[bot] commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1923130741 :robot: The Apache Camel test robot will run the tests for you :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
davsclaus commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1923102384 ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1923098634 Hey @davsclaus and @oscerd , please hold on just a bit on this one. There is something else I need to check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
davsclaus commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1922858692 There is a merge conflict I wonder if you can fix that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
cziesman commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1474782773
##
parent/pom.xml:
##
@@ -260,7 +260,7 @@
5.1.0
0.7.7
12.0.5
-${jetty-version}
+11.0.19
Review Comment:
No, the Maven plugin version does not track with the Jetty version. Highest
plugin version is 11.0.20, released 31 Jan, 2024.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
orpiske commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1920719843 Oh and just one minor nitpick stuff. If you write your commit messages like this `CAMEL-20377: ` the PR request gets automatically associated with the ticket, which makes it a lot easier for us to track the changes and what is going on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
davsclaus commented on code in PR #12966:
URL: https://github.com/apache/camel/pull/12966#discussion_r1473820072
##
parent/pom.xml:
##
@@ -260,7 +260,7 @@
5.1.0
0.7.7
12.0.5
-${jetty-version}
+11.0.19
Review Comment:
Is there not a v12 of the jetty maven plugin ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
github-actions[bot] commented on PR #12966: URL: https://github.com/apache/camel/pull/12966#issuecomment-1920039709 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [Camel 20377] *IT tests should be run with failsafe instead of surefire [camel]
cziesman opened a new pull request, #12966: URL: https://github.com/apache/camel/pull/12966 # Description There are many tests that use TestContainers and Docker in *IT.java classes that are currently being run by the `surefire` plugin. These tests should be run by `failsafe`, as they meet the definition of integration tests, not unit tests, and should not cause the whole build to fail if any of them fail. Use the command `mvn verify -Pintegration-test -Dquickly=true` to run the integration tests. Using any other Maven commands with the `default` or `full` profiles that invoke the test phase should only run unit tests. Existing profiles that have their own `failsafe` configuration for integration tests should not be affected. # Target - [ X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [ X] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [ X] I checked that each commit in the pull request has a meaningful subject line and body. - [ X] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
