Re: [PR] Add quarkus-artemis dependencies to the BOM [camel-quarkus]

2024-02-19 Thread via GitHub


jamesnetherton commented on PR #5763:
URL: https://github.com/apache/camel-quarkus/pull/5763#issuecomment-1953079898

   Need to think a bit more on this. Thus closing for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add quarkus-artemis dependencies to the BOM [camel-quarkus]

2024-02-19 Thread via GitHub


jamesnetherton closed pull request #5763: Add quarkus-artemis dependencies to 
the BOM
URL: https://github.com/apache/camel-quarkus/pull/5763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add quarkus-artemis dependencies to the BOM [camel-quarkus]

2024-02-16 Thread via GitHub


jamesnetherton commented on PR #5763:
URL: https://github.com/apache/camel-quarkus/pull/5763#issuecomment-1948512126

   Hmmm - now I think a bit more, maybe we should just import 
`quarkus-artemis-bom` and have all of its content in our BOM. Otherwise we 
maybe mess up user apps if they import `camel-quarkus-bom` & 
`quarkus-artemis-bom`.
   
   E.g you may end up with conflicting versions depending on the order things 
are imported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Add quarkus-artemis dependencies to the BOM [camel-quarkus]

2024-02-16 Thread via GitHub


jamesnetherton opened a new pull request, #5763:
URL: https://github.com/apache/camel-quarkus/pull/5763

   @zhfeng WDYT?
   
   I was thinking that maybe we should  just explicitly add the bits of 
quarkus-artemis we actually need. Instead of importing the BOM, which causes 
all `io.quarkiverse` & `org.apache.activemq` dependencies to get added to the 
BOM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org