Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
davsclaus merged PR #11754: URL: https://github.com/apache/camel/pull/11754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1366867752 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: the 2 other PRs have been merged. Less code change in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1365455339 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: Second PR provided to replace unitcore with assertj https://github.com/apache/camel/pull/11774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1365023002 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: First PR provided for the factorization of the xmlunit-core dependency in dependencyManagement https://github.com/apache/camel/pull/11767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1363825212 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: I can update to use the same xmlunit-core in this PR, and provide a different PR to migrate from xmlunit-core to xmlunit-assertj3 to separate concerns and discuss if it is worthy or not to use the introduced one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1363695118 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: for `xmlunit-core`, it was already used in several projects. In this PR, I only factorize it in the parent dependencyManagement. for `xmlunit-assertj3`, it allows to write simpler code and have a better error message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1363695118 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: for `xmlunit-core`, it was already used in several projects. for `xmlunit-assertj3`, it allows to write simpler code and have a better error message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
oscerd commented on code in PR #11754: URL: https://github.com/apache/camel/pull/11754#discussion_r1363585298 ## parent/pom.xml: ## @@ -2697,6 +2697,18 @@ pom import + Review Comment: Unless there is a good reason I would avoid adding other dependencies in parent/pom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
apupier opened a new pull request, #11754: URL: https://github.com/apache/camel/pull/11754 * With Java 21, the order of attributes are different but it does not change the semantic * factorize the xml-unit version in parent pom # Description # Target - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20008 - Improve assertion to compare xml and not string in XMLTokenExpressionIteratorTest [camel]
github-actions[bot] commented on PR #11754: URL: https://github.com/apache/camel/pull/11754#issuecomment-1768077704 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
