Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]
Croway commented on PR #1042: URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854077246 oh yeah, makes sense, so that documentation is updated. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]
davsclaus commented on PR #1042: URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854066102 yes but isnt there a default algorithm in jasypt itself. And if it has a default then it can also be set in that field, then SB and tooling know what the default value is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]
Croway commented on PR #1042: URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854015946 > okay had to do a few small changes - this -starter is somewhat special. It does some weird custom binder stuff, that should not be needed, but do it more normal spring boot way. Interesting, I am sorry I thought it was an easy change, but doesn't `private String randomIvGeneratorAlgorithm;` resolve to null if not set? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]
davsclaus commented on PR #1042: URL: https://github.com/apache/camel-spring-boot/pull/1042#issuecomment-1854012033 okay had to do a few small changes - this -starter is somewhat special. It does some weird custom binder stuff, that should not be needed, but do it more normal spring boot way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20231: make generators configurable [camel-spring-boot]
davsclaus merged PR #1042: URL: https://github.com/apache/camel-spring-boot/pull/1042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20231: make generators configurable [camel]
Croway merged PR #12440: URL: https://github.com/apache/camel/pull/12440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] CAMEL-20231: make generators configurable [camel]
Croway opened a new pull request, #12440: URL: https://github.com/apache/camel/pull/12440 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20231: make generators configurable [camel]
github-actions[bot] commented on PR #12440: URL: https://github.com/apache/camel/pull/12440#issuecomment-1853712347 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
