Re: [PR] CAMEL-20754: Support for MQTT 5 Publish Properties [camel]
hsudbrock commented on PR #14175: URL: https://github.com/apache/camel/pull/14175#issuecomment-2128042115 Thanks for the fast review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20754: Support for MQTT 5 Publish Properties [camel]
davsclaus merged PR #14175: URL: https://github.com/apache/camel/pull/14175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20754: Support for MQTT 5 Publish Properties [camel]
github-actions[bot] commented on PR #14175: URL: https://github.com/apache/camel/pull/14175#issuecomment-2117073568 :robot: The Apache Camel test robot will run the tests for you :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20754: Support for MQTT 5 Publish Properties [camel]
oscerd commented on PR #14175: URL: https://github.com/apache/camel/pull/14175#issuecomment-2117072859 /component-test paho-mqtt5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20754: Support for MQTT 5 Publish Properties [camel]
github-actions[bot] commented on PR #14175: URL: https://github.com/apache/camel/pull/14175#issuecomment-2117043363 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] CAMEL-20754: Support for MQTT 5 Publish Properties [camel]
hsudbrock opened a new pull request, #14175: URL: https://github.com/apache/camel/pull/14175 # Description This PR adds support for the MQTT message headers introduced with MQTT 5 (like, e.g., content-type, response-topic, message-expiry-interval, or user properties; cf. section 3.3.2.3 of the [MQTT 5 spec](https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html)) to the Paho-MQTT5 component. To this end, support for a single new Camel message header, `CamelPahoMqtt5MsgProperties`, is added; the header is filled with an object containing the MQTT message headers when consuming a MQTT message, and the contents of the header are used to set the MQTT message headers when publishing a MQTT message. # Notes The PR adds a single Camel message header for all MQTT message headers (using the `MqttProperties` class from the underlying Eclipse Paho library). An alternative would be to add multiple Camel message headers for the various MQTT message headers (e.g., one for the content-type, one for the response-topic, one for the message-expiry-interval, etc.). I prefer the simpler variant with a single Camel message header, but am open for the solution with multiple Camel message headers if that is the more "Camel-esque" way to go. # Target - [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [X] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [X] I checked that each commit in the pull request has a meaningful subject line and body. - [X] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
