Re: [PR] CAMEL-20846: Add capability to configure elasticsearch-rest-client with component options [camel]
davsclaus merged PR #14446: URL: https://github.com/apache/camel/pull/14446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20846: Add capability to configure elasticsearch-rest-client with component options [camel]
jamesnetherton commented on code in PR #14446:
URL: https://github.com/apache/camel/pull/14446#discussion_r1633344909
##
components/camel-elasticsearch-rest-client/src/main/java/org/apache/camel/component/elasticsearch/rest/client/ElasticsearchRestClientComponent.java:
##
@@ -19,18 +19,162 @@
import java.util.Map;
import org.apache.camel.Endpoint;
+import org.apache.camel.spi.Metadata;
import org.apache.camel.spi.annotations.Component;
import org.apache.camel.support.DefaultComponent;
+import org.elasticsearch.client.RestClient;
@Component("elasticsearch-rest-client")
public class ElasticsearchRestClientComponent extends DefaultComponent {
+@Metadata(autowired = true)
Review Comment:
Thanks for catching it. It's updated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CAMEL-20846: Add capability to configure elasticsearch-rest-client with component options [camel]
davsclaus commented on code in PR #14446:
URL: https://github.com/apache/camel/pull/14446#discussion_r162466
##
components/camel-elasticsearch-rest-client/src/main/java/org/apache/camel/component/elasticsearch/rest/client/ElasticsearchRestClientComponent.java:
##
@@ -19,18 +19,162 @@
import java.util.Map;
import org.apache.camel.Endpoint;
+import org.apache.camel.spi.Metadata;
import org.apache.camel.spi.annotations.Component;
import org.apache.camel.support.DefaultComponent;
+import org.elasticsearch.client.RestClient;
@Component("elasticsearch-rest-client")
public class ElasticsearchRestClientComponent extends DefaultComponent {
+@Metadata(autowired = true)
Review Comment:
label = advanced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] CAMEL-20846: Add capability to configure elasticsearch-rest-client with component options [camel]
jamesnetherton opened a new pull request, #14446: URL: https://github.com/apache/camel/pull/14446 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CAMEL-20846: Add capability to configure elasticsearch-rest-client with component options [camel]
github-actions[bot] commented on PR #14446: URL: https://github.com/apache/camel/pull/14446#issuecomment-2158380952 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
