Re: [PR] Camel 20381 annotate eip exchange properties [camel]

2024-02-19 Thread via GitHub


jono-morris commented on PR #13186:
URL: https://github.com/apache/camel/pull/13186#issuecomment-1953448142

   Hey np, I learnt a few things in the process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Camel 20381 annotate eip exchange properties [camel]

2024-02-19 Thread via GitHub


jono-morris closed pull request #13186: Camel 20381 annotate eip exchange 
properties
URL: https://github.com/apache/camel/pull/13186


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Camel 20381 annotate eip exchange properties [camel]

2024-02-19 Thread via GitHub


davsclaus commented on PR #13186:
URL: https://github.com/apache/camel/pull/13186#issuecomment-1952353734

   Yeah I am in the middle of it today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Camel 20381 annotate eip exchange properties [camel]

2024-02-19 Thread via GitHub


jono-morris commented on PR #13186:
URL: https://github.com/apache/camel/pull/13186#issuecomment-1952328724

   Hey @davsclaus I started looking at CAMEL-20381 but I see you've self 
assigned the ticket.  Should I leave it and look at something else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Camel 20381 annotate eip exchange properties [camel]

2024-02-19 Thread via GitHub


github-actions[bot] commented on PR #13186:
URL: https://github.com/apache/camel/pull/13186#issuecomment-1952323033

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Camel 20381 annotate eip exchange properties [camel]

2024-02-19 Thread via GitHub


jono-morris opened a new pull request, #13186:
URL: https://github.com/apache/camel/pull/13186

   # Description
   
   
   
   Write constants used by Eips, e.g. LOOP_INDEX, to model json files for 
inclusion to the camel catalog. 
   
   Example generated for Loop eip constants, LOOP_INDEX and LOOP_SIZE.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   
   
   - [x] I have run `mvn clean install -DskipTests` locally and I have 
committed all auto-generated changes
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org