Re: [PR] Make EndpointRegistry extends Map [camel]
gnodet merged PR #14066: URL: https://github.com/apache/camel/pull/14066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make EndpointRegistry extends Map [camel]
davsclaus commented on PR #14066: URL: https://github.com/apache/camel/pull/14066#issuecomment-2109655641 org.apache.camel.issues.RecipientListUseOriginalMessageEndpointExceptionIssueTest.testRecipientListUseOriginalMessageIssue | 1.822s | FAILURE -- | -- | -- org.apache.camel.builder.xml.XPathTest.testXPathSplitConcurrent | 1.763s | FAILURE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make EndpointRegistry extends Map [camel]
davsclaus commented on PR #14066: URL: https://github.com/apache/camel/pull/14066#issuecomment-2109485183 > > this PR needs to fix in the components as commented above > > In theory yes, in practice, no component is affected. The reason is that the `K` generic type in the `EnpointRegistry` is only used on `keySet()` and `entrySet()` methods, which are not used, and components, when they need to access the registry do so without using an intermediate variable which could cause a cast compilation error. > > I'm actually wondering if that parameter is needed at all, and while we're changing this method, it may be simpler to just make `EndpointRegistry` non parameterised and extends `Map`. @davsclaus thoughts ? Yes that is better as we dont need other kind of parameters at all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
