Re: [PR] Refactor kustomize experiment [camel-k]

2024-02-19 Thread via GitHub


gansheer closed pull request #4839: Refactor kustomize experiment
URL: https://github.com/apache/camel-k/pull/4839


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Refactor kustomize experiment [camel-k]

2024-02-07 Thread via GitHub


github-actions[bot] commented on PR #4839:
URL: https://github.com/apache/camel-k/pull/4839#issuecomment-1933156158

   This PR has been automatically marked as stale due to 90 days of inactivity.
   It will be closed if no further activity occurs within 15 days.
   If you think that’s incorrect or the issue should never stale, please simply 
write any comment.
   Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Refactor kustomize experiment [camel-k]

2023-10-23 Thread via GitHub


gansheer commented on code in PR #4839:
URL: https://github.com/apache/camel-k/pull/4839#discussion_r1368329104


##
install/overlays/kubernetes/README.md:
##
@@ -0,0 +1,50 @@
+# Kubernetes overlay
+
+## Pre-requise
+
+This is an overlay intended for Minkube with the following configuration:
+* Cluster-admin privileges are required
+* Namespace is `default`
+* Operator id is `camel-k`
+* An available registry
+
+## Usage
+
+The following env variable are expected
+
+
+To run from local folder :
+```sh
+kubectl kustomize kustomize/overlays/kubernetes | kubectl create -f -
+```
+
+To run from remote github repository:
+```sh
+kubectl kustomize 
https://github.com/apache/camel-k/kustomize/overlays/kubernetes | kubectl 
create -f -
+```
+
+NOTE: to use a different branch add the parameter "ref" to the github 
repository URL.
+
+
+### Minikube
+
+You can easilly configure minikube with the registry addon.
+
+First get the internal registry service IP from minikube :
+
+```sh
+export KAMEL_REGISTRY_ADDRESS="$(kubectl get service --selector 
"kubernetes.io/minikube-addons"="registry" --namespace kube-system 
-o=jsonpath='{.items[0].spec.clusterIP}')"

Review Comment:
   Thanks, I will check this. This explains the "placeholder" namespace value I 
saw in the files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Refactor kustomize experiment [camel-k]

2023-10-23 Thread via GitHub


squakez commented on code in PR #4839:
URL: https://github.com/apache/camel-k/pull/4839#discussion_r1368272333


##
install/overlays/README.md:
##
@@ -0,0 +1,98 @@
+
+# Kustomize Camel K
+
+Kustomize provides a declarative approach to the configuration customization 
of a Camel-K installation. Kustomize works either with a standalone executable 
or as a built-in to kubectl.
+
+Basic overlays are provided for easy usage.
+
+## HOW-TO
+
+### Initialize
+
+First create a new kustomization from the wanted version (kubernetes or 
openshift) in the repository:
+```sh
+kustomize create --resources 
https://github.com/apache/camel-k.git/install/overlays/kubernetes\?ref\=exp/kustomize_structure
+```
+
+You can also clone the camel-k repository and reference the local folder :
+```sh
+kubectl kustomize https://github.com/apache/camel-k.git/install/overlays/kubernetes\?ref\=exp/kustomize_structure

Review Comment:
   IMO, this one should be a separate chapter for user customization. We should 
not require anything but `kubectl` for a immediate user experiente. We miss a 
quickstart where the user run something like: `  # Build from github
 kubectl kustomize 
https://github.com/kubernetes-sigs/kustomize.git/examples/helloWorld?ref=v1.0.6 
| kubectl create -f` where, if it's the case the use can choose between 
Kubernetes and Openshift, withouth knowing anything about overlays. What I mean 
is that we provide 2 procedures:
* Kubernetes installation: `kubectl kustomize 
https://github.com/apache/camel-k.git/install/overlays/kubernetes | kubectl 
create -f` 
*  Openshift installation: `kubectl kustomize 
https://github.com/apache/camel-k.git/install/overlays/openshift | kubectl 
create -f` 



##
install/overlays/kubernetes/README.md:
##
@@ -0,0 +1,50 @@
+# Kubernetes overlay
+
+## Pre-requise
+
+This is an overlay intended for Minkube with the following configuration:
+* Cluster-admin privileges are required
+* Namespace is `default`
+* Operator id is `camel-k`
+* An available registry
+
+## Usage
+
+The following env variable are expected
+
+
+To run from local folder :
+```sh
+kubectl kustomize kustomize/overlays/kubernetes | kubectl create -f -
+```
+
+To run from remote github repository:
+```sh
+kubectl kustomize 
https://github.com/apache/camel-k/kustomize/overlays/kubernetes | kubectl 
create -f -

Review Comment:
   With all examples, we should specify the ref in order to point to the latest 
released version. We need to update the release script in order to update the 
documentation when we release (could be a follow up issue though).



##
install/overlays/kubernetes/README.md:
##
@@ -0,0 +1,50 @@
+# Kubernetes overlay
+
+## Pre-requise
+
+This is an overlay intended for Minkube with the following configuration:
+* Cluster-admin privileges are required
+* Namespace is `default`
+* Operator id is `camel-k`
+* An available registry
+
+## Usage
+
+The following env variable are expected
+
+
+To run from local folder :
+```sh
+kubectl kustomize kustomize/overlays/kubernetes | kubectl create -f -
+```
+
+To run from remote github repository:
+```sh
+kubectl kustomize 
https://github.com/apache/camel-k/kustomize/overlays/kubernetes | kubectl 
create -f -
+```
+
+NOTE: to use a different branch add the parameter "ref" to the github 
repository URL.

Review Comment:
   put an example like 
`https://github.com/apache/camel-k/kustomize/overlays/kubernetes?ref=main`



##
install/overlays/kubernetes/README.md:
##
@@ -0,0 +1,50 @@
+# Kubernetes overlay
+
+## Pre-requise
+
+This is an overlay intended for Minkube with the following configuration:
+* Cluster-admin privileges are required
+* Namespace is `default`
+* Operator id is `camel-k`
+* An available registry
+
+## Usage
+
+The following env variable are expected
+
+
+To run from local folder :
+```sh
+kubectl kustomize kustomize/overlays/kubernetes | kubectl create -f -
+```
+
+To run from remote github repository:
+```sh
+kubectl kustomize 
https://github.com/apache/camel-k/kustomize/overlays/kubernetes | kubectl 
create -f -
+```
+
+NOTE: to use a different branch add the parameter "ref" to the github 
repository URL.
+
+
+### Minikube
+
+You can easilly configure minikube with the registry addon.

Review Comment:
   We miss the instruction to enable the addon on the minikube.



##
install/overlays/README.md:
##
@@ -0,0 +1,98 @@
+
+# Kustomize Camel K
+
+Kustomize provides a declarative approach to the configuration customization 
of a Camel-K installation. Kustomize works either with a standalone executable 
or as a built-in to kubectl.
+
+Basic overlays are provided for easy usage.
+
+## HOW-TO
+
+### Initialize
+
+First create a new kustomization from the wanted version (kubernetes or 
openshift) in the repository:
+```sh
+kustomize create --resources 
https://github.com/apache/camel-k.git/install/overlays/kubernetes\?ref\=exp/kustomize_structure
+```
+
+You can also c

Re: [PR] Refactor kustomize experiment [camel-k]

2023-10-20 Thread via GitHub


gansheer commented on PR #4839:
URL: https://github.com/apache/camel-k/pull/4839#issuecomment-177207

   @squakez @oscerd could one of you run trigger the e2e tests please :pray: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Refactor kustomize experiment [camel-k]

2023-10-20 Thread via GitHub


gansheer opened a new pull request, #4839:
URL: https://github.com/apache/camel-k/pull/4839

   This is an experiment to refactor and simplify kustomize installations. 
   
   I am creating this PR to check what is the impact of the removals of code.
   
   Don't hesitate to give your feedback but keep in mind this is very much a 
work in progress :smile_cat: .
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org