Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
cziesman commented on PR #14063: URL: https://github.com/apache/camel/pull/14063#issuecomment-2113712130 @davsclaus How are other components that are not built in specific environments excluded from the tooling? I ran this again on OSX on Intel and ARM, and the build passed. I ran it on Fedora 38 on ARM and it failed trying to build `camel-endpointdsl`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
cziesman commented on PR #14063: URL: https://github.com/apache/camel/pull/14063#issuecomment-2104705639 @davsclaus That's very odd. I ran the build on my x86 MacBook and the Salesforce artifacts were generated. I wouldn't have submitted the PR otherwise. I am on PTO through Tuesday but I will revisit this when I return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
davsclaus commented on PR #14063: URL: https://github.com/apache/camel/pull/14063#issuecomment-2104066472 @cziesman this PR did not work - it causes a normal build on osx and other systems to somehow skip salesforce also and affects the total build with missing files in catalog from salesforce etc. Reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
davsclaus merged PR #14063: URL: https://github.com/apache/camel/pull/14063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
cziesman commented on PR #14063: URL: https://github.com/apache/camel/pull/14063#issuecomment-2098714217 @gnodet This does currently fail at build time, as was noted in Jira (https://issues.apache.org/jira/browse/CAMEL-20706): Protobuf compilation fails on Windows 11 on ARM because there is no protoc executable available for ARM. ``` Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile (default) on project camel-salesforce: Unable to resolve artifact: Missing: [ERROR] -- [ERROR] 1) com.google.protobuf:protoc:exe:windows-aarch_64:3.25.3 [ERROR] 1 required artifact is missing. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
gnodet commented on PR #14063: URL: https://github.com/apache/camel/pull/14063#issuecomment-2097464874 @cziesman why the fact that there's no native library breaks the build ? It should at most break when running tests, but the native library isn't really used at build time, is it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updated pom to skip build on Windows running on ARM [camel]
github-actions[bot] commented on PR #14063: URL: https://github.com/apache/camel/pull/14063#issuecomment-209703 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Updated pom to skip build on Windows running on ARM [camel]
cziesman opened a new pull request, #14063: URL: https://github.com/apache/camel/pull/14063 # Description The `camel-salesforce` component cannot build on Windows running on ARM because there is no gRPC library available. In order to build successfully on Windows/ARM, this PR disables the build on that environment. In general, adding profiles is discouraged, but since there is no way to disable a module via properties, adding profiles to the `camel-salesforce` parent pom was the only way to make this work. # Target - [ x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [ x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [ x] I checked that each commit in the pull request has a meaningful subject line and body. - [ x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes `mvn clean install -DskipTests` fails on Windows/ARM due to an error when building the documentation. That error probably requires a separate JIRA issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
