Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
squakez merged PR #5224: URL: https://github.com/apache/camel-k/pull/5224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
squakez commented on PR #5224: URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1983530891 > @lburgazzoli @squakez I added a comment to the bug with the scenarios that I tested after the changes: [#5223 (comment)](https://github.com/apache/camel-k/issues/5223#issuecomment-1981524817) Thanks I saw it. Checking with @lburgazzoli if he see some possible incompatibility I don't see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
lsergio commented on PR #5224: URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1983513027 @lburgazzoli @squakez I added a comment to the bug with the scenarios that I tested after the changes: https://github.com/apache/camel-k/issues/5223#issuecomment-1981524817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
squakez commented on PR #5224: URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1983468741 @lburgazzoli do you think this is breaking API compatibility by any chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
lsergio commented on PR #5224: URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1981323103 I see that in v2.2.0 the 25 default value is set at the crd (https://github.com/apache/camel-k/blob/v2.2.0/helm/camel-k/crds/crd-integration.yaml#L6755). It was supposed to mean 25% but it really means 25. However, the main branch does not have such a value (https://github.com/apache/camel-k/blob/main/helm/camel-k/crds/crd-integration.yaml#L6755) an thus delegate the default values to Kubernetes. So I think the wrong default value of 25 instead of 25% is no longer an issue and this PR would fix only the datatype in order to allow the users to inform percentage values on the trait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
lsergio commented on PR #5224: URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1981040120 So far I have onlu changed datatypes; still need to check where the code is using 25 and not 25% as default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
lsergio opened a new pull request, #5224: URL: https://github.com/apache/camel-k/pull/5224 closes #5218 **Release Note** ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
