Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
lburgazzoli commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2058650301 This is a draft implementation of [CAMEL-20675](https://issues.apache.org/jira/browse/CAMEL-20675), for the code POV, I think it is pretty ready, but I don't know how to deal with the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
davsclaus commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2058710785 Today I think there are not much docs, the only thing is those tables with all the SB starter options. And with this PR those for cluster/cloud is moved out. I guess if you add src/main/docs and add adoc for those new starters then they ought to show up in the website, but that is something we can look at after the code changes. What about Quarkus should its stuff also be moved out, or we dont have this kind for CEQ today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
davsclaus commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2058712452 How do we keep those json files up to date, if you do a change in the java file, then the json file is updated also ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
Croway commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2058717078 > This is a draft implementation of [CAMEL-20675](https://issues.apache.org/jira/browse/CAMEL-20675), for the code POV, I think it is pretty ready, but I don't know how to deal with the documentation. Hi @lburgazzoli regarding documentation, we may mention it in the release notes, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
lburgazzoli commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2059024231 > Today I think there are not much docs, the only thing is those tables with all the SB starter options. And with this PR those for cluster/cloud is moved out. > Yeas I was mainly trying to find out how to include such properties somewhere > I guess if you add src/main/docs and add adoc for those new starters then they ought to show up in the website, but that is something we can look at after the code changes. > +1 > What about Quarkus should its stuff also be moved out, or we dont have this kind for CEQ today. For Quarkus I did it already (as today the only have support for kubernetes and file cluster service) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
lburgazzoli commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2059025028 > > This is a draft implementation of [CAMEL-20675](https://issues.apache.org/jira/browse/CAMEL-20675), for the code POV, I think it is pretty ready, but I don't know how to deal with the documentation. > > Hi @lburgazzoli regarding documentation, we may mention it in the release notes, wdyt? Definitively -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
lburgazzoli commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2059026010 > How do we keep those json files up to date, if you do a change in the java file, then the json file is updated also ? Yes they are, those json have been auto generated bu some of the maven/camel/sb plugins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
davsclaus commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2060523460 Need to update the 4.6 upgrade guide doc with this change (in core project) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
lburgazzoli commented on PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130#issuecomment-2060566136 > Need to update the 4.6 upgrade guide doc with this change (in core project) https://github.com/apache/camel/pull/13830, let me know if you want to expand it more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CAMEL-20675] move cluster service implementations to dedicated starters [camel-spring-boot]
lburgazzoli merged PR #1130: URL: https://github.com/apache/camel-spring-boot/pull/1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
