Re: [PR] Add support for KUBECONFIG with multiple files [camel-k]

2024-01-26 Thread via GitHub


squakez commented on PR #5105:
URL: https://github.com/apache/camel-k/pull/5105#issuecomment-1912120238

   > > Mind that we're planning to move the entire CLI to Camel Jbang [2], so, 
any work done in the CLI, may be disappearing during 2024.
   > 
   > The plan is to move the CLI portion but not the operator if I understand 
correctly?
   
   Yes, just the CLI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for KUBECONFIG with multiple files [camel-k]

2024-01-26 Thread via GitHub


squakez commented on PR #5105:
URL: https://github.com/apache/camel-k/pull/5105#issuecomment-1912119860

   No problem. Thanks for taking the time to make the development though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for KUBECONFIG with multiple files [camel-k]

2024-01-26 Thread via GitHub


rodcloutier closed pull request #5105: Add support for KUBECONFIG with multiple 
files
URL: https://github.com/apache/camel-k/pull/5105


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for KUBECONFIG with multiple files [camel-k]

2024-01-26 Thread via GitHub


rodcloutier commented on PR #5105:
URL: https://github.com/apache/camel-k/pull/5105#issuecomment-1912092826

   I went a little deeper in the whole usage of the kubeconfig file and we 
would need to revise the way it is handled. Some shortcuts were taken an do not 
exactly follow the kubernetes way to implement a client. 
   
   Given that there is a migration planned, we can drop this PR as the 
workaround is not that difficult (was more a quality of life issue).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for KUBECONFIG with multiple files [camel-k]

2024-01-26 Thread via GitHub


rodcloutier commented on PR #5105:
URL: https://github.com/apache/camel-k/pull/5105#issuecomment-1912082391

   > Mind that we're planning to move the entire CLI to Camel Jbang [2], so, 
any work done in the CLI, may be disappearing during 2024.
   The plan is to move the CLI portion but not the operator if I understand 
correctly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add support for KUBECONFIG with multiple files [camel-k]

2024-01-26 Thread via GitHub


rodcloutier commented on PR #5105:
URL: https://github.com/apache/camel-k/pull/5105#issuecomment-1912073724

   > I haven't looked deeply at this, but it seems to me that we're completely 
ignoring the `kubeconfig` parameter. And it's used in the CLI for the
   > 
   > ```
   >   --kube-config string   Path to the kube config file to use for CLI 
requests
   > ```
   > 
   > feature.
   
   You are right. I forgot to keep the current functionality. I have updated 
the commit to add support for the argument as well and keep the current 
functionality. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org