Re: [PR] CAMEL-20388: camel-salesforce - Invoke client.disconnect() when recei… [camel]

[via GitHub]

davsclaus merged PR #13725:
URL: https://github.com/apache/camel/pull/13725


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] CAMEL-20388: camel-salesforce - Invoke client.disconnect() when recei… [camel]

[via GitHub]

davsclaus commented on code in PR #13725:
URL: https://github.com/apache/camel/pull/13725#discussion_r1562603563


##
components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/streaming/SubscriptionHelper.java:
##
@@ -165,6 +165,7 @@ public void onMessage(ClientSessionChannel channel, Message 
message) {
 LOG.warn("Connect failure: {}", message);
 connectError = (String) message.get(ERROR_FIELD);
 connectException = getFailure(message);
+client.disconnect();

Review Comment:
   Should this be in a try .. catch and ignore (I wonder if disconnect can 
throw an exception)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] CAMEL-20388: camel-salesforce - Invoke client.disconnect() when recei… [camel]

[via GitHub]

github-actions[bot] commented on PR #13725:
URL: https://github.com/apache/camel/pull/13725#issuecomment-2044557485

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org