Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
jamesnetherton merged PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
jamesnetherton commented on PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206#issuecomment-2042445232 > I have committed all the changes, why are checks failing now?@jamesnetherton From the project root try running `./mvnw-for-each clean install -DskipTests` then commit & push any changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
spatnity commented on PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206#issuecomment-2042441013 I have committed all the changes, why are checks failing now?@jamesnetherton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
jamesnetherton commented on code in PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206#discussion_r1555289197 ## vertx-websocket-chat/README.adoc: ## @@ -0,0 +1,56 @@ += Vertx-Websocket Chat: A Camel Quarkus example +:cq-example-description: Demonstration of how to configure a WebSocket server and interact with connected peers. Review Comment: Seems the cq-maven-plugin wants to enforce a specific description style and checks for a particular [prefix](https://github.com/l2x6/cq-maven-plugin/blob/main/maven-plugin/src/main/java/org/l2x6/cq/maven/UpdateExamplesJsonMojo.java#L50). If you modify things like the following, it'll hopefully work ok. ```suggestion :cq-example-description: An example that shows how to configure a WebSocket server and interact with connected peers. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
spatnity commented on code in PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206#discussion_r1553734407 ## vertx-websocket-chat/pom.xml: ## @@ -0,0 +1,312 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + +camel-quarkus-examples-vertx-websocket-chat +org.apache.camel.quarkus.examples +3.9.0 Review Comment: Yeah followed the same, I think I refered to one of the examples of main branch's pom instead of camel-quarkus-main:( I'll correct it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
spatnity commented on code in PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206#discussion_r1553734407 ## vertx-websocket-chat/pom.xml: ## @@ -0,0 +1,312 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + +camel-quarkus-examples-vertx-websocket-chat +org.apache.camel.quarkus.examples +3.9.0 Review Comment: Yeah followed the same, I think I refered to tone of the examples of main branch's pom instead of camel-quarkus-main:( I'll correct it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
spatnity commented on code in PR #206: URL: https://github.com/apache/camel-quarkus-examples/pull/206#discussion_r1553734407 ## vertx-websocket-chat/pom.xml: ## @@ -0,0 +1,312 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + +camel-quarkus-examples-vertx-websocket-chat +org.apache.camel.quarkus.examples +3.9.0 Review Comment: Yeah followed the same, I think I refered to the main branch instead of camel-quarkus-main:( I'll correct it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create an example project for vertx-websocket #5111 [camel-quarkus-examples]
jamesnetherton commented on code in PR #206:
URL:
https://github.com/apache/camel-quarkus-examples/pull/206#discussion_r1553713073
##
vertx-websocket-chat/pom.xml:
##
@@ -0,0 +1,312 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+camel-quarkus-examples-vertx-websocket-chat
+org.apache.camel.quarkus.examples
+3.9.0
Review Comment:
I would copy this pom.xml and add adjust it for what you need:
https://github.com/apache/camel-quarkus-examples/blob/camel-quarkus-main/timer-log/pom.xml
That way the project version and the BOM groupId / artifactId will be set up
correctly.
##
vertx-websocket-chat/pom.xml:
##
@@ -0,0 +1,312 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+camel-quarkus-examples-vertx-websocket-chat
+org.apache.camel.quarkus.examples
+3.9.0
+
+Camel Quarkus :: Examples :: Vertx-Websocket chat
+Camel Quarkus Example ::Implementing Websocket
+
+
+3.9.1
+
${quarkus.platform.version}
+
+
+3.9.0
+
+
io.quarkus.platform
+
quarkus-bom
+
${quarkus.platform.group-id}
+
quarkus-camel-bom
+
+UTF-8
+
UTF-8
+17
+17
+
${maven.compiler.target}
+
${maven.compiler.source}
+
+2.23.0
+1.9.0
+4.2
+3.11.0
+3.3.0
+3.3.1
+3.1.2
+
+
${project.build.directory}/quarkus-app/quarkus-run.jar
+
+
+
+
+
+
+${quarkus.platform.group-id}
+${quarkus.platform.artifact-id}
+${quarkus.platform.version}
+pom
+import
+
+
+${camel-quarkus.platform.group-id}
+${camel-quarkus.platform.artifact-id}
+${camel-quarkus.platform.version}
+pom
+import
+
+
+org.apache.camel.quarkus
+camel-quarkus-bom-test
+${camel-quarkus.version}
+pom
+import
+
+
+
+
+
+
+org.apache.camel.quarkus
+camel-quarkus-bean
+
+
+org.apache.camel.quarkus
+camel-quarkus-jackson
+
+
+org.apache.camel.quarkus
+camel-quarkus-vertx-websocket
+
+
+org.apache.camel.quarkus
+camel-quarkus-direct
+
+
+org.apache.camel.quarkus
+camel-quarkus-rest
+
+
+io.quarkus
+quarkus-arc
+
+
+
+
+io.quarkus
+quarkus-junit5
+test
+
+
+
+
+
+
+
+
+net.revelc.code.formatter
+formatter-maven-plugin
+${formatter-maven-plugin.version}
+
+
${maven.multiModuleProjectDirectory}/eclipse-formatter-config.xml
Review Comment:
You'll need to add the `eclipse-formatter-config.xml` to this project. You
can copy it from one of the other examples.
##
vertx-websocket-chat/README.md:
##
@@ -0,0 +1,57 @@
+= Vertx-Websocket Chat: A Camel Quarkus example
+:cq-example-description: Demonstration of how to configure a WebSocket server
and interact with connected peers.
+
+{cq-description}
+
+TIP: Check the
https://camel.apache.org/camel-quarkus/latest/first-steps.html[Camel Quarkus
User guide] for prerequisites
+and other general information.
+
+== Start in the Development mode
+
+You can run your application in dev mode that enables live coding using:
+
+[source,shell]
+
+$ mvn compile quarkus:dev
+
+
+The above command compiles the project, starts the application and lets the
Quarkus tooling watch for changes in your
+workspace. Any modifications in your project will automatically take effect in
the running application.You can find the application running
http://localhost:8080
+
+
+TIP: Please refer to the Development mode section of
+https://camel.apache.org/camel-quarkus/latest/first-steps.html#_development_mode[Camel
Quarkus User guide] for more details.
+
+As we run the example in Quarkus Dev Mode, you can connect to the websocket by
providing a username.Once you connect, you can see a chat room where you can
send/receive messages to a specific peer or all the peers connected.
+
+=== Package and run the application
+
+Once you are done with developing you may want to package and run the
