Re: [PR] Use xml-io-dsl instead of xml-jaxb when using the management extension [camel-quarkus]

[via GitHub]

jamesnetherton merged PR #6002:
URL: https://github.com/apache/camel-quarkus/pull/6002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use `xml-io-dsl` instead of `xml-jaxb` when using the `management` extension. [camel-quarkus]

[via GitHub]

jamesnetherton closed pull request #5983: Use `xml-io-dsl` instead of 
`xml-jaxb` when using the `management` extension.
URL: https://github.com/apache/camel-quarkus/pull/5983


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use `xml-io-dsl` instead of `xml-jaxb` when using the `management` extension. [camel-quarkus]

[via GitHub]

jamesnetherton commented on PR #5983:
URL: https://github.com/apache/camel-quarkus/pull/5983#issuecomment-2058773459

   Thanks @ammachado. I reworked things a little in #6002.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use `xml-io-dsl` instead of `xml-jaxb` when using the `management` extension. [camel-quarkus]

[via GitHub]

ammachado commented on code in PR #5983:
URL: https://github.com/apache/camel-quarkus/pull/5983#discussion_r1555953289


##
test-framework/junit5/src/main/java/org/apache/camel/quarkus/test/CamelQuarkusTestSupport.java:
##
@@ -318,7 +318,7 @@ protected void doPreSetup() throws Exception {
 
 if (isUseRouteBuilder()) {
 //save the routeIds of routes existing before setup
-createdRoutes = context.getRoutes().stream().map(r -> 
r.getRouteId()).collect(Collectors.toSet());
+createdRoutes = 
context.getRoutes().stream().map(Route::getRouteId).collect(Collectors.toSet());

Review Comment:
   Reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use `xml-io-dsl` instead of `xml-jaxb` when using the `management` extension. [camel-quarkus]

[via GitHub]

jamesnetherton commented on code in PR #5983:
URL: https://github.com/apache/camel-quarkus/pull/5983#discussion_r1555946110


##
test-framework/junit5/src/main/java/org/apache/camel/quarkus/test/CamelQuarkusTestSupport.java:
##
@@ -318,7 +318,7 @@ protected void doPreSetup() throws Exception {
 
 if (isUseRouteBuilder()) {
 //save the routeIds of routes existing before setup
-createdRoutes = context.getRoutes().stream().map(r -> 
r.getRouteId()).collect(Collectors.toSet());
+createdRoutes = 
context.getRoutes().stream().map(Route::getRouteId).collect(Collectors.toSet());

Review Comment:
   Please add the `CamelQuarkusTestSupport` changes into a separate commit.
   
   Or drop them entirely if they're not required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org