Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
squakez merged PR #5445: URL: https://github.com/apache/camel-k/pull/5445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
claudio4j commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2109823593 > It is only when this field is explicitly set to True that Knative interferes through validation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
hernanDatgDev commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2101364571 I added the test to ensure that the field is set properly on the deployment. I also relayed with my security team and it we only need this field so that we can set it to false which does not interfere with Knative. It is only when this field is explicitly set to `True` that Knative interferes through validation. So for my team and this field specifically this PR would be enough. There are other fields that we'd like set however those do have issues with Knative so I'm working on getting conversations started with the Knative teams. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
hernanDatgDev closed pull request #5445: kind/feature/5395/expand pod template spec URL: https://github.com/apache/camel-k/pull/5445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
squakez commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2092495725 To consider if this is really ready to merge: https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/pod.20template.20fields.20interfere.20with.20knative -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
claudio4j commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2091236395 > To get the right functionality I ran make generate instead. Would it be appropriate to update this comment as well? Yes, thanks. Can you squash the commits once you have it ready for review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
hernanDatgDev commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2090684915 @claudio4j Thanks I found the right values. Also I noticed in `pkg/apis/camel/v1/integration_types.go` it has some outdated make goal. To get the right functionality I ran `make generate` instead. Would it be appropriate to update this comment as well? ``` Run "make generate-deepcopy" to regenerate code after modifying this file ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
claudio4j commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2089253858 You can follow the k8s api [podspec](https://github.com/kubernetes/api/blob/master/core/v1/types.go#L3668) and set `21` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kind/feature/5395/expand pod template spec [camel-k]
hernanDatgDev commented on PR #5445: URL: https://github.com/apache/camel-k/pull/5445#issuecomment-2089061284 Hi, I'm not sure what value should actually be added for the "protobuf" string in pkg/apis/camel/v1/integration_types.go. The value I gave was `protobuf:"varint,8,opt,name=automountServiceAccountToken"` taking inspiration from other boolean values however the `8` is just a guess. What's an appropriate value to add when introducing new fields? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
