[jira] [Commented] (CASSANDRA-4091) multiget_slice thrift interface always returns empty list in erlang
[ https://issues.apache.org/jira/browse/CASSANDRA-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253130#comment-13253130 ] Anthony Molinaro commented on CASSANDRA-4091: - FWIW, I can't reproduce this with apache-cassandra-1.0.8 and thrift HEAD, so good that this was resolved not an issue. It's not an issue in thrift as far as I am concerned. > multiget_slice thrift interface always returns empty list in erlang > --- > > Key: CASSANDRA-4091 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4091 > Project: Cassandra > Issue Type: Bug >Affects Versions: 1.0.6, 1.0.8 > Environment: OS: tried on os x lion and fedora 16 > thrift: 0.8.0 > cassandra: tried apache cassandra 1.0.6 and datastax 1.0.8 > erlang: R14B04 >Reporter: varnitk > > multiget_slice doesn't work in erlang and always returns an empty list, > however multiget_count does for the same set of keys. Sample code: > Keys = [<<"key1">>, <<"key2">>], > ColumnParent = #columnParent{column_family=ColumnFamily}, > > SliceRange = #sliceRange{start="", finish="", reversed=false, > count=2147483647}, > SlicePredicate = #slicePredicate{slice_range=SliceRange, > column_names=undefined}, > {ok, Conn} = thrift_client_util:new(Host, Port, cassandra_thrift, [{framed, > true}]), ok, > {Conn2, {ok, ok}} = thrift_client:call(Conn, set_keyspace, [Keyspace]), > {NewCon, Response} = thrift_client:call(Conn2, multiget_slice, [Keys, > ColumnParent, SlicePredicate, 1]), > Response: {ok, []} > Please fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: fixing the config name
Updated Branches: refs/heads/trunk f3d3b4394 -> 0501cdd39 fixing the config name Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0501cdd3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0501cdd3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0501cdd3 Branch: refs/heads/trunk Commit: 0501cdd391e2e37249ae131a47ca29e4f7b8f9ab Parents: f3d3b43 Author: Vijay Parthasarathy Authored: Thu Apr 12 21:16:35 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 21:17:24 2012 -0700 -- conf/cassandra.yaml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/0501cdd3/conf/cassandra.yaml -- diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 2f6a7da..14cc525 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -32,7 +32,7 @@ hinted_handoff_throttle_delay_in_ms: 1 # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only when the whole node's data fits in memory. # Defaults to: false -# populate_buffer_cache_on_flush: false +# populate_io_cache_on_flush: false # authentication backend, implementing IAuthenticator; used to identify users authenticator: org.apache.cassandra.auth.AllowAllAuthenticator
git commit: fixing the config name
Updated Branches: refs/heads/cassandra-1.1 20bd8281f -> 389e6cd72 fixing the config name Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/389e6cd7 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/389e6cd7 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/389e6cd7 Branch: refs/heads/cassandra-1.1 Commit: 389e6cd72407bbe92e9edf5e30115cc94bf005fa Parents: 20bd828 Author: Vijay Parthasarathy Authored: Thu Apr 12 21:16:35 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 21:16:35 2012 -0700 -- conf/cassandra.yaml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/389e6cd7/conf/cassandra.yaml -- diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 2f6a7da..14cc525 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -32,7 +32,7 @@ hinted_handoff_throttle_delay_in_ms: 1 # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only when the whole node's data fits in memory. # Defaults to: false -# populate_buffer_cache_on_flush: false +# populate_io_cache_on_flush: false # authentication backend, implementing IAuthenticator; used to identify users authenticator: org.apache.cassandra.auth.AllowAllAuthenticator
[jira] [Updated] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-2635: - Affects Version/s: (was: 1.2) Fix Version/s: 1.2 1.1.1 > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.1.1 >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Fix For: 1.1.1, 1.2 > > Attachments: 0001-CASSANDRA-2635-v3.patch, CASSANDRA-2635-075.txt, > CASSANDRA-2635-trunk-1.txt, CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-2635: - Affects Version/s: 1.2 1.1.1 > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.1.1, 1.2 >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: 0001-CASSANDRA-2635-v3.patch, CASSANDRA-2635-075.txt, > CASSANDRA-2635-trunk-1.txt, CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay resolved CASSANDRA-2635. -- Resolution: Fixed Reviewer: vijay2...@yahoo.com committed thanks! https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=f3d3b43940b53bb6a90411ffec96abdf20929618 > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Affects Versions: 1.1.1, 1.2 >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: 0001-CASSANDRA-2635-v3.patch, CASSANDRA-2635-075.txt, > CASSANDRA-2635-trunk-1.txt, CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: make cache skipping optional patch by harishd; reviewed by Vijay for CASSANDRA-2635
Updated Branches: refs/heads/trunk 8ab2473fe -> f3d3b4394 make cache skipping optional patch by harishd; reviewed by Vijay for CASSANDRA-2635 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f3d3b439 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f3d3b439 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f3d3b439 Branch: refs/heads/trunk Commit: f3d3b43940b53bb6a90411ffec96abdf20929618 Parents: 8ab2473 Author: Vijay Parthasarathy Authored: Thu Apr 12 20:54:47 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 20:58:52 2012 -0700 -- conf/cassandra.yaml|5 + src/java/org/apache/cassandra/config/Config.java |1 + .../cassandra/config/DatabaseDescriptor.java |7 +++ .../apache/cassandra/io/sstable/SSTableWriter.java |8 +--- 4 files changed, 18 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3d3b439/conf/cassandra.yaml -- diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 0d94b0b..2f6a7da 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -29,6 +29,11 @@ max_hint_window_in_ms: 360 # one hour # Sleep this long after delivering each hint hinted_handoff_throttle_delay_in_ms: 1 +# The following setting populates the page cache on memtable flush and compaction +# WARNING: Enable this setting only when the whole node's data fits in memory. +# Defaults to: false +# populate_buffer_cache_on_flush: false + # authentication backend, implementing IAuthenticator; used to identify users authenticator: org.apache.cassandra.auth.AllowAllAuthenticator http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3d3b439/src/java/org/apache/cassandra/config/Config.java -- diff --git a/src/java/org/apache/cassandra/config/Config.java b/src/java/org/apache/cassandra/config/Config.java index 151c620..52c1f96 100644 --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@ -133,6 +133,7 @@ public class Config public int row_cache_save_period = 0; public int row_cache_keys_to_save = Integer.MAX_VALUE; public String row_cache_provider = ConcurrentLinkedHashCacheProvider.class.getSimpleName(); +public boolean populate_io_cache_on_flush = false; private static boolean loadYaml = true; private static boolean outboundBindAny = false; http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3d3b439/src/java/org/apache/cassandra/config/DatabaseDescriptor.java -- diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index daae743..8816733 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -193,6 +193,8 @@ public class DatabaseDescriptor if (conf.disk_access_mode == Config.DiskAccessMode.mmap) MmappedSegmentedFile.initCleaner(); + logger.debug("page_cache_hinting is " + conf.populate_io_cache_on_flush); + /* Authentication and authorization backend, implementing IAuthenticator and IAuthority */ if (conf.authenticator != null) authenticator = FBUtilities.construct(conf.authenticator, "authenticator"); @@ -1055,4 +1057,9 @@ public class DatabaseDescriptor { return conf.streaming_socket_timeout_in_ms; } + +public static boolean populateIOCacheOnFlush() +{ +return conf.populate_io_cache_on_flush; +} } http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3d3b439/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java -- diff --git a/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java b/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java index 8f06f69..e46e407 100644 --- a/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java +++ b/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java @@ -88,14 +88,15 @@ public class SSTableWriter extends SSTable dbuilder = SegmentedFile.getCompressedBuilder(); dataFile = CompressedSequentialWriter.open(getFilename(), descriptor.filenameFor(Component.COMPRESSION_INFO), - true, + !DatabaseDescriptor.populateIOCacheOnFlush(),
git commit: make cache skipping optional patch by harishd; reviewed by Vijay for CASSANDRA-2635
Updated Branches: refs/heads/cassandra-1.1 c215a4c96 -> 20bd8281f make cache skipping optional patch by harishd; reviewed by Vijay for CASSANDRA-2635 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/20bd8281 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/20bd8281 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/20bd8281 Branch: refs/heads/cassandra-1.1 Commit: 20bd8281fab66852659201a76a9c525cdf64b710 Parents: c215a4c Author: Vijay Parthasarathy Authored: Thu Apr 12 20:54:47 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 20:54:47 2012 -0700 -- conf/cassandra.yaml|5 + src/java/org/apache/cassandra/config/Config.java |1 + .../cassandra/config/DatabaseDescriptor.java |7 +++ .../apache/cassandra/io/sstable/SSTableWriter.java |8 +--- 4 files changed, 18 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/20bd8281/conf/cassandra.yaml -- diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 0d94b0b..2f6a7da 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -29,6 +29,11 @@ max_hint_window_in_ms: 360 # one hour # Sleep this long after delivering each hint hinted_handoff_throttle_delay_in_ms: 1 +# The following setting populates the page cache on memtable flush and compaction +# WARNING: Enable this setting only when the whole node's data fits in memory. +# Defaults to: false +# populate_buffer_cache_on_flush: false + # authentication backend, implementing IAuthenticator; used to identify users authenticator: org.apache.cassandra.auth.AllowAllAuthenticator http://git-wip-us.apache.org/repos/asf/cassandra/blob/20bd8281/src/java/org/apache/cassandra/config/Config.java -- diff --git a/src/java/org/apache/cassandra/config/Config.java b/src/java/org/apache/cassandra/config/Config.java index 253594b..cb1847e 100644 --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@ -136,6 +136,7 @@ public class Config public int row_cache_save_period = 0; public int row_cache_keys_to_save = Integer.MAX_VALUE; public String row_cache_provider = ConcurrentLinkedHashCacheProvider.class.getSimpleName(); +public boolean populate_io_cache_on_flush = false; private static boolean loadYaml = true; private static boolean outboundBindAny = false; http://git-wip-us.apache.org/repos/asf/cassandra/blob/20bd8281/src/java/org/apache/cassandra/config/DatabaseDescriptor.java -- diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index e74ac13..b6a1d4e 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -194,6 +194,8 @@ public class DatabaseDescriptor if (conf.disk_access_mode == Config.DiskAccessMode.mmap) MmappedSegmentedFile.initCleaner(); + logger.debug("page_cache_hinting is " + conf.populate_io_cache_on_flush); + /* Authentication and authorization backend, implementing IAuthenticator and IAuthority */ if (conf.authenticator != null) authenticator = FBUtilities.construct(conf.authenticator, "authenticator"); @@ -1056,4 +1058,9 @@ public class DatabaseDescriptor { return conf.streaming_socket_timeout_in_ms; } + +public static boolean populateIOCacheOnFlush() +{ +return conf.populate_io_cache_on_flush; +} } http://git-wip-us.apache.org/repos/asf/cassandra/blob/20bd8281/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java -- diff --git a/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java b/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java index b1fcc79..d74514f 100644 --- a/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java +++ b/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java @@ -90,14 +90,15 @@ public class SSTableWriter extends SSTable dbuilder = SegmentedFile.getCompressedBuilder(); dataFile = CompressedSequentialWriter.open(getFilename(), descriptor.filenameFor(Component.COMPRESSION_INFO), - true, + !DatabaseDescriptor.populateIOCacheOnFlush(),
[jira] [Commented] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253083#comment-13253083 ] Harish Doddi commented on CASSANDRA-2635: - +1 jonathan... > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: 0001-CASSANDRA-2635-v3.patch, CASSANDRA-2635-075.txt, > CASSANDRA-2635-trunk-1.txt, CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4138) Add varint encoding to Serializing Cache
[ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-4138: - Attachment: 0001-CASSANDRA-4138-Take1.patch > Add varint encoding to Serializing Cache > > > Key: CASSANDRA-4138 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4138 > Project: Cassandra > Issue Type: Sub-task > Components: Core >Affects Versions: 1.2 >Reporter: Vijay >Assignee: Vijay >Priority: Minor > Fix For: 1.2 > > Attachments: 0001-CASSANDRA-4138-Take1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4138) Add varint encoding to Serializing Cache
[ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-4138: - Attachment: (was: 0001-CASSANDRA-4138-Take1.patch) > Add varint encoding to Serializing Cache > > > Key: CASSANDRA-4138 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4138 > Project: Cassandra > Issue Type: Sub-task > Components: Core >Affects Versions: 1.2 >Reporter: Vijay >Assignee: Vijay >Priority: Minor > Fix For: 1.2 > > Attachments: 0001-CASSANDRA-4138-Take1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253040#comment-13253040 ] Jonathan Ellis commented on CASSANDRA-2635: --- How does that look to you, Harish? > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: 0001-CASSANDRA-2635-v3.patch, CASSANDRA-2635-075.txt, > CASSANDRA-2635-trunk-1.txt, CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4138) Add varint encoding to Serializing Cache
[ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-4138: - Attachment: 0001-CASSANDRA-4138-Take1.patch Attached patch is the first attempt to add VarInt Encoding to cassandra. It save's us around 10% of the memory compared to normal DataInputStream. Once this gets committed i will work on the rest of the pieces. > Add varint encoding to Serializing Cache > > > Key: CASSANDRA-4138 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4138 > Project: Cassandra > Issue Type: Sub-task > Components: Core >Affects Versions: 1.2 >Reporter: Vijay >Assignee: Vijay >Priority: Minor > Fix For: 1.2 > > Attachments: 0001-CASSANDRA-4138-Take1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-4138) Add varint encoding to Serializing Cache
[ https://issues.apache.org/jira/browse/CASSANDRA-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253028#comment-13253028 ] Vijay edited comment on CASSANDRA-4138 at 4/13/12 1:04 AM: --- Attached patch is the first attempt to add VarInt Encoding to cassandra. It save's us around 10% of the memory compared to normal DataInputStream. (based on a simple test via Stress Tool) Once this gets committed i will work on the rest of the pieces. was (Author: vijay2...@yahoo.com): Attached patch is the first attempt to add VarInt Encoding to cassandra. It save's us around 10% of the memory compared to normal DataInputStream. Once this gets committed i will work on the rest of the pieces. > Add varint encoding to Serializing Cache > > > Key: CASSANDRA-4138 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4138 > Project: Cassandra > Issue Type: Sub-task > Components: Core >Affects Versions: 1.2 >Reporter: Vijay >Assignee: Vijay >Priority: Minor > Fix For: 1.2 > > Attachments: 0001-CASSANDRA-4138-Take1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-4144) Pig: Composite column support for row key
Pig: Composite column support for row key - Key: CASSANDRA-4144 URL: https://issues.apache.org/jira/browse/CASSANDRA-4144 Project: Cassandra Issue Type: Improvement Components: Contrib Affects Versions: 1.0.9 Reporter: janwar dinata Priority: Minor Currently Pig only understands composite columns not composite row keys. Support for querying column family that has composite type for its key_validation_class will be nice. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4094) MS.getCommandPendingTasks returns a double
[ https://issues.apache.org/jira/browse/CASSANDRA-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams resolved CASSANDRA-4094. - Resolution: Not A Problem Not sure what I was looking at when I made this. > MS.getCommandPendingTasks returns a double > -- > > Key: CASSANDRA-4094 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4094 > Project: Cassandra > Issue Type: Improvement >Reporter: Brandon Williams >Priority: Trivial > Labels: lhf > Fix For: 1.2 > > > This makes no sense, since you can't have a partial task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-2635: - Attachment: 0001-CASSANDRA-2635-v3.patch Attached patch includes jonathan's feedback with some renames. I am still wondering how i missed that :/ > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: 0001-CASSANDRA-2635-v3.patch, CASSANDRA-2635-075.txt, > CASSANDRA-2635-trunk-1.txt, CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252793#comment-13252793 ] Jonathan Ellis commented on CASSANDRA-2635: --- Skimming this it looks like this turns off the cache hints for the read side as well as for writes. I don't see any benefit to disabling it for reads -- if there's nothing to evict the data, it won't get evicted even with the dontneed hint. It's on the write side that we need to tell it, "go ahead and cache this sstable that i'm writing now." > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: CASSANDRA-2635-075.txt, CASSANDRA-2635-trunk-1.txt, > CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252775#comment-13252775 ] Vijay edited comment on CASSANDRA-2635 at 4/12/12 7:52 PM: --- +1 for the rest of the patch, how about the following name and comments? {code} # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only when the node's data fit's in memory. populate_cache_on_flush: false {code} was (Author: vijay2...@yahoo.com): +1 for the rest of the patch, how about the following name and comments? {code} # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only node's data-size can fit in memory. populate_cache_on_flush: false {code} > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: CASSANDRA-2635-075.txt, CASSANDRA-2635-trunk-1.txt, > CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252775#comment-13252775 ] Vijay edited comment on CASSANDRA-2635 at 4/12/12 7:49 PM: --- +1 for the rest of the patch, how about the following name and comments? {code} # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only node's data-size can fit in memory. populate_cache_on_flush: false {code} was (Author: vijay2...@yahoo.com): +1 for the rest of the patch, how about the following name and comments? # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only node's data-size can fit in memory. populate_cache_on_flush: false > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: CASSANDRA-2635-075.txt, CASSANDRA-2635-trunk-1.txt, > CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2635) make cache skipping optional
[ https://issues.apache.org/jira/browse/CASSANDRA-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252775#comment-13252775 ] Vijay commented on CASSANDRA-2635: -- +1 for the rest of the patch, how about the following name and comments? # The following setting populates the page cache on memtable flush and compaction # WARNING: Enable this setting only node's data-size can fit in memory. populate_cache_on_flush: false > make cache skipping optional > > > Key: CASSANDRA-2635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2635 > Project: Cassandra > Issue Type: Improvement >Reporter: Peter Schuller >Assignee: Harish Doddi >Priority: Minor > Attachments: CASSANDRA-2635-075.txt, CASSANDRA-2635-trunk-1.txt, > CASSANDRA-2635-trunk.txt > > > We've applied this patch locally in order to turn of page skipping; not > completely but only for compaction/repair situations where it can be directly > detrimental in the sense of causing data to become cold even though your > entire data set fits in memory. > It's better than completely disabling DONTNEED because the cache skipping > does make sense and has no relevant (that I can see) detrimental effects in > some cases, like when dumping caches. > The patch is against 0.7.5 right now but if the change is desired I can make > a patch for trunk. Also, the name of the configuration option is dubious > since saying 'false' does not actually turn it off completely. I wasn't able > to figure out a good name that conveyed the functionality in a short brief > name however. > A related concern as discussed in CASSANDRA-1902 is that the cache skipping > isn't fsync:ing and so won't work reliably on writes. If the feature is to be > retained that's something to fix in a different ticket. > A question is also whether to retain the default to true or change it to > false. I'm kinda leaning to false since it's detrimental in the "easy" cases > of little data. In "big" cases with lots of data people will have to think > and tweak anyway, so better to put the burden on that end. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4115) UNREACHABLE schema after decommissioning a non-seed node
[ https://issues.apache.org/jira/browse/CASSANDRA-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252554#comment-13252554 ] Brandon Williams commented on CASSANDRA-4115: - What does strike me as odd though is that your 1.0 test has no schema at all, hence the --1000-- uuid. > UNREACHABLE schema after decommissioning a non-seed node > > > Key: CASSANDRA-4115 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4115 > Project: Cassandra > Issue Type: Bug > Environment: ccm using the following unavailable_schema_test.py dtest. >Reporter: Tyler Patterson >Assignee: Brandon Williams >Priority: Minor > Attachments: 4115.txt > > > decommission a non-seed node, sleep 30 seconds, then use thrift to check the > schema. UNREACHABLE is listed: > {'75dc4c07-3c1a-3013-ad7d-11fb34208465': ['127.0.0.1'], > 'UNREACHABLE': ['127.0.0.2']} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4115) UNREACHABLE schema after decommissioning a non-seed node
[ https://issues.apache.org/jira/browse/CASSANDRA-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252550#comment-13252550 ] Brandon Williams commented on CASSANDRA-4115: - This must be something with the environment, on 1.0 I see the node removed as soon as the decom node begins to announce it has left (before it has completed announcing, and thus before nodetool would even return) and it never reappears. > UNREACHABLE schema after decommissioning a non-seed node > > > Key: CASSANDRA-4115 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4115 > Project: Cassandra > Issue Type: Bug > Environment: ccm using the following unavailable_schema_test.py dtest. >Reporter: Tyler Patterson >Assignee: Brandon Williams >Priority: Minor > Attachments: 4115.txt > > > decommission a non-seed node, sleep 30 seconds, then use thrift to check the > schema. UNREACHABLE is listed: > {'75dc4c07-3c1a-3013-ad7d-11fb34208465': ['127.0.0.1'], > 'UNREACHABLE': ['127.0.0.2']} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4140) Build stress classes in a location that allows tools/stress/bin/stress to find them
[ https://issues.apache.org/jira/browse/CASSANDRA-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252549#comment-13252549 ] Nick Bailey commented on CASSANDRA-4140: +1 on these changes from me. Jonathan, maybe you could port the same changes to stress.bat since you run on windows? > Build stress classes in a location that allows tools/stress/bin/stress to > find them > --- > > Key: CASSANDRA-4140 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4140 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Affects Versions: 1.2 >Reporter: Nick Bailey >Assignee: Vijay >Priority: Trivial > Fix For: 1.2 > > Attachments: 0001-CASSANDRA-4140.patch > > > Right now its hard to run stress from a checkout of trunk. You need to do > 'ant artifacts' and then run the stress tool in the generated artifacts. > A discussion on irc came up with the proposal to just move stress to the main > jar, but the stress/stressd bash scripts in bin/, and drop the tools > directory altogether. It will be easier for users to find that way and will > make running stress from a checkout much easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4142) OOM Exception during repair session with LeveledCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-4142: -- Affects Version/s: (was: 1.0.6) 1.0.0 Fix Version/s: 1.1.1 Assignee: Sylvain Lebresne > OOM Exception during repair session with LeveledCompactionStrategy > -- > > Key: CASSANDRA-4142 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4142 > Project: Cassandra > Issue Type: Improvement > Components: Core >Affects Versions: 1.0.0 > Environment: OS: Linux CentOs 6 > JDK: Java HotSpot(TM) 64-Bit Server VM (build 14.0-b16, mixed mode) > Node configuration: > Quad-core > 10 GB RAM > Xmx set to 2,5 GB (as computed by default). >Reporter: Romain Hardouin >Assignee: Sylvain Lebresne > Fix For: 1.1.1 > > > We encountered an OOM Exception on 2 nodes during repair session. > Our CF are set up to use LeveledCompactionStrategy and SnappyCompressor. > These two options used together maybe the key to the problem. > Despite of setting XX:+HeapDumpOnOutOfMemoryError, no dump have been > generated. > Nonetheless a memory analysis on a live node doing a repair reveals an > hotspot: an ArrayList of SSTableBoundedScanner which appears to contain as > many objects as there are SSTables on disk. > This ArrayList consumes 786 MB of the heap space for 5757 objects. Therefore > each object is about 140 KB. > Eclipse Memory Analyzer's denominator tree shows that 99% of a > SSTableBoundedScanner object's memory is consumed by a > CompressedRandomAccessReader which contains two big byte arrays. > Cluster information: > 9 nodes > Each node handles 35 GB (RandomPartitioner) > This JIRA was created following this discussion: > http://cassandra-user-incubator-apache-org.3065146.n2.nabble.com/Why-so-many-SSTables-td7453033.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[2/4] git commit: Add gossip shutdown message to serializer test
Add gossip shutdown message to serializer test Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c215a4c9 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c215a4c9 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c215a4c9 Branch: refs/heads/cassandra-1.1 Commit: c215a4c96436303c9644f19c95db67ba88d871c3 Parents: 33cdcaf Author: Brandon Williams Authored: Thu Apr 12 11:12:52 2012 -0500 Committer: Brandon Williams Committed: Thu Apr 12 11:13:29 2012 -0500 -- .../apache/cassandra/io/CompactSerializerTest.java |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/c215a4c9/test/unit/org/apache/cassandra/io/CompactSerializerTest.java -- diff --git a/test/unit/org/apache/cassandra/io/CompactSerializerTest.java b/test/unit/org/apache/cassandra/io/CompactSerializerTest.java index 58b01a7..4fbab95 100644 --- a/test/unit/org/apache/cassandra/io/CompactSerializerTest.java +++ b/test/unit/org/apache/cassandra/io/CompactSerializerTest.java @@ -58,6 +58,7 @@ public class CompactSerializerTest extends SchemaLoader expectedClassNames.add("GossipDigestAck2MessageSerializer"); expectedClassNames.add("GossipDigestAckMessageSerializer"); expectedClassNames.add("GossipDigestSynMessageSerializer"); +expectedClassNames.add("GossipShutdownMessageSerializer"); expectedClassNames.add("HeartBeatStateSerializer"); expectedClassNames.add("VersionedValueSerializer"); expectedClassNames.add("HeaderSerializer");
[3/4] git commit: Add gossip shutdown message to serializer test
Add gossip shutdown message to serializer test Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c215a4c9 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c215a4c9 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c215a4c9 Branch: refs/heads/trunk Commit: c215a4c96436303c9644f19c95db67ba88d871c3 Parents: 33cdcaf Author: Brandon Williams Authored: Thu Apr 12 11:12:52 2012 -0500 Committer: Brandon Williams Committed: Thu Apr 12 11:13:29 2012 -0500 -- .../apache/cassandra/io/CompactSerializerTest.java |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/c215a4c9/test/unit/org/apache/cassandra/io/CompactSerializerTest.java -- diff --git a/test/unit/org/apache/cassandra/io/CompactSerializerTest.java b/test/unit/org/apache/cassandra/io/CompactSerializerTest.java index 58b01a7..4fbab95 100644 --- a/test/unit/org/apache/cassandra/io/CompactSerializerTest.java +++ b/test/unit/org/apache/cassandra/io/CompactSerializerTest.java @@ -58,6 +58,7 @@ public class CompactSerializerTest extends SchemaLoader expectedClassNames.add("GossipDigestAck2MessageSerializer"); expectedClassNames.add("GossipDigestAckMessageSerializer"); expectedClassNames.add("GossipDigestSynMessageSerializer"); +expectedClassNames.add("GossipShutdownMessageSerializer"); expectedClassNames.add("HeartBeatStateSerializer"); expectedClassNames.add("VersionedValueSerializer"); expectedClassNames.add("HeaderSerializer");
[4/4] git commit: remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141
remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/33cdcaf7 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/33cdcaf7 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/33cdcaf7 Branch: refs/heads/trunk Commit: 33cdcaf73463c351ada6e64dcd158a4823bdb902 Parents: 8909e1a Author: Vijay Parthasarathy Authored: Thu Apr 12 08:36:22 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 08:36:22 2012 -0700 -- .../cassandra/cache/ConcurrentLinkedHashCache.java |1 - .../apache/cassandra/cache/SerializingCache.java |1 - 2 files changed, 0 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/33cdcaf7/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java -- diff --git a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java index a1cf4ea..ad651eb 100644 --- a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java +++ b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java @@ -69,7 +69,6 @@ public class ConcurrentLinkedHashCache implements ICache { ConcurrentLinkedHashMap map = new ConcurrentLinkedHashMap.Builder() .weigher(weigher) -.initialCapacity(0) .maximumWeightedCapacity(weightedCapacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .build(); http://git-wip-us.apache.org/repos/asf/cassandra/blob/33cdcaf7/src/java/org/apache/cassandra/cache/SerializingCache.java -- diff --git a/src/java/org/apache/cassandra/cache/SerializingCache.java b/src/java/org/apache/cassandra/cache/SerializingCache.java index 275130c..08fad20 100644 --- a/src/java/org/apache/cassandra/cache/SerializingCache.java +++ b/src/java/org/apache/cassandra/cache/SerializingCache.java @@ -65,7 +65,6 @@ public class SerializingCache implements ICache .weigher(useMemoryWeigher ? createMemoryWeigher() : Weighers.singleton()) - .initialCapacity(capacity) .maximumWeightedCapacity(capacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .listener(listener)
[1/4] git commit: Merge branch 'cassandra-1.1' into trunk
Updated Branches: refs/heads/cassandra-1.1 33cdcaf73 -> c215a4c96 refs/heads/trunk 531d01c04 -> 8ab2473fe Merge branch 'cassandra-1.1' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8ab2473f Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8ab2473f Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8ab2473f Branch: refs/heads/trunk Commit: 8ab2473fe37c1e75ebb2c803f05649360e0a6861 Parents: 531d01c c215a4c Author: Brandon Williams Authored: Thu Apr 12 11:14:21 2012 -0500 Committer: Brandon Williams Committed: Thu Apr 12 11:14:21 2012 -0500 -- .../apache/cassandra/io/CompactSerializerTest.java |1 + 1 files changed, 1 insertions(+), 0 deletions(-) --
[jira] [Commented] (CASSANDRA-4142) OOM Exception during repair session with LeveledCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252526#comment-13252526 ] Sylvain Lebresne commented on CASSANDRA-4142: - bq. The comments in CRAR say that it can't use super.read, so is the RAR buffer wasted? The buffer in CRAR is for compressed data, the one in RAR is for uncompressed data, so we do need both. bq. Not sure how badly validation needs all of these at once. It doesn't. I haven't given it much though yet, but I think the easiest way/more efficient way to deal with that would be to have only have 1 sstable per level loaded (and all of L0), which should always be reasonable. > OOM Exception during repair session with LeveledCompactionStrategy > -- > > Key: CASSANDRA-4142 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4142 > Project: Cassandra > Issue Type: Improvement > Components: Core >Affects Versions: 1.0.6 > Environment: OS: Linux CentOs 6 > JDK: Java HotSpot(TM) 64-Bit Server VM (build 14.0-b16, mixed mode) > Node configuration: > Quad-core > 10 GB RAM > Xmx set to 2,5 GB (as computed by default). >Reporter: Romain Hardouin > > We encountered an OOM Exception on 2 nodes during repair session. > Our CF are set up to use LeveledCompactionStrategy and SnappyCompressor. > These two options used together maybe the key to the problem. > Despite of setting XX:+HeapDumpOnOutOfMemoryError, no dump have been > generated. > Nonetheless a memory analysis on a live node doing a repair reveals an > hotspot: an ArrayList of SSTableBoundedScanner which appears to contain as > many objects as there are SSTables on disk. > This ArrayList consumes 786 MB of the heap space for 5757 objects. Therefore > each object is about 140 KB. > Eclipse Memory Analyzer's denominator tree shows that 99% of a > SSTableBoundedScanner object's memory is consumed by a > CompressedRandomAccessReader which contains two big byte arrays. > Cluster information: > 9 nodes > Each node handles 35 GB (RandomPartitioner) > This JIRA was created following this discussion: > http://cassandra-user-incubator-apache-org.3065146.n2.nabble.com/Why-so-many-SSTables-td7453033.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4142) OOM Exception during repair session with LeveledCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252523#comment-13252523 ] Pavel Yaskevich commented on CASSANDRA-4142: bq. The comments in CRAR say that it can't use super.read, so is the RAR buffer wasted? Buffer in CRAR used to read compressed data from disk (instead of creating separate buffer each time) and it uses RAR.buffer for decompression, so non of the buffers is wasted. > OOM Exception during repair session with LeveledCompactionStrategy > -- > > Key: CASSANDRA-4142 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4142 > Project: Cassandra > Issue Type: Improvement > Components: Core >Affects Versions: 1.0.6 > Environment: OS: Linux CentOs 6 > JDK: Java HotSpot(TM) 64-Bit Server VM (build 14.0-b16, mixed mode) > Node configuration: > Quad-core > 10 GB RAM > Xmx set to 2,5 GB (as computed by default). >Reporter: Romain Hardouin > > We encountered an OOM Exception on 2 nodes during repair session. > Our CF are set up to use LeveledCompactionStrategy and SnappyCompressor. > These two options used together maybe the key to the problem. > Despite of setting XX:+HeapDumpOnOutOfMemoryError, no dump have been > generated. > Nonetheless a memory analysis on a live node doing a repair reveals an > hotspot: an ArrayList of SSTableBoundedScanner which appears to contain as > many objects as there are SSTables on disk. > This ArrayList consumes 786 MB of the heap space for 5757 objects. Therefore > each object is about 140 KB. > Eclipse Memory Analyzer's denominator tree shows that 99% of a > SSTableBoundedScanner object's memory is consumed by a > CompressedRandomAccessReader which contains two big byte arrays. > Cluster information: > 9 nodes > Each node handles 35 GB (RandomPartitioner) > This JIRA was created following this discussion: > http://cassandra-user-incubator-apache-org.3065146.n2.nabble.com/Why-so-many-SSTables-td7453033.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-4142) OOM Exception during repair session with LeveledCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252523#comment-13252523 ] Pavel Yaskevich edited comment on CASSANDRA-4142 at 4/12/12 4:08 PM: - bq. The comments in CRAR say that it can't use super.read, so is the RAR buffer wasted? Buffer in CRAR used to read compressed data from disk (instead of creating separate buffer each time) and it uses RAR.buffer for decompression, so none of the buffers are wasted. was (Author: xedin): bq. The comments in CRAR say that it can't use super.read, so is the RAR buffer wasted? Buffer in CRAR used to read compressed data from disk (instead of creating separate buffer each time) and it uses RAR.buffer for decompression, so non of the buffers is wasted. > OOM Exception during repair session with LeveledCompactionStrategy > -- > > Key: CASSANDRA-4142 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4142 > Project: Cassandra > Issue Type: Improvement > Components: Core >Affects Versions: 1.0.6 > Environment: OS: Linux CentOs 6 > JDK: Java HotSpot(TM) 64-Bit Server VM (build 14.0-b16, mixed mode) > Node configuration: > Quad-core > 10 GB RAM > Xmx set to 2,5 GB (as computed by default). >Reporter: Romain Hardouin > > We encountered an OOM Exception on 2 nodes during repair session. > Our CF are set up to use LeveledCompactionStrategy and SnappyCompressor. > These two options used together maybe the key to the problem. > Despite of setting XX:+HeapDumpOnOutOfMemoryError, no dump have been > generated. > Nonetheless a memory analysis on a live node doing a repair reveals an > hotspot: an ArrayList of SSTableBoundedScanner which appears to contain as > many objects as there are SSTables on disk. > This ArrayList consumes 786 MB of the heap space for 5757 objects. Therefore > each object is about 140 KB. > Eclipse Memory Analyzer's denominator tree shows that 99% of a > SSTableBoundedScanner object's memory is consumed by a > CompressedRandomAccessReader which contains two big byte arrays. > Cluster information: > 9 nodes > Each node handles 35 GB (RandomPartitioner) > This JIRA was created following this discussion: > http://cassandra-user-incubator-apache-org.3065146.n2.nabble.com/Why-so-many-SSTables-td7453033.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3974) Per-CF TTL
[ https://issues.apache.org/jira/browse/CASSANDRA-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252522#comment-13252522 ] Jonathan Ellis commented on CASSANDRA-3974: --- bq. In the initial patch, I had made changes to both UpdateStatement.addToMutation and ColumnFamily.addColumn to use the larger of the column's TTL or the column family default TTL Oops, I totally missed the addColumn changes. That's exactly what I had in mind. It sounds like you have an updated patch, could you post that? > Per-CF TTL > -- > > Key: CASSANDRA-3974 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3974 > Project: Cassandra > Issue Type: New Feature >Reporter: Jonathan Ellis >Assignee: Kirk True >Priority: Minor > Fix For: 1.2 > > Attachments: trunk-3974.txt > > > Per-CF TTL would allow compaction optimizations ("drop an entire sstable's > worth of expired data") that we can't do with per-column. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4142) OOM Exception during repair session with LeveledCompactionStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252517#comment-13252517 ] Jonathan Ellis commented on CASSANDRA-4142: --- bq. Eclipse Memory Analyzer's denominator tree shows that 99% of a SSTableBoundedScanner object's memory is consumed by a CompressedRandomAccessReader which contains two big byte arrays. One would be the 64KB buffer in RandomAccessReader; the other is the CRAR compression buffer. The comments in CRAR say that it can't use super.read, so is the RAR buffer wasted? bq. an ArrayList of SSTableBoundedScanner which appears to contain as many objects as there are SSTables on disk Not sure how badly validation needs all of these at once. It definitely seems like we could limit it to at most the overlapping sstables for a single L1 target at a time, though, which would cut it by a factor of 10. > OOM Exception during repair session with LeveledCompactionStrategy > -- > > Key: CASSANDRA-4142 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4142 > Project: Cassandra > Issue Type: Improvement > Components: Core >Affects Versions: 1.0.6 > Environment: OS: Linux CentOs 6 > JDK: Java HotSpot(TM) 64-Bit Server VM (build 14.0-b16, mixed mode) > Node configuration: > Quad-core > 10 GB RAM > Xmx set to 2,5 GB (as computed by default). >Reporter: Romain Hardouin > > We encountered an OOM Exception on 2 nodes during repair session. > Our CF are set up to use LeveledCompactionStrategy and SnappyCompressor. > These two options used together maybe the key to the problem. > Despite of setting XX:+HeapDumpOnOutOfMemoryError, no dump have been > generated. > Nonetheless a memory analysis on a live node doing a repair reveals an > hotspot: an ArrayList of SSTableBoundedScanner which appears to contain as > many objects as there are SSTables on disk. > This ArrayList consumes 786 MB of the heap space for 5757 objects. Therefore > each object is about 140 KB. > Eclipse Memory Analyzer's denominator tree shows that 99% of a > SSTableBoundedScanner object's memory is consumed by a > CompressedRandomAccessReader which contains two big byte arrays. > Cluster information: > 9 nodes > Each node handles 35 GB (RandomPartitioner) > This JIRA was created following this discussion: > http://cassandra-user-incubator-apache-org.3065146.n2.nabble.com/Why-so-many-SSTables-td7453033.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4143) HH delivery should not be attempted when target node is down
[ https://issues.apache.org/jira/browse/CASSANDRA-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252510#comment-13252510 ] Jonathan Ellis commented on CASSANDRA-4143: --- I'd be fine pushing that down to debug, though. > HH delivery should not be attempted when target node is down > > > Key: CASSANDRA-4143 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4143 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.0.9 >Reporter: Radim Kolar >Priority: Minor > > Look at this log fragment. Cassandra tries to do HH delivery every 10 minutes > even if host is marked down by gossip. > INFO [GossipTasks:1] 2012-04-12 03:01:55,040 Gossiper.java (line 818) > InetAddress /64.6.104.18 is now dead. > INFO [MemoryMeter:1] 2012-04-12 03:04:12,503 Memtable.java (line 186) > CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is > 1.7635719581514129 (just-counted was 1.7635719581514129). calculation took > 224ms for 226 columns > WARN [MemoryMeter:1] 2012-04-12 03:08:48,995 Memtable.java (line 176) > setting live ratio to minimum of 1.0 instead of 0.8717337990312605 > INFO [MemoryMeter:1] 2012-04-12 03:08:48,995 Memtable.java (line 186) > CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is > 1.7635719581514129 (just-counted was 1.0). calculation took 8ms for 738 > columns > INFO [HintedHandoff:1] 2012-04-12 03:09:31,269 HintedHandOffManager.java > (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting > INFO [MemoryMeter:1] 2012-04-12 03:16:58,007 Memtable.java (line 186) > CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is > 1.7635719581514129 (just-counted was 1.0055416029080733). calculation took > 19ms for 1762 columns > INFO [HintedHandoff:1] 2012-04-12 03:19:54,924 HintedHandOffManager.java > (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141
Updated Branches: refs/heads/trunk b289de1a7 -> 531d01c04 remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/531d01c0 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/531d01c0 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/531d01c0 Branch: refs/heads/trunk Commit: 531d01c04d120f4a784eab898240a6b7e59bf1c8 Parents: b289de1 Author: Vijay Parthasarathy Authored: Thu Apr 12 08:36:22 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 08:38:28 2012 -0700 -- .../cassandra/cache/ConcurrentLinkedHashCache.java |1 - .../apache/cassandra/cache/SerializingCache.java |1 - 2 files changed, 0 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/531d01c0/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java -- diff --git a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java index 5c984df..862e739 100644 --- a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java +++ b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java @@ -66,7 +66,6 @@ public class ConcurrentLinkedHashCache implements ICache { ConcurrentLinkedHashMap map = new ConcurrentLinkedHashMap.Builder() .weigher(weigher) -.initialCapacity(0) .maximumWeightedCapacity(weightedCapacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .build(); http://git-wip-us.apache.org/repos/asf/cassandra/blob/531d01c0/src/java/org/apache/cassandra/cache/SerializingCache.java -- diff --git a/src/java/org/apache/cassandra/cache/SerializingCache.java b/src/java/org/apache/cassandra/cache/SerializingCache.java index cd74611..1dac92e 100644 --- a/src/java/org/apache/cassandra/cache/SerializingCache.java +++ b/src/java/org/apache/cassandra/cache/SerializingCache.java @@ -61,7 +61,6 @@ public class SerializingCache implements ICache .weigher(useMemoryWeigher ? createMemoryWeigher() : Weighers.singleton()) - .initialCapacity(capacity) .maximumWeightedCapacity(capacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .listener(listener)
git commit: remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141
Updated Branches: refs/heads/cassandra-1.1.0 cbbf54910 -> 2eaea5be9 remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2eaea5be Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2eaea5be Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2eaea5be Branch: refs/heads/cassandra-1.1.0 Commit: 2eaea5be96461b1d9e405d26229b9803a96d3abf Parents: cbbf549 Author: Vijay Parthasarathy Authored: Thu Apr 12 08:36:22 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 08:38:04 2012 -0700 -- .../cassandra/cache/ConcurrentLinkedHashCache.java |1 - .../apache/cassandra/cache/SerializingCache.java |1 - 2 files changed, 0 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/2eaea5be/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java -- diff --git a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java index a1cf4ea..ad651eb 100644 --- a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java +++ b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java @@ -69,7 +69,6 @@ public class ConcurrentLinkedHashCache implements ICache { ConcurrentLinkedHashMap map = new ConcurrentLinkedHashMap.Builder() .weigher(weigher) -.initialCapacity(0) .maximumWeightedCapacity(weightedCapacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .build(); http://git-wip-us.apache.org/repos/asf/cassandra/blob/2eaea5be/src/java/org/apache/cassandra/cache/SerializingCache.java -- diff --git a/src/java/org/apache/cassandra/cache/SerializingCache.java b/src/java/org/apache/cassandra/cache/SerializingCache.java index 275130c..08fad20 100644 --- a/src/java/org/apache/cassandra/cache/SerializingCache.java +++ b/src/java/org/apache/cassandra/cache/SerializingCache.java @@ -65,7 +65,6 @@ public class SerializingCache implements ICache .weigher(useMemoryWeigher ? createMemoryWeigher() : Weighers.singleton()) - .initialCapacity(capacity) .maximumWeightedCapacity(capacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .listener(listener)
git commit: remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141
Updated Branches: refs/heads/cassandra-1.1 8909e1a92 -> 33cdcaf73 remove intialCapacity from rowcache patch by Vijay; reviewed by xedin for CASSANDRA-4141 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/33cdcaf7 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/33cdcaf7 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/33cdcaf7 Branch: refs/heads/cassandra-1.1 Commit: 33cdcaf73463c351ada6e64dcd158a4823bdb902 Parents: 8909e1a Author: Vijay Parthasarathy Authored: Thu Apr 12 08:36:22 2012 -0700 Committer: Vijay Parthasarathy Committed: Thu Apr 12 08:36:22 2012 -0700 -- .../cassandra/cache/ConcurrentLinkedHashCache.java |1 - .../apache/cassandra/cache/SerializingCache.java |1 - 2 files changed, 0 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/33cdcaf7/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java -- diff --git a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java index a1cf4ea..ad651eb 100644 --- a/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java +++ b/src/java/org/apache/cassandra/cache/ConcurrentLinkedHashCache.java @@ -69,7 +69,6 @@ public class ConcurrentLinkedHashCache implements ICache { ConcurrentLinkedHashMap map = new ConcurrentLinkedHashMap.Builder() .weigher(weigher) -.initialCapacity(0) .maximumWeightedCapacity(weightedCapacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .build(); http://git-wip-us.apache.org/repos/asf/cassandra/blob/33cdcaf7/src/java/org/apache/cassandra/cache/SerializingCache.java -- diff --git a/src/java/org/apache/cassandra/cache/SerializingCache.java b/src/java/org/apache/cassandra/cache/SerializingCache.java index 275130c..08fad20 100644 --- a/src/java/org/apache/cassandra/cache/SerializingCache.java +++ b/src/java/org/apache/cassandra/cache/SerializingCache.java @@ -65,7 +65,6 @@ public class SerializingCache implements ICache .weigher(useMemoryWeigher ? createMemoryWeigher() : Weighers.singleton()) - .initialCapacity(capacity) .maximumWeightedCapacity(capacity) .concurrencyLevel(DEFAULT_CONCURENCY_LEVEL) .listener(listener)
[jira] [Resolved] (CASSANDRA-4143) HH delivery should not be attempted when target node is down
[ https://issues.apache.org/jira/browse/CASSANDRA-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams resolved CASSANDRA-4143. - Resolution: Not A Problem bq. INFO [HintedHandoff:1] 2012-04-12 03:19:54,924 HintedHandOffManager.java (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting This is where it checked the FD and gave up. {noformat} if (!FailureDetector.instance.isAlive(endpoint)) { logger.info("Endpoint {} died before hint delivery, aborting", endpoint); return; } {noformat} > HH delivery should not be attempted when target node is down > > > Key: CASSANDRA-4143 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4143 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.0.9 >Reporter: Radim Kolar >Priority: Minor > > Look at this log fragment. Cassandra tries to do HH delivery every 10 minutes > even if host is marked down by gossip. > INFO [GossipTasks:1] 2012-04-12 03:01:55,040 Gossiper.java (line 818) > InetAddress /64.6.104.18 is now dead. > INFO [MemoryMeter:1] 2012-04-12 03:04:12,503 Memtable.java (line 186) > CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is > 1.7635719581514129 (just-counted was 1.7635719581514129). calculation took > 224ms for 226 columns > WARN [MemoryMeter:1] 2012-04-12 03:08:48,995 Memtable.java (line 176) > setting live ratio to minimum of 1.0 instead of 0.8717337990312605 > INFO [MemoryMeter:1] 2012-04-12 03:08:48,995 Memtable.java (line 186) > CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is > 1.7635719581514129 (just-counted was 1.0). calculation took 8ms for 738 > columns > INFO [HintedHandoff:1] 2012-04-12 03:09:31,269 HintedHandOffManager.java > (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting > INFO [MemoryMeter:1] 2012-04-12 03:16:58,007 Memtable.java (line 186) > CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is > 1.7635719581514129 (just-counted was 1.0055416029080733). calculation took > 19ms for 1762 columns > INFO [HintedHandoff:1] 2012-04-12 03:19:54,924 HintedHandOffManager.java > (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4141) Looks like Serializing cache broken in 1.1
[ https://issues.apache.org/jira/browse/CASSANDRA-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252461#comment-13252461 ] Pavel Yaskevich commented on CASSANDRA-4141: +1 > Looks like Serializing cache broken in 1.1 > -- > > Key: CASSANDRA-4141 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4141 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Vijay >Assignee: Vijay > Fix For: 1.1.0 > > Attachments: 0001-CASSANDRA-4141.patch > > > I get the following error while setting the row cache to be 1500 MB > INFO 23:27:25,416 Initializing row cache with capacity of 1500 MBs and > provider org.apache.cassandra.cache.SerializingCacheProvider > java.lang.OutOfMemoryError: Java heap space > Dumping heap to java_pid26402.hprof ... > havent spend a lot of time looking into the issue but looks like SC > constructor has > .initialCapacity(capacity) > .maximumWeightedCapacity(capacity) > which 1500Mb -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4141) Looks like Serializing cache broken in 1.1
[ https://issues.apache.org/jira/browse/CASSANDRA-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252452#comment-13252452 ] Vijay commented on CASSANDRA-4141: -- initialCapacity here is the number of elements in the hashmap and not the size. Size should be controlled by maximumWeightedCapacity (yes the names are confusing through) We are running OOM because we where trying to allocate 1500 * 1024 *1024 elements. the intial capacity is used to create the ConcurrentHashMap {code} new ConcurrentHashMap(builder.initialCapacity, 0.75f, concurrencyLevel); {code} > Looks like Serializing cache broken in 1.1 > -- > > Key: CASSANDRA-4141 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4141 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Vijay >Assignee: Vijay > Fix For: 1.1.0 > > Attachments: 0001-CASSANDRA-4141.patch > > > I get the following error while setting the row cache to be 1500 MB > INFO 23:27:25,416 Initializing row cache with capacity of 1500 MBs and > provider org.apache.cassandra.cache.SerializingCacheProvider > java.lang.OutOfMemoryError: Java heap space > Dumping heap to java_pid26402.hprof ... > havent spend a lot of time looking into the issue but looks like SC > constructor has > .initialCapacity(capacity) > .maximumWeightedCapacity(capacity) > which 1500Mb -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3636) cassandra 1.0.x breakes APT on debian OpenVZ
[ https://issues.apache.org/jira/browse/CASSANDRA-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252318#comment-13252318 ] Tio Tempestade commented on CASSANDRA-3636: --- Solved it! Just unpack the .deb and comment the sysctl -p /etc/sysctl.d/cassandra.conf line in postinst. It is already set to vm.max_map_count = 1048575 as the script tries to do.. After that rebuild the .deb and proceed with Datastax's installation. > cassandra 1.0.x breakes APT on debian OpenVZ > > > Key: CASSANDRA-3636 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3636 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Affects Versions: 1.0.6 > Environment: Debian Linux (stable), OpenVZ container >Reporter: Zenek Kraweznik >Assignee: Brandon Williams >Priority: Minor > > During upgrade from 1.0.6 > {code}Setting up cassandra (1.0.6) ... > *error: permission denied on key 'vm.max_map_count'* > dpkg: error processing cassandra (--configure): > subprocess installed post-installation script returned error exit status 255 > Errors were encountered while processing: > cassandra > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4141) Looks like Serializing cache broken in 1.1
[ https://issues.apache.org/jira/browse/CASSANDRA-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252311#comment-13252311 ] Pavel Yaskevich commented on CASSANDRA-4141: Wouldn't that instead crash with OOM later in some unpredictable moment (e.g. when cache is read from disk) or when cache resizing is done? > Looks like Serializing cache broken in 1.1 > -- > > Key: CASSANDRA-4141 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4141 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 1.1.0 >Reporter: Vijay >Assignee: Vijay > Fix For: 1.1.0 > > Attachments: 0001-CASSANDRA-4141.patch > > > I get the following error while setting the row cache to be 1500 MB > INFO 23:27:25,416 Initializing row cache with capacity of 1500 MBs and > provider org.apache.cassandra.cache.SerializingCacheProvider > java.lang.OutOfMemoryError: Java heap space > Dumping heap to java_pid26402.hprof ... > havent spend a lot of time looking into the issue but looks like SC > constructor has > .initialCapacity(capacity) > .maximumWeightedCapacity(capacity) > which 1500Mb -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2441) Cassandra crashes with segmentation fault on Debian 5.0 and Ubuntu 10.10
[ https://issues.apache.org/jira/browse/CASSANDRA-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252306#comment-13252306 ] Richard Low commented on CASSANDRA-2441: Tracked this down to the stack size setting. In cassandra-env.sh, the stack size is set to 128k. From running gdb, the segfault is tracked down to a stack overflow in parse_manifest.c:234 within openjdk. It's clear what's going on: there's a huge statically allocated variable. Setting the stack size to 256k means Cassandra can start up with javaagent. So we could reenable this for openjdk if people are prepared to take the memory hit on stack size. > Cassandra crashes with segmentation fault on Debian 5.0 and Ubuntu 10.10 > > > Key: CASSANDRA-2441 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2441 > Project: Cassandra > Issue Type: Bug > Components: Core >Affects Versions: 0.8 beta 1 > Environment: Both servers have identical hardware configuration: > Quad-Core AMD Opteron(tm) Processor 2374 HE, 4 GB RAM (rackspace servers) > Java version "1.6.0_20" > OpenJDK Runtime Environment (IcedTea6 1.9.7) (6b20-1.9.7-0ubuntu1) > OpenJDK 64-Bit Server VM (build 19.0-b09, mixed mode) >Reporter: Pavel Yaskevich >Assignee: Jonathan Ellis >Priority: Critical > Fix For: 0.8 beta 1 > > Attachments: 2441.txt, 2441.txt, jamm-0.2.1.jar > > > Last working commit is c8d1984bf17cab58f40069e522d074c7b0077bc1 (merge from > 0.7), branch: trunk. > What I did is cloned git://git.apache.org/cassandra.git and did git reset > each commit with `ant clean && ant && ./bin/cassandra -f` until I got > cassandra started -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-4143) HH delivery should not be attempted when target node is down
HH delivery should not be attempted when target node is down Key: CASSANDRA-4143 URL: https://issues.apache.org/jira/browse/CASSANDRA-4143 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.0.9 Reporter: Radim Kolar Priority: Minor Look at this log fragment. Cassandra tries to do HH delivery every 10 minutes even if host is marked down by gossip. INFO [GossipTasks:1] 2012-04-12 03:01:55,040 Gossiper.java (line 818) InetAddress /64.6.104.18 is now dead. INFO [MemoryMeter:1] 2012-04-12 03:04:12,503 Memtable.java (line 186) CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is 1.7635719581514129 (just-counted was 1.7635719581514129). calculation took 224ms for 226 columns WARN [MemoryMeter:1] 2012-04-12 03:08:48,995 Memtable.java (line 176) setting live ratio to minimum of 1.0 instead of 0.8717337990312605 INFO [MemoryMeter:1] 2012-04-12 03:08:48,995 Memtable.java (line 186) CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is 1.7635719581514129 (just-counted was 1.0). calculation took 8ms for 738 columns INFO [HintedHandoff:1] 2012-04-12 03:09:31,269 HintedHandOffManager.java (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting INFO [MemoryMeter:1] 2012-04-12 03:16:58,007 Memtable.java (line 186) CFS(Keyspace='system', ColumnFamily='HintsColumnFamily') liveRatio is 1.7635719581514129 (just-counted was 1.0055416029080733). calculation took 19ms for 1762 columns INFO [HintedHandoff:1] 2012-04-12 03:19:54,924 HintedHandOffManager.java (line 292) Endpoint /64.6.104.18 died before hint delivery, aborting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Git Push Summary
Updated Tags: refs/tags/1.1.0-rc1-tentative [created] cbbf54910
git commit: Update version for 1.1.0 RC1 release
Updated Branches: refs/heads/cassandra-1.1.0 34c1fc0b7 -> cbbf54910 Update version for 1.1.0 RC1 release Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cbbf5491 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cbbf5491 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cbbf5491 Branch: refs/heads/cassandra-1.1.0 Commit: cbbf54910f7f98e9f4b944b984b2460f42cd50bd Parents: 34c1fc0 Author: Sylvain Lebresne Authored: Thu Apr 12 10:01:18 2012 +0200 Committer: Sylvain Lebresne Committed: Thu Apr 12 10:01:18 2012 +0200 -- .rat-excludes|1 + build.xml|2 +- debian/changelog |6 ++ 3 files changed, 8 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/cbbf5491/.rat-excludes -- diff --git a/.rat-excludes b/.rat-excludes index 9dc6311..f41d97a 100644 --- a/.rat-excludes +++ b/.rat-excludes @@ -30,3 +30,4 @@ doc/cql/CQL* build.properties.default test/data/legacy-sstables/** examples/pig/** +examples/hadoop_word_count/conf/log4j.properties http://git-wip-us.apache.org/repos/asf/cassandra/blob/cbbf5491/build.xml -- diff --git a/build.xml b/build.xml index 2286b27..ca83a0d 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/cbbf5491/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index 01bf383..9c795f1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (1.1.0~rc1) unstable; urgency=low + + * New Release Candidate + + -- Sylvain Lebresne Thu, 12 Apr 2012 09:59:27 +0200 + cassandra (1.1.0~beta2) unstable; urgency=low * New beta release
[jira] [Created] (CASSANDRA-4142) OOM Exception during repair session with LeveledCompactionStrategy
OOM Exception during repair session with LeveledCompactionStrategy -- Key: CASSANDRA-4142 URL: https://issues.apache.org/jira/browse/CASSANDRA-4142 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.0.6 Environment: OS: Linux CentOs 6 JDK: Java HotSpot(TM) 64-Bit Server VM (build 14.0-b16, mixed mode) Node configuration: Quad-core 10 GB RAM Xmx set to 2,5 GB (as computed by default). Reporter: Romain Hardouin We encountered an OOM Exception on 2 nodes during repair session. Our CF are set up to use LeveledCompactionStrategy and SnappyCompressor. These two options used together maybe the key to the problem. Despite of setting XX:+HeapDumpOnOutOfMemoryError, no dump have been generated. Nonetheless a memory analysis on a live node doing a repair reveals an hotspot: an ArrayList of SSTableBoundedScanner which appears to contain as many objects as there are SSTables on disk. This ArrayList consumes 786 MB of the heap space for 5757 objects. Therefore each object is about 140 KB. Eclipse Memory Analyzer's denominator tree shows that 99% of a SSTableBoundedScanner object's memory is consumed by a CompressedRandomAccessReader which contains two big byte arrays. Cluster information: 9 nodes Each node handles 35 GB (RandomPartitioner) This JIRA was created following this discussion: http://cassandra-user-incubator-apache-org.3065146.n2.nabble.com/Why-so-many-SSTables-td7453033.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira