[4/5] git commit: Merge branch 'cassandra-1.1' into cassandra-1.2
Merge branch 'cassandra-1.1' into cassandra-1.2
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1f21bbe1
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1f21bbe1
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1f21bbe1
Branch: refs/heads/trunk
Commit: 1f21bbe18bed5496b9dbc3922240b94863e27bcd
Parents: 25014a1 868e7eb
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 01:59:06 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 01:59:06 2013 -0400
--
CHANGES.txt|5 +
.../cassandra/db/compaction/OperationType.java |2 +-
.../cassandra/hadoop/pig/CassandraStorage.java |8
3 files changed, 10 insertions(+), 5 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/1f21bbe1/CHANGES.txt
--
diff --cc CHANGES.txt
index 2124b15,b225cdf..b17d8e1
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -85,87 -10,11 +85,92 @@@ Merged from 1.1
* cqlsh: Add inet type support on Windows (ipv4-only) (CASSANDRA-4801)
* Fix race when initializing ColumnFamilyStore (CASSANDRA-5350)
* Add UseTLAB JVM flag (CASSANDRA-5361)
+
+
+1.2.2
+ * fix potential for multiple concurrent compactions of the same sstables
+ (CASSANDRA-5256)
+ * avoid no-op caching of byte[] on commitlog append (CASSANDRA-5199)
+ * fix symlinks under data dir not working (CASSANDRA-5185)
+ * fix bug in compact storage metadata handling (CASSANDRA-5189)
+ * Validate login for USE queries (CASSANDRA-5207)
+ * cli: remove default username and password (CASSANDRA-5208)
+ * configure populate_io_cache_on_flush per-CF (CASSANDRA-4694)
+ * allow configuration of internode socket buffer (CASSANDRA-3378)
+ * Make sstable directory picking blacklist-aware again (CASSANDRA-5193)
+ * Correctly expire gossip states for edge cases (CASSANDRA-5216)
+ * Improve handling of directory creation failures (CASSANDRA-5196)
+ * Expose secondary indicies to the rest of nodetool (CASSANDRA-4464)
+ * Binary protocol: avoid sending notification for 0.0.0.0 (CASSANDRA-5227)
+ * add UseCondCardMark XX jvm settings on jdk 1.7 (CASSANDRA-4366)
+ * CQL3 refactor to allow conversion function (CASSANDRA-5226)
+ * Fix drop of sstables in some circumstance (CASSANDRA-5232)
+ * Implement caching of authorization results (CASSANDRA-4295)
+ * Add support for LZ4 compression (CASSANDRA-5038)
+ * Fix missing columns in wide rows queries (CASSANDRA-5225)
+ * Simplify auth setup and make system_auth ks alterable (CASSANDRA-5112)
+ * Stop compactions from hanging during bootstrap (CASSANDRA-5244)
+ * fix compressed streaming sending extra chunk (CASSANDRA-5105)
+ * Add CQL3-based implementations of IAuthenticator and IAuthorizer
+ (CASSANDRA-4898)
+ * Fix timestamp-based tomstone removal logic (CASSANDRA-5248)
+ * cli: Add JMX authentication support (CASSANDRA-5080)
+ * Fix forceFlush behavior (CASSANDRA-5241)
+ * cqlsh: Add username autocompletion (CASSANDRA-5231)
+ * Fix CQL3 composite partition key error (CASSANDRA-5240)
+ * Allow IN clause on last clustering key (CASSANDRA-5230)
+
+
+1.2.1
+ * stream undelivered hints on decommission (CASSANDRA-5128)
+ * GossipingPropertyFileSnitch loads saved dc/rack info if needed
(CASSANDRA-5133)
+ * drain should flush system CFs too (CASSANDRA-4446)
+ * add inter_dc_tcp_nodelay setting (CASSANDRA-5148)
+ * re-allow wrapping ranges for start_token/end_token range pairing
(CASSANDRA-5106)
+ * fix validation compaction of empty rows (CASSADRA-5136)
+ * nodetool methods to enable/disable hint storage/delivery (CASSANDRA-4750)
+ * disallow bloom filter false positive chance of 0 (CASSANDRA-5013)
+ * add threadpool size adjustment methods to JMXEnabledThreadPoolExecutor and
+ CompactionManagerMBean (CASSANDRA-5044)
+ * fix hinting for dropped local writes (CASSANDRA-4753)
+ * off-heap cache doesn't need mutable column container (CASSANDRA-5057)
+ * apply disk_failure_policy to bad disks on initial directory creation
+ (CASSANDRA-4847)
+ * Optimize name-based queries to use ArrayBackedSortedColumns
(CASSANDRA-5043)
+ * Fall back to old manifest if most recent is unparseable (CASSANDRA-5041)
+ * pool [Compressed]RandomAccessReader objects on the partitioned read path
+ (CASSANDRA-4942)
+ * Add debug logging to list filenames processed by Directories.migrateFile
+ method (CASSANDRA-4939)
+ * Expose black-listed directories via JMX (CASSANDRA-4848)
+ * Log compaction merge counts (CASSANDRA-4894)
+ * Minimize byte array allocation by AbstractData{Input,Output}
(CASSANDRA-5090)
+ * Add SSL support for the binary protocol (CASSANDRA-5031)
+ * Allow non-schema system ks
[1/5] git commit: replace mistaken usage of commons-logging with slf4j patch by dbrosius reviewed by jbellis for CASSANDRA-5464
Updated Branches: refs/heads/trunk 704eb97a6 - a9d6aefd4 replace mistaken usage of commons-logging with slf4j patch by dbrosius reviewed by jbellis for CASSANDRA-5464 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/822bda77 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/822bda77 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/822bda77 Branch: refs/heads/trunk Commit: 822bda77aba24fda8b234590bedb292e32443aa5 Parents: 112014a Author: Dave Brosius dbros...@apache.org Authored: Sat Apr 13 01:03:11 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Sat Apr 13 01:03:11 2013 -0400 -- CHANGES.txt|1 + .../cassandra/hadoop/pig/CassandraStorage.java |7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/822bda77/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 59a7443..b225cdf 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -14,6 +14,7 @@ * Fix bad default for min/max timestamp in SSTableMetadata (CASSANDRA-5372) * Fix cf name extraction from manifest in Directories.migrateFile() (CASSANDRA-5242) * Support pluggable internode authentication (CASSANDRA-5401) + * Replace mistaken usage of commons-logging with slf4j (CASSANDRA-5464) 1.1.10 http://git-wip-us.apache.org/repos/asf/cassandra/blob/822bda77/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java -- diff --git a/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java b/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java index f362fca..55ccbb9 100644 --- a/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java +++ b/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java @@ -21,9 +21,6 @@ import java.math.BigInteger; import java.nio.ByteBuffer; import java.util.*; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; - import org.apache.cassandra.auth.IAuthenticator; import org.apache.cassandra.config.ConfigurationException; import org.apache.cassandra.db.Column; @@ -49,6 +46,8 @@ import org.apache.pig.ResourceSchema.ResourceFieldSchema; import org.apache.thrift.TDeserializer; import org.apache.thrift.TException; import org.apache.thrift.TSerializer; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * A LoadStoreFunc for retrieving data from and storing data to Cassandra @@ -82,7 +81,7 @@ public class CassandraStorage extends LoadFunc implements StoreFuncInterface, Lo private final static String PARTITION_FILTER_SIGNATURE = cassandra.partition.filter; private final static ByteBuffer BOUND = ByteBufferUtil.EMPTY_BYTE_BUFFER; -private static final Log logger = LogFactory.getLog(CassandraStorage.class); +private static final Logger logger = LoggerFactory.getLogger(CassandraStorage.class); private ByteBuffer slice_start = BOUND; private ByteBuffer slice_end = BOUND;
[5/5] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/a9d6aefd Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/a9d6aefd Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/a9d6aefd Branch: refs/heads/trunk Commit: a9d6aefd4feecdc983f2a30a5b78a54b00823d65 Parents: 704eb97 1f21bbe Author: Dave Brosius dbros...@apache.org Authored: Mon Apr 15 02:00:37 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Mon Apr 15 02:00:37 2013 -0400 -- CHANGES.txt|5 + .../cassandra/db/compaction/OperationType.java |2 +- .../cassandra/hadoop/pig/CassandraStorage.java |8 3 files changed, 10 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/a9d6aefd/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/a9d6aefd/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java -- diff --cc src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java index 2b074f7,110f61d..6fa085f --- a/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java +++ b/src/java/org/apache/cassandra/hadoop/pig/CassandraStorage.java @@@ -22,13 -22,12 +22,11 @@@ import java.math.BigInteger import java.nio.ByteBuffer; import java.util.*; + import org.apache.cassandra.exceptions.ConfigurationException; import org.apache.cassandra.exceptions.SyntaxException; - import org.apache.commons.logging.Log; - import org.apache.commons.logging.LogFactory; - import org.apache.cassandra.auth.IAuthenticator; import org.apache.cassandra.db.Column; -import org.apache.cassandra.db.IColumn; import org.apache.cassandra.db.marshal.*; import org.apache.cassandra.db.marshal.AbstractCompositeType.CompositeComponent; import org.apache.cassandra.hadoop.*;
[3/5] git commit: fix OperationType.UNKNOWN compaction message spelling
fix OperationType.UNKNOWN compaction message spelling Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/868e7eb3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/868e7eb3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/868e7eb3 Branch: refs/heads/trunk Commit: 868e7eb3c8e9ab2e175d4142ac1479b1f65f6173 Parents: 822bda7 Author: Dave Brosius dbros...@apache.org Authored: Mon Apr 15 01:49:47 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Mon Apr 15 01:49:47 2013 -0400 -- .../cassandra/db/compaction/OperationType.java |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/868e7eb3/src/java/org/apache/cassandra/db/compaction/OperationType.java -- diff --git a/src/java/org/apache/cassandra/db/compaction/OperationType.java b/src/java/org/apache/cassandra/db/compaction/OperationType.java index a6cb420..218808b 100644 --- a/src/java/org/apache/cassandra/db/compaction/OperationType.java +++ b/src/java/org/apache/cassandra/db/compaction/OperationType.java @@ -31,7 +31,7 @@ public enum OperationType SCRUB(Scrub), UPGRADE_SSTABLES(Upgrade sstables), INDEX_BUILD(Secondary index build), -UNKNOWN(Unkown compaction type); +UNKNOWN(Unknown compaction type); private final String type;
[2/5] git commit: comments
comments Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/25014a19 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/25014a19 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/25014a19 Branch: refs/heads/trunk Commit: 25014a193f009799bae10cbac291bb83b69f695d Parents: a25ac14 Author: Jonathan Ellis jbel...@apache.org Authored: Sat Apr 13 23:45:40 2013 -0500 Committer: Jonathan Ellis jbel...@apache.org Committed: Sat Apr 13 23:48:06 2013 -0500 -- conf/cassandra.yaml |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/25014a19/conf/cassandra.yaml -- diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 6eb0c6b..22e136c 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -102,7 +102,9 @@ permissions_validity_in_ms: 2000 # partitioners and token selection. partitioner: org.apache.cassandra.dht.Murmur3Partitioner -# directories where Cassandra should store data on disk. +# Directories where Cassandra should store data on disk. Cassandra +# will spread data evenly across them, subject to the granularity of +# the configured compaction strategy. data_file_directories: - /var/lib/cassandra/data
[jira] [Commented] (CASSANDRA-5461) LOCAL_QUORUM reads/writes don't throw UnavailableException if local quorum not present
[
https://issues.apache.org/jira/browse/CASSANDRA-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631593#comment-13631593
]
Piotr Kołaczkowski commented on CASSANDRA-5461:
---
I haven't tried. Maybe there is something in DSE that breaks it. Ok, I try this
week and let you know.
LOCAL_QUORUM reads/writes don't throw UnavailableException if local quorum
not present
--
Key: CASSANDRA-5461
URL: https://issues.apache.org/jira/browse/CASSANDRA-5461
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.9
Environment: Cassandra 1.1.9.3, DSE 3.0.1, Ubuntu Linux 12.10
Reporter: Piotr Kołaczkowski
Assignee: Ryan McGuire
{noformat}
automaton@ip-10-171-69-238:~$ dsetool ring cfs
Address DC RackWorkloadStatus State Load
Effective-Ownership Token
127605887595351923798765477786913079296
10.171.69.238 Analytics rack1 Analytics(JT) Up Normal 151.19
KB 100.00% 0
10.171.147.24 Analytics rack1 Analytics(TT) Down Down103.79
KB 100.00% 42535295865117307932921825928971026432
10.172.86.251 Analytics rack1 Analytics(TT) Down Down145.03
KB 100.00% 85070591730234615865843651857942052864
10.174.23.34Analytics rack1 Analytics(TT) Down Down158.88
KB 100.00% 127605887595351923798765477786913079296
{noformat}
{noformat}
Keyspace: cfs:
Replication Strategy: org.apache.cassandra.locator.NetworkTopologyStrategy
Durable Writes: true
Options: [analytics:4]
{noformat}
Reading from CFS with LOCAL_QUORUM:
{noformat}
automaton@ip-10-171-69-238:~$ dse hadoop fs -lsr /
13/04/12 16:18:23 INFO cfs.CassandraFileSystem: CassandraFileSystem.uri :
cfs://ip-10-171-69-238.us-west-1.compute.internal/
13/04/12 16:18:23 INFO cfs.CassandraFileSystem: Default block size: 67108864
13/04/12 16:18:24 INFO cfs.CassandraFileSystemThriftStore: Consistency level
for reads from cfs: LOCAL_QUORUM
13/04/12 16:18:24 INFO cfs.CassandraFileSystemThriftStore: Consistency level
for writes into cfs: LOCAL_QUORUM
13/04/12 16:18:24 INFO cfs.CassandraFileSystemRules: Successfully loaded path
rules for: cfs
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:42 /tf1
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:49 /tf10
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:43 /tf2
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:43 /tf3
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:43 /tf4
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:46 /tf5
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:46 /tf6
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:47 /tf7
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:47 /tf8
-rwxrwxrwx 1 automaton automaton 10 2013-04-12 15:49 /tf9
drwxrwxrwx - automaton automaton 0 2013-04-12 15:36 /tmp
drwxrwxrwx - automaton automaton 0 2013-04-12 15:36
/tmp/hadoop-automaton
drwxrwxrwx - automaton automaton 0 2013-04-12 15:36
/tmp/hadoop-automaton/mapred
drwx-- - automaton automaton 0 2013-04-12 15:36
/tmp/hadoop-automaton/mapred/system
-rwxrwxrwx 1 automaton automaton 4 2013-04-12 15:36
/tmp/hadoop-automaton/mapred/system/jobtracker.info
{noformat}
Now exactly the same with QUORUM:
{noformat}
automaton@ip-10-171-69-238:~$ dse hadoop fs -lsr /
13/04/12 16:19:21 INFO cfs.CassandraFileSystem: CassandraFileSystem.uri :
cfs://ip-10-171-69-238.us-west-1.compute.internal/
13/04/12 16:19:21 INFO cfs.CassandraFileSystem: Default block size: 67108864
13/04/12 16:19:22 INFO cfs.CassandraFileSystemThriftStore: Consistency level
for reads from cfs: QUORUM
13/04/12 16:19:22 INFO cfs.CassandraFileSystemThriftStore: Consistency level
for writes into cfs: QUORUM
13/04/12 16:19:22 INFO cfs.CassandraFileSystemRules: Successfully loaded path
rules for: cfs
lsr: UnavailableException()
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5470) Query with condition on two secondary indexes can't be run without ALLOW FILTERING.
Sergey Naumov created CASSANDRA-5470: Summary: Query with condition on two secondary indexes can't be run without ALLOW FILTERING. Key: CASSANDRA-5470 URL: https://issues.apache.org/jira/browse/CASSANDRA-5470 Project: Cassandra Issue Type: Bug Affects Versions: 1.2.3 Environment: Apache Cassandra 1.2.3 installed from DataStax debian repository. Reporter: Sergey Naumov While manual explicitly suggests to use multiple secondary indices (http://www.datastax.com/docs/1.2/ddl/indexes - Using multiple secondary indexes), it is impossible to call such a query without ALLOW FILTERING clause. I have the following table: cqlsh SQL DROP TABLE k1.tbl1; CREATE TABLE k1.tbl1 ( id timeuuid, name varchar, regid int, date timestamp, time timestamp, payload varchar, PRIMARY KEY (id) ); CREATE INDEX tbl1_name ON k1.tbl1 (name); CREATE INDEX tbl1_regid ON k1.tbl1 (regid); CREATE INDEX tbl1_date ON k1.tbl1 (date); SQL But when I'm trying to perform a query, error occured: cqlsh select * from k1.tbl1 where regid = 2 and name = 'DB49'; Bad Request: Cannot execute this query as it might involve data filtering and thus may have unpredictable performance. If you want to execute this query despite the performance unpredictability, use ALLOW FILTERING Perhaps you meant to use CQL 2? Try using the -2 option when starting cqlsh. With ALLOW FILTERING clause everything is OK. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
Jeremy Hanna created CASSANDRA-5471: --- Summary: Spelling and grammar errors in cassandra.yaml Key: CASSANDRA-5471 URL: https://issues.apache.org/jira/browse/CASSANDRA-5471 Project: Cassandra Issue Type: Bug Reporter: Jeremy Hanna Assignee: Jeremy Hanna Priority: Trivial There are various spelling and grammar errors in cassandra.yaml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
[ https://issues.apache.org/jira/browse/CASSANDRA-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Hanna updated CASSANDRA-5471: Attachment: 5471.txt Also tried to clarify a bit in the row cache description and standardize on _word_ instead of both that and *word*. Spelling and grammar errors in cassandra.yaml - Key: CASSANDRA-5471 URL: https://issues.apache.org/jira/browse/CASSANDRA-5471 Project: Cassandra Issue Type: Bug Reporter: Jeremy Hanna Assignee: Jeremy Hanna Priority: Trivial Attachments: 5471.txt There are various spelling and grammar errors in cassandra.yaml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
[ https://issues.apache.org/jira/browse/CASSANDRA-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631715#comment-13631715 ] Jeremy Hanna edited comment on CASSANDRA-5471 at 4/15/13 1:30 PM: -- Also tried to clarify a bit in the row cache description and standardize on _word_ instead of both that and *word*. Patch is against trunk. was (Author: jeromatron): Also tried to clarify a bit in the row cache description and standardize on _word_ instead of both that and *word*. Spelling and grammar errors in cassandra.yaml - Key: CASSANDRA-5471 URL: https://issues.apache.org/jira/browse/CASSANDRA-5471 Project: Cassandra Issue Type: Bug Reporter: Jeremy Hanna Assignee: Jeremy Hanna Priority: Trivial Attachments: 5471.txt There are various spelling and grammar errors in cassandra.yaml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
[
https://issues.apache.org/jira/browse/CASSANDRA-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631715#comment-13631715
]
Jeremy Hanna edited comment on CASSANDRA-5471 at 4/15/13 1:31 PM:
--
Also tried to clarify a bit in the row cache description and standardize on
{noformat}_word_{noformat} instead of both that and {noformat}*word*{noformat}.
Patch is against trunk.
was (Author: jeromatron):
Also tried to clarify a bit in the row cache description and standardize on
_word_ instead of both that and *word*. Patch is against trunk.
Spelling and grammar errors in cassandra.yaml
-
Key: CASSANDRA-5471
URL: https://issues.apache.org/jira/browse/CASSANDRA-5471
Project: Cassandra
Issue Type: Bug
Reporter: Jeremy Hanna
Assignee: Jeremy Hanna
Priority: Trivial
Attachments: 5471.txt
There are various spelling and grammar errors in cassandra.yaml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
[
https://issues.apache.org/jira/browse/CASSANDRA-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631715#comment-13631715
]
Jeremy Hanna edited comment on CASSANDRA-5471 at 4/15/13 1:33 PM:
--
Also tried to clarify a bit in the row cache description and standardize on
\_word_ instead of both that and \*word*. Patch is against trunk.
was (Author: jeromatron):
Also tried to clarify a bit in the row cache description and standardize on
{noformat}_word_{noformat} instead of both that and {noformat}*word*{noformat}.
Patch is against trunk.
Spelling and grammar errors in cassandra.yaml
-
Key: CASSANDRA-5471
URL: https://issues.apache.org/jira/browse/CASSANDRA-5471
Project: Cassandra
Issue Type: Bug
Reporter: Jeremy Hanna
Assignee: Jeremy Hanna
Priority: Trivial
Attachments: 5471.txt
There are various spelling and grammar errors in cassandra.yaml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5472) Timeuuid with CLUSTERING ORDER DESC cannot be used with the dateOf CQL3 function
Gareth Collins created CASSANDRA-5472: - Summary: Timeuuid with CLUSTERING ORDER DESC cannot be used with the dateOf CQL3 function Key: CASSANDRA-5472 URL: https://issues.apache.org/jira/browse/CASSANDRA-5472 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.4 Reporter: Gareth Collins I originally raised this issue in the mailing lists: http://www.mail-archive.com/user@cassandra.apache.org/msg29185.html Here is what I tried: cqlsh:location create table test_y (message_id timeuuid, name text, PRIMARY KEY (name,message_id)); cqlsh:location insert into test_y (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_y (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_y (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_y (message_id,name) VALUES (now(),'foo'); cqlsh:location select dateOf(message_id) from test_y; dateOf(message_id) -- 2013-04-13 00:33:42-0400 2013-04-13 00:33:43-0400 2013-04-13 00:33:43-0400 2013-04-13 00:33:44-0400 cqlsh:location create table test_x (message_id timeuuid, name text, PRIMARY KEY (name,message_id)) WITH CLUSTERING ORDER BY (message_id DESC); cqlsh:location insert into test_x (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_x (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_x (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_x (message_id,name) VALUES (now(),'foo'); cqlsh:location insert into test_x (message_id,name) VALUES (now(),'foo'); cqlsh:location select dateOf(message_id) from test_x; Bad Request: Type error: org.apache.cassandra.cql3.statements.Selection$SimpleSelector@1e7318 cannot be passed as argument 0 of function dateof of type timeuuid It should be possible to use dateOf on message_id in table test_x -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
[ https://issues.apache.org/jira/browse/CASSANDRA-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Brosius updated CASSANDRA-5471: Reviewer: dbrosius Spelling and grammar errors in cassandra.yaml - Key: CASSANDRA-5471 URL: https://issues.apache.org/jira/browse/CASSANDRA-5471 Project: Cassandra Issue Type: Bug Reporter: Jeremy Hanna Assignee: Jeremy Hanna Priority: Trivial Attachments: 5471.txt There are various spelling and grammar errors in cassandra.yaml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5471) Spelling and grammar errors in cassandra.yaml
[ https://issues.apache.org/jira/browse/CASSANDRA-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631806#comment-13631806 ] Dave Brosius commented on CASSANDRA-5471: - +1 Spelling and grammar errors in cassandra.yaml - Key: CASSANDRA-5471 URL: https://issues.apache.org/jira/browse/CASSANDRA-5471 Project: Cassandra Issue Type: Bug Reporter: Jeremy Hanna Assignee: Jeremy Hanna Priority: Trivial Attachments: 5471.txt There are various spelling and grammar errors in cassandra.yaml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5426) Redesign repair messages
[ https://issues.apache.org/jira/browse/CASSANDRA-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631816#comment-13631816 ] Yuki Morishita commented on CASSANDRA-5426: --- Pushed completed version to: https://github.com/yukim/cassandra/commits/5426-2 This time, failure handling is implemented and added some unit tests for new classes. Redesign repair messages Key: CASSANDRA-5426 URL: https://issues.apache.org/jira/browse/CASSANDRA-5426 Project: Cassandra Issue Type: Improvement Reporter: Yuki Morishita Assignee: Yuki Morishita Priority: Minor Fix For: 2.0 Many people have been reporting 'repair hang' when something goes wrong. Two major causes of hang are 1) validation failure and 2) streaming failure. Currently, when those failures happen, the failed node would not respond back to the repair initiator. The goal of this ticket is to redesign message flows around repair so that repair never hang. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5424) nodetool repair -pr on all nodes won't repair the full range when a Keyspace isn't in all DC's
[
https://issues.apache.org/jira/browse/CASSANDRA-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631821#comment-13631821
]
Jonathan Ellis commented on CASSANDRA-5424:
---
As you know, I'm pretty leery of making anything but the most superficial
changes to 1.1.x at this point.
Am I correct that a workaround would be, only run repair against a node that
is an owner of the given range?
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
--
Key: CASSANDRA-5424
URL: https://issues.apache.org/jira/browse/CASSANDRA-5424
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.7
Reporter: Jeremiah Jordan
Assignee: Yuki Morishita
Priority: Critical
Fix For: 1.1.11
Attachments: 5424-1.1.txt
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
Commands follow, but the TL;DR of it, range
(127605887595351923798765477786913079296,0] doesn't get repaired between .38
node and .236 node until I run a repair, no -pr, on .38
It seems like primary arnge calculation doesn't take schema into account, but
deciding who to ask for merkle tree's from does.
{noformat}
Address DC RackStatus State LoadOwns
Token
127605887595351923798765477786913079296
10.72.111.225 Cassandra rack1 Up Normal 455.87 KB 25.00%
0
10.2.29.38 Analytics rack1 Up Normal 40.74 MB25.00%
42535295865117307932921825928971026432
10.46.113.236 Analytics rack1 Up Normal 20.65 MB50.00%
127605887595351923798765477786913079296
create keyspace Keyspace1
with placement_strategy = 'NetworkTopologyStrategy'
and strategy_options = {Analytics : 2}
and durable_writes = true;
---
# nodetool -h 10.2.29.38 repair -pr Keyspace1 Standard1
[2013-04-03 15:46:58,000] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:47:00,881] Repair session b79b4850-9c75-11e2--8b5bf6ebea9e
for range (0,42535295865117307932921825928971026432] finished
[2013-04-03 15:47:00,881] Repair command #1 finished
root@ip-10-2-29-38:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,009 AntiEntropyService.java
(line 676) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] new session: will
sync a1/10.2.29.38, /10.46.113.236 on range
(0,42535295865117307932921825928971026432] for Keyspace1.[Standard1]
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,015 AntiEntropyService.java
(line 881) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] requesting merkle
trees for Standard1 (to [/10.46.113.236, a1/10.2.29.38])
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,202 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from /10.46.113.236
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,697 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from a1/10.2.29.38
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,879 AntiEntropyService.java
(line 1015) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Endpoints
/10.46.113.236 and a1/10.2.29.38 are consistent for Standard1
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 788) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Standard1 is fully
synced
INFO [AntiEntropySessions:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 722) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] session completed
successfully
root@ip-10-46-113-236:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropyStage:1] 2013-04-03 15:46:59,944 AntiEntropyService.java
(line 244) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Sending completed
merkle tree to /10.2.29.38 for (Keyspace1,Standard1)
root@ip-10-72-111-225:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
root@ip-10-72-111-225:/home/ubuntu#
---
# nodetool -h 10.46.113.236 repair -pr Keyspace1 Standard1
[2013-04-03 15:48:00,274] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:48:02,032] Repair session dcb91540-9c75-11e2--a839ee2ccbef
for range
[jira] [Commented] (CASSANDRA-5424) nodetool repair -pr on all nodes won't repair the full range when a Keyspace isn't in all DC's
[
https://issues.apache.org/jira/browse/CASSANDRA-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631831#comment-13631831
]
Jeremiah Jordan commented on CASSANDRA-5424:
The work around is always use repair no -pr
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
--
Key: CASSANDRA-5424
URL: https://issues.apache.org/jira/browse/CASSANDRA-5424
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.7
Reporter: Jeremiah Jordan
Assignee: Yuki Morishita
Priority: Critical
Fix For: 1.1.11
Attachments: 5424-1.1.txt
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
Commands follow, but the TL;DR of it, range
(127605887595351923798765477786913079296,0] doesn't get repaired between .38
node and .236 node until I run a repair, no -pr, on .38
It seems like primary arnge calculation doesn't take schema into account, but
deciding who to ask for merkle tree's from does.
{noformat}
Address DC RackStatus State LoadOwns
Token
127605887595351923798765477786913079296
10.72.111.225 Cassandra rack1 Up Normal 455.87 KB 25.00%
0
10.2.29.38 Analytics rack1 Up Normal 40.74 MB25.00%
42535295865117307932921825928971026432
10.46.113.236 Analytics rack1 Up Normal 20.65 MB50.00%
127605887595351923798765477786913079296
create keyspace Keyspace1
with placement_strategy = 'NetworkTopologyStrategy'
and strategy_options = {Analytics : 2}
and durable_writes = true;
---
# nodetool -h 10.2.29.38 repair -pr Keyspace1 Standard1
[2013-04-03 15:46:58,000] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:47:00,881] Repair session b79b4850-9c75-11e2--8b5bf6ebea9e
for range (0,42535295865117307932921825928971026432] finished
[2013-04-03 15:47:00,881] Repair command #1 finished
root@ip-10-2-29-38:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,009 AntiEntropyService.java
(line 676) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] new session: will
sync a1/10.2.29.38, /10.46.113.236 on range
(0,42535295865117307932921825928971026432] for Keyspace1.[Standard1]
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,015 AntiEntropyService.java
(line 881) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] requesting merkle
trees for Standard1 (to [/10.46.113.236, a1/10.2.29.38])
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,202 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from /10.46.113.236
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,697 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from a1/10.2.29.38
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,879 AntiEntropyService.java
(line 1015) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Endpoints
/10.46.113.236 and a1/10.2.29.38 are consistent for Standard1
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 788) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Standard1 is fully
synced
INFO [AntiEntropySessions:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 722) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] session completed
successfully
root@ip-10-46-113-236:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropyStage:1] 2013-04-03 15:46:59,944 AntiEntropyService.java
(line 244) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Sending completed
merkle tree to /10.2.29.38 for (Keyspace1,Standard1)
root@ip-10-72-111-225:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
root@ip-10-72-111-225:/home/ubuntu#
---
# nodetool -h 10.46.113.236 repair -pr Keyspace1 Standard1
[2013-04-03 15:48:00,274] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:48:02,032] Repair session dcb91540-9c75-11e2--a839ee2ccbef
for range
(42535295865117307932921825928971026432,127605887595351923798765477786913079296]
finished
[2013-04-03 15:48:02,033] Repair command #1 finished
root@ip-10-46-113-236:/home/ubuntu# grep
[jira] [Commented] (CASSANDRA-5051) Allow automatic cleanup after gc_grace
[ https://issues.apache.org/jira/browse/CASSANDRA-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631835#comment-13631835 ] Jonathan Ellis commented on CASSANDRA-5051: --- It still looks to me like the test is not checking range calculation for a node that is in the process of bootstrapping (i.e.: localhost is a Normal token; another node is Bootstrapping). I think I liked the isInRanges implementation better before the if it's empty, assume we're bootstrapping refactor. At the least I'd add an assert to make sure empty really does imply isBoostrapping. Allow automatic cleanup after gc_grace -- Key: CASSANDRA-5051 URL: https://issues.apache.org/jira/browse/CASSANDRA-5051 Project: Cassandra Issue Type: New Feature Components: Core Reporter: Brandon Williams Assignee: Vijay Labels: vnodes Fix For: 2.0 Attachments: 0001-5051-v4.patch, 0001-5051-with-test-fixes.patch, 0001-CASSANDRA-5051.patch, 0002-5051-remove-upgradesstable.patch, 0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch, 5051-v2.txt When using vnodes, after adding a new node you have to run cleanup on all the machines, because you don't know which are affected and chances are it was most if not all of them. As an alternative to this intensive process, we could allow cleanup during compaction if the data is older than gc_grace (or perhaps some other time period since people tend to use gc_grace hacks to get rid of tombstones.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5424) nodetool repair -pr on all nodes won't repair the full range when a Keyspace isn't in all DC's
[
https://issues.apache.org/jira/browse/CASSANDRA-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631843#comment-13631843
]
Jonathan Ellis commented on CASSANDRA-5424:
---
Thinking about it, -pr really should NOT affect ranges that aren't replicated
to the node in question. That's the whole point of that option!
It looks to me like the real bug here is that repair is not NTS-aware: the
primary range for .38 for Keyspace1 should be
(127605887595351923798765477786913079296,
42535295865117307932921825928971026432], not (0,
42535295865117307932921825928971026432].
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
--
Key: CASSANDRA-5424
URL: https://issues.apache.org/jira/browse/CASSANDRA-5424
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.7
Reporter: Jeremiah Jordan
Assignee: Yuki Morishita
Priority: Critical
Fix For: 1.1.11
Attachments: 5424-1.1.txt
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
Commands follow, but the TL;DR of it, range
(127605887595351923798765477786913079296,0] doesn't get repaired between .38
node and .236 node until I run a repair, no -pr, on .38
It seems like primary arnge calculation doesn't take schema into account, but
deciding who to ask for merkle tree's from does.
{noformat}
Address DC RackStatus State LoadOwns
Token
127605887595351923798765477786913079296
10.72.111.225 Cassandra rack1 Up Normal 455.87 KB 25.00%
0
10.2.29.38 Analytics rack1 Up Normal 40.74 MB25.00%
42535295865117307932921825928971026432
10.46.113.236 Analytics rack1 Up Normal 20.65 MB50.00%
127605887595351923798765477786913079296
create keyspace Keyspace1
with placement_strategy = 'NetworkTopologyStrategy'
and strategy_options = {Analytics : 2}
and durable_writes = true;
---
# nodetool -h 10.2.29.38 repair -pr Keyspace1 Standard1
[2013-04-03 15:46:58,000] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:47:00,881] Repair session b79b4850-9c75-11e2--8b5bf6ebea9e
for range (0,42535295865117307932921825928971026432] finished
[2013-04-03 15:47:00,881] Repair command #1 finished
root@ip-10-2-29-38:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,009 AntiEntropyService.java
(line 676) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] new session: will
sync a1/10.2.29.38, /10.46.113.236 on range
(0,42535295865117307932921825928971026432] for Keyspace1.[Standard1]
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,015 AntiEntropyService.java
(line 881) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] requesting merkle
trees for Standard1 (to [/10.46.113.236, a1/10.2.29.38])
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,202 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from /10.46.113.236
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,697 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from a1/10.2.29.38
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,879 AntiEntropyService.java
(line 1015) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Endpoints
/10.46.113.236 and a1/10.2.29.38 are consistent for Standard1
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 788) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Standard1 is fully
synced
INFO [AntiEntropySessions:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 722) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] session completed
successfully
root@ip-10-46-113-236:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropyStage:1] 2013-04-03 15:46:59,944 AntiEntropyService.java
(line 244) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Sending completed
merkle tree to /10.2.29.38 for (Keyspace1,Standard1)
root@ip-10-72-111-225:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
root@ip-10-72-111-225:/home/ubuntu#
---
# nodetool -h 10.46.113.236 repair -pr Keyspace1 Standard1
[2013-04-03 15:48:00,274] Starting repair
[jira] [Created] (CASSANDRA-5473) Use mmaped buffered write for ldb segments
Radim Kolar created CASSANDRA-5473: -- Summary: Use mmaped buffered write for ldb segments Key: CASSANDRA-5473 URL: https://issues.apache.org/jira/browse/CASSANDRA-5473 Project: Cassandra Issue Type: Improvement Reporter: Radim Kolar it increases throughput, especially in compations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5473) Use mmaped buffered write for ldb segments
[ https://issues.apache.org/jira/browse/CASSANDRA-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radim Kolar updated CASSANDRA-5473: --- Attachment: leveldb.ods write only workload benchmark. Use mmaped buffered write for ldb segments -- Key: CASSANDRA-5473 URL: https://issues.apache.org/jira/browse/CASSANDRA-5473 Project: Cassandra Issue Type: Improvement Reporter: Radim Kolar Labels: performance Attachments: leveldb.ods it increases throughput, especially in compations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5473) Use mmaped buffered write for ldb segments
[ https://issues.apache.org/jira/browse/CASSANDRA-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631997#comment-13631997 ] Jonathan Ellis commented on CASSANDRA-5473: --- Sounds similar to CASSANDRA-4338. Use mmaped buffered write for ldb segments -- Key: CASSANDRA-5473 URL: https://issues.apache.org/jira/browse/CASSANDRA-5473 Project: Cassandra Issue Type: Improvement Reporter: Radim Kolar Labels: performance Attachments: leveldb.ods it increases throughput, especially in compations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5473) Use mmaped buffered write for ldb segments
[ https://issues.apache.org/jira/browse/CASSANDRA-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631998#comment-13631998 ] Jonathan Ellis commented on CASSANDRA-5473: --- I'm not sure what I'm looking at in this .ods. Are the different rows different test runs? Use mmaped buffered write for ldb segments -- Key: CASSANDRA-5473 URL: https://issues.apache.org/jira/browse/CASSANDRA-5473 Project: Cassandra Issue Type: Improvement Reporter: Radim Kolar Labels: performance Attachments: leveldb.ods it increases throughput, especially in compations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5473) Use mmaped buffered write for ldb segments
[ https://issues.apache.org/jira/browse/CASSANDRA-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632037#comment-13632037 ] Radim Kolar commented on CASSANDRA-5473: yes, every line in one test run to check variations between runs. Use mmaped buffered write for ldb segments -- Key: CASSANDRA-5473 URL: https://issues.apache.org/jira/browse/CASSANDRA-5473 Project: Cassandra Issue Type: Improvement Reporter: Radim Kolar Labels: performance Attachments: leveldb.ods it increases throughput, especially in compations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5473) Use mmaped buffered write for ldb segments
[ https://issues.apache.org/jira/browse/CASSANDRA-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632044#comment-13632044 ] Radim Kolar commented on CASSANDRA-5473: i have not checked other patch code but you have to create file part, mmap it, write to memory, unmap, enlarge file, mmap next segment, write, unmap and truncate file to desired size. Use mmaped buffered write for ldb segments -- Key: CASSANDRA-5473 URL: https://issues.apache.org/jira/browse/CASSANDRA-5473 Project: Cassandra Issue Type: Improvement Reporter: Radim Kolar Labels: performance Attachments: leveldb.ods it increases throughput, especially in compations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5468) Prepared statements from default keyspace are broken
[
https://issues.apache.org/jira/browse/CASSANDRA-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632141#comment-13632141
]
Pierre Chalamet commented on CASSANDRA-5468:
works for me. Thanks.
Prepared statements from default keyspace are broken
Key: CASSANDRA-5468
URL: https://issues.apache.org/jira/browse/CASSANDRA-5468
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.4
Environment: Windows 8 x64, java 1.7.0_11 x64
Reporter: Pierre Chalamet
Assignee: Aleksey Yeschenko
Fix For: 1.2.5
Attachments: 5468.txt
Tested under CQL 3 binary protocol.
Preparing a statement from the default keyspace of the connection (statement
scoped with keyspace) and then running it will always throw the error no
keyspace has been specified.
{code}
Exec: CREATE KEYSPACE Tests WITH replication = {'class': 'SimpleStrategy',
'replication_factor' : 1}
Exec: CREATE TABLE Tests.AllTypes (a int, b int, primary key (a))
Prepare: insert into Tests.AllTypes (a, b) values (?, ?)
{code}
Exec prepared statement and exception no keyspace has been specified is
thrown.
Doing a use Tests before preparing the statement solves the issue.
This used to work in 1.2.3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[2/3] git commit: generify
generify
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b7ef940e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b7ef940e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b7ef940e
Branch: refs/heads/trunk
Commit: b7ef940ef20494ddc50e4b751b9afec098c4842f
Parents: 1f21bbe
Author: Jonathan Ellis jbel...@apache.org
Authored: Mon Apr 15 15:45:01 2013 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Mon Apr 15 15:45:09 2013 -0500
--
.../apache/cassandra/cache/SerializingCache.java |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/b7ef940e/src/java/org/apache/cassandra/cache/SerializingCache.java
--
diff --git a/src/java/org/apache/cassandra/cache/SerializingCache.java
b/src/java/org/apache/cassandra/cache/SerializingCache.java
index 6047bed..c7430d2 100644
--- a/src/java/org/apache/cassandra/cache/SerializingCache.java
+++ b/src/java/org/apache/cassandra/cache/SerializingCache.java
@@ -154,7 +154,7 @@ public class SerializingCacheK, V implements ICacheK, V
map.clear();
}
-public V get(Object key)
+public V get(K key)
{
RefCountedMemory mem = map.get(key);
if (mem == null)
[1/3] git commit: generify
Updated Branches:
refs/heads/cassandra-1.2 1f21bbe18 - b7ef940ef
refs/heads/trunk a9d6aefd4 - 9ee4deb9c
generify
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b7ef940e
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b7ef940e
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b7ef940e
Branch: refs/heads/cassandra-1.2
Commit: b7ef940ef20494ddc50e4b751b9afec098c4842f
Parents: 1f21bbe
Author: Jonathan Ellis jbel...@apache.org
Authored: Mon Apr 15 15:45:01 2013 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Mon Apr 15 15:45:09 2013 -0500
--
.../apache/cassandra/cache/SerializingCache.java |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/b7ef940e/src/java/org/apache/cassandra/cache/SerializingCache.java
--
diff --git a/src/java/org/apache/cassandra/cache/SerializingCache.java
b/src/java/org/apache/cassandra/cache/SerializingCache.java
index 6047bed..c7430d2 100644
--- a/src/java/org/apache/cassandra/cache/SerializingCache.java
+++ b/src/java/org/apache/cassandra/cache/SerializingCache.java
@@ -154,7 +154,7 @@ public class SerializingCacheK, V implements ICacheK, V
map.clear();
}
-public V get(Object key)
+public V get(K key)
{
RefCountedMemory mem = map.get(key);
if (mem == null)
[3/3] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9ee4deb9 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9ee4deb9 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9ee4deb9 Branch: refs/heads/trunk Commit: 9ee4deb9cefe4b377cc5e5f34603d71fdf7ee2ce Parents: a9d6aef b7ef940 Author: Jonathan Ellis jbel...@apache.org Authored: Mon Apr 15 15:46:34 2013 -0500 Committer: Jonathan Ellis jbel...@apache.org Committed: Mon Apr 15 15:46:34 2013 -0500 -- .../apache/cassandra/cache/SerializingCache.java |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --
[jira] [Commented] (CASSANDRA-5468) Prepared statements from default keyspace are broken
[
https://issues.apache.org/jira/browse/CASSANDRA-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632185#comment-13632185
]
Jonathan Ellis commented on CASSANDRA-5468:
---
+1
Prepared statements from default keyspace are broken
Key: CASSANDRA-5468
URL: https://issues.apache.org/jira/browse/CASSANDRA-5468
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.4
Environment: Windows 8 x64, java 1.7.0_11 x64
Reporter: Pierre Chalamet
Assignee: Aleksey Yeschenko
Fix For: 1.2.5
Attachments: 5468.txt
Tested under CQL 3 binary protocol.
Preparing a statement from the default keyspace of the connection (statement
scoped with keyspace) and then running it will always throw the error no
keyspace has been specified.
{code}
Exec: CREATE KEYSPACE Tests WITH replication = {'class': 'SimpleStrategy',
'replication_factor' : 1}
Exec: CREATE TABLE Tests.AllTypes (a int, b int, primary key (a))
Prepare: insert into Tests.AllTypes (a, b) values (?, ?)
{code}
Exec prepared statement and exception no keyspace has been specified is
thrown.
Doing a use Tests before preparing the statement solves the issue.
This used to work in 1.2.3.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3919) Dropping a column should do more than just remove the definition
[
https://issues.apache.org/jira/browse/CASSANDRA-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632187#comment-13632187
]
Jonathan Ellis commented on CASSANDRA-3919:
---
+1
Dropping a column should do more than just remove the definition
Key: CASSANDRA-3919
URL: https://issues.apache.org/jira/browse/CASSANDRA-3919
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Jonathan Ellis
Assignee: Aleksey Yeschenko
Labels: compaction, cql
Fix For: 2.0
Dropping a column should:
- immediately make it unavailable for {{SELECT}}, including {{SELECT *}}
- eventually (i.e., post-compaction) reclaim the space formerly used by that
column
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4131) Integrate Hive support to be in core cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632206#comment-13632206 ] Dmitry Vasilenko commented on CASSANDRA-4131: - This can be of some interest: https://github.com/dvasilen/Hive-Cassandra/blob/HIVE-0.10.0-CASSANDRA-1.2.4/release/hive-0.10.0-cassandra-1.2.4.jar https://github.com/dvasilen/Hive-Cassandra/blob/HIVE-0.9.0-CASSANDRA-1.2.4/release/hive-0.9.0-cassandra-1.2.4.jar I was testing Cassandra 1.2.3/Hive 0.10.0/HCatalog 0.5.0 and had to recompile the code of the storage handler to make it work with the latest versions. Integrate Hive support to be in core cassandra -- Key: CASSANDRA-4131 URL: https://issues.apache.org/jira/browse/CASSANDRA-4131 Project: Cassandra Issue Type: Improvement Reporter: Jeremy Hanna Assignee: Edward Capriolo Labels: hadoop, hive The standalone hive support (at https://github.com/riptano/hive) would be great to have in-tree so that people don't have to go out to github to download it and wonder if it's a left-for-dead external shim. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5474) failure when passing null parameter to prepared statement
Pierre Chalamet created CASSANDRA-5474:
--
Summary: failure when passing null parameter to prepared statement
Key: CASSANDRA-5474
URL: https://issues.apache.org/jira/browse/CASSANDRA-5474
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.4
Environment: windows 8 x64, 1.7.0_11-b21 x64
Reporter: Pierre Chalamet
I have a failure when passing a null parameter to the prepared statement bellow
when going through the cql 3 bin protocol:
{code}
Exec: CREATE KEYSPACE Tests WITH replication = {'class': 'SimpleStrategy',
'replication_factor' : 1}
Exec: CREATE TABLE Tests.AllTypes (a int, b int, primary key (a))
Prepare: insert into Tests.AllTypes (a, b) values (?, ?)
{code}
Passing a=1 and b=null cause the following error:
{code}
DEBUG 23:07:23,315 Responding: RESULT PREPARED 59b3d6baed67d5c0a3ced29ebb4277c5
[a(tests, alltypes), org.apache.cassandra.db.marshal.Int32Type][b(tests,
alltypes), org.apache.cassandra.db.marshal.Int32Type]
DEBUG 23:07:23,292 Compaction buckets are []
DEBUG 23:07:23,336 Received: EXECUTE 59b3d6baed67d5c0a3ced29ebb4277c5 with 2
values at consistency QUORUM
ERROR 23:07:23,338 Unexpected exception during request
java.lang.NullPointerException
at org.apache.cassandra.db.marshal.Int32Type.validate(Int32Type.java:95)
at
org.apache.cassandra.cql3.Constants$Marker.bindAndGet(Constants.java:257)
at
org.apache.cassandra.cql3.Constants$Setter.execute(Constants.java:282)
at
org.apache.cassandra.cql3.statements.UpdateStatement.mutationForKey(UpdateStatement.java:250)
at
org.apache.cassandra.cql3.statements.UpdateStatement.getMutations(UpdateStatement.java:133)
at
org.apache.cassandra.cql3.statements.ModificationStatement.execute(ModificationStatement.java:92)
at
org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:132)
at
org.apache.cassandra.cql3.QueryProcessor.processPrepared(QueryProcessor.java:254)
at
org.apache.cassandra.transport.messages.ExecuteMessage.execute(ExecuteMessage.java:122)
at
org.apache.cassandra.transport.Message$Dispatcher.messageReceived(Message.java:287)
at
org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:75)
at
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:565)
at
org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:793)
at
org.jboss.netty.handler.execution.ChannelUpstreamEventRunnable.doRun(ChannelUpstreamEventRunnable.java:45)
at
org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
DEBUG 23:07:23,337 No tasks available
DEBUG 23:07:23,341 request complete
DEBUG 23:07:23,343 Responding: ERROR SERVER_ERROR:
java.lang.NullPointerException
{code}
When serializing value for b, a bytes array of len -1 is transmitted
(accordingly to the spec):
{code}
[bytes] A [int] n, followed by n bytes if n = 0. If n 0,
no byte should follow and the value represented is `null`.
{code}
CASSANDRA-5081 added support for null params. Am I doing something wrong there
? Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4131) Integrate Hive support to be in core cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632214#comment-13632214 ] Jonathan Ellis commented on CASSANDRA-4131: --- Is that from Jake's branch? I'm kind of surprised if you didn't need more than a recompile. Integrate Hive support to be in core cassandra -- Key: CASSANDRA-4131 URL: https://issues.apache.org/jira/browse/CASSANDRA-4131 Project: Cassandra Issue Type: Improvement Reporter: Jeremy Hanna Assignee: Edward Capriolo Labels: hadoop, hive The standalone hive support (at https://github.com/riptano/hive) would be great to have in-tree so that people don't have to go out to github to download it and wonder if it's a left-for-dead external shim. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Fix preparing statements when current keyspace is not set
Updated Branches:
refs/heads/cassandra-1.2 b7ef940ef - cf532fe59
Fix preparing statements when current keyspace is not set
patch by Aleksey Yeschenko; reviewed by Jonathan Ellis for
CASSANDRA-5468
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cf532fe5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cf532fe5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cf532fe5
Branch: refs/heads/cassandra-1.2
Commit: cf532fe59a6aff9e3f914e370471e9564898e391
Parents: b7ef940
Author: Aleksey Yeschenko alek...@apache.org
Authored: Tue Apr 16 00:54:42 2013 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Tue Apr 16 00:54:42 2013 +0300
--
CHANGES.txt|1 +
.../org/apache/cassandra/cql3/QueryProcessor.java |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/cf532fe5/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index b17d8e1..008a9fb 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -4,6 +4,7 @@
(CASSANDRA-5445)
* Allow empty blob literals in CQL3 (CASSANDRA-5452)
* Fix streaming RangeTombstones at column index boundary (CASSANDRA-5418)
+ * Fix preparing statements when current keyspace is not set (CASSANDRA-5468)
Merged from 1.1:
* Fix trying to load deleted row into row cache on startup (CASSANDRA-4463)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/cf532fe5/src/java/org/apache/cassandra/cql3/QueryProcessor.java
--
diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
index 7dcd467..cd4ff25 100644
--- a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
+++ b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
@@ -205,7 +205,7 @@ public class QueryProcessor
logger.trace(CQL QUERY: {}, queryString);
ParsedStatement.Prepared prepared = getStatement(queryString,
clientState);
-ResultMessage.Prepared msg = storePreparedStatement(queryString,
clientState.getKeyspace(), prepared, forThrift);
+ResultMessage.Prepared msg = storePreparedStatement(queryString,
clientState.getRawKeyspace(), prepared, forThrift);
assert prepared.statement.getBoundsTerms() ==
prepared.boundNames.size();
return msg;
[1/2] git commit: Fix preparing statements when current keyspace is not set
Updated Branches:
refs/heads/trunk 9ee4deb9c - 6b332ddcb
Fix preparing statements when current keyspace is not set
patch by Aleksey Yeschenko; reviewed by Jonathan Ellis for
CASSANDRA-5468
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cf532fe5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cf532fe5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cf532fe5
Branch: refs/heads/trunk
Commit: cf532fe59a6aff9e3f914e370471e9564898e391
Parents: b7ef940
Author: Aleksey Yeschenko alek...@apache.org
Authored: Tue Apr 16 00:54:42 2013 +0300
Committer: Aleksey Yeschenko alek...@apache.org
Committed: Tue Apr 16 00:54:42 2013 +0300
--
CHANGES.txt|1 +
.../org/apache/cassandra/cql3/QueryProcessor.java |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/cf532fe5/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index b17d8e1..008a9fb 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -4,6 +4,7 @@
(CASSANDRA-5445)
* Allow empty blob literals in CQL3 (CASSANDRA-5452)
* Fix streaming RangeTombstones at column index boundary (CASSANDRA-5418)
+ * Fix preparing statements when current keyspace is not set (CASSANDRA-5468)
Merged from 1.1:
* Fix trying to load deleted row into row cache on startup (CASSANDRA-4463)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/cf532fe5/src/java/org/apache/cassandra/cql3/QueryProcessor.java
--
diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
index 7dcd467..cd4ff25 100644
--- a/src/java/org/apache/cassandra/cql3/QueryProcessor.java
+++ b/src/java/org/apache/cassandra/cql3/QueryProcessor.java
@@ -205,7 +205,7 @@ public class QueryProcessor
logger.trace(CQL QUERY: {}, queryString);
ParsedStatement.Prepared prepared = getStatement(queryString,
clientState);
-ResultMessage.Prepared msg = storePreparedStatement(queryString,
clientState.getKeyspace(), prepared, forThrift);
+ResultMessage.Prepared msg = storePreparedStatement(queryString,
clientState.getRawKeyspace(), prepared, forThrift);
assert prepared.statement.getBoundsTerms() ==
prepared.boundNames.size();
return msg;
[jira] [Commented] (CASSANDRA-5435) Support range tombstones from thrift
[ https://issues.apache.org/jira/browse/CASSANDRA-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632280#comment-13632280 ] Aleksey Yeschenko commented on CASSANDRA-5435: -- Or test/system/test_thrift_server.py Support range tombstones from thrift Key: CASSANDRA-5435 URL: https://issues.apache.org/jira/browse/CASSANDRA-5435 Project: Cassandra Issue Type: New Feature Components: API Reporter: Edward Capriolo Assignee: Edward Capriolo Priority: Minor I see a RangeTomstone test and methods in row mutation. However thrift's validate method throws exception when Deletion's have a slice predicate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: fix message spelling
Updated Branches:
refs/heads/cassandra-1.1 868e7eb3c - 6db8ac389
fix message spelling
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6db8ac38
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6db8ac38
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6db8ac38
Branch: refs/heads/cassandra-1.1
Commit: 6db8ac3898f1263dd33f159835999cdfd1f09a07
Parents: 868e7eb
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 19:14:08 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 19:14:08 2013 -0400
--
.../statements/CreateColumnFamilyStatement.java|2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/6db8ac38/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
--
diff --git
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
index cffb006..972e947 100644
---
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
+++
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
@@ -258,7 +258,7 @@ public class CreateColumnFamilyStatement extends
SchemaAlteringStatement
{
AbstractType type = columns.get(t);
if (type == null)
-throw new InvalidRequestException(String.format(Unkown
definition %s referenced in PRIMARY KEY, t));
+throw new InvalidRequestException(String.format(Unknown
definition %s referenced in PRIMARY KEY, t));
columns.remove(t);
Boolean isReversed = definedOrdering.get(t);
return isReversed != null isReversed ?
ReversedType.getInstance(type) : type;
[1/2] git commit: fix message spelling
Updated Branches:
refs/heads/cassandra-1.2 cf532fe59 - b4ebbae67
fix message spelling
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6db8ac38
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6db8ac38
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6db8ac38
Branch: refs/heads/cassandra-1.2
Commit: 6db8ac3898f1263dd33f159835999cdfd1f09a07
Parents: 868e7eb
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 19:14:08 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 19:14:08 2013 -0400
--
.../statements/CreateColumnFamilyStatement.java|2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/6db8ac38/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
--
diff --git
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
index cffb006..972e947 100644
---
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
+++
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
@@ -258,7 +258,7 @@ public class CreateColumnFamilyStatement extends
SchemaAlteringStatement
{
AbstractType type = columns.get(t);
if (type == null)
-throw new InvalidRequestException(String.format(Unkown
definition %s referenced in PRIMARY KEY, t));
+throw new InvalidRequestException(String.format(Unknown
definition %s referenced in PRIMARY KEY, t));
columns.remove(t);
Boolean isReversed = definedOrdering.get(t);
return isReversed != null isReversed ?
ReversedType.getInstance(type) : type;
[2/2] git commit: Merge branch 'cassandra-1.1' into cassandra-1.2
Merge branch 'cassandra-1.1' into cassandra-1.2
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b4ebbae6
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b4ebbae6
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b4ebbae6
Branch: refs/heads/cassandra-1.2
Commit: b4ebbae67922dc9e8be0d6c607eb382f7c3daab9
Parents: cf532fe 6db8ac3
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 19:18:32 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 19:18:32 2013 -0400
--
.../statements/CreateColumnFamilyStatement.java|3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/b4ebbae6/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
--
diff --cc
src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
index f2c3d6a,972e947..1dfdc74
---
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
+++
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
@@@ -342,9 -258,7 +342,10 @@@ public class CreateColumnFamilyStatemen
{
AbstractType type = columns.get(t);
if (type == null)
- throw new InvalidRequestException(String.format(Unkown
definition %s referenced in PRIMARY KEY, t));
+ throw new InvalidRequestException(String.format(Unknown
definition %s referenced in PRIMARY KEY, t));
+if (type instanceof CollectionType)
+throw new InvalidRequestException(String.format(Invalid
collection type for PRIMARY KEY component %s, t));
++
columns.remove(t);
Boolean isReversed = definedOrdering.get(t);
return isReversed != null isReversed ?
ReversedType.getInstance(type) : type;
[1/3] git commit: fix message spelling
Updated Branches:
refs/heads/trunk 6b332ddcb - 841ae04f8
fix message spelling
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6db8ac38
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6db8ac38
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6db8ac38
Branch: refs/heads/trunk
Commit: 6db8ac3898f1263dd33f159835999cdfd1f09a07
Parents: 868e7eb
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 19:14:08 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 19:14:08 2013 -0400
--
.../statements/CreateColumnFamilyStatement.java|2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/6db8ac38/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
--
diff --git
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
index cffb006..972e947 100644
---
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
+++
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
@@ -258,7 +258,7 @@ public class CreateColumnFamilyStatement extends
SchemaAlteringStatement
{
AbstractType type = columns.get(t);
if (type == null)
-throw new InvalidRequestException(String.format(Unkown
definition %s referenced in PRIMARY KEY, t));
+throw new InvalidRequestException(String.format(Unknown
definition %s referenced in PRIMARY KEY, t));
columns.remove(t);
Boolean isReversed = definedOrdering.get(t);
return isReversed != null isReversed ?
ReversedType.getInstance(type) : type;
[2/3] git commit: Merge branch 'cassandra-1.1' into cassandra-1.2
Merge branch 'cassandra-1.1' into cassandra-1.2
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b4ebbae6
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b4ebbae6
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b4ebbae6
Branch: refs/heads/trunk
Commit: b4ebbae67922dc9e8be0d6c607eb382f7c3daab9
Parents: cf532fe 6db8ac3
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 19:18:32 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 19:18:32 2013 -0400
--
.../statements/CreateColumnFamilyStatement.java|3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/b4ebbae6/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
--
diff --cc
src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
index f2c3d6a,972e947..1dfdc74
---
a/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
+++
b/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java
@@@ -342,9 -258,7 +342,10 @@@ public class CreateColumnFamilyStatemen
{
AbstractType type = columns.get(t);
if (type == null)
- throw new InvalidRequestException(String.format(Unkown
definition %s referenced in PRIMARY KEY, t));
+ throw new InvalidRequestException(String.format(Unknown
definition %s referenced in PRIMARY KEY, t));
+if (type instanceof CollectionType)
+throw new InvalidRequestException(String.format(Invalid
collection type for PRIMARY KEY component %s, t));
++
columns.remove(t);
Boolean isReversed = definedOrdering.get(t);
return isReversed != null isReversed ?
ReversedType.getInstance(type) : type;
[3/3] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/841ae04f Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/841ae04f Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/841ae04f Branch: refs/heads/trunk Commit: 841ae04f80275ed7f097e5a20e4a442d22114f77 Parents: 6b332dd b4ebbae Author: Dave Brosius dbros...@apache.org Authored: Mon Apr 15 19:19:36 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Mon Apr 15 19:19:36 2013 -0400 -- .../statements/CreateColumnFamilyStatement.java|3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/841ae04f/src/java/org/apache/cassandra/cql3/statements/CreateColumnFamilyStatement.java --
[jira] [Commented] (CASSANDRA-4131) Integrate Hive support to be in core cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632372#comment-13632372 ] Dmitry Vasilenko commented on CASSANDRA-4131: - I had to refactor the code slightly to conform to the new APIs but other than that it was relatively straightforward. Integrate Hive support to be in core cassandra -- Key: CASSANDRA-4131 URL: https://issues.apache.org/jira/browse/CASSANDRA-4131 Project: Cassandra Issue Type: Improvement Reporter: Jeremy Hanna Assignee: Edward Capriolo Labels: hadoop, hive The standalone hive support (at https://github.com/riptano/hive) would be great to have in-tree so that people don't have to go out to github to download it and wonder if it's a left-for-dead external shim. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5475) remove dead classes (ArrayUtil.java, CreationTimeAwareFuture.java)
Dave Brosius created CASSANDRA-5475: --- Summary: remove dead classes (ArrayUtil.java, CreationTimeAwareFuture.java) Key: CASSANDRA-5475 URL: https://issues.apache.org/jira/browse/CASSANDRA-5475 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.4 Reporter: Dave Brosius Priority: Trivial Fix For: 1.2.5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5475) remove dead classes (ArrayUtil.java, CreationTimeAwareFuture.java)
[ https://issues.apache.org/jira/browse/CASSANDRA-5475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Brosius updated CASSANDRA-5475: Attachment: 5475.txt remove dead classes (ArrayUtil.java, CreationTimeAwareFuture.java) -- Key: CASSANDRA-5475 URL: https://issues.apache.org/jira/browse/CASSANDRA-5475 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.4 Reporter: Dave Brosius Priority: Trivial Fix For: 1.2.5 Attachments: 5475.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-5474) failure when passing null parameter to prepared statement
[
https://issues.apache.org/jira/browse/CASSANDRA-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko resolved CASSANDRA-5474.
--
Resolution: Invalid
You are doing something wrong.
Just tested the same scenario and was able to insert null successfully (also
binary protocol). And my client serializes null as signed int32 -1
[0xff,0xff,0xff,0xff]. You probably got your null-serialization code wrong.
failure when passing null parameter to prepared statement
-
Key: CASSANDRA-5474
URL: https://issues.apache.org/jira/browse/CASSANDRA-5474
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.2.4
Environment: windows 8 x64, 1.7.0_11-b21 x64
Reporter: Pierre Chalamet
I have a failure when passing a null parameter to the prepared statement
bellow when going through the cql 3 bin protocol:
{code}
Exec: CREATE KEYSPACE Tests WITH replication = {'class': 'SimpleStrategy',
'replication_factor' : 1}
Exec: CREATE TABLE Tests.AllTypes (a int, b int, primary key (a))
Prepare: insert into Tests.AllTypes (a, b) values (?, ?)
{code}
Passing a=1 and b=null cause the following error:
{code}
DEBUG 23:07:23,315 Responding: RESULT PREPARED
59b3d6baed67d5c0a3ced29ebb4277c5 [a(tests, alltypes),
org.apache.cassandra.db.marshal.Int32Type][b(tests, alltypes),
org.apache.cassandra.db.marshal.Int32Type]
DEBUG 23:07:23,292 Compaction buckets are []
DEBUG 23:07:23,336 Received: EXECUTE 59b3d6baed67d5c0a3ced29ebb4277c5 with 2
values at consistency QUORUM
ERROR 23:07:23,338 Unexpected exception during request
java.lang.NullPointerException
at
org.apache.cassandra.db.marshal.Int32Type.validate(Int32Type.java:95)
at
org.apache.cassandra.cql3.Constants$Marker.bindAndGet(Constants.java:257)
at
org.apache.cassandra.cql3.Constants$Setter.execute(Constants.java:282)
at
org.apache.cassandra.cql3.statements.UpdateStatement.mutationForKey(UpdateStatement.java:250)
at
org.apache.cassandra.cql3.statements.UpdateStatement.getMutations(UpdateStatement.java:133)
at
org.apache.cassandra.cql3.statements.ModificationStatement.execute(ModificationStatement.java:92)
at
org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:132)
at
org.apache.cassandra.cql3.QueryProcessor.processPrepared(QueryProcessor.java:254)
at
org.apache.cassandra.transport.messages.ExecuteMessage.execute(ExecuteMessage.java:122)
at
org.apache.cassandra.transport.Message$Dispatcher.messageReceived(Message.java:287)
at
org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:75)
at
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:565)
at
org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:793)
at
org.jboss.netty.handler.execution.ChannelUpstreamEventRunnable.doRun(ChannelUpstreamEventRunnable.java:45)
at
org.jboss.netty.handler.execution.ChannelEventRunnable.run(ChannelEventRunnable.java:69)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
DEBUG 23:07:23,337 No tasks available
DEBUG 23:07:23,341 request complete
DEBUG 23:07:23,343 Responding: ERROR SERVER_ERROR:
java.lang.NullPointerException
{code}
When serializing value for b, a bytes array of len -1 is transmitted
(accordingly to the spec):
{code}
[bytes] A [int] n, followed by n bytes if n = 0. If n 0,
no byte should follow and the value represented is `null`.
{code}
CASSANDRA-5081 added support for null params. Am I doing something wrong
there ? Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5475) remove dead classes (ArrayUtil.java, CreationTimeAwareFuture.java)
[ https://issues.apache.org/jira/browse/CASSANDRA-5475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632469#comment-13632469 ] Aleksey Yeschenko commented on CASSANDRA-5475: -- +1 remove dead classes (ArrayUtil.java, CreationTimeAwareFuture.java) -- Key: CASSANDRA-5475 URL: https://issues.apache.org/jira/browse/CASSANDRA-5475 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.4 Reporter: Dave Brosius Priority: Trivial Fix For: 1.2.5 Attachments: 5475.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: remove unused classes ArrayUtil.java/CreationTimeAwareFuture.java patch by dbrosius reviewed by ayeschenko for CASSANDRA-5474
Updated Branches:
refs/heads/cassandra-1.2 b4ebbae67 - 40e7aba6b
remove unused classes ArrayUtil.java/CreationTimeAwareFuture.java
patch by dbrosius reviewed by ayeschenko for CASSANDRA-5474
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/40e7aba6
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/40e7aba6
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/40e7aba6
Branch: refs/heads/cassandra-1.2
Commit: 40e7aba6b2f694017df5fbba90fd44caa0d43fc9
Parents: b4ebbae
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 22:37:16 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 22:37:16 2013 -0400
--
.../concurrent/CreationTimeAwareFuture.java| 73 ---
.../org/apache/cassandra/utils/FBUtilities.java| 27 --
.../org/apache/cassandra/utils/obs/ArrayUtil.java | 39
3 files changed, 0 insertions(+), 139 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/40e7aba6/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
--
diff --git
a/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
b/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
deleted file mode 100644
index d9d8185..000
--- a/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
+++ /dev/null
@@ -1,73 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * License); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.cassandra.concurrent;
-
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.Future;
-import java.util.concurrent.FutureTask;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
-
-/**
- * Decorates {@link FutureTask}
- * /p
- * This Future implementation makes the future.get(long timeout, TimeUnit unit)
- * wait the amount of time specified in the .get(...) call based on the object
creation
- * by keeping an internal timestamp of when this object was constructed
- *
- * @param V
- */
-public class CreationTimeAwareFutureV implements FutureV
-{
-
-private final long creationTime = System.currentTimeMillis();
-private final FutureV future;
-
-public CreationTimeAwareFuture(FutureV future)
-{
-this.future = future;
-}
-
-public V get(long timeout, TimeUnit unit) throws InterruptedException,
ExecutionException, TimeoutException
-{
-timeout = unit.toMillis(timeout);
-long overallTimeout = timeout - (System.currentTimeMillis() -
creationTime);
-return future.get(overallTimeout, TimeUnit.MILLISECONDS);
-}
-
-public boolean cancel(boolean mayInterruptIfRunning)
-{
-return future.cancel(mayInterruptIfRunning);
-}
-
-public boolean isCancelled()
-{
-return future.isCancelled();
-}
-
-public boolean isDone()
-{
-return future.isDone();
-}
-
-public V get() throws InterruptedException, ExecutionException
-{
- return future.get();
-}
-
-}
http://git-wip-us.apache.org/repos/asf/cassandra/blob/40e7aba6/src/java/org/apache/cassandra/utils/FBUtilities.java
--
diff --git a/src/java/org/apache/cassandra/utils/FBUtilities.java
b/src/java/org/apache/cassandra/utils/FBUtilities.java
index fd3ad4c..1f7807d 100644
--- a/src/java/org/apache/cassandra/utils/FBUtilities.java
+++ b/src/java/org/apache/cassandra/utils/FBUtilities.java
@@ -42,7 +42,6 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.cassandra.cache.IRowCacheProvider;
-import org.apache.cassandra.concurrent.CreationTimeAwareFuture;
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.db.DecoratedKey;
@@ -388,32 +387,6 @@ public class FBUtilities
result.get(ms, TimeUnit.MILLISECONDS);
}
-
-/**
-
[1/2] git commit: remove unused classes ArrayUtil.java/CreationTimeAwareFuture.java patch by dbrosius reviewed by ayeschenko for CASSANDRA-5474
Updated Branches:
refs/heads/trunk 841ae04f8 - cc7c549e9
remove unused classes ArrayUtil.java/CreationTimeAwareFuture.java
patch by dbrosius reviewed by ayeschenko for CASSANDRA-5474
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/40e7aba6
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/40e7aba6
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/40e7aba6
Branch: refs/heads/trunk
Commit: 40e7aba6b2f694017df5fbba90fd44caa0d43fc9
Parents: b4ebbae
Author: Dave Brosius dbros...@apache.org
Authored: Mon Apr 15 22:37:16 2013 -0400
Committer: Dave Brosius dbros...@apache.org
Committed: Mon Apr 15 22:37:16 2013 -0400
--
.../concurrent/CreationTimeAwareFuture.java| 73 ---
.../org/apache/cassandra/utils/FBUtilities.java| 27 --
.../org/apache/cassandra/utils/obs/ArrayUtil.java | 39
3 files changed, 0 insertions(+), 139 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/40e7aba6/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
--
diff --git
a/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
b/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
deleted file mode 100644
index d9d8185..000
--- a/src/java/org/apache/cassandra/concurrent/CreationTimeAwareFuture.java
+++ /dev/null
@@ -1,73 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * License); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.cassandra.concurrent;
-
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.Future;
-import java.util.concurrent.FutureTask;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
-
-/**
- * Decorates {@link FutureTask}
- * /p
- * This Future implementation makes the future.get(long timeout, TimeUnit unit)
- * wait the amount of time specified in the .get(...) call based on the object
creation
- * by keeping an internal timestamp of when this object was constructed
- *
- * @param V
- */
-public class CreationTimeAwareFutureV implements FutureV
-{
-
-private final long creationTime = System.currentTimeMillis();
-private final FutureV future;
-
-public CreationTimeAwareFuture(FutureV future)
-{
-this.future = future;
-}
-
-public V get(long timeout, TimeUnit unit) throws InterruptedException,
ExecutionException, TimeoutException
-{
-timeout = unit.toMillis(timeout);
-long overallTimeout = timeout - (System.currentTimeMillis() -
creationTime);
-return future.get(overallTimeout, TimeUnit.MILLISECONDS);
-}
-
-public boolean cancel(boolean mayInterruptIfRunning)
-{
-return future.cancel(mayInterruptIfRunning);
-}
-
-public boolean isCancelled()
-{
-return future.isCancelled();
-}
-
-public boolean isDone()
-{
-return future.isDone();
-}
-
-public V get() throws InterruptedException, ExecutionException
-{
- return future.get();
-}
-
-}
http://git-wip-us.apache.org/repos/asf/cassandra/blob/40e7aba6/src/java/org/apache/cassandra/utils/FBUtilities.java
--
diff --git a/src/java/org/apache/cassandra/utils/FBUtilities.java
b/src/java/org/apache/cassandra/utils/FBUtilities.java
index fd3ad4c..1f7807d 100644
--- a/src/java/org/apache/cassandra/utils/FBUtilities.java
+++ b/src/java/org/apache/cassandra/utils/FBUtilities.java
@@ -42,7 +42,6 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.cassandra.cache.IRowCacheProvider;
-import org.apache.cassandra.concurrent.CreationTimeAwareFuture;
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.db.DecoratedKey;
@@ -388,32 +387,6 @@ public class FBUtilities
result.get(ms, TimeUnit.MILLISECONDS);
}
-
-/**
- * Waits for the
[2/2] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cc7c549e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cc7c549e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cc7c549e Branch: refs/heads/trunk Commit: cc7c549e959897e5d25e46d31e1f91a795832ba7 Parents: 841ae04 40e7aba Author: Dave Brosius dbros...@apache.org Authored: Mon Apr 15 22:42:19 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Mon Apr 15 22:42:19 2013 -0400 -- .../concurrent/CreationTimeAwareFuture.java| 73 --- .../org/apache/cassandra/utils/FBUtilities.java| 27 -- .../org/apache/cassandra/utils/obs/ArrayUtil.java | 39 3 files changed, 0 insertions(+), 139 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/cc7c549e/src/java/org/apache/cassandra/utils/FBUtilities.java --
git commit: assert
Updated Branches:
refs/heads/trunk cc7c549e9 - 35ef47ec0
assert
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/35ef47ec
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/35ef47ec
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/35ef47ec
Branch: refs/heads/trunk
Commit: 35ef47ec0c73d882e53dfde51bd61f27f76a2b83
Parents: cc7c549
Author: Jonathan Ellis jbel...@apache.org
Authored: Mon Apr 15 23:06:31 2013 -0500
Committer: Jonathan Ellis jbel...@apache.org
Committed: Mon Apr 15 23:08:22 2013 -0500
--
src/java/org/apache/cassandra/db/ColumnFamily.java |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/35ef47ec/src/java/org/apache/cassandra/db/ColumnFamily.java
--
diff --git a/src/java/org/apache/cassandra/db/ColumnFamily.java
b/src/java/org/apache/cassandra/db/ColumnFamily.java
index 7498d25..e50e396 100644
--- a/src/java/org/apache/cassandra/db/ColumnFamily.java
+++ b/src/java/org/apache/cassandra/db/ColumnFamily.java
@@ -59,6 +59,7 @@ public abstract class ColumnFamily implements
IterableColumn, IRowCacheEntry
protected ColumnFamily(CFMetaData metadata)
{
+assert metadata != null;
this.metadata = metadata;
}
[jira] [Commented] (CASSANDRA-5441) Add support for read at CL.SERIAL
[ https://issues.apache.org/jira/browse/CASSANDRA-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632547#comment-13632547 ] Jonathan Ellis commented on CASSANDRA-5441: --- Pushed to https://github.com/jbellis/cassandra/commits/5441 Add support for read at CL.SERIAL - Key: CASSANDRA-5441 URL: https://issues.apache.org/jira/browse/CASSANDRA-5441 Project: Cassandra Issue Type: Sub-task Components: API, Core Reporter: Jonathan Ellis Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5424) nodetool repair -pr on all nodes won't repair the full range when a Keyspace isn't in all DC's
[
https://issues.apache.org/jira/browse/CASSANDRA-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuki Morishita updated CASSANDRA-5424:
--
Fix Version/s: (was: 1.1.11)
1.2.5
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
--
Key: CASSANDRA-5424
URL: https://issues.apache.org/jira/browse/CASSANDRA-5424
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.7
Reporter: Jeremiah Jordan
Assignee: Yuki Morishita
Priority: Critical
Fix For: 1.2.5
Attachments: 5424-1.1.txt, 5424-v2-1.2.txt
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
Commands follow, but the TL;DR of it, range
(127605887595351923798765477786913079296,0] doesn't get repaired between .38
node and .236 node until I run a repair, no -pr, on .38
It seems like primary arnge calculation doesn't take schema into account, but
deciding who to ask for merkle tree's from does.
{noformat}
Address DC RackStatus State LoadOwns
Token
127605887595351923798765477786913079296
10.72.111.225 Cassandra rack1 Up Normal 455.87 KB 25.00%
0
10.2.29.38 Analytics rack1 Up Normal 40.74 MB25.00%
42535295865117307932921825928971026432
10.46.113.236 Analytics rack1 Up Normal 20.65 MB50.00%
127605887595351923798765477786913079296
create keyspace Keyspace1
with placement_strategy = 'NetworkTopologyStrategy'
and strategy_options = {Analytics : 2}
and durable_writes = true;
---
# nodetool -h 10.2.29.38 repair -pr Keyspace1 Standard1
[2013-04-03 15:46:58,000] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:47:00,881] Repair session b79b4850-9c75-11e2--8b5bf6ebea9e
for range (0,42535295865117307932921825928971026432] finished
[2013-04-03 15:47:00,881] Repair command #1 finished
root@ip-10-2-29-38:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,009 AntiEntropyService.java
(line 676) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] new session: will
sync a1/10.2.29.38, /10.46.113.236 on range
(0,42535295865117307932921825928971026432] for Keyspace1.[Standard1]
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,015 AntiEntropyService.java
(line 881) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] requesting merkle
trees for Standard1 (to [/10.46.113.236, a1/10.2.29.38])
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,202 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from /10.46.113.236
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,697 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from a1/10.2.29.38
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,879 AntiEntropyService.java
(line 1015) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Endpoints
/10.46.113.236 and a1/10.2.29.38 are consistent for Standard1
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 788) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Standard1 is fully
synced
INFO [AntiEntropySessions:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 722) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] session completed
successfully
root@ip-10-46-113-236:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropyStage:1] 2013-04-03 15:46:59,944 AntiEntropyService.java
(line 244) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Sending completed
merkle tree to /10.2.29.38 for (Keyspace1,Standard1)
root@ip-10-72-111-225:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
root@ip-10-72-111-225:/home/ubuntu#
---
# nodetool -h 10.46.113.236 repair -pr Keyspace1 Standard1
[2013-04-03 15:48:00,274] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:48:02,032] Repair session dcb91540-9c75-11e2--a839ee2ccbef
for range
(42535295865117307932921825928971026432,127605887595351923798765477786913079296]
finished
[2013-04-03 15:48:02,033] Repair command #1 finished
root@ip-10-46-113-236:/home/ubuntu# grep dcb91540-9c75-11e2--a839ee2ccbef
[jira] [Updated] (CASSANDRA-5424) nodetool repair -pr on all nodes won't repair the full range when a Keyspace isn't in all DC's
[
https://issues.apache.org/jira/browse/CASSANDRA-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuki Morishita updated CASSANDRA-5424:
--
Attachment: 5424-v2-1.2.txt
Ok, this time I created patch against 1.2.
We've been calculating the primary range just from the tokens of the node. The
patch changes this to use replication strategy's calculateNaturalEndpoint, and
use the first one returned by the method as the primary range. In order to do
this in NTS though, I have to tweak a little bit(Set instead of List to use
internally).
By this way, we get the primary ranges for .38 for Keyspace1 above are
(127...296, 0] and (0, 425...32]. For .225, it returns empty range(btw I had to
fix repair for empty range also).
When using vnodes, it is not guaranteed to have consecutive ranges, so I
decided to return in two separate ranges.
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
--
Key: CASSANDRA-5424
URL: https://issues.apache.org/jira/browse/CASSANDRA-5424
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.1.7
Reporter: Jeremiah Jordan
Assignee: Yuki Morishita
Priority: Critical
Fix For: 1.1.11
Attachments: 5424-1.1.txt, 5424-v2-1.2.txt
nodetool repair -pr on all nodes won't repair the full range when a Keyspace
isn't in all DC's
Commands follow, but the TL;DR of it, range
(127605887595351923798765477786913079296,0] doesn't get repaired between .38
node and .236 node until I run a repair, no -pr, on .38
It seems like primary arnge calculation doesn't take schema into account, but
deciding who to ask for merkle tree's from does.
{noformat}
Address DC RackStatus State LoadOwns
Token
127605887595351923798765477786913079296
10.72.111.225 Cassandra rack1 Up Normal 455.87 KB 25.00%
0
10.2.29.38 Analytics rack1 Up Normal 40.74 MB25.00%
42535295865117307932921825928971026432
10.46.113.236 Analytics rack1 Up Normal 20.65 MB50.00%
127605887595351923798765477786913079296
create keyspace Keyspace1
with placement_strategy = 'NetworkTopologyStrategy'
and strategy_options = {Analytics : 2}
and durable_writes = true;
---
# nodetool -h 10.2.29.38 repair -pr Keyspace1 Standard1
[2013-04-03 15:46:58,000] Starting repair command #1, repairing 1 ranges for
keyspace Keyspace1
[2013-04-03 15:47:00,881] Repair session b79b4850-9c75-11e2--8b5bf6ebea9e
for range (0,42535295865117307932921825928971026432] finished
[2013-04-03 15:47:00,881] Repair command #1 finished
root@ip-10-2-29-38:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,009 AntiEntropyService.java
(line 676) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] new session: will
sync a1/10.2.29.38, /10.46.113.236 on range
(0,42535295865117307932921825928971026432] for Keyspace1.[Standard1]
INFO [AntiEntropySessions:1] 2013-04-03 15:46:58,015 AntiEntropyService.java
(line 881) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] requesting merkle
trees for Standard1 (to [/10.46.113.236, a1/10.2.29.38])
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,202 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from /10.46.113.236
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,697 AntiEntropyService.java
(line 211) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Received merkle
tree for Standard1 from a1/10.2.29.38
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,879 AntiEntropyService.java
(line 1015) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Endpoints
/10.46.113.236 and a1/10.2.29.38 are consistent for Standard1
INFO [AntiEntropyStage:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 788) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Standard1 is fully
synced
INFO [AntiEntropySessions:1] 2013-04-03 15:47:00,880 AntiEntropyService.java
(line 722) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] session completed
successfully
root@ip-10-46-113-236:/home/ubuntu# grep b79b4850-9c75-11e2--8b5bf6ebea9e
/var/log/cassandra/system.log
INFO [AntiEntropyStage:1] 2013-04-03 15:46:59,944 AntiEntropyService.java
(line 244) [repair #b79b4850-9c75-11e2--8b5bf6ebea9e] Sending completed
merkle tree to /10.2.29.38 for
buildbot failure in ASF Buildbot on cassandra-trunk
The Buildbot has detected a new failure on builder cassandra-trunk while building cassandra. Full details are available at: http://ci.apache.org/builders/cassandra-trunk/builds/2580 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Source Stamp: [branch trunk] 35ef47ec0c73d882e53dfde51bd61f27f76a2b83 Blamelist: Jonathan Ellis jbel...@apache.org BUILD FAILED: failed shell sincerely, -The Buildbot
[jira] [Commented] (CASSANDRA-5051) Allow automatic cleanup after gc_grace
[
https://issues.apache.org/jira/browse/CASSANDRA-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632576#comment-13632576
]
Vijay commented on CASSANDRA-5051:
--
{quote}
(i.e.: localhost is a Normal token; another node is Bootstrapping)
{quote}
I think thats exactly what the test does :)
tk0 (Local node owns the whole range before BS) is taking over the whole range
but it is still bootstrapping...
CPT.testCleanupDuringRangeMovement()
{code}
// test if node streaming is not dropping the data.
tmd.addBootstrapToken(new BytesToken(tk0),
InetAddress.getByName(127.0.0.3));
tmd.updateNormalToken(new BytesToken(tk2),
FBUtilities.getBroadcastAddress());
StorageService.calculatePendingRanges(table.getReplicationStrategy(),
table.getName());
logger.info(Range movement scheduled for: {},
tmd.getPendingRanges(table.getName()));
CompactionManager.instance.submitMaximal(cfs, Integer.MAX_VALUE).get();
{code}
{quote}
At the least I'd add an assert to make sure empty really does imply
isBoostrapping.
{quote}
Will do, Let me know... Thanks!
Allow automatic cleanup after gc_grace
--
Key: CASSANDRA-5051
URL: https://issues.apache.org/jira/browse/CASSANDRA-5051
Project: Cassandra
Issue Type: New Feature
Components: Core
Reporter: Brandon Williams
Assignee: Vijay
Labels: vnodes
Fix For: 2.0
Attachments: 0001-5051-v4.patch, 0001-5051-with-test-fixes.patch,
0001-CASSANDRA-5051.patch, 0002-5051-remove-upgradesstable.patch,
0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch,
5051-v2.txt
When using vnodes, after adding a new node you have to run cleanup on all the
machines, because you don't know which are affected and chances are it was
most if not all of them. As an alternative to this intensive process, we
could allow cleanup during compaction if the data is older than gc_grace (or
perhaps some other time period since people tend to use gc_grace hacks to get
rid of tombstones.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
