[jira] [Created] (CASSANDRA-5646) Incompatible sstables hangs repair
Radim Kolar created CASSANDRA-5646: -- Summary: Incompatible sstables hangs repair Key: CASSANDRA-5646 URL: https://issues.apache.org/jira/browse/CASSANDRA-5646 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5 Reporter: Radim Kolar repair session between 1.2.5 and 1.2.4: ERROR [Thread-11] 2013-06-16 13:39:39,359 CassandraDaemon.java (line 175) Exception in thread Thread[Thread-11,5,main] java.lang.UnsupportedOperationException: SSTable C:\Program Files (x86)\DataStax Community\data\data\test\sipdb\test-sipdb-hf-16-Data.db is not compatible with current version ic at org.apache.cassandra.streaming.StreamIn.getContextMapping(StreamIn.java:77) at org.apache.cassandra.streaming.IncomingStreamReader.init(IncomingStreamReader.java:87) at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238) at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178) at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78) using nodetool netstats shows both sstables streaming at 0/XX. repair never finished. After upgrading sstables to latest level (hf and ic should be compatible) repair works fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-5647) Typo in error message in cqlsh (CQL3) when using more than one relation with a IN
[
https://issues.apache.org/jira/browse/CASSANDRA-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Brosius resolved CASSANDRA-5647.
-
Resolution: Fixed
Fix Version/s: 1.2.6
Reviewer: dbrosius
Thanks
committed as 155afa1b7f22dedad3fb9c0d7270a101e72be814 to cassandra-1.1
Typo in error message in cqlsh (CQL3) when using more than one relation with
a IN
--
Key: CASSANDRA-5647
URL: https://issues.apache.org/jira/browse/CASSANDRA-5647
Project: Cassandra
Issue Type: Bug
Components: Tools
Affects Versions: 1.2.5
Environment: Linux 3.8.0-25-generic #37-Ubuntu 13.04 SMP
[cqlsh 3.0.2 | Cassandra 1.2.5-SNAPSHOT | CQL spec 3.0.0 | Thrift protocol
19.36.0] (installed via ccm)
Reporter: Rui Vieira
Priority: Trivial
Fix For: 1.2.6
When performing a query such as
bq. select * from foo where bucket in (1) and id in ('O1', 'O2') and bucket
in (2) and id in ('O3', 'O4') ;
the error message in cqlsh is:
bq. Bad Request: bucket cannot be restricted by more than one *reation* if it
includes a IN
Expected:
bq. Bad Request: bucket cannot be restricted by more than one *relation* if
it includes a IN
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[2/2] git commit: Merge branch 'cassandra-1.1' into cassandra-1.2
Merge branch 'cassandra-1.1' into cassandra-1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0bff5f57 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0bff5f57 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0bff5f57 Branch: refs/heads/cassandra-1.2 Commit: 0bff5f57dc6b27522cf0c1add526fcbbd322edce Parents: 082684d 155afa1 Author: Dave Brosius dbros...@apache.org Authored: Sun Jun 16 13:18:47 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Sun Jun 16 13:18:47 2013 -0400 -- CHANGES.txt | 1 + .../org/apache/cassandra/cql3/statements/SelectStatement.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/0bff5f57/CHANGES.txt -- diff --cc CHANGES.txt index 9e68257,69df3de..c28d4d7 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,142 -1,14 +1,143 @@@ -1.1.12 +1.2.6 + * Reduce SSTableLoader memory usage (CASSANDRA-) + * Scale hinted_handoff_throttle_in_kb to cluster size (CASSANDRA-5272) + * (Hadoop) Add CQL3 input/output formats (CASSANDRA-4421) + * (Hadoop) Fix InputKeyRange in CFIF (CASSANDRA-5536) + * Fix dealing with ridiculously large max sstable sizes in LCS (CASSANDRA-5589) + * Ignore pre-truncate hints (CASSANDRA-4655) + * Move System.exit on OOM into a separate thread (CASSANDRA-5273) + * Write row markers when serializing schema (CASSANDRA-5572) + * Check only SSTables for the requested range when streaming (CASSANDRA-5569) + * Improve batchlog replay behavior and hint ttl handling (CASSANDRA-5314) + * Exclude localTimestamp from validation for tombstones (CASSANDRA-5398) + * cqlsh: add custom prompt support (CASSANDRA-5539) + * Reuse prepared statements in hot auth queries (CASSANDRA-5594) + * cqlsh: add vertical output option (see EXPAND) (CASSANDRA-5597) + * Add a rate limit option to stress (CASSANDRA-5004) + * have BulkLoader ignore snapshots directories (CASSANDRA-5587) + * fix SnitchProperties logging context (CASSANDRA-5602) + * Expose whether jna is enabled and memory is locked via JMX (CASSANDRA-5508) + * cqlsh: fix COPY FROM with ReversedType (CASSANDRA-5610) + * Allow creating CUSTOM indexes on collections (CASSANDRA-5615) + * Evaluate now() function at execution time (CASSANDRA-5616) + * Expose detailed read repair metrics (CASSANDRA-5618) + * Correct blob literal + ReversedType parsing (CASSANDRA-5629) + * Allow GPFS to prefer the internal IP like EC2MRS (CASSANDRA-5630) + * fix help text for -tspw cassandra-cli (CASSANDRA-5643) + * don't throw away initial causes exceptions for internode encryption issues (CASSANDRA-5644) ++ * Fix message spelling errors for cql select statements (CASSANDRA-5647) +Merged from 1.1: + * Remove buggy thrift max message length option (CASSANDRA-5529) + * Fix NPE in Pig's widerow mode (CASSANDRA-5488) + * Add split size parameter to Pig and disable split combination (CASSANDRA-5544) + + +1.2.5 + * make BytesToken.toString only return hex bytes (CASSANDRA-5566) + * Ensure that submitBackground enqueues at least one task (CASSANDRA-5554) + * fix 2i updates with identical values and timestamps (CASSANDRA-5540) + * fix compaction throttling bursty-ness (CASSANDRA-4316) + * reduce memory consumption of IndexSummary (CASSANDRA-5506) + * remove per-row column name bloom filters (CASSANDRA-5492) + * Include fatal errors in trace events (CASSANDRA-5447) + * Ensure that PerRowSecondaryIndex is notified of row-level deletes + (CASSANDRA-5445) + * Allow empty blob literals in CQL3 (CASSANDRA-5452) + * Fix streaming RangeTombstones at column index boundary (CASSANDRA-5418) + * Fix preparing statements when current keyspace is not set (CASSANDRA-5468) + * Fix SemanticVersion.isSupportedBy minor/patch handling (CASSANDRA-5496) + * Don't provide oldCfId for post-1.1 system cfs (CASSANDRA-5490) + * Fix primary range ignores replication strategy (CASSANDRA-5424) + * Fix shutdown of binary protocol server (CASSANDRA-5507) + * Fix repair -snapshot not working (CASSANDRA-5512) + * Set isRunning flag later in binary protocol server (CASSANDRA-5467) + * Fix use of CQL3 functions with descending clustering order (CASSANDRA-5472) + * Disallow renaming columns one at a time for thrift table in CQL3 + (CASSANDRA-5531) + * cqlsh: add CLUSTERING ORDER BY support to DESCRIBE (CASSANDRA-5528) + * Add custom secondary index support to CQL3 (CASSANDRA-5484) + * Fix repair hanging silently on unexpected error (CASSANDRA-5229) + * Fix Ec2Snitch regression introduced by CASSANDRA-5171 (CASSANDRA-5432) + * Add nodetool enablebackup/disablebackup (CASSANDRA-5556) + * cqlsh: fix
[2/3] git commit: Merge branch 'cassandra-1.1' into cassandra-1.2
Merge branch 'cassandra-1.1' into cassandra-1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0bff5f57 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0bff5f57 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0bff5f57 Branch: refs/heads/trunk Commit: 0bff5f57dc6b27522cf0c1add526fcbbd322edce Parents: 082684d 155afa1 Author: Dave Brosius dbros...@apache.org Authored: Sun Jun 16 13:18:47 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Sun Jun 16 13:18:47 2013 -0400 -- CHANGES.txt | 1 + .../org/apache/cassandra/cql3/statements/SelectStatement.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/0bff5f57/CHANGES.txt -- diff --cc CHANGES.txt index 9e68257,69df3de..c28d4d7 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,142 -1,14 +1,143 @@@ -1.1.12 +1.2.6 + * Reduce SSTableLoader memory usage (CASSANDRA-) + * Scale hinted_handoff_throttle_in_kb to cluster size (CASSANDRA-5272) + * (Hadoop) Add CQL3 input/output formats (CASSANDRA-4421) + * (Hadoop) Fix InputKeyRange in CFIF (CASSANDRA-5536) + * Fix dealing with ridiculously large max sstable sizes in LCS (CASSANDRA-5589) + * Ignore pre-truncate hints (CASSANDRA-4655) + * Move System.exit on OOM into a separate thread (CASSANDRA-5273) + * Write row markers when serializing schema (CASSANDRA-5572) + * Check only SSTables for the requested range when streaming (CASSANDRA-5569) + * Improve batchlog replay behavior and hint ttl handling (CASSANDRA-5314) + * Exclude localTimestamp from validation for tombstones (CASSANDRA-5398) + * cqlsh: add custom prompt support (CASSANDRA-5539) + * Reuse prepared statements in hot auth queries (CASSANDRA-5594) + * cqlsh: add vertical output option (see EXPAND) (CASSANDRA-5597) + * Add a rate limit option to stress (CASSANDRA-5004) + * have BulkLoader ignore snapshots directories (CASSANDRA-5587) + * fix SnitchProperties logging context (CASSANDRA-5602) + * Expose whether jna is enabled and memory is locked via JMX (CASSANDRA-5508) + * cqlsh: fix COPY FROM with ReversedType (CASSANDRA-5610) + * Allow creating CUSTOM indexes on collections (CASSANDRA-5615) + * Evaluate now() function at execution time (CASSANDRA-5616) + * Expose detailed read repair metrics (CASSANDRA-5618) + * Correct blob literal + ReversedType parsing (CASSANDRA-5629) + * Allow GPFS to prefer the internal IP like EC2MRS (CASSANDRA-5630) + * fix help text for -tspw cassandra-cli (CASSANDRA-5643) + * don't throw away initial causes exceptions for internode encryption issues (CASSANDRA-5644) ++ * Fix message spelling errors for cql select statements (CASSANDRA-5647) +Merged from 1.1: + * Remove buggy thrift max message length option (CASSANDRA-5529) + * Fix NPE in Pig's widerow mode (CASSANDRA-5488) + * Add split size parameter to Pig and disable split combination (CASSANDRA-5544) + + +1.2.5 + * make BytesToken.toString only return hex bytes (CASSANDRA-5566) + * Ensure that submitBackground enqueues at least one task (CASSANDRA-5554) + * fix 2i updates with identical values and timestamps (CASSANDRA-5540) + * fix compaction throttling bursty-ness (CASSANDRA-4316) + * reduce memory consumption of IndexSummary (CASSANDRA-5506) + * remove per-row column name bloom filters (CASSANDRA-5492) + * Include fatal errors in trace events (CASSANDRA-5447) + * Ensure that PerRowSecondaryIndex is notified of row-level deletes + (CASSANDRA-5445) + * Allow empty blob literals in CQL3 (CASSANDRA-5452) + * Fix streaming RangeTombstones at column index boundary (CASSANDRA-5418) + * Fix preparing statements when current keyspace is not set (CASSANDRA-5468) + * Fix SemanticVersion.isSupportedBy minor/patch handling (CASSANDRA-5496) + * Don't provide oldCfId for post-1.1 system cfs (CASSANDRA-5490) + * Fix primary range ignores replication strategy (CASSANDRA-5424) + * Fix shutdown of binary protocol server (CASSANDRA-5507) + * Fix repair -snapshot not working (CASSANDRA-5512) + * Set isRunning flag later in binary protocol server (CASSANDRA-5467) + * Fix use of CQL3 functions with descending clustering order (CASSANDRA-5472) + * Disallow renaming columns one at a time for thrift table in CQL3 + (CASSANDRA-5531) + * cqlsh: add CLUSTERING ORDER BY support to DESCRIBE (CASSANDRA-5528) + * Add custom secondary index support to CQL3 (CASSANDRA-5484) + * Fix repair hanging silently on unexpected error (CASSANDRA-5229) + * Fix Ec2Snitch regression introduced by CASSANDRA-5171 (CASSANDRA-5432) + * Add nodetool enablebackup/disablebackup (CASSANDRA-5556) + * cqlsh: fix DESCRIBE
[1/3] git commit: fix error message spelling with cql select statements patch by rvieira reviewed by dbrosius for cassandra-5647
Updated Branches: refs/heads/trunk 66a5e09b0 - 2ca07f523 fix error message spelling with cql select statements patch by rvieira reviewed by dbrosius for cassandra-5647 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/155afa1b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/155afa1b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/155afa1b Branch: refs/heads/trunk Commit: 155afa1b7f22dedad3fb9c0d7270a101e72be814 Parents: 9982449 Author: Dave Brosius dbros...@apache.org Authored: Sun Jun 16 13:06:53 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Sun Jun 16 13:06:53 2013 -0400 -- src/java/org/apache/cassandra/cql3/statements/SelectStatement.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/155afa1b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java -- diff --git a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java index d162a01..d2ceecb 100644 --- a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java @@ -1208,7 +1208,7 @@ public class SelectStatement implements CQLStatement break; case IN: if (restriction != null) -throw new InvalidRequestException(String.format(%s cannot be restricted by more than one reation if it includes a IN, name)); +throw new InvalidRequestException(String.format(%s cannot be restricted by more than one relation if it includes a IN, name)); restriction = new Restriction(newRel.getInValues()); break; case GT:
[3/3] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2ca07f52 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2ca07f52 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2ca07f52 Branch: refs/heads/trunk Commit: 2ca07f5238c5d918f78361e1fa35beb84205cf6a Parents: 66a5e09 0bff5f5 Author: Dave Brosius dbros...@apache.org Authored: Sun Jun 16 13:20:28 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Sun Jun 16 13:20:28 2013 -0400 -- CHANGES.txt | 1 + .../org/apache/cassandra/cql3/statements/SelectStatement.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/2ca07f52/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/2ca07f52/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java --
buildbot failure in ASF Buildbot on cassandra-1.1
The Buildbot has detected a new failure on builder cassandra-1.1 while building cassandra. Full details are available at: http://ci.apache.org/builders/cassandra-1.1/builds/192 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Source Stamp: [branch cassandra-1.1] 155afa1b7f22dedad3fb9c0d7270a101e72be814 Blamelist: Dave Brosius dbros...@apache.org BUILD FAILED: failed shell sincerely, -The Buildbot
buildbot success in ASF Buildbot on cassandra-1.1
The Buildbot has detected a restored build on builder cassandra-1.1 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cassandra-1.1/builds/193 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: forced: by IRC user mebigfatguy on channel #cassandra-dev: again Build Source Stamp: HEAD Blamelist: Build succeeded! sincerely, -The Buildbot
[jira] [Commented] (CASSANDRA-5646) Incompatible sstables hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684704#comment-13684704 ] Dave Brosius commented on CASSANDRA-5646: - hf is 1.1.6 nodetool upgradesstables Incompatible sstables hangs repair -- Key: CASSANDRA-5646 URL: https://issues.apache.org/jira/browse/CASSANDRA-5646 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5 Reporter: Radim Kolar repair session between 1.2.5 and 1.2.4: ERROR [Thread-11] 2013-06-16 13:39:39,359 CassandraDaemon.java (line 175) Exception in thread Thread[Thread-11,5,main] java.lang.UnsupportedOperationException: SSTable C:\Program Files (x86)\DataStax Community\data\data\test\sipdb\test-sipdb-hf-16-Data.db is not compatible with current version ic at org.apache.cassandra.streaming.StreamIn.getContextMapping(StreamIn.java:77) at org.apache.cassandra.streaming.IncomingStreamReader.init(IncomingStreamReader.java:87) at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238) at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178) at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78) using nodetool netstats shows both sstables streaming at 0/XX. repair never finished. After upgrading sstables to latest level (hf and ic should be compatible) repair works fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5646) Incompatible sstables hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684713#comment-13684713 ] Radim Kolar commented on CASSANDRA-5646: should not be 1.2 able to read 1.1.X? Incompatible sstables hangs repair -- Key: CASSANDRA-5646 URL: https://issues.apache.org/jira/browse/CASSANDRA-5646 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5 Reporter: Radim Kolar repair session between 1.2.5 and 1.2.4: ERROR [Thread-11] 2013-06-16 13:39:39,359 CassandraDaemon.java (line 175) Exception in thread Thread[Thread-11,5,main] java.lang.UnsupportedOperationException: SSTable C:\Program Files (x86)\DataStax Community\data\data\test\sipdb\test-sipdb-hf-16-Data.db is not compatible with current version ic at org.apache.cassandra.streaming.StreamIn.getContextMapping(StreamIn.java:77) at org.apache.cassandra.streaming.IncomingStreamReader.init(IncomingStreamReader.java:87) at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238) at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178) at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78) using nodetool netstats shows both sstables streaming at 0/XX. repair never finished. After upgrading sstables to latest level (hf and ic should be compatible) repair works fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5646) Incompatible sstables hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684719#comment-13684719 ] Jeremy Hanna commented on CASSANDRA-5646: - It's generally recommended to run nodetool upgradesstables between any two major versions prior to doing any kind of streaming operation like move, bootstrap, or repair. That will avoid any mixed version sstable issues. I'm not sure what the guarantees are. I believe each node can read the prior major version files, but sometimes the streaming operations have issues. Incompatible sstables hangs repair -- Key: CASSANDRA-5646 URL: https://issues.apache.org/jira/browse/CASSANDRA-5646 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5 Reporter: Radim Kolar repair session between 1.2.5 and 1.2.4: ERROR [Thread-11] 2013-06-16 13:39:39,359 CassandraDaemon.java (line 175) Exception in thread Thread[Thread-11,5,main] java.lang.UnsupportedOperationException: SSTable C:\Program Files (x86)\DataStax Community\data\data\test\sipdb\test-sipdb-hf-16-Data.db is not compatible with current version ic at org.apache.cassandra.streaming.StreamIn.getContextMapping(StreamIn.java:77) at org.apache.cassandra.streaming.IncomingStreamReader.init(IncomingStreamReader.java:87) at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238) at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178) at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78) using nodetool netstats shows both sstables streaming at 0/XX. repair never finished. After upgrading sstables to latest level (hf and ic should be compatible) repair works fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684723#comment-13684723 ] Vijay commented on CASSANDRA-5576: -- Removed cli support for it, but thrift i am not sure there is a lot of automation in testing which relies on it... As a user i use thrift for various reasons like performance and i am not sure if i would switch that soon, specially with the cross platforms we have to deal with. v4 addresses the nits too. https://github.com/Vijay2win/cassandra/commits/5576-v4 CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684739#comment-13684739 ] Aleksey Yeschenko commented on CASSANDRA-5576: -- bq. As a user i use thrift for various reasons like performance and i am not sure if i would switch that soon, specially with the cross platforms we have to deal with. You'd only have to use CQL3 for DROP and CREATE TRIGGER (via thfit.execute_cql3_query()) and ignore it otherwise. Speed not affected (unless you are talking about the speed of creating a trigger (: ). Though I can see some value of being able to modify triggers via thrift.system_update_column_family() if one has no CQL3 tables at all and doesn't want to bother with it, ever. Can you make it listmapstring, mapstring, string (list(index name - index options, including class)) then? So that once we add parametrization support, thrift wouldn't have to change at all? Other than this, everything looks fine to me. (tiny nit: FBUtilities.fromJsonListObject() is now unused and can be removed) CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684752#comment-13684752 ] Aleksey Yeschenko commented on CASSANDRA-5576: -- Also, TriggerOptions should be moved to org.apache.cassandra.config (and ideally renamed to just Triggers). This is all. CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684739#comment-13684739 ] Aleksey Yeschenko edited comment on CASSANDRA-5576 at 6/16/13 7:57 PM: --- bq. As a user i use thrift for various reasons like performance and i am not sure if i would switch that soon, specially with the cross platforms we have to deal with. You'd only have to use CQL3 for DROP and CREATE TRIGGER (via thfit.execute_cql3_query()) and ignore it otherwise. Speed not affected (unless you are talking about the speed of creating a trigger (: ). Though I can see some value of being able to modify triggers via thrift.system_update_column_family() if one has no CQL3 tables at all and doesn't want to bother with it, ever. Can you make it mapstring, mapstring, string (index name - index options, including class) then? So that once we add parametrization support, thrift wouldn't have to change at all? Other than this, everything looks fine to me. (tiny nit: FBUtilities.fromJsonListObject() is now unused and can be removed) was (Author: iamaleksey): bq. As a user i use thrift for various reasons like performance and i am not sure if i would switch that soon, specially with the cross platforms we have to deal with. You'd only have to use CQL3 for DROP and CREATE TRIGGER (via thfit.execute_cql3_query()) and ignore it otherwise. Speed not affected (unless you are talking about the speed of creating a trigger (: ). Though I can see some value of being able to modify triggers via thrift.system_update_column_family() if one has no CQL3 tables at all and doesn't want to bother with it, ever. Can you make it listmapstring, mapstring, string (list(index name - index options, including class)) then? So that once we add parametrization support, thrift wouldn't have to change at all? Other than this, everything looks fine to me. (tiny nit: FBUtilities.fromJsonListObject() is now unused and can be removed) CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: imports cleanup
Updated Branches: refs/heads/trunk 2ca07f523 - ed4d45565 imports cleanup Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ed4d4556 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ed4d4556 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ed4d4556 Branch: refs/heads/trunk Commit: ed4d45565789cbfb1fafcfee8527e24790e4803d Parents: 2ca07f5 Author: Dave Brosius dbros...@apache.org Authored: Sun Jun 16 18:22:30 2013 -0400 Committer: Dave Brosius dbros...@apache.org Committed: Sun Jun 16 18:22:30 2013 -0400 -- src/java/org/apache/cassandra/config/YamlConfigurationLoader.java | 1 - src/java/org/apache/cassandra/cql3/statements/BatchStatement.java | 1 - .../org/apache/cassandra/db/compaction/CompactionController.java | 2 -- .../org/apache/cassandra/db/compaction/LazilyCompactedRow.java| 1 - src/java/org/apache/cassandra/db/filter/SliceQueryFilter.java | 3 --- src/java/org/apache/cassandra/hadoop/ColumnFamilySplit.java | 1 - .../apache/cassandra/locator/YamlFileNetworkTopologySnitch.java | 1 - src/java/org/apache/cassandra/metrics/ReadRepairMetrics.java | 3 --- src/java/org/apache/cassandra/thrift/TServerCustomFactory.java| 1 - src/java/org/apache/cassandra/tools/NodeCmd.java | 2 -- 10 files changed, 16 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/ed4d4556/src/java/org/apache/cassandra/config/YamlConfigurationLoader.java -- diff --git a/src/java/org/apache/cassandra/config/YamlConfigurationLoader.java b/src/java/org/apache/cassandra/config/YamlConfigurationLoader.java index 2eb4e6e..642fe8b 100644 --- a/src/java/org/apache/cassandra/config/YamlConfigurationLoader.java +++ b/src/java/org/apache/cassandra/config/YamlConfigurationLoader.java @@ -27,7 +27,6 @@ import org.slf4j.LoggerFactory; import org.apache.cassandra.exceptions.ConfigurationException; import org.apache.cassandra.io.util.FileUtils; -import org.yaml.snakeyaml.Loader; import org.yaml.snakeyaml.TypeDescription; import org.yaml.snakeyaml.Yaml; import org.yaml.snakeyaml.error.YAMLException; http://git-wip-us.apache.org/repos/asf/cassandra/blob/ed4d4556/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java -- diff --git a/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java b/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java index 777c80f..1436811 100644 --- a/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java @@ -23,7 +23,6 @@ import java.util.*; import org.apache.cassandra.cql3.*; import org.apache.cassandra.db.ConsistencyLevel; import org.apache.cassandra.db.IMutation; -import org.apache.cassandra.db.RowMutation; import org.apache.cassandra.exceptions.*; import org.apache.cassandra.service.ClientState; import org.apache.cassandra.service.QueryState; http://git-wip-us.apache.org/repos/asf/cassandra/blob/ed4d4556/src/java/org/apache/cassandra/db/compaction/CompactionController.java -- diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionController.java b/src/java/org/apache/cassandra/db/compaction/CompactionController.java index 15878c5..7c79368 100644 --- a/src/java/org/apache/cassandra/db/compaction/CompactionController.java +++ b/src/java/org/apache/cassandra/db/compaction/CompactionController.java @@ -28,14 +28,12 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.apache.cassandra.config.DatabaseDescriptor; -import org.apache.cassandra.db.ColumnFamily; import org.apache.cassandra.db.ColumnFamilyStore; import org.apache.cassandra.db.DataTracker; import org.apache.cassandra.db.DecoratedKey; import org.apache.cassandra.io.sstable.SSTable; import org.apache.cassandra.io.sstable.SSTableIdentityIterator; import org.apache.cassandra.io.sstable.SSTableReader; -import org.apache.cassandra.service.CacheService; import org.apache.cassandra.utils.AlwaysPresentFilter; /** http://git-wip-us.apache.org/repos/asf/cassandra/blob/ed4d4556/src/java/org/apache/cassandra/db/compaction/LazilyCompactedRow.java -- diff --git a/src/java/org/apache/cassandra/db/compaction/LazilyCompactedRow.java b/src/java/org/apache/cassandra/db/compaction/LazilyCompactedRow.java index 5635652..e9cd2f1 100644 --- a/src/java/org/apache/cassandra/db/compaction/LazilyCompactedRow.java +++ b/src/java/org/apache/cassandra/db/compaction/LazilyCompactedRow.java @@ -37,7 +37,6 @@ import
[1/3] patch by Vijay; reviewed by Aleksey Yeschenko for CASSANDRA-5576
Updated Branches:
refs/heads/trunk ed4d45565 - 8bf6e1559
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8bf6e155/src/java/org/apache/cassandra/cql3/statements/CreateTriggerStatement.java
--
diff --git
a/src/java/org/apache/cassandra/cql3/statements/CreateTriggerStatement.java
b/src/java/org/apache/cassandra/cql3/statements/CreateTriggerStatement.java
new file mode 100644
index 000..4c6e78a
--- /dev/null
+++ b/src/java/org/apache/cassandra/cql3/statements/CreateTriggerStatement.java
@@ -0,0 +1,66 @@
+package org.apache.cassandra.cql3.statements;
+
+import org.apache.cassandra.auth.Permission;
+import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.config.Schema;
+import org.apache.cassandra.config.TriggerOptions;
+import org.apache.cassandra.cql3.CFName;
+import org.apache.cassandra.exceptions.ConfigurationException;
+import org.apache.cassandra.exceptions.ExceptionCode;
+import org.apache.cassandra.exceptions.InvalidRequestException;
+import org.apache.cassandra.exceptions.RequestValidationException;
+import org.apache.cassandra.exceptions.UnauthorizedException;
+import org.apache.cassandra.service.ClientState;
+import org.apache.cassandra.service.MigrationManager;
+import org.apache.cassandra.thrift.ThriftValidation;
+import org.apache.cassandra.transport.messages.ResultMessage;
+import org.apache.cassandra.triggers.TriggerExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CreateTriggerStatement extends SchemaAlteringStatement
+{
+private static final Logger logger =
LoggerFactory.getLogger(CreateTriggerStatement.class);
+
+private final String triggerName;
+private final String clazz;
+
+public CreateTriggerStatement(CFName name, String triggerName, String
clazz)
+{
+super(name);
+this.triggerName = triggerName;
+this.clazz = clazz;
+}
+
+public void checkAccess(ClientState state) throws UnauthorizedException,
InvalidRequestException
+{
+state.hasColumnFamilyAccess(keyspace(), columnFamily(),
Permission.ALTER);
+}
+
+@Override
+public void validate(ClientState state) throws RequestValidationException
+{
+ThriftValidation.validateColumnFamily(keyspace(), columnFamily());
+try
+{
+TriggerExecutor.instance.loadTriggerInstance(clazz);
+}
+catch (Exception ex)
+{
+throw new RequestValidationException(ExceptionCode.INVALID,
Trigger class: + clazz + , doesnt exist., ex) {};
+}
+}
+
+public void announceMigration() throws InvalidRequestException,
ConfigurationException
+{
+CFMetaData cfm = Schema.instance.getCFMetaData(keyspace(),
columnFamily()).clone();
+TriggerOptions.update(cfm, triggerName, clazz);
+logger.info(Adding triggers with name {} and classes {},
triggerName, clazz);
+MigrationManager.announceColumnFamilyUpdate(cfm, false);
+}
+
+public ResultMessage.SchemaChange.Change changeType()
+{
+return ResultMessage.SchemaChange.Change.UPDATED;
+}
+}
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8bf6e155/src/java/org/apache/cassandra/cql3/statements/DropTriggerStatement.java
--
diff --git
a/src/java/org/apache/cassandra/cql3/statements/DropTriggerStatement.java
b/src/java/org/apache/cassandra/cql3/statements/DropTriggerStatement.java
new file mode 100644
index 000..36da2f0
--- /dev/null
+++ b/src/java/org/apache/cassandra/cql3/statements/DropTriggerStatement.java
@@ -0,0 +1,59 @@
+package org.apache.cassandra.cql3.statements;
+
+import org.apache.cassandra.auth.Permission;
+import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.config.Schema;
+import org.apache.cassandra.config.TriggerOptions;
+import org.apache.cassandra.cql3.CFName;
+import org.apache.cassandra.exceptions.ConfigurationException;
+import org.apache.cassandra.exceptions.ExceptionCode;
+import org.apache.cassandra.exceptions.InvalidRequestException;
+import org.apache.cassandra.exceptions.RequestValidationException;
+import org.apache.cassandra.exceptions.UnauthorizedException;
+import org.apache.cassandra.service.ClientState;
+import org.apache.cassandra.service.MigrationManager;
+import org.apache.cassandra.thrift.ThriftValidation;
+import org.apache.cassandra.transport.messages.ResultMessage;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DropTriggerStatement extends SchemaAlteringStatement
+{
+private static final Logger logger =
LoggerFactory.getLogger(DropTriggerStatement.class);
+private final String triggerName;
+
+public DropTriggerStatement(CFName name, String triggerName)
+{
+super(name);
+this.triggerName = triggerName;
+}
+
+public void checkAccess(ClientState state) throws
[jira] [Commented] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684829#comment-13684829
]
Vijay commented on CASSANDRA-5576:
--
{quote}
Speed not affected
{quote}
I am talking about libraries are written on thrift which has to special case
just for triggers if we dont support, though it is not required per say.
{quote}
renamed to just Triggers
{quote}
Triggers class name will cause confusion and hence left it alone and moved it
to config, though I am not sure if thats the right place for it.
Committed to trunk, Glad it is done... and has mapstring, mapstring, string
now :-), Thanks!
CREATE/DROP TRIGGER in CQL
--
Key: CASSANDRA-5576
URL: https://issues.apache.org/jira/browse/CASSANDRA-5576
Project: Cassandra
Issue Type: Bug
Components: API, Core
Reporter: Jonathan Ellis
Assignee: Vijay
Fix For: 2.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay resolved CASSANDRA-5576. -- Resolution: Fixed CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684829#comment-13684829
]
Vijay edited comment on CASSANDRA-5576 at 6/16/13 10:59 PM:
{quote}
Speed not affected
{quote}
I am talking about libraries that are written on thrift which has to special
case just for triggers if we dont support, though it is not required per say.
{quote}
renamed to just Triggers
{quote}
Triggers class name will cause confusion and hence left it alone and moved it
to config, though I am not sure if thats the right place for it.
Committed to trunk, Glad it is done... and has mapstring, mapstring, string
now :-), Thanks!
was (Author: vijay2...@yahoo.com):
{quote}
Speed not affected
{quote}
I am talking about libraries are written on thrift which has to special case
just for triggers if we dont support, though it is not required per say.
{quote}
renamed to just Triggers
{quote}
Triggers class name will cause confusion and hence left it alone and moved it
to config, though I am not sure if thats the right place for it.
Committed to trunk, Glad it is done... and has mapstring, mapstring, string
now :-), Thanks!
CREATE/DROP TRIGGER in CQL
--
Key: CASSANDRA-5576
URL: https://issues.apache.org/jira/browse/CASSANDRA-5576
Project: Cassandra
Issue Type: Bug
Components: API, Core
Reporter: Jonathan Ellis
Assignee: Vijay
Fix For: 2.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684831#comment-13684831 ] Aleksey Yeschenko commented on CASSANDRA-5576: -- Good (: CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5576) CREATE/DROP TRIGGER in CQL
[ https://issues.apache.org/jira/browse/CASSANDRA-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684910#comment-13684910 ] Jonathan Ellis commented on CASSANDRA-5576: --- \o/ On Sun, Jun 16, 2013 at 6:03 PM, Aleksey Yeschenko (JIRA) -- Jonathan Ellis Project Chair, Apache Cassandra co-founder, http://www.datastax.com @spyced CREATE/DROP TRIGGER in CQL -- Key: CASSANDRA-5576 URL: https://issues.apache.org/jira/browse/CASSANDRA-5576 Project: Cassandra Issue Type: Bug Components: API, Core Reporter: Jonathan Ellis Assignee: Vijay Fix For: 2.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-5646) Incompatible sstables hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis resolved CASSANDRA-5646. --- Resolution: Not A Problem Dave is correct; streaming assumes same-version sstables. (More pedantically, it assumes sstables that are isStreamCompatible with the target.) The redesign of streaming for 2.0 plans to make this more flexible. Incompatible sstables hangs repair -- Key: CASSANDRA-5646 URL: https://issues.apache.org/jira/browse/CASSANDRA-5646 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5 Reporter: Radim Kolar repair session between 1.2.5 and 1.2.4: ERROR [Thread-11] 2013-06-16 13:39:39,359 CassandraDaemon.java (line 175) Exception in thread Thread[Thread-11,5,main] java.lang.UnsupportedOperationException: SSTable C:\Program Files (x86)\DataStax Community\data\data\test\sipdb\test-sipdb-hf-16-Data.db is not compatible with current version ic at org.apache.cassandra.streaming.StreamIn.getContextMapping(StreamIn.java:77) at org.apache.cassandra.streaming.IncomingStreamReader.init(IncomingStreamReader.java:87) at org.apache.cassandra.net.IncomingTcpConnection.stream(IncomingTcpConnection.java:238) at org.apache.cassandra.net.IncomingTcpConnection.handleStream(IncomingTcpConnection.java:178) at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:78) using nodetool netstats shows both sstables streaming at 0/XX. repair never finished. After upgrading sstables to latest level (hf and ic should be compatible) repair works fine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
