[jira] [Commented] (CASSANDRA-5626) Support empty IN queries
[ https://issues.apache.org/jira/browse/CASSANDRA-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720472#comment-13720472 ] Sylvain Lebresne commented on CASSANDRA-5626: - +1 on that last patch Support empty IN queries Key: CASSANDRA-5626 URL: https://issues.apache.org/jira/browse/CASSANDRA-5626 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.2.0 Reporter: Alexander Solovyev Assignee: Aleksey Yeschenko Priority: Minor Labels: cql3 Fix For: 1.2.8 Attachments: 5626.txt, 5626-v2.txt, 5626-v2-UPDATE-DELETE.txt It would be nice to have support of empty IN queries. Example: SELECT a FROM t WHERE aKey IN (). One of the reasons is to have such support in DataStax Java Driver (see discussion here: https://datastax-oss.atlassian.net/browse/JAVA-106). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5797) DC-local CAS
[ https://issues.apache.org/jira/browse/CASSANDRA-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-5797: Fix Version/s: (was: 2.0) 2.0 rc1 DC-local CAS Key: CASSANDRA-5797 URL: https://issues.apache.org/jira/browse/CASSANDRA-5797 Project: Cassandra Issue Type: Bug Components: API Affects Versions: 2.0 beta 1 Reporter: Jonathan Ellis Assignee: Sylvain Lebresne Priority: Minor Fix For: 2.0 rc1 Attachments: 0001-Thrift-generated-files.txt, 0002-Add-LOCAL_SERIAL-CL.txt, 0003-CQL-and-native-protocol-changes.txt For two-datacenter deployments where the second DC is strictly for disaster failover, it would be useful to restrict CAS to a single DC to avoid cross-DC round trips. (This would require manually truncating {{system.paxos}} when failing over.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5797) DC-local CAS
[ https://issues.apache.org/jira/browse/CASSANDRA-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720820#comment-13720820 ] Jonathan Ellis commented on CASSANDRA-5797: --- +1 (mostly looked at patch 2) Nit: rename isSameDCThan to isSameDCAs, or maybe better sameDCPredicateFor (since is implies it's doing a boolean evaluation) DC-local CAS Key: CASSANDRA-5797 URL: https://issues.apache.org/jira/browse/CASSANDRA-5797 Project: Cassandra Issue Type: Bug Components: API Affects Versions: 2.0 beta 1 Reporter: Jonathan Ellis Assignee: Sylvain Lebresne Priority: Minor Fix For: 2.0 rc1 Attachments: 0001-Thrift-generated-files.txt, 0002-Add-LOCAL_SERIAL-CL.txt, 0003-CQL-and-native-protocol-changes.txt For two-datacenter deployments where the second DC is strictly for disaster failover, it would be useful to restrict CAS to a single DC to avoid cross-DC round trips. (This would require manually truncating {{system.paxos}} when failing over.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5797) DC-local CAS
[ https://issues.apache.org/jira/browse/CASSANDRA-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-5797: - Reviewer: iamaleksey DC-local CAS Key: CASSANDRA-5797 URL: https://issues.apache.org/jira/browse/CASSANDRA-5797 Project: Cassandra Issue Type: Bug Components: API Affects Versions: 2.0 beta 1 Reporter: Jonathan Ellis Assignee: Sylvain Lebresne Priority: Minor Fix For: 2.0 rc1 Attachments: 0001-Thrift-generated-files.txt, 0002-Add-LOCAL_SERIAL-CL.txt, 0003-CQL-and-native-protocol-changes.txt For two-datacenter deployments where the second DC is strictly for disaster failover, it would be useful to restrict CAS to a single DC to avoid cross-DC round trips. (This would require manually truncating {{system.paxos}} when failing over.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5810) Round-off problem for double values
[ https://issues.apache.org/jira/browse/CASSANDRA-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] koray sariteke updated CASSANDRA-5810: -- Summary: Round-off problem for double values (was: Round problem for double values) Round-off problem for double values --- Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Core Environment: Cassandra 1.2.6, JavaSE 1.6.0_45-b06 Reporter: koray sariteke When wide row column family is created, CQL rounds-off double values for columns which are not included compound keys(partial key and clustered keys). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5797) DC-local CAS
[ https://issues.apache.org/jira/browse/CASSANDRA-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-5797: - Reviewer: jbellis (was: iamaleksey) DC-local CAS Key: CASSANDRA-5797 URL: https://issues.apache.org/jira/browse/CASSANDRA-5797 Project: Cassandra Issue Type: Bug Components: API Affects Versions: 2.0 beta 1 Reporter: Jonathan Ellis Assignee: Sylvain Lebresne Priority: Minor Fix For: 2.0 rc1 Attachments: 0001-Thrift-generated-files.txt, 0002-Add-LOCAL_SERIAL-CL.txt, 0003-CQL-and-native-protocol-changes.txt For two-datacenter deployments where the second DC is strictly for disaster failover, it would be useful to restrict CAS to a single DC to avoid cross-DC round trips. (This would require manually truncating {{system.paxos}} when failing over.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5810) Round problem for double values
koray sariteke created CASSANDRA-5810: - Summary: Round problem for double values Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Core Environment: Cassandra 1.2.6, JavaSE 1.6.0_45-b06 Reporter: koray sariteke When wide row column family is created, CQL rounds-off double values for columns which are not included compound keys(partial key and clustered keys). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5810) Round-off problem for double values
[ https://issues.apache.org/jira/browse/CASSANDRA-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] koray sariteke updated CASSANDRA-5810: -- Description: When wide row column family is created, CQL rounds-off double values was: When wide row column family is created, CQL rounds-off double values for columns which are not included compound keys(partial key and clustered keys). Round-off problem for double values --- Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Core Environment: Cassandra 1.2.6, JavaSE 1.6.0_45-b06 Reporter: koray sariteke When wide row column family is created, CQL rounds-off double values -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5810) Round-off problem for double values
[ https://issues.apache.org/jira/browse/CASSANDRA-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] koray sariteke updated CASSANDRA-5810: -- Description: When wide row column family is created, CQL rounds-off double values. was: When wide row column family is created, CQL rounds-off double values Environment: Cassandra 1.2.6, CQL3, JavaSE 1.6.0_45-b06 (was: Cassandra 1.2.6, JavaSE 1.6.0_45-b06) Round-off problem for double values --- Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Core Environment: Cassandra 1.2.6, CQL3, JavaSE 1.6.0_45-b06 Reporter: koray sariteke When wide row column family is created, CQL rounds-off double values. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5810) Round-off problem for double values
[ https://issues.apache.org/jira/browse/CASSANDRA-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720831#comment-13720831 ] koray sariteke commented on CASSANDRA-5810: --- To simulate the issue, create a table at CQL as CREATE KEYSPACE demodb WITH replication = { 'class': 'SimpleStrategy', 'replication_factor': '1' }; USE demodb; CREATE TABLE demo ( colm1 double, colm2 double, colm3 double, PRIMARY KEY (colm1, colm2) ) WITH compression = { 'sstable_compression' : 'DeflateCompressor', 'chunk_length_kb' : 64 } AND compaction = { 'class' : 'LeveledCompactionStrategy', 'sstable_size_in_mb' : 10 }; Then insert values for demo insert into demo (colm1, colm2 , colm3) VALUES ( -32.084741211,-32.084741211,-32.084741211); when select is performed; cqlsh:demodb select * from demo ; colm1 | colm2 | colm3 ---+---+--- -32.1 | -32.1 | -32.1 By the way, when i checked at CLI [default@unknown] use demodb; Authenticated to keyspace: demodb [default@demodb] list demo; Using default limit of 100 Using default cell limit of 100 --- RowKey: -32.084741211 = (name=-32.084741211:, value=, timestamp=1374848528177000) = (name=-32.084741211:colm3, value=c0400001, timestamp=1374848528177000) row key is defined true but clustered column and value column keeps a hex value which i could not decode yet. Round-off problem for double values --- Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Core Environment: Cassandra 1.2.6, JavaSE 1.6.0_45-b06 Reporter: koray sariteke When wide row column family is created, CQL rounds-off double values -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5810) Round-off problem for double values
[ https://issues.apache.org/jira/browse/CASSANDRA-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-5810: -- Component/s: (was: Core) Tools Priority: Minor (was: Major) Assignee: Aleksey Yeschenko Is this a cqlsh bug? Round-off problem for double values --- Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Tools Environment: Cassandra 1.2.6, CQL3, JavaSE 1.6.0_45-b06 Reporter: koray sariteke Assignee: Aleksey Yeschenko Priority: Minor When wide row column family is created, CQL rounds-off double values. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-5810) Round-off problem for double values
[ https://issues.apache.org/jira/browse/CASSANDRA-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko resolved CASSANDRA-5810. -- Resolution: Invalid Nope, it's the default float precision (set to 5, in this case rounds up to .1, as it should). If you need more precision shown by cqlsh, set something like {noformat} [ui] float_precision = 10 {noformat} in your ~/.cqlshrc Round-off problem for double values --- Key: CASSANDRA-5810 URL: https://issues.apache.org/jira/browse/CASSANDRA-5810 Project: Cassandra Issue Type: Bug Components: Tools Environment: Cassandra 1.2.6, CQL3, JavaSE 1.6.0_45-b06 Reporter: koray sariteke Assignee: Aleksey Yeschenko Priority: Minor When wide row column family is created, CQL rounds-off double values. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[1/2] DC-local CAS
Updated Branches: refs/heads/trunk afe4d555b - bfd73beaf http://git-wip-us.apache.org/repos/asf/cassandra/blob/bfd73bea/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java -- diff --git a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java index 2f9627b..8b9f7df 100644 --- a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java @@ -138,8 +138,10 @@ public class SelectStatement implements CQLStatement // Nothing to do, all validation has been done by RawStatement.prepare() } -public ResultMessage.Rows execute(ConsistencyLevel cl, QueryState state, ListByteBuffer variables, int pageSize, PagingState pagingState) throws RequestExecutionException, RequestValidationException +public ResultMessage.Rows execute(QueryState state, QueryOptions options) throws RequestExecutionException, RequestValidationException { +ConsistencyLevel cl = options.getConsistency(); +ListByteBuffer variables = options.getValues(); if (cl == null) throw new InvalidRequestException(Invalid empty consistency level); @@ -158,18 +160,19 @@ public class SelectStatement implements CQLStatement command = commands == null ? null : new Pageable.ReadCommands(commands); } +int pageSize = options.getPageSize(); // A count query will never be paged for the user, but we always page it internally to avoid OOM. // If we user provided a pageSize we'll use that to page internally (because why not), otherwise we use our default -if (parameters.isCount pageSize 0) +if (parameters.isCount pageSize = 0) pageSize = DEFAULT_COUNT_PAGE_SIZE; -if (pageSize 0 || command == null || !QueryPagers.mayNeedPaging(command, pageSize)) +if (pageSize = 0 || command == null || !QueryPagers.mayNeedPaging(command, pageSize)) { return execute(command, cl, variables, limit, now); } else { -QueryPager pager = QueryPagers.pager(command, cl, pagingState); +QueryPager pager = QueryPagers.pager(command, cl, options.getPagingState()); if (parameters.isCount) return pageCountQuery(pager, variables, pageSize, now); http://git-wip-us.apache.org/repos/asf/cassandra/blob/bfd73bea/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java -- diff --git a/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java b/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java index c66608b..318995e 100644 --- a/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java @@ -55,7 +55,7 @@ public class TruncateStatement extends CFStatement implements CQLStatement ThriftValidation.validateColumnFamily(keyspace(), columnFamily()); } -public ResultMessage execute(ConsistencyLevel cl, QueryState state, ListByteBuffer variables, int pageSize, PagingState pagingState) throws InvalidRequestException, TruncateException +public ResultMessage execute(QueryState state, QueryOptions options) throws InvalidRequestException, TruncateException { try { http://git-wip-us.apache.org/repos/asf/cassandra/blob/bfd73bea/src/java/org/apache/cassandra/cql3/statements/UseStatement.java -- diff --git a/src/java/org/apache/cassandra/cql3/statements/UseStatement.java b/src/java/org/apache/cassandra/cql3/statements/UseStatement.java index c2e3c34..ab42fed 100644 --- a/src/java/org/apache/cassandra/cql3/statements/UseStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/UseStatement.java @@ -21,6 +21,7 @@ import java.nio.ByteBuffer; import java.util.List; import org.apache.cassandra.cql3.CQLStatement; +import org.apache.cassandra.cql3.QueryOptions; import org.apache.cassandra.db.ConsistencyLevel; import org.apache.cassandra.exceptions.InvalidRequestException; import org.apache.cassandra.exceptions.UnauthorizedException; @@ -52,7 +53,7 @@ public class UseStatement extends ParsedStatement implements CQLStatement { } -public ResultMessage execute(ConsistencyLevel cl, QueryState state, ListByteBuffer variables, int pageSize, PagingState pagingState) throws InvalidRequestException +public ResultMessage execute(QueryState state, QueryOptions options) throws InvalidRequestException { state.getClientState().setKeyspace(keyspace); return new ResultMessage.SetKeyspace(keyspace);
[jira] [Commented] (CASSANDRA-5797) DC-local CAS
[ https://issues.apache.org/jira/browse/CASSANDRA-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720883#comment-13720883 ] Aleksey Yeschenko commented on CASSANDRA-5797: -- QueryOptions.Codec.encode() writes flags before writing the CL - should be reversed. Otherwise LGTM. DC-local CAS Key: CASSANDRA-5797 URL: https://issues.apache.org/jira/browse/CASSANDRA-5797 Project: Cassandra Issue Type: Bug Components: API Affects Versions: 2.0 beta 1 Reporter: Jonathan Ellis Assignee: Sylvain Lebresne Priority: Minor Fix For: 2.0 rc1 Attachments: 0001-Thrift-generated-files.txt, 0002-Add-LOCAL_SERIAL-CL.txt, 0003-CQL-and-native-protocol-changes.txt For two-datacenter deployments where the second DC is strictly for disaster failover, it would be useful to restrict CAS to a single DC to avoid cross-DC round trips. (This would require manually truncating {{system.paxos}} when failing over.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Fix QueryOptions.encode order
Updated Branches: refs/heads/trunk bfd73beaf - 791522597 Fix QueryOptions.encode order Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/79152259 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/79152259 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/79152259 Branch: refs/heads/trunk Commit: 791522597eb88248583dd83592af2522f44e5873 Parents: bfd73be Author: Sylvain Lebresne sylv...@datastax.com Authored: Fri Jul 26 17:33:19 2013 +0200 Committer: Sylvain Lebresne sylv...@datastax.com Committed: Fri Jul 26 17:33:19 2013 +0200 -- src/java/org/apache/cassandra/cql3/QueryOptions.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/79152259/src/java/org/apache/cassandra/cql3/QueryOptions.java -- diff --git a/src/java/org/apache/cassandra/cql3/QueryOptions.java b/src/java/org/apache/cassandra/cql3/QueryOptions.java index 662d463..9d8ab72 100644 --- a/src/java/org/apache/cassandra/cql3/QueryOptions.java +++ b/src/java/org/apache/cassandra/cql3/QueryOptions.java @@ -216,8 +216,8 @@ public class QueryOptions } CBUtil.BufferBuilder builder = new CBUtil.BufferBuilder(nbBuff, 0, options.values.size() + (flags.contains(Flag.PAGING_STATE) ? 1 : 0)); -builder.add(CBUtil.byteToCB((byte)Flag.serialize(flags))); builder.add(CBUtil.consistencyLevelToCB(options.getConsistency())); +builder.add(CBUtil.byteToCB((byte)Flag.serialize(flags))); if (flags.contains(Flag.VALUES)) {
[jira] [Resolved] (CASSANDRA-5758) Any exception hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams resolved CASSANDRA-5758. - Resolution: Fixed Any exception hangs repair -- Key: CASSANDRA-5758 URL: https://issues.apache.org/jira/browse/CASSANDRA-5758 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5, 2.0 beta 1 Reporter: Radim Kolar Fix For: 2.0 beta 2 If there is any exception during repair, it hangs and never complete. This is far away from optimal error handling. CASSANDRA-5646 and CASSANDRA-5757 and probably much other issues can be used to reproduce this problem for testing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5758) Any exception hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-5758: Fix Version/s: (was: 2.0 beta 2) 2.0 rc1 Any exception hangs repair -- Key: CASSANDRA-5758 URL: https://issues.apache.org/jira/browse/CASSANDRA-5758 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5, 2.0 beta 1 Reporter: Radim Kolar Fix For: 2.0 rc1 If there is any exception during repair, it hangs and never complete. This is far away from optimal error handling. CASSANDRA-5646 and CASSANDRA-5757 and probably much other issues can be used to reproduce this problem for testing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-5758) Any exception hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reopened CASSANDRA-5758: - Any exception hangs repair -- Key: CASSANDRA-5758 URL: https://issues.apache.org/jira/browse/CASSANDRA-5758 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5, 2.0 beta 1 Reporter: Radim Kolar Fix For: 2.0 beta 2 If there is any exception during repair, it hangs and never complete. This is far away from optimal error handling. CASSANDRA-5646 and CASSANDRA-5757 and probably much other issues can be used to reproduce this problem for testing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5758) Any exception hangs repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-5758: Fix Version/s: 2.0 beta 2 I'm pretty sure if nothing else 0cc0d8ded34051bf94e936dc4564b634a68ea864 fixed this. Any exception hangs repair -- Key: CASSANDRA-5758 URL: https://issues.apache.org/jira/browse/CASSANDRA-5758 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.2.5, 2.0 beta 1 Reporter: Radim Kolar Fix For: 2.0 beta 2 If there is any exception during repair, it hangs and never complete. This is far away from optimal error handling. CASSANDRA-5646 and CASSANDRA-5757 and probably much other issues can be used to reproduce this problem for testing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[2/3] git commit: Retry important messages for any IOException
Retry important messages for any IOException patch by Ashley Winters; reveiewed by yukim for CASSANDRA-5804 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dfa59e37 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dfa59e37 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dfa59e37 Branch: refs/heads/trunk Commit: dfa59e372ef00545ff1c8e1aed8da1c002fd6db8 Parents: 1810af4 Author: Ashley Winters ashley.wint...@freedomvoice.com Authored: Fri Jul 26 10:50:28 2013 -0500 Committer: Yuki Morishita yu...@apache.org Committed: Fri Jul 26 10:50:28 2013 -0500 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dfa59e37/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 858bbf8..077a986 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,6 @@ 1.2.8 * cqlsh: add collections support to COPY (CASSANDRA-5698) + * retry important messages for any IOException (CASSANDRA-5804) 1.2.7 http://git-wip-us.apache.org/repos/asf/cassandra/blob/dfa59e37/src/java/org/apache/cassandra/net/OutboundTcpConnection.java -- diff --git a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java index 648123b..4edac5d 100644 --- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java +++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java @@ -215,7 +215,7 @@ public class OutboundTcpConnection extends Thread // if the message was important, such as a repair acknowledgement, put it back on the queue // to retry after re-connecting. See CASSANDRA-5393 -if (e instanceof SocketException qm.shouldRetry()) +if (qm.shouldRetry()) { try {
[3/3] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f921965a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f921965a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f921965a Branch: refs/heads/trunk Commit: f921965a0b81f0c1dfdb08c5048eff3644b5dde9 Parents: 7915225 dfa59e3 Author: Yuki Morishita yu...@apache.org Authored: Fri Jul 26 10:51:35 2013 -0500 Committer: Yuki Morishita yu...@apache.org Committed: Fri Jul 26 10:51:35 2013 -0500 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f921965a/CHANGES.txt -- diff --cc CHANGES.txt index 94b5236,077a986..d18ff6e --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,113 -1,6 +1,114 @@@ +2.0.0-rc1 + * fix potential spurious wakeup in AsyncOneResponse (CASSANDRA-5690) + * fix schema-related trigger issues (CASSANDRA-5774) + * Better validation when accessing CQL3 table from thrift (CASSANDRA-5138) + * Fix assertion error during repair (CASSANDRA-5801) + * Fix range tombstone bug (CASSANDRA-5805) + * DC-local CAS (CASSANDRA-5797) + + +2.0.0-beta2 + * Replace countPendingHints with Hints Created metric (CASSANDRA-5746) + * Allow nodetool with no args, and with help to run without a server (CASSANDRA-5734) + * Cleanup AbstractType/TypeSerializer classes (CASSANDRA-5744) + * Remove unimplemented cli option schema-mwt (CASSANDRA-5754) + * Support range tombstones in thrift (CASSANDRA-5435) + * Normalize table-manipulating CQL3 statements' class names (CASSANDRA-5759) + * cqlsh: add missing table options to DESCRIBE output (CASSANDRA-5749) + * Fix assertion error during repair (CASSANDRA-5757) + * Fix bulkloader (CASSANDRA-5542) + * Add LZ4 compression to the native protocol (CASSANDRA-5765) + * Fix bugs in the native protocol v2 (CASSANDRA-5770) + * CAS on 'primary key only' table (CASSANDRA-5715) + * Support streaming SSTables of old versions (CASSANDRA-5772) + * Always respect protocol version in native protocol (CASSANDRA-5778) + * Fix ConcurrentModificationException during streaming (CASSANDRA-5782) + * Update deletion timestamp in Commit#updatesWithPaxosTime (CASSANDRA-5787) + * Thrift cas() method crashes if input columns are not sorted (CASSANDRA-5786) + * Order columns names correctly when querying for CAS (CASSANDRA-5788) + * Fix streaming retry (CASSANDRA-5775) + + +2.0.0-beta1 + * Removed on-heap row cache (CASSANDRA-5348) + * use nanotime consistently for node-local timeouts (CASSANDRA-5581) + * Avoid unnecessary second pass on name-based queries (CASSANDRA-5577) + * Experimental triggers (CASSANDRA-1311) + * JEMalloc support for off-heap allocation (CASSANDRA-3997) + * Single-pass compaction (CASSANDRA-4180) + * Removed token range bisection (CASSANDRA-5518) + * Removed compatibility with pre-1.2.5 sstables and network messages + (CASSANDRA-5511) + * removed PBSPredictor (CASSANDRA-5455) + * CAS support (CASSANDRA-5062, 5441, 5442, 5443, 5619, 5667) + * Leveled compaction performs size-tiered compactions in L0 + (CASSANDRA-5371, 5439) + * Add yaml network topology snitch for mixed ec2/other envs (CASSANDRA-5339) + * Log when a node is down longer than the hint window (CASSANDRA-4554) + * Optimize tombstone creation for ExpiringColumns (CASSANDRA-4917) + * Improve LeveledScanner work estimation (CASSANDRA-5250, 5407) + * Replace compaction lock with runWithCompactionsDisabled (CASSANDRA-3430) + * Change Message IDs to ints (CASSANDRA-5307) + * Move sstable level information into the Stats component, removing the + need for a separate Manifest file (CASSANDRA-4872) + * avoid serializing to byte[] on commitlog append (CASSANDRA-5199) + * make index_interval configurable per columnfamily (CASSANDRA-3961, CASSANDRA-5650) + * add default_time_to_live (CASSANDRA-3974) + * add memtable_flush_period_in_ms (CASSANDRA-4237) + * replace supercolumns internally by composites (CASSANDRA-3237, 5123) + * upgrade thrift to 0.9.0 (CASSANDRA-3719) + * drop unnecessary keyspace parameter from user-defined compaction API + (CASSANDRA-5139) + * more robust solution to incomplete compactions + counters (CASSANDRA-5151) + * Change order of directory searching for c*.in.sh (CASSANDRA-3983) + * Add tool to reset SSTable compaction level for LCS (CASSANDRA-5271) + * Allow custom configuration loader (CASSANDRA-5045) + * Remove memory emergency pressure valve logic (CASSANDRA-3534) + * Reduce request latency with eager retry (CASSANDRA-4705) + * cqlsh: Remove ASSUME command
Git Push Summary
Updated Tags: refs/tags/1.2.7-tentative [deleted] ce4e4b9b5
[jira] [Resolved] (CASSANDRA-5808) repair: sync failed exception
[ https://issues.apache.org/jira/browse/CASSANDRA-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams resolved CASSANDRA-5808. - Resolution: Invalid You need the exception from the source node, which is probably CASSANDRA-5801 repair: sync failed exception - Key: CASSANDRA-5808 URL: https://issues.apache.org/jira/browse/CASSANDRA-5808 Project: Cassandra Issue Type: Bug Affects Versions: 2.0 beta 2 Reporter: Radim Kolar Priority: Minor this might be just secondary exception caused by something else ERROR 01:54:30,125 Repair session b4fe3820-f57e-11e2-981c-c38e7fba9d51 for range (6833553681770550976,8892198649934659692] failed with error org.apache.cassandr a.exceptions.RepairException: [repair #b4fe3820-f57e-11e2-981c-c38e7fba9d51 on t est/sipdb, (6833553681770550976,8892198649934659692]] Sync failed between /10.0. 0.1 and /10.0.0.3 java.util.concurrent.ExecutionException: java.lang.RuntimeException: org.apache. cassandra.exceptions.RepairException: [repair #b4fe3820-f57e-11e2-981c-c38e7fba9 d51 on test/sipdb, (6833553681770550976,8892198649934659692]] Sync failed betwee n /10.0.0.1 and /10.0.0.3 at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:252) at java.util.concurrent.FutureTask.get(FutureTask.java:111) at org.apache.cassandra.service.StorageService$4.runMayThrow(StorageServ ice.java:2400) at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:2 8) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:47 1) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Git Push Summary
Updated Tags: refs/tags/cassandra-1.2.7 [created] 8430c8f30
[jira] [Resolved] (CASSANDRA-5807) validation failed during repair
[ https://issues.apache.org/jira/browse/CASSANDRA-5807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams resolved CASSANDRA-5807. - Resolution: Invalid You need the exception from the source node, which is probably CASSANDRA-5801. validation failed during repair --- Key: CASSANDRA-5807 URL: https://issues.apache.org/jira/browse/CASSANDRA-5807 Project: Cassandra Issue Type: Bug Affects Versions: 2.0 beta 2 Reporter: Radim Kolar Priority: Minor INFO 01:05:25,078 [repair #b085cf60-f57e-11e2-981c-c38e7fba9d51] new session: w ill sync /10.0.0.1, /10.0.0.3 on range (-4831857050499933252,-260562612586293613 3] for test.[sipdb] ERROR 01:05:25,078 [repair #aedfc080-f57e-11e2-981c-c38e7fba9d51] session comple ted with the following error org.apache.cassandra.exceptions.RepairException: [repair #aedfc080-f57e-11e2-981 c-c38e7fba9d51 on test/sipdb, (8892198649934659692,-9062237682932646949]] Valida tion failed in /10.0.0.1 at org.apache.cassandra.repair.RepairSession.validationComplete(RepairSe ssion.java:152) at org.apache.cassandra.service.ActiveRepairService.handleMessage(Active RepairService.java:188) at org.apache.cassandra.repair.RepairMessageVerbHandler.doVerb(RepairMes sageVerbHandler.java:59) at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask. java:56) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor. java:1145) + repair hangs (as usual) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[1/3] git commit: Retry important messages for any IOException
Updated Branches: refs/heads/cassandra-1.2 1810af404 - dfa59e372 refs/heads/trunk 791522597 - f921965a0 Retry important messages for any IOException patch by Ashley Winters; reveiewed by yukim for CASSANDRA-5804 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dfa59e37 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dfa59e37 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dfa59e37 Branch: refs/heads/cassandra-1.2 Commit: dfa59e372ef00545ff1c8e1aed8da1c002fd6db8 Parents: 1810af4 Author: Ashley Winters ashley.wint...@freedomvoice.com Authored: Fri Jul 26 10:50:28 2013 -0500 Committer: Yuki Morishita yu...@apache.org Committed: Fri Jul 26 10:50:28 2013 -0500 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dfa59e37/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 858bbf8..077a986 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,6 @@ 1.2.8 * cqlsh: add collections support to COPY (CASSANDRA-5698) + * retry important messages for any IOException (CASSANDRA-5804) 1.2.7 http://git-wip-us.apache.org/repos/asf/cassandra/blob/dfa59e37/src/java/org/apache/cassandra/net/OutboundTcpConnection.java -- diff --git a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java index 648123b..4edac5d 100644 --- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java +++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java @@ -215,7 +215,7 @@ public class OutboundTcpConnection extends Thread // if the message was important, such as a repair acknowledgement, put it back on the queue // to retry after re-connecting. See CASSANDRA-5393 -if (e instanceof SocketException qm.shouldRetry()) +if (qm.shouldRetry()) { try {
[jira] [Updated] (CASSANDRA-5741) Provide a way to disable automatic index rebuilds during bulk loading
[ https://issues.apache.org/jira/browse/CASSANDRA-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Zamata updated CASSANDRA-5741: -- Component/s: (was: Hadoop) Provide a way to disable automatic index rebuilds during bulk loading - Key: CASSANDRA-5741 URL: https://issues.apache.org/jira/browse/CASSANDRA-5741 Project: Cassandra Issue Type: Improvement Affects Versions: 1.2.6 Reporter: Jim Zamata When using the BulkLoadOutputFormat the actual streaming of the SSTables into Cassandra is fast, but the index rebuilds can take several minutes. Cassandra does not send the response until after all of the rebuilds for a streaming session complete. This causes the tasks to appear to hang at 100%, since the record writer streams the files in its close method. If the rebuilding process takes too long, the tasks can actually time out. Many SQL databases provide bulk insert utilities that disable index updates to allow large amounts of data to be added quickly. This functionality would serve a similar purpose. An alternative might be an option that would allow the session to return once the SSTables had been successfully imported without waiting for the index builds to complete. However, I have noticed heavy CPU loads during the index rebuilds, so bulkload performance might be better if this step could be deferred until after all of the data is loaded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1507360 - in /cassandra/site: publish/download/index.html publish/index.html src/settings.py
Author: slebresne Date: Fri Jul 26 16:01:26 2013 New Revision: 1507360 URL: http://svn.apache.org/r1507360 Log: Update website for 1.2.7 release Modified: cassandra/site/publish/download/index.html cassandra/site/publish/index.html cassandra/site/src/settings.py Modified: cassandra/site/publish/download/index.html URL: http://svn.apache.org/viewvc/cassandra/site/publish/download/index.html?rev=1507360r1=1507359r2=1507360view=diff == --- cassandra/site/publish/download/index.html (original) +++ cassandra/site/publish/download/index.html Fri Jul 26 16:01:26 2013 @@ -49,8 +49,8 @@ Cassandra releases include the core server, the a href=http://wiki.apache.org/cassandra/NodeTool;nodetool/a administration command-line interface, and a development shell (a href=http://cassandra.apache.org/doc/cql/CQL.html;ttcqlsh/tt/a and the old ttcassandra-cli/tt). p - The latest stable release of Apache Cassandra is 1.2.6 - (released on 2013-06-26). iIf you're just + The latest stable release of Apache Cassandra is 1.2.7 + (released on 2013-07-26). iIf you're just starting out, download this one./i /p @@ -59,13 +59,13 @@ ul li a class=filename - href=http://www.apache.org/dyn/closer.cgi?path=/cassandra/1.2.6/apache-cassandra-1.2.6-bin.tar.gz; + href=http://www.apache.org/dyn/closer.cgi?path=/cassandra/1.2.7/apache-cassandra-1.2.7-bin.tar.gz; onclick=javascript: pageTracker._trackPageview('/clicks/binary_download'); - apache-cassandra-1.2.6-bin.tar.gz + apache-cassandra-1.2.7-bin.tar.gz /a -[a href=http://www.apache.org/dist/cassandra/1.2.6/apache-cassandra-1.2.6-bin.tar.gz.asc;PGP/a] -[a href=http://www.apache.org/dist/cassandra/1.2.6/apache-cassandra-1.2.6-bin.tar.gz.md5;MD5/a] -[a href=http://www.apache.org/dist/cassandra/1.2.6/apache-cassandra-1.2.6-bin.tar.gz.sha1;SHA1/a] +[a href=http://www.apache.org/dist/cassandra/1.2.7/apache-cassandra-1.2.7-bin.tar.gz.asc;PGP/a] +[a href=http://www.apache.org/dist/cassandra/1.2.7/apache-cassandra-1.2.7-bin.tar.gz.md5;MD5/a] +[a href=http://www.apache.org/dist/cassandra/1.2.7/apache-cassandra-1.2.7-bin.tar.gz.sha1;SHA1/a] /li li a href=http://wiki.apache.org/cassandra/DebianPackaging;Debian installation instructions/a @@ -169,13 +169,13 @@ ul li a class=filename - href=http://www.apache.org/dyn/closer.cgi?path=/cassandra/1.2.6/apache-cassandra-1.2.6-src.tar.gz; + href=http://www.apache.org/dyn/closer.cgi?path=/cassandra/1.2.7/apache-cassandra-1.2.7-src.tar.gz; onclick=javascript: pageTracker._trackPageview('/clicks/source_download'); - apache-cassandra-1.2.6-src.tar.gz + apache-cassandra-1.2.7-src.tar.gz /a -[a href=http://www.apache.org/dist/cassandra/1.2.6/apache-cassandra-1.2.6-src.tar.gz.asc;PGP/a] -[a href=http://www.apache.org/dist/cassandra/1.2.6/apache-cassandra-1.2.6-src.tar.gz.md5;MD5/a] -[a href=http://www.apache.org/dist/cassandra/1.2.6/apache-cassandra-1.2.6-src.tar.gz.sha1;SHA1/a] +[a href=http://www.apache.org/dist/cassandra/1.2.7/apache-cassandra-1.2.7-src.tar.gz.asc;PGP/a] +[a href=http://www.apache.org/dist/cassandra/1.2.7/apache-cassandra-1.2.7-src.tar.gz.md5;MD5/a] +[a href=http://www.apache.org/dist/cassandra/1.2.7/apache-cassandra-1.2.7-src.tar.gz.sha1;SHA1/a] /li li Modified: cassandra/site/publish/index.html URL: http://svn.apache.org/viewvc/cassandra/site/publish/index.html?rev=1507360r1=1507359r2=1507360view=diff == --- cassandra/site/publish/index.html (original) +++ cassandra/site/publish/index.html Fri Jul 26 16:01:26 2013 @@ -76,8 +76,8 @@ h2Download/h2 div class=inner rc p -The latest release is b1.2.6/b -span class=relnotes(a href=http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=CHANGES.txt;hb=refs/tags/cassandra-1.2.6;Changes/a)/span +The latest release is b1.2.7/b +span class=relnotes(a href=http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blob_plain;f=CHANGES.txt;hb=refs/tags/cassandra-1.2.7;Changes/a)/span /p pa class=filename href=/download/Download options/a/p Modified: cassandra/site/src/settings.py URL: http://svn.apache.org/viewvc/cassandra/site/src/settings.py?rev=1507360r1=1507359r2=1507360view=diff == --- cassandra/site/src/settings.py (original) +++ cassandra/site/src/settings.py Fri Jul 26 16:01:26 2013 @@ -98,8 +98,8 @@ class CassandraDef(object): veryoldstable_version = '1.0.12' veryoldstable_release_date = '2012-10-04' veryoldstable_exists = True -stable_version = '1.2.6' -stable_release_date = '2013-06-26' +stable_version = '1.2.7' +stable_release_date = '2013-07-26'
git commit: streaming logging improvement
Updated Branches: refs/heads/trunk f921965a0 - 1e73b330a streaming logging improvement Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1e73b330 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1e73b330 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1e73b330 Branch: refs/heads/trunk Commit: 1e73b330aca294b924e5045905db615e77b13690 Parents: f921965 Author: Yuki Morishita yu...@apache.org Authored: Wed Jul 24 14:33:04 2013 -0500 Committer: Yuki Morishita yu...@apache.org Committed: Fri Jul 26 11:02:05 2013 -0500 -- .../cassandra/streaming/ConnectionHandler.java| 7 +++ .../cassandra/streaming/StreamResultFuture.java | 17 - .../apache/cassandra/streaming/StreamSession.java | 18 +++--- .../streaming/messages/CompleteMessage.java | 6 ++ .../cassandra/streaming/messages/FileMessage.java | 2 +- .../streaming/messages/FileMessageHeader.java | 14 ++ .../streaming/messages/PrepareMessage.java| 4 ++-- .../streaming/messages/ReceivedMessage.java | 8 .../streaming/messages/RetryMessage.java | 8 .../streaming/messages/SessionFailedMessage.java | 6 ++ 10 files changed, 67 insertions(+), 23 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/1e73b330/src/java/org/apache/cassandra/streaming/ConnectionHandler.java -- diff --git a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java index c4f2181..092d6a3 100644 --- a/src/java/org/apache/cassandra/streaming/ConnectionHandler.java +++ b/src/java/org/apache/cassandra/streaming/ConnectionHandler.java @@ -125,7 +125,6 @@ public class ConnectionHandler { try { -logger.info(Connecting to {} for streaming, peer); Socket socket = OutboundTcpConnectionPool.newSocket(peer); socket.setSoTimeout(DatabaseDescriptor.getStreamingSocketTimeout()); return socket; @@ -151,7 +150,7 @@ public class ConnectionHandler public ListenableFuture? close() { -logger.debug(Closing stream connection handler on {}, session.peer); +logger.debug([Stream #{}] Closing stream connection handler on {}, session.planId(), session.peer); ListenableFuture? inClosed = incoming == null ? Futures.immediateFuture(null) : incoming.close(); ListenableFuture? outClosed = outgoing == null ? Futures.immediateFuture(null) : outgoing.close(); @@ -290,7 +289,7 @@ public class ConnectionHandler // to ignore here since we'll have asked for a retry. if (message != null) { -logger.debug(Received {}, message); +logger.debug([Stream #{}] Received {}, session.planId(), message); session.messageReceived(message); } } @@ -354,7 +353,7 @@ public class ConnectionHandler { if ((next = messageQueue.poll(1, TimeUnit.SECONDS)) != null) { -logger.debug(Sending {}, next); +logger.debug([Stream #{}] Sending {}, session.planId(), next); sendMessage(next); if (next.type == StreamMessage.Type.SESSION_FAILED) close(); http://git-wip-us.apache.org/repos/asf/cassandra/blob/1e73b330/src/java/org/apache/cassandra/streaming/StreamResultFuture.java -- diff --git a/src/java/org/apache/cassandra/streaming/StreamResultFuture.java b/src/java/org/apache/cassandra/streaming/StreamResultFuture.java index d9189c5..979c19a 100644 --- a/src/java/org/apache/cassandra/streaming/StreamResultFuture.java +++ b/src/java/org/apache/cassandra/streaming/StreamResultFuture.java @@ -78,9 +78,11 @@ public final class StreamResultFuture extends AbstractFutureStreamState { StreamResultFuture future = createAndRegister(planId, description, sessions); +logger.info([Stream #{}] Executing streaming plan for {}, planId, description); // start sessions for (final StreamSession session : sessions) { +logger.info([Stream #{}] Beginning stream session with {}, planId, session.peer); session.init(future); session.start(); } @@ -110,6 +112,7 @@ public final class StreamResultFuture extends AbstractFutureStreamState else { future.attachSocket(from,
svn commit: r1507361 - /cassandra/site/publish/doc/cql3/CQL.html
Author: slebresne Date: Fri Jul 26 16:02:29 2013 New Revision: 1507361 URL: http://svn.apache.org/r1507361 Log: Update CQL doc on website too Modified: cassandra/site/publish/doc/cql3/CQL.html Modified: cassandra/site/publish/doc/cql3/CQL.html URL: http://svn.apache.org/viewvc/cassandra/site/publish/doc/cql3/CQL.html?rev=1507361r1=1507360r2=1507361view=diff == --- cassandra/site/publish/doc/cql3/CQL.html (original) +++ cassandra/site/publish/doc/cql3/CQL.html Fri Jul 26 16:02:29 2013 @@ -1,7 +1,9 @@ ?xml version='1.0' encoding='utf-8' ?!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Transitional//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;html xmlns=http://www.w3.org/1999/xhtml;headmeta http-equiv=Content-Type content=text/html; charset=utf-8/titleCQL/title/headbodyplink rel=StyleSheet href=CQL.css type=text/css media=screen/ph1 id=CassandraQueryLanguageCQLv3.0.4Cassandra Query Language (CQL) v3.0.4/h1span id=tableOfContentsol style=list-style: none;lia href=CQL.html#CassandraQueryLanguageCQLv3.0.4Cassandra Query Language (CQL) v3.0.4/aol style=list-style: none;lia href=CQL.html#CQLSyntaxCQL Syntax/aol style=list-style: none;lia href=CQL.html#PreamblePreamble/a/lilia href=CQL.html#ConventionsConventions/a/lilia href=CQL.html#identifiersIdentifiers and keywords/a/lilia href=CQL.html#constantsConstants/a/lilia href=CQL.html#CommentsComments/a/l ilia href=CQL.html#statementsStatements/a/lilia href=CQL.html#preparedStatementPrepared Statement/a/li/ol/lilia href=CQL.html#dataDefinitionData Definition/aol style=list-style: none;lia href=CQL.html#createKeyspaceStmtCREATE KEYSPACE/a/lilia href=CQL.html#useStmtUSE/a/lilia href=CQL.html#alterKeyspaceStmtALTER KEYSPACE/a/lilia href=CQL.html#dropKeyspaceStmtDROP KEYSPACE/a/lilia href=CQL.html#createTableStmtCREATE TABLE/a/lilia href=CQL.html#alterTableStmtALTER TABLE/a/lilia href=CQL.html#dropTableStmtDROP TABLE/a/lilia href=CQL.html#truncateStmtTRUNCATE/a/lilia href=CQL.html#createIndexStmtCREATE INDEX/a/lilia href=CQL.html#dropIndexStmtDROP INDEX/a/li/ol/lilia href=CQL.html#dataManipulationData Manipulation/aol style=list-style: none;lia href=CQL.html#insertStmtINSERT/a/lilia href=CQL.html#updateStmtUPDATE/a/li lia href=CQL.html#deleteStmtDELETE/a/lilia href=CQL.html#batchStmtBATCH/a/li/ol/lilia href=CQL.html#queriesQueries/aol style=list-style: none;lia href=CQL.html#selectStmtSELECT/a/li/ol/lilia href=CQL.html#typesData Types/aol style=list-style: none;lia href=CQL.html#usingdatesWorking with dates/a/lilia href=CQL.html#countersCounters/a/lilia href=CQL.html#collectionsWorking with collections/a/li/ol/lilia href=CQL.html#functionsFunctions/aol style=list-style: none;lia href=CQL.html#tokenFunToken/a/lilia href=CQL.html#timeuuidFunTimeuuid functions/a/lilia href=CQL.html#blobFunBlob conversion functions/a/li/ol/lilia href=CQL.html#appendixAAppendix A: CQL Keywords/a/lilia href=CQL.html#changesChanges/aol style=list-style: none;lia href=CQL.html#a3.0.43.0.4/a/lilia href=CQL.html#a3.0.33.0.3/a/lilia href=C QL.html#a3.0.23.0.2/a/lilia href=CQL.html#a3.0.13.0.1/a/li/ol/lilia href=CQL.html#VersioningVersioning/a/li/ol/li/ol/spanh2 id=CQLSyntaxCQL Syntax/h2h3 id=PreamblePreamble/h3pThis document describes the Cassandra Query Language (CQL) version 3. CQL v3 is not backward compatible with CQL v2 and differs from it in numerous ways. Note that this document describes the last version of the languages. However, the a href=#changeschanges/a section provides the diff between the different versions of CQL v3./ppCQL v3 offers a model very close to SQL in the sense that data is put in emtables/em containing emrows/em of emcolumns/em. For that reason, when used in this document, these terms (tables, rows and columns) have the same definition than they have in SQL. But please note that as such, they do strongnot/strong refer to the concept of rows and columns found in the internal implementation of Cassandra and in the t hrift and CQL v2 API./ph3 id=ConventionsConventions/h3pTo aid in specifying the CQL syntax, we will use the following conventions in this document:/pulliLanguage rules will be given in a a href=http://en.wikipedia.org/wiki/Backus%E2%80%93Naur_Form;BNF/a -like notation:/li/ulpre class=syntaxprelt;start ::= TERMINAL lt;non-terminal1 lt;non-terminal1 /pre/preulliNonterminal symbols will have codelt;angle brackets/code./liliAs additional shortcut notations to BNF, we#8217;ll use traditional regular expression#8217;s symbols (code?/code, code+/code and code*/code) to signify that a given symbol is optional and/or can be repeated. We#8217;ll also allow parentheses to group symbols and the code[lt;characters]/code notation to represent any one of codelt;characters/code./liliThe grammar is provided for documentation purposes and leave some minor details out. For instance, the last column definition in
git commit: update min version in news
Updated Branches: refs/heads/trunk 1e73b330a - 5c7b2e10c update min version in news Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5c7b2e10 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5c7b2e10 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5c7b2e10 Branch: refs/heads/trunk Commit: 5c7b2e10cc35e0a04f1b175bf59769d6e00d757e Parents: 1e73b33 Author: Brandon Williams brandonwilli...@apache.org Authored: Fri Jul 26 11:22:37 2013 -0500 Committer: Brandon Williams brandonwilli...@apache.org Committed: Fri Jul 26 11:22:44 2013 -0500 -- NEWS.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/5c7b2e10/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index dc3d51a..0acbc76 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -22,9 +22,9 @@ Upgrading timestamps are microseconds-since-epoch. Do not use these features if you are using client-specified timestamps with some other source. -- Upgrading is ONLY supported from Cassandra 1.2.6 or later. This +- Upgrading is ONLY supported from Cassandra 1.2.7 or later. This goes for sstable compatibility as well as network. When - upgrading from an earlier release, upgrade to 1.2.6 first and + upgrading from an earlier release, upgrade to 1.2.7 first and run upgradesstables before proceeding to 2.0. - Replication and strategy options do not accept unknown options anymore. This was already the case for CQL3 in 1.2 but this is now the case for
[jira] [Updated] (CASSANDRA-5084) Cassandra should expose connected client state via JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-5084: -- Reviewer: dbrosius Can you review, Dave? Cassandra should expose connected client state via JMX -- Key: CASSANDRA-5084 URL: https://issues.apache.org/jira/browse/CASSANDRA-5084 Project: Cassandra Issue Type: Improvement Reporter: Robert Coli Priority: Minor Labels: lhf Attachments: 5084-trunk.patch There is currently no good way to determine or estimate how many clients are connected to a cassandra node without using netstat or (if using sync thrift server) counting threads. There is also no way to understand what state any given connection is in. People regularly come into #cassandra/cassandra-user@ and ask how to get the equivalent of a MySQL SHOW FULL PROCESSLIST. While I understand that feature parity with SHOW FULL PROCESSLIST/information_schema.processlist is unlikely, even a few basic metrics like number of connected clients or number of active clients would greatly help with this operational information need. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Allow empty IN relations in SELECT/UPDATE/DELETE statements
Updated Branches: refs/heads/cassandra-1.2 dfa59e372 - dc457c5eb Allow empty IN relations in SELECT/UPDATE/DELETE statements patch by Aleksey Yeschenko; reviewed by Sylvain Lebresne for CASSANDRA-5626 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dc457c5e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dc457c5e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dc457c5e Branch: refs/heads/cassandra-1.2 Commit: dc457c5ebca5654c86b4df8a7574e579bae00b7e Parents: dfa59e3 Author: Aleksey Yeschenko alek...@apache.org Authored: Fri Jul 26 20:02:44 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Fri Jul 26 20:04:02 2013 +0300 -- CHANGES.txt | 1 + doc/cql3/CQL.textile| 12 ++-- src/java/org/apache/cassandra/cql3/Cql.g| 2 +- .../apache/cassandra/cql3/QueryProcessor.java | 2 +- .../cql3/statements/ModificationStatement.java | 6 +- .../cql3/statements/SelectStatement.java| 69 ++-- .../cql3/statements/UpdateStatement.java| 4 +- 7 files changed, 51 insertions(+), 45 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 077a986..fe28eee 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,6 +1,7 @@ 1.2.8 * cqlsh: add collections support to COPY (CASSANDRA-5698) * retry important messages for any IOException (CASSANDRA-5804) + * Allow empty IN relations in SELECT/UPDATE/DELETE statements (CASSANDRA-5626) 1.2.7 http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/doc/cql3/CQL.textile -- diff --git a/doc/cql3/CQL.textile b/doc/cql3/CQL.textile index 44c4dd2..fe64c71 100644 --- a/doc/cql3/CQL.textile +++ b/doc/cql3/CQL.textile @@ -1,6 +1,6 @@ link rel=StyleSheet href=CQL.css type=text/css media=screen -h1. Cassandra Query Language (CQL) v3.0.4 +h1. Cassandra Query Language (CQL) v3.0.5 span id=tableOfContents @@ -469,7 +469,7 @@ bc(syntax).. | identifier '[' term ']' '=' term where-clause ::= identifier '=' term - | identifier IN '(' term ( ',' term )* ')' + | identifier IN '(' ( term ( ',' term )* )? ')' option ::= TIMESTAMP integer | TTL integer @@ -515,7 +515,7 @@ bc(syntax).. selection ::= identifier ( '[' term ']' )? where-clause ::= identifier '=' term - | identifier IN '(' term ( ',' term )* ')' + | identifier IN '(' ( term ( ',' term )* )? ')' p. __Sample:__ @@ -597,7 +597,7 @@ bc(syntax).. where-clause ::= relation ( AND relation )* relation ::= identifier (= | | | = | =) term - | identifier IN '(' term ( ',' term)* ')' + | identifier IN '(' ( term ( ',' term)* )? ')' | TOKEN '(' identifier ')' (= | | | = | =) (term | TOKEN '( term ')' ) order-by ::= ordering ( ',' odering )* @@ -1052,6 +1052,10 @@ h2(#changes). Changes The following describes the addition/changes brought for each version of CQL. +h3. 3.0.5 + +* SELECT, UPDATE, and DELETE statements now allow empty IN relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). + h3. 3.0.4 * Updated the syntax for custom secondary indexes:#createIndexStmt. http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/src/java/org/apache/cassandra/cql3/Cql.g -- diff --git a/src/java/org/apache/cassandra/cql3/Cql.g b/src/java/org/apache/cassandra/cql3/Cql.g index 3ee30d1..6b31da5 100644 --- a/src/java/org/apache/cassandra/cql3/Cql.g +++ b/src/java/org/apache/cassandra/cql3/Cql.g @@ -799,7 +799,7 @@ relation[ListRelation clauses] $clauses.add(new Relation(id, type, t, true)); } | name=cident K_IN { Relation rel = Relation.createInRelation($name.id); } - '(' f1=term { rel.addInValue(f1); } (',' fN=term { rel.addInValue(fN); } )* ')' { $clauses.add(rel); } + '(' ( f1=term { rel.addInValue(f1); } (',' fN=term { rel.addInValue(fN); } )* )? ')' { $clauses.add(rel); } ; comparatorType returns [CQL3Type t] http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/src/java/org/apache/cassandra/cql3/QueryProcessor.java -- diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java b/src/java/org/apache/cassandra/cql3/QueryProcessor.java index fa019c0..4ae1e90 100644 --- a/src/java/org/apache/cassandra/cql3/QueryProcessor.java +++
[2/2] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Conflicts: doc/cql3/CQL.textile src/java/org/apache/cassandra/cql3/QueryProcessor.java src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java src/java/org/apache/cassandra/cql3/statements/SelectStatement.java src/java/org/apache/cassandra/cql3/statements/UpdateStatement.java Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1be575da Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1be575da Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1be575da Branch: refs/heads/trunk Commit: 1be575da0601fed1c84421d6cd602fcb0a90da08 Parents: 5c7b2e1 dc457c5 Author: Aleksey Yeschenko alek...@apache.org Authored: Fri Jul 26 20:37:43 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Fri Jul 26 20:37:43 2013 +0300 -- CHANGES.txt | 1 + doc/cql3/CQL.textile| 10 +++-- src/java/org/apache/cassandra/cql3/Cql.g| 2 +- .../cql3/statements/ModificationStatement.java | 11 +++-- .../cql3/statements/SelectStatement.java| 47 +++- 5 files changed, 43 insertions(+), 28 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/1be575da/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/1be575da/doc/cql3/CQL.textile -- diff --cc doc/cql3/CQL.textile index f63b6b8,fe64c71..dd76228 --- a/doc/cql3/CQL.textile +++ b/doc/cql3/CQL.textile @@@ -1077,13 -1052,10 +1077,17 @@@ h2(#changes). Change The following describes the addition/changes brought for each version of CQL. +h3. 3.1.0 + +* ALTER TABLE:#alterTableStmt @DROP@ option has been reenabled for CQL3 tables and has new semantics now: the space formerly used by dropped columns will now be eventually reclaimed (post-compaction). You should not readd previously dropped columns unless you use timestamps with microsecond precision (see CASSANDRA-3919:https://issues.apache.org/jira/browse/CASSANDRA-3919 for more details). +* @SELECT@ statement now supports aliases in select clause. Aliases in WHERE and ORDER BY clauses are not supported. See the section on select#selectStmt for details. +* @CREATE@ statements for @KEYSPACE@, @TABLE@ and @INDEX@ now supports an @IF NOT EXISTS@ condition. Similarly, @DROP@ statements support a @IF EXISTS@ condition. +* @INSERT@ statements optionally supports a @IF NOT EXISTS@ condition and @UDPATE@ supports @IF@ conditions. + + h3. 3.0.5 + + * SELECT, UPDATE, and DELETE statements now allow empty IN relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). + h3. 3.0.4 * Updated the syntax for custom secondary indexes:#createIndexStmt. http://git-wip-us.apache.org/repos/asf/cassandra/blob/1be575da/src/java/org/apache/cassandra/cql3/Cql.g -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/1be575da/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java -- diff --cc src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java index 0aa188d,5ede98f..d08d0ee --- a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java @@@ -109,175 -69,76 +109,175 @@@ public abstract class ModificationState public void validate(ClientState state) throws InvalidRequestException { -if (timeToLive 0) -throw new InvalidRequestException(A TTL must be greater or equal to 0); - -if (timeToLive ExpiringColumn.MAX_TTL) -throw new InvalidRequestException(String.format(ttl is too large. requested (%d) maximum (%d), timeToLive, ExpiringColumn.MAX_TTL)); } -protected abstract void validateConsistency(ConsistencyLevel cl) throws InvalidRequestException; +public void addOperation(Operation op) +{ +columnOperations.add(op); +} -public ResultMessage execute(ConsistencyLevel cl, QueryState queryState, ListByteBuffer variables) throws RequestExecutionException, RequestValidationException +public ListOperation getOperations() { -if (cl == null) -throw new InvalidRequestException(Invalid empty consistency level); +return columnOperations; +} -validateConsistency(cl); +public void addCondition(Operation op) +{ +if (columnConditions == null) +columnConditions =
[1/2] git commit: Allow empty IN relations in SELECT/UPDATE/DELETE statements
Updated Branches: refs/heads/trunk 5c7b2e10c - 1be575da0 Allow empty IN relations in SELECT/UPDATE/DELETE statements patch by Aleksey Yeschenko; reviewed by Sylvain Lebresne for CASSANDRA-5626 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dc457c5e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dc457c5e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dc457c5e Branch: refs/heads/trunk Commit: dc457c5ebca5654c86b4df8a7574e579bae00b7e Parents: dfa59e3 Author: Aleksey Yeschenko alek...@apache.org Authored: Fri Jul 26 20:02:44 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Fri Jul 26 20:04:02 2013 +0300 -- CHANGES.txt | 1 + doc/cql3/CQL.textile| 12 ++-- src/java/org/apache/cassandra/cql3/Cql.g| 2 +- .../apache/cassandra/cql3/QueryProcessor.java | 2 +- .../cql3/statements/ModificationStatement.java | 6 +- .../cql3/statements/SelectStatement.java| 69 ++-- .../cql3/statements/UpdateStatement.java| 4 +- 7 files changed, 51 insertions(+), 45 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 077a986..fe28eee 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,6 +1,7 @@ 1.2.8 * cqlsh: add collections support to COPY (CASSANDRA-5698) * retry important messages for any IOException (CASSANDRA-5804) + * Allow empty IN relations in SELECT/UPDATE/DELETE statements (CASSANDRA-5626) 1.2.7 http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/doc/cql3/CQL.textile -- diff --git a/doc/cql3/CQL.textile b/doc/cql3/CQL.textile index 44c4dd2..fe64c71 100644 --- a/doc/cql3/CQL.textile +++ b/doc/cql3/CQL.textile @@ -1,6 +1,6 @@ link rel=StyleSheet href=CQL.css type=text/css media=screen -h1. Cassandra Query Language (CQL) v3.0.4 +h1. Cassandra Query Language (CQL) v3.0.5 span id=tableOfContents @@ -469,7 +469,7 @@ bc(syntax).. | identifier '[' term ']' '=' term where-clause ::= identifier '=' term - | identifier IN '(' term ( ',' term )* ')' + | identifier IN '(' ( term ( ',' term )* )? ')' option ::= TIMESTAMP integer | TTL integer @@ -515,7 +515,7 @@ bc(syntax).. selection ::= identifier ( '[' term ']' )? where-clause ::= identifier '=' term - | identifier IN '(' term ( ',' term )* ')' + | identifier IN '(' ( term ( ',' term )* )? ')' p. __Sample:__ @@ -597,7 +597,7 @@ bc(syntax).. where-clause ::= relation ( AND relation )* relation ::= identifier (= | | | = | =) term - | identifier IN '(' term ( ',' term)* ')' + | identifier IN '(' ( term ( ',' term)* )? ')' | TOKEN '(' identifier ')' (= | | | = | =) (term | TOKEN '( term ')' ) order-by ::= ordering ( ',' odering )* @@ -1052,6 +1052,10 @@ h2(#changes). Changes The following describes the addition/changes brought for each version of CQL. +h3. 3.0.5 + +* SELECT, UPDATE, and DELETE statements now allow empty IN relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). + h3. 3.0.4 * Updated the syntax for custom secondary indexes:#createIndexStmt. http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/src/java/org/apache/cassandra/cql3/Cql.g -- diff --git a/src/java/org/apache/cassandra/cql3/Cql.g b/src/java/org/apache/cassandra/cql3/Cql.g index 3ee30d1..6b31da5 100644 --- a/src/java/org/apache/cassandra/cql3/Cql.g +++ b/src/java/org/apache/cassandra/cql3/Cql.g @@ -799,7 +799,7 @@ relation[ListRelation clauses] $clauses.add(new Relation(id, type, t, true)); } | name=cident K_IN { Relation rel = Relation.createInRelation($name.id); } - '(' f1=term { rel.addInValue(f1); } (',' fN=term { rel.addInValue(fN); } )* ')' { $clauses.add(rel); } + '(' ( f1=term { rel.addInValue(f1); } (',' fN=term { rel.addInValue(fN); } )* )? ')' { $clauses.add(rel); } ; comparatorType returns [CQL3Type t] http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc457c5e/src/java/org/apache/cassandra/cql3/QueryProcessor.java -- diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java b/src/java/org/apache/cassandra/cql3/QueryProcessor.java index fa019c0..4ae1e90 100644 --- a/src/java/org/apache/cassandra/cql3/QueryProcessor.java +++
git commit: Tiny CQL3 doc tweak
Updated Branches: refs/heads/cassandra-1.2 dc457c5eb - 91cd6538e Tiny CQL3 doc tweak Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/91cd6538 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/91cd6538 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/91cd6538 Branch: refs/heads/cassandra-1.2 Commit: 91cd6538e93b2a16df524bd45e4dee84b8f04329 Parents: dc457c5 Author: Aleksey Yeschenko alek...@apache.org Authored: Fri Jul 26 20:41:11 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Fri Jul 26 20:41:11 2013 +0300 -- doc/cql3/CQL.textile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/91cd6538/doc/cql3/CQL.textile -- diff --git a/doc/cql3/CQL.textile b/doc/cql3/CQL.textile index fe64c71..532d341 100644 --- a/doc/cql3/CQL.textile +++ b/doc/cql3/CQL.textile @@ -1054,7 +1054,7 @@ The following describes the addition/changes brought for each version of CQL. h3. 3.0.5 -* SELECT, UPDATE, and DELETE statements now allow empty IN relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). +* @SELECT@, @UPDATE@, and @DELETE@ statements now allow empty @IN@ relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). h3. 3.0.4
[1/2] git commit: Tiny CQL3 doc tweak
Updated Branches: refs/heads/trunk 1be575da0 - e22025e09 Tiny CQL3 doc tweak Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/91cd6538 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/91cd6538 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/91cd6538 Branch: refs/heads/trunk Commit: 91cd6538e93b2a16df524bd45e4dee84b8f04329 Parents: dc457c5 Author: Aleksey Yeschenko alek...@apache.org Authored: Fri Jul 26 20:41:11 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Fri Jul 26 20:41:11 2013 +0300 -- doc/cql3/CQL.textile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/91cd6538/doc/cql3/CQL.textile -- diff --git a/doc/cql3/CQL.textile b/doc/cql3/CQL.textile index fe64c71..532d341 100644 --- a/doc/cql3/CQL.textile +++ b/doc/cql3/CQL.textile @@ -1054,7 +1054,7 @@ The following describes the addition/changes brought for each version of CQL. h3. 3.0.5 -* SELECT, UPDATE, and DELETE statements now allow empty IN relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). +* @SELECT@, @UPDATE@, and @DELETE@ statements now allow empty @IN@ relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). h3. 3.0.4
[2/2] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e22025e0 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e22025e0 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e22025e0 Branch: refs/heads/trunk Commit: e22025e09fd55dd673bba34cbf78e8a01d88de70 Parents: 1be575d 91cd653 Author: Aleksey Yeschenko alek...@apache.org Authored: Fri Jul 26 20:41:39 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Fri Jul 26 20:41:39 2013 +0300 -- doc/cql3/CQL.textile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/e22025e0/doc/cql3/CQL.textile -- diff --cc doc/cql3/CQL.textile index dd76228,532d341..ece3a2d --- a/doc/cql3/CQL.textile +++ b/doc/cql3/CQL.textile @@@ -1077,16 -1052,9 +1077,16 @@@ h2(#changes). Change The following describes the addition/changes brought for each version of CQL. +h3. 3.1.0 + +* ALTER TABLE:#alterTableStmt @DROP@ option has been reenabled for CQL3 tables and has new semantics now: the space formerly used by dropped columns will now be eventually reclaimed (post-compaction). You should not readd previously dropped columns unless you use timestamps with microsecond precision (see CASSANDRA-3919:https://issues.apache.org/jira/browse/CASSANDRA-3919 for more details). +* @SELECT@ statement now supports aliases in select clause. Aliases in WHERE and ORDER BY clauses are not supported. See the section on select#selectStmt for details. +* @CREATE@ statements for @KEYSPACE@, @TABLE@ and @INDEX@ now supports an @IF NOT EXISTS@ condition. Similarly, @DROP@ statements support a @IF EXISTS@ condition. +* @INSERT@ statements optionally supports a @IF NOT EXISTS@ condition and @UDPATE@ supports @IF@ conditions. + h3. 3.0.5 - * SELECT, UPDATE, and DELETE statements now allow empty IN relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). + * @SELECT@, @UPDATE@, and @DELETE@ statements now allow empty @IN@ relations (see CASSANDRA-5626:https://issues.apache.org/jira/browse/CASSANDRA-5626). h3. 3.0.4
[jira] [Created] (CASSANDRA-5811) NPE during upgrade
Brandon Williams created CASSANDRA-5811: --- Summary: NPE during upgrade Key: CASSANDRA-5811 URL: https://issues.apache.org/jira/browse/CASSANDRA-5811 Project: Cassandra Issue Type: Bug Reporter: Brandon Williams Fix For: 1.2.8 The upgrade_through_versions dtest occasionally fails with the following error (on the 1.1 side): {noformat} ERROR [InternalResponseStage:2] 2013-07-26 12:51:10,145 AbstractCassandraDaemon.java (line 135) Exception in thread Thread[InternalResponseStage:2,5,main] java.lang.NullPointerException at org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:167) at org.apache.cassandra.utils.ByteBufferUtil.string(ByteBufferUtil.java:124) at org.apache.cassandra.cql.jdbc.JdbcUTF8.getString(JdbcUTF8.java:77) at org.apache.cassandra.cql.jdbc.JdbcUTF8.compose(JdbcUTF8.java:97) at org.apache.cassandra.db.marshal.UTF8Type.compose(UTF8Type.java:35) at org.apache.cassandra.cql3.UntypedResultSet$Row.getString(UntypedResultSet.java:87) at org.apache.cassandra.config.KSMetaData.fromSchema(KSMetaData.java:256) at org.apache.cassandra.db.DefsTable.mergeKeyspaces(DefsTable.java:397) at org.apache.cassandra.db.DefsTable.mergeSchema(DefsTable.java:373) at org.apache.cassandra.db.DefsTable.mergeRemoteSchema(DefsTable.java:352) at org.apache.cassandra.service.MigrationManager$MigrationTask$1.response(MigrationManager.java:453) at org.apache.cassandra.net.ResponseVerbHandler.doVerb(ResponseVerbHandler.java:45) at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:59) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:722) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5812) CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable
mick delaney created CASSANDRA-5812: --- Summary: CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable Key: CASSANDRA-5812 URL: https://issues.apache.org/jira/browse/CASSANDRA-5812 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 2.0 beta 2 Environment: Windows 8 64 Bit Reporter: mick delaney I downloaded Cassandra Beta 2. I've tried to use CQLSH against Cassandra. My python version is: Enthought Canopy Python 2.7.3 | 32-bit | (default, Mar 25 2013, 15:38:39) [MSC v.1500 32 bit (Intel)] on win32 I get the following exception when I run the utility: c:\Servers\apache-cassandra\binpython cqlsh 127.0.0.1 9160 Traceback (most recent call last): File cqlsh, line 131, in module if readline is not None and 'libedit' in readline.__doc__: TypeError: argument of type 'NoneType' is not iterable -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5715) CAS on 'primary key only' table
[ https://issues.apache.org/jira/browse/CASSANDRA-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721071#comment-13721071 ] Blair Zajac commented on CASSANDRA-5715: Thanks for getting this in. Is there syntax to support deleting the row with CAS? Is a CAS delete even necessary? Trying DELETE FROM test1 WHERE k = 456 IF EXISTS using cassandra-dbapi2: cql.apivalues.ProgrammingError: Bad Request: line 0:-1 no viable alternative at input 'EOF' Trying DELETE FROM test1 WHERE k = 456 IF k = 456 cql.apivalues.ProgrammingError: Bad Request: PRIMARY KEY part k found in SET part CAS on 'primary key only' table --- Key: CASSANDRA-5715 URL: https://issues.apache.org/jira/browse/CASSANDRA-5715 Project: Cassandra Issue Type: Improvement Reporter: Sylvain Lebresne Assignee: Sylvain Lebresne Priority: Minor Fix For: 2.0 beta 2 Attachments: 0001-Conditions-on-INSERT.txt, 0002-Support-updating-the-PK-only.txt, 5715-v2.txt Given a table with only a primary key, like {noformat} CREATE TABLE test (k int PRIMARY KEY) {noformat} there is currently no way to CAS a row in that table into existing because: # INSERT doesn't currently support IF # UPDATE has no way to update such table So we should probably allow IF conditions on INSERT statements. In addition (or alternatively), we could work on allowing UPDATE to update such table. One motivation for that could be to make UPDATE always be more general to INSERT. That is currently, there is a bunch of operation that INSERT cannot do (counter increments, collection appends), but that primary key table case is, afaik, the only case where you *need* to use INSERT. However, because CQL forces segregation of PK value to the WHERE clause and not to the SET one, the only syntax that I can see work would be: {noformat} UPDATE WHERE k=0; {noformat} which maybe is too ugly to allow? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5175) Unbounded (?) thread growth connecting to an removed node
[ https://issues.apache.org/jira/browse/CASSANDRA-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721091#comment-13721091 ] Minh Do commented on CASSANDRA-5175: Hi Vijay, I am using your commit db8705294ba96fe2b746fea4f26a919538653ebd but I think the logic in this commit is not the same as the attached patch. Please take a look. if (m == CLOSE_SENTINEL) { disconnect(); +if (!isStopped) +break; continue; } I think it should be : if (isStopped) break; Thanks. Unbounded (?) thread growth connecting to an removed node - Key: CASSANDRA-5175 URL: https://issues.apache.org/jira/browse/CASSANDRA-5175 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.1.8 Environment: EC2, JDK 7u9, Ubuntu 12.04.1 LTS Reporter: Janne Jalkanen Assignee: Vijay Priority: Minor Fix For: 1.1.10, 1.2.1 Attachments: 0001-CASSANDRA-5175.patch The following lines started repeating every minute in the log file {noformat} INFO [GossipStage:1] 2013-01-19 19:35:43,929 Gossiper.java (line 831) InetAddress /10.238.x.y is now dead. INFO [GossipStage:1] 2013-01-19 19:35:43,930 StorageService.java (line 1291) Removing token 170141183460469231731687303715884105718 for /10.238.x.y {noformat} Also, I got about 3000 threads which all look like this: {noformat} Name: WRITE-/10.238.x.y State: WAITING on java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1bb65c0f Total blocked: 0 Total waited: 3 Stack trace: sun.misc.Unsafe.park(Native Method) java.util.concurrent.locks.LockSupport.park(LockSupport.java:186) java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043) java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) org.apache.cassandra.net.OutboundTcpConnection.run(OutboundTcpConnection.java:104) {noformat} A new thread seems to be created every minute, and they never go away. The endpoint in question had been a part of the cluster weeks ago, and the node exhibiting the thread growth was added yesterday. Anyway, assassinating the endpoint in question stopped thread growth (but kept the existing threads running), so this isn't a huge issue. But I don't think the thread count is supposed to be increasing like this... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5813) PIG Error Using CqlStorage
James Schappet created CASSANDRA-5813: - Summary: PIG Error Using CqlStorage Key: CASSANDRA-5813 URL: https://issues.apache.org/jira/browse/CASSANDRA-5813 Project: Cassandra Issue Type: Bug Components: Hadoop Affects Versions: 1.2.7 Reporter: James Schappet Priority: Minor While trying to do a basic test with PIG in 1.2.7 I get the following exception: 2013-07-26 14:52:03,747 [Thread-6] WARN org.apache.hadoop.mapred.LocalJobRunner - job_local_0001 java.lang.RuntimeException at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:646) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.init(CqlPagingRecordReader.java:283) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader.initialize(CqlPagingRecordReader.java:149) at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigRecordReader.initialize(PigRecordReader.java:181) at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:522) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370) at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212) Caused by: InvalidRequestException(why:Expected 8 or 0 byte long (1)) at org.apache.cassandra.thrift.Cassandra$execute_prepared_cql3_query_result.read(Cassandra.java:41868) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:78) at org.apache.cassandra.thrift.Cassandra$Client.recv_execute_prepared_cql3_query(Cassandra.java:1689) at org.apache.cassandra.thrift.Cassandra$Client.execute_prepared_cql3_query(Cassandra.java:1674) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:616) ... 7 more SETUP: Create single Cassandra Instance Setup new schema: CREATE SCHEMA schema1 WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 }; Create New Table: CREATE TABLE users ( user_id varchar PRIMARY KEY, first varchar, last varchar, age int ); Insert new User to table: INSERT INTO users (user_id, first, last, age) VALUES ('jsmith', 'John', 'Smith', 42); Launch Pig: cd examples/pig bin/pig_cassandra -x local grunt rows = LOAD 'cql://schema1/users' USING CqlStorage(); grunt dump rows; Then you get the above error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5813) PIG Error Using CqlStorage
[ https://issues.apache.org/jira/browse/CASSANDRA-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721147#comment-13721147 ] James Schappet commented on CASSANDRA-5813: --- tsunami:~ schappetj$ uname -an Darwin tsunami.icts.uiowa.edu 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64 tsunami:~ schappetj$ java -version java version 1.6.0_51 Java(TM) SE Runtime Environment (build 1.6.0_51-b11-457-11M4509) Java HotSpot(TM) 64-Bit Server VM (build 20.51-b01-457, mixed mode) tsunami:~ schappetj$ apache-cassandra-1.2.7-src PIG Error Using CqlStorage -- Key: CASSANDRA-5813 URL: https://issues.apache.org/jira/browse/CASSANDRA-5813 Project: Cassandra Issue Type: Bug Components: Hadoop Affects Versions: 1.2.7 Reporter: James Schappet Priority: Minor While trying to do a basic test with PIG in 1.2.7 I get the following exception: 2013-07-26 14:52:03,747 [Thread-6] WARN org.apache.hadoop.mapred.LocalJobRunner - job_local_0001 java.lang.RuntimeException at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:646) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.init(CqlPagingRecordReader.java:283) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader.initialize(CqlPagingRecordReader.java:149) at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigRecordReader.initialize(PigRecordReader.java:181) at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:522) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370) at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212) Caused by: InvalidRequestException(why:Expected 8 or 0 byte long (1)) at org.apache.cassandra.thrift.Cassandra$execute_prepared_cql3_query_result.read(Cassandra.java:41868) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:78) at org.apache.cassandra.thrift.Cassandra$Client.recv_execute_prepared_cql3_query(Cassandra.java:1689) at org.apache.cassandra.thrift.Cassandra$Client.execute_prepared_cql3_query(Cassandra.java:1674) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:616) ... 7 more SETUP: Create single Cassandra Instance Setup new schema: CREATE SCHEMA schema1 WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 }; Create New Table: CREATE TABLE users ( user_id varchar PRIMARY KEY, first varchar, last varchar, age int ); Insert new User to table: INSERT INTO users (user_id, first, last, age) VALUES ('jsmith', 'John', 'Smith', 42); Launch Pig: cd examples/pig bin/pig_cassandra -x local grunt rows = LOAD 'cql://schema1/users' USING CqlStorage(); grunt dump rows; Then you get the above error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5813) PIG Error Using CqlStorage
[ https://issues.apache.org/jira/browse/CASSANDRA-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721186#comment-13721186 ] Brandon Williams commented on CASSANDRA-5813: - I'm unable to reproduce following your steps. {noformat} ((user_id,jsmith),(age,42),(first,John),(last,Smith)) grunt {noformat} PIG Error Using CqlStorage -- Key: CASSANDRA-5813 URL: https://issues.apache.org/jira/browse/CASSANDRA-5813 Project: Cassandra Issue Type: Bug Components: Hadoop Affects Versions: 1.2.7 Reporter: James Schappet Priority: Minor While trying to do a basic test with PIG in 1.2.7 I get the following exception: 2013-07-26 14:52:03,747 [Thread-6] WARN org.apache.hadoop.mapred.LocalJobRunner - job_local_0001 java.lang.RuntimeException at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:646) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.init(CqlPagingRecordReader.java:283) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader.initialize(CqlPagingRecordReader.java:149) at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigRecordReader.initialize(PigRecordReader.java:181) at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:522) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370) at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212) Caused by: InvalidRequestException(why:Expected 8 or 0 byte long (1)) at org.apache.cassandra.thrift.Cassandra$execute_prepared_cql3_query_result.read(Cassandra.java:41868) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:78) at org.apache.cassandra.thrift.Cassandra$Client.recv_execute_prepared_cql3_query(Cassandra.java:1689) at org.apache.cassandra.thrift.Cassandra$Client.execute_prepared_cql3_query(Cassandra.java:1674) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:616) ... 7 more SETUP: Create single Cassandra Instance Setup new schema: CREATE SCHEMA schema1 WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 }; Create New Table: CREATE TABLE users ( user_id varchar PRIMARY KEY, first varchar, last varchar, age int ); Insert new User to table: INSERT INTO users (user_id, first, last, age) VALUES ('jsmith', 'John', 'Smith', 42); Launch Pig: cd examples/pig bin/pig_cassandra -x local grunt rows = LOAD 'cql://schema1/users' USING CqlStorage(); grunt dump rows; Then you get the above error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5813) PIG Error Using CqlStorage
[ https://issues.apache.org/jira/browse/CASSANDRA-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721191#comment-13721191 ] James Schappet commented on CASSANDRA-5813: --- bin/cqlsh -3 CREATE SCHEMA schema1 WITH replication ={ 'class' : 'SimpleStrategy', 'replication_factor' : 1 }; CREATE TABLE users (user_id varchar PRIMARY KEY,first varchar,last varchar,age int); INSERT INTO users (user_id, first, last, age) VALUES ('jsmith', 'John', 'Smith', 42); Then Run PIG: cd examples/pig bin/pig_cassandra -x local grunt rows = LOAD 'cql://schema1/users' USING CqlStorage(); grunt dump rows; PIG Error Using CqlStorage -- Key: CASSANDRA-5813 URL: https://issues.apache.org/jira/browse/CASSANDRA-5813 Project: Cassandra Issue Type: Bug Components: Hadoop Affects Versions: 1.2.7 Reporter: James Schappet Priority: Minor While trying to do a basic test with PIG in 1.2.7 I get the following exception: 2013-07-26 14:52:03,747 [Thread-6] WARN org.apache.hadoop.mapred.LocalJobRunner - job_local_0001 java.lang.RuntimeException at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:646) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.init(CqlPagingRecordReader.java:283) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader.initialize(CqlPagingRecordReader.java:149) at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigRecordReader.initialize(PigRecordReader.java:181) at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:522) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370) at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212) Caused by: InvalidRequestException(why:Expected 8 or 0 byte long (1)) at org.apache.cassandra.thrift.Cassandra$execute_prepared_cql3_query_result.read(Cassandra.java:41868) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:78) at org.apache.cassandra.thrift.Cassandra$Client.recv_execute_prepared_cql3_query(Cassandra.java:1689) at org.apache.cassandra.thrift.Cassandra$Client.execute_prepared_cql3_query(Cassandra.java:1674) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:616) ... 7 more SETUP: Create single Cassandra Instance Setup new schema: CREATE SCHEMA schema1 WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 }; Create New Table: CREATE TABLE users ( user_id varchar PRIMARY KEY, first varchar, last varchar, age int ); Insert new User to table: INSERT INTO users (user_id, first, last, age) VALUES ('jsmith', 'John', 'Smith', 42); Launch Pig: cd examples/pig bin/pig_cassandra -x local grunt rows = LOAD 'cql://schema1/users' USING CqlStorage(); grunt dump rows; Then you get the above error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5812) CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable
[ https://issues.apache.org/jira/browse/CASSANDRA-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-5812: -- Priority: Minor (was: Major) Assignee: Aleksey Yeschenko CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable - Key: CASSANDRA-5812 URL: https://issues.apache.org/jira/browse/CASSANDRA-5812 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 2.0 beta 2 Environment: Windows 8 64 Bit Reporter: mick delaney Assignee: Aleksey Yeschenko Priority: Minor I downloaded Cassandra Beta 2. I've tried to use CQLSH against Cassandra. My python version is: Enthought Canopy Python 2.7.3 | 32-bit | (default, Mar 25 2013, 15:38:39) [MSC v.1500 32 bit (Intel)] on win32 I get the following exception when I run the utility: c:\Servers\apache-cassandra\binpython cqlsh 127.0.0.1 9160 Traceback (most recent call last): File cqlsh, line 131, in module if readline is not None and 'libedit' in readline.__doc__: TypeError: argument of type 'NoneType' is not iterable -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5814) RowIndexEntry.deletionTime raises UnsupportedOperationException when upgrading to 1.2.7
Brett Hoerner created CASSANDRA-5814: Summary: RowIndexEntry.deletionTime raises UnsupportedOperationException when upgrading to 1.2.7 Key: CASSANDRA-5814 URL: https://issues.apache.org/jira/browse/CASSANDRA-5814 Project: Cassandra Issue Type: Bug Affects Versions: 1.2.7 Reporter: Brett Hoerner Upgrading from 1.2.5 to 1.2.7 caused the following exception: {code} ERROR [MutationStage:59] 2013-07-26 19:35:10,460 CassandraDaemon.java (line 192) Exception in thread Thread[MutationStage:59,5,main] java.lang.ExceptionInInitializerError at org.apache.cassandra.utils.CounterId.localIds(CounterId.java:49) at org.apache.cassandra.utils.CounterId.getLocalId(CounterId.java:54) at org.apache.cassandra.db.context.CounterContext.create(CounterContext.java:105) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:84) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:34) at org.apache.cassandra.db.CounterMutation.apply(CounterMutation.java:133) at org.apache.cassandra.service.StorageProxy$7.runMayThrow(StorageProxy.java:758) at org.apache.cassandra.service.StorageProxy$LocalMutationRunnable.run(StorageProxy.java:1630) at org.apache.cassandra.service.StorageProxy$3.apply(StorageProxy.java:142) at org.apache.cassandra.service.StorageProxy.performWrite(StorageProxy.java:385) at org.apache.cassandra.service.StorageProxy.applyCounterMutationOnLeader(StorageProxy.java:733) at org.apache.cassandra.db.CounterMutationVerbHandler.doVerb(CounterMutationVerbHandler.java:53) at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Caused by: java.lang.UnsupportedOperationException at org.apache.cassandra.db.RowIndexEntry.deletionTime(RowIndexEntry.java:81) at org.apache.cassandra.db.columniterator.IndexedSliceReader.init(IndexedSliceReader.java:109) at org.apache.cassandra.db.columniterator.SSTableSliceIterator.createReader(SSTableSliceIterator.java:68) at org.apache.cassandra.db.columniterator.SSTableSliceIterator.init(SSTableSliceIterator.java:44) at org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:101) at org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:68) at org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:272) at org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:65) at org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:1390) at org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1213) at org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1125) at org.apache.cassandra.db.SystemTable.getCurrentLocalCounterId(SystemTable.java:595) at org.apache.cassandra.utils.CounterId$LocalCounterIdHistory.init(CounterId.java:194) at org.apache.cassandra.utils.CounterId$LocalIds.clinit(CounterId.java:42) ... 16 more {code} The code causing it seems to have changed in 1.2.7 via https://issues.apache.org/jira/browse/CASSANDRA-5677 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5814) RowIndexEntry.deletionTime raises UnsupportedOperationException when upgrading to 1.2.7
[ https://issues.apache.org/jira/browse/CASSANDRA-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Hoerner updated CASSANDRA-5814: - Description: Upgrading from 1.2.5 to 1.2.7 immediately caused the following exception. We stopped the node and reverted to 1.2.5. I'll note that we also run a 1.2.6 cluster that is doing fine, so I think this is caused by a change in 1.2.7. {code} ERROR [MutationStage:59] 2013-07-26 19:35:10,460 CassandraDaemon.java (line 192) Exception in thread Thread[MutationStage:59,5,main] java.lang.ExceptionInInitializerError at org.apache.cassandra.utils.CounterId.localIds(CounterId.java:49) at org.apache.cassandra.utils.CounterId.getLocalId(CounterId.java:54) at org.apache.cassandra.db.context.CounterContext.create(CounterContext.java:105) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:84) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:34) at org.apache.cassandra.db.CounterMutation.apply(CounterMutation.java:133) at org.apache.cassandra.service.StorageProxy$7.runMayThrow(StorageProxy.java:758) at org.apache.cassandra.service.StorageProxy$LocalMutationRunnable.run(StorageProxy.java:1630) at org.apache.cassandra.service.StorageProxy$3.apply(StorageProxy.java:142) at org.apache.cassandra.service.StorageProxy.performWrite(StorageProxy.java:385) at org.apache.cassandra.service.StorageProxy.applyCounterMutationOnLeader(StorageProxy.java:733) at org.apache.cassandra.db.CounterMutationVerbHandler.doVerb(CounterMutationVerbHandler.java:53) at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Caused by: java.lang.UnsupportedOperationException at org.apache.cassandra.db.RowIndexEntry.deletionTime(RowIndexEntry.java:81) at org.apache.cassandra.db.columniterator.IndexedSliceReader.init(IndexedSliceReader.java:109) at org.apache.cassandra.db.columniterator.SSTableSliceIterator.createReader(SSTableSliceIterator.java:68) at org.apache.cassandra.db.columniterator.SSTableSliceIterator.init(SSTableSliceIterator.java:44) at org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:101) at org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:68) at org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:272) at org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:65) at org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:1390) at org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1213) at org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1125) at org.apache.cassandra.db.SystemTable.getCurrentLocalCounterId(SystemTable.java:595) at org.apache.cassandra.utils.CounterId$LocalCounterIdHistory.init(CounterId.java:194) at org.apache.cassandra.utils.CounterId$LocalIds.clinit(CounterId.java:42) ... 16 more {code} The code causing it seems to have changed in 1.2.7 via https://issues.apache.org/jira/browse/CASSANDRA-5677 was: Upgrading from 1.2.5 to 1.2.7 caused the following exception: {code} ERROR [MutationStage:59] 2013-07-26 19:35:10,460 CassandraDaemon.java (line 192) Exception in thread Thread[MutationStage:59,5,main] java.lang.ExceptionInInitializerError at org.apache.cassandra.utils.CounterId.localIds(CounterId.java:49) at org.apache.cassandra.utils.CounterId.getLocalId(CounterId.java:54) at org.apache.cassandra.db.context.CounterContext.create(CounterContext.java:105) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:84) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:34) at org.apache.cassandra.db.CounterMutation.apply(CounterMutation.java:133) at org.apache.cassandra.service.StorageProxy$7.runMayThrow(StorageProxy.java:758) at org.apache.cassandra.service.StorageProxy$LocalMutationRunnable.run(StorageProxy.java:1630) at org.apache.cassandra.service.StorageProxy$3.apply(StorageProxy.java:142) at org.apache.cassandra.service.StorageProxy.performWrite(StorageProxy.java:385) at org.apache.cassandra.service.StorageProxy.applyCounterMutationOnLeader(StorageProxy.java:733) at
[jira] [Commented] (CASSANDRA-5813) PIG Error Using CqlStorage
[ https://issues.apache.org/jira/browse/CASSANDRA-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721244#comment-13721244 ] Brandon Williams commented on CASSANDRA-5813: - I don't have a problem following the steps (except you're missing a 'use schema1;') just reproducing the error, which doesn't occur. PIG Error Using CqlStorage -- Key: CASSANDRA-5813 URL: https://issues.apache.org/jira/browse/CASSANDRA-5813 Project: Cassandra Issue Type: Bug Components: Hadoop Affects Versions: 1.2.7 Reporter: James Schappet Priority: Minor While trying to do a basic test with PIG in 1.2.7 I get the following exception: 2013-07-26 14:52:03,747 [Thread-6] WARN org.apache.hadoop.mapred.LocalJobRunner - job_local_0001 java.lang.RuntimeException at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:646) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.init(CqlPagingRecordReader.java:283) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader.initialize(CqlPagingRecordReader.java:149) at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigRecordReader.initialize(PigRecordReader.java:181) at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:522) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370) at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212) Caused by: InvalidRequestException(why:Expected 8 or 0 byte long (1)) at org.apache.cassandra.thrift.Cassandra$execute_prepared_cql3_query_result.read(Cassandra.java:41868) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:78) at org.apache.cassandra.thrift.Cassandra$Client.recv_execute_prepared_cql3_query(Cassandra.java:1689) at org.apache.cassandra.thrift.Cassandra$Client.execute_prepared_cql3_query(Cassandra.java:1674) at org.apache.cassandra.hadoop.cql3.CqlPagingRecordReader$RowIterator.executeQuery(CqlPagingRecordReader.java:616) ... 7 more SETUP: Create single Cassandra Instance Setup new schema: CREATE SCHEMA schema1 WITH replication = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 }; Create New Table: CREATE TABLE users ( user_id varchar PRIMARY KEY, first varchar, last varchar, age int ); Insert new User to table: INSERT INTO users (user_id, first, last, age) VALUES ('jsmith', 'John', 'Smith', 42); Launch Pig: cd examples/pig bin/pig_cassandra -x local grunt rows = LOAD 'cql://schema1/users' USING CqlStorage(); grunt dump rows; Then you get the above error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-5815) NPE from migration manager
Vishy Kasar created CASSANDRA-5815: -- Summary: NPE from migration manager Key: CASSANDRA-5815 URL: https://issues.apache.org/jira/browse/CASSANDRA-5815 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.1.12 Reporter: Vishy Kasar Priority: Minor In one of our production clusters we see this error often. Looking through the source, Gossiper.instance.getEndpointStateForEndpoint(endpoint) is returning null for some end point. De we need any config change on our end to resolve this? In any case, cassandra should be updated to protect against this NPE. ERROR [OptionalTasks:1] 2013-07-24 13:40:38,972 AbstractCassandraDaemon.java (line 132) Exception in thread Thread[OptionalTasks:1,5,main] java.lang.NullPointerException at org.apache.cassandra.service.MigrationManager$1.run(MigrationManager.java:134) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:206) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) It turned out that the reason for NPE was we bootstrapped a node with the same token as another node. Cassandra should not throw an NPE here but log a meaningful error message. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-5637) sstableloader does not seem to load all the data present in the provided sstables
[ https://issues.apache.org/jira/browse/CASSANDRA-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishy Kasar resolved CASSANDRA-5637. Resolution: Not A Problem This turned out to be an issue with how we were reading back the data. The limit on how many columns to return on a read was set to 100 and it was not showing the newly added columns. Nothing more to do on this. sstableloader does not seem to load all the data present in the provided sstables - Key: CASSANDRA-5637 URL: https://issues.apache.org/jira/browse/CASSANDRA-5637 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 1.1.10 Reporter: Vishy Kasar Attachments: sstable-loader-log.txt I loaded about 1 million records in to my local cassandra. I then attempted to load these records using the sstableloader to prod cassandra using command sstableloader -v -u xyz -pw abc -d st11p02me-hpbb050130-i6 /tmp/prod_p02/containers When I read back the production data later, I do not find some rows that I inserted above. Few other rows are present though. Are there known bugs in sstableloader? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5637) sstableloader does not seem to load all the data present in the provided sstables
[ https://issues.apache.org/jira/browse/CASSANDRA-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721268#comment-13721268 ] Vishy Kasar commented on CASSANDRA-5637: This turned out to be an issue with how we were reading back the data. The limit on how many columns to return on a read was set to 100 and it was not showing the newly added columns. Nothing more to do on this. sstableloader does not seem to load all the data present in the provided sstables - Key: CASSANDRA-5637 URL: https://issues.apache.org/jira/browse/CASSANDRA-5637 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 1.1.10 Reporter: Vishy Kasar Attachments: sstable-loader-log.txt I loaded about 1 million records in to my local cassandra. I then attempted to load these records using the sstableloader to prod cassandra using command sstableloader -v -u xyz -pw abc -d st11p02me-hpbb050130-i6 /tmp/prod_p02/containers When I read back the production data later, I do not find some rows that I inserted above. Few other rows are present though. Are there known bugs in sstableloader? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5814) RowIndexEntry.deletionTime raises UnsupportedOperationException when upgrading to 1.2.7
[ https://issues.apache.org/jira/browse/CASSANDRA-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-5814: -- Attachment: 5814.txt Patch to read the deletion time from the row header when dealing with old sstable formats. RowIndexEntry.deletionTime raises UnsupportedOperationException when upgrading to 1.2.7 --- Key: CASSANDRA-5814 URL: https://issues.apache.org/jira/browse/CASSANDRA-5814 Project: Cassandra Issue Type: Bug Affects Versions: 1.2.7 Reporter: Brett Hoerner Attachments: 5814.txt Upgrading from 1.2.5 to 1.2.7 immediately caused the following exception. We stopped the node and reverted to 1.2.5. I'll note that we also run a 1.2.6 cluster that is doing fine, so I think this is caused by a change in 1.2.7. {code} ERROR [MutationStage:59] 2013-07-26 19:35:10,460 CassandraDaemon.java (line 192) Exception in thread Thread[MutationStage:59,5,main] java.lang.ExceptionInInitializerError at org.apache.cassandra.utils.CounterId.localIds(CounterId.java:49) at org.apache.cassandra.utils.CounterId.getLocalId(CounterId.java:54) at org.apache.cassandra.db.context.CounterContext.create(CounterContext.java:105) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:84) at org.apache.cassandra.db.CounterUpdateColumn.localCopy(CounterUpdateColumn.java:34) at org.apache.cassandra.db.CounterMutation.apply(CounterMutation.java:133) at org.apache.cassandra.service.StorageProxy$7.runMayThrow(StorageProxy.java:758) at org.apache.cassandra.service.StorageProxy$LocalMutationRunnable.run(StorageProxy.java:1630) at org.apache.cassandra.service.StorageProxy$3.apply(StorageProxy.java:142) at org.apache.cassandra.service.StorageProxy.performWrite(StorageProxy.java:385) at org.apache.cassandra.service.StorageProxy.applyCounterMutationOnLeader(StorageProxy.java:733) at org.apache.cassandra.db.CounterMutationVerbHandler.doVerb(CounterMutationVerbHandler.java:53) at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Caused by: java.lang.UnsupportedOperationException at org.apache.cassandra.db.RowIndexEntry.deletionTime(RowIndexEntry.java:81) at org.apache.cassandra.db.columniterator.IndexedSliceReader.init(IndexedSliceReader.java:109) at org.apache.cassandra.db.columniterator.SSTableSliceIterator.createReader(SSTableSliceIterator.java:68) at org.apache.cassandra.db.columniterator.SSTableSliceIterator.init(SSTableSliceIterator.java:44) at org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:101) at org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:68) at org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:272) at org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:65) at org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:1390) at org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1213) at org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1125) at org.apache.cassandra.db.SystemTable.getCurrentLocalCounterId(SystemTable.java:595) at org.apache.cassandra.utils.CounterId$LocalCounterIdHistory.init(CounterId.java:194) at org.apache.cassandra.utils.CounterId$LocalIds.clinit(CounterId.java:42) ... 16 more {code} The code causing it seems to have changed in 1.2.7 via https://issues.apache.org/jira/browse/CASSANDRA-5677 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-5815) NPE from migration manager
[ https://issues.apache.org/jira/browse/CASSANDRA-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-5815: --- Assignee: Brandon Williams NPE from migration manager -- Key: CASSANDRA-5815 URL: https://issues.apache.org/jira/browse/CASSANDRA-5815 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.1.12 Reporter: Vishy Kasar Assignee: Brandon Williams Priority: Minor In one of our production clusters we see this error often. Looking through the source, Gossiper.instance.getEndpointStateForEndpoint(endpoint) is returning null for some end point. De we need any config change on our end to resolve this? In any case, cassandra should be updated to protect against this NPE. ERROR [OptionalTasks:1] 2013-07-24 13:40:38,972 AbstractCassandraDaemon.java (line 132) Exception in thread Thread[OptionalTasks:1,5,main] java.lang.NullPointerException at org.apache.cassandra.service.MigrationManager$1.run(MigrationManager.java:134) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:206) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) It turned out that the reason for NPE was we bootstrapped a node with the same token as another node. Cassandra should not throw an NPE here but log a meaningful error message. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Fix cas() arguments order in MS.executeWithCondition
Updated Branches: refs/heads/trunk e22025e09 - 2548e5aca Fix cas() arguments order in MS.executeWithCondition follow-up to CASSANDRA-5797 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2548e5ac Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2548e5ac Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2548e5ac Branch: refs/heads/trunk Commit: 2548e5aca3a1ddc0c8b1e9ebe345d4be7d4a54c8 Parents: e22025e Author: Aleksey Yeschenko alek...@apache.org Authored: Sat Jul 27 03:43:22 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Sat Jul 27 03:43:22 2013 +0300 -- .../cassandra/cql3/statements/ModificationStatement.java| 9 - 1 file changed, 8 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/2548e5ac/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java -- diff --git a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java index d08d0ee..88a80e0 100644 --- a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java @@ -379,7 +379,14 @@ public abstract class ModificationStatement implements CQLStatement ColumnFamily updates = updateForKey(key, clusteringPrefix, params); ColumnFamily expected = buildConditions(key, clusteringPrefix, params); -ColumnFamily result = StorageProxy.cas(keyspace(), columnFamily(), key, clusteringPrefix, expected, updates, options.getConsistency(), options.getSerialConsistency()); +ColumnFamily result = StorageProxy.cas(keyspace(), + columnFamily(), + key, + clusteringPrefix, + expected, + updates, + options.getSerialConsistency(), + options.getConsistency()); return new ResultMessage.Rows(buildCasResultSet(key, result)); }
[jira] [Commented] (CASSANDRA-5084) Cassandra should expose connected client state via JMX
[ https://issues.apache.org/jira/browse/CASSANDRA-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721468#comment-13721468 ] Dave Brosius commented on CASSANDRA-5084: - Couple of points of note: This patch doesn't interact with the native interface, which going forward in trunk would seem to be more relevant. At the least that probably means the JMX name shouldn't include 'thrift'. connections? something else. Rather than returning error strings, probably would be better to just throw RuntimeExceptions, as programmatically you wouldn't be able to tell that No active connection found for given host and port wasn't a user name. Sure it looks fine in jconsole, but i'm talking about a programatic access. Creating a ThriftSessionManager field in CassandraServer doesn't seem necessary just to make sure that it is loaded first. One would think you could just do something like ThriftSessionManager.instance.hashCode() in the CassandraServer ctor. When i saw the word 'Active' in the jmx names, i immediately assumed you were talking about how many clients had code running for them in the server at the present time. I'm not sure if there's a better word for what you are reporting or not. In addition, with connection pooling, these numbers maybe larger than expected, so is that statistic of use? Or do you really want active use connections? Is there any concern about exposing user identity thru jmx? probably not, just asking. As soon as you do expose this however, admins will want the ability to kill a specific users connection :) small nit, the import order is java javax 3rdparties cassandra Cassandra should expose connected client state via JMX -- Key: CASSANDRA-5084 URL: https://issues.apache.org/jira/browse/CASSANDRA-5084 Project: Cassandra Issue Type: Improvement Reporter: Robert Coli Priority: Minor Labels: lhf Attachments: 5084-trunk.patch There is currently no good way to determine or estimate how many clients are connected to a cassandra node without using netstat or (if using sync thrift server) counting threads. There is also no way to understand what state any given connection is in. People regularly come into #cassandra/cassandra-user@ and ask how to get the equivalent of a MySQL SHOW FULL PROCESSLIST. While I understand that feature parity with SHOW FULL PROCESSLIST/information_schema.processlist is unlikely, even a few basic metrics like number of connected clients or number of active clients would greatly help with this operational information need. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5812) CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable
[ https://issues.apache.org/jira/browse/CASSANDRA-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-5812: - Reviewer: brandon.williams Affects Version/s: (was: 2.0 beta 2) 1.2.2 Fix Version/s: 1.2.8 Labels: cqlsh windows (was: ) CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable - Key: CASSANDRA-5812 URL: https://issues.apache.org/jira/browse/CASSANDRA-5812 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 1.2.2 Environment: Windows 8 64 Bit Reporter: mick delaney Assignee: Aleksey Yeschenko Priority: Minor Labels: cqlsh, windows Fix For: 1.2.8 I downloaded Cassandra Beta 2. I've tried to use CQLSH against Cassandra. My python version is: Enthought Canopy Python 2.7.3 | 32-bit | (default, Mar 25 2013, 15:38:39) [MSC v.1500 32 bit (Intel)] on win32 I get the following exception when I run the utility: c:\Servers\apache-cassandra\binpython cqlsh 127.0.0.1 9160 Traceback (most recent call last): File cqlsh, line 131, in module if readline is not None and 'libedit' in readline.__doc__: TypeError: argument of type 'NoneType' is not iterable -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5812) CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable
[ https://issues.apache.org/jira/browse/CASSANDRA-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-5812: - Attachment: 5812.txt CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable - Key: CASSANDRA-5812 URL: https://issues.apache.org/jira/browse/CASSANDRA-5812 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 1.2.2 Environment: Windows 8 64 Bit Reporter: mick delaney Assignee: Aleksey Yeschenko Priority: Minor Labels: cqlsh, windows Fix For: 1.2.8 Attachments: 5812.txt I downloaded Cassandra Beta 2. I've tried to use CQLSH against Cassandra. My python version is: Enthought Canopy Python 2.7.3 | 32-bit | (default, Mar 25 2013, 15:38:39) [MSC v.1500 32 bit (Intel)] on win32 I get the following exception when I run the utility: c:\Servers\apache-cassandra\binpython cqlsh 127.0.0.1 9160 Traceback (most recent call last): File cqlsh, line 131, in module if readline is not None and 'libedit' in readline.__doc__: TypeError: argument of type 'NoneType' is not iterable -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5812) CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable
[ https://issues.apache.org/jira/browse/CASSANDRA-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721481#comment-13721481 ] Brandon Williams commented on CASSANDRA-5812: - +1 CQLSH Windows: TypeError: argument of type 'NoneType' is not iterable - Key: CASSANDRA-5812 URL: https://issues.apache.org/jira/browse/CASSANDRA-5812 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 1.2.2 Environment: Windows 8 64 Bit Reporter: mick delaney Assignee: Aleksey Yeschenko Priority: Minor Labels: cqlsh, windows Fix For: 1.2.8 Attachments: 5812.txt I downloaded Cassandra Beta 2. I've tried to use CQLSH against Cassandra. My python version is: Enthought Canopy Python 2.7.3 | 32-bit | (default, Mar 25 2013, 15:38:39) [MSC v.1500 32 bit (Intel)] on win32 I get the following exception when I run the utility: c:\Servers\apache-cassandra\binpython cqlsh 127.0.0.1 9160 Traceback (most recent call last): File cqlsh, line 131, in module if readline is not None and 'libedit' in readline.__doc__: TypeError: argument of type 'NoneType' is not iterable -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: cqlsh: fix crashing on Windows due to libedit detection
Updated Branches: refs/heads/cassandra-1.2 91cd6538e - af4e1275e cqlsh: fix crashing on Windows due to libedit detection patch by Aleksey Yeschenko; reviewed by Brandon Williams for CASSANDRA-5812 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/af4e1275 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/af4e1275 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/af4e1275 Branch: refs/heads/cassandra-1.2 Commit: af4e1275edb7f76c460c4ea1d03fc525e2317fb4 Parents: 91cd653 Author: Aleksey Yeschenko alek...@apache.org Authored: Sat Jul 27 04:36:49 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Sat Jul 27 04:36:49 2013 +0300 -- CHANGES.txt | 1 + bin/cqlsh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/af4e1275/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index fe28eee..955af7b 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -2,6 +2,7 @@ * cqlsh: add collections support to COPY (CASSANDRA-5698) * retry important messages for any IOException (CASSANDRA-5804) * Allow empty IN relations in SELECT/UPDATE/DELETE statements (CASSANDRA-5626) + * cqlsh: fix crashing on Windows due to libedit detection (CASSANDRA-5812) 1.2.7 http://git-wip-us.apache.org/repos/asf/cassandra/blob/af4e1275/bin/cqlsh -- diff --git a/bin/cqlsh b/bin/cqlsh index 48cc492..4f49862 100755 --- a/bin/cqlsh +++ b/bin/cqlsh @@ -32,7 +32,7 @@ exit 1 from __future__ import with_statement description = CQL Shell for Apache Cassandra -version = 3.1.5 +version = 3.1.6 from StringIO import StringIO from itertools import groupby @@ -129,7 +129,7 @@ DEFAULT_TIME_FORMAT = '%Y-%m-%d %H:%M:%S%z' DEFAULT_FLOAT_PRECISION = 5 DEFAULT_SELECT_LIMIT = 1 -if readline is not None and 'libedit' in readline.__doc__: +if readline is not None and readline.__doc__ is not None and 'libedit' in readline.__doc__: DEFAULT_COMPLETEKEY = '\t' else: DEFAULT_COMPLETEKEY = 'tab'
git commit: cqlsh: correct the rest of libedit detection on windows
Updated Branches: refs/heads/cassandra-1.2 af4e1275e - 187f73f89 cqlsh: correct the rest of libedit detection on windows Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/187f73f8 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/187f73f8 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/187f73f8 Branch: refs/heads/cassandra-1.2 Commit: 187f73f89730b0a37f556eb487f496839c265c70 Parents: af4e127 Author: Aleksey Yeschenko alek...@apache.org Authored: Sat Jul 27 04:43:40 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Sat Jul 27 04:43:40 2013 +0300 -- bin/cqlsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/187f73f8/bin/cqlsh -- diff --git a/bin/cqlsh b/bin/cqlsh index 4f49862..59aac0d 100755 --- a/bin/cqlsh +++ b/bin/cqlsh @@ -846,7 +846,7 @@ class Shell(cmd.Cmd): else: old_completer = readline.get_completer() readline.set_completer(self.complete) -if 'libedit' in readline.__doc__: +if readline.__doc__ is not None and 'libedit' in readline.__doc__: readline.parse_and_bind(bind -e) readline.parse_and_bind(bind ' + self.completekey + ' rl_complete) else:
[2/3] git commit: cqlsh: correct the rest of libedit detection on windows
cqlsh: correct the rest of libedit detection on windows Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/187f73f8 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/187f73f8 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/187f73f8 Branch: refs/heads/trunk Commit: 187f73f89730b0a37f556eb487f496839c265c70 Parents: af4e127 Author: Aleksey Yeschenko alek...@apache.org Authored: Sat Jul 27 04:43:40 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Sat Jul 27 04:43:40 2013 +0300 -- bin/cqlsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/187f73f8/bin/cqlsh -- diff --git a/bin/cqlsh b/bin/cqlsh index 4f49862..59aac0d 100755 --- a/bin/cqlsh +++ b/bin/cqlsh @@ -846,7 +846,7 @@ class Shell(cmd.Cmd): else: old_completer = readline.get_completer() readline.set_completer(self.complete) -if 'libedit' in readline.__doc__: +if readline.__doc__ is not None and 'libedit' in readline.__doc__: readline.parse_and_bind(bind -e) readline.parse_and_bind(bind ' + self.completekey + ' rl_complete) else:
[1/3] git commit: cqlsh: fix crashing on Windows due to libedit detection
Updated Branches: refs/heads/trunk 2548e5aca - 308afb20b cqlsh: fix crashing on Windows due to libedit detection patch by Aleksey Yeschenko; reviewed by Brandon Williams for CASSANDRA-5812 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/af4e1275 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/af4e1275 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/af4e1275 Branch: refs/heads/trunk Commit: af4e1275edb7f76c460c4ea1d03fc525e2317fb4 Parents: 91cd653 Author: Aleksey Yeschenko alek...@apache.org Authored: Sat Jul 27 04:36:49 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Sat Jul 27 04:36:49 2013 +0300 -- CHANGES.txt | 1 + bin/cqlsh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/af4e1275/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index fe28eee..955af7b 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -2,6 +2,7 @@ * cqlsh: add collections support to COPY (CASSANDRA-5698) * retry important messages for any IOException (CASSANDRA-5804) * Allow empty IN relations in SELECT/UPDATE/DELETE statements (CASSANDRA-5626) + * cqlsh: fix crashing on Windows due to libedit detection (CASSANDRA-5812) 1.2.7 http://git-wip-us.apache.org/repos/asf/cassandra/blob/af4e1275/bin/cqlsh -- diff --git a/bin/cqlsh b/bin/cqlsh index 48cc492..4f49862 100755 --- a/bin/cqlsh +++ b/bin/cqlsh @@ -32,7 +32,7 @@ exit 1 from __future__ import with_statement description = CQL Shell for Apache Cassandra -version = 3.1.5 +version = 3.1.6 from StringIO import StringIO from itertools import groupby @@ -129,7 +129,7 @@ DEFAULT_TIME_FORMAT = '%Y-%m-%d %H:%M:%S%z' DEFAULT_FLOAT_PRECISION = 5 DEFAULT_SELECT_LIMIT = 1 -if readline is not None and 'libedit' in readline.__doc__: +if readline is not None and readline.__doc__ is not None and 'libedit' in readline.__doc__: DEFAULT_COMPLETEKEY = '\t' else: DEFAULT_COMPLETEKEY = 'tab'
[3/3] git commit: Merge branch 'cassandra-1.2' into trunk
Merge branch 'cassandra-1.2' into trunk Conflicts: bin/cqlsh Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/308afb20 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/308afb20 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/308afb20 Branch: refs/heads/trunk Commit: 308afb20bed382a2a1d0424bef23a683cf1ad99e Parents: 2548e5a 187f73f Author: Aleksey Yeschenko alek...@apache.org Authored: Sat Jul 27 04:45:02 2013 +0300 Committer: Aleksey Yeschenko alek...@apache.org Committed: Sat Jul 27 04:45:02 2013 +0300 -- CHANGES.txt | 1 + bin/cqlsh | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/308afb20/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/308afb20/bin/cqlsh --
[jira] [Commented] (CASSANDRA-5175) Unbounded (?) thread growth connecting to an removed node
[ https://issues.apache.org/jira/browse/CASSANDRA-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721497#comment-13721497 ] Vijay commented on CASSANDRA-5175: -- Yes there was another commit on top the attached patch to fix the test cases, yes the logic has changed since calling close() is the only time we need to stop the thread. Current code in the repo {code} if (m == CLOSE_SENTINEL) { disconnect(); if (isStopped) break; continue; } {code} Unbounded (?) thread growth connecting to an removed node - Key: CASSANDRA-5175 URL: https://issues.apache.org/jira/browse/CASSANDRA-5175 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.1.8 Environment: EC2, JDK 7u9, Ubuntu 12.04.1 LTS Reporter: Janne Jalkanen Assignee: Vijay Priority: Minor Fix For: 1.1.10, 1.2.1 Attachments: 0001-CASSANDRA-5175.patch The following lines started repeating every minute in the log file {noformat} INFO [GossipStage:1] 2013-01-19 19:35:43,929 Gossiper.java (line 831) InetAddress /10.238.x.y is now dead. INFO [GossipStage:1] 2013-01-19 19:35:43,930 StorageService.java (line 1291) Removing token 170141183460469231731687303715884105718 for /10.238.x.y {noformat} Also, I got about 3000 threads which all look like this: {noformat} Name: WRITE-/10.238.x.y State: WAITING on java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1bb65c0f Total blocked: 0 Total waited: 3 Stack trace: sun.misc.Unsafe.park(Native Method) java.util.concurrent.locks.LockSupport.park(LockSupport.java:186) java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2043) java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) org.apache.cassandra.net.OutboundTcpConnection.run(OutboundTcpConnection.java:104) {noformat} A new thread seems to be created every minute, and they never go away. The endpoint in question had been a part of the cluster weeks ago, and the node exhibiting the thread growth was added yesterday. Anyway, assassinating the endpoint in question stopped thread growth (but kept the existing threads running), so this isn't a huge issue. But I don't think the thread count is supposed to be increasing like this... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira