[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776062#comment-13776062 ] Alex Liu commented on CASSANDRA-6084: - Is vnode enable? It's not recommended to run hadoop/pig job when vnode is enabled. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Enable tcp keepalive on incoming connections.
Updated Branches:
refs/heads/cassandra-2.0 5817aa95c -> 3448ca57f
Enable tcp keepalive on incoming connections.
Patch by marcuse, reviewed by jbellis for CASSANDRA-4053
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3448ca57
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3448ca57
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3448ca57
Branch: refs/heads/cassandra-2.0
Commit: 3448ca57f3714521b5b7fc88fac43e31d0adcafa
Parents: 5817aa9
Author: Marcus Eriksson
Authored: Tue Sep 24 09:55:00 2013 +0200
Committer: Marcus Eriksson
Committed: Tue Sep 24 09:56:48 2013 +0200
--
CHANGES.txt | 2 +-
src/java/org/apache/cassandra/net/MessagingService.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/3448ca57/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 43bb25c..1bdb6a8 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,7 +7,7 @@ Merged from 1.2:
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
* Move batchlog replay to its own executor (CASSANDRA-6079)
* Add tombstone debug threshold and histogram (CASSANDRA-6042, 6057)
-
+ * Enable tcp keepalive on incoming connections (CASSANDRA-4053)
2.0.1
* Fix bug that could allow reading deleted data temporarily (CASSANDRA-6025)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/3448ca57/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java
b/src/java/org/apache/cassandra/net/MessagingService.java
index 792d657..33e3bfb 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -820,6 +820,7 @@ public final class MessagingService implements
MessagingServiceMBean
Socket socket = server.accept();
if (authenticate(socket))
{
+socket.setKeepAlive(true);
// determine the connection type to decide whether to
buffer
DataInputStream in = new
DataInputStream(socket.getInputStream());
MessagingService.validateMagic(in.readInt());
[1/2] git commit: Enable tcp keepalive on incoming connections.
Updated Branches:
refs/heads/trunk af4799b52 -> 08e334649
Enable tcp keepalive on incoming connections.
Patch by marcuse, reviewed by jbellis for CASSANDRA-4053
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3448ca57
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3448ca57
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3448ca57
Branch: refs/heads/trunk
Commit: 3448ca57f3714521b5b7fc88fac43e31d0adcafa
Parents: 5817aa9
Author: Marcus Eriksson
Authored: Tue Sep 24 09:55:00 2013 +0200
Committer: Marcus Eriksson
Committed: Tue Sep 24 09:56:48 2013 +0200
--
CHANGES.txt | 2 +-
src/java/org/apache/cassandra/net/MessagingService.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/3448ca57/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 43bb25c..1bdb6a8 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,7 +7,7 @@ Merged from 1.2:
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
* Move batchlog replay to its own executor (CASSANDRA-6079)
* Add tombstone debug threshold and histogram (CASSANDRA-6042, 6057)
-
+ * Enable tcp keepalive on incoming connections (CASSANDRA-4053)
2.0.1
* Fix bug that could allow reading deleted data temporarily (CASSANDRA-6025)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/3448ca57/src/java/org/apache/cassandra/net/MessagingService.java
--
diff --git a/src/java/org/apache/cassandra/net/MessagingService.java
b/src/java/org/apache/cassandra/net/MessagingService.java
index 792d657..33e3bfb 100644
--- a/src/java/org/apache/cassandra/net/MessagingService.java
+++ b/src/java/org/apache/cassandra/net/MessagingService.java
@@ -820,6 +820,7 @@ public final class MessagingService implements
MessagingServiceMBean
Socket socket = server.accept();
if (authenticate(socket))
{
+socket.setKeepAlive(true);
// determine the connection type to decide whether to
buffer
DataInputStream in = new
DataInputStream(socket.getInputStream());
MessagingService.validateMagic(in.readInt());
[2/2] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/08e33464 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/08e33464 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/08e33464 Branch: refs/heads/trunk Commit: 08e3346494a21688d214f465c7048567a86e5f06 Parents: af4799b 3448ca5 Author: Marcus Eriksson Authored: Tue Sep 24 09:57:39 2013 +0200 Committer: Marcus Eriksson Committed: Tue Sep 24 09:57:39 2013 +0200 -- CHANGES.txt | 2 +- src/java/org/apache/cassandra/net/MessagingService.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/08e33464/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/08e33464/src/java/org/apache/cassandra/net/MessagingService.java --
[jira] [Commented] (CASSANDRA-5862) Switch to adler checksum for sstables
[ https://issues.apache.org/jira/browse/CASSANDRA-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776112#comment-13776112 ] Adrien Grand commented on CASSANDRA-5862: - bq. What is the gain from switching to xxHash ? [...] Specifically, I'm interested in hash diversity. xxHash happens to pass all tests of the SMHasher test suite (http://code.google.com/p/smhasher/wiki/SMHasher, see scores and speed of some common hash function at http://code.google.com/p/xxhash/) which has many tests including hash diversity. > Switch to adler checksum for sstables > - > > Key: CASSANDRA-5862 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5862 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jonathan Ellis >Assignee: T Jake Luciani > Fix For: 2.0.1 > > Attachments: 5862.txt > > > Adler is significantly faster than CRC32: > http://java-performance.info/java-crc32-and-adler32/ > (Adler is weaker for short inputs, so we should leave the commitlog alone, as > it checksums each mutation individually.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5852) json2sstable breaks on data exported from sstable2json.
[
https://issues.apache.org/jira/browse/CASSANDRA-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-5852:
Fix Version/s: 1.2.10
> json2sstable breaks on data exported from sstable2json.
> ---
>
> Key: CASSANDRA-5852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5852
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
>Affects Versions: 1.2.4, 1.2.9, 2.0 rc1
>Reporter: Ryan McGuire
>Assignee: Lyuben Todorov
>Priority: Minor
> Fix For: 1.2.10, 2.0.1
>
> Attachments: 5852_cassandra-1.2.patch, 5852_cassandra-1.2_v2.patch,
> 5852_cassandra-1.2_v3.patch, 5852_cassandra-2.0.patch,
> 5852_cassandra-2.0_v2.patch, r.json
>
>
> Attached is a JSON formatted sstable generated by sstable2json.
> This file cannot be loaded back into Cassandra via json2sstable; it outputs
> this error:
> {code}
> Counting keys to import, please wait... (NOTE: to skip this use -n )
> Importing 16 keys...
> java.lang.NumberFormatException: Non-hex characters in value6
> at org.apache.cassandra.utils.Hex.hexToBytes(Hex.java:60)
> at
> org.apache.cassandra.utils.ByteBufferUtil.hexToBytes(ByteBufferUtil.java:503)
> at
> org.apache.cassandra.tools.SSTableImport.stringAsType(SSTableImport.java:578)
> at
> org.apache.cassandra.tools.SSTableImport.access$000(SSTableImport.java:59)
> at
> org.apache.cassandra.tools.SSTableImport$JsonColumn.(SSTableImport.java:154)
> at
> org.apache.cassandra.tools.SSTableImport.addColumnsToCF(SSTableImport.java:231)
> at
> org.apache.cassandra.tools.SSTableImport.addToStandardCF(SSTableImport.java:214)
> at
> org.apache.cassandra.tools.SSTableImport.importSorted(SSTableImport.java:432)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:319)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:543)
> ERROR: Non-hex characters in value6
> {code}
> Steps to reproduce:
> {code}
> $ ccm create -v git:trunk test-json-import
> Fetching Cassandra updates...
> Current cluster is now: test-json-import
> $ ccm populate -n 1
> $ ccm start
> $ ccm node1 cqlsh
> Connected to test-json-import at 127.0.0.1:9160.
> [cqlsh 4.0.0 | Cassandra 2.0.0-rc1-SNAPSHOT | CQL spec 3.1.0 | Thrift
> protocol 19.37.0]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> cqlsh> CREATE TABLE test.test (key varchar PRIMARY KEY, value varchar);
> cqlsh> INSERT INTO test.test (key, value) VALUES ('ryan', 'ryan');
> cqlsh>
> $ ccm node1 flush
> $ ccm stop
> $ ~/.ccm/test-json-import/node1/bin/json2sstable -s -K test -c test
> ~/Downloads/import_error/r.json
> ~/.ccm/test-json-import/node1/data/test/test/test-test-ja-1-Data.db
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Anastasyev updated CASSANDRA-6086:
---
Attachment: removeUnfinishedCompactionLeftovers.txt
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> -
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
>Reporter: Oleg Anastasyev
> Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
Oleg Anastasyev created CASSANDRA-6086:
--
Summary: Node refuses to start with exception in
ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be
removed files are already removed
Key: CASSANDRA-6086
URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
Project: Cassandra
Issue Type: Bug
Reporter: Oleg Anastasyev
Node refuses to start with
{code}
Caused by: java.lang.IllegalStateException: Unfinished compactions reference
missing sstables. This should never happen since compactions are marked
finished before we start removing the old sstables.
at
org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
at
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
{code}
IMO, there is no reason to refuse to start discivering files that must be
removed are already removed. It looks like pure bug diagnostic code and mean
nothing to operator (nor he can do anything about this).
Replaced throw of excepion with dump of diagnostic warning and continue startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5865) NPE when you mistakenly set listen_address to 0.0.0.0
[
https://issues.apache.org/jira/browse/CASSANDRA-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776304#comment-13776304
]
Jonathan Ellis commented on CASSANDRA-5865:
---
Any reason not to check the cases Dave mentioned?
> NPE when you mistakenly set listen_address to 0.0.0.0
> -
>
> Key: CASSANDRA-5865
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5865
> Project: Cassandra
> Issue Type: Bug
> Environment: Cassandra 1.2.8
>Reporter: Michaël Figuière
>Assignee: Brandon Williams
>Priority: Trivial
> Fix For: 1.2.11
>
> Attachments: 5865.txt
>
>
> It's clearly stated that setting {{listen_address}} to {{0.0.0.0}} is always
> wrong. But if you mistakenly do it anyway you end up with an NPE on 1.2.8
> while it's not the case on 2.0.0-rc1. See bellow:
> {code}
> INFO 16:34:43,598 JOINING: waiting for ring information
> INFO 16:34:44,505 Handshaking version with /127.0.0.1
> INFO 16:34:44,533 Handshaking version with /0.0.0.0
> INFO 16:35:13,626 JOINING: schema complete, ready to bootstrap
> INFO 16:35:13,631 JOINING: getting bootstrap token
> ERROR 16:35:13,633 Exception encountered during startup
> java.lang.RuntimeException: No other nodes seen! Unable to bootstrap.If you
> intended to start a single-node cluster, you should make sure your
> broadcast_address (or listen_address) is listed as a seed. Otherwise, you
> need to determine why the seed being contacted has no knowledge of the rest
> of the cluster. Usually, this can be solved by giving all nodes the same
> seed list.
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapSource(BootStrapper.java:154)
> at
> org.apache.cassandra.dht.BootStrapper.getBalancedToken(BootStrapper.java:135)
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapTokens(BootStrapper.java:115)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:666)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:554)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:451)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:348)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:447)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:490)
> java.lang.RuntimeException: No other nodes seen! Unable to bootstrap.If you
> intended to start a single-node cluster, you should make sure your
> broadcast_address (or listen_address) is listed as a seed. Otherwise, you
> need to determine why the seed being contacted has no knowledge of the rest
> of the cluster. Usually, this can be solved by giving all nodes the same
> seed list.
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapSource(BootStrapper.java:154)
> at
> org.apache.cassandra.dht.BootStrapper.getBalancedToken(BootStrapper.java:135)
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapTokens(BootStrapper.java:115)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:666)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:554)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:451)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:348)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:447)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:490)
> Exception encountered during startup: No other nodes seen! Unable to
> bootstrap.If you intended to start a single-node cluster, you should make
> sure your broadcast_address (or listen_address) is listed as a seed.
> Otherwise, you need to determine why the seed being contacted has no
> knowledge of the rest of the cluster. Usually, this can be solved by giving
> all nodes the same seed list.
> ERROR 16:35:13,668 Exception in thread
> Thread[StorageServiceShutdownHook,5,main]
> java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageService.stopRPCServer(StorageService.java:321)
> at
> org.apache.cassandra.service.StorageService.shutdownClientServers(StorageService.java:370)
> at
> org.apache.cassandra.service.StorageService.access$000(StorageService.java:88)
> at
> org.apache.cassandra.service.StorageService$1.runMayThrow(StorageService.java:519)
> at
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at java.lang.Thread.run(Thread.java:724)
> {code}
--
This message is automatically generated by JIRA.
If
[jira] [Created] (CASSANDRA-6087) Node OOMs on commit log replay when starting up
Oleg Anastasyev created CASSANDRA-6087: -- Summary: Node OOMs on commit log replay when starting up Key: CASSANDRA-6087 URL: https://issues.apache.org/jira/browse/CASSANDRA-6087 Project: Cassandra Issue Type: Bug Reporter: Oleg Anastasyev Attachments: CassandraDaemon.txt After some activity on batchlogs and hints and CFs restarted nodes without finished draining. On startup it OOMs. Investigating it found, that memtables occupied all available RAM, because MeteredFlusher is started later in setup code, so memtables cannot flush. Fixed by starting metered flusher before commit log replay starts -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6078) Wrong memtable size estimation: liveRatio is not honored in edge cases
[ https://issues.apache.org/jira/browse/CASSANDRA-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776306#comment-13776306 ] Jonathan Ellis commented on CASSANDRA-6078: --- WDYT [~jasobrown]? > Wrong memtable size estimation: liveRatio is not honored in edge cases > -- > > Key: CASSANDRA-6078 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6078 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: 6078-v2.txt, Memtable-getLiveSize.diff > > > Memtable.getLiveSize does not honours liveRatio the correct way: > allocator.get**Size() return sizes allocated only by name and columns data > (i.e. no liveRatio applied); but conditions, which cap estimated size, > compare it with estimatedSize, already multiplied by liveRatio. > If liveRatio is big enough (i've seen >11 on our dataset), this leads to huge > estimation errors and even to OutOfMemory, because MeteredFlusher > underestimates memtables sizes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6080) Bad metadata returned for SELECT COUNT
[ https://issues.apache.org/jira/browse/CASSANDRA-6080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-6080: - Reviewer: iamaleksey > Bad metadata returned for SELECT COUNT > -- > > Key: CASSANDRA-6080 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6080 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Minor > Fix For: 2.0.2 > > Attachments: 6080.txt > > > The native protocol v2 returns the result metadata with a prepared statement, > but for count queries this is currently incorrect, we return the metadata > corresponding to a 'SELECT *' instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6087) Node OOMs on commit log replay when starting up
[ https://issues.apache.org/jira/browse/CASSANDRA-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Anastasyev updated CASSANDRA-6087: --- Attachment: CassandraDaemon.txt > Node OOMs on commit log replay when starting up > --- > > Key: CASSANDRA-6087 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6087 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev > Attachments: CassandraDaemon.txt > > > After some activity on batchlogs and hints and CFs restarted nodes without > finished draining. On startup it OOMs. > Investigating it found, that memtables occupied all available RAM, because > MeteredFlusher is started later in setup code, so memtables cannot flush. > Fixed by starting metered flusher before commit log replay starts -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6080) Bad metadata returned for SELECT COUNT
[ https://issues.apache.org/jira/browse/CASSANDRA-6080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776309#comment-13776309 ] Aleksey Yeschenko commented on CASSANDRA-6080: -- +1 > Bad metadata returned for SELECT COUNT > -- > > Key: CASSANDRA-6080 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6080 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Minor > Fix For: 2.0.2 > > Attachments: 6080.txt > > > The native protocol v2 returns the result metadata with a prepared statement, > but for count queries this is currently incorrect, we return the metadata > corresponding to a 'SELECT *' instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[4/6] git commit: Merge branch 'cassandra-1.2' into cassandra-2.0
Merge branch 'cassandra-1.2' into cassandra-2.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7c6e5525 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7c6e5525 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7c6e5525 Branch: refs/heads/trunk Commit: 7c6e5525acdc973c4ddfb4abc510e656923b0bcd Parents: 3448ca5 3a4d10f Author: Jonathan Ellis Authored: Tue Sep 24 08:41:13 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 08:41:13 2013 -0500 -- src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/7c6e5525/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml --
[6/6] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/99691be1 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/99691be1 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/99691be1 Branch: refs/heads/trunk Commit: 99691be14f0bfcba71a2b75343332126c6e749e8 Parents: 08e3346 7c6e552 Author: Jonathan Ellis Authored: Tue Sep 24 08:41:23 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 08:41:23 2013 -0500 -- src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --
[5/6] git commit: Merge branch 'cassandra-1.2' into cassandra-2.0
Merge branch 'cassandra-1.2' into cassandra-2.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7c6e5525 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7c6e5525 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7c6e5525 Branch: refs/heads/cassandra-2.0 Commit: 7c6e5525acdc973c4ddfb4abc510e656923b0bcd Parents: 3448ca5 3a4d10f Author: Jonathan Ellis Authored: Tue Sep 24 08:41:13 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 08:41:13 2013 -0500 -- src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/7c6e5525/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml --
[1/6] git commit: add snapshot repair to NodeToolHelp.yaml
Updated Branches: refs/heads/cassandra-1.2 d014e4ce2 -> 3a4d10ff6 refs/heads/cassandra-2.0 3448ca57f -> 7c6e5525a refs/heads/trunk 08e334649 -> 99691be14 add snapshot repair to NodeToolHelp.yaml Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3a4d10ff Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3a4d10ff Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3a4d10ff Branch: refs/heads/cassandra-1.2 Commit: 3a4d10ff6330d0e3f6b6d7b2927db3338a2866fe Parents: d014e4c Author: Jonathan Ellis Authored: Tue Sep 24 08:41:03 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 08:41:03 2013 -0500 -- src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/3a4d10ff/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml -- diff --git a/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml b/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml index 6feb7b4..318aeed 100644 --- a/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml +++ b/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml @@ -144,7 +144,7 @@ commands: Flush one or more column families - name: repair [keyspace] [cfnames] help: | - Repair one or more column families (use -pr to repair only the first range returned by the partitioner) + Repair one or more column families (use -pr to repair only the first range returned by the partitioner; -snapshot to repair one node at a time sequentially using snapshots) - name: cleanup [keyspace] [cfnames] help: | Run cleanup on one or more column families
[2/6] git commit: add snapshot repair to NodeToolHelp.yaml
add snapshot repair to NodeToolHelp.yaml Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3a4d10ff Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3a4d10ff Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3a4d10ff Branch: refs/heads/cassandra-2.0 Commit: 3a4d10ff6330d0e3f6b6d7b2927db3338a2866fe Parents: d014e4c Author: Jonathan Ellis Authored: Tue Sep 24 08:41:03 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 08:41:03 2013 -0500 -- src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/3a4d10ff/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml -- diff --git a/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml b/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml index 6feb7b4..318aeed 100644 --- a/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml +++ b/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml @@ -144,7 +144,7 @@ commands: Flush one or more column families - name: repair [keyspace] [cfnames] help: | - Repair one or more column families (use -pr to repair only the first range returned by the partitioner) + Repair one or more column families (use -pr to repair only the first range returned by the partitioner; -snapshot to repair one node at a time sequentially using snapshots) - name: cleanup [keyspace] [cfnames] help: | Run cleanup on one or more column families
[3/6] git commit: add snapshot repair to NodeToolHelp.yaml
add snapshot repair to NodeToolHelp.yaml Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3a4d10ff Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3a4d10ff Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3a4d10ff Branch: refs/heads/trunk Commit: 3a4d10ff6330d0e3f6b6d7b2927db3338a2866fe Parents: d014e4c Author: Jonathan Ellis Authored: Tue Sep 24 08:41:03 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 08:41:03 2013 -0500 -- src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/3a4d10ff/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml -- diff --git a/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml b/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml index 6feb7b4..318aeed 100644 --- a/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml +++ b/src/resources/org/apache/cassandra/tools/NodeToolHelp.yaml @@ -144,7 +144,7 @@ commands: Flush one or more column families - name: repair [keyspace] [cfnames] help: | - Repair one or more column families (use -pr to repair only the first range returned by the partitioner) + Repair one or more column families (use -pr to repair only the first range returned by the partitioner; -snapshot to repair one node at a time sequentially using snapshots) - name: cleanup [keyspace] [cfnames] help: | Run cleanup on one or more column families
[jira] [Created] (CASSANDRA-6088) StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout
Oleg Anastasyev created CASSANDRA-6088: -- Summary: StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout Key: CASSANDRA-6088 URL: https://issues.apache.org/jira/browse/CASSANDRA-6088 Project: Cassandra Issue Type: Bug Reporter: Oleg Anastasyev Priority: Minor Attachments: TruncateBlocking.txt We have fat clients on our cluster. Trying to truncate CF gives timeout. This is because fat client dont respond to Truncation messages. Fixed by sending Truncation only to storage endpoints. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6088) StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Anastasyev updated CASSANDRA-6088: --- Attachment: TruncateBlocking.txt > StorageProxy.truncateBlocking sends truncation messages to fat client hosts; > making truncation timeout > -- > > Key: CASSANDRA-6088 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6088 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Priority: Minor > Attachments: TruncateBlocking.txt > > > We have fat clients on our cluster. Trying to truncate CF gives timeout. This > is because fat client dont respond to Truncation messages. > Fixed by sending Truncation only to storage endpoints. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6046) Update repair help to reference -snapshot
[ https://issues.apache.org/jira/browse/CASSANDRA-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776311#comment-13776311 ] Jonathan Ellis commented on CASSANDRA-6046: --- committed > Update repair help to reference -snapshot > - > > Key: CASSANDRA-6046 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6046 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jeremiah Jordan >Assignee: Jeremiah Jordan >Priority: Trivial > Fix For: 1.2.11 > > > Add a reference to -snapshot to the "repair" section of the nodetool help. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5835) Pig CqlStorage doesn't support classic thrift tables
[ https://issues.apache.org/jira/browse/CASSANDRA-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776312#comment-13776312 ] Jonathan Ellis commented on CASSANDRA-5835: --- Pig does extra probing of the schema? > Pig CqlStorage doesn't support classic thrift tables > > > Key: CASSANDRA-5835 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5835 > Project: Cassandra > Issue Type: Bug > Components: Hadoop >Affects Versions: 1.2.7 >Reporter: Alex Liu >Assignee: Alex Liu > Attachments: 5853-1.2-branch.txt > > > CASSANDRA-5752 fix the issue to support thrift tables in Hadoop. This ticket > to support thrift tables in Pig CqlStorage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5835) Pig CqlStorage doesn't support classic thrift tables
[ https://issues.apache.org/jira/browse/CASSANDRA-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-5835: -- Reviewer: brandon.williams > Pig CqlStorage doesn't support classic thrift tables > > > Key: CASSANDRA-5835 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5835 > Project: Cassandra > Issue Type: Bug > Components: Hadoop >Affects Versions: 1.2.7 >Reporter: Alex Liu >Assignee: Alex Liu > Attachments: 5853-1.2-branch.txt > > > CASSANDRA-5752 fix the issue to support thrift tables in Hadoop. This ticket > to support thrift tables in Pig CqlStorage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6070) Keep clients' remote addresses in ClientState
[ https://issues.apache.org/jira/browse/CASSANDRA-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776314#comment-13776314 ] Sylvain Lebresne commented on CASSANDRA-6070: - +1 > Keep clients' remote addresses in ClientState > - > > Key: CASSANDRA-6070 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6070 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 2.0.2 > > Attachments: 6070.txt > > > Keep clients' remote addresses in ClientState -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Send correct metadata on SELECT COUNT
Updated Branches:
refs/heads/cassandra-2.0 7c6e5525a -> 38ae1beef
Send correct metadata on SELECT COUNT
patch by slebresne; reviewed by iamaleksey for CASSANDRA-6080
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/38ae1bee
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/38ae1bee
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/38ae1bee
Branch: refs/heads/cassandra-2.0
Commit: 38ae1beef6cbe42447bfc0c113e0f39b1442ca73
Parents: 7c6e552
Author: Sylvain Lebresne
Authored: Tue Sep 24 15:57:40 2013 +0200
Committer: Sylvain Lebresne
Committed: Tue Sep 24 15:57:40 2013 +0200
--
CHANGES.txt | 1 +
src/java/org/apache/cassandra/cql3/ResultSet.java| 11 +++
.../cassandra/cql3/statements/SelectStatement.java | 4 +++-
3 files changed, 11 insertions(+), 5 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/38ae1bee/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 1bdb6a8..de51837 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Improve memory usage of metadata min/max column names (CASSANDRA-6077)
* Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081)
* Fix insertion of collections with CAS (CASSANDRA-6069)
+ * Correctly send metadata on SELECT COUNT (CASSANDRA-6080)
Merged from 1.2:
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/38ae1bee/src/java/org/apache/cassandra/cql3/ResultSet.java
--
diff --git a/src/java/org/apache/cassandra/cql3/ResultSet.java
b/src/java/org/apache/cassandra/cql3/ResultSet.java
index d15c7d0..e4f27f9 100644
--- a/src/java/org/apache/cassandra/cql3/ResultSet.java
+++ b/src/java/org/apache/cassandra/cql3/ResultSet.java
@@ -102,13 +102,16 @@ public class ResultSet
return makeCountResult(ksName, cfName, count, alias);
}
-public static ResultSet makeCountResult(String ksName, String cfName, long
count, ColumnIdentifier alias)
+public static ResultSet.Metadata makeCountMetadata(String ksName, String
cfName, ColumnIdentifier alias)
{
ColumnSpecification spec = new ColumnSpecification(ksName, cfName,
alias == null ? COUNT_COLUMN : alias, LongType.instance);
-Metadata newMetadata = new Metadata(Collections.singletonList(spec));
-List> newRows =
Collections.singletonList(Collections.singletonList(ByteBufferUtil.bytes(count)));
+return new Metadata(Collections.singletonList(spec));
+}
-return new ResultSet(newMetadata, newRows);
+public static ResultSet makeCountResult(String ksName, String cfName, long
count, ColumnIdentifier alias)
+{
+List> newRows =
Collections.singletonList(Collections.singletonList(ByteBufferUtil.bytes(count)));
+return new ResultSet(makeCountMetadata(ksName, cfName, alias),
newRows);
}
public CqlResult toThriftResult()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/38ae1bee/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
--
diff --git a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
index ff6d4d3..85e9cbc 100644
--- a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
+++ b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
@@ -104,7 +104,9 @@ public class SelectStatement implements CQLStatement
public ResultSet.Metadata getResultMetadata()
{
-return selection.getResultMetadata();
+return parameters.isCount
+ ? ResultSet.makeCountMetadata(keyspace(), columnFamily(),
parameters.countAlias)
+ : selection.getResultMetadata();
}
public int getBoundsTerms()
[2/2] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d3698f89 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d3698f89 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d3698f89 Branch: refs/heads/trunk Commit: d3698f8901eec59af6b3576c70a1cc2b15f384dc Parents: 99691be 38ae1be Author: Sylvain Lebresne Authored: Tue Sep 24 15:58:34 2013 +0200 Committer: Sylvain Lebresne Committed: Tue Sep 24 15:58:34 2013 +0200 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/ResultSet.java| 11 +++ .../cassandra/cql3/statements/SelectStatement.java | 4 +++- 3 files changed, 11 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/d3698f89/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/d3698f89/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java --
[1/2] git commit: Send correct metadata on SELECT COUNT
Updated Branches:
refs/heads/trunk 99691be14 -> d3698f890
Send correct metadata on SELECT COUNT
patch by slebresne; reviewed by iamaleksey for CASSANDRA-6080
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/38ae1bee
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/38ae1bee
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/38ae1bee
Branch: refs/heads/trunk
Commit: 38ae1beef6cbe42447bfc0c113e0f39b1442ca73
Parents: 7c6e552
Author: Sylvain Lebresne
Authored: Tue Sep 24 15:57:40 2013 +0200
Committer: Sylvain Lebresne
Committed: Tue Sep 24 15:57:40 2013 +0200
--
CHANGES.txt | 1 +
src/java/org/apache/cassandra/cql3/ResultSet.java| 11 +++
.../cassandra/cql3/statements/SelectStatement.java | 4 +++-
3 files changed, 11 insertions(+), 5 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/38ae1bee/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 1bdb6a8..de51837 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Improve memory usage of metadata min/max column names (CASSANDRA-6077)
* Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081)
* Fix insertion of collections with CAS (CASSANDRA-6069)
+ * Correctly send metadata on SELECT COUNT (CASSANDRA-6080)
Merged from 1.2:
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/38ae1bee/src/java/org/apache/cassandra/cql3/ResultSet.java
--
diff --git a/src/java/org/apache/cassandra/cql3/ResultSet.java
b/src/java/org/apache/cassandra/cql3/ResultSet.java
index d15c7d0..e4f27f9 100644
--- a/src/java/org/apache/cassandra/cql3/ResultSet.java
+++ b/src/java/org/apache/cassandra/cql3/ResultSet.java
@@ -102,13 +102,16 @@ public class ResultSet
return makeCountResult(ksName, cfName, count, alias);
}
-public static ResultSet makeCountResult(String ksName, String cfName, long
count, ColumnIdentifier alias)
+public static ResultSet.Metadata makeCountMetadata(String ksName, String
cfName, ColumnIdentifier alias)
{
ColumnSpecification spec = new ColumnSpecification(ksName, cfName,
alias == null ? COUNT_COLUMN : alias, LongType.instance);
-Metadata newMetadata = new Metadata(Collections.singletonList(spec));
-List> newRows =
Collections.singletonList(Collections.singletonList(ByteBufferUtil.bytes(count)));
+return new Metadata(Collections.singletonList(spec));
+}
-return new ResultSet(newMetadata, newRows);
+public static ResultSet makeCountResult(String ksName, String cfName, long
count, ColumnIdentifier alias)
+{
+List> newRows =
Collections.singletonList(Collections.singletonList(ByteBufferUtil.bytes(count)));
+return new ResultSet(makeCountMetadata(ksName, cfName, alias),
newRows);
}
public CqlResult toThriftResult()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/38ae1bee/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
--
diff --git a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
index ff6d4d3..85e9cbc 100644
--- a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
+++ b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
@@ -104,7 +104,9 @@ public class SelectStatement implements CQLStatement
public ResultSet.Metadata getResultMetadata()
{
-return selection.getResultMetadata();
+return parameters.isCount
+ ? ResultSet.makeCountMetadata(keyspace(), columnFamily(),
parameters.countAlias)
+ : selection.getResultMetadata();
}
public int getBoundsTerms()
git commit: Track clients' remote addresses in ClientState
Updated Branches:
refs/heads/cassandra-2.0 38ae1beef -> 326d5454d
Track clients' remote addresses in ClientState
patch by Aleksey Yeschenko; reviewed by Sylvain Lebresne for
CASSANDRA-6070
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/326d5454
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/326d5454
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/326d5454
Branch: refs/heads/cassandra-2.0
Commit: 326d5454dd22a40117791952a80fad37e9161d89
Parents: 38ae1be
Author: Aleksey Yeschenko
Authored: Tue Sep 24 16:59:09 2013 +0300
Committer: Aleksey Yeschenko
Committed: Tue Sep 24 17:00:17 2013 +0300
--
CHANGES.txt | 1 +
examples/client_only/src/ClientOnlyExample.java | 109 ---
src/java/org/apache/cassandra/auth/Auth.java| 5 +-
.../cassandra/auth/CassandraAuthorizer.java | 2 +-
.../cassandra/auth/PasswordAuthenticator.java | 2 +-
.../apache/cassandra/cql3/QueryProcessor.java | 5 +-
.../cql3/statements/ListUsersStatement.java | 2 +-
.../apache/cassandra/service/ClientState.java | 64 +++
.../apache/cassandra/service/QueryState.java| 8 ++
.../cassandra/thrift/ThriftClientState.java | 11 +-
.../cassandra/thrift/ThriftSessionManager.java | 6 +-
.../cassandra/transport/ServerConnection.java | 6 +-
12 files changed, 96 insertions(+), 125 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/326d5454/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index de51837..4bc1fd6 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -3,6 +3,7 @@
* Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081)
* Fix insertion of collections with CAS (CASSANDRA-6069)
* Correctly send metadata on SELECT COUNT (CASSANDRA-6080)
+ * Track clients' remote addresses in ClientState (CASSANDRA-6070)
Merged from 1.2:
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/326d5454/examples/client_only/src/ClientOnlyExample.java
--
diff --git a/examples/client_only/src/ClientOnlyExample.java
b/examples/client_only/src/ClientOnlyExample.java
index e823ead..7b42140 100644
--- a/examples/client_only/src/ClientOnlyExample.java
+++ b/examples/client_only/src/ClientOnlyExample.java
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -16,22 +16,18 @@
* limitations under the License.
*/
-import java.nio.ByteBuffer;
-import java.util.*;
import java.util.concurrent.TimeUnit;
+import com.google.common.util.concurrent.Uninterruptibles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.apache.cassandra.cql3.QueryProcessor;
+import org.apache.cassandra.cql3.UntypedResultSet;
import org.apache.cassandra.db.ConsistencyLevel;
-import org.apache.cassandra.db.marshal.AsciiType;
import org.apache.cassandra.exceptions.RequestExecutionException;
import org.apache.cassandra.exceptions.RequestValidationException;
import org.apache.cassandra.service.*;
-import org.apache.cassandra.transport.messages.ResultMessage;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import com.google.common.util.concurrent.Uninterruptibles;
public class ClientOnlyExample
{
@@ -47,24 +43,15 @@ public class ClientOnlyExample
private static void testWriting() throws Exception
{
-ClientState state = new ClientState(false);
-state.setKeyspace(KEYSPACE);
// do some writing.
for (int i = 0; i < 100; i++)
{
-QueryProcessor.process(
-new StringBuilder()
-.append("INSERT INTO ")
-.append(COLUMN_FAMILY)
-.append(" (id, name, value) VALUES ( 'key")
-.append(i)
-.append("', 'colb', 'value")
-.append(i)
-.append("' )")
-.toString(),
-ConsistencyLevel.QUORUM,
-new QueryState(state)
-);
+QueryProcessor.process(String.format("INSERT INTO %s.%s (id, name,
value) VALUES ( 'key%d', 'colb', 'value%d')",
+ KEYSPACE,
+ COLUMN_FAMILY,
+
[2/2] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/455e673b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/455e673b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/455e673b Branch: refs/heads/trunk Commit: 455e673bc9be2311e89eb245318fc1808566c6aa Parents: d3698f8 326d545 Author: Aleksey Yeschenko Authored: Tue Sep 24 17:00:56 2013 +0300 Committer: Aleksey Yeschenko Committed: Tue Sep 24 17:00:56 2013 +0300 -- CHANGES.txt | 1 + examples/client_only/src/ClientOnlyExample.java | 109 --- src/java/org/apache/cassandra/auth/Auth.java| 5 +- .../cassandra/auth/CassandraAuthorizer.java | 2 +- .../cassandra/auth/PasswordAuthenticator.java | 2 +- .../apache/cassandra/cql3/QueryProcessor.java | 5 +- .../cql3/statements/ListUsersStatement.java | 2 +- .../apache/cassandra/service/ClientState.java | 64 +++ .../apache/cassandra/service/QueryState.java| 8 ++ .../cassandra/thrift/ThriftClientState.java | 11 +- .../cassandra/thrift/ThriftSessionManager.java | 6 +- .../cassandra/transport/ServerConnection.java | 6 +- 12 files changed, 96 insertions(+), 125 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/455e673b/CHANGES.txt --
[1/2] git commit: Track clients' remote addresses in ClientState
Updated Branches:
refs/heads/trunk d3698f890 -> 455e673bc
Track clients' remote addresses in ClientState
patch by Aleksey Yeschenko; reviewed by Sylvain Lebresne for
CASSANDRA-6070
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/326d5454
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/326d5454
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/326d5454
Branch: refs/heads/trunk
Commit: 326d5454dd22a40117791952a80fad37e9161d89
Parents: 38ae1be
Author: Aleksey Yeschenko
Authored: Tue Sep 24 16:59:09 2013 +0300
Committer: Aleksey Yeschenko
Committed: Tue Sep 24 17:00:17 2013 +0300
--
CHANGES.txt | 1 +
examples/client_only/src/ClientOnlyExample.java | 109 ---
src/java/org/apache/cassandra/auth/Auth.java| 5 +-
.../cassandra/auth/CassandraAuthorizer.java | 2 +-
.../cassandra/auth/PasswordAuthenticator.java | 2 +-
.../apache/cassandra/cql3/QueryProcessor.java | 5 +-
.../cql3/statements/ListUsersStatement.java | 2 +-
.../apache/cassandra/service/ClientState.java | 64 +++
.../apache/cassandra/service/QueryState.java| 8 ++
.../cassandra/thrift/ThriftClientState.java | 11 +-
.../cassandra/thrift/ThriftSessionManager.java | 6 +-
.../cassandra/transport/ServerConnection.java | 6 +-
12 files changed, 96 insertions(+), 125 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/326d5454/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index de51837..4bc1fd6 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -3,6 +3,7 @@
* Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081)
* Fix insertion of collections with CAS (CASSANDRA-6069)
* Correctly send metadata on SELECT COUNT (CASSANDRA-6080)
+ * Track clients' remote addresses in ClientState (CASSANDRA-6070)
Merged from 1.2:
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/326d5454/examples/client_only/src/ClientOnlyExample.java
--
diff --git a/examples/client_only/src/ClientOnlyExample.java
b/examples/client_only/src/ClientOnlyExample.java
index e823ead..7b42140 100644
--- a/examples/client_only/src/ClientOnlyExample.java
+++ b/examples/client_only/src/ClientOnlyExample.java
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -16,22 +16,18 @@
* limitations under the License.
*/
-import java.nio.ByteBuffer;
-import java.util.*;
import java.util.concurrent.TimeUnit;
+import com.google.common.util.concurrent.Uninterruptibles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.apache.cassandra.cql3.QueryProcessor;
+import org.apache.cassandra.cql3.UntypedResultSet;
import org.apache.cassandra.db.ConsistencyLevel;
-import org.apache.cassandra.db.marshal.AsciiType;
import org.apache.cassandra.exceptions.RequestExecutionException;
import org.apache.cassandra.exceptions.RequestValidationException;
import org.apache.cassandra.service.*;
-import org.apache.cassandra.transport.messages.ResultMessage;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import com.google.common.util.concurrent.Uninterruptibles;
public class ClientOnlyExample
{
@@ -47,24 +43,15 @@ public class ClientOnlyExample
private static void testWriting() throws Exception
{
-ClientState state = new ClientState(false);
-state.setKeyspace(KEYSPACE);
// do some writing.
for (int i = 0; i < 100; i++)
{
-QueryProcessor.process(
-new StringBuilder()
-.append("INSERT INTO ")
-.append(COLUMN_FAMILY)
-.append(" (id, name, value) VALUES ( 'key")
-.append(i)
-.append("', 'colb', 'value")
-.append(i)
-.append("' )")
-.toString(),
-ConsistencyLevel.QUORUM,
-new QueryState(state)
-);
+QueryProcessor.process(String.format("INSERT INTO %s.%s (id, name,
value) VALUES ( 'key%d', 'colb', 'value%d')",
+ KEYSPACE,
+ COLUMN_FAMILY,
+
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776343#comment-13776343 ] Cyril Scetbon commented on CASSANDRA-6084: -- Yes vnodes are enabled. You didn't tell me it's not recommended at [CASSANDRA-5544|https://issues.apache.org/jira/browse/CASSANDRA-5544]. I know it will create too many split as compared to situation when vnodes are disabled, but I suppose it's not the source of errors I get, right ? > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-6074) Read regression in 2.0.1
[ https://issues.apache.org/jira/browse/CASSANDRA-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McGuire resolved CASSANDRA-6074. - Resolution: Cannot Reproduce > Read regression in 2.0.1 > > > Key: CASSANDRA-6074 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6074 > Project: Cassandra > Issue Type: Bug >Reporter: Ryan McGuire > Attachments: 6074 bisect.png, stress 2.0.0 vs 2.0.01.png > > > I'm seeing a regression in stress reads introduced in 2.0.1. Note, that this > is a separate regression from CASSANDRA-5933. > Setup > * 4 node cluster using default settings > * Write: -F 3000 -n 3000 -i 5 -l 2 > * Read: -n 3000 -o read -i 5 > I tried this three times on 2.0.0 and on 2.0.1(tentative; eb96db6c) > 2.0.0 is fine, but 2.0.1 timed out of it's read 2 out of the 3 times, and on > the one that did succeed, it struggled quite a bit at the start: > !stress 2.0.0 vs 2.0.01.png! > [Data can be viewed > here|http://ryanmcguire.info/ds/graph/graph.html?stats=stats.2.0.0v2.0.1.json&metric=interval_op_rate&operation=stress-read&smoothing=4] > I will bisect and update this when I find the commit that introduced this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6088) StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776374#comment-13776374 ] Jonathan Ellis commented on CASSANDRA-6088: --- May actually be your gratuitous import reformatting that's the problem; suggest matching http://wiki.apache.org/cassandra/CodeStyle > StorageProxy.truncateBlocking sends truncation messages to fat client hosts; > making truncation timeout > -- > > Key: CASSANDRA-6088 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6088 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Priority: Minor > Attachments: TruncateBlocking.txt > > > We have fat clients on our cluster. Trying to truncate CF gives timeout. This > is because fat client dont respond to Truncation messages. > Fixed by sending Truncation only to storage endpoints. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: Avoid sending Truncate command to fat clients patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-6088
Updated Branches:
refs/heads/cassandra-1.2 3a4d10ff6 -> bb3ec4ce9
Avoid sending Truncate command to fat clients
patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-6088
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/bb3ec4ce
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/bb3ec4ce
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/bb3ec4ce
Branch: refs/heads/cassandra-1.2
Commit: bb3ec4ce9ec020d0bf7963517f802c2b86e9047a
Parents: 3a4d10f
Author: Jonathan Ellis
Authored: Tue Sep 24 10:12:20 2013 -0500
Committer: Jonathan Ellis
Committed: Tue Sep 24 10:12:20 2013 -0500
--
CHANGES.txt | 1 +
src/java/org/apache/cassandra/gms/Gossiper.java | 20
.../apache/cassandra/service/StorageProxy.java | 4 ++--
3 files changed, 19 insertions(+), 6 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index cecb88a..ae2ab5e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.2.11
+ * Avoid sending Truncate command to fat clients (CASSANDRA-6088)
* Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980)
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/src/java/org/apache/cassandra/gms/Gossiper.java
--
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index b4ea88a..acf40f3 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -218,10 +218,22 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
public Set getLiveMembers()
{
-Set liveMbrs = new HashSet(liveEndpoints);
-if (!liveMbrs.contains(FBUtilities.getBroadcastAddress()))
-liveMbrs.add(FBUtilities.getBroadcastAddress());
-return liveMbrs;
+Set liveMembers = new HashSet(liveEndpoints);
+if (!liveMembers.contains(FBUtilities.getBroadcastAddress()))
+liveMembers.add(FBUtilities.getBroadcastAddress());
+return liveMembers;
+}
+
+public Set getLiveTokenOwners()
+{
+Set tokenOwners = new HashSet();
+for (InetAddress member : getLiveMembers())
+{
+EndpointState epState = endpointStateMap.get(member);
+if (epState != null && !isDeadState(epState) &&
StorageService.instance.getTokenMetadata().isMember(member))
+tokenOwners.add(member);
+}
+return tokenOwners;
}
public Set getUnreachableMembers()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/src/java/org/apache/cassandra/service/StorageProxy.java
--
diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java
b/src/java/org/apache/cassandra/service/StorageProxy.java
index be92213..8a6e52e 100644
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -25,7 +25,6 @@ import java.nio.ByteBuffer;
import java.util.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.AtomicInteger;
-import java.util.concurrent.atomic.AtomicLong;
import javax.management.MBeanServer;
import javax.management.ObjectName;
@@ -1551,7 +1550,8 @@ public class StorageProxy implements StorageProxyMBean
throw new UnavailableException(ConsistencyLevel.ALL, liveMembers +
Gossiper.instance.getUnreachableMembers().size(), liveMembers);
}
-Set allEndpoints = Gossiper.instance.getLiveMembers();
+Set allEndpoints = Gossiper.instance.getLiveTokenOwners();
+
int blockFor = allEndpoints.size();
final TruncateResponseHandler responseHandler = new
TruncateResponseHandler(blockFor);
[jira] [Commented] (CASSANDRA-6088) StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776379#comment-13776379 ] Jonathan Ellis commented on CASSANDRA-6088: --- rebased, fixed code style, and committed > StorageProxy.truncateBlocking sends truncation messages to fat client hosts; > making truncation timeout > -- > > Key: CASSANDRA-6088 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6088 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Attachments: TruncateBlocking.txt > > > We have fat clients on our cluster. Trying to truncate CF gives timeout. This > is because fat client dont respond to Truncation messages. > Fixed by sending Truncation only to storage endpoints. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5865) NPE when you mistakenly set listen_address to 0.0.0.0
[
https://issues.apache.org/jira/browse/CASSANDRA-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776381#comment-13776381
]
Brandon Williams commented on CASSANDRA-5865:
-
There are just too many possibilities, if someone screws up their subnetting.
192.168.0.255 would be invalid in a /24 due to being the broadcast address, but
so would 192.168.0.3 in a /30. 255.* is just a special case of this problem.
I don't think anyone is really going to do this, or use multicast, so it
doesn't seem worth bothering with.
> NPE when you mistakenly set listen_address to 0.0.0.0
> -
>
> Key: CASSANDRA-5865
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5865
> Project: Cassandra
> Issue Type: Bug
> Environment: Cassandra 1.2.8
>Reporter: Michaël Figuière
>Assignee: Brandon Williams
>Priority: Trivial
> Fix For: 1.2.11
>
> Attachments: 5865.txt
>
>
> It's clearly stated that setting {{listen_address}} to {{0.0.0.0}} is always
> wrong. But if you mistakenly do it anyway you end up with an NPE on 1.2.8
> while it's not the case on 2.0.0-rc1. See bellow:
> {code}
> INFO 16:34:43,598 JOINING: waiting for ring information
> INFO 16:34:44,505 Handshaking version with /127.0.0.1
> INFO 16:34:44,533 Handshaking version with /0.0.0.0
> INFO 16:35:13,626 JOINING: schema complete, ready to bootstrap
> INFO 16:35:13,631 JOINING: getting bootstrap token
> ERROR 16:35:13,633 Exception encountered during startup
> java.lang.RuntimeException: No other nodes seen! Unable to bootstrap.If you
> intended to start a single-node cluster, you should make sure your
> broadcast_address (or listen_address) is listed as a seed. Otherwise, you
> need to determine why the seed being contacted has no knowledge of the rest
> of the cluster. Usually, this can be solved by giving all nodes the same
> seed list.
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapSource(BootStrapper.java:154)
> at
> org.apache.cassandra.dht.BootStrapper.getBalancedToken(BootStrapper.java:135)
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapTokens(BootStrapper.java:115)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:666)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:554)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:451)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:348)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:447)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:490)
> java.lang.RuntimeException: No other nodes seen! Unable to bootstrap.If you
> intended to start a single-node cluster, you should make sure your
> broadcast_address (or listen_address) is listed as a seed. Otherwise, you
> need to determine why the seed being contacted has no knowledge of the rest
> of the cluster. Usually, this can be solved by giving all nodes the same
> seed list.
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapSource(BootStrapper.java:154)
> at
> org.apache.cassandra.dht.BootStrapper.getBalancedToken(BootStrapper.java:135)
> at
> org.apache.cassandra.dht.BootStrapper.getBootstrapTokens(BootStrapper.java:115)
> at
> org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:666)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:554)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:451)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:348)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:447)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:490)
> Exception encountered during startup: No other nodes seen! Unable to
> bootstrap.If you intended to start a single-node cluster, you should make
> sure your broadcast_address (or listen_address) is listed as a seed.
> Otherwise, you need to determine why the seed being contacted has no
> knowledge of the rest of the cluster. Usually, this can be solved by giving
> all nodes the same seed list.
> ERROR 16:35:13,668 Exception in thread
> Thread[StorageServiceShutdownHook,5,main]
> java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageService.stopRPCServer(StorageService.java:321)
> at
> org.apache.cassandra.service.StorageService.shutdownClientServers(StorageService.java:370)
> at
> org.apache.cassandra.service.StorageService.access$000(StorageService.j
[jira] [Commented] (CASSANDRA-5913) Nodes with no gossip STATUS shown as "UN" by nodetool:status
[
https://issues.apache.org/jira/browse/CASSANDRA-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776384#comment-13776384
]
Jeremy Hanna commented on CASSANDRA-5913:
-
Another case where there was no gossip STATUS for node X across the cluster
except for on node X. In that case there was a recently bootstrapped node and
it couldn't see node X in either nodetool describering nor in nodetool status
(1.2.6). It could be seen in nodetool status in the rest of the cluster
however. Anyway, so restarting node X refreshed the gossip information and
restored the STATUS part - as well as put it in the describering and nodetool
status output.
> Nodes with no gossip STATUS shown as "UN" by nodetool:status
>
>
> Key: CASSANDRA-5913
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5913
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Environment: 1.2.8
>Reporter: Chris Burroughs
>Priority: Minor
>
> I have no idea if this is a "valid" situation or a larger problem, but either
> way nodetool status should not make it look like everything is a-okay.
> From nt:gossipinfo:
> {noformat}
> /64.215.255.182
> RACK:NOP
> NET_VERSION:6
> HOST_ID:4f3b214b-b03e-46eb-8214-5fab2662a06b
> RELEASE_VERSION:1.2.8
> DC:IAD
> INTERNAL_IP:10.15.2.182
> SCHEMA:59adb24e-f3cd-3e02-97f0-5b395827453f
> RPC_ADDRESS:0.0.0.0
> {noformat}
> {noformat}
> $ ./bin/nt.sh status | grep -i 4055109d-800d-4743-8efa-4ecfff883463
> UN 64.215.255.182 63.84 GB 256 2.5%
> 4055109d-800d-4743-8efa-4ecfff883463 NOP
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[5/8] git commit: Print a warning when using nodetool ring with vnodes. Patch by Lyuben Todorov, reviewed by brandonwilliams for CASSANDRA-5954
Print a warning when using nodetool ring with vnodes.
Patch by Lyuben Todorov, reviewed by brandonwilliams for CASSANDRA-5954
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/fa8d9231
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/fa8d9231
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/fa8d9231
Branch: refs/heads/cassandra-1.2
Commit: fa8d92312e2f881fab8e58c8afc7265bd0d52bab
Parents: bb3ec4c
Author: Brandon Williams
Authored: Tue Sep 24 10:26:04 2013 -0500
Committer: Brandon Williams
Committed: Tue Sep 24 10:26:04 2013 -0500
--
src/java/org/apache/cassandra/tools/NodeCmd.java | 7 +++
1 file changed, 7 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/fa8d9231/src/java/org/apache/cassandra/tools/NodeCmd.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeCmd.java
b/src/java/org/apache/cassandra/tools/NodeCmd.java
index 26cc50e..4416a37 100644
--- a/src/java/org/apache/cassandra/tools/NodeCmd.java
+++ b/src/java/org/apache/cassandra/tools/NodeCmd.java
@@ -31,6 +31,7 @@ import java.util.concurrent.ExecutionException;
import com.google.common.base.Joiner;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Maps;
+import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.commons.cli.*;
import org.yaml.snakeyaml.Loader;
@@ -279,6 +280,12 @@ public class NodeCmd
{
throw new RuntimeException(e);
}
+
+if(DatabaseDescriptor.getNumTokens() > 1)
+{
+outs.println(" Warning: \"nodetool ring\" is used to output all
the tokens of a node.");
+outs.println(" To view status related info of a node use
\"nodetool status\" instead.\n");
+}
}
private void printDc(PrintStream outs, String format, String dc,
LinkedHashMultimap endpointsToTokens,
[4/8] git commit: Print a warning when using nodetool ring with vnodes. Patch by Lyuben Todorov, reviewed by brandonwilliams for CASSANDRA-5954
Print a warning when using nodetool ring with vnodes.
Patch by Lyuben Todorov, reviewed by brandonwilliams for CASSANDRA-5954
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/fa8d9231
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/fa8d9231
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/fa8d9231
Branch: refs/heads/trunk
Commit: fa8d92312e2f881fab8e58c8afc7265bd0d52bab
Parents: bb3ec4c
Author: Brandon Williams
Authored: Tue Sep 24 10:26:04 2013 -0500
Committer: Brandon Williams
Committed: Tue Sep 24 10:26:04 2013 -0500
--
src/java/org/apache/cassandra/tools/NodeCmd.java | 7 +++
1 file changed, 7 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/fa8d9231/src/java/org/apache/cassandra/tools/NodeCmd.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeCmd.java
b/src/java/org/apache/cassandra/tools/NodeCmd.java
index 26cc50e..4416a37 100644
--- a/src/java/org/apache/cassandra/tools/NodeCmd.java
+++ b/src/java/org/apache/cassandra/tools/NodeCmd.java
@@ -31,6 +31,7 @@ import java.util.concurrent.ExecutionException;
import com.google.common.base.Joiner;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Maps;
+import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.commons.cli.*;
import org.yaml.snakeyaml.Loader;
@@ -279,6 +280,12 @@ public class NodeCmd
{
throw new RuntimeException(e);
}
+
+if(DatabaseDescriptor.getNumTokens() > 1)
+{
+outs.println(" Warning: \"nodetool ring\" is used to output all
the tokens of a node.");
+outs.println(" To view status related info of a node use
\"nodetool status\" instead.\n");
+}
}
private void printDc(PrintStream outs, String format, String dc,
LinkedHashMultimap endpointsToTokens,
[1/8] git commit: Avoid sending Truncate command to fat clients patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-6088
Updated Branches:
refs/heads/cassandra-1.2 bb3ec4ce9 -> fa8d92312
refs/heads/cassandra-2.0 326d5454d -> 424206a15
refs/heads/trunk 455e673bc -> 938e6989a
Avoid sending Truncate command to fat clients
patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-6088
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/bb3ec4ce
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/bb3ec4ce
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/bb3ec4ce
Branch: refs/heads/cassandra-2.0
Commit: bb3ec4ce9ec020d0bf7963517f802c2b86e9047a
Parents: 3a4d10f
Author: Jonathan Ellis
Authored: Tue Sep 24 10:12:20 2013 -0500
Committer: Jonathan Ellis
Committed: Tue Sep 24 10:12:20 2013 -0500
--
CHANGES.txt | 1 +
src/java/org/apache/cassandra/gms/Gossiper.java | 20
.../apache/cassandra/service/StorageProxy.java | 4 ++--
3 files changed, 19 insertions(+), 6 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index cecb88a..ae2ab5e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.2.11
+ * Avoid sending Truncate command to fat clients (CASSANDRA-6088)
* Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980)
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/src/java/org/apache/cassandra/gms/Gossiper.java
--
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index b4ea88a..acf40f3 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -218,10 +218,22 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
public Set getLiveMembers()
{
-Set liveMbrs = new HashSet(liveEndpoints);
-if (!liveMbrs.contains(FBUtilities.getBroadcastAddress()))
-liveMbrs.add(FBUtilities.getBroadcastAddress());
-return liveMbrs;
+Set liveMembers = new HashSet(liveEndpoints);
+if (!liveMembers.contains(FBUtilities.getBroadcastAddress()))
+liveMembers.add(FBUtilities.getBroadcastAddress());
+return liveMembers;
+}
+
+public Set getLiveTokenOwners()
+{
+Set tokenOwners = new HashSet();
+for (InetAddress member : getLiveMembers())
+{
+EndpointState epState = endpointStateMap.get(member);
+if (epState != null && !isDeadState(epState) &&
StorageService.instance.getTokenMetadata().isMember(member))
+tokenOwners.add(member);
+}
+return tokenOwners;
}
public Set getUnreachableMembers()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/src/java/org/apache/cassandra/service/StorageProxy.java
--
diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java
b/src/java/org/apache/cassandra/service/StorageProxy.java
index be92213..8a6e52e 100644
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -25,7 +25,6 @@ import java.nio.ByteBuffer;
import java.util.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.AtomicInteger;
-import java.util.concurrent.atomic.AtomicLong;
import javax.management.MBeanServer;
import javax.management.ObjectName;
@@ -1551,7 +1550,8 @@ public class StorageProxy implements StorageProxyMBean
throw new UnavailableException(ConsistencyLevel.ALL, liveMembers +
Gossiper.instance.getUnreachableMembers().size(), liveMembers);
}
-Set allEndpoints = Gossiper.instance.getLiveMembers();
+Set allEndpoints = Gossiper.instance.getLiveTokenOwners();
+
int blockFor = allEndpoints.size();
final TruncateResponseHandler responseHandler = new
TruncateResponseHandler(blockFor);
[8/8] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/938e6989 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/938e6989 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/938e6989 Branch: refs/heads/trunk Commit: 938e6989a6f12a4cd68e6f0e7980b2687dd701e1 Parents: 455e673 424206a Author: Brandon Williams Authored: Tue Sep 24 10:29:23 2013 -0500 Committer: Brandon Williams Committed: Tue Sep 24 10:29:23 2013 -0500 -- CHANGES.txt | 2 ++ src/java/org/apache/cassandra/gms/Gossiper.java | 20 .../apache/cassandra/service/StorageProxy.java | 3 ++- .../org/apache/cassandra/tools/NodeCmd.java | 7 +++ 4 files changed, 27 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/938e6989/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/938e6989/src/java/org/apache/cassandra/gms/Gossiper.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/938e6989/src/java/org/apache/cassandra/service/StorageProxy.java --
[7/8] git commit: Merge branch 'cassandra-1.2' into cassandra-2.0
Merge branch 'cassandra-1.2' into cassandra-2.0 Conflicts: CHANGES.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/424206a1 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/424206a1 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/424206a1 Branch: refs/heads/cassandra-2.0 Commit: 424206a154297c5ea3a50506aa9e2a1a669f76c1 Parents: 326d545 fa8d923 Author: Brandon Williams Authored: Tue Sep 24 10:29:09 2013 -0500 Committer: Brandon Williams Committed: Tue Sep 24 10:29:09 2013 -0500 -- CHANGES.txt | 2 ++ src/java/org/apache/cassandra/gms/Gossiper.java | 20 .../apache/cassandra/service/StorageProxy.java | 3 ++- .../org/apache/cassandra/tools/NodeCmd.java | 7 +++ 4 files changed, 27 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/CHANGES.txt -- diff --cc CHANGES.txt index 4bc1fd6,ae2ab5e..281665e --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,10 -1,6 +1,12 @@@ -1.2.11 +2.0.2 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077) + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) + * Fix insertion of collections with CAS (CASSANDRA-6069) + * Correctly send metadata on SELECT COUNT (CASSANDRA-6080) + * Track clients' remote addresses in ClientState (CASSANDRA-6070) +Merged from 1.2: + * Avoid sending Truncate command to fat clients (CASSANDRA-6088) + * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037) * Do not open non-ssl storage port if encryption option is all (CASSANDRA-3916) * Move batchlog replay to its own executor (CASSANDRA-6079) http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/src/java/org/apache/cassandra/gms/Gossiper.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/src/java/org/apache/cassandra/service/StorageProxy.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/src/java/org/apache/cassandra/tools/NodeCmd.java -- diff --cc src/java/org/apache/cassandra/tools/NodeCmd.java index 1ae5de8,4416a37..943db7d --- a/src/java/org/apache/cassandra/tools/NodeCmd.java +++ b/src/java/org/apache/cassandra/tools/NodeCmd.java @@@ -31,8 -31,11 +31,9 @@@ import java.util.concurrent.ExecutionEx import com.google.common.base.Joiner; import com.google.common.collect.LinkedHashMultimap; import com.google.common.collect.Maps; + import org.apache.cassandra.config.DatabaseDescriptor; import org.apache.cassandra.utils.FBUtilities; import org.apache.commons.cli.*; -import org.yaml.snakeyaml.Loader; -import org.yaml.snakeyaml.TypeDescription; import org.yaml.snakeyaml.Yaml; import org.yaml.snakeyaml.constructor.Constructor;
[3/8] git commit: Print a warning when using nodetool ring with vnodes. Patch by Lyuben Todorov, reviewed by brandonwilliams for CASSANDRA-5954
Print a warning when using nodetool ring with vnodes.
Patch by Lyuben Todorov, reviewed by brandonwilliams for CASSANDRA-5954
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/fa8d9231
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/fa8d9231
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/fa8d9231
Branch: refs/heads/cassandra-2.0
Commit: fa8d92312e2f881fab8e58c8afc7265bd0d52bab
Parents: bb3ec4c
Author: Brandon Williams
Authored: Tue Sep 24 10:26:04 2013 -0500
Committer: Brandon Williams
Committed: Tue Sep 24 10:26:04 2013 -0500
--
src/java/org/apache/cassandra/tools/NodeCmd.java | 7 +++
1 file changed, 7 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/fa8d9231/src/java/org/apache/cassandra/tools/NodeCmd.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeCmd.java
b/src/java/org/apache/cassandra/tools/NodeCmd.java
index 26cc50e..4416a37 100644
--- a/src/java/org/apache/cassandra/tools/NodeCmd.java
+++ b/src/java/org/apache/cassandra/tools/NodeCmd.java
@@ -31,6 +31,7 @@ import java.util.concurrent.ExecutionException;
import com.google.common.base.Joiner;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Maps;
+import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.commons.cli.*;
import org.yaml.snakeyaml.Loader;
@@ -279,6 +280,12 @@ public class NodeCmd
{
throw new RuntimeException(e);
}
+
+if(DatabaseDescriptor.getNumTokens() > 1)
+{
+outs.println(" Warning: \"nodetool ring\" is used to output all
the tokens of a node.");
+outs.println(" To view status related info of a node use
\"nodetool status\" instead.\n");
+}
}
private void printDc(PrintStream outs, String format, String dc,
LinkedHashMultimap endpointsToTokens,
[2/8] git commit: Avoid sending Truncate command to fat clients patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-6088
Avoid sending Truncate command to fat clients
patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-6088
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/bb3ec4ce
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/bb3ec4ce
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/bb3ec4ce
Branch: refs/heads/trunk
Commit: bb3ec4ce9ec020d0bf7963517f802c2b86e9047a
Parents: 3a4d10f
Author: Jonathan Ellis
Authored: Tue Sep 24 10:12:20 2013 -0500
Committer: Jonathan Ellis
Committed: Tue Sep 24 10:12:20 2013 -0500
--
CHANGES.txt | 1 +
src/java/org/apache/cassandra/gms/Gossiper.java | 20
.../apache/cassandra/service/StorageProxy.java | 4 ++--
3 files changed, 19 insertions(+), 6 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index cecb88a..ae2ab5e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.2.11
+ * Avoid sending Truncate command to fat clients (CASSANDRA-6088)
* Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980)
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
* Do not open non-ssl storage port if encryption option is all
(CASSANDRA-3916)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/src/java/org/apache/cassandra/gms/Gossiper.java
--
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index b4ea88a..acf40f3 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -218,10 +218,22 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
public Set getLiveMembers()
{
-Set liveMbrs = new HashSet(liveEndpoints);
-if (!liveMbrs.contains(FBUtilities.getBroadcastAddress()))
-liveMbrs.add(FBUtilities.getBroadcastAddress());
-return liveMbrs;
+Set liveMembers = new HashSet(liveEndpoints);
+if (!liveMembers.contains(FBUtilities.getBroadcastAddress()))
+liveMembers.add(FBUtilities.getBroadcastAddress());
+return liveMembers;
+}
+
+public Set getLiveTokenOwners()
+{
+Set tokenOwners = new HashSet();
+for (InetAddress member : getLiveMembers())
+{
+EndpointState epState = endpointStateMap.get(member);
+if (epState != null && !isDeadState(epState) &&
StorageService.instance.getTokenMetadata().isMember(member))
+tokenOwners.add(member);
+}
+return tokenOwners;
}
public Set getUnreachableMembers()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bb3ec4ce/src/java/org/apache/cassandra/service/StorageProxy.java
--
diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java
b/src/java/org/apache/cassandra/service/StorageProxy.java
index be92213..8a6e52e 100644
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -25,7 +25,6 @@ import java.nio.ByteBuffer;
import java.util.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.AtomicInteger;
-import java.util.concurrent.atomic.AtomicLong;
import javax.management.MBeanServer;
import javax.management.ObjectName;
@@ -1551,7 +1550,8 @@ public class StorageProxy implements StorageProxyMBean
throw new UnavailableException(ConsistencyLevel.ALL, liveMembers +
Gossiper.instance.getUnreachableMembers().size(), liveMembers);
}
-Set allEndpoints = Gossiper.instance.getLiveMembers();
+Set allEndpoints = Gossiper.instance.getLiveTokenOwners();
+
int blockFor = allEndpoints.size();
final TruncateResponseHandler responseHandler = new
TruncateResponseHandler(blockFor);
[6/8] git commit: Merge branch 'cassandra-1.2' into cassandra-2.0
Merge branch 'cassandra-1.2' into cassandra-2.0 Conflicts: CHANGES.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/424206a1 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/424206a1 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/424206a1 Branch: refs/heads/trunk Commit: 424206a154297c5ea3a50506aa9e2a1a669f76c1 Parents: 326d545 fa8d923 Author: Brandon Williams Authored: Tue Sep 24 10:29:09 2013 -0500 Committer: Brandon Williams Committed: Tue Sep 24 10:29:09 2013 -0500 -- CHANGES.txt | 2 ++ src/java/org/apache/cassandra/gms/Gossiper.java | 20 .../apache/cassandra/service/StorageProxy.java | 3 ++- .../org/apache/cassandra/tools/NodeCmd.java | 7 +++ 4 files changed, 27 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/CHANGES.txt -- diff --cc CHANGES.txt index 4bc1fd6,ae2ab5e..281665e --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,10 -1,6 +1,12 @@@ -1.2.11 +2.0.2 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077) + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) + * Fix insertion of collections with CAS (CASSANDRA-6069) + * Correctly send metadata on SELECT COUNT (CASSANDRA-6080) + * Track clients' remote addresses in ClientState (CASSANDRA-6070) +Merged from 1.2: + * Avoid sending Truncate command to fat clients (CASSANDRA-6088) + * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037) * Do not open non-ssl storage port if encryption option is all (CASSANDRA-3916) * Move batchlog replay to its own executor (CASSANDRA-6079) http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/src/java/org/apache/cassandra/gms/Gossiper.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/src/java/org/apache/cassandra/service/StorageProxy.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/424206a1/src/java/org/apache/cassandra/tools/NodeCmd.java -- diff --cc src/java/org/apache/cassandra/tools/NodeCmd.java index 1ae5de8,4416a37..943db7d --- a/src/java/org/apache/cassandra/tools/NodeCmd.java +++ b/src/java/org/apache/cassandra/tools/NodeCmd.java @@@ -31,8 -31,11 +31,9 @@@ import java.util.concurrent.ExecutionEx import com.google.common.base.Joiner; import com.google.common.collect.LinkedHashMultimap; import com.google.common.collect.Maps; + import org.apache.cassandra.config.DatabaseDescriptor; import org.apache.cassandra.utils.FBUtilities; import org.apache.commons.cli.*; -import org.yaml.snakeyaml.Loader; -import org.yaml.snakeyaml.TypeDescription; import org.yaml.snakeyaml.Yaml; import org.yaml.snakeyaml.constructor.Constructor;
[jira] [Commented] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776390#comment-13776390
]
Yuki Morishita commented on CASSANDRA-6086:
---
The primary reason we have removeUnfinishedCompacitonLeftovers check is to not
overcount counters stored.
If we do not stop at the original exception, then we will have both compacted
SSTables and leftovers which may produce unexpected counter value.
Though we have the report that "this happens"(CASSANDRA-6008), we should fix
somehow.
Maybe we consider compaction is finished even if we have entry in
compactions_in_progress but some or all of the input SSTables are missing.
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> -
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
>Reporter: Oleg Anastasyev
> Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776390#comment-13776390
]
Yuki Morishita edited comment on CASSANDRA-6086 at 9/24/13 3:32 PM:
The primary reason we have removeUnfinishedCompacitonLeftovers check is to not
overcount counters stored.
If we do not stop at the original exception, then we will have both compacted
SSTables and leftovers which may produce unexpected counter value.
Though we have the report that "this happens"(CASSANDRA-6008), we should fix
somehow.
Maybe we can consider compaction is finished even if we have entry in
compactions_in_progress but some or all of the input SSTables are missing.
was (Author: yukim):
The primary reason we have removeUnfinishedCompacitonLeftovers check is to
not overcount counters stored.
If we do not stop at the original exception, then we will have both compacted
SSTables and leftovers which may produce unexpected counter value.
Though we have the report that "this happens"(CASSANDRA-6008), we should fix
somehow.
Maybe we consider compaction is finished even if we have entry in
compactions_in_progress but some or all of the input SSTables are missing.
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> -
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
>Reporter: Oleg Anastasyev
> Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-5712) Reverse slice queries can skip range tombstones
[ https://issues.apache.org/jira/browse/CASSANDRA-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremiah Jordan reassigned CASSANDRA-5712: -- Assignee: Jeremiah Jordan (was: Sylvain Lebresne) > Reverse slice queries can skip range tombstones > --- > > Key: CASSANDRA-5712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5712 > Project: Cassandra > Issue Type: Bug >Affects Versions: 1.2.0 >Reporter: Sylvain Lebresne >Assignee: Jeremiah Jordan > Fix For: 1.2.7 > > Attachments: 5712.txt > > > On disk, we represent range tombstones by a marker at the beginning of the > range covered. Since we repeat such markers when they overlap an index block > and since an index block is always read in forward order (even in reverse > queries), we are guaranteed to see a range tombstone before any column it > covers. However, IndexedSliceReader returns the columns of an index block in > reverse order and thus can return a range tombstone *after* columns it covers. > It follows that some range tombstone can be skipped during a reversed range > slice. We need to fix IndexedSliceReader to always return range tombstone > first (or at least before the first column covered by each range tombstone). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5720) AssertionError in CompactionExecutor
[
https://issues.apache.org/jira/browse/CASSANDRA-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeremiah Jordan updated CASSANDRA-5720:
---
Reproduced In: 1.2.7
> AssertionError in CompactionExecutor
>
>
> Key: CASSANDRA-5720
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5720
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.2.5, 1.2.7
> Environment: 4 nodes
> RF 2
>Reporter: Eric Falcao
> Labels: compaction, ttl
>
> Seeing this on all 4 of my nodes during a major compaction.
> {code}
> ERROR [CompactionExecutor:57927] 2013-07-03 13:41:27,591 CassandraDaemon.java
> (line 175) Exception in thread Thread[CompactionExecutor:57927,1,RMI Runtime]
> java.lang.AssertionError: originally calculated column size of 443395646 but
> now it is 443395712
> at
> org.apache.cassandra.db.compaction.LazilyCompactedRow.write(LazilyCompactedRow.java:135)
> at
> org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:160)
> at
> org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:162)
> at
> org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48)
> at
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:58)
> at
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
> at
> org.apache.cassandra.db.compaction.CompactionManager$6.runMayThrow(CompactionManager.java:355)
> at
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:722)
> {code}
> A little bit about this CF. It stores data with a TTL of up to 30 days. These
> rows are wide. We run major compactions to remove expired data. This has been
> our setup for almost 2 years and this issue only started cropping up after
> upgrading to 1.2.5 (from 1.1.5)
> I've been running scrub in the meantime to remove expired data. Now, I'm
> ending up with lots of similarly sized SSTables that C* is trying constantly
> to compact. These minor compactions of the bigger SSTables are failing also.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6088) StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-6088: -- Fix Version/s: 2.0.2 1.2.11 > StorageProxy.truncateBlocking sends truncation messages to fat client hosts; > making truncation timeout > -- > > Key: CASSANDRA-6088 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6088 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: TruncateBlocking.txt > > > We have fat clients on our cluster. Trying to truncate CF gives timeout. This > is because fat client dont respond to Truncation messages. > Fixed by sending Truncation only to storage endpoints. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-5835) Pig CqlStorage doesn't support classic thrift tables
[ https://issues.apache.org/jira/browse/CASSANDRA-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776407#comment-13776407 ] Alex Liu commented on CASSANDRA-5835: - yes. Pig has schema. This ticket has been fixed by another, we can close it as duplicate. > Pig CqlStorage doesn't support classic thrift tables > > > Key: CASSANDRA-5835 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5835 > Project: Cassandra > Issue Type: Bug > Components: Hadoop >Affects Versions: 1.2.7 >Reporter: Alex Liu >Assignee: Alex Liu > Attachments: 5853-1.2-branch.txt > > > CASSANDRA-5752 fix the issue to support thrift tables in Hadoop. This ticket > to support thrift tables in Pig CqlStorage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-6086:
--
Reviewer: yukim
Component/s: Core
Fix Version/s: 2.0.2
Assignee: Oleg Anastasyev
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> -
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Oleg Anastasyev
>Assignee: Oleg Anastasyev
> Fix For: 2.0.2
>
> Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-5712) Reverse slice queries can skip range tombstones
[ https://issues.apache.org/jira/browse/CASSANDRA-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremiah Jordan updated CASSANDRA-5712: --- Assignee: Sylvain Lebresne (was: Jeremiah Jordan) > Reverse slice queries can skip range tombstones > --- > > Key: CASSANDRA-5712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5712 > Project: Cassandra > Issue Type: Bug >Affects Versions: 1.2.0 >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne > Fix For: 1.2.7 > > Attachments: 5712.txt > > > On disk, we represent range tombstones by a marker at the beginning of the > range covered. Since we repeat such markers when they overlap an index block > and since an index block is always read in forward order (even in reverse > queries), we are guaranteed to see a range tombstone before any column it > covers. However, IndexedSliceReader returns the columns of an index block in > reverse order and thus can return a range tombstone *after* columns it covers. > It follows that some range tombstone can be skipped during a reversed range > slice. We need to fix IndexedSliceReader to always return range tombstone > first (or at least before the first column covered by each range tombstone). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[07/11] git commit: merge from 1.2
merge from 1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7af56b5a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7af56b5a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7af56b5a Branch: refs/heads/trunk Commit: 7af56b5ae4c3b201a2633745042233ef66766ec2 Parents: f3dddb3 1b79d6e Author: Jonathan Ellis Authored: Tue Sep 24 10:46:48 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:46:48 2013 -0500 -- CHANGES.txt| 1 + src/java/org/apache/cassandra/service/CassandraDaemon.java | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/7af56b5a/CHANGES.txt -- diff --cc CHANGES.txt index 54b2e9e,a5903fa..4d52c99 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,8 -1,5 +1,9 @@@ -1.2.11 +2.0.2 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077) + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) + * Fix insertion of collections with CAS (CASSANDRA-6069) +Merged from 1.2: + * Start MeteredFlusher earlier to prevent OOM during CL replay (CASSANDRA-6087) * Avoid sending Truncate command to fat clients (CASSANDRA-6088) * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037) http://git-wip-us.apache.org/repos/asf/cassandra/blob/7af56b5a/src/java/org/apache/cassandra/service/CassandraDaemon.java -- diff --cc src/java/org/apache/cassandra/service/CassandraDaemon.java index 2879f1d,448bb0a..ae8a5a2 --- a/src/java/org/apache/cassandra/service/CassandraDaemon.java +++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java @@@ -331,10 -339,7 +335,7 @@@ public class CassandraDaemo }; StorageService.optionalTasks.schedule(runnable, 5 * 60, TimeUnit.SECONDS); - // MeteredFlusher can block if flush queue fills up, so don't put on scheduledTasks - StorageService.optionalTasks.scheduleWithFixedDelay(new MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS); - -SystemTable.finishStartup(); +SystemKeyspace.finishStartup(); // start server internals StorageService.instance.registerDaemon(this);
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776410#comment-13776410 ] Alex Liu commented on CASSANDRA-6084: - Let's disable the vnode to see whether we can reproduce the issue? > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[02/11] git commit: merge from 1.2
merge from 1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f3dddb3b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f3dddb3b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f3dddb3b Branch: refs/heads/trunk Commit: f3dddb3bd5e0332717d36d40effba363dd230853 Parents: 7c6e552 bb3ec4c Author: Jonathan Ellis Authored: Tue Sep 24 10:14:04 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:14:04 2013 -0500 -- CHANGES.txt | 3 +++ src/java/org/apache/cassandra/gms/Gossiper.java | 20 .../apache/cassandra/service/StorageProxy.java | 3 ++- 3 files changed, 21 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3dddb3b/CHANGES.txt -- diff --cc CHANGES.txt index 1bdb6a8,ae2ab5e..54b2e9e --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,49 -1,13 +1,52 @@@ -1.2.11 +2.0.2 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077) + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) + * Fix insertion of collections with CAS (CASSANDRA-6069) +Merged from 1.2: + * Avoid sending Truncate command to fat clients (CASSANDRA-6088) + * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037) * Do not open non-ssl storage port if encryption option is all (CASSANDRA-3916) * Move batchlog replay to its own executor (CASSANDRA-6079) * Add tombstone debug threshold and histogram (CASSANDRA-6042, 6057) + * Enable tcp keepalive on incoming connections (CASSANDRA-4053) + -1.2.10 +2.0.1 + * Fix bug that could allow reading deleted data temporarily (CASSANDRA-6025) + * Improve memory use defaults (CASSANDRA-5069) + * Make ThriftServer more easlly extensible (CASSANDRA-6058) + * Remove Hadoop dependency from ITransportFactory (CASSANDRA-6062) + * add file_cache_size_in_mb setting (CASSANDRA-5661) + * Improve error message when yaml contains invalid properties (CASSANDRA-5958) + * Improve leveled compaction's ability to find non-overlapping L0 compactions + to work on concurrently (CASSANDRA-5921) + * Notify indexer of columns shadowed by range tombstones (CASSANDRA-5614) + * Log Merkle tree stats (CASSANDRA-2698) + * Switch from crc32 to adler32 for compressed sstable checksums (CASSANDRA-5862) + * Improve offheap memcpy performance (CASSANDRA-5884) + * Use a range aware scanner for cleanup (CASSANDRA-2524) + * Cleanup doesn't need to inspect sstables that contain only local data + (CASSANDRA-5722) + * Add ability for CQL3 to list partition keys (CASSANDRA-4536) + * Improve native protocol serialization (CASSANDRA-5664) + * Upgrade Thrift to 0.9.1 (CASSANDRA-5923) + * Require superuser status for adding triggers (CASSANDRA-5963) + * Make standalone scrubber handle old and new style leveled manifest + (CASSANDRA-6005) + * Fix paxos bugs (CASSANDRA-6012, 6013, 6023) + * Fix paged ranges with multiple replicas (CASSANDRA-6004) + * Fix potential AssertionError during tracing (CASSANDRA-6041) + * Fix NPE in sstablesplit (CASSANDRA-6027) + * Migrate pre-2.0 key/value/column aliases to system.schema_columns + (CASSANDRA-6009) + * Paging filter empty rows too agressively (CASSANDRA-6040) + * Support variadic parameters for IN clauses (CASSANDRA-4210) + * cqlsh: return the result of CAS writes (CASSANDRA-5796) + * Fix validation of IN clauses with 2ndary indexes (CASSANDRA-6050) + * Support named bind variables in CQL (CASSANDRA-6033) +Merged from 1.2: + * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Avoid second-guessing out-of-space state (CASSANDRA-5605) * Tuning knobs for dealing with large blobs and many CFs (CASSANDRA-5982) * (Hadoop) Fix CQLRW for thrift tables (CASSANDRA-6002) http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3dddb3b/src/java/org/apache/cassandra/gms/Gossiper.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3dddb3b/src/java/org/apache/cassandra/service/StorageProxy.java --
[11/11] git commit: merge from 2.0
merge from 2.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2fea9fab Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2fea9fab Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2fea9fab Branch: refs/heads/trunk Commit: 2fea9fab059dc8f3bdfb0c29eef6dd5d162342e8 Parents: bab62d5 938e698 Author: Jonathan Ellis Authored: Tue Sep 24 10:48:03 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:48:03 2013 -0500 -- CHANGES.txt | 2 + examples/client_only/src/ClientOnlyExample.java | 109 --- src/java/org/apache/cassandra/auth/Auth.java| 5 +- .../cassandra/auth/CassandraAuthorizer.java | 2 +- .../cassandra/auth/PasswordAuthenticator.java | 2 +- .../apache/cassandra/cql3/QueryProcessor.java | 5 +- .../org/apache/cassandra/cql3/ResultSet.java| 11 +- .../cql3/statements/ListUsersStatement.java | 2 +- .../cql3/statements/SelectStatement.java| 4 +- .../apache/cassandra/service/ClientState.java | 64 +++ .../apache/cassandra/service/QueryState.java| 8 ++ .../cassandra/thrift/ThriftClientState.java | 11 +- .../cassandra/thrift/ThriftSessionManager.java | 6 +- .../org/apache/cassandra/tools/NodeCmd.java | 7 ++ .../cassandra/transport/ServerConnection.java | 6 +- 15 files changed, 114 insertions(+), 130 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/2fea9fab/CHANGES.txt -- diff --cc CHANGES.txt index 60cae04,cd6fd05..97c99d4 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -10,8 -10,9 +10,10 @@@ * Improve memory usage of metadata min/max column names (CASSANDRA-6077) * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) * Fix insertion of collections with CAS (CASSANDRA-6069) + * Correctly send metadata on SELECT COUNT (CASSANDRA-6080) + * Track clients' remote addresses in ClientState (CASSANDRA-6070) Merged from 1.2: + * Start MeteredFlusher earlier to prevent OOM during CL replay (CASSANDRA-6087) * Avoid sending Truncate command to fat clients (CASSANDRA-6088) * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
[jira] [Commented] (CASSANDRA-6087) Node OOMs on commit log replay when starting up
[ https://issues.apache.org/jira/browse/CASSANDRA-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776413#comment-13776413 ] Jonathan Ellis commented on CASSANDRA-6087: --- committed > Node OOMs on commit log replay when starting up > --- > > Key: CASSANDRA-6087 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6087 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev > Fix For: 1.2.11, 2.0.2 > > Attachments: CassandraDaemon.txt > > > After some activity on batchlogs and hints and CFs restarted nodes without > finished draining. On startup it OOMs. > Investigating it found, that memtables occupied all available RAM, because > MeteredFlusher is started later in setup code, so memtables cannot flush. > Fixed by starting metered flusher before commit log replay starts -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[06/11] git commit: merge from 1.2
merge from 1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7af56b5a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7af56b5a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7af56b5a Branch: refs/heads/cassandra-2.0 Commit: 7af56b5ae4c3b201a2633745042233ef66766ec2 Parents: f3dddb3 1b79d6e Author: Jonathan Ellis Authored: Tue Sep 24 10:46:48 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:46:48 2013 -0500 -- CHANGES.txt| 1 + src/java/org/apache/cassandra/service/CassandraDaemon.java | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/7af56b5a/CHANGES.txt -- diff --cc CHANGES.txt index 54b2e9e,a5903fa..4d52c99 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,8 -1,5 +1,9 @@@ -1.2.11 +2.0.2 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077) + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) + * Fix insertion of collections with CAS (CASSANDRA-6069) +Merged from 1.2: + * Start MeteredFlusher earlier to prevent OOM during CL replay (CASSANDRA-6087) * Avoid sending Truncate command to fat clients (CASSANDRA-6088) * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037) http://git-wip-us.apache.org/repos/asf/cassandra/blob/7af56b5a/src/java/org/apache/cassandra/service/CassandraDaemon.java -- diff --cc src/java/org/apache/cassandra/service/CassandraDaemon.java index 2879f1d,448bb0a..ae8a5a2 --- a/src/java/org/apache/cassandra/service/CassandraDaemon.java +++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java @@@ -331,10 -339,7 +335,7 @@@ public class CassandraDaemo }; StorageService.optionalTasks.schedule(runnable, 5 * 60, TimeUnit.SECONDS); - // MeteredFlusher can block if flush queue fills up, so don't put on scheduledTasks - StorageService.optionalTasks.scheduleWithFixedDelay(new MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS); - -SystemTable.finishStartup(); +SystemKeyspace.finishStartup(); // start server internals StorageService.instance.registerDaemon(this);
[05/11] git commit: Start MeteredFlusher earlier to prevent OOM during CL replay patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-7078
Start MeteredFlusher earlier to prevent OOM during CL replay
patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-7078
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1b79d6ed
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1b79d6ed
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1b79d6ed
Branch: refs/heads/trunk
Commit: 1b79d6ed4f19752369a0345ae8d611ec107746d5
Parents: bb3ec4c
Author: Jonathan Ellis
Authored: Tue Sep 24 10:44:20 2013 -0500
Committer: Jonathan Ellis
Committed: Tue Sep 24 10:44:20 2013 -0500
--
CHANGES.txt| 1 +
src/java/org/apache/cassandra/service/CassandraDaemon.java | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/1b79d6ed/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index ae2ab5e..a5903fa 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.2.11
+ * Start MeteredFlusher earlier to prevent OOM during CL replay
(CASSANDRA-6087)
* Avoid sending Truncate command to fat clients (CASSANDRA-6088)
* Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980)
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/1b79d6ed/src/java/org/apache/cassandra/service/CassandraDaemon.java
--
diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java
b/src/java/org/apache/cassandra/service/CassandraDaemon.java
index b2fc367..448bb0a 100644
--- a/src/java/org/apache/cassandra/service/CassandraDaemon.java
+++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java
@@ -297,6 +297,10 @@ public class CassandraDaemon
logger.warn("Unable to start GCInspector (currently only supported
on the Sun JVM)");
}
+// MeteredFlusher can block if flush queue fills up, so don't put on
scheduledTasks
+// Start it before commit log, so memtables can flush during commit
log replay
+StorageService.optionalTasks.scheduleWithFixedDelay(new
MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS);
+
// replay the log if necessary
try
{
@@ -335,9 +339,6 @@ public class CassandraDaemon
};
StorageService.optionalTasks.schedule(runnable, 5 * 60,
TimeUnit.SECONDS);
-// MeteredFlusher can block if flush queue fills up, so don't put on
scheduledTasks
-StorageService.optionalTasks.scheduleWithFixedDelay(new
MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS);
-
SystemTable.finishStartup();
// start server internals
[10/11] git commit: merge from 1.2
merge from 1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/07638f41 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/07638f41 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/07638f41 Branch: refs/heads/cassandra-2.0 Commit: 07638f41a8c62932b05bdb498aaaedabd2efd139 Parents: 7af56b5 424206a Author: Jonathan Ellis Authored: Tue Sep 24 10:47:40 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:47:40 2013 -0500 -- CHANGES.txt | 2 + examples/client_only/src/ClientOnlyExample.java | 109 --- src/java/org/apache/cassandra/auth/Auth.java| 5 +- .../cassandra/auth/CassandraAuthorizer.java | 2 +- .../cassandra/auth/PasswordAuthenticator.java | 2 +- .../apache/cassandra/cql3/QueryProcessor.java | 5 +- .../org/apache/cassandra/cql3/ResultSet.java| 11 +- .../cql3/statements/ListUsersStatement.java | 2 +- .../cql3/statements/SelectStatement.java| 4 +- .../apache/cassandra/service/ClientState.java | 64 +++ .../apache/cassandra/service/QueryState.java| 8 ++ .../cassandra/thrift/ThriftClientState.java | 11 +- .../cassandra/thrift/ThriftSessionManager.java | 6 +- .../org/apache/cassandra/tools/NodeCmd.java | 7 ++ .../cassandra/transport/ServerConnection.java | 6 +- 15 files changed, 114 insertions(+), 130 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/07638f41/CHANGES.txt -- diff --cc CHANGES.txt index 4d52c99,281665e..830f568 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -2,8 -2,9 +2,10 @@@ * Improve memory usage of metadata min/max column names (CASSANDRA-6077) * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) * Fix insertion of collections with CAS (CASSANDRA-6069) + * Correctly send metadata on SELECT COUNT (CASSANDRA-6080) + * Track clients' remote addresses in ClientState (CASSANDRA-6070) Merged from 1.2: + * Start MeteredFlusher earlier to prevent OOM during CL replay (CASSANDRA-6087) * Avoid sending Truncate command to fat clients (CASSANDRA-6088) * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
[01/11] git commit: merge from 1.2
Updated Branches: refs/heads/cassandra-1.2 fa8d92312 -> 546485310 refs/heads/cassandra-2.0 424206a15 -> 07638f41a refs/heads/trunk 938e6989a -> 2fea9fab0 merge from 1.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f3dddb3b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f3dddb3b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f3dddb3b Branch: refs/heads/cassandra-2.0 Commit: f3dddb3bd5e0332717d36d40effba363dd230853 Parents: 7c6e552 bb3ec4c Author: Jonathan Ellis Authored: Tue Sep 24 10:14:04 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:14:04 2013 -0500 -- CHANGES.txt | 3 +++ src/java/org/apache/cassandra/gms/Gossiper.java | 20 .../apache/cassandra/service/StorageProxy.java | 3 ++- 3 files changed, 21 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3dddb3b/CHANGES.txt -- diff --cc CHANGES.txt index 1bdb6a8,ae2ab5e..54b2e9e --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,49 -1,13 +1,52 @@@ -1.2.11 +2.0.2 + * Improve memory usage of metadata min/max column names (CASSANDRA-6077) + * Fix thrift validation refusing row markers on CQL3 tables (CASSANDRA-6081) + * Fix insertion of collections with CAS (CASSANDRA-6069) +Merged from 1.2: + * Avoid sending Truncate command to fat clients (CASSANDRA-6088) + * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Allow where clause conditions to be in parenthesis (CASSANDRA-6037) * Do not open non-ssl storage port if encryption option is all (CASSANDRA-3916) * Move batchlog replay to its own executor (CASSANDRA-6079) * Add tombstone debug threshold and histogram (CASSANDRA-6042, 6057) + * Enable tcp keepalive on incoming connections (CASSANDRA-4053) + -1.2.10 +2.0.1 + * Fix bug that could allow reading deleted data temporarily (CASSANDRA-6025) + * Improve memory use defaults (CASSANDRA-5069) + * Make ThriftServer more easlly extensible (CASSANDRA-6058) + * Remove Hadoop dependency from ITransportFactory (CASSANDRA-6062) + * add file_cache_size_in_mb setting (CASSANDRA-5661) + * Improve error message when yaml contains invalid properties (CASSANDRA-5958) + * Improve leveled compaction's ability to find non-overlapping L0 compactions + to work on concurrently (CASSANDRA-5921) + * Notify indexer of columns shadowed by range tombstones (CASSANDRA-5614) + * Log Merkle tree stats (CASSANDRA-2698) + * Switch from crc32 to adler32 for compressed sstable checksums (CASSANDRA-5862) + * Improve offheap memcpy performance (CASSANDRA-5884) + * Use a range aware scanner for cleanup (CASSANDRA-2524) + * Cleanup doesn't need to inspect sstables that contain only local data + (CASSANDRA-5722) + * Add ability for CQL3 to list partition keys (CASSANDRA-4536) + * Improve native protocol serialization (CASSANDRA-5664) + * Upgrade Thrift to 0.9.1 (CASSANDRA-5923) + * Require superuser status for adding triggers (CASSANDRA-5963) + * Make standalone scrubber handle old and new style leveled manifest + (CASSANDRA-6005) + * Fix paxos bugs (CASSANDRA-6012, 6013, 6023) + * Fix paged ranges with multiple replicas (CASSANDRA-6004) + * Fix potential AssertionError during tracing (CASSANDRA-6041) + * Fix NPE in sstablesplit (CASSANDRA-6027) + * Migrate pre-2.0 key/value/column aliases to system.schema_columns + (CASSANDRA-6009) + * Paging filter empty rows too agressively (CASSANDRA-6040) + * Support variadic parameters for IN clauses (CASSANDRA-4210) + * cqlsh: return the result of CAS writes (CASSANDRA-5796) + * Fix validation of IN clauses with 2ndary indexes (CASSANDRA-6050) + * Support named bind variables in CQL (CASSANDRA-6033) +Merged from 1.2: + * Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980) * Avoid second-guessing out-of-space state (CASSANDRA-5605) * Tuning knobs for dealing with large blobs and many CFs (CASSANDRA-5982) * (Hadoop) Fix CQLRW for thrift tables (CASSANDRA-6002) http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3dddb3b/src/java/org/apache/cassandra/gms/Gossiper.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3dddb3b/src/java/org/apache/cassandra/service/StorageProxy.java --
[03/11] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/108b4db5 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/108b4db5 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/108b4db5 Branch: refs/heads/trunk Commit: 108b4db53bfc5d7507ccca228ca942d85eb3dc0a Parents: 99691be f3dddb3 Author: Jonathan Ellis Authored: Tue Sep 24 10:14:12 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:14:12 2013 -0500 -- CHANGES.txt | 3 +++ src/java/org/apache/cassandra/gms/Gossiper.java | 20 .../apache/cassandra/service/StorageProxy.java | 3 ++- 3 files changed, 21 insertions(+), 5 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/108b4db5/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/108b4db5/src/java/org/apache/cassandra/gms/Gossiper.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/108b4db5/src/java/org/apache/cassandra/service/StorageProxy.java --
[09/11] git commit: Start MeteredFlusher earlier to prevent OOM during CL replay patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-7078
Start MeteredFlusher earlier to prevent OOM during CL replay
patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-7078
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/54648531
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/54648531
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/54648531
Branch: refs/heads/cassandra-1.2
Commit: 546485310e20dd2c6c67f863cba4b5acd1bae586
Parents: fa8d923
Author: Jonathan Ellis
Authored: Tue Sep 24 10:44:20 2013 -0500
Committer: Jonathan Ellis
Committed: Tue Sep 24 10:47:08 2013 -0500
--
CHANGES.txt| 1 +
src/java/org/apache/cassandra/service/CassandraDaemon.java | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/54648531/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index ae2ab5e..a5903fa 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.2.11
+ * Start MeteredFlusher earlier to prevent OOM during CL replay
(CASSANDRA-6087)
* Avoid sending Truncate command to fat clients (CASSANDRA-6088)
* Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980)
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/54648531/src/java/org/apache/cassandra/service/CassandraDaemon.java
--
diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java
b/src/java/org/apache/cassandra/service/CassandraDaemon.java
index b2fc367..448bb0a 100644
--- a/src/java/org/apache/cassandra/service/CassandraDaemon.java
+++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java
@@ -297,6 +297,10 @@ public class CassandraDaemon
logger.warn("Unable to start GCInspector (currently only supported
on the Sun JVM)");
}
+// MeteredFlusher can block if flush queue fills up, so don't put on
scheduledTasks
+// Start it before commit log, so memtables can flush during commit
log replay
+StorageService.optionalTasks.scheduleWithFixedDelay(new
MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS);
+
// replay the log if necessary
try
{
@@ -335,9 +339,6 @@ public class CassandraDaemon
};
StorageService.optionalTasks.schedule(runnable, 5 * 60,
TimeUnit.SECONDS);
-// MeteredFlusher can block if flush queue fills up, so don't put on
scheduledTasks
-StorageService.optionalTasks.scheduleWithFixedDelay(new
MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS);
-
SystemTable.finishStartup();
// start server internals
[jira] [Commented] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776424#comment-13776424
]
Oleg Anastasyev commented on CASSANDRA-6086:
Well, the common with CASSANDRA-6008 is that in my case node was dead before
restart due to OOM. However, unlike 6008, CFs on which it reported this error
was never truncated.
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> -
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Oleg Anastasyev
>Assignee: Oleg Anastasyev
> Fix For: 2.0.2
>
> Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4191) Add `nodetool cfstats ` abilities
[ https://issues.apache.org/jira/browse/CASSANDRA-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776425#comment-13776425 ] Brandon Williams commented on CASSANDRA-4191: - Looks good, but there's still no way to include a secondary index without getting the entire keyspace, which is actually what Keyspace1.Standard1.Idx1 returns. > Add `nodetool cfstats ` abilities > -- > > Key: CASSANDRA-4191 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4191 > Project: Cassandra > Issue Type: New Feature >Affects Versions: 1.2.0 beta 1 >Reporter: Joaquin Casares >Assignee: Lyuben Todorov >Priority: Minor > Labels: datastax_qa > Fix For: 1.2.9 > > Attachments: 4191.patch, 4191_specific_cfstats.diff > > > This way cfstats will only print information per keyspace/column family > combinations. > Another related proposal as an alternative to this ticket: > Allow for `nodetool cfstats` to use --excludes or --includes to accept > keyspace and column family arguments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6086) Node refuses to start with exception in ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to be removed files are already removed
[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776428#comment-13776428
]
Oleg Anastasyev commented on CASSANDRA-6086:
>From the other hand, the leftovers about to remove are already missing (i.e.
>already removed) when exception is thrown. I am not sure how can it influence
>counter value.
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> -
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Oleg Anastasyev
>Assignee: Oleg Anastasyev
> Fix For: 2.0.2
>
> Attachments: removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[08/11] git commit: Merge branch 'cassandra-2.0' into trunk
Merge branch 'cassandra-2.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/bab62d56 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/bab62d56 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/bab62d56 Branch: refs/heads/trunk Commit: bab62d560628e115b6ee86e9b24b7dccc3e288bc Parents: 108b4db 7af56b5 Author: Jonathan Ellis Authored: Tue Sep 24 10:46:56 2013 -0500 Committer: Jonathan Ellis Committed: Tue Sep 24 10:46:56 2013 -0500 -- CHANGES.txt| 1 + src/java/org/apache/cassandra/service/CassandraDaemon.java | 7 --- 2 files changed, 5 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/bab62d56/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/bab62d56/src/java/org/apache/cassandra/service/CassandraDaemon.java --
[jira] [Updated] (CASSANDRA-4638) Patch to bin/cassandra to use 64bit JVM if available
[ https://issues.apache.org/jira/browse/CASSANDRA-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Evans updated CASSANDRA-4638: -- Attachment: 4638.patch > Patch to bin/cassandra to use 64bit JVM if available > > > Key: CASSANDRA-4638 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4638 > Project: Cassandra > Issue Type: Improvement > Components: Core >Affects Versions: 1.1.4 > Environment: Tested on Solaris 11 with Oracle supplied JVM 1.6 and 1.7 >Reporter: Bernhard Roth > Labels: 64bit, linux, solaris > Attachments: 4638.patch, cassandra.patch > > Original Estimate: 0.25h > Remaining Estimate: 0.25h > > Cassandra uses by default the JAVA binary at $JAVA_HOME/bin and complains at > start that the 64bit version should be used. > Well, even if the 64bit JAVA version is installed, cassandra still does not > use it. > Attached patch solves this problem by checking if $JAVA_HOME/bin/amd64/java > binary exists. If yes, it will be used for cassandra. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776450#comment-13776450 ] Oleg Anastasyev commented on CASSANDRA-6079: Well, I did some quick test. As i suspected there is no measurable performance impact on this. 3 node cluster, RF=3, separated client, writing batches of 3 inserts each to 3 different CFs. 8 core (not so) recent iron servers. (no batches were replayed actually, so this pure common case). I measured this for 1 hour run in both cases. Here is performance WITH wait on get(): avg 3052 batches/sec, st deviance 131 WITHOUT waiting in get() avg 3030 per sec, deviance 106 > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[04/11] git commit: Start MeteredFlusher earlier to prevent OOM during CL replay patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-7078
Start MeteredFlusher earlier to prevent OOM during CL replay
patch by Oleg Anastasyev; reviewed by jbellis for CASSANDRA-7078
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/1b79d6ed
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/1b79d6ed
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/1b79d6ed
Branch: refs/heads/cassandra-2.0
Commit: 1b79d6ed4f19752369a0345ae8d611ec107746d5
Parents: bb3ec4c
Author: Jonathan Ellis
Authored: Tue Sep 24 10:44:20 2013 -0500
Committer: Jonathan Ellis
Committed: Tue Sep 24 10:44:20 2013 -0500
--
CHANGES.txt| 1 +
src/java/org/apache/cassandra/service/CassandraDaemon.java | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/1b79d6ed/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index ae2ab5e..a5903fa 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.2.11
+ * Start MeteredFlusher earlier to prevent OOM during CL replay
(CASSANDRA-6087)
* Avoid sending Truncate command to fat clients (CASSANDRA-6088)
* Allow cache-keys-to-save to be set at runtime (CASSANDRA-5980)
* Allow where clause conditions to be in parenthesis (CASSANDRA-6037)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/1b79d6ed/src/java/org/apache/cassandra/service/CassandraDaemon.java
--
diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java
b/src/java/org/apache/cassandra/service/CassandraDaemon.java
index b2fc367..448bb0a 100644
--- a/src/java/org/apache/cassandra/service/CassandraDaemon.java
+++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java
@@ -297,6 +297,10 @@ public class CassandraDaemon
logger.warn("Unable to start GCInspector (currently only supported
on the Sun JVM)");
}
+// MeteredFlusher can block if flush queue fills up, so don't put on
scheduledTasks
+// Start it before commit log, so memtables can flush during commit
log replay
+StorageService.optionalTasks.scheduleWithFixedDelay(new
MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS);
+
// replay the log if necessary
try
{
@@ -335,9 +339,6 @@ public class CassandraDaemon
};
StorageService.optionalTasks.schedule(runnable, 5 * 60,
TimeUnit.SECONDS);
-// MeteredFlusher can block if flush queue fills up, so don't put on
scheduledTasks
-StorageService.optionalTasks.scheduleWithFixedDelay(new
MeteredFlusher(), 1000, 1000, TimeUnit.MILLISECONDS);
-
SystemTable.finishStartup();
// start server internals
[jira] [Commented] (CASSANDRA-4638) Patch to bin/cassandra to use 64bit JVM if available
[
https://issues.apache.org/jira/browse/CASSANDRA-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776457#comment-13776457
]
Eric Evans commented on CASSANDRA-4638:
---
{quote}
Please note that the wish to use automatically the 64-bit JVM is not only no
Solaris, I would like to see the same feature on Linux or other operating
systems on which cassandra may run and which may use a downloaded version of
the JVM.
As far as I remember even cassandra was telling in the log files that a 64bit
JVM shall be used.
{quote}
The way this is supposed to work is that (whenever possible), you properly
configure the system for the version of Java you are using; The desired Java
binary should be in the path. When this isn't possible, the {{$JAVA_HOME}}
environment variable can be used to infer the location.
We use {{$JAVA_HOME}} here because it is a _very_ widely used convention, and
something that people are familiar with. This is the first report I'm aware of
where {{$JAVA_HOME/bin/java}} wouldn't work.
TL;DR Linux doesn't have this issue.
I propose [this alternate
patch|https://issues.apache.org/jira/secure/attachment/12604822/4638.patch]
instead. It's effectively the same, but implements a search list which is
(hopefully) easier to grok, and will be easier to extend if we have to add more
alternatives.
> Patch to bin/cassandra to use 64bit JVM if available
>
>
> Key: CASSANDRA-4638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4638
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.1.4
> Environment: Tested on Solaris 11 with Oracle supplied JVM 1.6 and 1.7
>Reporter: Bernhard Roth
> Labels: 64bit, linux, solaris
> Attachments: 4638.patch, cassandra.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Cassandra uses by default the JAVA binary at $JAVA_HOME/bin and complains at
> start that the 64bit version should be used.
> Well, even if the 64bit JAVA version is installed, cassandra still does not
> use it.
> Attached patch solves this problem by checking if $JAVA_HOME/bin/amd64/java
> binary exists. If yes, it will be used for cassandra.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776465#comment-13776465 ] Alex Liu commented on CASSANDRA-6084: - I will work on vnode support for hadoop/pig later once I have my other tasks done. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6071) CqlStorage loading compact table adds an extraneous field to the pig schema
[
https://issues.apache.org/jira/browse/CASSANDRA-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-6071:
---
Attachment: 6071-2.txt
Sorry about that, updated patch attached
> CqlStorage loading compact table adds an extraneous field to the pig schema
> ---
>
> Key: CASSANDRA-6071
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6071
> Project: Cassandra
> Issue Type: Bug
> Components: Hadoop
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Minor
> Fix For: 1.2.11
>
> Attachments: 6071-2.txt, 6071.txt
>
>
> {code}
> CREATE TABLE t (
> key text,
> field1 int,
> field2 int
> PRIMARY KEY (key, field1)
> ) WITH COMPACT STORAGE;
> INSERT INTO t (key,field1,field2) VALUES ('key1',1,2);
> INSERT INTO t (key,field1,field2) VALUES ('key2',1,2);
> INSERT INTO t (key,field1,field2) VALUES ('key3',1,2);
> {code}
> {code}
> grunt> t = LOAD 'cql://ks/t' USING CqlStorage();
> grunt> describe t;
> t: {key: chararray,field1: int,field2: int,value: int}
> dump t;
> (key1,1,2,)
> (key3,1,2,)
> (key2,1,2,)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6071) CqlStorage loading compact table adds an extraneous field to the pig schema
[
https://issues.apache.org/jira/browse/CASSANDRA-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776476#comment-13776476
]
Alex Liu commented on CASSANDRA-6071:
-
+1
> CqlStorage loading compact table adds an extraneous field to the pig schema
> ---
>
> Key: CASSANDRA-6071
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6071
> Project: Cassandra
> Issue Type: Bug
> Components: Hadoop
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Minor
> Fix For: 1.2.11
>
> Attachments: 6071-2.txt, 6071.txt
>
>
> {code}
> CREATE TABLE t (
> key text,
> field1 int,
> field2 int
> PRIMARY KEY (key, field1)
> ) WITH COMPACT STORAGE;
> INSERT INTO t (key,field1,field2) VALUES ('key1',1,2);
> INSERT INTO t (key,field1,field2) VALUES ('key2',1,2);
> INSERT INTO t (key,field1,field2) VALUES ('key3',1,2);
> {code}
> {code}
> grunt> t = LOAD 'cql://ks/t' USING CqlStorage();
> grunt> describe t;
> t: {key: chararray,field1: int,field2: int,value: int}
> dump t;
> (key1,1,2,)
> (key3,1,2,)
> (key2,1,2,)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Deleted] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Anastasyev updated CASSANDRA-6079: --- Comment: was deleted (was: Batchlog functionality is critical for our current application (having batch mutation consistency within 60sec, like it is in current implementation is not acceptable for us), so we considering replayAllBatches to run every rpcwrite timeout interval, which could be costly with current batchlog implementation. So, I looked further at Batchlog manager and see a room for improvement there: Currently it rescans the whole dataset to find batches to replay. A slight change in data model can eliminate this. a quick guess is to have batchlog table as ( minuteoftheday int, written_at timestamp, id uuid, data blob primary key (minuteoftheday, written_at) ) so batches are split to buckets and stored in order of their arrival to local node. BatchlogManager on each replay cycle selects batchlog records with written_at between (currentTime-RpcWriteTimeout*2) and (currentTime-RpcWriteTimeout). Only on the very 1st cycle after startup it scans all records to find batchlog records from previous node run. This way, at any replay cycle, except the very first, BM scans only batchlog entries for last couple of seconds. And its performance does not depend on batchlog CF compaction. And because it scans over recent columns only it will unlikely to hit to disk. Am I missing something ? (we could implement this rewrite, if you find it useful for others as well) ) > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776479#comment-13776479 ] Oleg Anastasyev commented on CASSANDRA-6079: Batchlog functionality is critical for our current application (having batch mutation consistency within 60sec, like it is in current implementation is not acceptable for us), so we considering replayAllBatches to run every rpcwrite timeout interval, which could be costly with current batchlog implementation. So, I looked further at Batchlog manager and see a room for improvement there: Currently it rescans the whole dataset to find batches to replay. A slight change in data model can eliminate this. a quick guess is to have batchlog table as ( minuteoftheday int, written_at timestamp, id uuid, data blob primary key (minuteoftheday, written_at) ) so batches are split to buckets and stored in order of their arrival to local node. BatchlogManager on each replay cycle selects batchlog records with written_at between (currentTime-RpcWriteTimeout*2) and (currentTime-RpcWriteTimeout). Only on the very 1st cycle after startup it scans all records to find batchlog records from previous node run. This way, at any replay cycle, except the very first, BM scans only batchlog entries for last couple of seconds. And its performance does not depend on batchlog CF compaction. And because it scans over recent columns only it will unlikely to hit to disk. Am I missing something ? (we could implement this rewrite, if you find it useful for others as well) > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776493#comment-13776493 ] Jonathan Ellis commented on CASSANDRA-6079: --- I think you're missing that we need to replay not just for coordinator failure but for replica failure. So "only scan for last couple seconds" is not correct; you need to scan every partition since the replica went down. (Note that for typical deployments, replica failure will be 3x more likely than coordinator failure.) > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6088) StorageProxy.truncateBlocking sends truncation messages to fat client hosts; making truncation timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776371#comment-13776371 ] Jonathan Ellis commented on CASSANDRA-6088: --- Patch does not apply to 1.2 or 2.0 or trunk, can you rebase? > StorageProxy.truncateBlocking sends truncation messages to fat client hosts; > making truncation timeout > -- > > Key: CASSANDRA-6088 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6088 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Priority: Minor > Attachments: TruncateBlocking.txt > > > We have fat clients on our cluster. Trying to truncate CF gives timeout. This > is because fat client dont respond to Truncation messages. > Fixed by sending Truncation only to storage endpoints. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776519#comment-13776519 ] Oleg Anastasyev commented on CASSANDRA-6079: Do you mean the replica, which is target for one of batched mutations ? I see a hint is written by BM if it cannot deliver one of mutations serialized to backlog record (in replaySerializedMutation and attemptDirectDelivery) , so as i understood HintManager bothers further about delivering it to failed replica when it is back online. So as soon as BM writes a hint(s) for (all of) failed replica(s), BM has nothing to do with batchlog record, so no all partitions scanning neccessary. Am I missing something again ? > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776519#comment-13776519 ] Oleg Anastasyev edited comment on CASSANDRA-6079 at 9/24/13 5:28 PM: - Do you mean the replica, which is target for one of batched mutations ? I see a hint is written by BM if it cannot deliver one of mutations serialized to batchlog record (in replaySerializedMutation and attemptDirectDelivery) , so as i understood HintManager bothers further about delivering it to failed replica when it is back online. So as soon as BM writes a hint(s) for (all of) failed replica(s), BM has nothing to do with batchlog record, so no all partitions scanning neccessary. Am I missing something again ? was (Author: m0nstermind): Do you mean the replica, which is target for one of batched mutations ? I see a hint is written by BM if it cannot deliver one of mutations serialized to backlog record (in replaySerializedMutation and attemptDirectDelivery) , so as i understood HintManager bothers further about delivering it to failed replica when it is back online. So as soon as BM writes a hint(s) for (all of) failed replica(s), BM has nothing to do with batchlog record, so no all partitions scanning neccessary. Am I missing something again ? > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3673) Allow reduced consistency in sstableloader utility
[ https://issues.apache.org/jira/browse/CASSANDRA-3673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776523#comment-13776523 ] Brandon Williams commented on CASSANDRA-3673: - We do already have the -i,--ignore option which is quite similar. > Allow reduced consistency in sstableloader utility > -- > > Key: CASSANDRA-3673 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3673 > Project: Cassandra > Issue Type: New Feature > Components: Tools >Reporter: Samarth Gahire >Priority: Minor > Labels: sstableloader, streaming > Original Estimate: 72h > Remaining Estimate: 72h > > Below are some of the issues I have been facing since I am using > sstable-loader cassandra utility in cassandra-0.8.2 > 1) We have configured the sstableloader on a different machine.Since we have > loaded sstables from this machine it has become a part of the cluster and > except loading time it is always unreachable in describe cluster. > a)As it is unreachable whenever I changes the schema it says this node is > unreachable(but its ok as schema change reflect over the other nodes) > b) The main problem is when I tried to remove the node out of the cluster > using nodetool removetoken ,the process stucks saying "RemovalStatus: > Removing token (62676456546693435176060154681903071729). Waiting for > replication confirmation from [cassandra-1/(10.10.01.10)(This is the ip of > loader machine)]".As loader is part of the cluster and cassandra tries to > stream the data from loader machine and could not stream. > So instead of making loader machine permanent part of the cluster can we make > it temporarily part of the cluster? > 2)When any of the node is down or unreachable with thrift based client like > pelop we can insert the data into the cassandra cluster.But this is not the > case with the sstable-loader.It do not work(do not stream) when any of the > nodes in the cluster is down or unreachable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6048) CQL3 data filtering improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Liu updated CASSANDRA-6048:
Assignee: Alex Liu
> CQL3 data filtering improvement
> ---
>
> Key: CASSANDRA-6048
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6048
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Alex Liu
>Assignee: Alex Liu
>
> Existing data filtering uses the following algorithm
> {code}
>1. find best selective predicate based on the smallest mean columns count
>2. fetch rows for the best selective predicate predicate, then filter the
> data based on other predicates left.
> {code}
> So potentially we could improve the performance by
> {code}
>1. joining multiple predicates then do the data filtering for other
> predicates.
>2. fine tune the best predicate selection algorithm
> {code}
> For multiple predicate join, it could improve performance if one predicate
> has many entries and another predicate has a very few of entries. It means a
> few index CF read, join the row keys, fetch rows then filter other predicates
> Another approach is to have index on multiple columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-6085) Pig CqlStorage read schema changes to (value, value ... value) from ((name,value), (name, value) ... (name, value)) . Do we need make it backward compatible?
[
https://issues.apache.org/jira/browse/CASSANDRA-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams resolved CASSANDRA-6085.
-
Resolution: Won't Fix
CqlStorage is new enough that I don't see the need to take on extra code to
make it backward-compatible.
> Pig CqlStorage read schema changes to (value, value ... value) from
> ((name,value), (name, value) ... (name, value)) . Do we need make it backward
> compatible?
> -
>
> Key: CASSANDRA-6085
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6085
> Project: Cassandra
> Issue Type: Bug
>Reporter: Alex Liu
>Assignee: Alex Liu
>Priority: Minor
>
> Since the pushdown needs the schema change from (name, value) tuple to value
> {code}
> schema: (value, value, value) where keys are in the front. Each has its
> name in the column schema
> {code}
> Doesn't anyone needs backward compatible which will block filter push down?
> The new schema is much concise than the old one, and It still keeps the
> column name in the column schema.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4705) Speculative execution for reads / eager retries
[ https://issues.apache.org/jira/browse/CASSANDRA-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776674#comment-13776674 ] Li Zou commented on CASSANDRA-4705: --- [~iamaleksey] please see my comments at [CASSANDRA-5932|https://issues.apache.org/jira/browse/CASSANDRA-5932] > Speculative execution for reads / eager retries > --- > > Key: CASSANDRA-4705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4705 > Project: Cassandra > Issue Type: Improvement >Reporter: Vijay >Assignee: Vijay > Fix For: 2.0 beta 1 > > Attachments: 0001-CASSANDRA-4705.patch, 0001-CASSANDRA-4705-v2.patch, > 0001-CASSANDRA-4705-v3.patch, > 0001-Refactor-to-introduce-AbstractReadExecutor.patch, > 0002-Add-Speculative-execution-for-Row-Reads.patch > > > When read_repair is not 1.0, we send the request to one node for some of the > requests. When a node goes down or when a node is too busy the client has to > wait for the timeout before it can retry. > It would be nice to watch for latency and execute an additional request to a > different node, if the response is not received within average/99% of the > response times recorded in the past. > CASSANDRA-2540 might be able to solve the variance when read_repair is set to > 1.0 > 1) May be we need to use metrics-core to record various Percentiles > 2) Modify ReadCallback.get to execute additional request speculatively. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-6089) client_only example does not work
Mikhail Panchenko created CASSANDRA-6089:
Summary: client_only example does not work
Key: CASSANDRA-6089
URL: https://issues.apache.org/jira/browse/CASSANDRA-6089
Project: Cassandra
Issue Type: Bug
Reporter: Mikhail Panchenko
client_only example fails out of the box with:
{code}
13/09/24 11:44:53 INFO gms.Gossiper: Node /127.0.0.1 is now part of the cluster
13/09/24 11:44:53 INFO gms.Gossiper: InetAddress /127.0.0.1 is now UP
13/09/24 11:44:53 ERROR concurrent.DebuggableThreadPoolExecutor: Error in
ThreadPoolExecutor
java.lang.NullPointerException
at
org.apache.cassandra.service.MigrationManager.maybeScheduleSchemaPull(MigrationManager.java:113)
at
org.apache.cassandra.service.MigrationManager.onAlive(MigrationManager.java:95)
at org.apache.cassandra.gms.Gossiper.markAlive(Gossiper.java:803)
at
org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:846)
at
org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:931)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:50)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)
Exception in thread "GossipStage:1" java.lang.NullPointerException
at
org.apache.cassandra.service.MigrationManager.maybeScheduleSchemaPull(MigrationManager.java:113)
at
org.apache.cassandra.service.MigrationManager.onAlive(MigrationManager.java:95)
at org.apache.cassandra.gms.Gossiper.markAlive(Gossiper.java:803)
at
org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:846)
at
org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:931)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:50)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)
{/code}
I've tested this both on the 1.2.8 tag and with 1.2 latest.
The line in question is
{code:java}
if (Schema.instance.getVersion().equals(theirVersion) ||
!shouldPullSchemaFrom(endpoint))
{/code}
Seems that {{Schema.instance.getVersion()}} returns null in the client_only
case. Adding a {{Schema.instance.getVersion() == null}} as another {{||}} in
the conditional appears to fix it, but I don't remember the codepaths well
enough to confidently say that that's the correct thing to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6089) client_only example does not work
[
https://issues.apache.org/jira/browse/CASSANDRA-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Panchenko updated CASSANDRA-6089:
-
Description:
client_only example fails out of the box with:
{code}
13/09/24 11:44:53 INFO gms.Gossiper: Node /127.0.0.1 is now part of the cluster
13/09/24 11:44:53 INFO gms.Gossiper: InetAddress /127.0.0.1 is now UP
13/09/24 11:44:53 ERROR concurrent.DebuggableThreadPoolExecutor: Error in
ThreadPoolExecutor
java.lang.NullPointerException
at
org.apache.cassandra.service.MigrationManager.maybeScheduleSchemaPull(MigrationManager.java:113)
at
org.apache.cassandra.service.MigrationManager.onAlive(MigrationManager.java:95)
at org.apache.cassandra.gms.Gossiper.markAlive(Gossiper.java:803)
at
org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:846)
at
org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:931)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:50)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)
Exception in thread "GossipStage:1" java.lang.NullPointerException
at
org.apache.cassandra.service.MigrationManager.maybeScheduleSchemaPull(MigrationManager.java:113)
at
org.apache.cassandra.service.MigrationManager.onAlive(MigrationManager.java:95)
at org.apache.cassandra.gms.Gossiper.markAlive(Gossiper.java:803)
at
org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:846)
at
org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:931)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:50)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)
{code}
I've tested this both on the 1.2.8 tag and with 1.2 latest.
The line in question is
{code:java}
if (Schema.instance.getVersion().equals(theirVersion) ||
!shouldPullSchemaFrom(endpoint))
{code}
Seems that {{Schema.instance.getVersion()}} returns null in the client_only
case. Adding a {{Schema.instance.getVersion() == null}} as another {{||}} in
the conditional appears to fix it, but I don't remember the codepaths well
enough to confidently say that that's the correct thing to do.
was:
client_only example fails out of the box with:
{code}
13/09/24 11:44:53 INFO gms.Gossiper: Node /127.0.0.1 is now part of the cluster
13/09/24 11:44:53 INFO gms.Gossiper: InetAddress /127.0.0.1 is now UP
13/09/24 11:44:53 ERROR concurrent.DebuggableThreadPoolExecutor: Error in
ThreadPoolExecutor
java.lang.NullPointerException
at
org.apache.cassandra.service.MigrationManager.maybeScheduleSchemaPull(MigrationManager.java:113)
at
org.apache.cassandra.service.MigrationManager.onAlive(MigrationManager.java:95)
at org.apache.cassandra.gms.Gossiper.markAlive(Gossiper.java:803)
at
org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:846)
at
org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:931)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:50)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)
Exception in thread "GossipStage:1" java.lang.NullPointerException
at
org.apache.cassandra.service.MigrationManager.maybeScheduleSchemaPull(MigrationManager.java:113)
at
org.apache.cassandra.service.MigrationManager.onAlive(MigrationManager.java:95)
at org.apache.cassandra.gms.Gossiper.markAlive(Gossiper.java:803)
at
org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:846)
at
org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:931)
at
org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:50)
at
org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:56)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:9
[jira] [Commented] (CASSANDRA-6079) Memtables flush is delayed when having a lot of batchlog activity, making node OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776692#comment-13776692 ] Jonathan Ellis commented on CASSANDRA-6079: --- bq. as soon as BM writes a hint(s) for (all of) failed replica(s), BM has nothing to do with batchlog record, so no all partitions scanning neccessary You are right. Carry on! > Memtables flush is delayed when having a lot of batchlog activity, making > node OOM > -- > > Key: CASSANDRA-6079 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6079 > Project: Cassandra > Issue Type: Bug >Reporter: Oleg Anastasyev >Assignee: Oleg Anastasyev >Priority: Minor > Fix For: 1.2.11, 2.0.2 > > Attachments: NoWaitBatchlogCompaction.diff > > > Both MeteredFlusher and BatchlogManager share the same OptionalTasks thread. > So, when batchlog manager processes its tasks no flushes can occur. Even > more, batchlog manager waits for batchlog CF compaction to finish. > On a lot of batchlog activity this prevents memtables from flush for a long > time, making the node OOM. > Fixed this by moving batchlog to its own thread and not waiting for batchlog > compaction to finish. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776714#comment-13776714 ] Cyril Scetbon commented on CASSANDRA-6084: -- I confirm that I can't reproduce the issue without vnodes. So, with vnodes it works sporadically whereas it always work without. Can you tell me if when you'll work on the vnode support ? in a few days ? a few weeks ? a few hours :) Thanks Alex > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-6090) init.d script not working under Ubuntu
Laurent Raufaste created CASSANDRA-6090: --- Summary: init.d script not working under Ubuntu Key: CASSANDRA-6090 URL: https://issues.apache.org/jira/browse/CASSANDRA-6090 Project: Cassandra Issue Type: Bug Environment: Ubuntu 12.04.2 LTS x64 Reporter: Laurent Raufaste Priority: Minor Fix For: 2.0.1 When installing the Cassandra package on Ubuntu, it starts up automatically without writing the PID file. It renders the init.d script useless as it can't status or stop cassandra. I submitted a PR on github to fix this: https://github.com/apache/cassandra/pull/21 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-6090) init.d script not working under Ubuntu
[ https://issues.apache.org/jira/browse/CASSANDRA-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Raufaste updated CASSANDRA-6090: Component/s: Packaging > init.d script not working under Ubuntu > -- > > Key: CASSANDRA-6090 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6090 > Project: Cassandra > Issue Type: Bug > Components: Packaging > Environment: Ubuntu 12.04.2 LTS x64 >Reporter: Laurent Raufaste >Priority: Minor > Fix For: 2.0.1 > > > When installing the Cassandra package on Ubuntu, it starts up automatically > without writing the PID file. > It renders the init.d script useless as it can't status or stop cassandra. > I submitted a PR on github to fix this: > https://github.com/apache/cassandra/pull/21 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776741#comment-13776741 ] Alex Liu commented on CASSANDRA-6084: - It may takes a few of weeks. I had been investigated it a few months back, and we decide not to support it in DSE. It looks like we should address it now. Basic idea is to combine a few vnode splits into a sudo big split, so it works like without vnodes. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-6091) Better Vnode support in hadoop/pig
Alex Liu created CASSANDRA-6091: --- Summary: Better Vnode support in hadoop/pig Key: CASSANDRA-6091 URL: https://issues.apache.org/jira/browse/CASSANDRA-6091 Project: Cassandra Issue Type: Bug Components: Hadoop Reporter: Alex Liu Assignee: Alex Liu CASSANDRA-6084 shows there are some issues during running hadoop/pig job if vnodes are enable. Also the hadoop performance of vnode enabled nodes are bad for there are so many splits. The idea is to combine vnode splits into a big sudo splits so it work like vnode is disable for hadoop/pig job -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776748#comment-13776748 ] Alex Liu commented on CASSANDRA-6084: - CASSANDRA-6091 is opened to better support vnode for hadoop/pig jobs. I am close this ticket. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776748#comment-13776748 ] Alex Liu edited comment on CASSANDRA-6084 at 9/24/13 9:09 PM: -- CASSANDRA-6091 is opened to better support vnode for hadoop/pig jobs. I close this ticket. was (Author: alexliu68): CASSANDRA-6091 is opened to better support vnode for hadoop/pig jobs. I am close this ticket. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Liu resolved CASSANDRA-6084. - Resolution: Won't Fix > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776753#comment-13776753 ] Jonathan Ellis commented on CASSANDRA-6084: --- There's nothing in the split code that *shouldn't* work with vnodes, so I suspect that there's a bug that affects both and is just 256 or so times more likely to manifest with vnodes. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-6084) java.io.IOException: Could not get input splits
[ https://issues.apache.org/jira/browse/CASSANDRA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776741#comment-13776741 ] Alex Liu edited comment on CASSANDRA-6084 at 9/24/13 9:11 PM: -- It may take a few of weeks. I had been investigated it a few months back, and we decide not to support it in DSE. It looks like we should address it now. Basic idea is to combine a few vnode splits into a sudo big split, so it works like without vnodes. was (Author: alexliu68): It may takes a few of weeks. I had been investigated it a few months back, and we decide not to support it in DSE. It looks like we should address it now. Basic idea is to combine a few vnode splits into a sudo big split, so it works like without vnodes. > java.io.IOException: Could not get input splits > --- > > Key: CASSANDRA-6084 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6084 > Project: Cassandra > Issue Type: Bug > Components: Hadoop > Environment: Osx 10.8.5 > Java 1.7 > Cassandra 1.2.10 > Pig 0.9.2/0.11.1 >Reporter: Cyril Scetbon >Assignee: Alex Liu > > see http://www.mail-archive.com/user@cassandra.apache.org/msg32414.html > I've noticed that if I restart Cassandra I get more errors for the first > minutes, although it's accessible through cqlsh without issue. > I have tested on a 1-node (Osx Laptop) and 4-nodes (Ubuntu servers) and got > the same error. I tried with version 1.2.6, 1.2.8, 1.2.9, 1.2.10 without > success -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
