[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)
[
https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724871#comment-14724871
]
Stefania commented on CASSANDRA-8630:
-
Here is a cperf result:
http://cstar.datastax.com/tests/id/deb052ba-5068-11e5-8248-42010af0688f
I compared 3.0 with the latest 8630 and the version of 8630 before the
suggestions (to rule out any impact from removing {{readBytes}}).
Do we have a performance regressuib or are they close enough?
> Faster sequential IO (on compaction, streaming, etc)
>
>
> Key: CASSANDRA-8630
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8630
> Project: Cassandra
> Issue Type: Improvement
> Components: Core, Tools
>Reporter: Oleg Anastasyev
>Assignee: Stefania
> Labels: compaction, performance
> Fix For: 3.x
>
> Attachments: 8630-FasterSequencialReadsAndWrites.txt, cpu_load.png,
> flight_recorder_001_files.tar.gz, flight_recorder_002_files.tar.gz,
> mmaped_uncomp_hotspot.png
>
>
> When node is doing a lot of sequencial IO (streaming, compacting, etc) a lot
> of CPU is lost in calls to RAF's int read() and DataOutputStream's write(int).
> This is because default implementations of readShort,readLong, etc as well as
> their matching write* are implemented with numerous calls of byte by byte
> read and write.
> This makes a lot of syscalls as well.
> A quick microbench shows than just reimplementation of these methods in
> either way gives 8x speed increase.
> A patch attached implements RandomAccessReader.read and
> SequencialWriter.write methods in more efficient way.
> I also eliminated some extra byte copies in CompositeType.split and
> ColumnNameHelper.maxComponents, which were on my profiler's hotspot method
> list during tests.
> A stress tests on my laptop show that this patch makes compaction 25-30%
> faster on uncompressed sstables and 15% faster for compressed ones.
> A deployment to production shows much less CPU load for compaction.
> (I attached a cpu load graph from one of our production, orange is niced CPU
> load - i.e. compaction; yellow is user - i.e. not compaction related tasks)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9451) Startup message response for unsupported protocol versions is incorrect
[
https://issues.apache.org/jira/browse/CASSANDRA-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724857#comment-14724857
]
Stefania commented on CASSANDRA-9451:
-
Hi [~zstlaw], sorry for the delay.
Could you attach {{cqlsh_to_2_1_server.sh}} and specify which 2.2.0 version you
are reproducing the problem with?
What happens when I increase the protocol version in cqlsh is that the python
driver automatically downgrades it and everything works fine, on the latest
branches for 2.1 or 2.2.
So I tried connecting from a 2.2 cqlsh to a running 2.1 node and got:
{code}
Connection error: ('Unable to connect to any servers', {'127.0.0.1':
ProtocolError("cql_version '3.3.0' is not supported by remote (w/ native
protocol). Supported versions: [u'3.2.0']",)})
{code}
However {{./cqlsh --cqlversion=3.2.0}} works fine as the driver once again
downgrades the protocol version.
The driver downgrades the version only when receiving
{{ProtocolVersionUnsupported}}, which leads me to believe this patch is working
as expected.
I wonder if the 2.2.0 version you used was older than 2.2.0 rc1 or if I am
doing something wrong to reproduce this?
> Startup message response for unsupported protocol versions is incorrect
> ---
>
> Key: CASSANDRA-9451
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9451
> Project: Cassandra
> Issue Type: Bug
> Environment: OS X 10.9
> Cassandra 2.1.5
>Reporter: Jorge Bay
>Assignee: Stefania
> Labels: client-impacting
> Fix For: 2.1.6, 2.2.0 rc1
>
> Attachments: 9451.txt
>
>
> The response to a STARTUP request with protocol v4 on a C* 2.1 host is an
> error with an incorrect error code (0).
> Instead of the error code being "Protocol error" ({{0x000A}}) it has error
> code 0 and message (wrapped by netty):
> {{"io.netty.handler.codec.DecoderException:
> org.apache.cassandra.transport.ProtocolException: Invalid or unsupported
> protocol version: 4"}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-6819) The command "nodetool setcompactionthroughput" sometimes takes a long time to take effect
[ https://issues.apache.org/jira/browse/CASSANDRA-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sankalp kohli resolved CASSANDRA-6819. -- Resolution: Duplicate > The command "nodetool setcompactionthroughput" sometimes takes a long time to > take effect > - > > Key: CASSANDRA-6819 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6819 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Steven Lowenthal > Fix For: 3.x > > > It's often necessary to throttle a large compaction. When the nodetool > setcompactionthroughput command is issued, the setting doesn't seem to take > hold until another compaction starts, which may be some time on a bungled > node. This command should take hold immediately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10222) Periodically attempt to delete failed snapshot deletions on Windows
[
https://issues.apache.org/jira/browse/CASSANDRA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724729#comment-14724729
]
Stefania commented on CASSANDRA-10222:
--
Code review:
* The {{SnapshotDeletingTask}} constructor assumes that the delete snapshot
task has failed but {{Directories.clearSnapshot()}} doesn't attempt to delete
it. It simply creates {{SnapshotDeletingTask}} and calls {{run}}. Perhaps you
changed approach and forgot to adjust the constructor or vice-versa?
* The class name in the logger for {{SnapshotDeletingTask}} is still
{{SSTableDeletingTask}}.
Notes:
* {{SSTableDeletingTask}} has been removed in 3.0, it's equivalent is
{{TransactionLog.SSTableTidier}}. I've put more details on CASSANDRA-8271.
bq. we could be more aggressive and call
SnapshotDeletingTask.rescheduleFailedTasks() after each successful
SSTableDeletingTask.run() to capture sstable deletions that never trigger the
failed path rather than relying on a GC to hit
Perhaps we could schedule only the failed snapshot deletions where the snapshot
parent directory is the same as the sstable directory?
> Periodically attempt to delete failed snapshot deletions on Windows
> ---
>
> Key: CASSANDRA-10222
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10222
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Joshua McKenzie
>Assignee: Joshua McKenzie
> Labels: Windows
> Fix For: 2.2.2
>
>
> The changes in CASSANDRA-9658 leave us in a position where a node on Windows
> will have to be restarted to clear out snapshots that cannot be deleted at
> request time due to sstables still being mapped, thus preventing deletions of
> hard links. A simple periodic task to categorize failed snapshot deletions
> and retry them would help prevent node disk utilization from growing
> unbounded by snapshots as compaction will eventually make these snapshot
> files deletable.
> Given that hard links to files in NTFS don't take up any extra space on disk
> so long as the original file still exists, the only limitation for users from
> this approach will be the inability to 'move' a snapshot file to another
> drive share. They will be copyable, however, so it's a minor platform
> difference.
> This goes directly against the goals of CASSANDRA-8271 and will likely be
> built on top of that code. Until such time as we get buffered performance
> in-line with memory-mapped, this is an interim necessity for production
> roll-outs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8271) Remove SSTableDeletingTask
[
https://issues.apache.org/jira/browse/CASSANDRA-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724715#comment-14724715
]
Stefania commented on CASSANDRA-8271:
-
CASSANDRA-7066 has replaced {{SSTableDeletingTask}} with
{{TransactionLog.SSTableTidier}}. In addition to performing the tasks of
{{SSTableDeletingTask}}, it keeps a reference to the transaction and it ensures
its log file is only removed after all sstable files are already removed.
> Remove SSTableDeletingTask
> --
>
> Key: CASSANDRA-8271
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8271
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Joshua McKenzie
>Assignee: Joshua McKenzie
>Priority: Minor
> Fix For: 3.x
>
>
> With CASSANDRA-4050 and CASSANDRA-6993, our out-of-order deletion problems
> w/regards to Windows are resolved and the only outstanding reason to have
> SSTableDeletingTask would be for support of non-sun VM's w/regards to mmap'ed
> files. As this is no longer a big concern in the Cassandra ecosystem
> (non-sun VM's), we should remove SSTableDeletingTask.
> The one caveat is that if we want to revisit mmap'ed I/O on Windows in the
> future we may need to re-use this type of "delayed deletion" approach due to
> Windows not allowing deletion of hard linked files w/memory-mapped segments
> in the original file, but CASSANDRA-5863 would obviate that concern.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)
[
https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724615#comment-14724615
]
Stefania commented on CASSANDRA-8630:
-
Thanks [~benedict] and [~JoshuaMcKenzie].
bq. Removed the readBytes method entirely
Are you sure? This method was introduced by CASSANDRA-1714, titled _zero-copy
reads_. It copies BBs via {{FastByteOperations}} rather than reading into a
buffer byte by byte. Bear in mind that {{ByteBufferUtil.read()}} is one of the
most used read methods according to flight recorder.
bq. Removed the (as commented in TODO) unnecessary
BufferedSegmentedFile.createReader
Thanks, I had totally forgot to remove this.
bq. MappedRegions.close now always calls channel.close, and returns any error
thrown by it
Thanks for spotting it!
The remaining points are good. The new {{Throwables.perform}} API is really
neat.
I've pushed a rebased version to Jenkins and I've asked on IRC to set-up
Windows jobs for this branch. I've also launched a [cperf
job|http://cstar.datastax.com/tests/id/35dbcc0e-5050-11e5-b3f6-42010af0688f].
I'll post the results once they are available.
> Faster sequential IO (on compaction, streaming, etc)
>
>
> Key: CASSANDRA-8630
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8630
> Project: Cassandra
> Issue Type: Improvement
> Components: Core, Tools
>Reporter: Oleg Anastasyev
>Assignee: Stefania
> Labels: compaction, performance
> Fix For: 3.x
>
> Attachments: 8630-FasterSequencialReadsAndWrites.txt, cpu_load.png,
> flight_recorder_001_files.tar.gz, flight_recorder_002_files.tar.gz,
> mmaped_uncomp_hotspot.png
>
>
> When node is doing a lot of sequencial IO (streaming, compacting, etc) a lot
> of CPU is lost in calls to RAF's int read() and DataOutputStream's write(int).
> This is because default implementations of readShort,readLong, etc as well as
> their matching write* are implemented with numerous calls of byte by byte
> read and write.
> This makes a lot of syscalls as well.
> A quick microbench shows than just reimplementation of these methods in
> either way gives 8x speed increase.
> A patch attached implements RandomAccessReader.read and
> SequencialWriter.write methods in more efficient way.
> I also eliminated some extra byte copies in CompositeType.split and
> ColumnNameHelper.maxComponents, which were on my profiler's hotspot method
> list during tests.
> A stress tests on my laptop show that this patch makes compaction 25-30%
> faster on uncompressed sstables and 15% faster for compressed ones.
> A deployment to production shows much less CPU load for compaction.
> (I attached a cpu load graph from one of our production, orange is niced CPU
> load - i.e. compaction; yellow is user - i.e. not compaction related tasks)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9689) keyspace does not show in describe list, if create query times out
[
https://issues.apache.org/jira/browse/CASSANDRA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724314#comment-14724314
]
Paulo Motta commented on CASSANDRA-9689:
Attached 2.1 and 2.2+ patches..
Based on Tyler's suggestion the solution checks if there's a schema mismatch
after a {{OperationTimedOut}} exception and in positive case, the schema
metadata is reloaded with
{{cluster.refresh_schema_metadata(max_schema_agreement_wait=0)}}, which was
implemented on
[PYTHON-205|https://datastax-oss.atlassian.net/browse/PYTHON-205] and
effectively bypasses schema agreement during metadata refresh. This guarantees
that the subsequent operation will (which can be a {{describe keyspaces}} or
{{describe tables}}) will have the most recent schema version. It's also
printed a warning about the schema disagreement.
I also replaced the workaround for CASSANDRA-8512 (created before
[PYTHON-205|https://datastax-oss.atlassian.net/browse/PYTHON-205] was
implemented) by using the new python driver`s method
{{cluster.refresh_schema_metadata(max_schema_agreement_wait=0)}}.
I created a [cassandra dtest
PR|https://github.com/riptano/cassandra-dtest/pull/522] with a simple test to
validate the scenario of this ticket and the new metadata refresh behavior.
Tests:
* [2.1
dtests|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-2.1-dtest/]
* [2.1
testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-2.1-testall/]
* [2.2
dtests|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-2.2-dtest/]
* [2.2
testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-2.2-testall/]
* [3.0
dtests|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-3.0-dtest/]
* [3.0
testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-3.0-testall/]
* [trunk
dtests|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-trunk-dtest/]
* [trunk
testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-9689-trunk-testall/]
Would you mind reviewing [~blerer]?
> keyspace does not show in describe list, if create query times out
> --
>
> Key: CASSANDRA-9689
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9689
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Roopesh
>Assignee: Paulo Motta
> Labels: cqlsh
> Fix For: 2.1.x
>
>
> Here is the snapshot of the overall issue :
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm create 'demo2' -v binary:2.1.7
> -n 3 -s -d
> Current cluster is now: demo2
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm list
> demo_1node
> *demo2
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm status
> Cluster: 'demo2'
>
> node1: UP
> node3: UP
> node2: UP
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm node2 nodetool version
> ReleaseVersion: 2.1.7
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm node2 stop
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm status
> Cluster: 'demo2'
>
> node1: UP
> node3: UP
> node2: DOWN
> whiterabbit@whiterabbit:~/cassandra/bin$ ccm node1 cqlsh
> Connected to demo2 at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 2.1.7 | CQL spec 3.2.0 | Native protocol v3]
> Use HELP for help.
> cqlsh> describe keyspaces;
> system_traces system
> cqlsh> create keyspace training with
> replication={'class':'SimpleStrategy','replication_factor':1};
> OperationTimedOut: errors={}, last_host=127.0.0.1
> cqlsh> create keyspace training with
> replication={'class':'SimpleStrategy','replication_factor':1};
> AlreadyExists: Keyspace 'training' already exists
> cqlsh> describe keyspaces;
> system_traces system
> cqlsh>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9664) Allow MV's select statements to be more complex
[
https://issues.apache.org/jira/browse/CASSANDRA-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724150#comment-14724150
]
Tyler Hobbs commented on CASSANDRA-9664:
I've discovered one limitation of this: I don't think we will be able to
support filtering on regular columns in the base table due to timestamp issues.
Suppose we have a base table like this:
{noformat}
CREATE TABLE base (a int, b int, c int, d int, PRIMARY KEY (a, b));
{noformat}
and a view:
{noformat}
CREATE MATERIALIZED VIEW view AS
SELECT * FROM base
WHERE a IS NOT NULL
AND b IS NOT NULL
AND c = 1
PRIMARY KEY (a, b)
{noformat}
The view should only contain rows where {{c = 1}}.
Now, suppose we do the following:
{noformat}
INSERT INTO base (a, b, c, d) VALUES (0, 0, 1, 0) USING TIMESTAMP 0;
UPDATE base SET c = 1 USING TIMESTAMP 2;
UPDATE base SET c = 0 USING TIMESTAMP 3; -- view row should be deleted w/
timestamp 3
UPDATE base SET c = 1 USING TIMESTAMP 4;
{noformat}
The third update results in a tombstone being written to the view row with a
timestamp of 3 because {{c}} no longer matches our SELECT statement. The
problem comes at the final update: now that {{c}} matches the SELECT again, we
should reinsert a row into the view. For the reinsertion, we can use timestamp
4 for the row marker and {{c}}'s cell, but what about {{d}}'s cell? If we use
its timestamp from the base row (0), the view tombstone supercedes it, leaving
{{d}} as null. If we use timestamp 4 for {{d}}'s cell, we may accidentally
ignore updates to {{d}}. For example, this would update {{d}} in the base
table but not the view:
{noformat}
UPDATE base SET d = 1 WHERE a = 0 AND b = 0 USING TIMESTAMP 1;
{noformat}
Note that the timestamp of 1 is higher than {{d}}'s timestamp in the base table
(0) but lower than {{d}}'s timestamp in the view (4).
In light of this, I suggest that for the first iteration of this we only allow
the SELECT statement to restrict PK columns.
> Allow MV's select statements to be more complex
> ---
>
> Key: CASSANDRA-9664
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9664
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Carl Yeksigian
> Fix For: 3.x
>
>
> [Materialized Views|https://issues.apache.org/jira/browse/CASSANDRA-6477] add
> support for a syntax which includes a {{SELECT}} statement, but only allows
> selection of direct columns, and does not allow any filtering to take place.
> We should add support to the MV {{SELECT}} statement to bring better parity
> with the normal CQL {{SELECT}} statement, specifically simple functions in
> the selected columns, as well as specifying a {{WHERE}} clause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10234) Add nodetool gettraceprobability command
[ https://issues.apache.org/jira/browse/CASSANDRA-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-10234: - Fix Version/s: (was: 2.1.10) > Add nodetool gettraceprobability command > > > Key: CASSANDRA-10234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10234 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: sequoyha pelletier >Assignee: sequoyha pelletier >Priority: Trivial > Fix For: 2.2.1, 3.0 beta 2 > > Attachments: trunk-10234.txt > > > nodetool has a settraceprobability command but there is no way to get the > value from the nodetool command. Attaching patch that adds the > gettraceprobability command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[01/10] cassandra git commit: Revert "Add nodetool gettraceprobability command" from 2.1
Repository: cassandra
Updated Branches:
refs/heads/cassandra-2.1 57d48a9ba -> 542bb1fa4
refs/heads/cassandra-2.2 8c43b8c3f -> c2b6dd450
refs/heads/cassandra-3.0 f3c5faba0 -> 627e939be
refs/heads/trunk c5632c400 -> 8302ef7a8
Revert "Add nodetool gettraceprobability command" from 2.1
This reverts commit 57d48a9ba074810ebb25324d3bfc4db086a1c44d.
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/542bb1fa
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/542bb1fa
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/542bb1fa
Branch: refs/heads/cassandra-2.1
Commit: 542bb1fa4741aaad62ce9e239fc4220bdc893ee0
Parents: 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 17:10:21 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 17:10:21 2015 -0500
--
CHANGES.txt | 1 -
.../org/apache/cassandra/tools/NodeProbe.java | 2 --
.../org/apache/cassandra/tools/NodeTool.java| 1 -
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index d57eaf7..7841f9b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,7 +2,6 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
- * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index 51b1c93..caa12c3 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,8 +971,6 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
-public double getTraceProbability() {return ssProxy.getTraceProbability();}
-
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index cc6e6d4..8e88f45 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,7 +138,6 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
-GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
deleted file mode 100644
index 3940790..000
--- a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.cassandra.tools.nodetool;
-
-import io.airlift.command.Command;
-
-import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
-
-@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
-public class GetTraceProbabil
[05/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c2b6dd45 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c2b6dd45 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c2b6dd45 Branch: refs/heads/cassandra-3.0 Commit: c2b6dd4503dc8f11a98fbb2c732b21179997f894 Parents: 8c43b8c 542bb1f Author: Brandon Williams Authored: Mon Aug 31 17:10:38 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 17:10:38 2015 -0500 -- --
[08/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/627e939b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/627e939b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/627e939b Branch: refs/heads/cassandra-3.0 Commit: 627e939be29c969c51cf7f23e904dbece4d1ff97 Parents: f3c5fab c2b6dd4 Author: Brandon Williams Authored: Mon Aug 31 17:10:50 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 17:10:50 2015 -0500 -- --
[04/10] cassandra git commit: Revert "Add nodetool gettraceprobability command" from 2.1
Revert "Add nodetool gettraceprobability command" from 2.1
This reverts commit 57d48a9ba074810ebb25324d3bfc4db086a1c44d.
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/542bb1fa
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/542bb1fa
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/542bb1fa
Branch: refs/heads/trunk
Commit: 542bb1fa4741aaad62ce9e239fc4220bdc893ee0
Parents: 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 17:10:21 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 17:10:21 2015 -0500
--
CHANGES.txt | 1 -
.../org/apache/cassandra/tools/NodeProbe.java | 2 --
.../org/apache/cassandra/tools/NodeTool.java| 1 -
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index d57eaf7..7841f9b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,7 +2,6 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
- * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index 51b1c93..caa12c3 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,8 +971,6 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
-public double getTraceProbability() {return ssProxy.getTraceProbability();}
-
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index cc6e6d4..8e88f45 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,7 +138,6 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
-GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
deleted file mode 100644
index 3940790..000
--- a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.cassandra.tools.nodetool;
-
-import io.airlift.command.Command;
-
-import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
-
-@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
-public class GetTraceProbability extends NodeToolCmd
-{
-@Override
-public void execute(NodeProbe probe)
-{
-System.out.println("Current trace probability: " +
probe.getTraceProbability());
-}
-}
[09/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/627e939b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/627e939b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/627e939b Branch: refs/heads/trunk Commit: 627e939be29c969c51cf7f23e904dbece4d1ff97 Parents: f3c5fab c2b6dd4 Author: Brandon Williams Authored: Mon Aug 31 17:10:50 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 17:10:50 2015 -0500 -- --
[02/10] cassandra git commit: Revert "Add nodetool gettraceprobability command" from 2.1
Revert "Add nodetool gettraceprobability command" from 2.1
This reverts commit 57d48a9ba074810ebb25324d3bfc4db086a1c44d.
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/542bb1fa
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/542bb1fa
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/542bb1fa
Branch: refs/heads/cassandra-2.2
Commit: 542bb1fa4741aaad62ce9e239fc4220bdc893ee0
Parents: 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 17:10:21 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 17:10:21 2015 -0500
--
CHANGES.txt | 1 -
.../org/apache/cassandra/tools/NodeProbe.java | 2 --
.../org/apache/cassandra/tools/NodeTool.java| 1 -
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index d57eaf7..7841f9b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,7 +2,6 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
- * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index 51b1c93..caa12c3 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,8 +971,6 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
-public double getTraceProbability() {return ssProxy.getTraceProbability();}
-
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index cc6e6d4..8e88f45 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,7 +138,6 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
-GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
deleted file mode 100644
index 3940790..000
--- a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.cassandra.tools.nodetool;
-
-import io.airlift.command.Command;
-
-import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
-
-@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
-public class GetTraceProbability extends NodeToolCmd
-{
-@Override
-public void execute(NodeProbe probe)
-{
-System.out.println("Current trace probability: " +
probe.getTraceProbability());
-}
-}
[07/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c2b6dd45 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c2b6dd45 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c2b6dd45 Branch: refs/heads/trunk Commit: c2b6dd4503dc8f11a98fbb2c732b21179997f894 Parents: 8c43b8c 542bb1f Author: Brandon Williams Authored: Mon Aug 31 17:10:38 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 17:10:38 2015 -0500 -- --
[10/10] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8302ef7a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8302ef7a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8302ef7a Branch: refs/heads/trunk Commit: 8302ef7a856e8bb18986d226596b23daf3020ed0 Parents: c5632c4 627e939 Author: Brandon Williams Authored: Mon Aug 31 17:10:58 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 17:10:58 2015 -0500 -- --
[06/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c2b6dd45 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c2b6dd45 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c2b6dd45 Branch: refs/heads/cassandra-2.2 Commit: c2b6dd4503dc8f11a98fbb2c732b21179997f894 Parents: 8c43b8c 542bb1f Author: Brandon Williams Authored: Mon Aug 31 17:10:38 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 17:10:38 2015 -0500 -- --
[03/10] cassandra git commit: Revert "Add nodetool gettraceprobability command" from 2.1
Revert "Add nodetool gettraceprobability command" from 2.1
This reverts commit 57d48a9ba074810ebb25324d3bfc4db086a1c44d.
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/542bb1fa
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/542bb1fa
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/542bb1fa
Branch: refs/heads/cassandra-3.0
Commit: 542bb1fa4741aaad62ce9e239fc4220bdc893ee0
Parents: 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 17:10:21 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 17:10:21 2015 -0500
--
CHANGES.txt | 1 -
.../org/apache/cassandra/tools/NodeProbe.java | 2 --
.../org/apache/cassandra/tools/NodeTool.java| 1 -
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index d57eaf7..7841f9b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,7 +2,6 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
- * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index 51b1c93..caa12c3 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,8 +971,6 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
-public double getTraceProbability() {return ssProxy.getTraceProbability();}
-
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index cc6e6d4..8e88f45 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,7 +138,6 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
-GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/542bb1fa/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
deleted file mode 100644
index 3940790..000
--- a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.cassandra.tools.nodetool;
-
-import io.airlift.command.Command;
-
-import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
-
-@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
-public class GetTraceProbability extends NodeToolCmd
-{
-@Override
-public void execute(NodeProbe probe)
-{
-System.out.println("Current trace probability: " +
probe.getTraceProbability());
-}
-}
[jira] [Updated] (CASSANDRA-10234) Add nodetool gettraceprobability command
[ https://issues.apache.org/jira/browse/CASSANDRA-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-10234: - Labels: (was: newbie patch) > Add nodetool gettraceprobability command > > > Key: CASSANDRA-10234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10234 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: sequoyha pelletier >Assignee: sequoyha pelletier >Priority: Trivial > Fix For: 2.2.1, 3.0 beta 2, 2.1.10 > > Attachments: trunk-10234.txt > > > nodetool has a settraceprobability command but there is no way to get the > value from the nodetool command. Attaching patch that adds the > gettraceprobability command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CASSANDRA-10234) Add nodetool gettraceprobability command
[ https://issues.apache.org/jira/browse/CASSANDRA-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sequoyha pelletier reassigned CASSANDRA-10234: -- Assignee: sequoyha pelletier > Add nodetool gettraceprobability command > > > Key: CASSANDRA-10234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10234 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: sequoyha pelletier >Assignee: sequoyha pelletier >Priority: Trivial > Labels: newbie, patch > Fix For: 3.x > > Attachments: trunk-10234.txt > > > nodetool has a settraceprobability command but there is no way to get the > value from the nodetool command. Attaching patch that adds the > gettraceprobability command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[03/10] cassandra git commit: Add nodetool gettraceprobability command
Add nodetool gettraceprobability command
Patch by Sequoyha Pelletier, reviewed by brandonwilliams for
CASSANDRA-10234
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/57d48a9b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/57d48a9b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/57d48a9b
Branch: refs/heads/cassandra-3.0
Commit: 57d48a9ba074810ebb25324d3bfc4db086a1c44d
Parents: 8a8a5a4
Author: Brandon Williams
Authored: Mon Aug 31 16:40:00 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:41:34 2015 -0500
--
CHANGES.txt | 1 +
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 7841f9b..d57eaf7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index caa12c3..51b1c93 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,6 +971,8 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
+public double getTraceProbability() {return ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index 8e88f45..cc6e6d4 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,6 +138,7 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
+GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
new file mode 100644
index 000..3940790
--- /dev/null
+++ b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.tools.nodetool;
+
+import io.airlift.command.Command;
+
+import org.apache.cassandra.tools.NodeProbe;
+import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+
+@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
+public class GetTraceProbability extends NodeToolCmd
+{
+@Override
+public void execute(NodeProbe probe)
+{
+System.out.println("Current trace probability: " +
probe.getTraceProbability());
+}
+}
[07/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2
Conflicts:
CHANGES.txt
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8c43b8c3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8c43b8c3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8c43b8c3
Branch: refs/heads/trunk
Commit: 8c43b8c3feb507ce43254a620060467087c7f12b
Parents: 0d2f403 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 16:42:08 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:42:08 2015 -0500
--
CHANGES.txt | 3 ++
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 39 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/CHANGES.txt
--
diff --cc CHANGES.txt
index 37244c9,d57eaf7..d9f8a50
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,29 -1,11 +1,32 @@@
-2.1.10
+2.2.2
+ * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks
+ (CASSANDRA-10199)
+Merged from 2.1:
* Only check KeyCache when it is enabled
+ * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
+ * (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
-2.1.9
+2.2.1
+ * Fix race during construction of commit log (CASSANDRA-10049)
+ * Fix LeveledCompactionStrategyTest (CASSANDRA-9757)
+ * Fix broken UnbufferedDataOutputStreamPlus.writeUTF (CASSANDRA-10203)
+ * (cqlsh) add CLEAR command (CASSANDRA-10086)
+ * Support string literals as Role names for compatibility (CASSANDRA-10135)
+ * Allow count(*) and count(1) to be use as normal aggregation
(CASSANDRA-10114)
+ * An NPE is thrown if the column name is unknown for an IN relation
(CASSANDRA-10043)
+ * Apply commit_failure_policy to more errors on startup (CASSANDRA-9749)
+ * Fix histogram overflow exception (CASSANDRA-9973)
+ * Route gossip messages over dedicated socket (CASSANDRA-9237)
+ * Add checksum to saved cache files (CASSANDRA-9265)
+ * Log warning when using an aggregate without partition key (CASSANDRA-9737)
+ * Avoid grouping sstables for anticompaction with DTCS (CASSANDRA-9900)
+ * UDF / UDA execution time in trace (CASSANDRA-9723)
+ * Fix broken internode SSL (CASSANDRA-9884)
+Merged from 2.1:
+ * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
+ * (cqlsh) update list of CQL keywords (CASSANDRA-9232)
* Avoid race condition during read repair (CASSANDRA-9460)
* (cqlsh) default load-from-file encoding to utf-8 (CASSANDRA-9898)
* Avoid returning Permission.NONE when failing to query users table
(CASSANDRA-10168)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --cc src/java/org/apache/cassandra/tools/NodeProbe.java
index 2b256bd,51b1c93..ebbef7d
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@@ -930,9 -971,11 +930,11 @@@ public class NodeProbe implements AutoC
return ssProxy.getStreamThroughputMbPerSec();
}
+ public double getTraceProbability() {return
ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
-return ssProxy.getExceptionCount();
+return (int)StorageMetrics.exceptions.getCount();
}
public Map getDroppedMessages()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/src/java/org/apache/cassandra/tools/NodeTool.java
--
[09/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Conflicts: CHANGES.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f3c5faba Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f3c5faba Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f3c5faba Branch: refs/heads/trunk Commit: f3c5faba0705e819bdc529f17bbbaca403116e85 Parents: 3bc585d 8c43b8c Author: Brandon Williams Authored: Mon Aug 31 16:43:09 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 16:43:09 2015 -0500 -- CHANGES.txt | 8 + .../org/apache/cassandra/tools/NodeProbe.java | 2 ++ .../org/apache/cassandra/tools/NodeTool.java| 1 + .../tools/nodetool/GetTraceProbability.java | 33 4 files changed, 44 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3c5faba/CHANGES.txt -- diff --cc CHANGES.txt index f69f09f,d9f8a50..08b7df0 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,18 -1,14 +1,26 @@@ -2.2.2 +3.0.0-beta2 + * Fix Materialized View builder when adding multiple MVs (CASSANDRA-10156) + * Choose better poolingOptions for protocol v4 in cassandra-stress (CASSANDRA-10182) + * Fix LWW bug affecting Materialized Views (CASSANDRA-10197) + * Ensures frozen sets and maps are always sorted (CASSANDRA-10162) + * Don't deadlock when flushing CFS backed custom indexes (CASSANDRA-10181) + * Fix double flushing of secondary index tables (CASSANDRA-10180) + * Fix incorrect handling of range tombstones in thrift (CASSANDRA-10046) + * Only use batchlog when paired materialized view replica is remote (CASSANDRA-10061) + * Reuse TemporalRow when updating multiple MaterializedViews (CASSANDRA-10060) + * Validate gc_grace_seconds for batchlog writes and MVs (CASSANDRA-9917) + * Fix sstablerepairedset (CASSANDRA-10132) +Merged from 2.2: * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks (CASSANDRA-10199) + Merged from 2.1: + * Only check KeyCache when it is enabled + * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611) + * (cqlsh) update list of CQL keywords (CASSANDRA-9232) + * Add nodetool gettraceprobability command (CASSANDRA-10234) + + + 2.2.1 * Fix race during construction of commit log (CASSANDRA-10049) * Fix LeveledCompactionStrategyTest (CASSANDRA-9757) * Fix broken UnbufferedDataOutputStreamPlus.writeUTF (CASSANDRA-10203) http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3c5faba/src/java/org/apache/cassandra/tools/NodeProbe.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3c5faba/src/java/org/apache/cassandra/tools/NodeTool.java --
[01/10] cassandra git commit: Add nodetool gettraceprobability command
Repository: cassandra
Updated Branches:
refs/heads/cassandra-2.1 8a8a5a428 -> 57d48a9ba
refs/heads/cassandra-2.2 0d2f4038f -> 8c43b8c3f
refs/heads/cassandra-3.0 3bc585d5d -> f3c5faba0
refs/heads/trunk 5d0c6ef77 -> c5632c400
Add nodetool gettraceprobability command
Patch by Sequoyha Pelletier, reviewed by brandonwilliams for
CASSANDRA-10234
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/57d48a9b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/57d48a9b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/57d48a9b
Branch: refs/heads/cassandra-2.1
Commit: 57d48a9ba074810ebb25324d3bfc4db086a1c44d
Parents: 8a8a5a4
Author: Brandon Williams
Authored: Mon Aug 31 16:40:00 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:41:34 2015 -0500
--
CHANGES.txt | 1 +
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 7841f9b..d57eaf7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index caa12c3..51b1c93 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,6 +971,8 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
+public double getTraceProbability() {return ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index 8e88f45..cc6e6d4 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,6 +138,7 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
+GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
new file mode 100644
index 000..3940790
--- /dev/null
+++ b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.tools.nodetool;
+
+import io.airlift.command.Command;
+
+import org.apache.cassandra.tools.NodeProbe;
+import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+
+@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
+public class GetTraceProbability ex
[04/10] cassandra git commit: Add nodetool gettraceprobability command
Add nodetool gettraceprobability command
Patch by Sequoyha Pelletier, reviewed by brandonwilliams for
CASSANDRA-10234
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/57d48a9b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/57d48a9b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/57d48a9b
Branch: refs/heads/trunk
Commit: 57d48a9ba074810ebb25324d3bfc4db086a1c44d
Parents: 8a8a5a4
Author: Brandon Williams
Authored: Mon Aug 31 16:40:00 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:41:34 2015 -0500
--
CHANGES.txt | 1 +
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 7841f9b..d57eaf7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index caa12c3..51b1c93 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,6 +971,8 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
+public double getTraceProbability() {return ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index 8e88f45..cc6e6d4 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,6 +138,7 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
+GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
new file mode 100644
index 000..3940790
--- /dev/null
+++ b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.tools.nodetool;
+
+import io.airlift.command.Command;
+
+import org.apache.cassandra.tools.NodeProbe;
+import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+
+@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
+public class GetTraceProbability extends NodeToolCmd
+{
+@Override
+public void execute(NodeProbe probe)
+{
+System.out.println("Current trace probability: " +
probe.getTraceProbability());
+}
+}
[05/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2
Conflicts:
CHANGES.txt
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8c43b8c3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8c43b8c3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8c43b8c3
Branch: refs/heads/cassandra-3.0
Commit: 8c43b8c3feb507ce43254a620060467087c7f12b
Parents: 0d2f403 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 16:42:08 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:42:08 2015 -0500
--
CHANGES.txt | 3 ++
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 39 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/CHANGES.txt
--
diff --cc CHANGES.txt
index 37244c9,d57eaf7..d9f8a50
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,29 -1,11 +1,32 @@@
-2.1.10
+2.2.2
+ * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks
+ (CASSANDRA-10199)
+Merged from 2.1:
* Only check KeyCache when it is enabled
+ * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
+ * (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
-2.1.9
+2.2.1
+ * Fix race during construction of commit log (CASSANDRA-10049)
+ * Fix LeveledCompactionStrategyTest (CASSANDRA-9757)
+ * Fix broken UnbufferedDataOutputStreamPlus.writeUTF (CASSANDRA-10203)
+ * (cqlsh) add CLEAR command (CASSANDRA-10086)
+ * Support string literals as Role names for compatibility (CASSANDRA-10135)
+ * Allow count(*) and count(1) to be use as normal aggregation
(CASSANDRA-10114)
+ * An NPE is thrown if the column name is unknown for an IN relation
(CASSANDRA-10043)
+ * Apply commit_failure_policy to more errors on startup (CASSANDRA-9749)
+ * Fix histogram overflow exception (CASSANDRA-9973)
+ * Route gossip messages over dedicated socket (CASSANDRA-9237)
+ * Add checksum to saved cache files (CASSANDRA-9265)
+ * Log warning when using an aggregate without partition key (CASSANDRA-9737)
+ * Avoid grouping sstables for anticompaction with DTCS (CASSANDRA-9900)
+ * UDF / UDA execution time in trace (CASSANDRA-9723)
+ * Fix broken internode SSL (CASSANDRA-9884)
+Merged from 2.1:
+ * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
+ * (cqlsh) update list of CQL keywords (CASSANDRA-9232)
* Avoid race condition during read repair (CASSANDRA-9460)
* (cqlsh) default load-from-file encoding to utf-8 (CASSANDRA-9898)
* Avoid returning Permission.NONE when failing to query users table
(CASSANDRA-10168)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --cc src/java/org/apache/cassandra/tools/NodeProbe.java
index 2b256bd,51b1c93..ebbef7d
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@@ -930,9 -971,11 +930,11 @@@ public class NodeProbe implements AutoC
return ssProxy.getStreamThroughputMbPerSec();
}
+ public double getTraceProbability() {return
ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
-return ssProxy.getExceptionCount();
+return (int)StorageMetrics.exceptions.getCount();
}
public Map getDroppedMessages()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/src/java/org/apache/cassandra/tools/NodeTool.java
--
[06/10] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2
Conflicts:
CHANGES.txt
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8c43b8c3
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8c43b8c3
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8c43b8c3
Branch: refs/heads/cassandra-2.2
Commit: 8c43b8c3feb507ce43254a620060467087c7f12b
Parents: 0d2f403 57d48a9
Author: Brandon Williams
Authored: Mon Aug 31 16:42:08 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:42:08 2015 -0500
--
CHANGES.txt | 3 ++
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 39 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/CHANGES.txt
--
diff --cc CHANGES.txt
index 37244c9,d57eaf7..d9f8a50
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,29 -1,11 +1,32 @@@
-2.1.10
+2.2.2
+ * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks
+ (CASSANDRA-10199)
+Merged from 2.1:
* Only check KeyCache when it is enabled
+ * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
+ * (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
-2.1.9
+2.2.1
+ * Fix race during construction of commit log (CASSANDRA-10049)
+ * Fix LeveledCompactionStrategyTest (CASSANDRA-9757)
+ * Fix broken UnbufferedDataOutputStreamPlus.writeUTF (CASSANDRA-10203)
+ * (cqlsh) add CLEAR command (CASSANDRA-10086)
+ * Support string literals as Role names for compatibility (CASSANDRA-10135)
+ * Allow count(*) and count(1) to be use as normal aggregation
(CASSANDRA-10114)
+ * An NPE is thrown if the column name is unknown for an IN relation
(CASSANDRA-10043)
+ * Apply commit_failure_policy to more errors on startup (CASSANDRA-9749)
+ * Fix histogram overflow exception (CASSANDRA-9973)
+ * Route gossip messages over dedicated socket (CASSANDRA-9237)
+ * Add checksum to saved cache files (CASSANDRA-9265)
+ * Log warning when using an aggregate without partition key (CASSANDRA-9737)
+ * Avoid grouping sstables for anticompaction with DTCS (CASSANDRA-9900)
+ * UDF / UDA execution time in trace (CASSANDRA-9723)
+ * Fix broken internode SSL (CASSANDRA-9884)
+Merged from 2.1:
+ * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
+ * (cqlsh) update list of CQL keywords (CASSANDRA-9232)
* Avoid race condition during read repair (CASSANDRA-9460)
* (cqlsh) default load-from-file encoding to utf-8 (CASSANDRA-9898)
* Avoid returning Permission.NONE when failing to query users table
(CASSANDRA-10168)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --cc src/java/org/apache/cassandra/tools/NodeProbe.java
index 2b256bd,51b1c93..ebbef7d
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@@ -930,9 -971,11 +930,11 @@@ public class NodeProbe implements AutoC
return ssProxy.getStreamThroughputMbPerSec();
}
+ public double getTraceProbability() {return
ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
-return ssProxy.getExceptionCount();
+return (int)StorageMetrics.exceptions.getCount();
}
public Map getDroppedMessages()
http://git-wip-us.apache.org/repos/asf/cassandra/blob/8c43b8c3/src/java/org/apache/cassandra/tools/NodeTool.java
--
[08/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Conflicts: CHANGES.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f3c5faba Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f3c5faba Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f3c5faba Branch: refs/heads/cassandra-3.0 Commit: f3c5faba0705e819bdc529f17bbbaca403116e85 Parents: 3bc585d 8c43b8c Author: Brandon Williams Authored: Mon Aug 31 16:43:09 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 16:43:09 2015 -0500 -- CHANGES.txt | 8 + .../org/apache/cassandra/tools/NodeProbe.java | 2 ++ .../org/apache/cassandra/tools/NodeTool.java| 1 + .../tools/nodetool/GetTraceProbability.java | 33 4 files changed, 44 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3c5faba/CHANGES.txt -- diff --cc CHANGES.txt index f69f09f,d9f8a50..08b7df0 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,18 -1,14 +1,26 @@@ -2.2.2 +3.0.0-beta2 + * Fix Materialized View builder when adding multiple MVs (CASSANDRA-10156) + * Choose better poolingOptions for protocol v4 in cassandra-stress (CASSANDRA-10182) + * Fix LWW bug affecting Materialized Views (CASSANDRA-10197) + * Ensures frozen sets and maps are always sorted (CASSANDRA-10162) + * Don't deadlock when flushing CFS backed custom indexes (CASSANDRA-10181) + * Fix double flushing of secondary index tables (CASSANDRA-10180) + * Fix incorrect handling of range tombstones in thrift (CASSANDRA-10046) + * Only use batchlog when paired materialized view replica is remote (CASSANDRA-10061) + * Reuse TemporalRow when updating multiple MaterializedViews (CASSANDRA-10060) + * Validate gc_grace_seconds for batchlog writes and MVs (CASSANDRA-9917) + * Fix sstablerepairedset (CASSANDRA-10132) +Merged from 2.2: * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks (CASSANDRA-10199) + Merged from 2.1: + * Only check KeyCache when it is enabled + * Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611) + * (cqlsh) update list of CQL keywords (CASSANDRA-9232) + * Add nodetool gettraceprobability command (CASSANDRA-10234) + + + 2.2.1 * Fix race during construction of commit log (CASSANDRA-10049) * Fix LeveledCompactionStrategyTest (CASSANDRA-9757) * Fix broken UnbufferedDataOutputStreamPlus.writeUTF (CASSANDRA-10203) http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3c5faba/src/java/org/apache/cassandra/tools/NodeProbe.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/f3c5faba/src/java/org/apache/cassandra/tools/NodeTool.java --
[10/10] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c5632c40 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c5632c40 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c5632c40 Branch: refs/heads/trunk Commit: c5632c40077dcdf34e5c33e1687a1eff3bd9c898 Parents: 5d0c6ef f3c5fab Author: Brandon Williams Authored: Mon Aug 31 16:43:19 2015 -0500 Committer: Brandon Williams Committed: Mon Aug 31 16:43:19 2015 -0500 -- CHANGES.txt | 8 + .../org/apache/cassandra/tools/NodeProbe.java | 2 ++ .../org/apache/cassandra/tools/NodeTool.java| 1 + .../tools/nodetool/GetTraceProbability.java | 33 4 files changed, 44 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/c5632c40/CHANGES.txt --
[02/10] cassandra git commit: Add nodetool gettraceprobability command
Add nodetool gettraceprobability command
Patch by Sequoyha Pelletier, reviewed by brandonwilliams for
CASSANDRA-10234
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/57d48a9b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/57d48a9b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/57d48a9b
Branch: refs/heads/cassandra-2.2
Commit: 57d48a9ba074810ebb25324d3bfc4db086a1c44d
Parents: 8a8a5a4
Author: Brandon Williams
Authored: Mon Aug 31 16:40:00 2015 -0500
Committer: Brandon Williams
Committed: Mon Aug 31 16:41:34 2015 -0500
--
CHANGES.txt | 1 +
.../org/apache/cassandra/tools/NodeProbe.java | 2 ++
.../org/apache/cassandra/tools/NodeTool.java| 1 +
.../tools/nodetool/GetTraceProbability.java | 33
4 files changed, 37 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 7841f9b..d57eaf7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Only check KeyCache when it is enabled
* Change streaming_socket_timeout_in_ms default to 1 hour (CASSANDRA-8611)
* (cqlsh) update list of CQL keywords (CASSANDRA-9232)
+ * Add nodetool gettraceprobability command (CASSANDRA-10234)
2.1.9
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeProbe.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeProbe.java
b/src/java/org/apache/cassandra/tools/NodeProbe.java
index caa12c3..51b1c93 100644
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@ -971,6 +971,8 @@ public class NodeProbe implements AutoCloseable
return ssProxy.getStreamThroughputMbPerSec();
}
+public double getTraceProbability() {return ssProxy.getTraceProbability();}
+
public int getExceptionCount()
{
return ssProxy.getExceptionCount();
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/NodeTool.java
--
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index 8e88f45..cc6e6d4 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -138,6 +138,7 @@ public class NodeTool
GetCompactionThreshold.class,
GetCompactionThroughput.class,
GetStreamThroughput.class,
+GetTraceProbability.class,
GetEndpoints.class,
GetSSTables.class,
GossipInfo.class,
http://git-wip-us.apache.org/repos/asf/cassandra/blob/57d48a9b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
--
diff --git
a/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
new file mode 100644
index 000..3940790
--- /dev/null
+++ b/src/java/org/apache/cassandra/tools/nodetool/GetTraceProbability.java
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.tools.nodetool;
+
+import io.airlift.command.Command;
+
+import org.apache.cassandra.tools.NodeProbe;
+import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+
+@Command(name = "gettraceprobability", description = "Print the current trace
probability value")
+public class GetTraceProbability extends NodeToolCmd
+{
+@Override
+public void execute(NodeProbe probe)
+{
+System.out.println("Current trace probability: " +
probe.getTraceProbability());
+}
+}
[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)
[
https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724092#comment-14724092
]
Benedict commented on CASSANDRA-8630:
-
I've pushed a version with a few suggestions, and a bug fix, in decreasing
order of note:
* {{MappedRegions.close}} now always calls {{channel.close}}, and returns any
error thrown by it
* Removed the {{readBytes}} method entirely, since it doesn't appear to offer
anything {{readFully}} and, transitively, {{ByteBufferUtil.read}}, doesn't
(correct me if I'm wrong...?)
** Simplified {{readFully}} while we're here
* Moved some of the {{close}} methods to the new {{Throwables.perform}} API to
make their behaviour more robust
* Replaced {{AssertionError}} with {{UnsupportedOperationException}} where
suitable
* Removed {{IOException}} from the throws clause of close, so no need to
introduce the new {{closeQuietly}} calls
* Removed the (as commented in TODO) unnecessary
{{BufferedSegmentedFile.createReader}}
* {{ChecksummedDataInput}} extends
{{RandomAccessReader.RandomAccessReaderWithOwnChannel}}
* Removed / standardised EOF behaviour for RAR and CRAR
Let me know what you think, and we can squash/commit.
bq. how picky the platform is about timing on DirectBuffer unmapping etc.
[~JoshuaMcKenzie]: is this wrt file rename / deletion, or wrt closing the
channel? My understanding was the former, in which case any such problem would
indicate a severe bug with 2.2+ (unless snapshots are involved, but don't think
we even try to handle that), and shouldn't be affected by this patch.
Absolutely no harm running the tests, of course.
> Faster sequential IO (on compaction, streaming, etc)
>
>
> Key: CASSANDRA-8630
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8630
> Project: Cassandra
> Issue Type: Improvement
> Components: Core, Tools
>Reporter: Oleg Anastasyev
>Assignee: Stefania
> Labels: compaction, performance
> Fix For: 3.x
>
> Attachments: 8630-FasterSequencialReadsAndWrites.txt, cpu_load.png,
> flight_recorder_001_files.tar.gz, flight_recorder_002_files.tar.gz,
> mmaped_uncomp_hotspot.png
>
>
> When node is doing a lot of sequencial IO (streaming, compacting, etc) a lot
> of CPU is lost in calls to RAF's int read() and DataOutputStream's write(int).
> This is because default implementations of readShort,readLong, etc as well as
> their matching write* are implemented with numerous calls of byte by byte
> read and write.
> This makes a lot of syscalls as well.
> A quick microbench shows than just reimplementation of these methods in
> either way gives 8x speed increase.
> A patch attached implements RandomAccessReader.read and
> SequencialWriter.write methods in more efficient way.
> I also eliminated some extra byte copies in CompositeType.split and
> ColumnNameHelper.maxComponents, which were on my profiler's hotspot method
> list during tests.
> A stress tests on my laptop show that this patch makes compaction 25-30%
> faster on uncompressed sstables and 15% faster for compressed ones.
> A deployment to production shows much less CPU load for compaction.
> (I attached a cpu load graph from one of our production, orange is niced CPU
> load - i.e. compaction; yellow is user - i.e. not compaction related tasks)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10234) Add nodetool gettraceprobability command
[ https://issues.apache.org/jira/browse/CASSANDRA-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sequoyha pelletier updated CASSANDRA-10234: --- Fix Version/s: 3.x > Add nodetool gettraceprobability command > > > Key: CASSANDRA-10234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10234 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: sequoyha pelletier >Priority: Trivial > Labels: newbie, patch > Fix For: 3.x > > Attachments: trunk-10234.txt > > > nodetool has a settraceprobability command but there is no way to get the > value from the nodetool command. Attaching patch that adds the > gettraceprobability command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10234) Add nodetool gettraceprobability command
[ https://issues.apache.org/jira/browse/CASSANDRA-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sequoyha pelletier updated CASSANDRA-10234: --- Attachment: trunk-10234.txt > Add nodetool gettraceprobability command > > > Key: CASSANDRA-10234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10234 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: sequoyha pelletier >Priority: Trivial > Attachments: trunk-10234.txt > > > nodetool has a settraceprobability command but there is no way to get the > value from the nodetool command. Attaching patch that adds the > gettraceprobability command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-10234) Add nodetool gettraceprobability command
sequoyha pelletier created CASSANDRA-10234: -- Summary: Add nodetool gettraceprobability command Key: CASSANDRA-10234 URL: https://issues.apache.org/jira/browse/CASSANDRA-10234 Project: Cassandra Issue Type: Improvement Components: Core Reporter: sequoyha pelletier Priority: Trivial nodetool has a settraceprobability command but there is no way to get the value from the nodetool command. Attaching patch that adds the gettraceprobability command. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10226) Support multiple non-PK cols in MV clustering key when partition key is shared
[ https://issues.apache.org/jira/browse/CASSANDRA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724062#comment-14724062 ] Tyler Hobbs commented on CASSANDRA-10226: - bq. Will this also let you set the cluster ordering how ever you want? Possibly across multiple columns? Yes. However, the existing restriction that the entire base table PK must be in the MV PK still applies. > Support multiple non-PK cols in MV clustering key when partition key is shared > -- > > Key: CASSANDRA-10226 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10226 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Labels: materializedviews > Fix For: 3.0.0 rc1 > > > This issue is similar to CASSANDRA-9928, but with one key limitation: the MV > partition key must match the base table's partition key. This limitation > results in the base replica always pairing with itself as the MV replica. > Because of this pairing, if the base replica is lost, any MV rows that would > otherwise be ambiguous are also lost. This allows us to avoid the problem > described in 9928 of not knowing which MV row to delete. > Although this limitation has the potential to be a bit confusing for users, I > believe this improvement is still worthwhile because: > * The base table's partition key will often be a good choice for the MV > partition key as well. I expect it to be common for users to partition data > the same way, but use a different clustering order to optimize for (or allow > for) different queries. > * It may take a long time to solve the problems presented in 9928 in general > (if we can solve them at all). On the other hand, this is straightforward > and is a significant improvement to the usability of MVs. > I have a minimal prototype of this that works well, so I should be able to > upload a patch with thorough tests within the next few days. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10226) Support multiple non-PK cols in MV clustering key when partition key is shared
[ https://issues.apache.org/jira/browse/CASSANDRA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724043#comment-14724043 ] Jeremiah Jordan commented on CASSANDRA-10226: - Will this also let you set the cluster ordering how ever you want? Possibly across multiple columns? Where a regular secondary index is always in "indexed column value" order. > Support multiple non-PK cols in MV clustering key when partition key is shared > -- > > Key: CASSANDRA-10226 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10226 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Labels: materializedviews > Fix For: 3.0.0 rc1 > > > This issue is similar to CASSANDRA-9928, but with one key limitation: the MV > partition key must match the base table's partition key. This limitation > results in the base replica always pairing with itself as the MV replica. > Because of this pairing, if the base replica is lost, any MV rows that would > otherwise be ambiguous are also lost. This allows us to avoid the problem > described in 9928 of not knowing which MV row to delete. > Although this limitation has the potential to be a bit confusing for users, I > believe this improvement is still worthwhile because: > * The base table's partition key will often be a good choice for the MV > partition key as well. I expect it to be common for users to partition data > the same way, but use a different clustering order to optimize for (or allow > for) different queries. > * It may take a long time to solve the problems presented in 9928 in general > (if we can solve them at all). On the other hand, this is straightforward > and is a significant improvement to the usability of MVs. > I have a minimal prototype of this that works well, so I should be able to > upload a patch with thorough tests within the next few days. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10226) Support multiple non-PK cols in MV clustering key when partition key is shared
[ https://issues.apache.org/jira/browse/CASSANDRA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724021#comment-14724021 ] T Jake Luciani commented on CASSANDRA-10226: bq. Is that what you're asking, or am I missing something? That's good thanks > Support multiple non-PK cols in MV clustering key when partition key is shared > -- > > Key: CASSANDRA-10226 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10226 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Labels: materializedviews > Fix For: 3.0.0 rc1 > > > This issue is similar to CASSANDRA-9928, but with one key limitation: the MV > partition key must match the base table's partition key. This limitation > results in the base replica always pairing with itself as the MV replica. > Because of this pairing, if the base replica is lost, any MV rows that would > otherwise be ambiguous are also lost. This allows us to avoid the problem > described in 9928 of not knowing which MV row to delete. > Although this limitation has the potential to be a bit confusing for users, I > believe this improvement is still worthwhile because: > * The base table's partition key will often be a good choice for the MV > partition key as well. I expect it to be common for users to partition data > the same way, but use a different clustering order to optimize for (or allow > for) different queries. > * It may take a long time to solve the problems presented in 9928 in general > (if we can solve them at all). On the other hand, this is straightforward > and is a significant improvement to the usability of MVs. > I have a minimal prototype of this that works well, so I should be able to > upload a patch with thorough tests within the next few days. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
svn commit: r1700341 - in /cassandra/site: publish/download/index.html src/settings.py
Author: jake
Date: Mon Aug 31 20:50:33 2015
New Revision: 1700341
URL: http://svn.apache.org/r1700341
Log:
cgi -> lua
Modified:
cassandra/site/publish/download/index.html
cassandra/site/src/settings.py
Modified: cassandra/site/publish/download/index.html
URL:
http://svn.apache.org/viewvc/cassandra/site/publish/download/index.html?rev=1700341&r1=1700340&r2=1700341&view=diff
==
--- cassandra/site/publish/download/index.html (original)
+++ cassandra/site/publish/download/index.html Mon Aug 31 20:50:33 2015
@@ -63,7 +63,7 @@
http://www.apache.org/dyn/closer.lua?path=/cassandra/2.2.0/apache-cassandra-2.2.0-bin.tar.gz";
+
href="http://www.apache.org/dyn/closer.lua/cassandra/2.2.0/apache-cassandra-2.2.0-bin.tar.gz";
onclick="javascript:
pageTracker._trackPageview('/clicks/binary_download');">
apache-cassandra-2.2.0-bin.tar.gz
@@ -83,7 +83,7 @@
- http://www.apache.org/dyn/closer.lua?path=/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz";>apache-cassandra-2.1.9-bin.tar.gz
+ http://www.apache.org/dyn/closer.lua/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz";>apache-cassandra-2.1.9-bin.tar.gz
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz.sha1";>SHA1]
@@ -131,7 +131,7 @@
-http://www.apache.org/dyn/closer.lua?path=/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz";>apache-cassandra-3.0.0-beta1-bin.tar.gz
+http://www.apache.org/dyn/closer.lua/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz";>apache-cassandra-3.0.0-beta1-bin.tar.gz
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz.sha1";>SHA1]
@@ -151,7 +151,7 @@
-http://www.apache.org/dyn/closer.lua?path=/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz";>apache-cassandra-2.0.16-bin.tar.gz
+http://www.apache.org/dyn/closer.lua/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz";>apache-cassandra-2.0.16-bin.tar.gz
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz.sha1";>SHA1]
@@ -171,7 +171,7 @@
http://www.apache.org/dyn/closer.lua?path=/cassandra/2.2.0/apache-cassandra-2.2.0-src.tar.gz";
+
href="http://www.apache.org/dyn/closer.lua/cassandra/2.2.0/apache-cassandra-2.2.0-src.tar.gz";
onclick="javascript:
pageTracker._trackPageview('/clicks/source_download');">
apache-cassandra-2.2.0-src.tar.gz
@@ -181,7 +181,7 @@
-http://www.apache.org/dyn/closer.lua?path=/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz";>apache-cassandra-2.1.9-src.tar.gz
+http://www.apache.org/dyn/closer.lua/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz";>apache-cassandra-2.1.9-src.tar.gz
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz.sha1";>SHA1]
@@ -189,7 +189,7 @@
-http://www.apache.org/dyn/closer.lua?path=/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz";>apache-cassandra-2.0.16-src.tar.gz
+http://www.apache.org/dyn/closer.lua/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz";>apache-cassandra-2.0.16-src.tar.gz
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz.sha1";>SHA1]
@@ -197,7 +197,7 @@
-http://www.apache.org/dyn/closer.lua?path=/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz";>apache-cassandra-3.0.0-beta1-src.tar.gz
+http://www.apache.org/dyn/closer.lua/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz";>apache-cassandra-3.0.0-beta1-src.tar.gz
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz.sha1";>SHA1]
Modified: cassandra/site/src/settings.py
URL:
http://
svn commit: r1700337 - in /cassandra/site: publish/download/index.html src/settings.py
Author: jake
Date: Mon Aug 31 20:45:11 2015
New Revision: 1700337
URL: http://svn.apache.org/r1700337
Log:
cgi -> lua
Modified:
cassandra/site/publish/download/index.html
cassandra/site/src/settings.py
Modified: cassandra/site/publish/download/index.html
URL:
http://svn.apache.org/viewvc/cassandra/site/publish/download/index.html?rev=1700337&r1=1700336&r2=1700337&view=diff
==
--- cassandra/site/publish/download/index.html (original)
+++ cassandra/site/publish/download/index.html Mon Aug 31 20:45:11 2015
@@ -63,7 +63,7 @@
http://www.apache.org/dyn/closer.cgi?path=/cassandra/2.2.0/apache-cassandra-2.2.0-bin.tar.gz";
+
href="http://www.apache.org/dyn/closer.lua?path=/cassandra/2.2.0/apache-cassandra-2.2.0-bin.tar.gz";
onclick="javascript:
pageTracker._trackPageview('/clicks/binary_download');">
apache-cassandra-2.2.0-bin.tar.gz
@@ -83,7 +83,7 @@
- http://www.apache.org/dyn/closer.cgi?path=/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz";>apache-cassandra-2.1.9-bin.tar.gz
+ http://www.apache.org/dyn/closer.lua?path=/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz";>apache-cassandra-2.1.9-bin.tar.gz
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-bin.tar.gz.sha1";>SHA1]
@@ -131,7 +131,7 @@
-http://www.apache.org/dyn/closer.cgi?path=/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz";>apache-cassandra-3.0.0-beta1-bin.tar.gz
+http://www.apache.org/dyn/closer.lua?path=/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz";>apache-cassandra-3.0.0-beta1-bin.tar.gz
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-bin.tar.gz.sha1";>SHA1]
@@ -151,7 +151,7 @@
-http://www.apache.org/dyn/closer.cgi?path=/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz";>apache-cassandra-2.0.16-bin.tar.gz
+http://www.apache.org/dyn/closer.lua?path=/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz";>apache-cassandra-2.0.16-bin.tar.gz
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-bin.tar.gz.sha1";>SHA1]
@@ -171,7 +171,7 @@
http://www.apache.org/dyn/closer.cgi?path=/cassandra/2.2.0/apache-cassandra-2.2.0-src.tar.gz";
+
href="http://www.apache.org/dyn/closer.lua?path=/cassandra/2.2.0/apache-cassandra-2.2.0-src.tar.gz";
onclick="javascript:
pageTracker._trackPageview('/clicks/source_download');">
apache-cassandra-2.2.0-src.tar.gz
@@ -181,7 +181,7 @@
-http://www.apache.org/dyn/closer.cgi?path=/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz";>apache-cassandra-2.1.9-src.tar.gz
+http://www.apache.org/dyn/closer.lua?path=/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz";>apache-cassandra-2.1.9-src.tar.gz
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.1.9/apache-cassandra-2.1.9-src.tar.gz.sha1";>SHA1]
@@ -189,7 +189,7 @@
-http://www.apache.org/dyn/closer.cgi?path=/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz";>apache-cassandra-2.0.16-src.tar.gz
+http://www.apache.org/dyn/closer.lua?path=/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz";>apache-cassandra-2.0.16-src.tar.gz
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/2.0.16/apache-cassandra-2.0.16-src.tar.gz.sha1";>SHA1]
@@ -197,7 +197,7 @@
-http://www.apache.org/dyn/closer.cgi?path=/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz";>apache-cassandra-3.0.0-beta1-src.tar.gz
+http://www.apache.org/dyn/closer.lua?path=/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz";>apache-cassandra-3.0.0-beta1-src.tar.gz
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz.asc";>PGP]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz.md5";>MD5]
[http://www.apache.org/dist/cassandra/3.0.0/apache-cassandra-3.0.0-beta1-src.tar.gz.sha1";>SHA1]
Modifi
[jira] [Commented] (CASSANDRA-10226) Support multiple non-PK cols in MV clustering key when partition key is shared
[
https://issues.apache.org/jira/browse/CASSANDRA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723996#comment-14723996
]
Tyler Hobbs commented on CASSANDRA-10226:
-
bq. I'm assuming you will continue to filter out nulls?
Yes, the current {{IS NOT NULL}} restrictions will continue to apply for now.
bq. Also, how is this any different than a secondary index?
The two main differences are 1) that it doesn't require a scatter-gather query,
and 2) only a single read needs to be executed instead of reading the index
table and then reading multiple keys from the base table. Is that what you're
asking, or am I missing something?
> Support multiple non-PK cols in MV clustering key when partition key is shared
> --
>
> Key: CASSANDRA-10226
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10226
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
> Labels: materializedviews
> Fix For: 3.0.0 rc1
>
>
> This issue is similar to CASSANDRA-9928, but with one key limitation: the MV
> partition key must match the base table's partition key. This limitation
> results in the base replica always pairing with itself as the MV replica.
> Because of this pairing, if the base replica is lost, any MV rows that would
> otherwise be ambiguous are also lost. This allows us to avoid the problem
> described in 9928 of not knowing which MV row to delete.
> Although this limitation has the potential to be a bit confusing for users, I
> believe this improvement is still worthwhile because:
> * The base table's partition key will often be a good choice for the MV
> partition key as well. I expect it to be common for users to partition data
> the same way, but use a different clustering order to optimize for (or allow
> for) different queries.
> * It may take a long time to solve the problems presented in 9928 in general
> (if we can solve them at all). On the other hand, this is straightforward
> and is a significant improvement to the usability of MVs.
> I have a minimal prototype of this that works well, so I should be able to
> upload a patch with thorough tests within the next few days.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723963#comment-14723963 ] Philip Thompson commented on CASSANDRA-10066: - Dtest results show this patch is horrible. Will fix and re-submit > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9754) Make index info heap friendly for large CQL partitions
[ https://issues.apache.org/jira/browse/CASSANDRA-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723931#comment-14723931 ] Ariel Weisberg commented on CASSANDRA-9754: --- Maybe it makes sense to have an intermediate step. Leverage Robert's work in 9738 to transition to simple off heap representation that can be mapped and then remove the key cache. It seems like this would effectively increase the upper bound on usable partition size in all cases compared to what we have today (is this a true statement?). After, or in parallel work on another representation for partition indexes. > Make index info heap friendly for large CQL partitions > -- > > Key: CASSANDRA-9754 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9754 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: Michael Kjellman >Priority: Minor > > Looking at a heap dump of 2.0 cluster, I found that majority of the objects > are IndexInfo and its ByteBuffers. This is specially bad in endpoints with > large CQL partitions. If a CQL partition is say 6,4GB, it will have 100K > IndexInfo objects and 200K ByteBuffers. This will create a lot of churn for > GC. Can this be improved by not creating so many objects? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9738) Migrate key-cache to be fully off-heap
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723917#comment-14723917 ] Ariel Weisberg commented on CASSANDRA-9738: --- I agree there is overlap in. The scope of what we need to make the key cache work is smaller, but it might be game over for the key cache and large partitions anyways even with Robert's improvements. Constantly loading and unloading large partitions is never going to work. We are at least reaching parity with the old key cache. If we could map the entire partition index then you could point this code at the mapping and it would work. It would not be ideal because what we are doing is a basic translation of the object graph which is an array pointing to variable size objects. Binary searches are going to result in access to two pages for each comparison. Possibly still better than what we have today? I think the trick right now is figuring out what we can do for 3.0, and what the next intermediate step is. If Robert goes and makes this work off-heap then the key cache can maybe go off heap for 3.0. Seems like removing the key cache and reliably operating against a memory map is unlikely for 3.0, but maybe shortly after. What would the timeline be for 9754? That kind of determines what intermediate steps make sense. > Migrate key-cache to be fully off-heap > -- > > Key: CASSANDRA-9738 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9738 > Project: Cassandra > Issue Type: Sub-task >Reporter: Robert Stupp >Assignee: Robert Stupp > Fix For: 3.0 beta 2 > > > Key cache still uses a concurrent map on-heap. This could go to off-heap and > feels doable now after CASSANDRA-8099. > Evaluation should be done in advance based on a POC to prove that pure > off-heap counter cache buys a performance and/or gc-pressure improvement. > In theory, elimination of on-heap management of the map should buy us some > benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7276) Include keyspace and table names in logs where possible
[
https://issues.apache.org/jira/browse/CASSANDRA-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723905#comment-14723905
]
Robert Coli commented on CASSANDRA-7276:
As an operator the log messages in which I most need Keyspace are the ones that
relate to flushing, like these :
{quote}
INFO [ScheduledTasks:1] 2015-08-31 10:29:08,618 ColumnFamilyStore.java:912 -
Enqueuing flush of sstable_activity: 4672 (0%) on-heap, 0 (0%) off-heap
INFO [MemtableFlushWriter:458] 2015-08-31 07:29:08,617 Memtable.java:347 -
Writing Memtable-sstable_activity@1628471115(0.521KiB serialized bytes, 216
ops, 0%/0% of on/off-heap limit)
{quote}
If I had keyspace info, I would would grep -v all system keyspace activity. But
now I have to enumerate a list of all system keyspaces and grep -v that.
The compaction ones at least contain a string that I can trivially remove via
grep, "/system/" :
{quote}
INFO [CompactionExecutor:7] 2015-08-31 07:29:08,627 CompactionTask.java:141 -
Compacting [SSTableReader(path='/mnt/cassandra/data/system/
{quote}
> Include keyspace and table names in logs where possible
> ---
>
> Key: CASSANDRA-7276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7276
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Tyler Hobbs
>Assignee: Nitzan Volman
>Priority: Minor
> Labels: bootcamp, lhf
> Fix For: 2.1.x
>
> Attachments: 2.1-CASSANDRA-7276-v1.txt,
> cassandra-2.1-7276-compaction.txt, cassandra-2.1-7276.txt
>
>
> Most error messages and stacktraces give you no clue as to what keyspace or
> table was causing the problem. For example:
> {noformat}
> ERROR [MutationStage:61648] 2014-05-20 12:05:45,145 CassandraDaemon.java
> (line 198) Exception in thread Thread[MutationStage:61648,5,main]
> java.lang.IllegalArgumentException
> at java.nio.Buffer.limit(Unknown Source)
> at
> org.apache.cassandra.db.marshal.AbstractCompositeType.getBytes(AbstractCompositeType.java:63)
> at
> org.apache.cassandra.db.marshal.AbstractCompositeType.getWithShortLength(AbstractCompositeType.java:72)
> at
> org.apache.cassandra.db.marshal.AbstractCompositeType.compare(AbstractCompositeType.java:98)
> at
> org.apache.cassandra.db.marshal.AbstractCompositeType.compare(AbstractCompositeType.java:35)
> at
> edu.stanford.ppl.concurrent.SnapTreeMap$1.compareTo(SnapTreeMap.java:538)
> at
> edu.stanford.ppl.concurrent.SnapTreeMap.attemptUpdate(SnapTreeMap.java:1108)
> at
> edu.stanford.ppl.concurrent.SnapTreeMap.updateUnderRoot(SnapTreeMap.java:1059)
> at edu.stanford.ppl.concurrent.SnapTreeMap.update(SnapTreeMap.java:1023)
> at
> edu.stanford.ppl.concurrent.SnapTreeMap.putIfAbsent(SnapTreeMap.java:985)
> at
> org.apache.cassandra.db.AtomicSortedColumns$Holder.addColumn(AtomicSortedColumns.java:328)
> at
> org.apache.cassandra.db.AtomicSortedColumns.addAllWithSizeDelta(AtomicSortedColumns.java:200)
> at org.apache.cassandra.db.Memtable.resolve(Memtable.java:226)
> at org.apache.cassandra.db.Memtable.put(Memtable.java:173)
> at
> org.apache.cassandra.db.ColumnFamilyStore.apply(ColumnFamilyStore.java:893)
> at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:368)
> at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:333)
> at org.apache.cassandra.db.RowMutation.apply(RowMutation.java:206)
> at
> org.apache.cassandra.db.RowMutationVerbHandler.doVerb(RowMutationVerbHandler.java:56)
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:60)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
> at java.lang.Thread.run(Unknown Source)
> {noformat}
> We should try to include info on the keyspace and column family in the error
> messages or logs whenever possible. This includes reads, writes,
> compactions, flushes, repairs, and probably more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723863#comment-14723863 ] Philip Thompson edited comment on CASSANDRA-10066 at 8/31/15 7:00 PM: -- 2.1 patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.1 2.2+ patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.2 2.1 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-2.1-dtest/ 2.2 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-2.2-dtest/ 3.0 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-3.0-dtest/ was (Author: philipthompson): 2.1 patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.1 2.2+ patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.2 2.1 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-2.1-dtest/ 2.2 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-2.2-dtest/ > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723868#comment-14723868 ] Philip Thompson edited comment on CASSANDRA-10066 at 8/31/15 6:59 PM: -- One important change I want to point out is at https://github.com/apache/cassandra/compare/trunk...ptnapoleon:10066-2.2#diff-1cce67f7d76864f07aaf4d986d6fc051R2303 . 2.1 is already using self.hostname, which appears to be the correct behavior. The new import ordering was determined using isort. https://github.com/timothycrosley/isort was (Author: philipthompson): One important change I want to point out is at https://github.com/apache/cassandra/compare/trunk...ptnapoleon:10066-2.2#diff-1cce67f7d76864f07aaf4d986d6fc051R2303 . 2.1 is already using self.hostname, which appears to be the correct behavior. > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723868#comment-14723868 ] Philip Thompson commented on CASSANDRA-10066: - One important change I want to point out is at https://github.com/apache/cassandra/compare/trunk...ptnapoleon:10066-2.2#diff-1cce67f7d76864f07aaf4d986d6fc051R2303 . 2.1 is already using self.hostname, which appears to be the correct behavior. > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723863#comment-14723863 ] Philip Thompson edited comment on CASSANDRA-10066 at 8/31/15 6:56 PM: -- 2.1 patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.1 2.2+ patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.2 2.1 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-2.1-dtest/ 2.2 dtest results at http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-10066-2.2-dtest/ was (Author: philipthompson): 2.1 patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.1 2.2+ patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.2 > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Thompson updated CASSANDRA-10066: Fix Version/s: 3.x > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10066) Bring cqlsh into PEP8 compliance
[ https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723863#comment-14723863 ] Philip Thompson commented on CASSANDRA-10066: - 2.1 patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.1 2.2+ patch at https://github.com/ptnapoleon/cassandra/tree/10066-2.2 > Bring cqlsh into PEP8 compliance > > > Key: CASSANDRA-10066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10066 > Project: Cassandra > Issue Type: Bug >Reporter: Philip Thompson >Assignee: Philip Thompson >Priority: Minor > Labels: cqlsh > Fix For: 3.x, 2.1.x, 2.2.x > > > In order for us to begin running flake8 against cqlsh.py in CI, it would be > helpful if it were already PEP8 complaint, with the exception of using 120 > character lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (CASSANDRA-9893) Fix upgrade tests from #9704 that are still failing
[ https://issues.apache.org/jira/browse/CASSANDRA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704060#comment-14704060 ] Blake Eggleston edited comment on CASSANDRA-9893 at 8/31/15 6:45 PM: - I've merged Tyler's 8099-backwards-compat branch with the current dtest master and run the tests in the upgrade_tests folder locally against the tip of cassandra-3.0 (CASSANDRA_DIR) and cassandra-2.1 (OLD_CASSANDRA_DIR) with Stupp's fix for CASSANDRA-8220 on osx. I'm getting 7 failures, and 9 other tests which are repeatably throwing various timeout themed errors. These are the tests that are failing: -cql_tests:TestCQL.collection_indexing_test- -cql_tests:TestCQL.composite_index_collections_test- -cql_tests:TestCQL.edge_2i_on_complex_pk_test- -cql_tests:TestCQL.indexed_with_eq_test- -*cql_tests:TestCQL.large_count_test*- (CASSANDRA-9857) -cql_tests:TestCQL.conditional_delete_test- -*cql_tests:TestCQL.static_columns_with_distinct_test*- (CASSANDRA-9857) -paging_test:TestPagingWithDeletions.test_failure_threshold_deletions- cql_tests:TestCQL.static_columns_cas_test paging_test:TestPagingSize.test_with_equal_results_to_page_size these are the ones with timeout/no host errors: -*cql_tests:TestCQL.batch_test*- (CASSANDRA-9673) -*cql_tests:TestCQL.noncomposite_static_cf_test*- (CASSANDRA-9673) -*cql_tests:TestCQL.static_cf_test*- (CASSANDRA-9673) -*cql_tests:TestCQL.test_v2_protocol_IN_with_tuples*- (CASSANDRA-10146) -paging_test:TestPagingDatasetChanges.test_row_TTL_expiry_during_paging- and these had Truncate related timeouts: -paging_test:TestPagingData.test_paging_a_single_wide_row- -paging_test:TestPagingData.test_paging_across_multi_wide_rows- -paging_test:TestPagingDatasetChanges.test_cell_TTL_expiry_during_paging- -paging_test:TestPagingSize.test_undefined_page_size_default- with some more info about the failures here: https://gist.github.com/bdeggleston/cb29e277468a5861d33e https://gist.github.com/bdeggleston/ead704e3f62d55adf5f0 This is mainly a checklist for myself, since 8099-backwards-compat support on cassci isn't there yet. I'm going to focus on the failures first, then take a closer look at the errors. was (Author: bdeggleston): I've merged Tyler's 8099-backwards-compat branch with the current dtest master and run the tests in the upgrade_tests folder locally against the tip of cassandra-3.0 (CASSANDRA_DIR) and cassandra-2.1 (OLD_CASSANDRA_DIR) with Stupp's fix for CASSANDRA-8220 on osx. I'm getting 7 failures, and 9 other tests which are repeatably throwing various timeout themed errors. These are the tests that are failing: -cql_tests:TestCQL.collection_indexing_test- -cql_tests:TestCQL.composite_index_collections_test- -cql_tests:TestCQL.edge_2i_on_complex_pk_test- -cql_tests:TestCQL.indexed_with_eq_test- -*cql_tests:TestCQL.large_count_test*- (CASSANDRA-9857) cql_tests:TestCQL.conditional_delete_test -*cql_tests:TestCQL.static_columns_with_distinct_test*- (CASSANDRA-9857) paging_test:TestPagingWithDeletions.test_failure_threshold_deletions these are the ones with timeout/no host errors: -*cql_tests:TestCQL.batch_test*- (CASSANDRA-9673) -*cql_tests:TestCQL.noncomposite_static_cf_test*- (CASSANDRA-9673) -*cql_tests:TestCQL.static_cf_test*- (CASSANDRA-9673) -*cql_tests:TestCQL.test_v2_protocol_IN_with_tuples*- (CASSANDRA-10146) -paging_test:TestPagingDatasetChanges.test_row_TTL_expiry_during_paging- and these had Truncate related timeouts: -paging_test:TestPagingData.test_paging_a_single_wide_row- -paging_test:TestPagingData.test_paging_across_multi_wide_rows- -paging_test:TestPagingDatasetChanges.test_cell_TTL_expiry_during_paging- -paging_test:TestPagingSize.test_undefined_page_size_default- with some more info about the failures here: https://gist.github.com/bdeggleston/cb29e277468a5861d33e https://gist.github.com/bdeggleston/ead704e3f62d55adf5f0 This is mainly a checklist for myself, since 8099-backwards-compat support on cassci isn't there yet. I'm going to focus on the failures first, then take a closer look at the errors. > Fix upgrade tests from #9704 that are still failing > --- > > Key: CASSANDRA-9893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9893 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Blake Eggleston > Fix For: 3.0 beta 2 > > > The first things to do on this ticket would be to commit Tyler's branch > (https://github.com/thobbs/cassandra-dtest/tree/8099-backwards-compat) to the > dtests so cassci run them. I've had to do a few minor modifications to have > them run locally so someone which access to cassci should do it and make sure > it runs properly. > Once we have that, we should fix any test that isn't passing. I've ran the > tests locally and I had 8 f
[jira] [Commented] (CASSANDRA-9893) Fix upgrade tests from #9704 that are still failing
[
https://issues.apache.org/jira/browse/CASSANDRA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723847#comment-14723847
]
Blake Eggleston commented on CASSANDRA-9893:
The {{TestCQL.conditional_delete_test}} failure is caused by the interaction of
two LegacyLayout behaviors. First, the static row is always prepended to the
LegacyCell iterator here:
https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/LegacyLayout.java#L646.
Second, the ColumnFilter instance deserialized from a 2.1 read command always
has isFetchAll set to true. This may be more of a ColumnFilter.Builder problem,
which sets isFetchAll to true if CFMetaData is present here:
https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L291
In any case, this causes the static cells to be passed back to the 2.1 node as
part of the read response. I've added a 'maybeDisableFetchAll' method to the
column filter builder, which is called from the legacy slice command
deserializer, and turns off isFetchAll if the command isn't selecting all
regular/static columns. This fixes the issue, and doesn't break anything else,
but I'm not positive this is the best way to fix the problem.
https://github.com/bdeggleston/cassandra/commit/5bacd62b7a6492cc91a8fd33846ea3a7d3ef9dfc
The {{TestPagingWithDeletions.test_failure_threshold_deletions}} failure was
caused by an out of date log regex, which is fixed here:
https://github.com/bdeggleston/cassandra-dtest/commit/28de3d11fe355a5289e70f38cb8e9e9d010a8059
I've also found these 2 tests, which are failing sporadically:
cql_tests:TestCQL.static_columns_cas_test
TestPagingSize.test_with_equal_results_to_page_size
> Fix upgrade tests from #9704 that are still failing
> ---
>
> Key: CASSANDRA-9893
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9893
> Project: Cassandra
> Issue Type: Bug
>Reporter: Sylvain Lebresne
>Assignee: Blake Eggleston
> Fix For: 3.0 beta 2
>
>
> The first things to do on this ticket would be to commit Tyler's branch
> (https://github.com/thobbs/cassandra-dtest/tree/8099-backwards-compat) to the
> dtests so cassci run them. I've had to do a few minor modifications to have
> them run locally so someone which access to cassci should do it and make sure
> it runs properly.
> Once we have that, we should fix any test that isn't passing. I've ran the
> tests locally and I had 8 failures. for 2 of them, it sounds plausible that
> they'll get fixed by the patch of CASSANDRA-9775, though that's just a guess.
> The rest where test that timeouted without a particular error in the log,
> and running some of them individually, they passed. So we'll have to see if
> it's just my machine being overly slow when running them all.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CASSANDRA-10233) IndexOutOfBoundsException in HintedHandOffManager
Omri Iluz created CASSANDRA-10233:
-
Summary: IndexOutOfBoundsException in HintedHandOffManager
Key: CASSANDRA-10233
URL: https://issues.apache.org/jira/browse/CASSANDRA-10233
Project: Cassandra
Issue Type: Bug
Components: Core
Environment: Cassandra 2.2.0
Reporter: Omri Iluz
After upgrading our cluster to 2.2.0, the following error started showing
exectly every 10 minutes on every server in the cluster:
{noformat}
INFO [CompactionExecutor:1381] 2015-08-31 18:31:55,506 CompactionTask.java:142
- Compacting (8e7e1520-500e-11e5-b1e3-e95897ba4d20)
[/cassandra/data/system/hints-2666e20573ef38b390fefecf96e8f0c7/la-540-big-Data.db:level=0,
]
INFO [CompactionExecutor:1381] 2015-08-31 18:31:55,599 CompactionTask.java:224
- Compacted (8e7e1520-500e-11e5-b1e3-e95897ba4d20) 1 sstables to
[/cassandra/data/system/hints-2666e20573ef38b390fefecf96e8f0c7/la-541-big,] to
level=0. 1,544,495 bytes to 1,544,495 (~100% of original) in 93ms =
15.838121MB/s. 0 total partitions merged to 4. Partition merge counts were
{1:4, }
ERROR [HintedHandoff:1] 2015-08-31 18:31:55,600 CassandraDaemon.java:182 -
Exception in thread Thread[HintedHandoff:1,1,main]
java.lang.IndexOutOfBoundsException: null
at java.nio.Buffer.checkIndex(Buffer.java:538) ~[na:1.7.0_79]
at java.nio.HeapByteBuffer.getLong(HeapByteBuffer.java:410)
~[na:1.7.0_79]
at org.apache.cassandra.utils.UUIDGen.getUUID(UUIDGen.java:106)
~[apache-cassandra-2.2.0.jar:2.2.0]
at
org.apache.cassandra.db.HintedHandOffManager.scheduleAllDeliveries(HintedHandOffManager.java:515)
~[apache-cassandra-2.2.0.jar:2.2.0]
at
org.apache.cassandra.db.HintedHandOffManager.access$000(HintedHandOffManager.java:88)
~[apache-cassandra-2.2.0.jar:2.2.0]
at
org.apache.cassandra.db.HintedHandOffManager$1.run(HintedHandOffManager.java:168)
~[apache-cassandra-2.2.0.jar:2.2.0]
at
org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor$UncomplainingRunnable.run(DebuggableScheduledThreadPoolExecutor.java:118)
~[apache-cassandra-2.2.0.jar:2.2.0]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
[na:1.7.0_79]
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
[na:1.7.0_79]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
[na:1.7.0_79]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[na:1.7.0_79]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[na:1.7.0_79]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[na:1.7.0_79]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_79]
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-6237) Allow range deletions in CQL
[
https://issues.apache.org/jira/browse/CASSANDRA-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723843#comment-14723843
]
Joshua McKenzie commented on CASSANDRA-6237:
Current branch is based off of trunk however this ticket is targeting 3.0.
Could we get a rebase to 3.0 linked to the ticket? I'll start review against
trunk as they should be functionally quite similar but I figured it's better to
operate against the correct branch.
> Allow range deletions in CQL
>
>
> Key: CASSANDRA-6237
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6237
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sylvain Lebresne
>Assignee: Benjamin Lerer
>Priority: Minor
> Labels: cql, docs
> Fix For: 3.0 beta 2
>
> Attachments: CASSANDRA-6237.txt
>
>
> We uses RangeTombstones internally in a number of places, but we could expose
> more directly too. Typically, given a table like:
> {noformat}
> CREATE TABLE events (
> id text,
> created_at timestamp,
> content text,
> PRIMARY KEY (id, created_at)
> )
> {noformat}
> we could allow queries like:
> {noformat}
> DELETE FROM events WHERE id='someEvent' AND created_at < 'Jan 3, 2013';
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-10108) Windows dtest 3.0: sstablesplit_test.py:TestSSTableSplit.split_test fails
[
https://issues.apache.org/jira/browse/CASSANDRA-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta resolved CASSANDRA-10108.
-
Resolution: Done
> Windows dtest 3.0: sstablesplit_test.py:TestSSTableSplit.split_test fails
> -
>
> Key: CASSANDRA-10108
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10108
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Joshua McKenzie
>Assignee: Paulo Motta
> Labels: Windows
> Fix For: 3.0.x
>
>
> Locally:
> {noformat}
> -- ma-28-big-Data.db-
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/supercsv/prefs/CsvPreference$Builder
> at org.apache.cassandra.config.Config.(Config.java:240)
> at
> org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:105)
> at
> org.apache.cassandra.service.StorageService.getPartitioner(StorageService.java:220)
> at
> org.apache.cassandra.service.StorageService.(StorageService.java:206)
> at
> org.apache.cassandra.service.StorageService.(StorageService.java:211)
> at
> org.apache.cassandra.schema.LegacySchemaTables.getSchemaPartitionsForTable(LegacySchemaTables.java:295)
> at
> org.apache.cassandra.schema.LegacySchemaTables.readSchemaFromSystemTables(LegacySchemaTables.java:210)
> at org.apache.cassandra.config.Schema.loadFromDisk(Schema.java:108)
> at
> org.apache.cassandra.tools.StandaloneSplitter.main(StandaloneSplitter.java:58)
> Caused by: java.lang.ClassNotFoundException:
> org.supercsv.prefs.CsvPreference$Builder
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 9 more
> Number of sstables after split: 1. expected 21.0
> {noformat}
> on CI:
> {noformat}
> 21.0 not less than or equal to 2
> and
> [node1 ERROR] Exception calling "CompareTo" with "1" argument(s): "Object
> must be of type
> String."
> At D:\temp\dtest-i3xwjx\test\node1\conf\cassandra-env.ps1:336 char:9
> + if ($env:JVM_VERSION.CompareTo("1.8.0_40" -eq -1))
> + ~
> + CategoryInfo : NotSpecified: (:) [], MethodInvocationException
> + FullyQualifiedErrorId : ArgumentException
> -- ma-28-big-Data.db-
> {noformat}
> Failure history:
> [consistent|http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_dtest_win32/lastCompletedBuild/testReport/sstablesplit_test/TestSSTableSplit/split_test/history/]
> Env: both CI and local
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10108) Windows dtest 3.0: sstablesplit_test.py:TestSSTableSplit.split_test fails
[
https://issues.apache.org/jira/browse/CASSANDRA-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723824#comment-14723824
]
Paulo Motta commented on CASSANDRA-10108:
-
closing as the issue seem to have been fixed in the latest
[builds|http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/lastCompletedBuild/testReport/sstablesplit_test/TestSSTableSplit/split_test/history/]
(except in the faulty win2k8 builds). will reopen if necessary.
> Windows dtest 3.0: sstablesplit_test.py:TestSSTableSplit.split_test fails
> -
>
> Key: CASSANDRA-10108
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10108
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Joshua McKenzie
>Assignee: Paulo Motta
> Labels: Windows
> Fix For: 3.0.x
>
>
> Locally:
> {noformat}
> -- ma-28-big-Data.db-
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/supercsv/prefs/CsvPreference$Builder
> at org.apache.cassandra.config.Config.(Config.java:240)
> at
> org.apache.cassandra.config.DatabaseDescriptor.(DatabaseDescriptor.java:105)
> at
> org.apache.cassandra.service.StorageService.getPartitioner(StorageService.java:220)
> at
> org.apache.cassandra.service.StorageService.(StorageService.java:206)
> at
> org.apache.cassandra.service.StorageService.(StorageService.java:211)
> at
> org.apache.cassandra.schema.LegacySchemaTables.getSchemaPartitionsForTable(LegacySchemaTables.java:295)
> at
> org.apache.cassandra.schema.LegacySchemaTables.readSchemaFromSystemTables(LegacySchemaTables.java:210)
> at org.apache.cassandra.config.Schema.loadFromDisk(Schema.java:108)
> at
> org.apache.cassandra.tools.StandaloneSplitter.main(StandaloneSplitter.java:58)
> Caused by: java.lang.ClassNotFoundException:
> org.supercsv.prefs.CsvPreference$Builder
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 9 more
> Number of sstables after split: 1. expected 21.0
> {noformat}
> on CI:
> {noformat}
> 21.0 not less than or equal to 2
> and
> [node1 ERROR] Exception calling "CompareTo" with "1" argument(s): "Object
> must be of type
> String."
> At D:\temp\dtest-i3xwjx\test\node1\conf\cassandra-env.ps1:336 char:9
> + if ($env:JVM_VERSION.CompareTo("1.8.0_40" -eq -1))
> + ~
> + CategoryInfo : NotSpecified: (:) [], MethodInvocationException
> + FullyQualifiedErrorId : ArgumentException
> -- ma-28-big-Data.db-
> {noformat}
> Failure history:
> [consistent|http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_dtest_win32/lastCompletedBuild/testReport/sstablesplit_test/TestSSTableSplit/split_test/history/]
> Env: both CI and local
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-6819) The command "nodetool setcompactionthroughput" sometimes takes a long time to take effect
[ https://issues.apache.org/jira/browse/CASSANDRA-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723787#comment-14723787 ] Jeremy Hanna commented on CASSANDRA-6819: - [~kohlisankalp] It is a duplicate - I was being overly conservative. Feel free to resolve either one in favor of the other. > The command "nodetool setcompactionthroughput" sometimes takes a long time to > take effect > - > > Key: CASSANDRA-6819 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6819 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Steven Lowenthal > Fix For: 3.x > > > It's often necessary to throttle a large compaction. When the nodetool > setcompactionthroughput command is issued, the setting doesn't seem to take > hold until another compaction starts, which may be some time on a bungled > node. This command should take hold immediately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
svn commit: r1700284 - in /cassandra/site: publish/download/index.html src/settings.py
Author: jake Date: Mon Aug 31 17:52:22 2015 New Revision: 1700284 URL: http://svn.apache.org/r1700284 Log: date typo Modified: cassandra/site/publish/download/index.html cassandra/site/src/settings.py Modified: cassandra/site/publish/download/index.html URL: http://svn.apache.org/viewvc/cassandra/site/publish/download/index.html?rev=1700284&r1=1700283&r2=1700284&view=diff == --- cassandra/site/publish/download/index.html (original) +++ cassandra/site/publish/download/index.html Mon Aug 31 17:52:22 2015 @@ -78,7 +78,7 @@ The most stable release of Apache Cassandra is 2.1.9 - (released on 2015-09-28). If you are in production or planning to be soon, download this one. + (released on 2015-08-28). If you are in production or planning to be soon, download this one. Modified: cassandra/site/src/settings.py URL: http://svn.apache.org/viewvc/cassandra/site/src/settings.py?rev=1700284&r1=1700283&r2=1700284&view=diff == --- cassandra/site/src/settings.py (original) +++ cassandra/site/src/settings.py Mon Aug 31 17:52:22 2015 @@ -96,7 +96,7 @@ class CassandraDef(object): stable_release_date = '2015-07-20' is_stable_prod_ready = False oldstable_version = '2.1.9' -oldstable_release_date = '2015-09-28' +oldstable_release_date = '2015-08-28' oldstable_exists = True veryoldstable_version = '2.0.16' veryoldstable_release_date = '2015-06-22'
[jira] [Commented] (CASSANDRA-9738) Migrate key-cache to be fully off-heap
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723761#comment-14723761 ] sankalp kohli commented on CASSANDRA-9738: -- It looks like there is lot of overlap with CASSANDRA-9754 > Migrate key-cache to be fully off-heap > -- > > Key: CASSANDRA-9738 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9738 > Project: Cassandra > Issue Type: Sub-task >Reporter: Robert Stupp >Assignee: Robert Stupp > Fix For: 3.0 beta 2 > > > Key cache still uses a concurrent map on-heap. This could go to off-heap and > feels doable now after CASSANDRA-8099. > Evaluation should be done in advance based on a POC to prove that pure > off-heap counter cache buys a performance and/or gc-pressure improvement. > In theory, elimination of on-heap management of the map should buy us some > benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9738) Migrate key-cache to be fully off-heap
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723736#comment-14723736 ] Ariel Weisberg commented on CASSANDRA-9738: --- OK, looks like what I was thinking at a high level. Since it is in progress I won't go deeper yet. I would include the index info offsets in the serialization and just populate them from the start so random access is simple. It's not going to be a worse memory impact than the existing Java object graph that has the array. Caching the last used IndexInfo is going to force a little bit of promotion. Not sure how much. It's not going to be easy, but if we can operate on the IndexInfo as a ByteBuffer we can avoid deserializing them during the binary search. Getting ClusteringComparator and ClusteringPrefix to that point does look hard. We measure as is and see if it's enough garbage and to matter. Reference counting shouldn't be too bad. In all the cases I could find the index info is consumed immediately and discarded or composed into an iterator implementing Closable. There is a bit of rope to hang to hang ourselves with there for long lived iterators pinning stuff in the cache. This is probably something we should test in OHC. > Migrate key-cache to be fully off-heap > -- > > Key: CASSANDRA-9738 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9738 > Project: Cassandra > Issue Type: Sub-task >Reporter: Robert Stupp >Assignee: Robert Stupp > Fix For: 3.0 beta 2 > > > Key cache still uses a concurrent map on-heap. This could go to off-heap and > feels doable now after CASSANDRA-8099. > Evaluation should be done in advance based on a POC to prove that pure > off-heap counter cache buys a performance and/or gc-pressure improvement. > In theory, elimination of on-heap management of the map should buy us some > benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-6819) The command "nodetool setcompactionthroughput" sometimes takes a long time to take effect
[ https://issues.apache.org/jira/browse/CASSANDRA-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723730#comment-14723730 ] sankalp kohli commented on CASSANDRA-6819: -- [~jeromatron] Why is this not a dupe of CASSANDRA-10025? We are planning to solve exactly this. > The command "nodetool setcompactionthroughput" sometimes takes a long time to > take effect > - > > Key: CASSANDRA-6819 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6819 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Steven Lowenthal > Fix For: 3.x > > > It's often necessary to throttle a large compaction. When the nodetool > setcompactionthroughput command is issued, the setting doesn't seem to take > hold until another compaction starts, which may be some time on a bungled > node. This command should take hold immediately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[4/6] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3bc585d5 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3bc585d5 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3bc585d5 Branch: refs/heads/trunk Commit: 3bc585d5d0e01dd4f855994add67d3d120857eec Parents: 0828e24 0d2f403 Author: Jonathan Ellis Authored: Mon Aug 31 12:04:44 2015 -0500 Committer: Jonathan Ellis Committed: Mon Aug 31 12:04:44 2015 -0500 -- .../org/apache/cassandra/config/DatabaseDescriptor.java | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/3bc585d5/src/java/org/apache/cassandra/config/DatabaseDescriptor.java --
[jira] [Commented] (CASSANDRA-9071) CQLSSTableWriter gives java.lang.AssertionError: Empty partition
[ https://issues.apache.org/jira/browse/CASSANDRA-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723700#comment-14723700 ] Jonathan Ellis commented on CASSANDRA-9071: --- No. > CQLSSTableWriter gives java.lang.AssertionError: Empty partition > > > Key: CASSANDRA-9071 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9071 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: java 7 / 8 > cassandra 2.1.3 snapshot build locally with last commit > https://github.com/apache/cassandra/commit/6ee4b0989d9a3ae3e704918622024fa57fdf63e7 > macos Yosemite 10.10.2 >Reporter: Ajit Joglekar >Assignee: Fabien Rousseau > Fix For: 2.1.6 > > Attachments: EmailWriter.java, Screen Shot 2015-04-15 at 11.14.40 > PM.png, cassandra-2.1-9071.txt, data.csv.gz > > > I am always getting the following error: > Exception in thread "main" java.lang.AssertionError: Empty partition > at > org.apache.cassandra.io.sstable.SSTableSimpleUnsortedWriter$DiskWriter.run(SSTableSimpleUnsortedWriter.java:228) > It happens at a certain point that seems to be repeatable. Only issue is I am > converting 400 million records into multiple SSTables and creating small test > is a challenge > Last comment from Benedict looks relevant here > https://issues.apache.org/jira/browse/CASSANDRA-8619 > Is there a work around, quick fix, fix that I can try out locally? > Thanks, > -Ajit -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/6] cassandra git commit: Defer initialization of default RoleManager until IAuthenticator is set reviewed by jbellis for CASSANDRA-10209
Defer initialization of default RoleManager until IAuthenticator is set
reviewed by jbellis for CASSANDRA-10209
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0d2f4038
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0d2f4038
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0d2f4038
Branch: refs/heads/cassandra-3.0
Commit: 0d2f4038fc2564c695d0d8c4b1ad523ec1afaceb
Parents: c870adc
Author: Sam Tunnicliffe
Authored: Thu Aug 27 20:21:17 2015 +0100
Committer: Jonathan Ellis
Committed: Mon Aug 31 12:04:01 2015 -0500
--
.../org/apache/cassandra/config/DatabaseDescriptor.java | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/0d2f4038/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
--
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index b7e3eaa..9cf3959 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -87,7 +87,9 @@ public class DatabaseDescriptor
private static IAuthenticator authenticator = new AllowAllAuthenticator();
private static IAuthorizer authorizer = new AllowAllAuthorizer();
-private static IRoleManager roleManager = new CassandraRoleManager();
+// Don't initialize the role manager until applying config. The options
supported by CassandraRoleManager
+// depend on the configured IAuthenticator, so defer creating it until
that's been set.
+private static IRoleManager roleManager;
private static IRequestScheduler requestScheduler;
private static RequestSchedulerId requestSchedulerId;
@@ -323,8 +325,9 @@ public class DatabaseDescriptor
if (authenticator instanceof AllowAllAuthenticator && !(authorizer
instanceof AllowAllAuthorizer))
throw new ConfigurationException("AllowAllAuthenticator can't be
used with " + conf.authorizer, false);
-if (conf.role_manager != null)
-roleManager = FBUtilities.newRoleManager(conf.role_manager);
+roleManager = conf.role_manager == null
+? new CassandraRoleManager()
+: FBUtilities.newRoleManager(conf.role_manager);
if (authenticator instanceof PasswordAuthenticator && !(roleManager
instanceof CassandraRoleManager))
throw new ConfigurationException("CassandraRoleManager must be
used with PasswordAuthenticator", false);
[jira] [Updated] (CASSANDRA-9738) Migrate key-cache to be fully off-heap
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-9738: -- Assignee: Robert Stupp (was: Ariel Weisberg) > Migrate key-cache to be fully off-heap > -- > > Key: CASSANDRA-9738 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9738 > Project: Cassandra > Issue Type: Sub-task >Reporter: Robert Stupp >Assignee: Robert Stupp > Fix For: 3.0 beta 2 > > > Key cache still uses a concurrent map on-heap. This could go to off-heap and > feels doable now after CASSANDRA-8099. > Evaluation should be done in advance based on a POC to prove that pure > off-heap counter cache buys a performance and/or gc-pressure improvement. > In theory, elimination of on-heap management of the map should buy us some > benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9928) Add Support for multiple non-primary key columns in Materialized View primary keys
[ https://issues.apache.org/jira/browse/CASSANDRA-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723695#comment-14723695 ] Joel Knighton commented on CASSANDRA-9928: -- Guaranteeing a quorum of nodes will see the updates does not solve the problem because supporting multiple non-primary key columns in the materialized view primary key introduces a sensitivity to the ordering of updates to these non-primary key columns. I think this is the simplest version of Benedict's example. Envision a cluster with a table with primary key P and columns A and B. Presently, all replicas contain an entry for P=1, A=1, B=1. Two concurrent updates are occurring - one setting A=2, and one setting B=2. One replica receives the update B=2, removes the MV entry for P=1, A=1, B=1, creates an MV entry for P=1, A=1, B=2, and then crashes with data loss. The remainder of the base replicas receive the update A=2; remove the MV entry for P=1, A=1, B=1; create an MV entry for P=1, A=2, B=1; receive the update B=2; remove the MV entry for P=1, A=2, B=1; and create an MV entry for P=1, A=2, B=2. Upon repairing the data lost base replica from the remaining base replicas, a delete for the entry P=1, A=1, B=2 in the paired replica will never be created. > Add Support for multiple non-primary key columns in Materialized View primary > keys > -- > > Key: CASSANDRA-9928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9928 > Project: Cassandra > Issue Type: Improvement >Reporter: T Jake Luciani > Labels: materializedviews > Fix For: 3.x > > > Currently we don't allow > 1 non primary key from the base table in a MV > primary key. We should remove this restriction assuming we continue > filtering out nulls. With allowing nulls in the MV columns there are a lot > of multiplicative implications we need to think through. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/6] cassandra git commit: Defer initialization of default RoleManager until IAuthenticator is set reviewed by jbellis for CASSANDRA-10209
Repository: cassandra
Updated Branches:
refs/heads/cassandra-2.2 c870adc2f -> 0d2f4038f
refs/heads/cassandra-3.0 0828e2499 -> 3bc585d5d
refs/heads/trunk ae7afb7a8 -> 5d0c6ef77
Defer initialization of default RoleManager until IAuthenticator is set
reviewed by jbellis for CASSANDRA-10209
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0d2f4038
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0d2f4038
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0d2f4038
Branch: refs/heads/cassandra-2.2
Commit: 0d2f4038fc2564c695d0d8c4b1ad523ec1afaceb
Parents: c870adc
Author: Sam Tunnicliffe
Authored: Thu Aug 27 20:21:17 2015 +0100
Committer: Jonathan Ellis
Committed: Mon Aug 31 12:04:01 2015 -0500
--
.../org/apache/cassandra/config/DatabaseDescriptor.java | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/0d2f4038/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
--
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index b7e3eaa..9cf3959 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -87,7 +87,9 @@ public class DatabaseDescriptor
private static IAuthenticator authenticator = new AllowAllAuthenticator();
private static IAuthorizer authorizer = new AllowAllAuthorizer();
-private static IRoleManager roleManager = new CassandraRoleManager();
+// Don't initialize the role manager until applying config. The options
supported by CassandraRoleManager
+// depend on the configured IAuthenticator, so defer creating it until
that's been set.
+private static IRoleManager roleManager;
private static IRequestScheduler requestScheduler;
private static RequestSchedulerId requestSchedulerId;
@@ -323,8 +325,9 @@ public class DatabaseDescriptor
if (authenticator instanceof AllowAllAuthenticator && !(authorizer
instanceof AllowAllAuthorizer))
throw new ConfigurationException("AllowAllAuthenticator can't be
used with " + conf.authorizer, false);
-if (conf.role_manager != null)
-roleManager = FBUtilities.newRoleManager(conf.role_manager);
+roleManager = conf.role_manager == null
+? new CassandraRoleManager()
+: FBUtilities.newRoleManager(conf.role_manager);
if (authenticator instanceof PasswordAuthenticator && !(roleManager
instanceof CassandraRoleManager))
throw new ConfigurationException("CassandraRoleManager must be
used with PasswordAuthenticator", false);
[jira] [Commented] (CASSANDRA-9928) Add Support for multiple non-primary key columns in Materialized View primary keys
[ https://issues.apache.org/jira/browse/CASSANDRA-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723703#comment-14723703 ] T Jake Luciani commented on CASSANDRA-9928: --- of course! thx. > Add Support for multiple non-primary key columns in Materialized View primary > keys > -- > > Key: CASSANDRA-9928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9928 > Project: Cassandra > Issue Type: Improvement >Reporter: T Jake Luciani > Labels: materializedviews > Fix For: 3.x > > > Currently we don't allow > 1 non primary key from the base table in a MV > primary key. We should remove this restriction assuming we continue > filtering out nulls. With allowing nulls in the MV columns there are a lot > of multiplicative implications we need to think through. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (CASSANDRA-9738) Migrate key-cache to be fully off-heap
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg reassigned CASSANDRA-9738: - Assignee: Ariel Weisberg (was: Robert Stupp) > Migrate key-cache to be fully off-heap > -- > > Key: CASSANDRA-9738 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9738 > Project: Cassandra > Issue Type: Sub-task >Reporter: Robert Stupp >Assignee: Ariel Weisberg > Fix For: 3.0 beta 2 > > > Key cache still uses a concurrent map on-heap. This could go to off-heap and > feels doable now after CASSANDRA-8099. > Evaluation should be done in advance based on a POC to prove that pure > off-heap counter cache buys a performance and/or gc-pressure improvement. > In theory, elimination of on-heap management of the map should buy us some > benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[5/6] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3bc585d5 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3bc585d5 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3bc585d5 Branch: refs/heads/cassandra-3.0 Commit: 3bc585d5d0e01dd4f855994add67d3d120857eec Parents: 0828e24 0d2f403 Author: Jonathan Ellis Authored: Mon Aug 31 12:04:44 2015 -0500 Committer: Jonathan Ellis Committed: Mon Aug 31 12:04:44 2015 -0500 -- .../org/apache/cassandra/config/DatabaseDescriptor.java | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/3bc585d5/src/java/org/apache/cassandra/config/DatabaseDescriptor.java --
[6/6] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/5d0c6ef7 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/5d0c6ef7 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/5d0c6ef7 Branch: refs/heads/trunk Commit: 5d0c6ef77461b6b6b488be445c22062e0aa9b936 Parents: ae7afb7 3bc585d Author: Jonathan Ellis Authored: Mon Aug 31 12:04:51 2015 -0500 Committer: Jonathan Ellis Committed: Mon Aug 31 12:04:51 2015 -0500 -- .../org/apache/cassandra/config/DatabaseDescriptor.java | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/5d0c6ef7/src/java/org/apache/cassandra/config/DatabaseDescriptor.java --
[3/6] cassandra git commit: Defer initialization of default RoleManager until IAuthenticator is set reviewed by jbellis for CASSANDRA-10209
Defer initialization of default RoleManager until IAuthenticator is set
reviewed by jbellis for CASSANDRA-10209
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0d2f4038
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0d2f4038
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0d2f4038
Branch: refs/heads/trunk
Commit: 0d2f4038fc2564c695d0d8c4b1ad523ec1afaceb
Parents: c870adc
Author: Sam Tunnicliffe
Authored: Thu Aug 27 20:21:17 2015 +0100
Committer: Jonathan Ellis
Committed: Mon Aug 31 12:04:01 2015 -0500
--
.../org/apache/cassandra/config/DatabaseDescriptor.java | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/0d2f4038/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
--
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index b7e3eaa..9cf3959 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -87,7 +87,9 @@ public class DatabaseDescriptor
private static IAuthenticator authenticator = new AllowAllAuthenticator();
private static IAuthorizer authorizer = new AllowAllAuthorizer();
-private static IRoleManager roleManager = new CassandraRoleManager();
+// Don't initialize the role manager until applying config. The options
supported by CassandraRoleManager
+// depend on the configured IAuthenticator, so defer creating it until
that's been set.
+private static IRoleManager roleManager;
private static IRequestScheduler requestScheduler;
private static RequestSchedulerId requestSchedulerId;
@@ -323,8 +325,9 @@ public class DatabaseDescriptor
if (authenticator instanceof AllowAllAuthenticator && !(authorizer
instanceof AllowAllAuthorizer))
throw new ConfigurationException("AllowAllAuthenticator can't be
used with " + conf.authorizer, false);
-if (conf.role_manager != null)
-roleManager = FBUtilities.newRoleManager(conf.role_manager);
+roleManager = conf.role_manager == null
+? new CassandraRoleManager()
+: FBUtilities.newRoleManager(conf.role_manager);
if (authenticator instanceof PasswordAuthenticator && !(roleManager
instanceof CassandraRoleManager))
throw new ConfigurationException("CassandraRoleManager must be
used with PasswordAuthenticator", false);
[jira] [Commented] (CASSANDRA-9071) CQLSSTableWriter gives java.lang.AssertionError: Empty partition
[ https://issues.apache.org/jira/browse/CASSANDRA-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723693#comment-14723693 ] Dana Powers commented on CASSANDRA-9071: Are there any plans to backport this patch to the 2.0 branch ? > CQLSSTableWriter gives java.lang.AssertionError: Empty partition > > > Key: CASSANDRA-9071 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9071 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: java 7 / 8 > cassandra 2.1.3 snapshot build locally with last commit > https://github.com/apache/cassandra/commit/6ee4b0989d9a3ae3e704918622024fa57fdf63e7 > macos Yosemite 10.10.2 >Reporter: Ajit Joglekar >Assignee: Fabien Rousseau > Fix For: 2.1.6 > > Attachments: EmailWriter.java, Screen Shot 2015-04-15 at 11.14.40 > PM.png, cassandra-2.1-9071.txt, data.csv.gz > > > I am always getting the following error: > Exception in thread "main" java.lang.AssertionError: Empty partition > at > org.apache.cassandra.io.sstable.SSTableSimpleUnsortedWriter$DiskWriter.run(SSTableSimpleUnsortedWriter.java:228) > It happens at a certain point that seems to be repeatable. Only issue is I am > converting 400 million records into multiple SSTables and creating small test > is a challenge > Last comment from Benedict looks relevant here > https://issues.apache.org/jira/browse/CASSANDRA-8619 > Is there a work around, quick fix, fix that I can try out locally? > Thanks, > -Ajit -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10232) Small optimizations in index entry serialization
[ https://issues.apache.org/jira/browse/CASSANDRA-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-10232: --- Reviewer: Ariel Weisberg [~aweisberg] to review > Small optimizations in index entry serialization > > > Key: CASSANDRA-10232 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10232 > Project: Cassandra > Issue Type: Improvement >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne > Fix For: 3.0.0 rc1 > > > While we should improve the data structure we use for our on-disk index in > future versions, it occurred to me that we had a few _very_ low hanging fruit > optimization (as in, for 3.0) we could do for the serialization of our > current entries, like using vint encodings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9839) Move crc_check_chance out of compressions options
[ https://issues.apache.org/jira/browse/CASSANDRA-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-9839: -- Assignee: Paulo Motta (was: Sam Tunnicliffe) > Move crc_check_chance out of compressions options > - > > Key: CASSANDRA-9839 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9839 > Project: Cassandra > Issue Type: Bug >Reporter: Aleksey Yeschenko >Assignee: Paulo Motta >Priority: Minor > Labels: client-impacting, docs-impacting > Fix For: 3.0.0 rc1 > > > Follow up to CASSANDRA-8384. The option doesn't belong to compression params > - it doesn't affect compression, itself, and isn't passed to compressors upon > initialization. > While it's true that it is (currently) only being honored when reading > compressed sstables, it still doesn't belong to compression params (and is > causing CASSANDRA-7978 -like issues). > [~tjake] suggested we should make it an option of its own, and I think we > should. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10215) Reduce redundant secondary index selection lookups
[
https://issues.apache.org/jira/browse/CASSANDRA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723651#comment-14723651
]
T Jake Luciani commented on CASSANDRA-10215:
Overall looks good.
- Why use a UUID vs just passing the name? Since the UUID is basically the
MD5 of the name? is it to have a fixed length of key-space and index name?
For debugging purposes it would be clearer to have the name send in case you
have a schema disagreement and you can see what index it's looking for. The
exception log in deserializeIndexMetadata would ideally have the name. I think
you should make that message clearer as to what just happened.
- Why do you have IndexMetadata in the constructor of the read command when
it's always passing Optional.empty() in the code?
> Reduce redundant secondary index selection lookups
> --
>
> Key: CASSANDRA-10215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10215
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
> Fix For: 3.0.0 rc1
>
>
> Once an index has been identified as being the one that should be used for a
> given query, it should be included as part of the {{ReadCommand}} so that it
> can be retrieved when needed during execution. Currently we don't do this,
> meaning that the index selection process implemented in
> {{SIM::getBestIndexFor}} is run multiple times on both the coordinator and
> each replica when performing a range command.
> This is also a pre-requisite of CASSANDRA-10214
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10232) Small optimizations in index entry serialization
[ https://issues.apache.org/jira/browse/CASSANDRA-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723648#comment-14723648 ] Sylvain Lebresne commented on CASSANDRA-10232: -- Pushed [a branch|https://github.com/pcmanus/cassandra/commits/10232] that implements the following changes: # The 1st commit uses vint encoding for index entries. This should give quite a few benefits in itself since we store things like each index entry width as a 8 byte long while t will almost always is around 64k. Or we use a 4 byte int for the number of entries which is likely often smallish. # The 2nd commit get rid of the offset in each index entry. Indeed, keep both the offset (from the row start) and the width of each entry is a bit redundant: we can recompute one with the other. And since the width will yield a better vint encoding, the patch removes the offset. We do need to add for each indexed partition the size of the "partition header", but that's a single (small) value for each partition and since we don't index unless we have at least 2 block, this will always be a net win. # The 3rd commit is not a serialization improvement but just a minor cleanup that avoid re-creating serializer objects every time we need them. # The 4th and last commit is a small improvement over the 1st one: it uses 64k as a base to delta-encode each entry width (since by definition each entry will be just slightly bigger than 64k). The patch actually hard-code 64k even though users can theoretically change the index size, but that's because I didn't saw a trivial way to save the actual index size used alongside each index file and I want to keep the patch on this ticket simple enough to write/review so they can make it in 3.0. Happy to skip that commit if someone has an allergic reaction to the hard-coded number however. All those changes should be simple and quick to review so hopefully we can get those in 3.0 quickly. At the very very least, the 1st commit is trivial and there is no reason not to include it imo. > Small optimizations in index entry serialization > > > Key: CASSANDRA-10232 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10232 > Project: Cassandra > Issue Type: Improvement >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne > Fix For: 3.0.0 rc1 > > > While we should improve the data structure we use for our on-disk index in > future versions, it occurred to me that we had a few _very_ low hanging fruit > optimization (as in, for 3.0) we could do for the serialization of our > current entries, like using vint encodings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-10232) Small optimizations in index entry serialization
Sylvain Lebresne created CASSANDRA-10232: Summary: Small optimizations in index entry serialization Key: CASSANDRA-10232 URL: https://issues.apache.org/jira/browse/CASSANDRA-10232 Project: Cassandra Issue Type: Improvement Reporter: Sylvain Lebresne Assignee: Sylvain Lebresne Fix For: 3.0.0 rc1 While we should improve the data structure we use for our on-disk index in future versions, it occurred to me that we had a few _very_ low hanging fruit optimization (as in, for 3.0) we could do for the serialization of our current entries, like using vint encodings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9554) Avoid digest mismatch storm on upgrade to 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723641#comment-14723641
]
Branimir Lambov commented on CASSANDRA-9554:
Thank you, the new test looks great.
Nit in [the addRowDeletion
comment|https://github.com/pcmanus/cassandra/commit/e0699a4451980d1b568e3e0ec960851b7d58ad4c#diff-79b0ff76cc67b62a0d7947248e60c379R152]:
s/use to/used to/
+1, commit when cassci's happy.
> Avoid digest mismatch storm on upgrade to 3.0
> -
>
> Key: CASSANDRA-9554
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9554
> Project: Cassandra
> Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Sylvain Lebresne
> Labels: upgrade
> Fix For: 3.0 beta 2
>
>
> CASSANDRA-8099, in {{UnfilteredRowIterators.digest()}}:
> {code}
> // TODO: we're not computing digest the same way that old nodes. This
> // means we'll have digest mismatches during upgrade. We should pass
> the messaging version of
> // the node this is for (which might mean computing the digest last,
> and won't work
> // for schema (where we announce the version through gossip to
> everyone))
> {code}
> In a mixed 2.1(2.2) - 3.0 clusters, we need to calculate both digest at the
> same time and keep both results, and send the appropriate one, depending on
> receiving nodes' messaging versions. Do that until
> {{MessagingService.allNodesAtLeast30()}} is true (this is not unprecedented).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10210) Windows utest 3.0: org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable
[
https://issues.apache.org/jira/browse/CASSANDRA-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723638#comment-14723638
]
Paulo Motta commented on CASSANDRA-10210:
-
bq. While I think the patch will fix the utest issue my fear is that there's
actually something wrong w/the code-base on Windows that this utest is
uncovering
+1, since I cannot reproduce it locally while it fails quite consistenly on CI,
I propose we commit this workaround temporarily without resolving the issue to
confirm/deny the hypothesis of JVM bug, and based on the results we can perform
a more detailed investigation against a) and b).
> Windows utest 3.0:
> org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable
> -
>
> Key: CASSANDRA-10210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10210
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Philip Thompson
>Assignee: Paulo Motta
> Labels: Windows
> Fix For: 3.0.x
>
>
> {{org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable}}
> is failing on 3.0-head. See
> http://cassci.datastax.com/job/cassandra-3.0_utest_win32/29/testReport/
> Stack trace is
> {code}
> FSWriteError in
> D:\temp\1440702015716-0\SSTableLoaderTest\Standard2\ma-1-big-Data.db
> at
> org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:136)
> at
> org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:153)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:440)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:436)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:436)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:436)
> at
> org.apache.cassandra.io.sstable.SSTableLoaderTest.cleanup(SSTableLoaderTest.java:83)
> Caused by: java.nio.file.AccessDeniedException:
> D:\temp\1440702015716-0\SSTableLoaderTest\Standard2\ma-1-big-Data.db
> at
> sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
> at
> sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
> at
> sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
> at java.nio.file.Files.delete(Files.java:1126)
> at
> org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:130)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10226) Support multiple non-PK cols in MV clustering key when partition key is shared
[ https://issues.apache.org/jira/browse/CASSANDRA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723636#comment-14723636 ] T Jake Luciani commented on CASSANDRA-10226: Also, how is this any different than a secondary index? > Support multiple non-PK cols in MV clustering key when partition key is shared > -- > > Key: CASSANDRA-10226 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10226 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Labels: materializedviews > Fix For: 3.0.0 rc1 > > > This issue is similar to CASSANDRA-9928, but with one key limitation: the MV > partition key must match the base table's partition key. This limitation > results in the base replica always pairing with itself as the MV replica. > Because of this pairing, if the base replica is lost, any MV rows that would > otherwise be ambiguous are also lost. This allows us to avoid the problem > described in 9928 of not knowing which MV row to delete. > Although this limitation has the potential to be a bit confusing for users, I > believe this improvement is still worthwhile because: > * The base table's partition key will often be a good choice for the MV > partition key as well. I expect it to be common for users to partition data > the same way, but use a different clustering order to optimize for (or allow > for) different queries. > * It may take a long time to solve the problems presented in 9928 in general > (if we can solve them at all). On the other hand, this is straightforward > and is a significant improvement to the usability of MVs. > I have a minimal prototype of this that works well, so I should be able to > upload a patch with thorough tests within the next few days. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-10227) Can't accept remote connections using VirtualBox host-only adapter (Windows 10).
[ https://issues.apache.org/jira/browse/CASSANDRA-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua McKenzie resolved CASSANDRA-10227. - Resolution: Not A Problem Localhost functioning (or not functioning) on Windows 10 in conjunction with Virtualbox isn't a Cassandra issue. Along with that, the latest update on the linked virtualbox ticket (now closed) implies it was a configuration issue on your end: bq. You have 192.168.10.200 configured as an address for both host and guest. Closing as Not a Problem. > Can't accept remote connections using VirtualBox host-only adapter (Windows > 10). > > > Key: CASSANDRA-10227 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10227 > Project: Cassandra > Issue Type: Bug >Reporter: Paul Knopf > > Before I begin, I have created a simple project that reproduces this issue. > It uses Vagrant (1.7.4) to dynamically setup the box for each network adapter. > > https://bitbucket.org/theonlylawislove/cassandrahostonlyadapter/commits/tag/network-host-only > - Not working > > https://bitbucket.org/theonlylawislove/cassandrahostonlyadapter/commits/tag/network-public > - Working > Check out each tag, then run "vagrant up". This will setup the VM. Then run > CassandraTest.exe on the host machine to test remote access. The "public > network" vm works with remote access, but the "host-only network" does not. > Within each VM (ssh), I can succesfully connect to the IP (either host-only > or public) using cqlsh. So, Cassandra is setup and configured properly. > I also added the VM logs for using both the public network adapter, and the > host-only adapter. > Any guidance on this issue would be greatly appreciated. > I would like to add that I have successfully used other applications with > host-only adapter on Windows 10, such as Redis and Postgres. There is > something unique about Cassandra, and I am honestly not smart enough to > figure it out. Something is definitely broken though :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10227) Can't accept remote connections using VirtualBox host-only adapter (Windows 10).
[ https://issues.apache.org/jira/browse/CASSANDRA-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua McKenzie updated CASSANDRA-10227: Summary: Can't accept remote connections using VirtualBox host-only adapter (Windows 10). (was: Can't accept remove connections using VirtualBox host-only adapter (Windows 10).) > Can't accept remote connections using VirtualBox host-only adapter (Windows > 10). > > > Key: CASSANDRA-10227 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10227 > Project: Cassandra > Issue Type: Bug >Reporter: Paul Knopf > > Before I begin, I have created a simple project that reproduces this issue. > It uses Vagrant (1.7.4) to dynamically setup the box for each network adapter. > > https://bitbucket.org/theonlylawislove/cassandrahostonlyadapter/commits/tag/network-host-only > - Not working > > https://bitbucket.org/theonlylawislove/cassandrahostonlyadapter/commits/tag/network-public > - Working > Check out each tag, then run "vagrant up". This will setup the VM. Then run > CassandraTest.exe on the host machine to test remote access. The "public > network" vm works with remote access, but the "host-only network" does not. > Within each VM (ssh), I can succesfully connect to the IP (either host-only > or public) using cqlsh. So, Cassandra is setup and configured properly. > I also added the VM logs for using both the public network adapter, and the > host-only adapter. > Any guidance on this issue would be greatly appreciated. > I would like to add that I have successfully used other applications with > host-only adapter on Windows 10, such as Redis and Postgres. There is > something unique about Cassandra, and I am honestly not smart enough to > figure it out. Something is definitely broken though :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9881) Rows with negative-sized keys can't be skipped by sstablescrub
[
https://issues.apache.org/jira/browse/CASSANDRA-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723570#comment-14723570
]
Jonathan Ellis commented on CASSANDRA-9881:
---
Is this still a problem post 8099? /cc [~slebresne]
> Rows with negative-sized keys can't be skipped by sstablescrub
> --
>
> Key: CASSANDRA-9881
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9881
> Project: Cassandra
> Issue Type: Bug
> Components: Core
>Reporter: Brandon Williams
>Assignee: Stefania
>Priority: Minor
> Fix For: 2.1.x
>
>
> It is possible to have corruption in such a way that scrub (on or offline)
> can't skip the row, so you end up in a loop where this just keeps repeating:
> {noformat}
> WARNING: Row starting at position 2087453 is unreadable; skipping to next
> Reading row at 2087453
> row (unreadable key) is -1 bytes
> {noformat}
> The workaround is to just delete the problem sstable since you were going to
> have to repair anyway, but it would still be nice to salvage the rest of the
> sstable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9103) Multi-dc topology seems inadequately tested
[ https://issues.apache.org/jira/browse/CASSANDRA-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-9103: -- Assignee: (was: Stefania) > Multi-dc topology seems inadequately tested > --- > > Key: CASSANDRA-9103 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9103 > Project: Cassandra > Issue Type: Test >Reporter: Ariel Weisberg > > The only test we found was multidc_putget_test which is minimal. > Validate some core set of behaviors in a multi-dc topology and validate > supported operations against a multi-dc topology (adding DCs, removing DCs) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-6680) Clock skew detection via gossip
[ https://issues.apache.org/jira/browse/CASSANDRA-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-6680: -- Assignee: (was: Stefania) > Clock skew detection via gossip > --- > > Key: CASSANDRA-6680 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6680 > Project: Cassandra > Issue Type: New Feature > Components: Core >Reporter: Brandon Williams >Priority: Minor > Fix For: 3.x > > > Gossip's HeartbeatState keeps the generation (local timestamp the node was > started) and version (monotonically increasing per gossip interval) which > could be used to roughly calculate the node's current time, enabling > detection of gossip messages too far in the future for the clocks to be > synced. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9391) Test coverage for all supported protocol versions
[ https://issues.apache.org/jira/browse/CASSANDRA-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-9391: -- Assignee: (was: Stefania) > Test coverage for all supported protocol versions > - > > Key: CASSANDRA-9391 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9391 > Project: Cassandra > Issue Type: Test > Components: Tests >Reporter: Tyler Hobbs > > In CASSANDRA-7807 we accidentally broke registering for TOPOLOGY, STATUS, and > SCHEMA events through the v1 protocol, but no C* tests caught this. > We need to test all supported messages, flags, and options for the native > protocol versions that we support. The dtests are probably the best place > for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10231) Null status entries on nodes that crash during decommission of a different node
[ https://issues.apache.org/jira/browse/CASSANDRA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-10231: --- Fix Version/s: 3.0.x > Null status entries on nodes that crash during decommission of a different > node > --- > > Key: CASSANDRA-10231 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10231 > Project: Cassandra > Issue Type: Bug >Reporter: Joel Knighton >Assignee: Stefania > Fix For: 3.0.x > > > This issue is reproducible through a Jepsen test of materialized views that > crashes and decommissions nodes throughout the test. > In a 5 node cluster, if a node crashes at a certain point (unknown) during > the decommission of a different node, it may start with a null entry for the > decommissioned node like so: > DN 10.0.0.5 ? 256 ? null rack1 > This entry does not get updated/cleared by gossip. This entry is removed upon > a restart of the affected node. > This issue is further detailed in ticket > [10068|https://issues.apache.org/jira/browse/CASSANDRA-10068]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10226) Support multiple non-PK cols in MV clustering key when partition key is shared
[ https://issues.apache.org/jira/browse/CASSANDRA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723563#comment-14723563 ] T Jake Luciani commented on CASSANDRA-10226: I follow your reasoning. I'm assuming you will continue to filter out nulls? > Support multiple non-PK cols in MV clustering key when partition key is shared > -- > > Key: CASSANDRA-10226 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10226 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Labels: materializedviews > Fix For: 3.0.0 rc1 > > > This issue is similar to CASSANDRA-9928, but with one key limitation: the MV > partition key must match the base table's partition key. This limitation > results in the base replica always pairing with itself as the MV replica. > Because of this pairing, if the base replica is lost, any MV rows that would > otherwise be ambiguous are also lost. This allows us to avoid the problem > described in 9928 of not knowing which MV row to delete. > Although this limitation has the potential to be a bit confusing for users, I > believe this improvement is still worthwhile because: > * The base table's partition key will often be a good choice for the MV > partition key as well. I expect it to be common for users to partition data > the same way, but use a different clustering order to optimize for (or allow > for) different queries. > * It may take a long time to solve the problems presented in 9928 in general > (if we can solve them at all). On the other hand, this is straightforward > and is a significant improvement to the usability of MVs. > I have a minimal prototype of this that works well, so I should be able to > upload a patch with thorough tests within the next few days. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10231) Null status entries on nodes that crash during decommission of a different node
[ https://issues.apache.org/jira/browse/CASSANDRA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-10231: --- Assignee: Stefania > Null status entries on nodes that crash during decommission of a different > node > --- > > Key: CASSANDRA-10231 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10231 > Project: Cassandra > Issue Type: Bug >Reporter: Joel Knighton >Assignee: Stefania > > This issue is reproducible through a Jepsen test of materialized views that > crashes and decommissions nodes throughout the test. > In a 5 node cluster, if a node crashes at a certain point (unknown) during > the decommission of a different node, it may start with a null entry for the > decommissioned node like so: > DN 10.0.0.5 ? 256 ? null rack1 > This entry does not get updated/cleared by gossip. This entry is removed upon > a restart of the affected node. > This issue is further detailed in ticket > [10068|https://issues.apache.org/jira/browse/CASSANDRA-10068]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9928) Add Support for multiple non-primary key columns in Materialized View primary keys
[ https://issues.apache.org/jira/browse/CASSANDRA-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723556#comment-14723556 ] T Jake Luciani commented on CASSANDRA-9928: --- This scenario where 3 nodes won't see each others updates can't happen if we use the coordinator batchlog, since we guarantee at least a quorum of nodes will see the updates. Mentioning this for CASSANDRA-10230 > Add Support for multiple non-primary key columns in Materialized View primary > keys > -- > > Key: CASSANDRA-9928 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9928 > Project: Cassandra > Issue Type: Improvement >Reporter: T Jake Luciani > Labels: materializedviews > Fix For: 3.x > > > Currently we don't allow > 1 non primary key from the base table in a MV > primary key. We should remove this restriction assuming we continue > filtering out nulls. With allowing nulls in the MV columns there are a lot > of multiplicative implications we need to think through. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-10231) Null status entries on nodes that crash during decommission of a different node
Joel Knighton created CASSANDRA-10231: - Summary: Null status entries on nodes that crash during decommission of a different node Key: CASSANDRA-10231 URL: https://issues.apache.org/jira/browse/CASSANDRA-10231 Project: Cassandra Issue Type: Bug Reporter: Joel Knighton This issue is reproducible through a Jepsen test of materialized views that crashes and decommissions nodes throughout the test. In a 5 node cluster, if a node crashes at a certain point (unknown) during the decommission of a different node, it may start with a null entry for the decommissioned node like so: DN 10.0.0.5 ? 256 ? null rack1 This entry does not get updated/cleared by gossip. This entry is removed upon a restart of the affected node. This issue is further detailed in ticket [10068|https://issues.apache.org/jira/browse/CASSANDRA-10068]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10068) Batchlog replay fails with exception after a node is decommissioned
[ https://issues.apache.org/jira/browse/CASSANDRA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723544#comment-14723544 ] Joel Knighton commented on CASSANDRA-10068: --- [10231|https://issues.apache.org/jira/browse/CASSANDRA-10231] is a follow-up for the status bug. > Batchlog replay fails with exception after a node is decommissioned > --- > > Key: CASSANDRA-10068 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10068 > Project: Cassandra > Issue Type: Bug >Reporter: Joel Knighton >Assignee: Branimir Lambov > Attachments: n1.log, n2.log, n3.log, n4.log, n5.log > > > This issue is reproducible through a Jepsen test of materialized views that > crashes and decommissions nodes throughout the test. > At the conclusion of the test, a batchlog replay is initiated through > nodetool and hits the following assertion due to a missing host ID: > https://github.com/apache/cassandra/blob/3413e557b95d9448b0311954e9b4f53eaf4758cd/src/java/org/apache/cassandra/service/StorageProxy.java#L1197 > A nodetool status on the node with failed batchlog replay shows the following > entry for the decommissioned node: > DN 10.0.0.5 ? 256 ? null > rack1 > On the unaffected nodes, there is no entry for the decommissioned node as > expected. > There are occasional hits of the same assertions for logs in other nodes; it > looks like the issue might occasionally resolve itself, but one node seems to > have the errant null entry indefinitely. > In logs for the nodes, this possibly unrelated exception also appears: > java.lang.RuntimeException: Trying to get the view natural endpoint on a > non-data replica > at > org.apache.cassandra.db.view.MaterializedViewUtils.getViewNaturalEndpoint(MaterializedViewUtils.java:91) > ~[apache-cassandra-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT] > I have a running cluster with the issue on my machine; it is also repeatable. > Nothing stands out in the logs of the decommissioned node (n4) for me. The > logs of each node in the cluster are attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9554) Avoid digest mismatch storm on upgrade to 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723540#comment-14723540
]
Sylvain Lebresne commented on CASSANDRA-9554:
-
You're right of course.
I've push a few additional commits on [my
branch|https://github.com/pcmanus/cassandra/commits/9554]. It makes
{{PartitionTest.testDigest}} run on the legacy format (even though that test
isn't all that useful) and more importantly adds backward compatibility tests
against values computed on 2.2 as suggested. There is also 3 other "fix"
commits:
* the first one remove the "local deletion time" from the digest computation on
3.0 nodes. This one isn't really a bug nor a problem for backward
compatibility, but as the name implies, the "local deletion time" is meant to
be a local information (even though it's in practice assigned by the
coordinator and thus common to all replica, and that's why this wasn't a
problem) and if "feels" better to not use it in digests. This is also more
consistent with the old way to during things (we don't include it in pre-3.0
digets).
* the second one makes it so that deletion of a row on a compact table is done
through the insertion of a cell tombstone. As explained by the comment in the
commit, that's more consistent with the old way of doing this, and is easier
than to deal with that in both thrift and the backward compatibility code
(which we weren't doing properly).
* the thirft one fix minor errors in the legacy digest computation.
CI tests are ongoing but will be at
[utests|http://cassci.datastax.com/job/pcmanus-9554-testall/2/] and
[dtests|http://cassci.datastax.com/job/pcmanus-9554-dtest/2/].
> Avoid digest mismatch storm on upgrade to 3.0
> -
>
> Key: CASSANDRA-9554
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9554
> Project: Cassandra
> Issue Type: Bug
>Reporter: Aleksey Yeschenko
>Assignee: Sylvain Lebresne
> Labels: upgrade
> Fix For: 3.0 beta 2
>
>
> CASSANDRA-8099, in {{UnfilteredRowIterators.digest()}}:
> {code}
> // TODO: we're not computing digest the same way that old nodes. This
> // means we'll have digest mismatches during upgrade. We should pass
> the messaging version of
> // the node this is for (which might mean computing the digest last,
> and won't work
> // for schema (where we announce the version through gossip to
> everyone))
> {code}
> In a mixed 2.1(2.2) - 3.0 clusters, we need to calculate both digest at the
> same time and keep both results, and send the appropriate one, depending on
> receiving nodes' messaging versions. Do that until
> {{MessagingService.allNodesAtLeast30()}} is true (this is not unprecedented).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CASSANDRA-10230) Remove coordinator batchlog from materialized views
T Jake Luciani created CASSANDRA-10230:
--
Summary: Remove coordinator batchlog from materialized views
Key: CASSANDRA-10230
URL: https://issues.apache.org/jira/browse/CASSANDRA-10230
Project: Cassandra
Issue Type: Bug
Reporter: T Jake Luciani
Assignee: Joel Knighton
Fix For: 3.0.x
We are considering removing or making optional the coordinator batchlog.
The batchlog primary serves as a way to quickly reach consistency between base
and view since we don't have any kind of read repair between base and view. But
we do have repair so as long as you don't lose nodes while writing at CL.ONE
you will be eventually consistent.
I've committed to the 3.0 branch a way to disable the coordinator with
{{-Dcassandra.mv_disable_coordinator_batchlog=true}}
The majority of the performance hit to throughput is currently the batchlog as
shown by this chart.
http://cstar.datastax.com/graph?stats=f794245a-4d9d-11e5-9def-42010af0688f&metric=op_rate&operation=1_user&smoothing=1&show_aggregates=true&xmin=0&xmax=498.52&ymin=0&ymax=50142.4
I'd like to have tests run with and without this flag to validate how quickly
we achieve quorum consistency without repair writing with CL.ONE. Once we can
see there is little/no impact we can permanently remove the coordinator
batchlog.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10230) Remove coordinator batchlog from materialized views
[
https://issues.apache.org/jira/browse/CASSANDRA-10230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
T Jake Luciani updated CASSANDRA-10230:
---
Issue Type: Improvement (was: Bug)
> Remove coordinator batchlog from materialized views
> ---
>
> Key: CASSANDRA-10230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10230
> Project: Cassandra
> Issue Type: Improvement
>Reporter: T Jake Luciani
>Assignee: Joel Knighton
> Fix For: 3.0.x
>
>
> We are considering removing or making optional the coordinator batchlog.
> The batchlog primary serves as a way to quickly reach consistency between
> base and view since we don't have any kind of read repair between base and
> view. But we do have repair so as long as you don't lose nodes while writing
> at CL.ONE you will be eventually consistent.
> I've committed to the 3.0 branch a way to disable the coordinator with
> {{-Dcassandra.mv_disable_coordinator_batchlog=true}}
> The majority of the performance hit to throughput is currently the batchlog
> as shown by this chart.
> http://cstar.datastax.com/graph?stats=f794245a-4d9d-11e5-9def-42010af0688f&metric=op_rate&operation=1_user&smoothing=1&show_aggregates=true&xmin=0&xmax=498.52&ymin=0&ymax=50142.4
> I'd like to have tests run with and without this flag to validate how quickly
> we achieve quorum consistency without repair writing with CL.ONE. Once we
> can see there is little/no impact we can permanently remove the coordinator
> batchlog.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723526#comment-14723526 ] Joshua McKenzie commented on CASSANDRA-8630: While I don't expect this to cause any problems on Windows from a cursory skimming of the patch, it might be worth running a utest/dtest combo job against the platform just to be sure given how picky the platform is about timing on DirectBuffer unmapping etc. > Faster sequential IO (on compaction, streaming, etc) > > > Key: CASSANDRA-8630 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8630 > Project: Cassandra > Issue Type: Improvement > Components: Core, Tools >Reporter: Oleg Anastasyev >Assignee: Stefania > Labels: compaction, performance > Fix For: 3.x > > Attachments: 8630-FasterSequencialReadsAndWrites.txt, cpu_load.png, > flight_recorder_001_files.tar.gz, flight_recorder_002_files.tar.gz, > mmaped_uncomp_hotspot.png > > > When node is doing a lot of sequencial IO (streaming, compacting, etc) a lot > of CPU is lost in calls to RAF's int read() and DataOutputStream's write(int). > This is because default implementations of readShort,readLong, etc as well as > their matching write* are implemented with numerous calls of byte by byte > read and write. > This makes a lot of syscalls as well. > A quick microbench shows than just reimplementation of these methods in > either way gives 8x speed increase. > A patch attached implements RandomAccessReader.read and > SequencialWriter.write methods in more efficient way. > I also eliminated some extra byte copies in CompositeType.split and > ColumnNameHelper.maxComponents, which were on my profiler's hotspot method > list during tests. > A stress tests on my laptop show that this patch makes compaction 25-30% > faster on uncompressed sstables and 15% faster for compressed ones. > A deployment to production shows much less CPU load for compaction. > (I attached a cpu load graph from one of our production, orange is niced CPU > load - i.e. compaction; yellow is user - i.e. not compaction related tasks) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9242) Add PerfDisableSharedMem to default JVM params
[ https://issues.apache.org/jira/browse/CASSANDRA-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723525#comment-14723525 ] Ariel Weisberg commented on CASSANDRA-9242: --- DSE will be updated to work with PerfDisableSharedMem or come with it off by default. You don't need to have this flag enabled to run C* and have it work well. We are aware this impacts other tools like jps and mission control and documented it in [CASSANDRA-9483|https://issues.apache.org/jira/browse/CASSANDRA-9483]. > Add PerfDisableSharedMem to default JVM params > -- > > Key: CASSANDRA-9242 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9242 > Project: Cassandra > Issue Type: Improvement > Components: Config >Reporter: Matt Stump >Assignee: Ariel Weisberg > Fix For: 2.2.0 beta 1 > > > We should add PerfDisableSharedMem to default JVM params. The JVM will save > stats to a memory mapped file when reaching a safepoint. This is performed > synchronously and the JVM remains paused while this action takes place. > Occasionally the OS will stall the calling thread while this happens > resulting in significant impact to worst case JVM pauses. By disabling the > save in the JVM these mysterious multi-second pauses disappear. > The behavior is outlined in [this > article|http://www.evanjones.ca/jvm-mmap-pause.html]. Another manifestation > is significant time spent in sys during GC pauses. In [the linked > test|http://cstar.datastax.com/graph?stats=762d9c2a-eace-11e4-8236-42010af0688f&metric=gc_max_ms&operation=1_write&smoothing=1&show_aggregates=true&xmin=0&xmax=110.77&ymin=0&ymax=10421.4] > you'll notice multiple seconds spent in sys during the longest pauses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10210) Windows utest 3.0: org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable
[
https://issues.apache.org/jira/browse/CASSANDRA-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723523#comment-14723523
]
Joshua McKenzie commented on CASSANDRA-10210:
-
Is it possible we have a latent bug in the system where either a) we forgot to
unmap a direct buffer or b) we're keeping a direct buffer around for recycling
and it's going to bite us in the ass on Windows in the future? While I think
the patch will fix the utest issue my fear is that there's actually something
wrong w/the code-base on Windows that this utest is uncovering
> Windows utest 3.0:
> org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable
> -
>
> Key: CASSANDRA-10210
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10210
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Philip Thompson
>Assignee: Paulo Motta
> Labels: Windows
> Fix For: 3.0.x
>
>
> {{org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable}}
> is failing on 3.0-head. See
> http://cassci.datastax.com/job/cassandra-3.0_utest_win32/29/testReport/
> Stack trace is
> {code}
> FSWriteError in
> D:\temp\1440702015716-0\SSTableLoaderTest\Standard2\ma-1-big-Data.db
> at
> org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:136)
> at
> org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:153)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:440)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:436)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:436)
> at
> org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:436)
> at
> org.apache.cassandra.io.sstable.SSTableLoaderTest.cleanup(SSTableLoaderTest.java:83)
> Caused by: java.nio.file.AccessDeniedException:
> D:\temp\1440702015716-0\SSTableLoaderTest\Standard2\ma-1-big-Data.db
> at
> sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
> at
> sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
> at
> sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
> at java.nio.file.Files.delete(Files.java:1126)
> at
> org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:130)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
