[jira] [Comment Edited] (CASSANDRA-10421) Potential issue with LogTransaction as it only checks in a single directory for files
[ https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952746#comment-14952746 ] Benedict edited comment on CASSANDRA-10421 at 10/12/15 7:33 AM: FTR, IMO (as I expressed on IRC), I think it is both safer and easier to implement duplication to all disks. Since this data is low traffic it also shouldn't be a major issue that we do this: Implementation-wise, the changes can be extremely minimal to the existing logic: on read, we read all files simultaneously, line-by-line, corroborating they are the same (we can even have a special reader that wraps all files, so that the current logic is completely unchanged). If at any point they differ, we confirm there is no proceeding line (if there is we leave everything as is, as it is corruption, much like we normally would), and otherwise we confirm that every file's last line is a prefix-match of every other. On write we can do similar, ensuring we write to all of them in sequence, treating it as a single action from the POV of the existing logic. This means the only modifications are at the very outermost parts of the logic, so we don't have to revisit the safety of the basic functionality. This also leaves us with much less complexity reasoning about the safety under different scenarios wrt disk corruption, failure, accidental user-error, etc. So, it seems like a win-win AFAICT. The only downside is that users modifying these files would need to modify them all, but this is not overly onerous. (I will note I'm not convinced it _cannot_ be done safely with separate disks, just that it's going to be fiddlier, and I haven't had time to consider it beyond that) was (Author: benedict): FTR, IMO (as I expressed on IRC), I think it is both safer and easier to implement duplication to all disks. Since this data is low traffic it also shouldn't be a major issue that we do this: Implementation-wise, the changes can be extremely minimal to the existing logic: on read, we read all files simultaneously, line-by-line, corroborating they are the same (we can even have a special reader that wraps all files, so that the current logic is completely unchanged). If at any point they differ, we confirm there is no proceeding line (if there is we leave everything as is, as it is corruption, much like we normally would), and otherwise we confirm that every file's last line is a prefix-match of every other. On write we can do similar, ensuring we write to all of them in sequence, treating it as a single action from the POV of the existing logic. This means the only modifications are at the very outermost parts of the logic, so we don't have to revisit the safety of the basic functionality. This also leaves us with much less complexity reasoning about the safety under different scenarios wrt disk corruption, failure, accidental user-error, etc. So, it seems like a win-win AFAICT. The only downside is that users modifying these files would need to modify them all, but this is not overly onerous. > Potential issue with LogTransaction as it only checks in a single directory > for files > - > > Key: CASSANDRA-10421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10421 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Stefania >Priority: Blocker > Fix For: 3.0.0 rc2 > > > When creating a new LogTransaction we try to create the new logfile in the > same directory as the one we are writing to, but as we use > {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}} > this might end up in "any" of the configured data directories. If it does, > we will not be able to clean up leftovers as we check for files in the same > directory as the logfile was created: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163 > cc [~Stefania] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-10478) Seek position is not within mmap segment
[ https://issues.apache.org/jira/browse/CASSANDRA-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict resolved CASSANDRA-10478. -- Resolution: Fixed Fix Version/s: (was: 2.2.x) (was: 2.1.x) 2.1.11 2.2.3 Committed as f87e34ed3c82a7b0b73178a6ce565a1227a7457b > Seek position is not within mmap segment > > > Key: CASSANDRA-10478 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10478 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Cassandra 2.2.2 > Java 1.8.0.60 >Reporter: Omri Iluz >Assignee: Benedict >Priority: Critical > Fix For: 2.2.3, 2.1.11 > > > After upgrading to 2.2.2 we started seeing timeouts accompanied by the > following error in the log. Disabling mmap (by using "disk_access_mode: > standard") completely solves the problem. > We did not experience this problem in 2.2.1. > The change to src/java/org/apache/cassandra/io/util/ByteBufferDataInput.java > in the following commit seems interesting as it changes the calculation of > the mmap boundaries (and moves from <= to <) > https://github.com/apache/cassandra/commit/25de92e321604626d6c098233082904832c07814 > > {noformat} > WARN [SharedPool-Worker-1] 2015-10-07 03:40:39,771 > AbstractTracingAwareExecutorService.java:169 - Uncaught exception on thread > Thread[SharedPool-Worker-1,5,main]: {} > java.lang.RuntimeException: > org.apache.cassandra.io.sstable.CorruptSSTableException: java.io.IOException: > Seek position 717680 is not within mmap segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2187) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_60] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [apache-cassandra-2.2.2.jar:2.2.2] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60] > Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException: > java.io.IOException: Seek position 717680 is not within mmap segment (seg > offs: 0, length: 717680) > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.getPosition(BigTableReader.java:250) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.SSTableReader.getPosition(SSTableReader.java:1558) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.SSTableSliceIterator.(SSTableSliceIterator.java:42) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:75) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:246) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:62) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:270) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:64) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:2004) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1808) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.db.Keyspace.getRow(Keyspace.java:360) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.SliceFromReadCommand.getRow(SliceFromReadCommand.java:85) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1537) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2183) > ~[apache-cassandra-2.2.2.jar:2.2.2] > ... 4 common frames omitted > Caused by: java.io.IOException: Seek position 717680 is not within mmap > segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.io.util.ByteBufferDataInput.seek(ByteBufferDataInput.java:47) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.util.AbstractDataInput.skipBytes(AbstractDataInput.java:33) > ~[apache-cassandra-2.2.2.jar:2.2.2] >
[jira] [Commented] (CASSANDRA-10421) Potential issue with LogTransaction as it only checks in a single directory for files
[ https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952746#comment-14952746 ] Benedict commented on CASSANDRA-10421: -- FTR, IMO (as I expressed on IRC), I think it is both safer and easier to implement duplication to all disks. Since this data is low traffic it also shouldn't be a major issue that we do this: Implementation-wise, the changes can be extremely minimal to the existing logic: on read, we read all files simultaneously, line-by-line, corroborating they are the same (we can even have a special reader that wraps all files, so that the current logic is completely unchanged). If at any point they differ, we confirm there is no proceeding line (if there is we leave everything as is, as it is corruption, much like we normally would), and otherwise we confirm that every file's last line is a prefix-match of every other. On write we can do similar, ensuring we write to all of them in sequence, treating it as a single action from the POV of the existing logic. This means the only modifications are at the very outermost parts of the logic, so we don't have to revisit the safety of the basic functionality. This also leaves us with much less complexity reasoning about the safety under different scenarios wrt disk corruption, failure, accidental user-error, etc. So, it seems like a win-win AFAICT. The only downside is that users modifying these files would need to modify them all, but this is not overly onerous. > Potential issue with LogTransaction as it only checks in a single directory > for files > - > > Key: CASSANDRA-10421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10421 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Stefania >Priority: Blocker > Fix For: 3.0.0 rc2 > > > When creating a new LogTransaction we try to create the new logfile in the > same directory as the one we are writing to, but as we use > {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}} > this might end up in "any" of the configured data directories. If it does, > we will not be able to clean up leftovers as we check for files in the same > directory as the logfile was created: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163 > cc [~Stefania] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/2] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/16f29aac Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/16f29aac Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/16f29aac Branch: refs/heads/trunk Commit: 16f29aac9f43a126573cfa22e99a78348c4207ea Parents: 739de13 50fae5d Author: Marcus ErikssonAuthored: Mon Oct 12 08:28:35 2015 +0200 Committer: Marcus Eriksson Committed: Mon Oct 12 08:28:35 2015 +0200 -- src/java/org/apache/cassandra/db/SystemKeyspace.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --
cassandra git commit: Force blocking flush of peers when removing endpoint.
Repository: cassandra Updated Branches: refs/heads/cassandra-3.0 fc92c9621 -> 50fae5df1 Force blocking flush of peers when removing endpoint. Patch by Joel Knighton; reviewed by Stefania for CASSANDRA-10231 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/50fae5df Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/50fae5df Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/50fae5df Branch: refs/heads/cassandra-3.0 Commit: 50fae5df193a41c77a5b02a84c9350226eccaf9f Parents: fc92c96 Author: Joel KnightonAuthored: Thu Oct 8 18:35:13 2015 -0500 Committer: Marcus Eriksson Committed: Mon Oct 12 08:26:09 2015 +0200 -- src/java/org/apache/cassandra/db/SystemKeyspace.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/50fae5df/src/java/org/apache/cassandra/db/SystemKeyspace.java -- diff --git a/src/java/org/apache/cassandra/db/SystemKeyspace.java b/src/java/org/apache/cassandra/db/SystemKeyspace.java index 689a33d..6112869 100644 --- a/src/java/org/apache/cassandra/db/SystemKeyspace.java +++ b/src/java/org/apache/cassandra/db/SystemKeyspace.java @@ -690,10 +690,7 @@ public final class SystemKeyspace public static synchronized void updateTokens(InetAddress ep, Collection tokens) { if (ep.equals(FBUtilities.getBroadcastAddress())) -{ -removeEndpoint(ep); return; -} String req = "INSERT INTO system.%s (peer, tokens) VALUES (?, ?)"; executeInternal(String.format(req, PEERS), ep, tokensAsSet(tokens)); @@ -755,6 +752,7 @@ public final class SystemKeyspace { String req = "DELETE FROM system.%s WHERE peer = ?"; executeInternal(String.format(req, PEERS), ep); +forceBlockingFlush(PEERS); } /**
[1/2] cassandra git commit: Force blocking flush of peers when removing endpoint.
Repository: cassandra Updated Branches: refs/heads/trunk 739de136d -> 16f29aac9 Force blocking flush of peers when removing endpoint. Patch by Joel Knighton; reviewed by Stefania for CASSANDRA-10231 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/50fae5df Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/50fae5df Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/50fae5df Branch: refs/heads/trunk Commit: 50fae5df193a41c77a5b02a84c9350226eccaf9f Parents: fc92c96 Author: Joel KnightonAuthored: Thu Oct 8 18:35:13 2015 -0500 Committer: Marcus Eriksson Committed: Mon Oct 12 08:26:09 2015 +0200 -- src/java/org/apache/cassandra/db/SystemKeyspace.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/50fae5df/src/java/org/apache/cassandra/db/SystemKeyspace.java -- diff --git a/src/java/org/apache/cassandra/db/SystemKeyspace.java b/src/java/org/apache/cassandra/db/SystemKeyspace.java index 689a33d..6112869 100644 --- a/src/java/org/apache/cassandra/db/SystemKeyspace.java +++ b/src/java/org/apache/cassandra/db/SystemKeyspace.java @@ -690,10 +690,7 @@ public final class SystemKeyspace public static synchronized void updateTokens(InetAddress ep, Collection tokens) { if (ep.equals(FBUtilities.getBroadcastAddress())) -{ -removeEndpoint(ep); return; -} String req = "INSERT INTO system.%s (peer, tokens) VALUES (?, ?)"; executeInternal(String.format(req, PEERS), ep, tokensAsSet(tokens)); @@ -755,6 +752,7 @@ public final class SystemKeyspace { String req = "DELETE FROM system.%s WHERE peer = ?"; executeInternal(String.format(req, PEERS), ep); +forceBlockingFlush(PEERS); } /**
[jira] [Commented] (CASSANDRA-10365) Consider storing types by their CQL names in schema tables instead of fully-qualified internal class names
[ https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952785#comment-14952785 ] Sylvain Lebresne commented on CASSANDRA-10365: -- bq. I think it is doable, but if keeping both is possible, it'd make the driver upgrades that much easier. I certainly understand that argument, but the fully-qualified class names are also leaking implementation details, namely which concrete classes are used server side. On the long term, removing that leakage is probably a good idea and might allow some cleanups of type classes at some point, and since we've redone the whole schema table, that sounds like a good time to do so. So while I understand this is a bit more work for the drivers (mostly, you'd have to either make sure you're up-to-date on types before querying columns, or resolve the types you don't know about by querying afterwards), I do feel that not conserving the fqcn version in new tables is the right thing to do. > Consider storing types by their CQL names in schema tables instead of > fully-qualified internal class names > -- > > Key: CASSANDRA-10365 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10365 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko > Labels: client-impacting > Fix For: 3.0.0 rc2 > > > Consider saving CQL types names for column, UDF/UDA arguments and return > types, and UDT components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-10427) compactionstats 'completed' field not updating
[ https://issues.apache.org/jira/browse/CASSANDRA-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson resolved CASSANDRA-10427. - Resolution: Fixed created CASSANDRA-10504 for the tests > compactionstats 'completed' field not updating > -- > > Key: CASSANDRA-10427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10427 > Project: Cassandra > Issue Type: Bug >Reporter: T Jake Luciani >Assignee: Marcus Eriksson >Priority: Critical > Fix For: 3.0.0 rc2 > > > nodetool compactionstats is no longer showing any change to completed field > or progress. > Can be reproduced with: > * Start cassandra > * Run stress write > * run nodetool flush followed by nodetool compactionstats > {code} > ➜ cassandra git:(cassandra-3.0) ✗ ./bin/nodetool flush > ➜ cassandra git:(cassandra-3.0) ✗ ./bin/nodetool compactionstats > pending tasks: 1 > id compaction typekeyspace > table completed totalunit progress >75609a20-67a8-11e5-8003-c909ff7fd15eCompaction keyspace1 > standard1 0 350132121 bytes 0.00% > Active compaction remaining time : 0h00m20s > ➜ cassandra git:(cassandra-3.0) ✗ ./bin/nodetool compactionstats > pending tasks: 1 > id compaction typekeyspace > table completed totalunit progress >75609a20-67a8-11e5-8003-c909ff7fd15eCompaction keyspace1 > standard1 0 350132121 bytes 0.00% > Active compaction remaining time : 0h00m20s > ➜ cassandra git:(cassandra-3.0) ✗ ./bin/nodetool compactionstats > pending tasks: 1 > id compaction typekeyspace > table completed totalunit progress >75609a20-67a8-11e5-8003-c909ff7fd15eCompaction keyspace1 > standard1 0 350132121 bytes 0.00% > Active compaction remaining time : 0h00m20s > ➜ cassandra git:(cassandra-3.0) ✗ ./bin/nodetool compactionstats > pending tasks: 1 > id compaction typekeyspace > table completed totalunit progress >75609a20-67a8-11e5-8003-c909ff7fd15eCompaction keyspace1 > standard1 0 350132121 bytes 0.00% > Active compaction remaining time : 0h00m20s > ➜ cassandra git:(cassandra-3.0) ✗ ./bin/nodetool compactionstats > pending tasks: 0 > ➜ cassandra git:(cassandra-3.0) ✗ > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-10504) Create tests for compactionstats
Marcus Eriksson created CASSANDRA-10504: --- Summary: Create tests for compactionstats Key: CASSANDRA-10504 URL: https://issues.apache.org/jira/browse/CASSANDRA-10504 Project: Cassandra Issue Type: Improvement Reporter: Marcus Eriksson Assignee: Philip Thompson Fix For: 3.x, 2.1.x, 2.2.x Creating a new ticket for compactionstats tests to avoid confusion regarding release versions etc, see CASSANDRA-10427 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10421) Potential issue with LogTransaction as it only checks in a single directory for files
[ https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952941#comment-14952941 ] Benedict commented on CASSANDRA-10421: -- bq. It doesn't however change the fact that we write more and have therefore more chances of failing to do so Right. This isn't exposing us to anything too terrible though, really, since this clearly should be infrequent or there are bigger problems. If there is a disk failure it is quite reasonable to mark the disk as unavailable and start again (from scratch)\*. bq. Unless you meant to not store the relative file path (the path of an sstable relative to a txn file), Yes, I think now it is probably best to store the full path (or, if we wanted to be helpful, the relative path to the common ancestor of all data disks) bq. To be clear, we would roll back the transaction if we failed to write a record to any file except for the last record, where we could tolerate failures provided we have written to at least one file? That's how I would do it, yes, as it has the most semantic consistency. With one addendum: on restart, I would consider *any* incomplete (or missing) final records to be the same as our current incomplete final record behaviour. i.e. we enter paranoid mode and make sure all of the files are present. If they aren't, we leave them all, just in case. This means we leave some extra duplicate data in disk in some cases during a restart when we had some temporary disk problems, but that's a fine tradeoff for simplicity and safety in my book, since these should be rare scenarios, and are clearly scenarios of hardware issues, in which paranoia is probably best. This does technically break the semantic consistency argument on restart, but I think acceptably. \* It may be that we could detect disk failure here and also retain more data, but it is highly unlikely this complexity would pay dividends given the window of effect, and the per-disk vnode allocations coming in the near future. > Potential issue with LogTransaction as it only checks in a single directory > for files > - > > Key: CASSANDRA-10421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10421 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Stefania >Priority: Blocker > Fix For: 3.0.0 rc2 > > > When creating a new LogTransaction we try to create the new logfile in the > same directory as the one we are writing to, but as we use > {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}} > this might end up in "any" of the configured data directories. If it does, > we will not be able to clean up leftovers as we check for files in the same > directory as the logfile was created: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163 > cc [~Stefania] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10264) Unable to use conditions on static columns for DELETE
[ https://issues.apache.org/jira/browse/CASSANDRA-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952843#comment-14952843 ] Sylvain Lebresne commented on CASSANDRA-10264: -- On the cqlsh change, I think the new code now exclude "IF x = 3" ({{}} doesn't support only {{=}} as far as I can tell). On the CQL changes, I believe the changes work, but they don't feel very intuitive to me as it stands. As far as I can tell, we're checking that the operations are not empty because in the case of a {{DELETE}}, no operations means we have a {{DELETE FROM ...}}, that is we're deleting all columns implicitely. But I don't think this is entirely clear from the code so this deserve a comment but I would also feel more comfortable if we were guarding the 'operations not empty' check by whether the statement is a {{DELETE}} as having 'no operations' for an {{INSERT}} doesn't mean the same thing. In fact, on 3.0, I'd find it more intuitive to move the logic inside {{Operations}}. Namely, I'd change {{Operations.appliesToRegularColumns()}} to be: {noformat} public boolean appliesToRegularColumns() { // If we have regular operations, this applies to regular columns. // Otherwise, if the statement is a DELETE and staticOperations is also empty, this means we have no operations, // which for a DELETE means a full row deletion. Which means the operation applies to all columns and regular ones in particular. return !regularOperations.isEmpty() || (statementType == StatementType.DELETE && staticOperations.isEmpty()); } {noformat} which require to feed the {{StatemenType}} to the {{Operations}} ctor, but that's easy enough. > Unable to use conditions on static columns for DELETE > - > > Key: CASSANDRA-10264 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10264 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Cassandra 2.2.0 >Reporter: DOAN DuyHai >Assignee: Benjamin Lerer > Attachments: 10264-2.1.txt, 10264-3.0.txt > > > {noformat} > cqlsh:test> create table static_table(id int, stat int static, ord int, val > text, primary key(id,ord)); > cqlsh:test> insert into static_table (id,stat,ord,val) VALUES ( 1, 1, 1, '1'); > cqlsh:test> delete from static_table where id=1 and ord=1 if stat != 1; > Invalid syntax at line 1, char 55 > delete from static_table where id=1 and ord=1 if stat != 1; > ^ > {noformat} > Same error if using =, <, <=, >= or > condition > According to [~thobbs] the syntax should work. Plus, the error message is > wrong -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10377) AssertionError: attempted to delete non-existing file CommitLog
[ https://issues.apache.org/jira/browse/CASSANDRA-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952859#comment-14952859 ] Branimir Lambov commented on CASSANDRA-10377: - I think this is a good solution; any new code trying to delete an active segment will go through {{recycleSegment}} and will also be protected by the atomicity of the {{activeSegments}} queue. +1 to commit. > AssertionError: attempted to delete non-existing file CommitLog > --- > > Key: CASSANDRA-10377 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10377 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: CentOS 7.1/x64 >Reporter: Vovodroid >Priority: Critical > Attachments: 10377.patch > > > After several hours of script tests (create and drop users, keyspaces and > tables) exception is thrown: > {code} > ERROR 02:58:39 Failed managing commit log segments. Commit disk failure > policy is stop; terminating thread > java.lang.AssertionError: attempted to delete non-existing file > CommitLog-5-1442599226756.log > at > org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:122) > ~[main/:na] > at > org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:149) > ~[main/:na] > at > org.apache.cassandra.db.commitlog.CommitLogSegment.discard(CommitLogSegment.java:314) > ~[main/:na] > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManager$2.run(CommitLogSegmentManager.java:374) > ~[main/:na] > at > org.apache.cassandra.db.commitlog.CommitLogSegmentManager$1.runMayThrow(CommitLogSegmentManager.java:155) > ~[main/:na] > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > [main/:na] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45] > {code} > I added some logs to *deleteWithConfirm* and it showed that this file really > was deleted by previous delete action, i.e. it was second attempt to delete > the same log. Commit log with next number exists in the same time, so log was > switched. > I disabled assert and it seems to have no no bad effect. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10372) Adds smallint and tinyint to the CQL documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-10372: --- Description: CASSANDRA-8951 added {{smallint}} and {{tinyint}} types but the CQL documentation was not updated. (was: CASSANDRA-8043 added {{smallint}} and {{tinyint}} types but the CQL documentation was not updated. ) > Adds smallint and tinyint to the CQL documentation > -- > > Key: CASSANDRA-10372 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10372 > Project: Cassandra > Issue Type: Bug >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Minor > Fix For: 2.2.x > > > CASSANDRA-8951 added {{smallint}} and {{tinyint}} types but the CQL > documentation was not updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10478) Seek position is not within mmap segment
[ https://issues.apache.org/jira/browse/CASSANDRA-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952919#comment-14952919 ] Christian Winther commented on CASSANDRA-10478: --- when will this be released as a binary ? we are hitting the same issue currently is there any workaround I can apply configuration wise? > Seek position is not within mmap segment > > > Key: CASSANDRA-10478 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10478 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Cassandra 2.2.2 > Java 1.8.0.60 >Reporter: Omri Iluz >Assignee: Benedict >Priority: Critical > Fix For: 2.2.3, 2.1.11 > > > After upgrading to 2.2.2 we started seeing timeouts accompanied by the > following error in the log. Disabling mmap (by using "disk_access_mode: > standard") completely solves the problem. > We did not experience this problem in 2.2.1. > The change to src/java/org/apache/cassandra/io/util/ByteBufferDataInput.java > in the following commit seems interesting as it changes the calculation of > the mmap boundaries (and moves from <= to <) > https://github.com/apache/cassandra/commit/25de92e321604626d6c098233082904832c07814 > > {noformat} > WARN [SharedPool-Worker-1] 2015-10-07 03:40:39,771 > AbstractTracingAwareExecutorService.java:169 - Uncaught exception on thread > Thread[SharedPool-Worker-1,5,main]: {} > java.lang.RuntimeException: > org.apache.cassandra.io.sstable.CorruptSSTableException: java.io.IOException: > Seek position 717680 is not within mmap segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2187) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_60] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [apache-cassandra-2.2.2.jar:2.2.2] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60] > Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException: > java.io.IOException: Seek position 717680 is not within mmap segment (seg > offs: 0, length: 717680) > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.getPosition(BigTableReader.java:250) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.SSTableReader.getPosition(SSTableReader.java:1558) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.SSTableSliceIterator.(SSTableSliceIterator.java:42) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:75) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:246) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:62) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:270) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:64) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:2004) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1808) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.db.Keyspace.getRow(Keyspace.java:360) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.SliceFromReadCommand.getRow(SliceFromReadCommand.java:85) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1537) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2183) > ~[apache-cassandra-2.2.2.jar:2.2.2] > ... 4 common frames omitted > Caused by: java.io.IOException: Seek position 717680 is not within mmap > segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.io.util.ByteBufferDataInput.seek(ByteBufferDataInput.java:47) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.util.AbstractDataInput.skipBytes(AbstractDataInput.java:33) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at
[jira] [Commented] (CASSANDRA-10478) Seek position is not within mmap segment
[ https://issues.apache.org/jira/browse/CASSANDRA-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952924#comment-14952924 ] Benedict commented on CASSANDRA-10478: -- It will be released very soon. Most likely in 2-3 days. You could switch to standard disk access mode until then. The problems being: this may result in lower throughput, and will also result in a rebuild of the summary files of all of your data on restart (and again when you flip back), which could be costly (i.e. startup will be slow). Strictly this could be avoided, with the same approach as CASSANDRA-10357, but this would take longer to deliver than just the new release. > Seek position is not within mmap segment > > > Key: CASSANDRA-10478 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10478 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Cassandra 2.2.2 > Java 1.8.0.60 >Reporter: Omri Iluz >Assignee: Benedict >Priority: Critical > Fix For: 2.2.3, 2.1.11 > > > After upgrading to 2.2.2 we started seeing timeouts accompanied by the > following error in the log. Disabling mmap (by using "disk_access_mode: > standard") completely solves the problem. > We did not experience this problem in 2.2.1. > The change to src/java/org/apache/cassandra/io/util/ByteBufferDataInput.java > in the following commit seems interesting as it changes the calculation of > the mmap boundaries (and moves from <= to <) > https://github.com/apache/cassandra/commit/25de92e321604626d6c098233082904832c07814 > > {noformat} > WARN [SharedPool-Worker-1] 2015-10-07 03:40:39,771 > AbstractTracingAwareExecutorService.java:169 - Uncaught exception on thread > Thread[SharedPool-Worker-1,5,main]: {} > java.lang.RuntimeException: > org.apache.cassandra.io.sstable.CorruptSSTableException: java.io.IOException: > Seek position 717680 is not within mmap segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2187) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_60] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [apache-cassandra-2.2.2.jar:2.2.2] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60] > Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException: > java.io.IOException: Seek position 717680 is not within mmap segment (seg > offs: 0, length: 717680) > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.getPosition(BigTableReader.java:250) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.SSTableReader.getPosition(SSTableReader.java:1558) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.SSTableSliceIterator.(SSTableSliceIterator.java:42) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:75) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:246) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:62) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:270) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:64) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:2004) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1808) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.db.Keyspace.getRow(Keyspace.java:360) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.SliceFromReadCommand.getRow(SliceFromReadCommand.java:85) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1537) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2183) > ~[apache-cassandra-2.2.2.jar:2.2.2] > ... 4 common frames omitted > Caused by: java.io.IOException: Seek position 717680 is not within
[jira] [Commented] (CASSANDRA-10421) Potential issue with LogTransaction as it only checks in a single directory for files
[ https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952923#comment-14952923 ] Stefania commented on CASSANDRA-10421: -- Thanks for explaining your opinion. The way you envision it, duplicating files does seem easier than segmenting files across disks. It doesn't however change the fact that we write more and have therefore more chances of failing to do so therefore having to roll back a transaction. bq. The only downside is that users modifying these files would need to modify them all, but this is not overly onerous. Users are not supposed to modify these files but if they did delete one txn file then they could be quite surprised to see temporary files disappear on startup because of a txn log in another folder. Especially given that we only list temporary files by looking at the local txn file. That was one of my concerns. Unless you meant to *not* store the relative file path (the path of an sstable relative to a txn file), in which case we would only be able to delete temporary files if the txn file in the sstable folder has not been deleted? To be clear, we would roll back the transaction if we failed to write a record to _any file_ except for the last record, where we could tolerate failures provided we have written to at least one file? > Potential issue with LogTransaction as it only checks in a single directory > for files > - > > Key: CASSANDRA-10421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10421 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Stefania >Priority: Blocker > Fix For: 3.0.0 rc2 > > > When creating a new LogTransaction we try to create the new logfile in the > same directory as the one we are writing to, but as we use > {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}} > this might end up in "any" of the configured data directories. If it does, > we will not be able to clean up leftovers as we check for files in the same > directory as the logfile was created: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163 > cc [~Stefania] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/6] cassandra git commit: Preserve case properly for quoted user/role names
Preserve case properly for quoted user/role names Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cccaa17e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cccaa17e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cccaa17e Branch: refs/heads/cassandra-3.0 Commit: cccaa17e1c20556afcaca78439d775ba0f15760a Parents: 3529284 Author: Sam TunnicliffeAuthored: Thu Sep 24 17:29:52 2015 +0100 Committer: Sam Tunnicliffe Committed: Mon Oct 12 11:56:31 2015 +0100 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/Cql.g | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/cccaa17e/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index ea0a2db..215bd76 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.2.3 + * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) Merged from 2.1: http://git-wip-us.apache.org/repos/asf/cassandra/blob/cccaa17e/src/java/org/apache/cassandra/cql3/Cql.g -- diff --git a/src/java/org/apache/cassandra/cql3/Cql.g b/src/java/org/apache/cassandra/cql3/Cql.g index ed10e77..b4cbac8 100644 --- a/src/java/org/apache/cassandra/cql3/Cql.g +++ b/src/java/org/apache/cassandra/cql3/Cql.g @@ -967,7 +967,7 @@ createUserStatement returns [CreateRoleStatement stmt] boolean ifNotExists = false; RoleName name = new RoleName(); } -: K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })? u=username { name.setName($u.text, false); } +: K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })? u=username { name.setName($u.text, true); } ( K_WITH userPassword[opts] )? ( K_SUPERUSER { superuser = true; } | K_NOSUPERUSER { superuser = false; } )? { opts.setOption(IRoleManager.Option.SUPERUSER, superuser); @@ -1162,7 +1162,7 @@ idxName[IndexName name] roleName[RoleName name] : t=IDENT { $name.setName($t.text, false); } -| s=STRING_LITERAL { $name.setName($s.text, false); } +| s=STRING_LITERAL { $name.setName($s.text, true); } | t=QUOTED_NAME{ $name.setName($t.text, true); } | k=unreserved_keyword { $name.setName(k, false); } | QMARK {addRecognitionError("Bind variables cannot be used for role names");}
[5/6] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b324759e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b324759e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b324759e Branch: refs/heads/cassandra-3.0 Commit: b324759eada2cb4b60e3894ecefb2b8071716d7a Parents: 50fae5d cccaa17 Author: Sam TunnicliffeAuthored: Mon Oct 12 12:00:34 2015 +0100 Committer: Sam Tunnicliffe Committed: Mon Oct 12 12:00:34 2015 +0100 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/Cql.g | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b324759e/CHANGES.txt -- diff --cc CHANGES.txt index fa74c69,215bd76..f40c12c --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,45 -1,25 +1,46 @@@ -2.2.3 +3.0 + * Only include modified cell data in indexing deltas (CASSANDRA-10438) + * Do not load keyspace when creating sstable writer (CASSANDRA-10443) + * If node is not yet gossiping write all MV updates to batchlog only (CASSANDRA-10413) + * Re-populate token metadata after commit log recovery (CASSANDRA-10293) + * Provide additional metrics for materialized views (CASSANDRA-10323) + * Flush system schema tables after local schema changes (CASSANDRA-10429) +Merged from 2.2: + * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) - * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) + * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) Merged from 2.1: - * Fix mmap file segment seeking to EOF (CASSANDRA-10478) * Allow LOCAL_JMX to be easily overridden (CASSANDRA-10275) * Mark nodes as dead even if they've already left (CASSANDRA-10205) - * Update internal python driver used by cqlsh (CASSANDRA-10161) -2.2.2 - * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) + +3.0.0-rc1 + * Fix mixed version read request compatibility for compact static tables + (CASSANDRA-10373) + * Fix paging of DISTINCT with static and IN (CASSANDRA-10354) + * Allow MATERIALIZED VIEW's SELECT statement to restrict primary key + columns (CASSANDRA-9664) + * Move crc_check_chance out of compression options (CASSANDRA-9839) + * Fix descending iteration past end of BTreeSearchIterator (CASSANDRA-10301) + * Transfer hints to a different node on decommission (CASSANDRA-10198) + * Check partition keys for CAS operations during stmt validation (CASSANDRA-10338) + * Add custom query expressions to SELECT (CASSANDRA-10217) + * Fix minor bugs in MV handling (CASSANDRA-10362) + * Allow custom indexes with 0,1 or multiple target columns (CASSANDRA-10124) + * Improve MV schema representation (CASSANDRA-9921) + * Add flag to enable/disable coordinator batchlog for MV writes (CASSANDRA-10230) + * Update cqlsh COPY for new internal driver serialization interface (CASSANDRA-10318) + * Give index implementations more control over rebuild operations (CASSANDRA-10312) + * Update index file format (CASSANDRA-10314) + * Add "shadowable" row tombstones to deal with mv timestamp issues (CASSANDRA-10261) + * CFS.loadNewSSTables() broken for pre-3.0 sstables + * Cache selected index in read command to reduce lookups (CASSANDRA-10215) + * Small optimizations of sstable index serialization (CASSANDRA-10232) + * Support for both encrypted and unencrypted native transport connections (CASSANDRA-9590) +Merged from 2.2: * Configurable page size in cqlsh (CASSANDRA-9855) * Defer default role manager setup until all nodes are on 2.2+ (CASSANDRA-9761) - * Cancel transaction for sstables we wont redistribute index summary - for (CASSANDRA-10270) - * Handle missing RoleManager in config after upgrade to 2.2 (CASSANDRA-10209) - * Retry snapshot deletion after compaction and gc on Windows (CASSANDRA-10222) - * Fix failure to start with space in directory path on Windows (CASSANDRA-10239) - * Fix repair hang when snapshot failed (CASSANDRA-10057) - * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks - (CASSANDRA-10199) + * Handle missing RoleManager in config after upgrade to 2.2 (CASSANDRA-10209) Merged from 2.1: * Bulk Loader API could not tolerate even node failure (CASSANDRA-10347) * Avoid misleading pushed notifications when multiple nodes http://git-wip-us.apache.org/repos/asf/cassandra/blob/b324759e/src/java/org/apache/cassandra/cql3/Cql.g --
[4/6] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b324759e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b324759e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b324759e Branch: refs/heads/trunk Commit: b324759eada2cb4b60e3894ecefb2b8071716d7a Parents: 50fae5d cccaa17 Author: Sam TunnicliffeAuthored: Mon Oct 12 12:00:34 2015 +0100 Committer: Sam Tunnicliffe Committed: Mon Oct 12 12:00:34 2015 +0100 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/Cql.g | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b324759e/CHANGES.txt -- diff --cc CHANGES.txt index fa74c69,215bd76..f40c12c --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,45 -1,25 +1,46 @@@ -2.2.3 +3.0 + * Only include modified cell data in indexing deltas (CASSANDRA-10438) + * Do not load keyspace when creating sstable writer (CASSANDRA-10443) + * If node is not yet gossiping write all MV updates to batchlog only (CASSANDRA-10413) + * Re-populate token metadata after commit log recovery (CASSANDRA-10293) + * Provide additional metrics for materialized views (CASSANDRA-10323) + * Flush system schema tables after local schema changes (CASSANDRA-10429) +Merged from 2.2: + * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) - * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) + * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) Merged from 2.1: - * Fix mmap file segment seeking to EOF (CASSANDRA-10478) * Allow LOCAL_JMX to be easily overridden (CASSANDRA-10275) * Mark nodes as dead even if they've already left (CASSANDRA-10205) - * Update internal python driver used by cqlsh (CASSANDRA-10161) -2.2.2 - * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) + +3.0.0-rc1 + * Fix mixed version read request compatibility for compact static tables + (CASSANDRA-10373) + * Fix paging of DISTINCT with static and IN (CASSANDRA-10354) + * Allow MATERIALIZED VIEW's SELECT statement to restrict primary key + columns (CASSANDRA-9664) + * Move crc_check_chance out of compression options (CASSANDRA-9839) + * Fix descending iteration past end of BTreeSearchIterator (CASSANDRA-10301) + * Transfer hints to a different node on decommission (CASSANDRA-10198) + * Check partition keys for CAS operations during stmt validation (CASSANDRA-10338) + * Add custom query expressions to SELECT (CASSANDRA-10217) + * Fix minor bugs in MV handling (CASSANDRA-10362) + * Allow custom indexes with 0,1 or multiple target columns (CASSANDRA-10124) + * Improve MV schema representation (CASSANDRA-9921) + * Add flag to enable/disable coordinator batchlog for MV writes (CASSANDRA-10230) + * Update cqlsh COPY for new internal driver serialization interface (CASSANDRA-10318) + * Give index implementations more control over rebuild operations (CASSANDRA-10312) + * Update index file format (CASSANDRA-10314) + * Add "shadowable" row tombstones to deal with mv timestamp issues (CASSANDRA-10261) + * CFS.loadNewSSTables() broken for pre-3.0 sstables + * Cache selected index in read command to reduce lookups (CASSANDRA-10215) + * Small optimizations of sstable index serialization (CASSANDRA-10232) + * Support for both encrypted and unencrypted native transport connections (CASSANDRA-9590) +Merged from 2.2: * Configurable page size in cqlsh (CASSANDRA-9855) * Defer default role manager setup until all nodes are on 2.2+ (CASSANDRA-9761) - * Cancel transaction for sstables we wont redistribute index summary - for (CASSANDRA-10270) - * Handle missing RoleManager in config after upgrade to 2.2 (CASSANDRA-10209) - * Retry snapshot deletion after compaction and gc on Windows (CASSANDRA-10222) - * Fix failure to start with space in directory path on Windows (CASSANDRA-10239) - * Fix repair hang when snapshot failed (CASSANDRA-10057) - * Fall back to 1/4 commitlog volume for commitlog_total_space on small disks - (CASSANDRA-10199) + * Handle missing RoleManager in config after upgrade to 2.2 (CASSANDRA-10209) Merged from 2.1: * Bulk Loader API could not tolerate even node failure (CASSANDRA-10347) * Avoid misleading pushed notifications when multiple nodes http://git-wip-us.apache.org/repos/asf/cassandra/blob/b324759e/src/java/org/apache/cassandra/cql3/Cql.g --
[6/6] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/87da74eb Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/87da74eb Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/87da74eb Branch: refs/heads/trunk Commit: 87da74eb543ff9ff3e6294a003a72d028ad720dd Parents: 16f29aa b324759 Author: Sam TunnicliffeAuthored: Mon Oct 12 12:00:56 2015 +0100 Committer: Sam Tunnicliffe Committed: Mon Oct 12 12:00:56 2015 +0100 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/Cql.g | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/87da74eb/CHANGES.txt --
[1/6] cassandra git commit: Preserve case properly for quoted user/role names
Repository: cassandra Updated Branches: refs/heads/cassandra-2.2 352928467 -> cccaa17e1 refs/heads/cassandra-3.0 50fae5df1 -> b324759ea refs/heads/trunk 16f29aac9 -> 87da74eb5 Preserve case properly for quoted user/role names Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cccaa17e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cccaa17e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cccaa17e Branch: refs/heads/cassandra-2.2 Commit: cccaa17e1c20556afcaca78439d775ba0f15760a Parents: 3529284 Author: Sam TunnicliffeAuthored: Thu Sep 24 17:29:52 2015 +0100 Committer: Sam Tunnicliffe Committed: Mon Oct 12 11:56:31 2015 +0100 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/Cql.g | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/cccaa17e/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index ea0a2db..215bd76 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.2.3 + * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) Merged from 2.1: http://git-wip-us.apache.org/repos/asf/cassandra/blob/cccaa17e/src/java/org/apache/cassandra/cql3/Cql.g -- diff --git a/src/java/org/apache/cassandra/cql3/Cql.g b/src/java/org/apache/cassandra/cql3/Cql.g index ed10e77..b4cbac8 100644 --- a/src/java/org/apache/cassandra/cql3/Cql.g +++ b/src/java/org/apache/cassandra/cql3/Cql.g @@ -967,7 +967,7 @@ createUserStatement returns [CreateRoleStatement stmt] boolean ifNotExists = false; RoleName name = new RoleName(); } -: K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })? u=username { name.setName($u.text, false); } +: K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })? u=username { name.setName($u.text, true); } ( K_WITH userPassword[opts] )? ( K_SUPERUSER { superuser = true; } | K_NOSUPERUSER { superuser = false; } )? { opts.setOption(IRoleManager.Option.SUPERUSER, superuser); @@ -1162,7 +1162,7 @@ idxName[IndexName name] roleName[RoleName name] : t=IDENT { $name.setName($t.text, false); } -| s=STRING_LITERAL { $name.setName($s.text, false); } +| s=STRING_LITERAL { $name.setName($s.text, true); } | t=QUOTED_NAME{ $name.setName($t.text, true); } | k=unreserved_keyword { $name.setName(k, false); } | QMARK {addRecognitionError("Bind variables cannot be used for role names");}
[3/6] cassandra git commit: Preserve case properly for quoted user/role names
Preserve case properly for quoted user/role names Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/cccaa17e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/cccaa17e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/cccaa17e Branch: refs/heads/trunk Commit: cccaa17e1c20556afcaca78439d775ba0f15760a Parents: 3529284 Author: Sam TunnicliffeAuthored: Thu Sep 24 17:29:52 2015 +0100 Committer: Sam Tunnicliffe Committed: Mon Oct 12 11:56:31 2015 +0100 -- CHANGES.txt | 1 + src/java/org/apache/cassandra/cql3/Cql.g | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/cccaa17e/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index ea0a2db..215bd76 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.2.3 + * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) Merged from 2.1: http://git-wip-us.apache.org/repos/asf/cassandra/blob/cccaa17e/src/java/org/apache/cassandra/cql3/Cql.g -- diff --git a/src/java/org/apache/cassandra/cql3/Cql.g b/src/java/org/apache/cassandra/cql3/Cql.g index ed10e77..b4cbac8 100644 --- a/src/java/org/apache/cassandra/cql3/Cql.g +++ b/src/java/org/apache/cassandra/cql3/Cql.g @@ -967,7 +967,7 @@ createUserStatement returns [CreateRoleStatement stmt] boolean ifNotExists = false; RoleName name = new RoleName(); } -: K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })? u=username { name.setName($u.text, false); } +: K_CREATE K_USER (K_IF K_NOT K_EXISTS { ifNotExists = true; })? u=username { name.setName($u.text, true); } ( K_WITH userPassword[opts] )? ( K_SUPERUSER { superuser = true; } | K_NOSUPERUSER { superuser = false; } )? { opts.setOption(IRoleManager.Option.SUPERUSER, superuser); @@ -1162,7 +1162,7 @@ idxName[IndexName name] roleName[RoleName name] : t=IDENT { $name.setName($t.text, false); } -| s=STRING_LITERAL { $name.setName($s.text, false); } +| s=STRING_LITERAL { $name.setName($s.text, true); } | t=QUOTED_NAME{ $name.setName($t.text, true); } | k=unreserved_keyword { $name.setName(k, false); } | QMARK {addRecognitionError("Bind variables cannot be used for role names");}
[jira] [Commented] (CASSANDRA-10505) Duplicate range tombstones
[ https://issues.apache.org/jira/browse/CASSANDRA-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953209#comment-14953209 ] Marcus Eriksson commented on CASSANDRA-10505: - it is likely CASSANDRA-7953 will fix the compaction issue atleast > Duplicate range tombstones > -- > > Key: CASSANDRA-10505 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10505 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Brandon Williams > Fix For: 2.1.x > > > I don't have a way to reproduce this just yet, but I have the sstables to > prove it and can provide those offline. What I can reproduce, however, is > the magnification of this problem via compaction. Here's what I know so far: > * under some condition, we flush the exact same RT more than once in the same > sstable. Same timestamps, everything. > * Once this happens in multiple sstables, compacting them causes the > duplication to grow. The more this occurs, the worse the problem gets. > This continues until gc_grace has passed, then they are all evicted normally. > I'd at least like to take a look at the compaction amplification for now, > that way if the condition does occur, at least compaction can help it, rather > than exacerbate it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9920) Consider making Materialized Views a schema target in events
[ https://issues.apache.org/jira/browse/CASSANDRA-9920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Holmberg updated CASSANDRA-9920: - Labels: client-impacting materializedviews native_protocol protocolv5 (was: client-impacting materializedviews) > Consider making Materialized Views a schema target in events > > > Key: CASSANDRA-9920 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9920 > Project: Cassandra > Issue Type: Sub-task >Reporter: Carl Yeksigian > Labels: client-impacting, materializedviews, native_protocol, > protocolv5 > Fix For: 3.x > > > Make views be a schema target like Tables and Types in protocol events, > rather than a property of Tables like 2i. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10452) Fix flapping resummable_bootstrap_test
[ https://issues.apache.org/jira/browse/CASSANDRA-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953215#comment-14953215 ] Andrew Hust commented on CASSANDRA-10452: - {{bootstrap_test.py:TestBootstrap.resumable_bootstrap_test}} and {{bootstrap_test.py:TestBootstrap.bootstrap_with_reset_bootstrap_state_test}} will consistently fail if jvm assertions are disabled. {{resumable_bootstrap_test}} will fail with this exception: {code} ERROR [main] 2015-10-12 09:21:58,088 CassandraDaemon.java:689 - Exception encountered during startup java.lang.IllegalStateException: No match found at java.util.regex.Matcher.group(Matcher.java:536) ~[na:1.8.0_60] at org.apache.cassandra.db.lifecycle.LogFile.make(LogFile.java:52) ~[main/:na] at org.apache.cassandra.db.lifecycle.LogTransaction.removeUnfinishedLeftovers(LogTransaction.java:399) ~[main/:na] at org.apache.cassandra.db.lifecycle.LifecycleTransaction.removeUnfinishedLeftovers(LifecycleTransaction.java:552) ~[main/:na] at org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:571) ~[main/:na] at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:239) [main/:na] at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:548) [main/:na] at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:676) [main/:na] {code} {{bootstrap_with_reset_bootstrap_state_test}} will fail with this exception: {code} ERROR [STREAM-IN-/127.0.0.1] 2015-10-12 09:26:04,777 StreamSession.java:520 - [Stream #8d0ebd40-70f5-11e5-92fe-517de766f243] Streaming error occurred java.io.EOFException: null at java.io.DataInputStream.readUnsignedShort(DataInputStream.java:340) ~[na:1.8.0_60] at org.apache.cassandra.utils.BytesReadTracker.readUnsignedShort(BytesReadTracker.java:142) ~[main/:na] at org.apache.cassandra.utils.ByteBufferUtil.readShortLength(ByteBufferUtil.java:366) ~[main/:na] at org.apache.cassandra.utils.ByteBufferUtil.readWithShortLength(ByteBufferUtil.java:376) ~[main/:na] at org.apache.cassandra.streaming.StreamReader$StreamDeserializer.newPartition(StreamReader.java:198) ~[main/:na] at org.apache.cassandra.streaming.StreamReader.writePartition(StreamReader.java:168) ~[main/:na] at org.apache.cassandra.streaming.StreamReader.read(StreamReader.java:109) ~[main/:na] at org.apache.cassandra.streaming.messages.IncomingFileMessage$1.deserialize(IncomingFileMessage.java:50) ~[main/:na] at org.apache.cassandra.streaming.messages.IncomingFileMessage$1.deserialize(IncomingFileMessage.java:39) ~[main/:na] at org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:59) ~[main/:na] at org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:261) ~[main/:na] at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60] {code} Ran against: apache/cassandra-3.0: {{345be2057383895f8d4c6b07a89357a0e87441be}} Ran with command: {{KEEP_LOGS=true JVM_EXTRA_OPTS=-da PRINT_DEBUG=true nosetests -xsv bootstrap_test.py:TestBootstrap.bootstrap_with_reset_bootstrap_state_test}} > Fix flapping resummable_bootstrap_test > -- > > Key: CASSANDRA-10452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10452 > Project: Cassandra > Issue Type: Sub-task >Reporter: Jim Witschey >Assignee: Yuki Morishita > Fix For: 3.0.0 rc2 > > > {{bootstrap_test.py:TestBootstrap.resumable_bootstrap_test}} has been > flapping on CassCI lately: > http://cassci.datastax.com/view/trunk/job/cassandra-3.0_dtest/lastCompletedBuild/testReport/bootstrap_test/TestBootstrap/resumable_bootstrap_test/history/ > I have not been able to reproduce on OpenStack. I'm assigning [~yukim] for > now, but feel free to reassign. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9126) java.lang.RuntimeException: Last written key DecoratedKey >= current key DecoratedKey
[ https://issues.apache.org/jira/browse/CASSANDRA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953225#comment-14953225 ] Jim Witschey commented on CASSANDRA-9126: - [~krummas] Ok, then, I'll close this -- you should reopen if there's more for us to do, but it sounds like you're satisfied? > java.lang.RuntimeException: Last written key DecoratedKey >= current key > DecoratedKey > - > > Key: CASSANDRA-9126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9126 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: srinivasu gottipati >Priority: Critical > Fix For: 2.1.x > > Attachments: cassandra-system.log > > > Cassandra V: 2.0.14, > Getting the following exceptions while trying to compact (I see this issue > was raised in earlier versions and marked as closed. However it still appears > in 2.0.14). In our case, compaction is not getting succeeded and keep failing > with this error.: > {code}java.lang.RuntimeException: Last written key > DecoratedKey(3462767860784856708, > 354038323137333038305f3330325f31355f474d4543454f) >= current key > DecoratedKey(3462334604624154281, > 354036333036353334315f3336315f31355f474d4543454f) writing into {code} > ... > Stacktrace:{code} > at > org.apache.cassandra.io.sstable.SSTableWriter.beforeAppend(SSTableWriter.java:143) > at > org.apache.cassandra.io.sstable.SSTableWriter.append(SSTableWriter.java:166) > at > org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:167) > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:60) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59) > at > org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:198) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745){code} > Any help is greatly appreciated -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10421) Potential issue with LogTransaction as it only checks in a single directory for files
[ https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953237#comment-14953237 ] Ariel Weisberg commented on CASSANDRA-10421: So if I understand the proposed action on restart is to retain all available files including the ones that have been newly created in the failed transaction and compact it later? If we can find a record that says a file should be added we know that it is theoretically complete. I don't know if it matters that the files wasn't completed or what happens if we try and load partial files. Since we support early opening can we retain partial files usefully? Or do we delete files that don't have some log record somewhere adding them? > Potential issue with LogTransaction as it only checks in a single directory > for files > - > > Key: CASSANDRA-10421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10421 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Stefania >Priority: Blocker > Fix For: 3.0.0 rc2 > > > When creating a new LogTransaction we try to create the new logfile in the > same directory as the one we are writing to, but as we use > {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}} > this might end up in "any" of the configured data directories. If it does, > we will not be able to clean up leftovers as we check for files in the same > directory as the logfile was created: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163 > cc [~Stefania] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10477) java.lang.AssertionError in StorageProxy.submitHint
[ https://issues.apache.org/jira/browse/CASSANDRA-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953262#comment-14953262 ] Philip Thompson commented on CASSANDRA-10477: - Once I find someone to work on this, they'll share their contact info with you. Thanks. > java.lang.AssertionError in StorageProxy.submitHint > --- > > Key: CASSANDRA-10477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10477 > Project: Cassandra > Issue Type: Bug > Environment: CentOS 6, Oracle JVM 1.8.45 >Reporter: Severin Leonhardt > Fix For: 2.1.x > > > A few days after updating from 2.0.15 to 2.1.9 we have the following log > entry on 2 of 5 machines: > {noformat} > ERROR [EXPIRING-MAP-REAPER:1] 2015-10-07 17:01:08,041 > CassandraDaemon.java:223 - Exception in thread > Thread[EXPIRING-MAP-REAPER:1,5,main] > java.lang.AssertionError: /192.168.11.88 > at > org.apache.cassandra.service.StorageProxy.submitHint(StorageProxy.java:949) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > org.apache.cassandra.net.MessagingService$5.apply(MessagingService.java:383) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > org.apache.cassandra.net.MessagingService$5.apply(MessagingService.java:363) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at org.apache.cassandra.utils.ExpiringMap$1.run(ExpiringMap.java:98) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor$UncomplainingRunnable.run(DebuggableScheduledThreadPoolExecutor.java:118) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > [na:1.8.0_45] > at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) > [na:1.8.0_45] > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > [na:1.8.0_45] > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) > [na:1.8.0_45] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > [na:1.8.0_45] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > [na:1.8.0_45] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45] > {noformat} > 192.168.11.88 is the broadcast address of the local machine. > When this is logged the read request latency of the whole cluster becomes > very bad, from 6 ms/op to more than 100 ms/op according to OpsCenter. Clients > get a lot of timeouts. We need to restart the affected Cassandra node to get > back normal read latencies. It seems write latency is not affected. > Disabling hinted handoff using {{nodetool disablehandoff}} only prevents the > assert from being logged. At some point the read latency becomes bad again. > Restarting the node where hinted handoff was disabled results in the read > latency being better again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10505) Duplicate range tombstones
[ https://issues.apache.org/jira/browse/CASSANDRA-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953229#comment-14953229 ] Brandon Williams commented on CASSANDRA-10505: -- I applied 7953v2 and forced a compaction to no avail. I should also note that you don't need multiple sstables to make the dupes grow, forcing a major on a single table is enough. > Duplicate range tombstones > -- > > Key: CASSANDRA-10505 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10505 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Brandon Williams > Fix For: 2.1.x > > > I don't have a way to reproduce this just yet, but I have the sstables to > prove it and can provide those offline. What I can reproduce, however, is > the magnification of this problem via compaction. Here's what I know so far: > * under some condition, we flush the exact same RT more than once in the same > sstable. Same timestamps, everything. > * Once this happens in multiple sstables, compacting them causes the > duplication to grow. The more this occurs, the worse the problem gets. > This continues until gc_grace has passed, then they are all evicted normally. > I'd at least like to take a look at the compaction amplification for now, > that way if the condition does occur, at least compaction can help it, rather > than exacerbate it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10381) NullPointerException in cqlsh paging through CF with static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953227#comment-14953227 ] Sylvain Lebresne commented on CASSANDRA-10381: -- bq. I found out that queries like SELECT * FROM test WHERE a IN (0, 1, 2, 3, 4) were also not working properly Ok. In theory, we shouldn't end up calling {{SinglePartitionPager.isPreviouslyReturnedPartition()}} with another key than the one of the pager itself, and {{MultiPartitionPager}} should theoretically handle that, but I think the underlying problem is that {{AbstractQueryPager}} doesn't properly record if it's done with a given partition. We should probably fix that by changing {{AbstractQueryPager.PagerIterator.close()}} slightly to {noformat} @Override public void close() { boolean partitionExhausted = !hasNext(); super.close(); // ... remainingInPartition = partitionExhausted ? 0 : counter.countedInCurrentPartition(); exhausted = counted < pageLimits.count(); } {noformat} I suspect that's the cleaner way to fix the {{IN}} problem. That said, there isn't any harm I suppose to check the key in {{SinglePartitionPager.isPreviouslyReturnedPartition()}} for extra safety, but we don't need to add a {{lastReturnedKey}} for that, we can just do: {noformat} protected boolean isPreviouslyReturnedPartition(DecoratedKey key) { return key.equals(command.partitionKey()) && lastReturned != null; } {noformat} > NullPointerException in cqlsh paging through CF with static columns > --- > > Key: CASSANDRA-10381 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10381 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Michael Keeney >Assignee: Benjamin Lerer > Labels: cqlsh, nullpointerexception, range > Fix For: 2.1.x, 2.2.x, 3.0.x > > > When running select count( * ) from cqlsh with limit, the following NPE > occurs: > select count( * ) from tbl1 limit 5 ; > {code} > ERROR [SharedPool-Worker-4] 2015-09-16 14:49:43,480 QueryMessage.java:132 - > Unexpected error during query > java.lang.NullPointerException: null > at > org.apache.cassandra.service.pager.RangeSliceQueryPager.containsPreviousLast(RangeSliceQueryPager.java:99) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.service.pager.AbstractQueryPager.fetchPage(AbstractQueryPager.java:119) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.service.pager.RangeSliceQueryPager.fetchPage(RangeSliceQueryPager.java:37) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.pageCountQuery(SelectStatement.java:286) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:230) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:67) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:238) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$StatementExecution.execute(DseQueryHandler.java:291) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$Operation.executeWithTiming(DseQueryHandler.java:223) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$Operation.executeWithAuditLogging(DseQueryHandler.java:259) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler.process(DseQueryHandler.java:94) > ~[dse-4.7.2.jar:4.7.2] > at > org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:119) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:439) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:335) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$700(AbstractChannelHandlerContext.java:32) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext$8.run(AbstractChannelHandlerContext.java:324) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > [na:1.7.0_75] > at >
[jira] [Commented] (CASSANDRA-10447) Async logging configuration doesn't result in data flushing when shutdown hook runs
[ https://issues.apache.org/jira/browse/CASSANDRA-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953246#comment-14953246 ] Ariel Weisberg commented on CASSANDRA-10447: Finally tracked this down. It's a problem specific to TeeingAppender so it only effects test code. TeeingAppender needs to implement stop() and then stop the Appenders it wraps. > Async logging configuration doesn't result in data flushing when shutdown > hook runs > --- > > Key: CASSANDRA-10447 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10447 > Project: Cassandra > Issue Type: Bug >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg > Fix For: 3.0.0 rc2 > > > Stefania discovered that tests that don't produce a lot of log output end up > producing 0 debug output to files because the data is not flushed as part of > the shutdown hook. I traced through and it looks like the shutdown hook > doesn't actually invoke code that does anything useful. It shuts down an > executor service in the logging context but doesn't call stop on any > appenders. > A hackish thing we can do is use a status listener to collect all the > appenders and then stop them when the shutdown hook runs. Even adding a small > delay to the shutdown hook (no code changes on our part) would in let the > async appender flush in 90% of cases. > We still need to fix it for test which uses a different config file and for > which a small delay is not desirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10360) UnsupportedOperationException when compacting system.size_estimates after 2.1 -> 2.2 -> 3.0 upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953244#comment-14953244 ] Sylvain Lebresne commented on CASSANDRA-10360: -- There was indeed a small error in the logic of the next code leading to that assertion. I've force-pushed a fix, would you mind re-running your test and check if it works now? > UnsupportedOperationException when compacting system.size_estimates after 2.1 > -> 2.2 -> 3.0 upgrade > --- > > Key: CASSANDRA-10360 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10360 > Project: Cassandra > Issue Type: Bug >Reporter: Andrew Hust >Assignee: Sylvain Lebresne >Priority: Blocker > Fix For: 3.0.0 rc2 > > Attachments: size_estimates.2.tar.bz2, size_estimates.tar.bz2, > system.log.2.bz2, system.log.bz2 > > > When upgrading from 2.1 -> 2.2 -> 3.0 the system.size_estimates table will > get stuck in a compaction loop throwing: > {code} > java.lang.UnsupportedOperationException > at > org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.readNext(UnfilteredDeserializer.java:382) > at > org.apache.cassandra.io.sstable.SSTableSimpleIterator$OldFormatIterator.computeNext(SSTableSimpleIterator.java:147) > at > org.apache.cassandra.io.sstable.SSTableSimpleIterator$OldFormatIterator.computeNext(SSTableSimpleIterator.java:96) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.io.sstable.SSTableIdentityIterator.computeNext(SSTableIdentityIterator.java:100) > at > org.apache.cassandra.io.sstable.SSTableIdentityIterator.computeNext(SSTableIdentityIterator.java:30) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.utils.MergeIterator$TrivialOneToOne.computeNext(MergeIterator.java:460) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:503) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:363) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.WrappingUnfilteredRowIterator.hasNext(WrappingUnfilteredRowIterator.java:80) > at > org.apache.cassandra.db.rows.AlteringUnfilteredRowIterator.hasNext(AlteringUnfilteredRowIterator.java:72) > at > org.apache.cassandra.db.rows.UnfilteredRowIterator.isEmpty(UnfilteredRowIterator.java:100) > at > org.apache.cassandra.db.partitions.PurgingPartitionIterator.hasNext(PurgingPartitionIterator.java:72) > at > org.apache.cassandra.db.compaction.CompactionIterator.hasNext(CompactionIterator.java:223) > at > org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:177) > at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:78) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60) > at > org.apache.cassandra.db.compaction.CompactionManager$8.runMayThrow(CompactionManager.java:539) > at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} > It will only occur when upgrading thru 2.2. Going from 2.1 -> 3.0 will not > surface the issue. It can be reproduced with the following (note -- changing > jdks will need to be altered if you aren't on OSX) > {code} > #!/bin/sh > echo "using java7 for cassandra-2.1 instance" > export JAVA_HOME=$(/usr/libexec/java_home -v 1.7) > ccm stop > ccm remove upgrade_nodes > ccm create -n 1 -v git:cassandra-2.1 upgrade_nodes > ccm start > ccm node1 stress write n=500K -rate threads=4 -mode native cql3 > sleep 10 >
[17/19] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/319157d9 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/319157d9 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/319157d9 Branch: refs/heads/trunk Commit: 319157d94ca60873f6ddb9794da1175586829724 Parents: 345be20 0c051a4 Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:13:30 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:30 2015 +0100 -- --
[18/19] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/319157d9 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/319157d9 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/319157d9 Branch: refs/heads/cassandra-3.0 Commit: 319157d94ca60873f6ddb9794da1175586829724 Parents: 345be20 0c051a4 Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:13:30 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:30 2015 +0100 -- --
[04/19] cassandra git commit: bump versions for 2.2.3
bump versions for 2.2.3 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/84443024 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/84443024 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/84443024 Branch: refs/heads/trunk Commit: 84443024328f96a50e336ab0c321900e42240e73 Parents: 45ade6e Author: T Jake LucianiAuthored: Mon Oct 12 09:49:51 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:50:39 2015 -0400 -- NEWS.txt | 8 build.xml| 2 +- debian/changelog | 6 ++ 3 files changed, 15 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 6bd0a77..69f2412 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -13,6 +13,14 @@ restore snapshots created with the previous major version using the 'sstableloader' tool. You can upgrade the file format of your snapshots using the provided 'sstableupgrade' tool. +2.2.3 += + +Upgrading +- +- Nothing specific to this release, but please see 2.2 if you are upgrading + from a previous version. + 2.2.2 = http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/build.xml -- diff --git a/build.xml b/build.xml index 1be774b..d479a70 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index 5361b5c..31fa8e6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.2.3) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:49:15 -0400 + cassandra (2.2.2) unstable; urgency=medium * New release
[09/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/80e6879b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/80e6879b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/80e6879b Branch: refs/heads/cassandra-3.0 Commit: 80e6879bf5c6d3ad1697ecf05f58b9e6260314af Parents: 8444302 182d28c Author: T Jake LucianiAuthored: Mon Oct 12 09:54:01 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:54:01 2015 -0400 -- --
[10/19] cassandra git commit: ninja comment out broken test line in MmappedFileDataInputTest
ninja comment out broken test line in MmappedFileDataInputTest Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4acc3a69 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4acc3a69 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4acc3a69 Branch: refs/heads/cassandra-2.2 Commit: 4acc3a69d319b0e7e00cbd37b27e988ebfa4df4f Parents: 182d28c Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:12:56 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:09 2015 +0100 -- .../unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/4acc3a69/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java -- diff --git a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java index 93b6923..2bc388d 100644 --- a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java +++ b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java @@ -45,7 +45,7 @@ public class MappedFileDataInputTest Assert.assertTrue(bbdi.isEOF()); bbdi.seek(15); Assert.assertEquals(15, bbdi.getFilePointer()); -Assert.assertEquals(15, bbdi.getPosition()); +//Assert.assertEquals(15, bbdi.getPosition()); try { bbdi.seek(14);
[08/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/80e6879b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/80e6879b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/80e6879b Branch: refs/heads/trunk Commit: 80e6879bf5c6d3ad1697ecf05f58b9e6260314af Parents: 8444302 182d28c Author: T Jake LucianiAuthored: Mon Oct 12 09:54:01 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:54:01 2015 -0400 -- --
[16/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0c051a46 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0c051a46 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0c051a46 Branch: refs/heads/cassandra-2.2 Commit: 0c051a46c54fd1a2f151e1a68f4556faca02be8d Parents: 80e6879 4acc3a6 Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:13:21 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:21 2015 +0100 -- --
[19/19] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/20026a84 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/20026a84 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/20026a84 Branch: refs/heads/trunk Commit: 20026a84ce650bbc4d6fe498d71a56de84037425 Parents: fe0f447 319157d Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:13:39 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:39 2015 +0100 -- NEWS.txt | 3 +++ 1 file changed, 3 insertions(+) --
[06/19] cassandra git commit: update news.txt
update news.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/182d28c2 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/182d28c2 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/182d28c2 Branch: refs/heads/cassandra-3.0 Commit: 182d28c2ffb7ab9488698fec1034a91134167ade Parents: df6b27e Author: T Jake LucianiAuthored: Mon Oct 12 09:53:25 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:53:25 2015 -0400 -- NEWS.txt | 8 1 file changed, 8 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/182d28c2/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 6ec24ef..4b34778 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -13,6 +13,14 @@ restore snapshots created with the previous major version using the 'sstableloader' tool. You can upgrade the file format of your snapshots using the provided 'sstableupgrade' tool. +2.1.11 += + +Upgrading +- +- Nothing specific to this release, but please see 2.1 if you are upgrading + from a previous version. + 2.1.10 =
[11/19] cassandra git commit: ninja comment out broken test line in MmappedFileDataInputTest
ninja comment out broken test line in MmappedFileDataInputTest Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4acc3a69 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4acc3a69 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4acc3a69 Branch: refs/heads/cassandra-3.0 Commit: 4acc3a69d319b0e7e00cbd37b27e988ebfa4df4f Parents: 182d28c Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:12:56 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:09 2015 +0100 -- .../unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/4acc3a69/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java -- diff --git a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java index 93b6923..2bc388d 100644 --- a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java +++ b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java @@ -45,7 +45,7 @@ public class MappedFileDataInputTest Assert.assertTrue(bbdi.isEOF()); bbdi.seek(15); Assert.assertEquals(15, bbdi.getFilePointer()); -Assert.assertEquals(15, bbdi.getPosition()); +//Assert.assertEquals(15, bbdi.getPosition()); try { bbdi.seek(14);
[13/19] cassandra git commit: ninja comment out broken test line in MmappedFileDataInputTest
ninja comment out broken test line in MmappedFileDataInputTest Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4acc3a69 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4acc3a69 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4acc3a69 Branch: refs/heads/trunk Commit: 4acc3a69d319b0e7e00cbd37b27e988ebfa4df4f Parents: 182d28c Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:12:56 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:09 2015 +0100 -- .../unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/4acc3a69/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java -- diff --git a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java index 93b6923..2bc388d 100644 --- a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java +++ b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java @@ -45,7 +45,7 @@ public class MappedFileDataInputTest Assert.assertTrue(bbdi.isEOF()); bbdi.seek(15); Assert.assertEquals(15, bbdi.getFilePointer()); -Assert.assertEquals(15, bbdi.getPosition()); +//Assert.assertEquals(15, bbdi.getPosition()); try { bbdi.seek(14);
[01/19] cassandra git commit: Add versions from which upgrade is supported in NEWS file
Repository: cassandra Updated Branches: refs/heads/cassandra-2.1 182d28c2f -> 4acc3a69d refs/heads/cassandra-2.2 80e6879bf -> 0c051a46c refs/heads/cassandra-3.0 345be2057 -> 319157d94 refs/heads/trunk fe0f44741 -> 20026a84c Add versions from which upgrade is supported in NEWS file Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/deeef721 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/deeef721 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/deeef721 Branch: refs/heads/trunk Commit: deeef7219e32dade28c8404485f9210bbf7e05bb Parents: 6f3d1e2 Author: Sylvain LebresneAuthored: Mon Oct 12 15:46:21 2015 +0200 Committer: Sylvain Lebresne Committed: Mon Oct 12 15:46:21 2015 +0200 -- NEWS.txt | 3 +++ 1 file changed, 3 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/deeef721/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 18d61a3..1f32001 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -44,6 +44,9 @@ New features Upgrading - + - Upgrade to 3.0 is supported from Cassandra 2.1 versions greater or equal to 2.1.9, + or Cassandra 2.2 versions greater or equal to 2.2.1. Upgrade from Cassandra 2.0 and + older versions is not supported. - The 'memtable_allocation_type: offheap_objects' option has been removed. It should be re-introduced in a future release and you can follow CASSANDRA-9472 to know more. - The LIMIT clause applies now only to the number of rows returned to the user,
[15/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0c051a46 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0c051a46 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0c051a46 Branch: refs/heads/cassandra-3.0 Commit: 0c051a46c54fd1a2f151e1a68f4556faca02be8d Parents: 80e6879 4acc3a6 Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:13:21 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:21 2015 +0100 -- --
[02/19] cassandra git commit: bump versions for 2.1.11
bump versions for 2.1.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/df6b27e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/df6b27e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/df6b27e3 Branch: refs/heads/trunk Commit: df6b27e36c113607b23f000507520a9199bb3e52 Parents: f87e34e Author: T Jake LucianiAuthored: Mon Oct 12 09:46:49 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:46:49 2015 -0400 -- build.xml| 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/build.xml -- diff --git a/build.xml b/build.xml index 2969cbc..28a8f74 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index d4158f0..9ffa66d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.1.11) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:46:10 -0400 + cassandra (2.1.10) unstable; urgency=medium * New release
[03/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/45ade6e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/45ade6e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/45ade6e3 Branch: refs/heads/trunk Commit: 45ade6e36be865bdd0ef07fce9552432376c4f25 Parents: 83b9740 df6b27e Author: T Jake LucianiAuthored: Mon Oct 12 09:47:54 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:47:54 2015 -0400 -- --
[05/19] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/345be205 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/345be205 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/345be205 Branch: refs/heads/trunk Commit: 345be2057383895f8d4c6b07a89357a0e87441be Parents: deeef72 8444302 Author: T Jake LucianiAuthored: Mon Oct 12 09:52:01 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:52:01 2015 -0400 -- --
[12/19] cassandra git commit: ninja comment out broken test line in MmappedFileDataInputTest
ninja comment out broken test line in MmappedFileDataInputTest Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4acc3a69 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4acc3a69 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4acc3a69 Branch: refs/heads/cassandra-2.1 Commit: 4acc3a69d319b0e7e00cbd37b27e988ebfa4df4f Parents: 182d28c Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:12:56 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:09 2015 +0100 -- .../unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/4acc3a69/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java -- diff --git a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java index 93b6923..2bc388d 100644 --- a/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java +++ b/test/unit/org/apache/cassandra/io/util/MappedFileDataInputTest.java @@ -45,7 +45,7 @@ public class MappedFileDataInputTest Assert.assertTrue(bbdi.isEOF()); bbdi.seek(15); Assert.assertEquals(15, bbdi.getFilePointer()); -Assert.assertEquals(15, bbdi.getPosition()); +//Assert.assertEquals(15, bbdi.getPosition()); try { bbdi.seek(14);
[14/19] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/0c051a46 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/0c051a46 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/0c051a46 Branch: refs/heads/trunk Commit: 0c051a46c54fd1a2f151e1a68f4556faca02be8d Parents: 80e6879 4acc3a6 Author: Benedict Elliott SmithAuthored: Mon Oct 12 15:13:21 2015 +0100 Committer: Benedict Elliott Smith Committed: Mon Oct 12 15:13:21 2015 +0100 -- --
[jira] [Updated] (CASSANDRA-10452) Fix resummable_bootstrap_test and bootstrap_with_reset_bootstrap_state_test
[ https://issues.apache.org/jira/browse/CASSANDRA-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Hust updated CASSANDRA-10452: Summary: Fix resummable_bootstrap_test and bootstrap_with_reset_bootstrap_state_test (was: Fix flapping resummable_bootstrap_test) > Fix resummable_bootstrap_test and bootstrap_with_reset_bootstrap_state_test > --- > > Key: CASSANDRA-10452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10452 > Project: Cassandra > Issue Type: Sub-task >Reporter: Jim Witschey >Assignee: Yuki Morishita > Fix For: 3.0.0 rc2 > > > {{bootstrap_test.py:TestBootstrap.resumable_bootstrap_test}} has been > flapping on CassCI lately: > http://cassci.datastax.com/view/trunk/job/cassandra-3.0_dtest/lastCompletedBuild/testReport/bootstrap_test/TestBootstrap/resumable_bootstrap_test/history/ > I have not been able to reproduce on OpenStack. I'm assigning [~yukim] for > now, but feel free to reassign. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10291) Bootstrap hangs on adding new node
[ https://issues.apache.org/jira/browse/CASSANDRA-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953280#comment-14953280 ] Jim Witschey commented on CASSANDRA-10291: -- [~yukim] Any thoughts on the logs, given that information? > Bootstrap hangs on adding new node > --- > > Key: CASSANDRA-10291 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10291 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Debian 7 64 bit > HotSpot JDK 1.7.0_79 > Cassandra-2.2.1 via apt-get > 1x Intel Quad-Core Xeon E3-1230 / 16GB / 4x1TB SATA / 3x1TB RAID0 data drive >Reporter: Ara Sadoyan > Attachments: logs_netstats.tar.gz, nodetool.txt, system.log > > > Adding new node in heavy loaded environment freeze bootstrap. No errors are > reported in log files. Some of other other nodes throws "String didn't > validate" error, but I;m not sure that this is related. > After restarting node it start bootstrap again and hangs after some time . > nodetool netstats shows : > /data/XXX//tmp-la-1184-big-Data.db 5126078789/18345924701 bytes(27%) > received from idx:0/192.168.220.16 > /data/XXX//tmp-la-1233-big-Data.db 7213706459/18600941671 bytes(38%) > received from idx:0/192.168.220.22 > /data/XXX//tmp-la-1599-big-Data.db 8492408759/17572043398 bytes(48%) > received from idx:0/192.168.220.12 > /data/XXX//tmp-la-2066-big-Data.db 15773981555/18508127610 bytes(85%) > received from idx:0/192.168.220.18 > /data/XXX//tmp-la-211-big-Data.db 8274231066/17172754085 bytes(48%) > received from idx:0/192.168.220.20 > but listing files on local FS shows "No such file or directory" > This happens only if there is significant amount of data. I have 1.5 TB per > node on 13 node cluster, we use STCS compaction strategy and flat network > topology . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10487) Regression in select count with limit
[ https://issues.apache.org/jira/browse/CASSANDRA-10487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953085#comment-14953085 ] Sylvain Lebresne commented on CASSANDRA-10487: -- +1 > Regression in select count with limit > - > > Key: CASSANDRA-10487 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10487 > Project: Cassandra > Issue Type: Bug >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer > Fix For: 2.2.x > > > After CASSANDRA-4914 the {{LIMIT}} clause should limit only the number of > rows returned to the user not the number of rows used by the aggregates. > That functionality is currently broken in 2.2. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10478) Seek position is not within mmap segment
[ https://issues.apache.org/jira/browse/CASSANDRA-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953025#comment-14953025 ] Christian Winther commented on CASSANDRA-10478: --- okay, I changed to standard disk mode, my dataset is just a few TB, so went pretty fast with rebuilding the summary files will the next release be 2.2.3 ? > Seek position is not within mmap segment > > > Key: CASSANDRA-10478 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10478 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Cassandra 2.2.2 > Java 1.8.0.60 >Reporter: Omri Iluz >Assignee: Benedict >Priority: Critical > Fix For: 2.2.3, 2.1.11 > > > After upgrading to 2.2.2 we started seeing timeouts accompanied by the > following error in the log. Disabling mmap (by using "disk_access_mode: > standard") completely solves the problem. > We did not experience this problem in 2.2.1. > The change to src/java/org/apache/cassandra/io/util/ByteBufferDataInput.java > in the following commit seems interesting as it changes the calculation of > the mmap boundaries (and moves from <= to <) > https://github.com/apache/cassandra/commit/25de92e321604626d6c098233082904832c07814 > > {noformat} > WARN [SharedPool-Worker-1] 2015-10-07 03:40:39,771 > AbstractTracingAwareExecutorService.java:169 - Uncaught exception on thread > Thread[SharedPool-Worker-1,5,main]: {} > java.lang.RuntimeException: > org.apache.cassandra.io.sstable.CorruptSSTableException: java.io.IOException: > Seek position 717680 is not within mmap segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2187) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_60] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [apache-cassandra-2.2.2.jar:2.2.2] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60] > Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException: > java.io.IOException: Seek position 717680 is not within mmap segment (seg > offs: 0, length: 717680) > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.getPosition(BigTableReader.java:250) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.SSTableReader.getPosition(SSTableReader.java:1558) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.SSTableSliceIterator.(SSTableSliceIterator.java:42) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:75) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:246) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:62) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:270) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:64) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:2004) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1808) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.db.Keyspace.getRow(Keyspace.java:360) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.SliceFromReadCommand.getRow(SliceFromReadCommand.java:85) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1537) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2183) > ~[apache-cassandra-2.2.2.jar:2.2.2] > ... 4 common frames omitted > Caused by: java.io.IOException: Seek position 717680 is not within mmap > segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.io.util.ByteBufferDataInput.seek(ByteBufferDataInput.java:47) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.util.AbstractDataInput.skipBytes(AbstractDataInput.java:33) >
[jira] [Commented] (CASSANDRA-4430) optional pluggable o.a.c.metrics reporters
[ https://issues.apache.org/jira/browse/CASSANDRA-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953035#comment-14953035 ] sumit thakur commented on CASSANDRA-4430: - Hello Team, Can you please also explain the configuration required in ganglia to handle cassandra reporting? Thanks & Regards Sumit Thakur > optional pluggable o.a.c.metrics reporters > -- > > Key: CASSANDRA-4430 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4430 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Chris Burroughs >Assignee: Chris Burroughs >Priority: Minor > Fix For: 2.0.2 > > Attachments: 4430-2.0.txt, 4430-trunk.txt, > cassandra-ganglia-example.png > > > CASSANDRA-4009 expanded the use of the metrics library which has a set of > reporter modules http://metrics.codahale.com/manual/core/#reporters You can > report to flat files, ganglia, spit everything over http, etc. The next step > is a mechanism for using those reporters with o.a.c.metrics. To avoid > bundling everything I suggest following the mx4j approach of "enable only if > on classpath coupled with a reporter configuration file. > Strawman file: > {noformat} > console: > time: 1 > timeunit: "seconds" > csv: > - time: 1 >timeunit: minutes >file: foo.csv > - time: 10 >timeunit: seconds > file: bar.csv > ganglia: > - time: 30 >timunit: seconds >host: server-1 >port: 8649 > - time: 30 >timunit: seconds >host: server-2 >port: 8649 > {noformat} > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10372) Adds smallint and tinyint to the CQL documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-10372: --- Attachment: 10372-2.2.txt > Adds smallint and tinyint to the CQL documentation > -- > > Key: CASSANDRA-10372 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10372 > Project: Cassandra > Issue Type: Bug >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Minor > Fix For: 2.2.x > > Attachments: 10372-2.2.txt > > > CASSANDRA-8951 added {{smallint}} and {{tinyint}} types but the CQL > documentation was not updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
cassandra git commit: Call forceStaticInitialization first in activate and make sure offline tools properly handle DatabaseDescriptor static exceptions
Repository: cassandra Updated Branches: refs/heads/cassandra-2.2 cccaa17e1 -> 83b9740a5 Call forceStaticInitialization first in activate and make sure offline tools properly handle DatabaseDescriptor static exceptions patch by carlyeks; reviewed by pauloricardomg for CASSANDRA-10412 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83b9740a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83b9740a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83b9740a Branch: refs/heads/cassandra-2.2 Commit: 83b9740a5ec13142f5d4bd8fe46e86172533595c Parents: cccaa17 Author: Carl YeksigianAuthored: Wed Oct 7 08:46:12 2015 -0400 Committer: Sylvain Lebresne Committed: Mon Oct 12 14:45:58 2015 +0200 -- CHANGES.txt | 1 + .../cassandra/service/CassandraDaemon.java | 30 +- .../cassandra/tools/SSTableExpiredBlockers.java | 4 +- .../apache/cassandra/tools/SSTableExport.java | 1 + .../apache/cassandra/tools/SSTableImport.java | 2 + .../cassandra/tools/SSTableLevelResetter.java | 2 + .../cassandra/tools/SSTableMetadataViewer.java | 2 + .../cassandra/tools/SSTableOfflineRelevel.java | 3 + .../tools/SSTableRepairedAtSetter.java | 2 + .../cassandra/tools/StandaloneScrubber.java | 2 + .../cassandra/tools/StandaloneSplitter.java | 2 + .../cassandra/tools/StandaloneUpgrader.java | 2 + .../cassandra/tools/StandaloneVerifier.java | 2 + src/java/org/apache/cassandra/tools/Util.java | 58 14 files changed, 99 insertions(+), 14 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/83b9740a/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 215bd76..efae4ab 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.2.3 + * Avoid NoClassDefFoundError during DataDescriptor initialization on windows (CASSANDRA-10412) * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) http://git-wip-us.apache.org/repos/asf/cassandra/blob/83b9740a/src/java/org/apache/cassandra/service/CassandraDaemon.java -- diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java b/src/java/org/apache/cassandra/service/CassandraDaemon.java index 075c8f7..2a23550 100644 --- a/src/java/org/apache/cassandra/service/CassandraDaemon.java +++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java @@ -480,19 +480,20 @@ public class CassandraDaemon */ public void activate() { -String pidFile = System.getProperty("cassandra-pidfile"); - -if (FBUtilities.isWindows()) -{ -// We need to adjust the system timer on windows from the default 15ms down to the minimum of 1ms as this -// impacts timer intervals, thread scheduling, driver interrupts, etc. - WindowsTimer.startTimerPeriod(DatabaseDescriptor.getWindowsTimerInterval()); -} - +// Do not put any references to DatabaseDescriptor above the forceStaticInitialization call. try { try { +DatabaseDescriptor.forceStaticInitialization(); +} +catch (ExceptionInInitializerError e) +{ +throw e.getCause(); +} + +try +{ MBeanServer mbs = ManagementFactory.getPlatformMBeanServer(); mbs.registerMBean(new StandardMBean(new NativeAccess(), NativeAccessMBean.class), new ObjectName(MBEAN_NAME)); } @@ -502,14 +503,17 @@ public class CassandraDaemon //Allow the server to start even if the bean can't be registered } -try { -DatabaseDescriptor.forceStaticInitialization(); -} catch (ExceptionInInitializerError e) { -throw e.getCause(); +if (FBUtilities.isWindows()) +{ +// We need to adjust the system timer on windows from the default 15ms down to the minimum of 1ms as this +// impacts timer intervals, thread scheduling, driver interrupts, etc. + WindowsTimer.startTimerPeriod(DatabaseDescriptor.getWindowsTimerInterval()); } setup(); +String pidFile = System.getProperty("cassandra-pidfile"); + if (pidFile != null) { new File(pidFile).deleteOnExit();
[2/3] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Conflicts: CHANGES.txt src/java/org/apache/cassandra/tools/SSTableExport.java src/java/org/apache/cassandra/tools/SSTableImport.java Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6f3d1e22 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6f3d1e22 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6f3d1e22 Branch: refs/heads/trunk Commit: 6f3d1e225da27924a2d4333086b11ed805a84ee1 Parents: b324759 83b9740 Author: Sylvain LebresneAuthored: Mon Oct 12 14:50:01 2015 +0200 Committer: Sylvain Lebresne Committed: Mon Oct 12 14:50:01 2015 +0200 -- CHANGES.txt | 1 + .../cassandra/service/CassandraDaemon.java | 30 +- .../cassandra/tools/SSTableExpiredBlockers.java | 4 +- .../cassandra/tools/SSTableLevelResetter.java | 2 + .../cassandra/tools/SSTableMetadataViewer.java | 2 + .../cassandra/tools/SSTableOfflineRelevel.java | 3 + .../tools/SSTableRepairedAtSetter.java | 2 + .../cassandra/tools/StandaloneScrubber.java | 2 + .../cassandra/tools/StandaloneSplitter.java | 2 + .../cassandra/tools/StandaloneUpgrader.java | 2 + .../cassandra/tools/StandaloneVerifier.java | 2 + src/java/org/apache/cassandra/tools/Util.java | 58 12 files changed, 96 insertions(+), 14 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/6f3d1e22/CHANGES.txt -- diff --cc CHANGES.txt index f40c12c,efae4ab..f72929f --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,46 -1,26 +1,47 @@@ -2.2.3 +3.0 + * Only include modified cell data in indexing deltas (CASSANDRA-10438) + * Do not load keyspace when creating sstable writer (CASSANDRA-10443) + * If node is not yet gossiping write all MV updates to batchlog only (CASSANDRA-10413) + * Re-populate token metadata after commit log recovery (CASSANDRA-10293) + * Provide additional metrics for materialized views (CASSANDRA-10323) + * Flush system schema tables after local schema changes (CASSANDRA-10429) +Merged from 2.2: + * Avoid NoClassDefFoundError during DataDescriptor initialization on windows (CASSANDRA-10412) * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) - * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) + * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) Merged from 2.1: - * Fix mmap file segment seeking to EOF (CASSANDRA-10478) * Allow LOCAL_JMX to be easily overridden (CASSANDRA-10275) * Mark nodes as dead even if they've already left (CASSANDRA-10205) - * Update internal python driver used by cqlsh (CASSANDRA-10161) -2.2.2 - * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) + +3.0.0-rc1 + * Fix mixed version read request compatibility for compact static tables + (CASSANDRA-10373) + * Fix paging of DISTINCT with static and IN (CASSANDRA-10354) + * Allow MATERIALIZED VIEW's SELECT statement to restrict primary key + columns (CASSANDRA-9664) + * Move crc_check_chance out of compression options (CASSANDRA-9839) + * Fix descending iteration past end of BTreeSearchIterator (CASSANDRA-10301) + * Transfer hints to a different node on decommission (CASSANDRA-10198) + * Check partition keys for CAS operations during stmt validation (CASSANDRA-10338) + * Add custom query expressions to SELECT (CASSANDRA-10217) + * Fix minor bugs in MV handling (CASSANDRA-10362) + * Allow custom indexes with 0,1 or multiple target columns (CASSANDRA-10124) + * Improve MV schema representation (CASSANDRA-9921) + * Add flag to enable/disable coordinator batchlog for MV writes (CASSANDRA-10230) + * Update cqlsh COPY for new internal driver serialization interface (CASSANDRA-10318) + * Give index implementations more control over rebuild operations (CASSANDRA-10312) + * Update index file format (CASSANDRA-10314) + * Add "shadowable" row tombstones to deal with mv timestamp issues (CASSANDRA-10261) + * CFS.loadNewSSTables() broken for pre-3.0 sstables + * Cache selected index in read command to reduce lookups (CASSANDRA-10215) + * Small optimizations of sstable index serialization (CASSANDRA-10232) + * Support for both encrypted and unencrypted native transport connections (CASSANDRA-9590) +Merged from 2.2: * Configurable page size in cqlsh (CASSANDRA-9855) * Defer default role manager setup until all nodes are on 2.2+ (CASSANDRA-9761) - * Cancel transaction for sstables we wont redistribute index summary - for
[1/3] cassandra git commit: Call forceStaticInitialization first in activate and make sure offline tools properly handle DatabaseDescriptor static exceptions
Repository: cassandra Updated Branches: refs/heads/trunk 87da74eb5 -> fe0f44741 Call forceStaticInitialization first in activate and make sure offline tools properly handle DatabaseDescriptor static exceptions patch by carlyeks; reviewed by pauloricardomg for CASSANDRA-10412 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83b9740a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83b9740a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83b9740a Branch: refs/heads/trunk Commit: 83b9740a5ec13142f5d4bd8fe46e86172533595c Parents: cccaa17 Author: Carl YeksigianAuthored: Wed Oct 7 08:46:12 2015 -0400 Committer: Sylvain Lebresne Committed: Mon Oct 12 14:45:58 2015 +0200 -- CHANGES.txt | 1 + .../cassandra/service/CassandraDaemon.java | 30 +- .../cassandra/tools/SSTableExpiredBlockers.java | 4 +- .../apache/cassandra/tools/SSTableExport.java | 1 + .../apache/cassandra/tools/SSTableImport.java | 2 + .../cassandra/tools/SSTableLevelResetter.java | 2 + .../cassandra/tools/SSTableMetadataViewer.java | 2 + .../cassandra/tools/SSTableOfflineRelevel.java | 3 + .../tools/SSTableRepairedAtSetter.java | 2 + .../cassandra/tools/StandaloneScrubber.java | 2 + .../cassandra/tools/StandaloneSplitter.java | 2 + .../cassandra/tools/StandaloneUpgrader.java | 2 + .../cassandra/tools/StandaloneVerifier.java | 2 + src/java/org/apache/cassandra/tools/Util.java | 58 14 files changed, 99 insertions(+), 14 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/83b9740a/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 215bd76..efae4ab 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.2.3 + * Avoid NoClassDefFoundError during DataDescriptor initialization on windows (CASSANDRA-10412) * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) http://git-wip-us.apache.org/repos/asf/cassandra/blob/83b9740a/src/java/org/apache/cassandra/service/CassandraDaemon.java -- diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java b/src/java/org/apache/cassandra/service/CassandraDaemon.java index 075c8f7..2a23550 100644 --- a/src/java/org/apache/cassandra/service/CassandraDaemon.java +++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java @@ -480,19 +480,20 @@ public class CassandraDaemon */ public void activate() { -String pidFile = System.getProperty("cassandra-pidfile"); - -if (FBUtilities.isWindows()) -{ -// We need to adjust the system timer on windows from the default 15ms down to the minimum of 1ms as this -// impacts timer intervals, thread scheduling, driver interrupts, etc. - WindowsTimer.startTimerPeriod(DatabaseDescriptor.getWindowsTimerInterval()); -} - +// Do not put any references to DatabaseDescriptor above the forceStaticInitialization call. try { try { +DatabaseDescriptor.forceStaticInitialization(); +} +catch (ExceptionInInitializerError e) +{ +throw e.getCause(); +} + +try +{ MBeanServer mbs = ManagementFactory.getPlatformMBeanServer(); mbs.registerMBean(new StandardMBean(new NativeAccess(), NativeAccessMBean.class), new ObjectName(MBEAN_NAME)); } @@ -502,14 +503,17 @@ public class CassandraDaemon //Allow the server to start even if the bean can't be registered } -try { -DatabaseDescriptor.forceStaticInitialization(); -} catch (ExceptionInInitializerError e) { -throw e.getCause(); +if (FBUtilities.isWindows()) +{ +// We need to adjust the system timer on windows from the default 15ms down to the minimum of 1ms as this +// impacts timer intervals, thread scheduling, driver interrupts, etc. + WindowsTimer.startTimerPeriod(DatabaseDescriptor.getWindowsTimerInterval()); } setup(); +String pidFile = System.getProperty("cassandra-pidfile"); + if (pidFile != null) { new File(pidFile).deleteOnExit();
[3/3] cassandra git commit: Merge branch 'cassandra-3.0' into trunk
Merge branch 'cassandra-3.0' into trunk Conflicts: src/java/org/apache/cassandra/service/CassandraDaemon.java Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/fe0f4474 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/fe0f4474 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/fe0f4474 Branch: refs/heads/trunk Commit: fe0f447410e8493c04f080688140f264c65e3d96 Parents: 87da74e 6f3d1e2 Author: Sylvain LebresneAuthored: Mon Oct 12 14:55:44 2015 +0200 Committer: Sylvain Lebresne Committed: Mon Oct 12 14:55:44 2015 +0200 -- CHANGES.txt | 1 + .../cassandra/service/CassandraDaemon.java | 31 ++- .../cassandra/tools/SSTableExpiredBlockers.java | 4 +- .../cassandra/tools/SSTableLevelResetter.java | 2 + .../cassandra/tools/SSTableMetadataViewer.java | 2 + .../cassandra/tools/SSTableOfflineRelevel.java | 3 + .../tools/SSTableRepairedAtSetter.java | 2 + .../cassandra/tools/StandaloneScrubber.java | 2 + .../cassandra/tools/StandaloneSplitter.java | 2 + .../cassandra/tools/StandaloneUpgrader.java | 2 + .../cassandra/tools/StandaloneVerifier.java | 2 + src/java/org/apache/cassandra/tools/Util.java | 58 12 files changed, 95 insertions(+), 16 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/fe0f4474/CHANGES.txt -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/fe0f4474/src/java/org/apache/cassandra/service/CassandraDaemon.java --
[jira] [Commented] (CASSANDRA-10477) java.lang.AssertionError in StorageProxy.submitHint
[ https://issues.apache.org/jira/browse/CASSANDRA-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953112#comment-14953112 ] Severin Leonhardt commented on CASSANDRA-10477: --- [~philipthompson] I can't make the logfile publicly accessible but I can share it by mail. Let me know to whom I should send it. > java.lang.AssertionError in StorageProxy.submitHint > --- > > Key: CASSANDRA-10477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10477 > Project: Cassandra > Issue Type: Bug > Environment: CentOS 6, Oracle JVM 1.8.45 >Reporter: Severin Leonhardt > Fix For: 2.1.x > > > A few days after updating from 2.0.15 to 2.1.9 we have the following log > entry on 2 of 5 machines: > {noformat} > ERROR [EXPIRING-MAP-REAPER:1] 2015-10-07 17:01:08,041 > CassandraDaemon.java:223 - Exception in thread > Thread[EXPIRING-MAP-REAPER:1,5,main] > java.lang.AssertionError: /192.168.11.88 > at > org.apache.cassandra.service.StorageProxy.submitHint(StorageProxy.java:949) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > org.apache.cassandra.net.MessagingService$5.apply(MessagingService.java:383) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > org.apache.cassandra.net.MessagingService$5.apply(MessagingService.java:363) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at org.apache.cassandra.utils.ExpiringMap$1.run(ExpiringMap.java:98) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor$UncomplainingRunnable.run(DebuggableScheduledThreadPoolExecutor.java:118) > ~[apache-cassandra-2.1.9.jar:2.1.9] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > [na:1.8.0_45] > at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) > [na:1.8.0_45] > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > [na:1.8.0_45] > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) > [na:1.8.0_45] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > [na:1.8.0_45] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > [na:1.8.0_45] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45] > {noformat} > 192.168.11.88 is the broadcast address of the local machine. > When this is logged the read request latency of the whole cluster becomes > very bad, from 6 ms/op to more than 100 ms/op according to OpsCenter. Clients > get a lot of timeouts. We need to restart the affected Cassandra node to get > back normal read latencies. It seems write latency is not affected. > Disabling hinted handoff using {{nodetool disablehandoff}} only prevents the > assert from being logged. At some point the read latency becomes bad again. > Restarting the node where hinted handoff was disabled results in the read > latency being better again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10478) Seek position is not within mmap segment
[ https://issues.apache.org/jira/browse/CASSANDRA-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953028#comment-14953028 ] Benedict commented on CASSANDRA-10478: -- bq. will the next release be 2.2.3 ? Yes > Seek position is not within mmap segment > > > Key: CASSANDRA-10478 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10478 > Project: Cassandra > Issue Type: Bug > Components: Core > Environment: Cassandra 2.2.2 > Java 1.8.0.60 >Reporter: Omri Iluz >Assignee: Benedict >Priority: Critical > Fix For: 2.2.3, 2.1.11 > > > After upgrading to 2.2.2 we started seeing timeouts accompanied by the > following error in the log. Disabling mmap (by using "disk_access_mode: > standard") completely solves the problem. > We did not experience this problem in 2.2.1. > The change to src/java/org/apache/cassandra/io/util/ByteBufferDataInput.java > in the following commit seems interesting as it changes the calculation of > the mmap boundaries (and moves from <= to <) > https://github.com/apache/cassandra/commit/25de92e321604626d6c098233082904832c07814 > > {noformat} > WARN [SharedPool-Worker-1] 2015-10-07 03:40:39,771 > AbstractTracingAwareExecutorService.java:169 - Uncaught exception on thread > Thread[SharedPool-Worker-1,5,main]: {} > java.lang.RuntimeException: > org.apache.cassandra.io.sstable.CorruptSSTableException: java.io.IOException: > Seek position 717680 is not within mmap segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2187) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_60] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [apache-cassandra-2.2.2.jar:2.2.2] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60] > Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException: > java.io.IOException: Seek position 717680 is not within mmap segment (seg > offs: 0, length: 717680) > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.getPosition(BigTableReader.java:250) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.SSTableReader.getPosition(SSTableReader.java:1558) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.SSTableSliceIterator.(SSTableSliceIterator.java:42) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:75) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.SliceQueryFilter.getSSTableColumnIterator(SliceQueryFilter.java:246) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.filter.QueryFilter.getSSTableColumnIterator(QueryFilter.java:62) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:270) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:64) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:2004) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1808) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at org.apache.cassandra.db.Keyspace.getRow(Keyspace.java:360) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.db.SliceFromReadCommand.getRow(SliceFromReadCommand.java:85) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1537) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2183) > ~[apache-cassandra-2.2.2.jar:2.2.2] > ... 4 common frames omitted > Caused by: java.io.IOException: Seek position 717680 is not within mmap > segment (seg offs: 0, length: 717680) > at > org.apache.cassandra.io.util.ByteBufferDataInput.seek(ByteBufferDataInput.java:47) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.util.AbstractDataInput.skipBytes(AbstractDataInput.java:33) > ~[apache-cassandra-2.2.2.jar:2.2.2] > at > org.apache.cassandra.io.util.FileUtils.skipBytesFully(FileUtils.java:405) >
[jira] [Updated] (CASSANDRA-10372) Adds smallint and tinyint to the CQL documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-10372: - Reviewer: Sylvain Lebresne (was: Aleksey Yeschenko) > Adds smallint and tinyint to the CQL documentation > -- > > Key: CASSANDRA-10372 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10372 > Project: Cassandra > Issue Type: Bug >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Minor > Fix For: 2.2.x > > Attachments: 10372-2.2.txt > > > CASSANDRA-8951 added {{smallint}} and {{tinyint}} types but the CQL > documentation was not updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-10442) Paging repeats records
[ https://issues.apache.org/jira/browse/CASSANDRA-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer resolved CASSANDRA-10442. Resolution: Won't Fix > Paging repeats records > -- > > Key: CASSANDRA-10442 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10442 > Project: Cassandra > Issue Type: Bug >Reporter: Robert Wille >Assignee: Benjamin Lerer > > Paging repeats records every fetchSize records. The following sample easily > reproduces the problem on Cassandra 2.0.16 with Java Driver 2.0.11. > {noformat} > public class TestPagingBug > { > public static void main(String[] args) > { > Cluster.Builder builder = Cluster.builder(); > Cluster c = builder.addContactPoints("192.168.98.190").build(); > > Session s = c.connect(); > > s.execute("CREATE KEYSPACE IF NOT EXISTS test WITH replication > = { 'class' : 'SimpleStrategy', 'replication_factor' : 3 }"); > s.execute("CREATE TABLE IF NOT EXISTS test.test_page(id INT, > sec BIGINT, data VARCHAR static, PRIMARY KEY ((id), sec))"); > s.execute("INSERT INTO test.test_page (id, data) VALUES (1, > 'asdfasdfasdfasdfasdfasdf')"); > > PreparedStatement insert = s.prepare("INSERT INTO > test.test_page (id, sec) VALUES (1, ?)"); > for (int i = 0; i < 1000; i++) > s.execute(insert.bind((long) i)); > > PreparedStatement select = s.prepare("SELECT sec FROM > test.test_page WHERE id = 1"); > > long lastSec = -1; > for (Row row : s.execute(select.bind().setFetchSize(300))) > { > long sec = row.getLong("sec"); > if (sec == lastSec) > System.out.println(String.format("Duplicated id > %d", sec)); > > lastSec = sec; > } > System.exit(0); > } > } > {noformat} > The program outputs the following: > Duplicated id 299 > Duplicated id 598 > Duplicated id 897 > Note that the static column is required. This bug doesn't occur if you remove > the column from the schema. > I realize that this may be a driver bug, but I don't really know, so I'm > logging it here until that can be determined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/2] cassandra git commit: Call forceStaticInitialization first in activate and make sure offline tools properly handle DatabaseDescriptor static exceptions
Repository: cassandra Updated Branches: refs/heads/cassandra-3.0 b324759ea -> 6f3d1e225 Call forceStaticInitialization first in activate and make sure offline tools properly handle DatabaseDescriptor static exceptions patch by carlyeks; reviewed by pauloricardomg for CASSANDRA-10412 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83b9740a Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83b9740a Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83b9740a Branch: refs/heads/cassandra-3.0 Commit: 83b9740a5ec13142f5d4bd8fe46e86172533595c Parents: cccaa17 Author: Carl YeksigianAuthored: Wed Oct 7 08:46:12 2015 -0400 Committer: Sylvain Lebresne Committed: Mon Oct 12 14:45:58 2015 +0200 -- CHANGES.txt | 1 + .../cassandra/service/CassandraDaemon.java | 30 +- .../cassandra/tools/SSTableExpiredBlockers.java | 4 +- .../apache/cassandra/tools/SSTableExport.java | 1 + .../apache/cassandra/tools/SSTableImport.java | 2 + .../cassandra/tools/SSTableLevelResetter.java | 2 + .../cassandra/tools/SSTableMetadataViewer.java | 2 + .../cassandra/tools/SSTableOfflineRelevel.java | 3 + .../tools/SSTableRepairedAtSetter.java | 2 + .../cassandra/tools/StandaloneScrubber.java | 2 + .../cassandra/tools/StandaloneSplitter.java | 2 + .../cassandra/tools/StandaloneUpgrader.java | 2 + .../cassandra/tools/StandaloneVerifier.java | 2 + src/java/org/apache/cassandra/tools/Util.java | 58 14 files changed, 99 insertions(+), 14 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/83b9740a/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 215bd76..efae4ab 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.2.3 + * Avoid NoClassDefFoundError during DataDescriptor initialization on windows (CASSANDRA-10412) * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) http://git-wip-us.apache.org/repos/asf/cassandra/blob/83b9740a/src/java/org/apache/cassandra/service/CassandraDaemon.java -- diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java b/src/java/org/apache/cassandra/service/CassandraDaemon.java index 075c8f7..2a23550 100644 --- a/src/java/org/apache/cassandra/service/CassandraDaemon.java +++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java @@ -480,19 +480,20 @@ public class CassandraDaemon */ public void activate() { -String pidFile = System.getProperty("cassandra-pidfile"); - -if (FBUtilities.isWindows()) -{ -// We need to adjust the system timer on windows from the default 15ms down to the minimum of 1ms as this -// impacts timer intervals, thread scheduling, driver interrupts, etc. - WindowsTimer.startTimerPeriod(DatabaseDescriptor.getWindowsTimerInterval()); -} - +// Do not put any references to DatabaseDescriptor above the forceStaticInitialization call. try { try { +DatabaseDescriptor.forceStaticInitialization(); +} +catch (ExceptionInInitializerError e) +{ +throw e.getCause(); +} + +try +{ MBeanServer mbs = ManagementFactory.getPlatformMBeanServer(); mbs.registerMBean(new StandardMBean(new NativeAccess(), NativeAccessMBean.class), new ObjectName(MBEAN_NAME)); } @@ -502,14 +503,17 @@ public class CassandraDaemon //Allow the server to start even if the bean can't be registered } -try { -DatabaseDescriptor.forceStaticInitialization(); -} catch (ExceptionInInitializerError e) { -throw e.getCause(); +if (FBUtilities.isWindows()) +{ +// We need to adjust the system timer on windows from the default 15ms down to the minimum of 1ms as this +// impacts timer intervals, thread scheduling, driver interrupts, etc. + WindowsTimer.startTimerPeriod(DatabaseDescriptor.getWindowsTimerInterval()); } setup(); +String pidFile = System.getProperty("cassandra-pidfile"); + if (pidFile != null) { new File(pidFile).deleteOnExit();
[jira] [Commented] (CASSANDRA-10372) Adds smallint and tinyint to the CQL documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953077#comment-14953077 ] Sylvain Lebresne commented on CASSANDRA-10372: -- +1 but can you also include a mention of the change in the changelog at the end of the documentation on commit (for whatever CQL version they happen to have released with). > Adds smallint and tinyint to the CQL documentation > -- > > Key: CASSANDRA-10372 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10372 > Project: Cassandra > Issue Type: Bug >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Minor > Fix For: 2.2.x > > Attachments: 10372-2.2.txt > > > CASSANDRA-8951 added {{smallint}} and {{tinyint}} types but the CQL > documentation was not updated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10381) NullPointerException in cqlsh paging through CF with static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953118#comment-14953118 ] Sylvain Lebresne commented on CASSANDRA-10381: -- The 2.1 patch lgtm. On the 3.0 patch: * Can you update the comment on top of {{boolean includeLastKey = ...}} (in {{RangeSliceQueryPager}} to explain the new condition. * I don't think I understand why {{SinglePartitionParger}} has to include a {{lastReturnedKey}}? A {{SinglePartitionPager}} applies to a single partition so we shouldn't need this. And if we do need this, can you provide a test for what problem this fixes (since as far as I can tell, the test you mention above doesn't use {{SinglePartitionPager}}). Also, can you convert your test for this above to a dtest and open a pull request for its inclusion. > NullPointerException in cqlsh paging through CF with static columns > --- > > Key: CASSANDRA-10381 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10381 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Michael Keeney >Assignee: Benjamin Lerer > Labels: cqlsh, nullpointerexception, range > Fix For: 2.1.x, 2.2.x, 3.0.x > > > When running select count( * ) from cqlsh with limit, the following NPE > occurs: > select count( * ) from tbl1 limit 5 ; > {code} > ERROR [SharedPool-Worker-4] 2015-09-16 14:49:43,480 QueryMessage.java:132 - > Unexpected error during query > java.lang.NullPointerException: null > at > org.apache.cassandra.service.pager.RangeSliceQueryPager.containsPreviousLast(RangeSliceQueryPager.java:99) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.service.pager.AbstractQueryPager.fetchPage(AbstractQueryPager.java:119) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.service.pager.RangeSliceQueryPager.fetchPage(RangeSliceQueryPager.java:37) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.pageCountQuery(SelectStatement.java:286) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:230) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:67) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:238) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$StatementExecution.execute(DseQueryHandler.java:291) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$Operation.executeWithTiming(DseQueryHandler.java:223) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$Operation.executeWithAuditLogging(DseQueryHandler.java:259) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler.process(DseQueryHandler.java:94) > ~[dse-4.7.2.jar:4.7.2] > at > org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:119) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:439) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:335) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$700(AbstractChannelHandlerContext.java:32) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext$8.run(AbstractChannelHandlerContext.java:324) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > [na:1.7.0_75] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at java.lang.Thread.run(Thread.java:745) [na:1.7.0_75] > {code} > Table definition looks something like: > {code} > CREATE TABLE tbl1 ( > field1 bigint, > field2 int, > field3 timestamp, > field4 map, > field5 text static, > field6 text static, > field7 text static > PRIMARY KEY (field1, field2, field3) > ) WITH
[jira] [Commented] (CASSANDRA-10421) Potential issue with LogTransaction as it only checks in a single directory for files
[ https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953016#comment-14953016 ] Stefania commented on CASSANDRA-10421: -- bq. This isn't exposing us to anything too terrible though, really, since this clearly should be infrequent or there are bigger problems. Agreed. -- It's clearer now, thanks. Unless [~aweisberg] has any concern I will resume work on this tomorrow. > Potential issue with LogTransaction as it only checks in a single directory > for files > - > > Key: CASSANDRA-10421 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10421 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Stefania >Priority: Blocker > Fix For: 3.0.0 rc2 > > > When creating a new LogTransaction we try to create the new logfile in the > same directory as the one we are writing to, but as we use > {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}} > this might end up in "any" of the configured data directories. If it does, > we will not be able to clean up leftovers as we check for files in the same > directory as the logfile was created: > https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163 > cc [~Stefania] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10442) Paging repeats records
[ https://issues.apache.org/jira/browse/CASSANDRA-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953032#comment-14953032 ] Benjamin Lerer commented on CASSANDRA-10442: I tested the different cassandra versions and it seems that only {{2.0}} is affected by this issue. I could not reproduce the issue with {{2.1}}, {{2.2}} and {{3.0}}. As {{2.0}} is not supported anymore, I will close the issue as {{won't fix}}. > Paging repeats records > -- > > Key: CASSANDRA-10442 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10442 > Project: Cassandra > Issue Type: Bug >Reporter: Robert Wille >Assignee: Benjamin Lerer > > Paging repeats records every fetchSize records. The following sample easily > reproduces the problem on Cassandra 2.0.16 with Java Driver 2.0.11. > {noformat} > public class TestPagingBug > { > public static void main(String[] args) > { > Cluster.Builder builder = Cluster.builder(); > Cluster c = builder.addContactPoints("192.168.98.190").build(); > > Session s = c.connect(); > > s.execute("CREATE KEYSPACE IF NOT EXISTS test WITH replication > = { 'class' : 'SimpleStrategy', 'replication_factor' : 3 }"); > s.execute("CREATE TABLE IF NOT EXISTS test.test_page(id INT, > sec BIGINT, data VARCHAR static, PRIMARY KEY ((id), sec))"); > s.execute("INSERT INTO test.test_page (id, data) VALUES (1, > 'asdfasdfasdfasdfasdfasdf')"); > > PreparedStatement insert = s.prepare("INSERT INTO > test.test_page (id, sec) VALUES (1, ?)"); > for (int i = 0; i < 1000; i++) > s.execute(insert.bind((long) i)); > > PreparedStatement select = s.prepare("SELECT sec FROM > test.test_page WHERE id = 1"); > > long lastSec = -1; > for (Row row : s.execute(select.bind().setFetchSize(300))) > { > long sec = row.getLong("sec"); > if (sec == lastSec) > System.out.println(String.format("Duplicated id > %d", sec)); > > lastSec = sec; > } > System.exit(0); > } > } > {noformat} > The program outputs the following: > Duplicated id 299 > Duplicated id 598 > Duplicated id 897 > Note that the static column is required. This bug doesn't occur if you remove > the column from the schema. > I realize that this may be a driver bug, but I don't really know, so I'm > logging it here until that can be determined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/2] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Conflicts: CHANGES.txt src/java/org/apache/cassandra/tools/SSTableExport.java src/java/org/apache/cassandra/tools/SSTableImport.java Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6f3d1e22 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6f3d1e22 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6f3d1e22 Branch: refs/heads/cassandra-3.0 Commit: 6f3d1e225da27924a2d4333086b11ed805a84ee1 Parents: b324759 83b9740 Author: Sylvain LebresneAuthored: Mon Oct 12 14:50:01 2015 +0200 Committer: Sylvain Lebresne Committed: Mon Oct 12 14:50:01 2015 +0200 -- CHANGES.txt | 1 + .../cassandra/service/CassandraDaemon.java | 30 +- .../cassandra/tools/SSTableExpiredBlockers.java | 4 +- .../cassandra/tools/SSTableLevelResetter.java | 2 + .../cassandra/tools/SSTableMetadataViewer.java | 2 + .../cassandra/tools/SSTableOfflineRelevel.java | 3 + .../tools/SSTableRepairedAtSetter.java | 2 + .../cassandra/tools/StandaloneScrubber.java | 2 + .../cassandra/tools/StandaloneSplitter.java | 2 + .../cassandra/tools/StandaloneUpgrader.java | 2 + .../cassandra/tools/StandaloneVerifier.java | 2 + src/java/org/apache/cassandra/tools/Util.java | 58 12 files changed, 96 insertions(+), 14 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/6f3d1e22/CHANGES.txt -- diff --cc CHANGES.txt index f40c12c,efae4ab..f72929f --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,46 -1,26 +1,47 @@@ -2.2.3 +3.0 + * Only include modified cell data in indexing deltas (CASSANDRA-10438) + * Do not load keyspace when creating sstable writer (CASSANDRA-10443) + * If node is not yet gossiping write all MV updates to batchlog only (CASSANDRA-10413) + * Re-populate token metadata after commit log recovery (CASSANDRA-10293) + * Provide additional metrics for materialized views (CASSANDRA-10323) + * Flush system schema tables after local schema changes (CASSANDRA-10429) +Merged from 2.2: + * Avoid NoClassDefFoundError during DataDescriptor initialization on windows (CASSANDRA-10412) * Preserve case of quoted Role & User names (CASSANDRA-10394) * cqlsh pg-style-strings broken (CASSANDRA-10484) - * Make Hadoop CF splits more polite to custom orderered partitioners (CASSANDRA-10400) + * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) Merged from 2.1: - * Fix mmap file segment seeking to EOF (CASSANDRA-10478) * Allow LOCAL_JMX to be easily overridden (CASSANDRA-10275) * Mark nodes as dead even if they've already left (CASSANDRA-10205) - * Update internal python driver used by cqlsh (CASSANDRA-10161) -2.2.2 - * cqlsh prompt includes name of keyspace after failed `use` statement (CASSANDRA-10369) + +3.0.0-rc1 + * Fix mixed version read request compatibility for compact static tables + (CASSANDRA-10373) + * Fix paging of DISTINCT with static and IN (CASSANDRA-10354) + * Allow MATERIALIZED VIEW's SELECT statement to restrict primary key + columns (CASSANDRA-9664) + * Move crc_check_chance out of compression options (CASSANDRA-9839) + * Fix descending iteration past end of BTreeSearchIterator (CASSANDRA-10301) + * Transfer hints to a different node on decommission (CASSANDRA-10198) + * Check partition keys for CAS operations during stmt validation (CASSANDRA-10338) + * Add custom query expressions to SELECT (CASSANDRA-10217) + * Fix minor bugs in MV handling (CASSANDRA-10362) + * Allow custom indexes with 0,1 or multiple target columns (CASSANDRA-10124) + * Improve MV schema representation (CASSANDRA-9921) + * Add flag to enable/disable coordinator batchlog for MV writes (CASSANDRA-10230) + * Update cqlsh COPY for new internal driver serialization interface (CASSANDRA-10318) + * Give index implementations more control over rebuild operations (CASSANDRA-10312) + * Update index file format (CASSANDRA-10314) + * Add "shadowable" row tombstones to deal with mv timestamp issues (CASSANDRA-10261) + * CFS.loadNewSSTables() broken for pre-3.0 sstables + * Cache selected index in read command to reduce lookups (CASSANDRA-10215) + * Small optimizations of sstable index serialization (CASSANDRA-10232) + * Support for both encrypted and unencrypted native transport connections (CASSANDRA-9590) +Merged from 2.2: * Configurable page size in cqlsh (CASSANDRA-9855) * Defer default role manager setup until all nodes are on 2.2+ (CASSANDRA-9761) - * Cancel transaction for sstables we wont redistribute index summary - for
cassandra git commit: bump versions for 2.1.11
Repository: cassandra Updated Branches: refs/heads/cassandra-2.1 f87e34ed3 -> df6b27e36 bump versions for 2.1.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/df6b27e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/df6b27e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/df6b27e3 Branch: refs/heads/cassandra-2.1 Commit: df6b27e36c113607b23f000507520a9199bb3e52 Parents: f87e34e Author: T Jake LucianiAuthored: Mon Oct 12 09:46:49 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:46:49 2015 -0400 -- build.xml| 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/build.xml -- diff --git a/build.xml b/build.xml index 2969cbc..28a8f74 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index d4158f0..9ffa66d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.1.11) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:46:10 -0400 + cassandra (2.1.10) unstable; urgency=medium * New release
[1/2] cassandra git commit: update news.txt
Repository: cassandra Updated Branches: refs/heads/cassandra-2.2 844430243 -> 80e6879bf update news.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/182d28c2 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/182d28c2 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/182d28c2 Branch: refs/heads/cassandra-2.2 Commit: 182d28c2ffb7ab9488698fec1034a91134167ade Parents: df6b27e Author: T Jake LucianiAuthored: Mon Oct 12 09:53:25 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:53:25 2015 -0400 -- NEWS.txt | 8 1 file changed, 8 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/182d28c2/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 6ec24ef..4b34778 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -13,6 +13,14 @@ restore snapshots created with the previous major version using the 'sstableloader' tool. You can upgrade the file format of your snapshots using the provided 'sstableupgrade' tool. +2.1.11 += + +Upgrading +- +- Nothing specific to this release, but please see 2.1 if you are upgrading + from a previous version. + 2.1.10 =
[jira] [Created] (CASSANDRA-10505) Duplicate range tombstones
Brandon Williams created CASSANDRA-10505: Summary: Duplicate range tombstones Key: CASSANDRA-10505 URL: https://issues.apache.org/jira/browse/CASSANDRA-10505 Project: Cassandra Issue Type: Bug Components: Core Reporter: Brandon Williams Fix For: 2.1.x I don't have a way to reproduce this just yet, but I have the sstables to prove it and can provide those offline. What I can reproduce, however, is the magnification of this problem via compaction. Here's what I know so far: * under some condition, we flush the exact same RT more than once in the same sstable. Same timestamps, everything. * Once this happens in multiple sstables, compacting them causes the duplication to grow. The more this occurs, the worse the problem gets. This continues until gc_grace has passed, then they are all evicted normally. I'd at least like to take a look at the compaction amplification for now, that way if the condition does occur, at least compaction can help it, rather than exacerbate it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
cassandra git commit: Add versions from which upgrade is supported in NEWS file
Repository: cassandra Updated Branches: refs/heads/cassandra-3.0 6f3d1e225 -> deeef7219 Add versions from which upgrade is supported in NEWS file Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/deeef721 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/deeef721 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/deeef721 Branch: refs/heads/cassandra-3.0 Commit: deeef7219e32dade28c8404485f9210bbf7e05bb Parents: 6f3d1e2 Author: Sylvain LebresneAuthored: Mon Oct 12 15:46:21 2015 +0200 Committer: Sylvain Lebresne Committed: Mon Oct 12 15:46:21 2015 +0200 -- NEWS.txt | 3 +++ 1 file changed, 3 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/deeef721/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 18d61a3..1f32001 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -44,6 +44,9 @@ New features Upgrading - + - Upgrade to 3.0 is supported from Cassandra 2.1 versions greater or equal to 2.1.9, + or Cassandra 2.2 versions greater or equal to 2.2.1. Upgrade from Cassandra 2.0 and + older versions is not supported. - The 'memtable_allocation_type: offheap_objects' option has been removed. It should be re-introduced in a future release and you can follow CASSANDRA-9472 to know more. - The LIMIT clause applies now only to the number of rows returned to the user,
[3/4] cassandra git commit: bump versions for 2.2.3
bump versions for 2.2.3 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/84443024 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/84443024 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/84443024 Branch: refs/heads/cassandra-3.0 Commit: 84443024328f96a50e336ab0c321900e42240e73 Parents: 45ade6e Author: T Jake LucianiAuthored: Mon Oct 12 09:49:51 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:50:39 2015 -0400 -- NEWS.txt | 8 build.xml| 2 +- debian/changelog | 6 ++ 3 files changed, 15 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 6bd0a77..69f2412 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -13,6 +13,14 @@ restore snapshots created with the previous major version using the 'sstableloader' tool. You can upgrade the file format of your snapshots using the provided 'sstableupgrade' tool. +2.2.3 += + +Upgrading +- +- Nothing specific to this release, but please see 2.2 if you are upgrading + from a previous version. + 2.2.2 = http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/build.xml -- diff --git a/build.xml b/build.xml index 1be774b..d479a70 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index 5361b5c..31fa8e6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.2.3) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:49:15 -0400 + cassandra (2.2.2) unstable; urgency=medium * New release
[1/4] cassandra git commit: bump versions for 2.1.11
Repository: cassandra Updated Branches: refs/heads/cassandra-3.0 deeef7219 -> 345be2057 bump versions for 2.1.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/df6b27e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/df6b27e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/df6b27e3 Branch: refs/heads/cassandra-3.0 Commit: df6b27e36c113607b23f000507520a9199bb3e52 Parents: f87e34e Author: T Jake LucianiAuthored: Mon Oct 12 09:46:49 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:46:49 2015 -0400 -- build.xml| 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/build.xml -- diff --git a/build.xml b/build.xml index 2969cbc..28a8f74 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index d4158f0..9ffa66d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.1.11) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:46:10 -0400 + cassandra (2.1.10) unstable; urgency=medium * New release
cassandra git commit: update news.txt
Repository: cassandra Updated Branches: refs/heads/cassandra-2.1 df6b27e36 -> 182d28c2f update news.txt Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/182d28c2 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/182d28c2 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/182d28c2 Branch: refs/heads/cassandra-2.1 Commit: 182d28c2ffb7ab9488698fec1034a91134167ade Parents: df6b27e Author: T Jake LucianiAuthored: Mon Oct 12 09:53:25 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:53:25 2015 -0400 -- NEWS.txt | 8 1 file changed, 8 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/182d28c2/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 6ec24ef..4b34778 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -13,6 +13,14 @@ restore snapshots created with the previous major version using the 'sstableloader' tool. You can upgrade the file format of your snapshots using the provided 'sstableupgrade' tool. +2.1.11 += + +Upgrading +- +- Nothing specific to this release, but please see 2.1 if you are upgrading + from a previous version. + 2.1.10 =
[3/3] cassandra git commit: bump versions for 2.2.3
bump versions for 2.2.3 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/84443024 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/84443024 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/84443024 Branch: refs/heads/cassandra-2.2 Commit: 84443024328f96a50e336ab0c321900e42240e73 Parents: 45ade6e Author: T Jake LucianiAuthored: Mon Oct 12 09:49:51 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:50:39 2015 -0400 -- NEWS.txt | 8 build.xml| 2 +- debian/changelog | 6 ++ 3 files changed, 15 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/NEWS.txt -- diff --git a/NEWS.txt b/NEWS.txt index 6bd0a77..69f2412 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -13,6 +13,14 @@ restore snapshots created with the previous major version using the 'sstableloader' tool. You can upgrade the file format of your snapshots using the provided 'sstableupgrade' tool. +2.2.3 += + +Upgrading +- +- Nothing specific to this release, but please see 2.2 if you are upgrading + from a previous version. + 2.2.2 = http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/build.xml -- diff --git a/build.xml b/build.xml index 1be774b..d479a70 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/84443024/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index 5361b5c..31fa8e6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.2.3) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:49:15 -0400 + cassandra (2.2.2) unstable; urgency=medium * New release
[2/3] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/45ade6e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/45ade6e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/45ade6e3 Branch: refs/heads/cassandra-2.2 Commit: 45ade6e36be865bdd0ef07fce9552432376c4f25 Parents: 83b9740 df6b27e Author: T Jake LucianiAuthored: Mon Oct 12 09:47:54 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:47:54 2015 -0400 -- --
[1/3] cassandra git commit: bump versions for 2.1.11
Repository: cassandra Updated Branches: refs/heads/cassandra-2.2 83b9740a5 -> 844430243 bump versions for 2.1.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/df6b27e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/df6b27e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/df6b27e3 Branch: refs/heads/cassandra-2.2 Commit: df6b27e36c113607b23f000507520a9199bb3e52 Parents: f87e34e Author: T Jake LucianiAuthored: Mon Oct 12 09:46:49 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:46:49 2015 -0400 -- build.xml| 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/build.xml -- diff --git a/build.xml b/build.xml index 2969cbc..28a8f74 100644 --- a/build.xml +++ b/build.xml @@ -25,7 +25,7 @@ - + http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=tree"/> http://git-wip-us.apache.org/repos/asf/cassandra/blob/df6b27e3/debian/changelog -- diff --git a/debian/changelog b/debian/changelog index d4158f0..9ffa66d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +cassandra (2.1.11) unstable; urgency=medium + + * New release + + -- Jake Luciani Mon, 12 Oct 2015 09:46:10 -0400 + cassandra (2.1.10) unstable; urgency=medium * New release
[jira] [Commented] (CASSANDRA-9748) Can't see other nodes when using multiple network interfaces
[ https://issues.apache.org/jira/browse/CASSANDRA-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953165#comment-14953165 ] Roman Bielik commented on CASSANDRA-9748: - Hi Paulo, thank you very much, the provided github version works absolutely well!! I used the suggested configuration and the nodes started smoothly seeing both nodes in a ring. I run few tests with my Thrift client and all looks good. :) > Can't see other nodes when using multiple network interfaces > > > Key: CASSANDRA-9748 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9748 > Project: Cassandra > Issue Type: Bug > Environment: Cassandra 2.0.16; multi-DC configuration >Reporter: Roman Bielik >Assignee: Paulo Motta > Attachments: system_node1.log, system_node2.log > > > The idea is to setup a multi-DC environment across 2 different networks based > on the following configuration recommendations: > http://docs.datastax.com/en/cassandra/2.0/cassandra/configuration/configMultiNetworks.html > Each node has 2 network interfaces. One used as a private network (DC1: > 10.0.1.x and DC2: 10.0.2.x). The second one a "public" network where all > nodes can see each other (this one has a higher latency). > Using the following settings in cassandra.yaml: > *seeds:* public IP (same as used in broadcast_address) > *listen_address:* private IP > *broadcast_address:* public IP > *rpc_address:* 0.0.0.0 > *endpoint_snitch:* GossipingPropertyFileSnitch > _(tried different combinations with no luck)_ > No firewall and no SSL/encryption used. > The problem is that nodes do not see each other (a gossip problem I guess). > The nodetool ring/status shows only the local node but not the other ones > (even from the same DC). > When I set listen_address to public IP, then everything works fine, but that > is not the required configuration. > _Note: Not using EC2 cloud!_ > netstat -anp | grep -E "(7199|9160|9042|7000)" > tcp0 0 0.0.0.0:71990.0.0.0:* > LISTEN 3587/java > tcp0 0 10.0.1.1:9160 0.0.0.0:* > LISTEN 3587/java > tcp0 0 10.0.1.1:9042 0.0.0.0:* > LISTEN 3587/java > tcp0 0 10.0.1.1:7000 0.0.0.0:* > LISTEN 3587/java > tcp0 0 127.0.0.1:7199 127.0.0.1:52874 > ESTABLISHED 3587/java > tcp0 0 10.0.1.1:7199 10.0.1.1:39650 > ESTABLISHED 3587/java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-10505) Duplicate range tombstones
[ https://issues.apache.org/jira/browse/CASSANDRA-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-10505: - Reproduced In: 2.1.8 2.1.8 is where the original problem occurred, but the compaction issue still remains on 2.1 HEAD. > Duplicate range tombstones > -- > > Key: CASSANDRA-10505 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10505 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Brandon Williams > Fix For: 2.1.x > > > I don't have a way to reproduce this just yet, but I have the sstables to > prove it and can provide those offline. What I can reproduce, however, is > the magnification of this problem via compaction. Here's what I know so far: > * under some condition, we flush the exact same RT more than once in the same > sstable. Same timestamps, everything. > * Once this happens in multiple sstables, compacting them causes the > duplication to grow. The more this occurs, the worse the problem gets. > This continues until gc_grace has passed, then they are all evicted normally. > I'd at least like to take a look at the compaction amplification for now, > that way if the condition does occur, at least compaction can help it, rather > than exacerbate it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10488) Document supported upgrade paths to 3.0 in NEWS.txt
[ https://issues.apache.org/jira/browse/CASSANDRA-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953135#comment-14953135 ] Sylvain Lebresne commented on CASSANDRA-10488: -- bq. There might have been other forward-compatibility changes in 2.1 or 2.2 that I missed in later releases. I can't remember anything so I've simply push a commit going with 2.1.9+ and 2.2.1+. If someone remember a reason why that's incorrect, please speak. I'm gonna mark that issue as testing as we should check that our upgrading test do at least pass for those versions, but since that's really pending the completion of CASSANDRA-10166. > Document supported upgrade paths to 3.0 in NEWS.txt > --- > > Key: CASSANDRA-10488 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10488 > Project: Cassandra > Issue Type: Bug > Components: Documentation & website >Reporter: Tyler Hobbs >Assignee: Sylvain Lebresne >Priority: Blocker > Fix For: 3.0.0 rc2 > > > Due to CASSANDRA-9849, we only support upgrading to 3.0 from 2.1.9+ or > 2.2.1+. This needs to be documented in the "Upgrading" section of NEWS.txt. > (There might have been other forward-compatibility changes in 2.1 or 2.2 that > I missed in later releases.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/2] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/80e6879b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/80e6879b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/80e6879b Branch: refs/heads/cassandra-2.2 Commit: 80e6879bf5c6d3ad1697ecf05f58b9e6260314af Parents: 8444302 182d28c Author: T Jake LucianiAuthored: Mon Oct 12 09:54:01 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:54:01 2015 -0400 -- --
[jira] [Commented] (CASSANDRA-10381) NullPointerException in cqlsh paging through CF with static columns
[ https://issues.apache.org/jira/browse/CASSANDRA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953197#comment-14953197 ] Benjamin Lerer commented on CASSANDRA-10381: {quote}Also, can you convert your test for this above to a dtest and open a pull request for its inclusion.{quote} The link to the DTest branch is in the {{Issue Links}}. {quote}I don't think I understand why SinglePartitionParger has to include a lastReturnedKey? A SinglePartitionPager applies to a single partition so we shouldn't need this. And if we do need this, can you provide a test for what problem this fixes (since as far as I can tell, the test you mention above doesn't use SinglePartitionPager).{quote} Sorry, I forgot to explain that part of the patch. While investigating the issue, I found out that queries like {{SELECT * FROM test WHERE a IN (0, 1, 2, 3, 4)}} were also not working properly. In {{3.0}} those queries lead me to {{SinglePartitionParger}}. I included a {{lastReturnedKey}} to be able to detect if we were done with the partition and should move to the next. It seems to be working but I am not sure that it is the right way to fix the problem. > NullPointerException in cqlsh paging through CF with static columns > --- > > Key: CASSANDRA-10381 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10381 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Michael Keeney >Assignee: Benjamin Lerer > Labels: cqlsh, nullpointerexception, range > Fix For: 2.1.x, 2.2.x, 3.0.x > > > When running select count( * ) from cqlsh with limit, the following NPE > occurs: > select count( * ) from tbl1 limit 5 ; > {code} > ERROR [SharedPool-Worker-4] 2015-09-16 14:49:43,480 QueryMessage.java:132 - > Unexpected error during query > java.lang.NullPointerException: null > at > org.apache.cassandra.service.pager.RangeSliceQueryPager.containsPreviousLast(RangeSliceQueryPager.java:99) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.service.pager.AbstractQueryPager.fetchPage(AbstractQueryPager.java:119) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.service.pager.RangeSliceQueryPager.fetchPage(RangeSliceQueryPager.java:37) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.pageCountQuery(SelectStatement.java:286) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:230) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:67) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:238) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$StatementExecution.execute(DseQueryHandler.java:291) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$Operation.executeWithTiming(DseQueryHandler.java:223) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler$Operation.executeWithAuditLogging(DseQueryHandler.java:259) > ~[dse-4.7.2.jar:4.7.2] > at > com.datastax.bdp.cassandra.cql3.DseQueryHandler.process(DseQueryHandler.java:94) > ~[dse-4.7.2.jar:4.7.2] > at > org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:119) > ~[cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:439) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:335) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$700(AbstractChannelHandlerContext.java:32) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at > io.netty.channel.AbstractChannelHandlerContext$8.run(AbstractChannelHandlerContext.java:324) > [netty-all-4.0.23.Final.jar:4.0.23.Final] > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > [na:1.7.0_75] > at > org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [cassandra-all-2.1.8.621.jar:2.1.8.621] > at
[4/4] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/345be205 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/345be205 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/345be205 Branch: refs/heads/cassandra-3.0 Commit: 345be2057383895f8d4c6b07a89357a0e87441be Parents: deeef72 8444302 Author: T Jake LucianiAuthored: Mon Oct 12 09:52:01 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:52:01 2015 -0400 -- --
[2/4] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/45ade6e3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/45ade6e3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/45ade6e3 Branch: refs/heads/cassandra-3.0 Commit: 45ade6e36be865bdd0ef07fce9552432376c4f25 Parents: 83b9740 df6b27e Author: T Jake LucianiAuthored: Mon Oct 12 09:47:54 2015 -0400 Committer: T Jake Luciani Committed: Mon Oct 12 09:47:54 2015 -0400 -- --
[jira] [Updated] (CASSANDRA-10488) Document supported upgrade paths to 3.0 in NEWS.txt
[ https://issues.apache.org/jira/browse/CASSANDRA-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-10488: - Priority: Major (was: Blocker) > Document supported upgrade paths to 3.0 in NEWS.txt > --- > > Key: CASSANDRA-10488 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10488 > Project: Cassandra > Issue Type: Bug > Components: Documentation & website >Reporter: Tyler Hobbs >Assignee: Sylvain Lebresne > Fix For: 3.0.0 rc2 > > > Due to CASSANDRA-9849, we only support upgrading to 3.0 from 2.1.9+ or > 2.2.1+. This needs to be documented in the "Upgrading" section of NEWS.txt. > (There might have been other forward-compatibility changes in 2.1 or 2.2 that > I missed in later releases.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Git Push Summary
Repository: cassandra Updated Tags: refs/tags/2.1.11-tentative [created] 182d28c2f
[jira] [Commented] (CASSANDRA-10461) Fix sstableverify_test dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953178#comment-14953178 ] Jim Witschey commented on CASSANDRA-10461: -- [~Stefania] Thanks! Is this ticket ready to be closed, or are there more changes to make? > Fix sstableverify_test dtest > > > Key: CASSANDRA-10461 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10461 > Project: Cassandra > Issue Type: Sub-task >Reporter: Jim Witschey >Assignee: Stefania > Labels: test > Fix For: 3.0.0 rc2 > > > The dtest for sstableverify is failing: > http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_dtest/lastCompletedBuild/testReport/offline_tools_test/TestOfflineTools/sstableverify_test/ > It fails in the same way when I run it on OpenStack, so I don't think it's > just a CassCI problem. > [~slebresne] Looks like you made changes to this test recently: > https://github.com/riptano/cassandra-dtest/commit/51ab085f21e01cc8e5ad88a277cb4a43abd3f880 > Could you have a look at the failure? I'm assigning you for triage, but feel > free to reassign. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10089) NullPointerException in Gossip handleStateNormal
[ https://issues.apache.org/jira/browse/CASSANDRA-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953192#comment-14953192 ] Joel Knighton commented on CASSANDRA-10089: --- These updated patches look good. It looks like CassCI aborted several of the dtest/testall runs for these rebased branches. It is almost certainly environmental, but it'd be great if you could kick those off one more time, so that we can get a clean CI bill of health. The blocking flush discussion was moved to [CASSANDRA-10231]. > NullPointerException in Gossip handleStateNormal > > > Key: CASSANDRA-10089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10089 > Project: Cassandra > Issue Type: Bug >Reporter: Stefania >Assignee: Stefania > Fix For: 2.1.x, 2.2.x, 3.0.x > > > Whilst comparing dtests for CASSANDRA-9970 I found [this failing > dtest|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-9970-dtest/lastCompletedBuild/testReport/consistency_test/TestConsistency/short_read_test/] > in 2.2: > {code} > Unexpected error in node1 node log: ['ERROR [GossipStage:1] 2015-08-14 > 15:39:57,873 CassandraDaemon.java:183 - Exception in thread > Thread[GossipStage:1,5,main] java.lang.NullPointerException: null \tat > org.apache.cassandra.service.StorageService.getApplicationStateValue(StorageService.java:1731) > ~[main/:na] \tat > org.apache.cassandra.service.StorageService.getTokensFor(StorageService.java:1804) > ~[main/:na] \tat > org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:1857) > ~[main/:na] \tat > org.apache.cassandra.service.StorageService.onChange(StorageService.java:1629) > ~[main/:na] \tat > org.apache.cassandra.service.StorageService.onJoin(StorageService.java:2312) > ~[main/:na] \tat > org.apache.cassandra.gms.Gossiper.handleMajorStateChange(Gossiper.java:1025) > ~[main/:na] \tat > org.apache.cassandra.gms.Gossiper.applyStateLocally(Gossiper.java:1106) > ~[main/:na] \tat > org.apache.cassandra.gms.GossipDigestAck2VerbHandler.doVerb(GossipDigestAck2VerbHandler.java:49) > ~[main/:na] \tat > org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:66) > ~[main/:na] \tat > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > ~[na:1.7.0_80] \tat > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > ~[na:1.7.0_80] \tat java.lang.Thread.run(Thread.java:745) ~[na:1.7.0_80]'] > {code} > I wasn't able to find it on unpatched branches but it is clearly not related > to CASSANDRA-9970, if anything it could have been a side effect of > CASSANDRA-9871. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Git Push Summary
Repository: cassandra Updated Tags: refs/tags/2.1.11-tentative [deleted] 182d28c2f
[jira] [Commented] (CASSANDRA-10291) Bootstrap hangs on adding new node
[ https://issues.apache.org/jira/browse/CASSANDRA-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953376#comment-14953376 ] Yuki Morishita commented on CASSANDRA-10291: Unfortunately not so much. All I got were: {code} WARN [STREAM-IN-/192.168.220.17] 2015-09-17 08:27:32,189 StreamSession.java:644 - [Stream #a5f6b030-5d07-11e5-b554-5f8e66db7dc7] Retrying for following errorjava.lang.AssertionError: null at org.apache.cassandra.streaming.compress.CompressedInputStream.read(CompressedInputStream.java:96) ~[apache-cassandra-2.2.1.jar:2.2.1] at java.io.InputStream.read(InputStream.java:179) ~[na:1.7.0_80] at java.io.InputStream.skip(InputStream.java:222) ~[na:1.7.0_80] at org.apache.cassandra.streaming.StreamReader.drain(StreamReader.java:137) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.compress.CompressedStreamReader.read(CompressedStreamReader.java:106) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.messages.IncomingFileMessage$1.deserialize(IncomingFileMessage.java:49) [apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.messages.IncomingFileMessage$1.deserialize(IncomingFileMessage.java:38) [apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:56) [apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:261) [apache-cassandra-2.2.1.jar:2.2.1] at java.lang.Thread.run(Thread.java:745) [na:1.7.0_80] {code} and {code} WARN [STREAM-IN-/192.168.220.16] 2015-09-17 09:40:42,378 StreamSession.java:644 - [Stream #a5f6b030-5d07-11e5-b554-5f8e66db7dc7] Retrying for following errororg.apache.cassandra.serializers.MarshalException: String didn't validate. at org.apache.cassandra.serializers.UTF8Serializer.validate(UTF8Serializer.java:35) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.marshal.AbstractType.getString(AbstractType.java:91) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.cql3.ColumnIdentifier.(ColumnIdentifier.java:58) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.composites.SimpleSparseCellNameType.fromByteBuffer(SimpleSparseCellNameType.java:83) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:381) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.composites.AbstractCType$Serializer.deserialize(AbstractCType.java:365) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.RangeTombstone$Serializer.deserializeBody(RangeTombstone.java:357) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.OnDiskAtom$Serializer.deserializeFromSSTable(OnDiskAtom.java:84) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:52) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.db.AbstractCell$1.computeNext(AbstractCell.java:46) ~[apache-cassandra-2.2.1.jar:2.2.1] at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143) ~[guava-16.0.jar:na] at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) ~[guava-16.0.jar:na] at org.apache.cassandra.io.sstable.format.big.BigTableWriter.appendFromStream(BigTableWriter.java:243) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.StreamReader.writeRow(StreamReader.java:162) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.compress.CompressedStreamReader.read(CompressedStreamReader.java:95) ~[apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.messages.IncomingFileMessage$1.deserialize(IncomingFileMessage.java:49) [apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.messages.IncomingFileMessage$1.deserialize(IncomingFileMessage.java:38) [apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:56) [apache-cassandra-2.2.1.jar:2.2.1] at org.apache.cassandra.streaming.ConnectionHandler$IncomingMessageHandler.run(ConnectionHandler.java:261) [apache-cassandra-2.2.1.jar:2.2.1] at java.lang.Thread.run(Thread.java:745) [na:1.7.0_80] {code} so I wonder if there were SSTable corruption on those nodes. Though "(/192.168.220.)16 was able to restream that particular stream." so 17 was only problematic at that moment. > Bootstrap hangs on adding new node > --- > > Key: CASSANDRA-10291 > URL:
Git Push Summary
Repository: cassandra Updated Tags: refs/tags/2.2.3-tentative [created] 0c051a46c
[jira] [Commented] (CASSANDRA-10463) Fix failing compaction tests
[ https://issues.apache.org/jira/browse/CASSANDRA-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953455#comment-14953455 ] Joel Knighton commented on CASSANDRA-10463: --- Both PRs have been merged, and reviewing dtest runs for 3.0 on CassCI shows that the tests are passing. Thanks, resolving. > Fix failing compaction tests > > > Key: CASSANDRA-10463 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10463 > Project: Cassandra > Issue Type: Sub-task >Reporter: Jim Witschey >Assignee: Yuki Morishita > Fix For: 3.0.0 rc2 > > > A bunch of compaction tests started failing after some changes to how logs > are handled in ccm: > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.compaction_throughput_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.data_size_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_alter_and_nodetool_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_alter_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_nodetool_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_schema_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.sstable_deletion_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.compaction_throughput_test > - compaction_test.TestCompaction_with_LeveledCompactionStrategy.data_size_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_alter_and_nodetool_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_alter_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_nodetool_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_schema_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.sstable_deletion_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.compaction_throughput_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.data_size_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_alter_and_nodetool_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_alter_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_nodetool_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_schema_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.sstable_deletion_test > I haven't dug into it much, but it looks like the following tests: > - compaction_throughput_test > - data_size_test > - disable_autocompaction_alter_and_nodetool_test > - disable_autocompaction_alter_test > - disable_autocompaction_nodetool_test > - disable_autocompaction_schema_test > - sstable_deletion_test > grep logs to check if operations happened successfully, and that something in > the new log-handling code broke this. > I'm assigning [~yukim], since I believe you wrote the changes to ccm, but > feel free to find a new assignee. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10365) Consider storing types by their CQL names in schema tables instead of fully-qualified internal class names
[ https://issues.apache.org/jira/browse/CASSANDRA-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953362#comment-14953362 ] Adam Holmberg commented on CASSANDRA-10365: --- If the concern is about leaking implementation details, would it be reasonable to instead store User Types as fully-specified abstract types as we do in the results encoding? https://github.com/apache/cassandra/blob/trunk/doc/native_protocol_v4.spec#L607-L618 I know this is not CQL, but it would avoid having to resolve inner types. > Consider storing types by their CQL names in schema tables instead of > fully-qualified internal class names > -- > > Key: CASSANDRA-10365 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10365 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko > Labels: client-impacting > Fix For: 3.0.0 rc2 > > > Consider saving CQL types names for column, UDF/UDA arguments and return > types, and UDT components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Git Push Summary
Repository: cassandra Updated Tags: refs/tags/2.1.11-tentative [created] 4acc3a69d
[jira] [Commented] (CASSANDRA-10360) UnsupportedOperationException when compacting system.size_estimates after 2.1 -> 2.2 -> 3.0 upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953490#comment-14953490 ] Andrew Hust commented on CASSANDRA-10360: - Confirmed that the above upgrade test script now passes without exceptions. Ran with: apache/cassandra-2.1: {{4acc3a69d319b0e7e00cbd37b27e988ebfa4df4f}} apache/cassandra-2.2: {{0c051a46c54fd1a2f151e1a68f4556faca02be8d}} pcmanus/10360: {{6a56057a4eaab01480fba6292c5a59d4c3d62c49}} > UnsupportedOperationException when compacting system.size_estimates after 2.1 > -> 2.2 -> 3.0 upgrade > --- > > Key: CASSANDRA-10360 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10360 > Project: Cassandra > Issue Type: Bug >Reporter: Andrew Hust >Assignee: Sylvain Lebresne >Priority: Blocker > Fix For: 3.0.0 rc2 > > Attachments: size_estimates.2.tar.bz2, size_estimates.tar.bz2, > system.log.2.bz2, system.log.bz2 > > > When upgrading from 2.1 -> 2.2 -> 3.0 the system.size_estimates table will > get stuck in a compaction loop throwing: > {code} > java.lang.UnsupportedOperationException > at > org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.readNext(UnfilteredDeserializer.java:382) > at > org.apache.cassandra.io.sstable.SSTableSimpleIterator$OldFormatIterator.computeNext(SSTableSimpleIterator.java:147) > at > org.apache.cassandra.io.sstable.SSTableSimpleIterator$OldFormatIterator.computeNext(SSTableSimpleIterator.java:96) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.io.sstable.SSTableIdentityIterator.computeNext(SSTableIdentityIterator.java:100) > at > org.apache.cassandra.io.sstable.SSTableIdentityIterator.computeNext(SSTableIdentityIterator.java:30) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95) > at > org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.utils.MergeIterator$TrivialOneToOne.computeNext(MergeIterator.java:460) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:503) > at > org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:363) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at > org.apache.cassandra.db.rows.WrappingUnfilteredRowIterator.hasNext(WrappingUnfilteredRowIterator.java:80) > at > org.apache.cassandra.db.rows.AlteringUnfilteredRowIterator.hasNext(AlteringUnfilteredRowIterator.java:72) > at > org.apache.cassandra.db.rows.UnfilteredRowIterator.isEmpty(UnfilteredRowIterator.java:100) > at > org.apache.cassandra.db.partitions.PurgingPartitionIterator.hasNext(PurgingPartitionIterator.java:72) > at > org.apache.cassandra.db.compaction.CompactionIterator.hasNext(CompactionIterator.java:223) > at > org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:177) > at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at > org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:78) > at > org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60) > at > org.apache.cassandra.db.compaction.CompactionManager$8.runMayThrow(CompactionManager.java:539) > at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} > It will only occur when upgrading thru 2.2. Going from 2.1 -> 3.0 will not > surface the issue. It can be reproduced with the following (note -- changing > jdks will need to be altered if you aren't on OSX) > {code} > #!/bin/sh > echo "using java7 for cassandra-2.1 instance" > export JAVA_HOME=$(/usr/libexec/java_home -v 1.7) > ccm stop > ccm remove upgrade_nodes > ccm create -n 1 -v git:cassandra-2.1
[jira] [Updated] (CASSANDRA-9526) Provide a JMX hook to monitor phi values in the FailureDetector
[ https://issues.apache.org/jira/browse/CASSANDRA-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-9526: -- Assignee: Ron Kuris (was: Ariel Weisberg) > Provide a JMX hook to monitor phi values in the FailureDetector > --- > > Key: CASSANDRA-9526 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9526 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Ron Kuris >Assignee: Ron Kuris > Fix For: 2.2.x > > Attachments: Monitor-Phi-JMX.patch, Phi-Log-Debug-When-Close.patch, > Tiny-Race-Condition.patch > > > phi_convict_threshold can be tuned, but there's currently no way to monitor > the phi values to see if you're getting close. > The attached patch adds the ability to get these values via JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CASSANDRA-10463) Fix failing compaction tests
[ https://issues.apache.org/jira/browse/CASSANDRA-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Knighton resolved CASSANDRA-10463. --- Resolution: Fixed > Fix failing compaction tests > > > Key: CASSANDRA-10463 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10463 > Project: Cassandra > Issue Type: Sub-task >Reporter: Jim Witschey >Assignee: Yuki Morishita > Fix For: 3.0.0 rc2 > > > A bunch of compaction tests started failing after some changes to how logs > are handled in ccm: > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.compaction_throughput_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.data_size_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_alter_and_nodetool_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_alter_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_nodetool_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.disable_autocompaction_schema_test > - > compaction_test.TestCompaction_with_DateTieredCompactionStrategy.sstable_deletion_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.compaction_throughput_test > - compaction_test.TestCompaction_with_LeveledCompactionStrategy.data_size_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_alter_and_nodetool_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_alter_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_nodetool_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.disable_autocompaction_schema_test > - > compaction_test.TestCompaction_with_LeveledCompactionStrategy.sstable_deletion_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.compaction_throughput_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.data_size_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_alter_and_nodetool_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_alter_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_nodetool_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.disable_autocompaction_schema_test > - > compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.sstable_deletion_test > I haven't dug into it much, but it looks like the following tests: > - compaction_throughput_test > - data_size_test > - disable_autocompaction_alter_and_nodetool_test > - disable_autocompaction_alter_test > - disable_autocompaction_nodetool_test > - disable_autocompaction_schema_test > - sstable_deletion_test > grep logs to check if operations happened successfully, and that something in > the new log-handling code broke this. > I'm assigning [~yukim], since I believe you wrote the changes to ccm, but > feel free to find a new assignee. -- This message was sent by Atlassian JIRA (v6.3.4#6332)